UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

greybus: operation: make incomplete-message errors more informative 

Include the operation id as well as the received and expected size
(from header) when reporting incomplete messages.

This information is useful when debugging communication errors.

Also invert the size test to match the error message and increase
readability.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Johan Hovold 2015-03-27 12:41:20 +01:00 committed by Greg Kroah-Hartman
parent e1baa3f0a9
commit 0150bd7f23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/greybus/operation.c
View File

@ -899,8 +899,10 @@ void gb_connection_recv(struct gb_connection *connection,
header = data;
msg_size = le16_to_cpu(header->size);
if (msg_size > size) {
dev_err(&connection->dev, "incomplete message\n");
if (size < msg_size) {
dev_err(&connection->dev,
"incomplete message received: 0x%04x (%zu < %zu)\n",
le16_to_cpu(header->operation_id), size, msg_size);
return; /* XXX Should still complete operation */
}