mISDN: fix possible use-after-free in HFC_cleanup()
This module's remove path calls del_timer(). However, that function does not wait until the timer handler finishes. This means that the timer handler may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling del_timer_sync(), which makes sure the timer handler has finished, and unable to re-schedule itself. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
1c72e6ab66
commit
009fc857c5
|
@ -2342,7 +2342,7 @@ static void __exit
|
||||||
HFC_cleanup(void)
|
HFC_cleanup(void)
|
||||||
{
|
{
|
||||||
if (timer_pending(&hfc_tl))
|
if (timer_pending(&hfc_tl))
|
||||||
del_timer(&hfc_tl);
|
del_timer_sync(&hfc_tl);
|
||||||
|
|
||||||
pci_unregister_driver(&hfc_driver);
|
pci_unregister_driver(&hfc_driver);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue