scsi: ufs: Add a bsg endpoint that supports UPIUs
For now, just provide an API to allocate and remove ufs-bsg node. We
will use this framework to manage ufs devices by sending UPIU
transactions.
For the time being, implements an empty bsg_request() - will add some
more functionality in coming patches.
Nonetheless, we reveal here the protocol we are planning to use: UFS
Transport Protocol Transactions. UFS transactions consist of packets
called UFS Protocol Information Units (UPIU).
There are UPIU’s defined for UFS SCSI commands, responses, data in and
data out, task management, utility functions, vendor functions,
transaction synchronization and control, and more.
By using UPIUs, we get access to the most fine-grained internals of this
protocol, and able to communicate with the device in ways, that are
sometimes beyond the capacity of the ufs driver.
Moreover and as a result, our core structure - ufs_bsg_node has a pretty
lean structure: using upiu transactions that contains the outmost
detailed info, so we don't really need complex constructs to support it.
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-10-07 22:30:35 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
/*
|
|
|
|
* bsg endpoint that supports UPIUs
|
|
|
|
*
|
|
|
|
* Copyright (C) 2018 Western Digital Corporation
|
|
|
|
*/
|
|
|
|
#include "ufs_bsg.h"
|
|
|
|
|
2018-10-07 22:30:38 +08:00
|
|
|
static int ufs_bsg_get_query_desc_size(struct ufs_hba *hba, int *desc_len,
|
|
|
|
struct utp_upiu_query *qr)
|
|
|
|
{
|
|
|
|
int desc_size = be16_to_cpu(qr->length);
|
|
|
|
int desc_id = qr->idn;
|
|
|
|
|
|
|
|
if (desc_size <= 0)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2020-06-03 17:19:58 +08:00
|
|
|
ufshcd_map_desc_id_to_length(hba, desc_id, desc_len);
|
|
|
|
if (!*desc_len)
|
2018-10-07 22:30:38 +08:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
*desc_len = min_t(int, *desc_len, desc_size);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ufs_bsg_verify_query_size(struct ufs_hba *hba,
|
|
|
|
unsigned int request_len,
|
2019-02-20 15:11:12 +08:00
|
|
|
unsigned int reply_len)
|
2018-10-07 22:30:38 +08:00
|
|
|
{
|
|
|
|
int min_req_len = sizeof(struct ufs_bsg_request);
|
|
|
|
int min_rsp_len = sizeof(struct ufs_bsg_reply);
|
|
|
|
|
|
|
|
if (min_req_len > request_len || min_rsp_len > reply_len) {
|
|
|
|
dev_err(hba->dev, "not enough space assigned\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-02-20 15:11:12 +08:00
|
|
|
static int ufs_bsg_alloc_desc_buffer(struct ufs_hba *hba, struct bsg_job *job,
|
|
|
|
uint8_t **desc_buff, int *desc_len,
|
|
|
|
enum query_opcode desc_op)
|
2018-10-07 22:30:38 +08:00
|
|
|
{
|
2019-02-20 15:11:12 +08:00
|
|
|
struct ufs_bsg_request *bsg_request = job->request;
|
2018-10-07 22:30:38 +08:00
|
|
|
struct utp_upiu_query *qr;
|
2019-02-20 15:11:12 +08:00
|
|
|
u8 *descp;
|
2018-10-07 22:30:38 +08:00
|
|
|
|
2019-02-20 15:11:14 +08:00
|
|
|
if (desc_op != UPIU_QUERY_OPCODE_WRITE_DESC &&
|
|
|
|
desc_op != UPIU_QUERY_OPCODE_READ_DESC)
|
2018-10-07 22:30:38 +08:00
|
|
|
goto out;
|
|
|
|
|
|
|
|
qr = &bsg_request->upiu_req.qr;
|
|
|
|
if (ufs_bsg_get_query_desc_size(hba, desc_len, qr)) {
|
|
|
|
dev_err(hba->dev, "Illegal desc size\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2019-02-20 15:11:12 +08:00
|
|
|
if (*desc_len > job->request_payload.payload_len) {
|
|
|
|
dev_err(hba->dev, "Illegal desc size\n");
|
2018-10-07 22:30:38 +08:00
|
|
|
return -EINVAL;
|
2019-02-20 15:11:12 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
descp = kzalloc(*desc_len, GFP_KERNEL);
|
|
|
|
if (!descp)
|
|
|
|
return -ENOMEM;
|
2018-10-07 22:30:38 +08:00
|
|
|
|
2019-02-20 15:11:14 +08:00
|
|
|
if (desc_op == UPIU_QUERY_OPCODE_WRITE_DESC)
|
|
|
|
sg_copy_to_buffer(job->request_payload.sg_list,
|
|
|
|
job->request_payload.sg_cnt, descp,
|
|
|
|
*desc_len);
|
2019-02-20 15:11:12 +08:00
|
|
|
|
|
|
|
*desc_buff = descp;
|
2018-10-07 22:30:38 +08:00
|
|
|
|
|
|
|
out:
|
|
|
|
return 0;
|
|
|
|
}
|
scsi: ufs: Add a bsg endpoint that supports UPIUs
For now, just provide an API to allocate and remove ufs-bsg node. We
will use this framework to manage ufs devices by sending UPIU
transactions.
For the time being, implements an empty bsg_request() - will add some
more functionality in coming patches.
Nonetheless, we reveal here the protocol we are planning to use: UFS
Transport Protocol Transactions. UFS transactions consist of packets
called UFS Protocol Information Units (UPIU).
There are UPIU’s defined for UFS SCSI commands, responses, data in and
data out, task management, utility functions, vendor functions,
transaction synchronization and control, and more.
By using UPIUs, we get access to the most fine-grained internals of this
protocol, and able to communicate with the device in ways, that are
sometimes beyond the capacity of the ufs driver.
Moreover and as a result, our core structure - ufs_bsg_node has a pretty
lean structure: using upiu transactions that contains the outmost
detailed info, so we don't really need complex constructs to support it.
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-10-07 22:30:35 +08:00
|
|
|
|
|
|
|
static int ufs_bsg_request(struct bsg_job *job)
|
|
|
|
{
|
|
|
|
struct ufs_bsg_request *bsg_request = job->request;
|
|
|
|
struct ufs_bsg_reply *bsg_reply = job->reply;
|
2018-10-07 22:30:38 +08:00
|
|
|
struct ufs_hba *hba = shost_priv(dev_to_shost(job->dev->parent));
|
|
|
|
unsigned int req_len = job->request_len;
|
|
|
|
unsigned int reply_len = job->reply_len;
|
2018-10-07 22:30:39 +08:00
|
|
|
struct uic_command uc = {};
|
2018-10-07 22:30:38 +08:00
|
|
|
int msgcode;
|
|
|
|
uint8_t *desc_buff = NULL;
|
|
|
|
int desc_len = 0;
|
|
|
|
enum query_opcode desc_op = UPIU_QUERY_OPCODE_NOP;
|
|
|
|
int ret;
|
|
|
|
|
2019-02-20 15:11:12 +08:00
|
|
|
ret = ufs_bsg_verify_query_size(hba, req_len, reply_len);
|
2018-10-07 22:30:38 +08:00
|
|
|
if (ret)
|
|
|
|
goto out;
|
scsi: ufs: Add a bsg endpoint that supports UPIUs
For now, just provide an API to allocate and remove ufs-bsg node. We
will use this framework to manage ufs devices by sending UPIU
transactions.
For the time being, implements an empty bsg_request() - will add some
more functionality in coming patches.
Nonetheless, we reveal here the protocol we are planning to use: UFS
Transport Protocol Transactions. UFS transactions consist of packets
called UFS Protocol Information Units (UPIU).
There are UPIU’s defined for UFS SCSI commands, responses, data in and
data out, task management, utility functions, vendor functions,
transaction synchronization and control, and more.
By using UPIUs, we get access to the most fine-grained internals of this
protocol, and able to communicate with the device in ways, that are
sometimes beyond the capacity of the ufs driver.
Moreover and as a result, our core structure - ufs_bsg_node has a pretty
lean structure: using upiu transactions that contains the outmost
detailed info, so we don't really need complex constructs to support it.
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-10-07 22:30:35 +08:00
|
|
|
|
|
|
|
bsg_reply->reply_payload_rcv_len = 0;
|
|
|
|
|
2019-10-10 16:31:07 +08:00
|
|
|
pm_runtime_get_sync(hba->dev);
|
|
|
|
|
2018-10-07 22:30:38 +08:00
|
|
|
msgcode = bsg_request->msgcode;
|
|
|
|
switch (msgcode) {
|
|
|
|
case UPIU_TRANSACTION_QUERY_REQ:
|
|
|
|
desc_op = bsg_request->upiu_req.qr.opcode;
|
2019-02-20 15:11:12 +08:00
|
|
|
ret = ufs_bsg_alloc_desc_buffer(hba, job, &desc_buff,
|
|
|
|
&desc_len, desc_op);
|
2020-05-22 12:59:29 +08:00
|
|
|
if (ret) {
|
|
|
|
pm_runtime_put_sync(hba->dev);
|
2018-10-07 22:30:38 +08:00
|
|
|
goto out;
|
2020-05-22 12:59:29 +08:00
|
|
|
}
|
2018-10-07 22:30:38 +08:00
|
|
|
|
2020-08-24 06:36:59 +08:00
|
|
|
fallthrough;
|
2018-10-07 22:30:38 +08:00
|
|
|
case UPIU_TRANSACTION_NOP_OUT:
|
|
|
|
case UPIU_TRANSACTION_TASK_REQ:
|
|
|
|
ret = ufshcd_exec_raw_upiu_cmd(hba, &bsg_request->upiu_req,
|
|
|
|
&bsg_reply->upiu_rsp, msgcode,
|
|
|
|
desc_buff, &desc_len, desc_op);
|
|
|
|
if (ret)
|
|
|
|
dev_err(hba->dev,
|
|
|
|
"exe raw upiu: error code %d\n", ret);
|
|
|
|
|
2018-10-07 22:30:39 +08:00
|
|
|
break;
|
|
|
|
case UPIU_TRANSACTION_UIC_CMD:
|
|
|
|
memcpy(&uc, &bsg_request->upiu_req.uc, UIC_CMD_SIZE);
|
|
|
|
ret = ufshcd_send_uic_cmd(hba, &uc);
|
|
|
|
if (ret)
|
2019-06-24 01:38:39 +08:00
|
|
|
dev_err(hba->dev,
|
2018-10-07 22:30:39 +08:00
|
|
|
"send uic cmd: error code %d\n", ret);
|
|
|
|
|
|
|
|
memcpy(&bsg_reply->upiu_rsp.uc, &uc, UIC_CMD_SIZE);
|
|
|
|
|
2018-10-07 22:30:38 +08:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
ret = -ENOTSUPP;
|
|
|
|
dev_err(hba->dev, "unsupported msgcode 0x%x\n", msgcode);
|
|
|
|
|
|
|
|
break;
|
|
|
|
}
|
scsi: ufs: Add a bsg endpoint that supports UPIUs
For now, just provide an API to allocate and remove ufs-bsg node. We
will use this framework to manage ufs devices by sending UPIU
transactions.
For the time being, implements an empty bsg_request() - will add some
more functionality in coming patches.
Nonetheless, we reveal here the protocol we are planning to use: UFS
Transport Protocol Transactions. UFS transactions consist of packets
called UFS Protocol Information Units (UPIU).
There are UPIU’s defined for UFS SCSI commands, responses, data in and
data out, task management, utility functions, vendor functions,
transaction synchronization and control, and more.
By using UPIUs, we get access to the most fine-grained internals of this
protocol, and able to communicate with the device in ways, that are
sometimes beyond the capacity of the ufs driver.
Moreover and as a result, our core structure - ufs_bsg_node has a pretty
lean structure: using upiu transactions that contains the outmost
detailed info, so we don't really need complex constructs to support it.
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-10-07 22:30:35 +08:00
|
|
|
|
2019-10-10 16:31:07 +08:00
|
|
|
pm_runtime_put_sync(hba->dev);
|
|
|
|
|
2019-02-20 15:11:12 +08:00
|
|
|
if (!desc_buff)
|
|
|
|
goto out;
|
|
|
|
|
2019-02-20 15:11:14 +08:00
|
|
|
if (desc_op == UPIU_QUERY_OPCODE_READ_DESC && desc_len)
|
|
|
|
bsg_reply->reply_payload_rcv_len =
|
|
|
|
sg_copy_from_buffer(job->request_payload.sg_list,
|
|
|
|
job->request_payload.sg_cnt,
|
|
|
|
desc_buff, desc_len);
|
|
|
|
|
2019-02-20 15:11:12 +08:00
|
|
|
kfree(desc_buff);
|
|
|
|
|
2018-10-07 22:30:38 +08:00
|
|
|
out:
|
scsi: ufs: Add a bsg endpoint that supports UPIUs
For now, just provide an API to allocate and remove ufs-bsg node. We
will use this framework to manage ufs devices by sending UPIU
transactions.
For the time being, implements an empty bsg_request() - will add some
more functionality in coming patches.
Nonetheless, we reveal here the protocol we are planning to use: UFS
Transport Protocol Transactions. UFS transactions consist of packets
called UFS Protocol Information Units (UPIU).
There are UPIU’s defined for UFS SCSI commands, responses, data in and
data out, task management, utility functions, vendor functions,
transaction synchronization and control, and more.
By using UPIUs, we get access to the most fine-grained internals of this
protocol, and able to communicate with the device in ways, that are
sometimes beyond the capacity of the ufs driver.
Moreover and as a result, our core structure - ufs_bsg_node has a pretty
lean structure: using upiu transactions that contains the outmost
detailed info, so we don't really need complex constructs to support it.
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-10-07 22:30:35 +08:00
|
|
|
bsg_reply->result = ret;
|
2019-02-20 15:11:12 +08:00
|
|
|
job->reply_len = sizeof(struct ufs_bsg_reply);
|
2019-06-24 01:38:56 +08:00
|
|
|
/* complete the job here only if no error */
|
|
|
|
if (ret == 0)
|
|
|
|
bsg_job_done(job, ret, bsg_reply->reply_payload_rcv_len);
|
scsi: ufs: Add a bsg endpoint that supports UPIUs
For now, just provide an API to allocate and remove ufs-bsg node. We
will use this framework to manage ufs devices by sending UPIU
transactions.
For the time being, implements an empty bsg_request() - will add some
more functionality in coming patches.
Nonetheless, we reveal here the protocol we are planning to use: UFS
Transport Protocol Transactions. UFS transactions consist of packets
called UFS Protocol Information Units (UPIU).
There are UPIU’s defined for UFS SCSI commands, responses, data in and
data out, task management, utility functions, vendor functions,
transaction synchronization and control, and more.
By using UPIUs, we get access to the most fine-grained internals of this
protocol, and able to communicate with the device in ways, that are
sometimes beyond the capacity of the ufs driver.
Moreover and as a result, our core structure - ufs_bsg_node has a pretty
lean structure: using upiu transactions that contains the outmost
detailed info, so we don't really need complex constructs to support it.
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-10-07 22:30:35 +08:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* ufs_bsg_remove - detach and remove the added ufs-bsg node
|
2019-10-30 07:07:08 +08:00
|
|
|
* @hba: per adapter object
|
scsi: ufs: Add a bsg endpoint that supports UPIUs
For now, just provide an API to allocate and remove ufs-bsg node. We
will use this framework to manage ufs devices by sending UPIU
transactions.
For the time being, implements an empty bsg_request() - will add some
more functionality in coming patches.
Nonetheless, we reveal here the protocol we are planning to use: UFS
Transport Protocol Transactions. UFS transactions consist of packets
called UFS Protocol Information Units (UPIU).
There are UPIU’s defined for UFS SCSI commands, responses, data in and
data out, task management, utility functions, vendor functions,
transaction synchronization and control, and more.
By using UPIUs, we get access to the most fine-grained internals of this
protocol, and able to communicate with the device in ways, that are
sometimes beyond the capacity of the ufs driver.
Moreover and as a result, our core structure - ufs_bsg_node has a pretty
lean structure: using upiu transactions that contains the outmost
detailed info, so we don't really need complex constructs to support it.
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-10-07 22:30:35 +08:00
|
|
|
*
|
|
|
|
* Should be called when unloading the driver.
|
|
|
|
*/
|
|
|
|
void ufs_bsg_remove(struct ufs_hba *hba)
|
|
|
|
{
|
|
|
|
struct device *bsg_dev = &hba->bsg_dev;
|
|
|
|
|
|
|
|
if (!hba->bsg_queue)
|
|
|
|
return;
|
|
|
|
|
2018-10-27 01:27:02 +08:00
|
|
|
bsg_remove_queue(hba->bsg_queue);
|
scsi: ufs: Add a bsg endpoint that supports UPIUs
For now, just provide an API to allocate and remove ufs-bsg node. We
will use this framework to manage ufs devices by sending UPIU
transactions.
For the time being, implements an empty bsg_request() - will add some
more functionality in coming patches.
Nonetheless, we reveal here the protocol we are planning to use: UFS
Transport Protocol Transactions. UFS transactions consist of packets
called UFS Protocol Information Units (UPIU).
There are UPIU’s defined for UFS SCSI commands, responses, data in and
data out, task management, utility functions, vendor functions,
transaction synchronization and control, and more.
By using UPIUs, we get access to the most fine-grained internals of this
protocol, and able to communicate with the device in ways, that are
sometimes beyond the capacity of the ufs driver.
Moreover and as a result, our core structure - ufs_bsg_node has a pretty
lean structure: using upiu transactions that contains the outmost
detailed info, so we don't really need complex constructs to support it.
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-10-07 22:30:35 +08:00
|
|
|
|
|
|
|
device_del(bsg_dev);
|
|
|
|
put_device(bsg_dev);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void ufs_bsg_node_release(struct device *dev)
|
|
|
|
{
|
|
|
|
put_device(dev->parent);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* ufs_bsg_probe - Add ufs bsg device node
|
|
|
|
* @hba: per adapter object
|
|
|
|
*
|
|
|
|
* Called during initial loading of the driver, and before scsi_scan_host.
|
|
|
|
*/
|
|
|
|
int ufs_bsg_probe(struct ufs_hba *hba)
|
|
|
|
{
|
|
|
|
struct device *bsg_dev = &hba->bsg_dev;
|
|
|
|
struct Scsi_Host *shost = hba->host;
|
|
|
|
struct device *parent = &shost->shost_gendev;
|
|
|
|
struct request_queue *q;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
device_initialize(bsg_dev);
|
|
|
|
|
|
|
|
bsg_dev->parent = get_device(parent);
|
|
|
|
bsg_dev->release = ufs_bsg_node_release;
|
|
|
|
|
2019-12-03 14:58:40 +08:00
|
|
|
dev_set_name(bsg_dev, "ufs-bsg%u", shost->host_no);
|
scsi: ufs: Add a bsg endpoint that supports UPIUs
For now, just provide an API to allocate and remove ufs-bsg node. We
will use this framework to manage ufs devices by sending UPIU
transactions.
For the time being, implements an empty bsg_request() - will add some
more functionality in coming patches.
Nonetheless, we reveal here the protocol we are planning to use: UFS
Transport Protocol Transactions. UFS transactions consist of packets
called UFS Protocol Information Units (UPIU).
There are UPIU’s defined for UFS SCSI commands, responses, data in and
data out, task management, utility functions, vendor functions,
transaction synchronization and control, and more.
By using UPIUs, we get access to the most fine-grained internals of this
protocol, and able to communicate with the device in ways, that are
sometimes beyond the capacity of the ufs driver.
Moreover and as a result, our core structure - ufs_bsg_node has a pretty
lean structure: using upiu transactions that contains the outmost
detailed info, so we don't really need complex constructs to support it.
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-10-07 22:30:35 +08:00
|
|
|
|
|
|
|
ret = device_add(bsg_dev);
|
|
|
|
if (ret)
|
|
|
|
goto out;
|
|
|
|
|
2018-10-27 01:26:25 +08:00
|
|
|
q = bsg_setup_queue(bsg_dev, dev_name(bsg_dev), ufs_bsg_request, NULL, 0);
|
scsi: ufs: Add a bsg endpoint that supports UPIUs
For now, just provide an API to allocate and remove ufs-bsg node. We
will use this framework to manage ufs devices by sending UPIU
transactions.
For the time being, implements an empty bsg_request() - will add some
more functionality in coming patches.
Nonetheless, we reveal here the protocol we are planning to use: UFS
Transport Protocol Transactions. UFS transactions consist of packets
called UFS Protocol Information Units (UPIU).
There are UPIU’s defined for UFS SCSI commands, responses, data in and
data out, task management, utility functions, vendor functions,
transaction synchronization and control, and more.
By using UPIUs, we get access to the most fine-grained internals of this
protocol, and able to communicate with the device in ways, that are
sometimes beyond the capacity of the ufs driver.
Moreover and as a result, our core structure - ufs_bsg_node has a pretty
lean structure: using upiu transactions that contains the outmost
detailed info, so we don't really need complex constructs to support it.
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-10-07 22:30:35 +08:00
|
|
|
if (IS_ERR(q)) {
|
|
|
|
ret = PTR_ERR(q);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
hba->bsg_queue = q;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
out:
|
|
|
|
dev_err(bsg_dev, "fail to initialize a bsg dev %d\n", shost->host_no);
|
|
|
|
put_device(bsg_dev);
|
|
|
|
return ret;
|
|
|
|
}
|