2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* Copyright (C)2003,2004 USAGI/WIDE Project
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
2007-02-09 22:24:49 +08:00
|
|
|
*
|
2005-04-17 06:20:36 +08:00
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
2007-02-09 22:24:49 +08:00
|
|
|
*
|
2005-04-17 06:20:36 +08:00
|
|
|
* You should have received a copy of the GNU General Public License
|
2013-12-07 01:13:39 +08:00
|
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
2005-04-17 06:20:36 +08:00
|
|
|
*
|
|
|
|
* Authors Mitsuru KANDA <mk@linux-ipv6.org>
|
2014-08-25 04:53:10 +08:00
|
|
|
* YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
2005-04-17 06:20:36 +08:00
|
|
|
*
|
|
|
|
* Based on net/ipv4/xfrm4_tunnel.c
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/xfrm.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 16:04:11 +08:00
|
|
|
#include <linux/slab.h>
|
2009-10-24 02:19:19 +08:00
|
|
|
#include <linux/rculist.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
#include <net/ip.h>
|
|
|
|
#include <net/xfrm.h>
|
|
|
|
#include <net/ipv6.h>
|
|
|
|
#include <linux/ipv6.h>
|
|
|
|
#include <linux/icmpv6.h>
|
2006-03-21 14:33:17 +08:00
|
|
|
#include <linux/mutex.h>
|
2010-01-25 18:37:54 +08:00
|
|
|
#include <net/netns/generic.h>
|
|
|
|
|
|
|
|
#define XFRM6_TUNNEL_SPI_BYADDR_HSIZE 256
|
|
|
|
#define XFRM6_TUNNEL_SPI_BYSPI_HSIZE 256
|
|
|
|
|
|
|
|
#define XFRM6_TUNNEL_SPI_MIN 1
|
|
|
|
#define XFRM6_TUNNEL_SPI_MAX 0xffffffff
|
|
|
|
|
|
|
|
struct xfrm6_tunnel_net {
|
|
|
|
struct hlist_head spi_byaddr[XFRM6_TUNNEL_SPI_BYADDR_HSIZE];
|
|
|
|
struct hlist_head spi_byspi[XFRM6_TUNNEL_SPI_BYSPI_HSIZE];
|
|
|
|
u32 spi;
|
|
|
|
};
|
|
|
|
|
netns: make struct pernet_operations::id unsigned int
Make struct pernet_operations::id unsigned.
There are 2 reasons to do so:
1)
This field is really an index into an zero based array and
thus is unsigned entity. Using negative value is out-of-bound
access by definition.
2)
On x86_64 unsigned 32-bit data which are mixed with pointers
via array indexing or offsets added or subtracted to pointers
are preffered to signed 32-bit data.
"int" being used as an array index needs to be sign-extended
to 64-bit before being used.
void f(long *p, int i)
{
g(p[i]);
}
roughly translates to
movsx rsi, esi
mov rdi, [rsi+...]
call g
MOVSX is 3 byte instruction which isn't necessary if the variable is
unsigned because x86_64 is zero extending by default.
Now, there is net_generic() function which, you guessed it right, uses
"int" as an array index:
static inline void *net_generic(const struct net *net, int id)
{
...
ptr = ng->ptr[id - 1];
...
}
And this function is used a lot, so those sign extensions add up.
Patch snipes ~1730 bytes on allyesconfig kernel (without all junk
messing with code generation):
add/remove: 0/0 grow/shrink: 70/598 up/down: 396/-2126 (-1730)
Unfortunately some functions actually grow bigger.
This is a semmingly random artefact of code generation with register
allocator being used differently. gcc decides that some variable
needs to live in new r8+ registers and every access now requires REX
prefix. Or it is shifted into r12, so [r12+0] addressing mode has to be
used which is longer than [r8]
However, overall balance is in negative direction:
add/remove: 0/0 grow/shrink: 70/598 up/down: 396/-2126 (-1730)
function old new delta
nfsd4_lock 3886 3959 +73
tipc_link_build_proto_msg 1096 1140 +44
mac80211_hwsim_new_radio 2776 2808 +32
tipc_mon_rcv 1032 1058 +26
svcauth_gss_legacy_init 1413 1429 +16
tipc_bcbase_select_primary 379 392 +13
nfsd4_exchange_id 1247 1260 +13
nfsd4_setclientid_confirm 782 793 +11
...
put_client_renew_locked 494 480 -14
ip_set_sockfn_get 730 716 -14
geneve_sock_add 829 813 -16
nfsd4_sequence_done 721 703 -18
nlmclnt_lookup_host 708 686 -22
nfsd4_lockt 1085 1063 -22
nfs_get_client 1077 1050 -27
tcf_bpf_init 1106 1076 -30
nfsd4_encode_fattr 5997 5930 -67
Total: Before=154856051, After=154854321, chg -0.00%
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-11-17 09:58:21 +08:00
|
|
|
static unsigned int xfrm6_tunnel_net_id __read_mostly;
|
2010-01-25 18:37:54 +08:00
|
|
|
static inline struct xfrm6_tunnel_net *xfrm6_tunnel_pernet(struct net *net)
|
|
|
|
{
|
|
|
|
return net_generic(net, xfrm6_tunnel_net_id);
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
/*
|
2007-02-09 22:24:49 +08:00
|
|
|
* xfrm_tunnel_spi things are for allocating unique id ("spi")
|
2005-04-17 06:20:36 +08:00
|
|
|
* per xfrm_address_t.
|
|
|
|
*/
|
|
|
|
struct xfrm6_tunnel_spi {
|
2009-10-24 02:19:19 +08:00
|
|
|
struct hlist_node list_byaddr;
|
|
|
|
struct hlist_node list_byspi;
|
|
|
|
xfrm_address_t addr;
|
|
|
|
u32 spi;
|
2017-07-04 14:34:59 +08:00
|
|
|
refcount_t refcnt;
|
2009-10-24 02:19:19 +08:00
|
|
|
struct rcu_head rcu_head;
|
2005-04-17 06:20:36 +08:00
|
|
|
};
|
|
|
|
|
2009-10-24 02:19:19 +08:00
|
|
|
static DEFINE_SPINLOCK(xfrm6_tunnel_spi_lock);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2006-12-07 12:33:20 +08:00
|
|
|
static struct kmem_cache *xfrm6_tunnel_spi_kmem __read_mostly;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-04-15 13:58:06 +08:00
|
|
|
static inline unsigned int xfrm6_tunnel_spi_hash_byaddr(const xfrm_address_t *addr)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2012-04-15 13:58:06 +08:00
|
|
|
unsigned int h;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2013-01-13 13:02:38 +08:00
|
|
|
h = ipv6_addr_hash((const struct in6_addr *)addr);
|
2005-04-17 06:20:36 +08:00
|
|
|
h ^= h >> 16;
|
|
|
|
h ^= h >> 8;
|
|
|
|
h &= XFRM6_TUNNEL_SPI_BYADDR_HSIZE - 1;
|
|
|
|
|
|
|
|
return h;
|
|
|
|
}
|
|
|
|
|
2012-04-15 13:58:06 +08:00
|
|
|
static inline unsigned int xfrm6_tunnel_spi_hash_byspi(u32 spi)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
return spi % XFRM6_TUNNEL_SPI_BYSPI_HSIZE;
|
|
|
|
}
|
|
|
|
|
2011-04-22 12:53:02 +08:00
|
|
|
static struct xfrm6_tunnel_spi *__xfrm6_tunnel_spi_lookup(struct net *net, const xfrm_address_t *saddr)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2010-01-25 18:37:54 +08:00
|
|
|
struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net);
|
2005-04-17 06:20:36 +08:00
|
|
|
struct xfrm6_tunnel_spi *x6spi;
|
|
|
|
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:06:00 +08:00
|
|
|
hlist_for_each_entry_rcu(x6spi,
|
2010-01-25 18:37:54 +08:00
|
|
|
&xfrm6_tn->spi_byaddr[xfrm6_tunnel_spi_hash_byaddr(saddr)],
|
2005-04-17 06:20:36 +08:00
|
|
|
list_byaddr) {
|
2013-01-29 20:48:31 +08:00
|
|
|
if (xfrm6_addr_equal(&x6spi->addr, saddr))
|
2005-04-17 06:20:36 +08:00
|
|
|
return x6spi;
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2011-04-22 12:53:02 +08:00
|
|
|
__be32 xfrm6_tunnel_spi_lookup(struct net *net, const xfrm_address_t *saddr)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct xfrm6_tunnel_spi *x6spi;
|
|
|
|
u32 spi;
|
|
|
|
|
2009-10-24 02:19:19 +08:00
|
|
|
rcu_read_lock_bh();
|
2010-01-25 18:37:54 +08:00
|
|
|
x6spi = __xfrm6_tunnel_spi_lookup(net, saddr);
|
2005-04-17 06:20:36 +08:00
|
|
|
spi = x6spi ? x6spi->spi : 0;
|
2009-10-24 02:19:19 +08:00
|
|
|
rcu_read_unlock_bh();
|
2006-11-02 07:28:58 +08:00
|
|
|
return htonl(spi);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(xfrm6_tunnel_spi_lookup);
|
|
|
|
|
2010-01-25 18:37:54 +08:00
|
|
|
static int __xfrm6_tunnel_spi_check(struct net *net, u32 spi)
|
2008-02-19 21:54:00 +08:00
|
|
|
{
|
2010-01-25 18:37:54 +08:00
|
|
|
struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net);
|
2008-02-19 21:54:00 +08:00
|
|
|
struct xfrm6_tunnel_spi *x6spi;
|
|
|
|
int index = xfrm6_tunnel_spi_hash_byspi(spi);
|
|
|
|
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:06:00 +08:00
|
|
|
hlist_for_each_entry(x6spi,
|
2010-01-25 18:37:54 +08:00
|
|
|
&xfrm6_tn->spi_byspi[index],
|
2008-02-19 21:54:00 +08:00
|
|
|
list_byspi) {
|
|
|
|
if (x6spi->spi == spi)
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
return index;
|
|
|
|
}
|
|
|
|
|
2010-01-25 18:37:54 +08:00
|
|
|
static u32 __xfrm6_tunnel_alloc_spi(struct net *net, xfrm_address_t *saddr)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2010-01-25 18:37:54 +08:00
|
|
|
struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net);
|
2005-04-17 06:20:36 +08:00
|
|
|
u32 spi;
|
|
|
|
struct xfrm6_tunnel_spi *x6spi;
|
2008-02-19 21:54:00 +08:00
|
|
|
int index;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-01-25 18:37:54 +08:00
|
|
|
if (xfrm6_tn->spi < XFRM6_TUNNEL_SPI_MIN ||
|
|
|
|
xfrm6_tn->spi >= XFRM6_TUNNEL_SPI_MAX)
|
|
|
|
xfrm6_tn->spi = XFRM6_TUNNEL_SPI_MIN;
|
2005-04-17 06:20:36 +08:00
|
|
|
else
|
2010-01-25 18:37:54 +08:00
|
|
|
xfrm6_tn->spi++;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-01-25 18:37:54 +08:00
|
|
|
for (spi = xfrm6_tn->spi; spi <= XFRM6_TUNNEL_SPI_MAX; spi++) {
|
|
|
|
index = __xfrm6_tunnel_spi_check(net, spi);
|
2008-02-19 21:54:00 +08:00
|
|
|
if (index >= 0)
|
|
|
|
goto alloc_spi;
|
2018-12-19 14:45:09 +08:00
|
|
|
|
|
|
|
if (spi == XFRM6_TUNNEL_SPI_MAX)
|
|
|
|
break;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2010-01-25 18:37:54 +08:00
|
|
|
for (spi = XFRM6_TUNNEL_SPI_MIN; spi < xfrm6_tn->spi; spi++) {
|
|
|
|
index = __xfrm6_tunnel_spi_check(net, spi);
|
2008-02-19 21:54:00 +08:00
|
|
|
if (index >= 0)
|
|
|
|
goto alloc_spi;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
spi = 0;
|
|
|
|
goto out;
|
|
|
|
alloc_spi:
|
2010-01-25 18:37:54 +08:00
|
|
|
xfrm6_tn->spi = spi;
|
2006-12-07 12:33:16 +08:00
|
|
|
x6spi = kmem_cache_alloc(xfrm6_tunnel_spi_kmem, GFP_ATOMIC);
|
2006-07-25 04:49:06 +08:00
|
|
|
if (!x6spi)
|
2005-04-17 06:20:36 +08:00
|
|
|
goto out;
|
2006-07-25 04:49:06 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
memcpy(&x6spi->addr, saddr, sizeof(x6spi->addr));
|
|
|
|
x6spi->spi = spi;
|
2017-07-04 14:34:59 +08:00
|
|
|
refcount_set(&x6spi->refcnt, 1);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-01-25 18:37:54 +08:00
|
|
|
hlist_add_head_rcu(&x6spi->list_byspi, &xfrm6_tn->spi_byspi[index]);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
index = xfrm6_tunnel_spi_hash_byaddr(saddr);
|
2010-01-25 18:37:54 +08:00
|
|
|
hlist_add_head_rcu(&x6spi->list_byaddr, &xfrm6_tn->spi_byaddr[index]);
|
2005-04-17 06:20:36 +08:00
|
|
|
out:
|
|
|
|
return spi;
|
|
|
|
}
|
|
|
|
|
2010-01-25 18:37:54 +08:00
|
|
|
__be32 xfrm6_tunnel_alloc_spi(struct net *net, xfrm_address_t *saddr)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct xfrm6_tunnel_spi *x6spi;
|
|
|
|
u32 spi;
|
|
|
|
|
2009-10-24 02:19:19 +08:00
|
|
|
spin_lock_bh(&xfrm6_tunnel_spi_lock);
|
2010-01-25 18:37:54 +08:00
|
|
|
x6spi = __xfrm6_tunnel_spi_lookup(net, saddr);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (x6spi) {
|
2017-07-04 14:34:59 +08:00
|
|
|
refcount_inc(&x6spi->refcnt);
|
2005-04-17 06:20:36 +08:00
|
|
|
spi = x6spi->spi;
|
|
|
|
} else
|
2010-01-25 18:37:54 +08:00
|
|
|
spi = __xfrm6_tunnel_alloc_spi(net, saddr);
|
2009-10-24 02:19:19 +08:00
|
|
|
spin_unlock_bh(&xfrm6_tunnel_spi_lock);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2006-11-02 07:28:58 +08:00
|
|
|
return htonl(spi);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(xfrm6_tunnel_alloc_spi);
|
|
|
|
|
2009-10-24 02:19:19 +08:00
|
|
|
static void x6spi_destroy_rcu(struct rcu_head *head)
|
|
|
|
{
|
|
|
|
kmem_cache_free(xfrm6_tunnel_spi_kmem,
|
|
|
|
container_of(head, struct xfrm6_tunnel_spi, rcu_head));
|
|
|
|
}
|
|
|
|
|
2010-10-15 13:15:59 +08:00
|
|
|
static void xfrm6_tunnel_free_spi(struct net *net, xfrm_address_t *saddr)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2010-01-25 18:37:54 +08:00
|
|
|
struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net);
|
2005-04-17 06:20:36 +08:00
|
|
|
struct xfrm6_tunnel_spi *x6spi;
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:06:00 +08:00
|
|
|
struct hlist_node *n;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-10-24 02:19:19 +08:00
|
|
|
spin_lock_bh(&xfrm6_tunnel_spi_lock);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:06:00 +08:00
|
|
|
hlist_for_each_entry_safe(x6spi, n,
|
2010-01-25 18:37:54 +08:00
|
|
|
&xfrm6_tn->spi_byaddr[xfrm6_tunnel_spi_hash_byaddr(saddr)],
|
2005-04-17 06:20:36 +08:00
|
|
|
list_byaddr)
|
|
|
|
{
|
2013-01-29 20:48:31 +08:00
|
|
|
if (xfrm6_addr_equal(&x6spi->addr, saddr)) {
|
2017-07-04 14:34:59 +08:00
|
|
|
if (refcount_dec_and_test(&x6spi->refcnt)) {
|
2009-10-24 02:19:19 +08:00
|
|
|
hlist_del_rcu(&x6spi->list_byaddr);
|
|
|
|
hlist_del_rcu(&x6spi->list_byspi);
|
|
|
|
call_rcu(&x6spi->rcu_head, x6spi_destroy_rcu);
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2009-10-24 02:19:19 +08:00
|
|
|
spin_unlock_bh(&xfrm6_tunnel_spi_lock);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int xfrm6_tunnel_output(struct xfrm_state *x, struct sk_buff *skb)
|
|
|
|
{
|
2007-10-11 06:44:06 +08:00
|
|
|
skb_push(skb, -skb_network_offset(skb));
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-04-01 16:52:46 +08:00
|
|
|
static int xfrm6_tunnel_input(struct xfrm_state *x, struct sk_buff *skb)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2007-10-18 12:28:06 +08:00
|
|
|
return skb_network_header(skb)[IP6CB(skb)->nhoff];
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2006-03-28 17:12:13 +08:00
|
|
|
static int xfrm6_tunnel_rcv(struct sk_buff *skb)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2010-01-25 18:37:54 +08:00
|
|
|
struct net *net = dev_net(skb->dev);
|
2011-04-22 12:53:02 +08:00
|
|
|
const struct ipv6hdr *iph = ipv6_hdr(skb);
|
2006-09-28 09:48:18 +08:00
|
|
|
__be32 spi;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2011-04-22 12:53:02 +08:00
|
|
|
spi = xfrm6_tunnel_spi_lookup(net, (const xfrm_address_t *)&iph->saddr);
|
2016-09-19 22:17:57 +08:00
|
|
|
return xfrm6_rcv_spi(skb, IPPROTO_IPV6, spi, NULL);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2006-03-28 17:12:13 +08:00
|
|
|
static int xfrm6_tunnel_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
|
2009-06-23 19:31:07 +08:00
|
|
|
u8 type, u8 code, int offset, __be32 info)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
/* xfrm6_tunnel native err handling */
|
|
|
|
switch (type) {
|
2007-02-09 22:24:49 +08:00
|
|
|
case ICMPV6_DEST_UNREACH:
|
2005-04-17 06:20:36 +08:00
|
|
|
switch (code) {
|
2007-02-09 22:24:49 +08:00
|
|
|
case ICMPV6_NOROUTE:
|
2005-04-17 06:20:36 +08:00
|
|
|
case ICMPV6_ADM_PROHIBITED:
|
|
|
|
case ICMPV6_NOT_NEIGHBOUR:
|
|
|
|
case ICMPV6_ADDR_UNREACH:
|
|
|
|
case ICMPV6_PORT_UNREACH:
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case ICMPV6_PKT_TOOBIG:
|
|
|
|
break;
|
|
|
|
case ICMPV6_TIME_EXCEED:
|
|
|
|
switch (code) {
|
|
|
|
case ICMPV6_EXC_HOPLIMIT:
|
|
|
|
break;
|
|
|
|
case ICMPV6_EXC_FRAGTIME:
|
2007-02-09 22:24:49 +08:00
|
|
|
default:
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case ICMPV6_PARAMPROB:
|
|
|
|
switch (code) {
|
|
|
|
case ICMPV6_HDR_FIELD: break;
|
|
|
|
case ICMPV6_UNK_NEXTHDR: break;
|
|
|
|
case ICMPV6_UNK_OPTION: break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
2006-03-28 17:12:13 +08:00
|
|
|
|
|
|
|
return 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2005-06-21 04:18:08 +08:00
|
|
|
static int xfrm6_tunnel_init_state(struct xfrm_state *x)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2006-09-23 06:05:15 +08:00
|
|
|
if (x->props.mode != XFRM_MODE_TUNNEL)
|
2005-04-17 06:20:36 +08:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (x->encap)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
x->props.header_len = sizeof(struct ipv6hdr);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void xfrm6_tunnel_destroy(struct xfrm_state *x)
|
|
|
|
{
|
2010-01-25 18:37:54 +08:00
|
|
|
struct net *net = xs_net(x);
|
|
|
|
|
|
|
|
xfrm6_tunnel_free_spi(net, (xfrm_address_t *)&x->props.saddr);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2008-01-31 11:11:50 +08:00
|
|
|
static const struct xfrm_type xfrm6_tunnel_type = {
|
2005-04-17 06:20:36 +08:00
|
|
|
.description = "IP6IP6",
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.proto = IPPROTO_IPV6,
|
|
|
|
.init_state = xfrm6_tunnel_init_state,
|
|
|
|
.destructor = xfrm6_tunnel_destroy,
|
|
|
|
.input = xfrm6_tunnel_input,
|
|
|
|
.output = xfrm6_tunnel_output,
|
|
|
|
};
|
|
|
|
|
2010-08-30 18:27:10 +08:00
|
|
|
static struct xfrm6_tunnel xfrm6_tunnel_handler __read_mostly = {
|
2005-04-17 06:20:36 +08:00
|
|
|
.handler = xfrm6_tunnel_rcv,
|
2006-03-28 17:12:13 +08:00
|
|
|
.err_handler = xfrm6_tunnel_err,
|
|
|
|
.priority = 2,
|
2005-04-17 06:20:36 +08:00
|
|
|
};
|
|
|
|
|
2010-08-30 18:27:10 +08:00
|
|
|
static struct xfrm6_tunnel xfrm46_tunnel_handler __read_mostly = {
|
2007-02-14 04:55:55 +08:00
|
|
|
.handler = xfrm6_tunnel_rcv,
|
|
|
|
.err_handler = xfrm6_tunnel_err,
|
|
|
|
.priority = 2,
|
|
|
|
};
|
|
|
|
|
2010-01-25 18:37:54 +08:00
|
|
|
static int __net_init xfrm6_tunnel_net_init(struct net *net)
|
|
|
|
{
|
|
|
|
struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net);
|
|
|
|
unsigned int i;
|
|
|
|
|
|
|
|
for (i = 0; i < XFRM6_TUNNEL_SPI_BYADDR_HSIZE; i++)
|
|
|
|
INIT_HLIST_HEAD(&xfrm6_tn->spi_byaddr[i]);
|
|
|
|
for (i = 0; i < XFRM6_TUNNEL_SPI_BYSPI_HSIZE; i++)
|
|
|
|
INIT_HLIST_HEAD(&xfrm6_tn->spi_byspi[i]);
|
|
|
|
xfrm6_tn->spi = 0;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __net_exit xfrm6_tunnel_net_exit(struct net *net)
|
|
|
|
{
|
2017-11-13 03:34:03 +08:00
|
|
|
struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net);
|
|
|
|
unsigned int i;
|
|
|
|
|
2018-04-16 13:50:09 +08:00
|
|
|
xfrm_flush_gc();
|
xfrm: destroy xfrm_state synchronously on net exit path
xfrm_state_put() moves struct xfrm_state to the GC list
and schedules the GC work to clean it up. On net exit call
path, xfrm_state_flush() is called to clean up and
xfrm_flush_gc() is called to wait for the GC work to complete
before exit.
However, this doesn't work because one of the ->destructor(),
ipcomp_destroy(), schedules the same GC work again inside
the GC work. It is hard to wait for such a nested async
callback. This is also why syzbot still reports the following
warning:
WARNING: CPU: 1 PID: 33 at net/ipv6/xfrm6_tunnel.c:351 xfrm6_tunnel_net_exit+0x2cb/0x500 net/ipv6/xfrm6_tunnel.c:351
...
ops_exit_list.isra.0+0xb0/0x160 net/core/net_namespace.c:153
cleanup_net+0x51d/0xb10 net/core/net_namespace.c:551
process_one_work+0xd0c/0x1ce0 kernel/workqueue.c:2153
worker_thread+0x143/0x14a0 kernel/workqueue.c:2296
kthread+0x357/0x430 kernel/kthread.c:246
ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352
In fact, it is perfectly fine to bypass GC and destroy xfrm_state
synchronously on net exit call path, because it is in process context
and doesn't need a work struct to do any blocking work.
This patch introduces xfrm_state_put_sync() which simply bypasses
GC, and lets its callers to decide whether to use this synchronous
version. On net exit path, xfrm_state_fini() and
xfrm6_tunnel_net_exit() use it. And, as ipcomp_destroy() itself is
blocking, it can use xfrm_state_put_sync() directly too.
Also rename xfrm_state_gc_destroy() to ___xfrm_state_destroy() to
reflect this change.
Fixes: b48c05ab5d32 ("xfrm: Fix warning in xfrm6_tunnel_net_exit.")
Reported-and-tested-by: syzbot+e9aebef558e3ed673934@syzkaller.appspotmail.com
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
2019-02-01 05:05:49 +08:00
|
|
|
xfrm_state_flush(net, IPSEC_PROTO_ANY, false, true);
|
2018-04-16 13:50:09 +08:00
|
|
|
|
2017-11-13 03:34:03 +08:00
|
|
|
for (i = 0; i < XFRM6_TUNNEL_SPI_BYADDR_HSIZE; i++)
|
|
|
|
WARN_ON_ONCE(!hlist_empty(&xfrm6_tn->spi_byaddr[i]));
|
|
|
|
|
|
|
|
for (i = 0; i < XFRM6_TUNNEL_SPI_BYSPI_HSIZE; i++)
|
|
|
|
WARN_ON_ONCE(!hlist_empty(&xfrm6_tn->spi_byspi[i]));
|
2010-01-25 18:37:54 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct pernet_operations xfrm6_tunnel_net_ops = {
|
|
|
|
.init = xfrm6_tunnel_net_init,
|
|
|
|
.exit = xfrm6_tunnel_net_exit,
|
|
|
|
.id = &xfrm6_tunnel_net_id,
|
|
|
|
.size = sizeof(struct xfrm6_tunnel_net),
|
|
|
|
};
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
static int __init xfrm6_tunnel_init(void)
|
|
|
|
{
|
2010-01-25 18:28:21 +08:00
|
|
|
int rv;
|
|
|
|
|
2010-02-16 17:05:04 +08:00
|
|
|
xfrm6_tunnel_spi_kmem = kmem_cache_create("xfrm6_tunnel_spi",
|
|
|
|
sizeof(struct xfrm6_tunnel_spi),
|
|
|
|
0, SLAB_HWCACHE_ALIGN,
|
|
|
|
NULL);
|
|
|
|
if (!xfrm6_tunnel_spi_kmem)
|
|
|
|
return -ENOMEM;
|
|
|
|
rv = register_pernet_subsys(&xfrm6_tunnel_net_ops);
|
|
|
|
if (rv < 0)
|
|
|
|
goto out_pernet;
|
2010-01-25 18:28:21 +08:00
|
|
|
rv = xfrm_register_type(&xfrm6_tunnel_type, AF_INET6);
|
|
|
|
if (rv < 0)
|
2010-02-16 17:05:04 +08:00
|
|
|
goto out_type;
|
2010-01-25 18:28:21 +08:00
|
|
|
rv = xfrm6_tunnel_register(&xfrm6_tunnel_handler, AF_INET6);
|
|
|
|
if (rv < 0)
|
2010-02-16 17:05:04 +08:00
|
|
|
goto out_xfrm6;
|
2010-01-25 18:28:21 +08:00
|
|
|
rv = xfrm6_tunnel_register(&xfrm46_tunnel_handler, AF_INET);
|
|
|
|
if (rv < 0)
|
2010-02-16 17:05:04 +08:00
|
|
|
goto out_xfrm46;
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
2008-12-15 15:13:48 +08:00
|
|
|
|
2010-02-16 17:05:04 +08:00
|
|
|
out_xfrm46:
|
2008-12-15 15:13:48 +08:00
|
|
|
xfrm6_tunnel_deregister(&xfrm6_tunnel_handler, AF_INET6);
|
2010-02-16 17:05:04 +08:00
|
|
|
out_xfrm6:
|
2008-12-15 15:13:48 +08:00
|
|
|
xfrm_unregister_type(&xfrm6_tunnel_type, AF_INET6);
|
2010-02-16 17:05:04 +08:00
|
|
|
out_type:
|
|
|
|
unregister_pernet_subsys(&xfrm6_tunnel_net_ops);
|
|
|
|
out_pernet:
|
|
|
|
kmem_cache_destroy(xfrm6_tunnel_spi_kmem);
|
2010-01-25 18:28:21 +08:00
|
|
|
return rv;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void __exit xfrm6_tunnel_fini(void)
|
|
|
|
{
|
2007-02-14 04:55:55 +08:00
|
|
|
xfrm6_tunnel_deregister(&xfrm46_tunnel_handler, AF_INET);
|
|
|
|
xfrm6_tunnel_deregister(&xfrm6_tunnel_handler, AF_INET6);
|
2006-07-25 04:49:06 +08:00
|
|
|
xfrm_unregister_type(&xfrm6_tunnel_type, AF_INET6);
|
2010-02-16 17:05:04 +08:00
|
|
|
unregister_pernet_subsys(&xfrm6_tunnel_net_ops);
|
|
|
|
kmem_cache_destroy(xfrm6_tunnel_spi_kmem);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
module_init(xfrm6_tunnel_init);
|
|
|
|
module_exit(xfrm6_tunnel_fini);
|
|
|
|
MODULE_LICENSE("GPL");
|
2007-06-27 14:57:49 +08:00
|
|
|
MODULE_ALIAS_XFRM_TYPE(AF_INET6, XFRM_PROTO_IPV6);
|