2008-03-18 16:22:06 +08:00
|
|
|
/*
|
|
|
|
* linux/arch/arm/mach-omap2/clock.c
|
|
|
|
*
|
2008-03-18 17:56:39 +08:00
|
|
|
* Copyright (C) 2005-2008 Texas Instruments, Inc.
|
2010-02-23 13:09:24 +08:00
|
|
|
* Copyright (C) 2004-2010 Nokia Corporation
|
2008-03-18 16:22:06 +08:00
|
|
|
*
|
2008-03-18 17:56:39 +08:00
|
|
|
* Contacts:
|
|
|
|
* Richard Woodruff <r-woodruff2@ti.com>
|
2008-03-18 16:22:06 +08:00
|
|
|
* Paul Walmsley
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
|
|
* published by the Free Software Foundation.
|
|
|
|
*/
|
|
|
|
#undef DEBUG
|
|
|
|
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/list.h>
|
|
|
|
#include <linux/errno.h>
|
2010-02-23 13:09:36 +08:00
|
|
|
#include <linux/err.h>
|
|
|
|
#include <linux/delay.h>
|
2008-03-18 16:22:06 +08:00
|
|
|
#include <linux/clk.h>
|
2008-09-06 19:10:45 +08:00
|
|
|
#include <linux/io.h>
|
2008-09-06 19:13:59 +08:00
|
|
|
#include <linux/bitops.h>
|
2008-03-18 16:22:06 +08:00
|
|
|
|
2011-03-03 18:25:43 +08:00
|
|
|
#include <asm/cpu.h>
|
2012-09-01 01:59:07 +08:00
|
|
|
|
2009-10-21 00:40:47 +08:00
|
|
|
#include <plat/clock.h>
|
|
|
|
#include <plat/prcm.h>
|
2008-03-18 16:22:06 +08:00
|
|
|
|
2012-09-01 01:59:07 +08:00
|
|
|
#include <trace/events/power.h>
|
|
|
|
|
|
|
|
#include "soc.h"
|
|
|
|
#include "clockdomain.h"
|
2008-03-18 16:22:06 +08:00
|
|
|
#include "clock.h"
|
2010-12-22 06:30:55 +08:00
|
|
|
#include "cm2xxx_3xxx.h"
|
2008-03-18 16:22:06 +08:00
|
|
|
#include "cm-regbits-24xx.h"
|
|
|
|
#include "cm-regbits-34xx.h"
|
|
|
|
|
2011-12-14 02:46:43 +08:00
|
|
|
u16 cpu_mask;
|
2008-03-18 16:22:06 +08:00
|
|
|
|
2011-07-10 19:57:06 +08:00
|
|
|
/*
|
|
|
|
* clkdm_control: if true, then when a clock is enabled in the
|
|
|
|
* hardware, its clockdomain will first be enabled; and when a clock
|
|
|
|
* is disabled in the hardware, its clockdomain will be disabled
|
|
|
|
* afterwards.
|
|
|
|
*/
|
|
|
|
static bool clkdm_control = true;
|
|
|
|
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
/*
|
|
|
|
* OMAP2+ specific clock functions
|
|
|
|
*/
|
2008-03-18 16:22:06 +08:00
|
|
|
|
2010-01-27 11:13:04 +08:00
|
|
|
/* Private functions */
|
|
|
|
|
|
|
|
/**
|
|
|
|
* _omap2_module_wait_ready - wait for an OMAP module to leave IDLE
|
|
|
|
* @clk: struct clk * belonging to the module
|
|
|
|
*
|
|
|
|
* If the necessary clocks for the OMAP hardware IP block that
|
|
|
|
* corresponds to clock @clk are enabled, then wait for the module to
|
|
|
|
* indicate readiness (i.e., to leave IDLE). This code does not
|
|
|
|
* belong in the clock code and will be moved in the medium term to
|
|
|
|
* module-dependent code. No return value.
|
|
|
|
*/
|
|
|
|
static void _omap2_module_wait_ready(struct clk *clk)
|
|
|
|
{
|
|
|
|
void __iomem *companion_reg, *idlest_reg;
|
2010-02-25 03:05:54 +08:00
|
|
|
u8 other_bit, idlest_bit, idlest_val;
|
2010-01-27 11:13:04 +08:00
|
|
|
|
|
|
|
/* Not all modules have multiple clocks that their IDLEST depends on */
|
|
|
|
if (clk->ops->find_companion) {
|
|
|
|
clk->ops->find_companion(clk, &companion_reg, &other_bit);
|
|
|
|
if (!(__raw_readl(companion_reg) & (1 << other_bit)))
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2010-02-25 03:05:54 +08:00
|
|
|
clk->ops->find_idlest(clk, &idlest_reg, &idlest_bit, &idlest_val);
|
2010-01-27 11:13:04 +08:00
|
|
|
|
2010-02-25 03:05:54 +08:00
|
|
|
omap2_cm_wait_idlest(idlest_reg, (1 << idlest_bit), idlest_val,
|
2012-09-22 16:24:17 +08:00
|
|
|
__clk_get_name(clk));
|
2010-01-27 11:13:04 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Public functions */
|
|
|
|
|
2008-08-19 16:08:45 +08:00
|
|
|
/**
|
|
|
|
* omap2_init_clk_clkdm - look up a clockdomain name, store pointer in clk
|
|
|
|
* @clk: OMAP clock struct ptr to use
|
|
|
|
*
|
|
|
|
* Convert a clockdomain name stored in a struct clk 'clk' into a
|
|
|
|
* clockdomain pointer, and save it into the struct clk. Intended to be
|
|
|
|
* called during clk_register(). No return value.
|
|
|
|
*/
|
|
|
|
void omap2_init_clk_clkdm(struct clk *clk)
|
|
|
|
{
|
|
|
|
struct clockdomain *clkdm;
|
2012-09-22 16:24:17 +08:00
|
|
|
const char *clk_name;
|
2008-08-19 16:08:45 +08:00
|
|
|
|
|
|
|
if (!clk->clkdm_name)
|
|
|
|
return;
|
|
|
|
|
2012-09-22 16:24:17 +08:00
|
|
|
clk_name = __clk_get_name(clk);
|
|
|
|
|
2008-08-19 16:08:45 +08:00
|
|
|
clkdm = clkdm_lookup(clk->clkdm_name);
|
|
|
|
if (clkdm) {
|
|
|
|
pr_debug("clock: associated clk %s to clkdm %s\n",
|
2012-09-22 16:24:17 +08:00
|
|
|
clk_name, clk->clkdm_name);
|
2008-08-19 16:08:45 +08:00
|
|
|
clk->clkdm = clkdm;
|
|
|
|
} else {
|
2012-07-26 14:54:26 +08:00
|
|
|
pr_debug("clock: could not associate clk %s to clkdm %s\n",
|
2012-09-22 16:24:17 +08:00
|
|
|
clk_name, clk->clkdm_name);
|
2008-08-19 16:08:45 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-07-10 19:57:06 +08:00
|
|
|
/**
|
|
|
|
* omap2_clk_disable_clkdm_control - disable clkdm control on clk enable/disable
|
|
|
|
*
|
|
|
|
* Prevent the OMAP clock code from calling into the clockdomain code
|
|
|
|
* when a hardware clock in that clockdomain is enabled or disabled.
|
|
|
|
* Intended to be called at init time from omap*_clk_init(). No
|
|
|
|
* return value.
|
|
|
|
*/
|
|
|
|
void __init omap2_clk_disable_clkdm_control(void)
|
|
|
|
{
|
|
|
|
clkdm_control = false;
|
|
|
|
}
|
|
|
|
|
2008-03-18 16:22:06 +08:00
|
|
|
/**
|
2009-07-25 09:44:03 +08:00
|
|
|
* omap2_clk_dflt_find_companion - find companion clock to @clk
|
|
|
|
* @clk: struct clk * to find the companion clock of
|
|
|
|
* @other_reg: void __iomem ** to return the companion clock CM_*CLKEN va in
|
|
|
|
* @other_bit: u8 ** to return the companion clock bit shift in
|
|
|
|
*
|
|
|
|
* Note: We don't need special code here for INVERT_ENABLE for the
|
|
|
|
* time being since INVERT_ENABLE only applies to clocks enabled by
|
|
|
|
* CM_CLKEN_PLL
|
2008-03-18 16:22:06 +08:00
|
|
|
*
|
2009-07-25 09:44:03 +08:00
|
|
|
* Convert CM_ICLKEN* <-> CM_FCLKEN*. This conversion assumes it's
|
|
|
|
* just a matter of XORing the bits.
|
|
|
|
*
|
|
|
|
* Some clocks don't have companion clocks. For example, modules with
|
|
|
|
* only an interface clock (such as MAILBOXES) don't have a companion
|
|
|
|
* clock. Right now, this code relies on the hardware exporting a bit
|
|
|
|
* in the correct companion register that indicates that the
|
|
|
|
* nonexistent 'companion clock' is active. Future patches will
|
|
|
|
* associate this type of code with per-module data structures to
|
|
|
|
* avoid this issue, and remove the casts. No return value.
|
2008-03-18 16:22:06 +08:00
|
|
|
*/
|
2009-07-25 09:44:03 +08:00
|
|
|
void omap2_clk_dflt_find_companion(struct clk *clk, void __iomem **other_reg,
|
|
|
|
u8 *other_bit)
|
2008-03-18 16:22:06 +08:00
|
|
|
{
|
2009-07-25 09:44:03 +08:00
|
|
|
u32 r;
|
2008-03-18 16:22:06 +08:00
|
|
|
|
|
|
|
/*
|
2009-07-25 09:44:03 +08:00
|
|
|
* Convert CM_ICLKEN* <-> CM_FCLKEN*. This conversion assumes
|
|
|
|
* it's just a matter of XORing the bits.
|
2008-03-18 16:22:06 +08:00
|
|
|
*/
|
2009-07-25 09:44:03 +08:00
|
|
|
r = ((__force u32)clk->enable_reg ^ (CM_FCLKEN ^ CM_ICLKEN));
|
2008-03-18 16:22:06 +08:00
|
|
|
|
2009-07-25 09:44:03 +08:00
|
|
|
*other_reg = (__force void __iomem *)r;
|
|
|
|
*other_bit = clk->enable_bit;
|
|
|
|
}
|
2008-03-18 16:22:06 +08:00
|
|
|
|
2009-07-25 09:44:03 +08:00
|
|
|
/**
|
|
|
|
* omap2_clk_dflt_find_idlest - find CM_IDLEST reg va, bit shift for @clk
|
|
|
|
* @clk: struct clk * to find IDLEST info for
|
|
|
|
* @idlest_reg: void __iomem ** to return the CM_IDLEST va in
|
2010-02-25 03:05:54 +08:00
|
|
|
* @idlest_bit: u8 * to return the CM_IDLEST bit shift in
|
|
|
|
* @idlest_val: u8 * to return the idle status indicator
|
2009-07-25 09:44:03 +08:00
|
|
|
*
|
|
|
|
* Return the CM_IDLEST register address and bit shift corresponding
|
|
|
|
* to the module that "owns" this clock. This default code assumes
|
|
|
|
* that the CM_IDLEST bit shift is the CM_*CLKEN bit shift, and that
|
|
|
|
* the IDLEST register address ID corresponds to the CM_*CLKEN
|
|
|
|
* register address ID (e.g., that CM_FCLKEN2 corresponds to
|
|
|
|
* CM_IDLEST2). This is not true for all modules. No return value.
|
2008-03-18 16:22:06 +08:00
|
|
|
*/
|
2009-07-25 09:44:03 +08:00
|
|
|
void omap2_clk_dflt_find_idlest(struct clk *clk, void __iomem **idlest_reg,
|
2010-02-25 03:05:54 +08:00
|
|
|
u8 *idlest_bit, u8 *idlest_val)
|
2008-03-18 16:22:06 +08:00
|
|
|
{
|
2009-07-25 09:44:03 +08:00
|
|
|
u32 r;
|
2008-03-18 16:22:06 +08:00
|
|
|
|
2009-07-25 09:44:03 +08:00
|
|
|
r = (((__force u32)clk->enable_reg & ~0xf0) | 0x20);
|
|
|
|
*idlest_reg = (__force void __iomem *)r;
|
|
|
|
*idlest_bit = clk->enable_bit;
|
2010-02-25 03:05:54 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* 24xx uses 0 to indicate not ready, and 1 to indicate ready.
|
|
|
|
* 34xx reverses this, just to keep us on our toes
|
|
|
|
* AM35xx uses both, depending on the module.
|
|
|
|
*/
|
|
|
|
if (cpu_is_omap24xx())
|
|
|
|
*idlest_val = OMAP24XX_CM_IDLEST_VAL;
|
|
|
|
else if (cpu_is_omap34xx())
|
|
|
|
*idlest_val = OMAP34XX_CM_IDLEST_VAL;
|
|
|
|
else
|
|
|
|
BUG();
|
|
|
|
|
2009-07-25 09:44:03 +08:00
|
|
|
}
|
2008-03-18 16:22:06 +08:00
|
|
|
|
2009-07-25 09:44:03 +08:00
|
|
|
int omap2_dflt_clk_enable(struct clk *clk)
|
2008-03-18 16:22:06 +08:00
|
|
|
{
|
2009-01-29 03:18:19 +08:00
|
|
|
u32 v;
|
2008-03-18 16:22:06 +08:00
|
|
|
|
2008-09-05 22:10:27 +08:00
|
|
|
if (unlikely(clk->enable_reg == NULL)) {
|
2009-07-25 09:44:03 +08:00
|
|
|
pr_err("clock.c: Enable for %s without enable code\n",
|
2008-03-18 16:22:06 +08:00
|
|
|
clk->name);
|
|
|
|
return 0; /* REVISIT: -EINVAL */
|
|
|
|
}
|
|
|
|
|
2009-01-29 03:18:19 +08:00
|
|
|
v = __raw_readl(clk->enable_reg);
|
2008-03-18 16:22:06 +08:00
|
|
|
if (clk->flags & INVERT_ENABLE)
|
2009-01-29 03:18:19 +08:00
|
|
|
v &= ~(1 << clk->enable_bit);
|
2008-03-18 16:22:06 +08:00
|
|
|
else
|
2009-01-29 03:18:19 +08:00
|
|
|
v |= (1 << clk->enable_bit);
|
|
|
|
__raw_writel(v, clk->enable_reg);
|
2009-01-29 03:35:06 +08:00
|
|
|
v = __raw_readl(clk->enable_reg); /* OCP barrier */
|
2008-03-18 16:22:06 +08:00
|
|
|
|
2009-07-25 09:44:03 +08:00
|
|
|
if (clk->ops->find_idlest)
|
2010-01-27 11:13:04 +08:00
|
|
|
_omap2_module_wait_ready(clk);
|
2008-03-18 16:22:06 +08:00
|
|
|
|
2009-07-25 09:44:03 +08:00
|
|
|
return 0;
|
2008-11-05 02:59:32 +08:00
|
|
|
}
|
|
|
|
|
2009-07-25 09:44:03 +08:00
|
|
|
void omap2_dflt_clk_disable(struct clk *clk)
|
2008-03-18 16:22:06 +08:00
|
|
|
{
|
2009-01-29 03:18:19 +08:00
|
|
|
u32 v;
|
2008-03-18 16:22:06 +08:00
|
|
|
|
2009-01-28 10:12:50 +08:00
|
|
|
if (!clk->enable_reg) {
|
2008-03-18 16:22:06 +08:00
|
|
|
/*
|
|
|
|
* 'Independent' here refers to a clock which is not
|
|
|
|
* controlled by its parent.
|
|
|
|
*/
|
2012-07-26 14:54:26 +08:00
|
|
|
pr_err("clock: clk_disable called on independent clock %s which has no enable_reg\n", clk->name);
|
2008-03-18 16:22:06 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2009-01-29 03:18:19 +08:00
|
|
|
v = __raw_readl(clk->enable_reg);
|
2008-03-18 16:22:06 +08:00
|
|
|
if (clk->flags & INVERT_ENABLE)
|
2009-01-29 03:18:19 +08:00
|
|
|
v |= (1 << clk->enable_bit);
|
2008-03-18 16:22:06 +08:00
|
|
|
else
|
2009-01-29 03:18:19 +08:00
|
|
|
v &= ~(1 << clk->enable_bit);
|
|
|
|
__raw_writel(v, clk->enable_reg);
|
2009-01-29 03:35:01 +08:00
|
|
|
/* No OCP barrier needed here since it is a disable operation */
|
2008-03-18 16:22:06 +08:00
|
|
|
}
|
|
|
|
|
2008-11-05 01:59:52 +08:00
|
|
|
const struct clkops clkops_omap2_dflt_wait = {
|
2009-07-25 09:44:03 +08:00
|
|
|
.enable = omap2_dflt_clk_enable,
|
2008-11-05 01:59:52 +08:00
|
|
|
.disable = omap2_dflt_clk_disable,
|
2009-07-25 09:44:03 +08:00
|
|
|
.find_companion = omap2_clk_dflt_find_companion,
|
|
|
|
.find_idlest = omap2_clk_dflt_find_idlest,
|
2008-11-05 01:59:52 +08:00
|
|
|
};
|
|
|
|
|
2008-11-05 02:59:32 +08:00
|
|
|
const struct clkops clkops_omap2_dflt = {
|
|
|
|
.enable = omap2_dflt_clk_enable,
|
|
|
|
.disable = omap2_dflt_clk_disable,
|
|
|
|
};
|
|
|
|
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
/**
|
|
|
|
* omap2_clk_disable - disable a clock, if the system is not using it
|
|
|
|
* @clk: struct clk * to disable
|
|
|
|
*
|
|
|
|
* Decrements the usecount on struct clk @clk. If there are no users
|
|
|
|
* left, call the clkops-specific clock disable function to disable it
|
|
|
|
* in hardware. If the clock is part of a clockdomain (which they all
|
|
|
|
* should be), request that the clockdomain be disabled. (It too has
|
|
|
|
* a usecount, and so will not be disabled in the hardware until it no
|
|
|
|
* longer has any users.) If the clock has a parent clock (most of
|
|
|
|
* them do), then call ourselves, recursing on the parent clock. This
|
|
|
|
* can cause an entire branch of the clock tree to be powered off by
|
|
|
|
* simply disabling one clock. Intended to be called with the clockfw_lock
|
|
|
|
* spinlock held. No return value.
|
|
|
|
*/
|
2008-03-18 16:22:06 +08:00
|
|
|
void omap2_clk_disable(struct clk *clk)
|
|
|
|
{
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
if (clk->usecount == 0) {
|
2012-07-26 14:54:26 +08:00
|
|
|
WARN(1, "clock: %s: omap2_clk_disable() called, but usecount already 0?", clk->name);
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
return;
|
2008-03-18 16:22:06 +08:00
|
|
|
}
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
|
|
|
|
pr_debug("clock: %s: decrementing usecount\n", clk->name);
|
|
|
|
|
|
|
|
clk->usecount--;
|
|
|
|
|
|
|
|
if (clk->usecount > 0)
|
|
|
|
return;
|
|
|
|
|
|
|
|
pr_debug("clock: %s: disabling in hardware\n", clk->name);
|
|
|
|
|
2011-03-03 18:25:43 +08:00
|
|
|
if (clk->ops && clk->ops->disable) {
|
|
|
|
trace_clock_disable(clk->name, 0, smp_processor_id());
|
2011-02-26 06:48:36 +08:00
|
|
|
clk->ops->disable(clk);
|
2011-03-03 18:25:43 +08:00
|
|
|
}
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
|
2011-07-10 19:57:06 +08:00
|
|
|
if (clkdm_control && clk->clkdm)
|
2011-02-26 07:06:48 +08:00
|
|
|
clkdm_clk_disable(clk->clkdm, clk);
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
|
|
|
|
if (clk->parent)
|
|
|
|
omap2_clk_disable(clk->parent);
|
2008-03-18 16:22:06 +08:00
|
|
|
}
|
|
|
|
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
/**
|
|
|
|
* omap2_clk_enable - request that the system enable a clock
|
|
|
|
* @clk: struct clk * to enable
|
|
|
|
*
|
|
|
|
* Increments the usecount on struct clk @clk. If there were no users
|
|
|
|
* previously, then recurse up the clock tree, enabling all of the
|
|
|
|
* clock's parents and all of the parent clockdomains, and finally,
|
|
|
|
* enabling @clk's clockdomain, and @clk itself. Intended to be
|
|
|
|
* called with the clockfw_lock spinlock held. Returns 0 upon success
|
|
|
|
* or a negative error code upon failure.
|
|
|
|
*/
|
2008-03-18 16:22:06 +08:00
|
|
|
int omap2_clk_enable(struct clk *clk)
|
|
|
|
{
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
int ret;
|
2008-03-18 16:22:06 +08:00
|
|
|
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
pr_debug("clock: %s: incrementing usecount\n", clk->name);
|
2008-08-19 16:08:45 +08:00
|
|
|
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
clk->usecount++;
|
|
|
|
|
|
|
|
if (clk->usecount > 1)
|
|
|
|
return 0;
|
2008-08-19 16:08:45 +08:00
|
|
|
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
pr_debug("clock: %s: enabling in hardware\n", clk->name);
|
|
|
|
|
|
|
|
if (clk->parent) {
|
|
|
|
ret = omap2_clk_enable(clk->parent);
|
2009-01-31 19:00:17 +08:00
|
|
|
if (ret) {
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
WARN(1, "clock: %s: could not enable parent %s: %d\n",
|
|
|
|
clk->name, clk->parent->name, ret);
|
|
|
|
goto oce_err1;
|
|
|
|
}
|
|
|
|
}
|
2009-01-31 19:00:17 +08:00
|
|
|
|
2011-07-10 19:57:06 +08:00
|
|
|
if (clkdm_control && clk->clkdm) {
|
2011-02-26 07:06:48 +08:00
|
|
|
ret = clkdm_clk_enable(clk->clkdm, clk);
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
if (ret) {
|
2012-07-26 14:54:26 +08:00
|
|
|
WARN(1, "clock: %s: could not enable clockdomain %s: %d\n",
|
|
|
|
clk->name, clk->clkdm->name, ret);
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
goto oce_err2;
|
2008-03-18 16:22:06 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-02-26 06:48:36 +08:00
|
|
|
if (clk->ops && clk->ops->enable) {
|
2011-03-03 18:25:43 +08:00
|
|
|
trace_clock_enable(clk->name, 1, smp_processor_id());
|
2011-02-26 06:48:36 +08:00
|
|
|
ret = clk->ops->enable(clk);
|
|
|
|
if (ret) {
|
|
|
|
WARN(1, "clock: %s: could not enable: %d\n",
|
|
|
|
clk->name, ret);
|
|
|
|
goto oce_err3;
|
|
|
|
}
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
oce_err3:
|
2011-07-10 19:57:06 +08:00
|
|
|
if (clkdm_control && clk->clkdm)
|
2011-02-26 07:06:48 +08:00
|
|
|
clkdm_clk_disable(clk->clkdm, clk);
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
oce_err2:
|
|
|
|
if (clk->parent)
|
|
|
|
omap2_clk_disable(clk->parent);
|
|
|
|
oce_err1:
|
2009-01-31 19:00:17 +08:00
|
|
|
clk->usecount--;
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
|
2008-03-18 16:22:06 +08:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2010-05-19 08:40:24 +08:00
|
|
|
/* Given a clock and a rate apply a clock specific rounding function */
|
|
|
|
long omap2_clk_round_rate(struct clk *clk, unsigned long rate)
|
|
|
|
{
|
|
|
|
if (clk->round_rate)
|
|
|
|
return clk->round_rate(clk, rate);
|
|
|
|
|
|
|
|
return clk->rate;
|
|
|
|
}
|
|
|
|
|
2008-03-18 16:22:06 +08:00
|
|
|
/* Set the clock rate for a clock source */
|
|
|
|
int omap2_clk_set_rate(struct clk *clk, unsigned long rate)
|
|
|
|
{
|
|
|
|
int ret = -EINVAL;
|
|
|
|
|
|
|
|
pr_debug("clock: set_rate for clock %s to rate %ld\n", clk->name, rate);
|
|
|
|
|
|
|
|
/* dpll_ck, core_ck, virt_prcm_set; plus all clksel clocks */
|
2011-03-03 18:25:43 +08:00
|
|
|
if (clk->set_rate) {
|
|
|
|
trace_clock_set_rate(clk->name, rate, smp_processor_id());
|
2008-03-18 16:22:06 +08:00
|
|
|
ret = clk->set_rate(clk, rate);
|
2011-03-03 18:25:43 +08:00
|
|
|
}
|
2008-03-18 16:22:06 +08:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
int omap2_clk_set_parent(struct clk *clk, struct clk *new_parent)
|
|
|
|
{
|
|
|
|
if (!clk->clksel)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2010-02-23 13:09:16 +08:00
|
|
|
if (clk->parent == new_parent)
|
|
|
|
return 0;
|
|
|
|
|
2010-01-27 11:13:04 +08:00
|
|
|
return omap2_clksel_set_parent(clk, new_parent);
|
2008-03-18 16:22:06 +08:00
|
|
|
}
|
|
|
|
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
/*
|
|
|
|
* OMAP2+ clock reset and init functions
|
|
|
|
*/
|
2008-03-18 16:22:06 +08:00
|
|
|
|
|
|
|
#ifdef CONFIG_OMAP_RESET_CLOCKS
|
|
|
|
void omap2_clk_disable_unused(struct clk *clk)
|
|
|
|
{
|
|
|
|
u32 regval32, v;
|
|
|
|
|
|
|
|
v = (clk->flags & INVERT_ENABLE) ? (1 << clk->enable_bit) : 0;
|
|
|
|
|
|
|
|
regval32 = __raw_readl(clk->enable_reg);
|
|
|
|
if ((regval32 & (1 << clk->enable_bit)) == v)
|
|
|
|
return;
|
|
|
|
|
2010-10-09 01:40:20 +08:00
|
|
|
pr_debug("Disabling unused clock \"%s\"\n", clk->name);
|
2009-01-29 03:27:45 +08:00
|
|
|
if (cpu_is_omap34xx()) {
|
|
|
|
omap2_clk_enable(clk);
|
|
|
|
omap2_clk_disable(clk);
|
OMAP2+ clock: revise omap2_clk_{disable,enable}()
Simplify the code in the omap2_clk_disable() and omap2_clk_enable()
functions, reducing levels of indentation. This makes the code easier
to read. Add some additional debugging pr_debug()s here also to help
others understand what is going on.
Revise the omap2_clk_disable() logic so that it now attempts to
disable the clock's clockdomain before recursing up the clock tree.
Simultaneously, ensure that omap2_clk_enable() is called on parent
clocks first, before enabling the clockdomain. This ensures that a
parent clock's clockdomain is enabled before the child clock's
clockdomain. These sequences should be the inverse of each other.
Revise the omap2_clk_enable() logic so that it now cleans up after
itself upon encountering an error. Previously, an error enabling a
parent clock could have resulted in inconsistent usecounts on the
enclosing clockdomain.
Remove the trivial _omap2_clk_disable() and _omap2_clk_enable() static
functions, and replace it with the clkops calls that they were
executing.
For all this to work, the clockdomain omap2_clkdm_clk_enable() and
omap2_clkdm_clk_disable() code must not return an error on clockdomains
without CLKSTCTRL registers; so modify those functions to simply return 0
in that case.
While here, add some basic kerneldoc documentation on both functions,
and get rid of some old non-CodingStyle-compliant comments that have
existed since the dawn of time (at least, the OMAP clock framework's
time).
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Richard Woodruff <r-woodruff2@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
2010-02-23 13:09:38 +08:00
|
|
|
} else {
|
|
|
|
clk->ops->disable(clk);
|
|
|
|
}
|
2008-10-15 22:48:44 +08:00
|
|
|
if (clk->clkdm != NULL)
|
2012-05-08 13:55:38 +08:00
|
|
|
pwrdm_state_switch(clk->clkdm->pwrdm.ptr);
|
2008-03-18 16:22:06 +08:00
|
|
|
}
|
|
|
|
#endif
|
2010-01-27 11:13:04 +08:00
|
|
|
|
2010-02-23 13:09:36 +08:00
|
|
|
/**
|
|
|
|
* omap2_clk_switch_mpurate_at_boot - switch ARM MPU rate by boot-time argument
|
|
|
|
* @mpurate_ck_name: clk name of the clock to change rate
|
|
|
|
*
|
|
|
|
* Change the ARM MPU clock rate to the rate specified on the command
|
|
|
|
* line, if one was specified. @mpurate_ck_name should be
|
|
|
|
* "virt_prcm_set" on OMAP2xxx and "dpll1_ck" on OMAP34xx/OMAP36xx.
|
|
|
|
* XXX Does not handle voltage scaling - on OMAP2xxx this is currently
|
|
|
|
* handled by the virt_prcm_set clock, but this should be handled by
|
|
|
|
* the OPP layer. XXX This is intended to be handled by the OPP layer
|
|
|
|
* code in the near future and should be removed from the clock code.
|
|
|
|
* Returns -EINVAL if 'mpurate' is zero or if clk_set_rate() rejects
|
|
|
|
* the rate, -ENOENT if the struct clk referred to by @mpurate_ck_name
|
|
|
|
* cannot be found, or 0 upon success.
|
|
|
|
*/
|
|
|
|
int __init omap2_clk_switch_mpurate_at_boot(const char *mpurate_ck_name)
|
|
|
|
{
|
|
|
|
struct clk *mpurate_ck;
|
|
|
|
int r;
|
|
|
|
|
|
|
|
if (!mpurate)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
mpurate_ck = clk_get(NULL, mpurate_ck_name);
|
|
|
|
if (WARN(IS_ERR(mpurate_ck), "Failed to get %s.\n", mpurate_ck_name))
|
|
|
|
return -ENOENT;
|
|
|
|
|
|
|
|
r = clk_set_rate(mpurate_ck, mpurate);
|
|
|
|
if (IS_ERR_VALUE(r)) {
|
|
|
|
WARN(1, "clock: %s: unable to set MPU rate to %d: %d\n",
|
|
|
|
mpurate_ck->name, mpurate, r);
|
2011-07-04 19:08:10 +08:00
|
|
|
clk_put(mpurate_ck);
|
2010-02-23 13:09:36 +08:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
calibrate_delay();
|
|
|
|
recalculate_root_clocks();
|
|
|
|
|
|
|
|
clk_put(mpurate_ck);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* omap2_clk_print_new_rates - print summary of current clock tree rates
|
|
|
|
* @hfclkin_ck_name: clk name for the off-chip HF oscillator
|
|
|
|
* @core_ck_name: clk name for the on-chip CORE_CLK
|
|
|
|
* @mpu_ck_name: clk name for the ARM MPU clock
|
|
|
|
*
|
|
|
|
* Prints a short message to the console with the HFCLKIN oscillator
|
|
|
|
* rate, the rate of the CORE clock, and the rate of the ARM MPU clock.
|
|
|
|
* Called by the boot-time MPU rate switching code. XXX This is intended
|
|
|
|
* to be handled by the OPP layer code in the near future and should be
|
|
|
|
* removed from the clock code. No return value.
|
|
|
|
*/
|
|
|
|
void __init omap2_clk_print_new_rates(const char *hfclkin_ck_name,
|
|
|
|
const char *core_ck_name,
|
|
|
|
const char *mpu_ck_name)
|
|
|
|
{
|
|
|
|
struct clk *hfclkin_ck, *core_ck, *mpu_ck;
|
|
|
|
unsigned long hfclkin_rate;
|
|
|
|
|
|
|
|
mpu_ck = clk_get(NULL, mpu_ck_name);
|
|
|
|
if (WARN(IS_ERR(mpu_ck), "clock: failed to get %s.\n", mpu_ck_name))
|
|
|
|
return;
|
|
|
|
|
|
|
|
core_ck = clk_get(NULL, core_ck_name);
|
|
|
|
if (WARN(IS_ERR(core_ck), "clock: failed to get %s.\n", core_ck_name))
|
|
|
|
return;
|
|
|
|
|
|
|
|
hfclkin_ck = clk_get(NULL, hfclkin_ck_name);
|
|
|
|
if (WARN(IS_ERR(hfclkin_ck), "Failed to get %s.\n", hfclkin_ck_name))
|
|
|
|
return;
|
|
|
|
|
|
|
|
hfclkin_rate = clk_get_rate(hfclkin_ck);
|
|
|
|
|
2012-07-26 14:54:26 +08:00
|
|
|
pr_info("Switched to new clocking rate (Crystal/Core/MPU): %ld.%01ld/%ld/%ld MHz\n",
|
|
|
|
(hfclkin_rate / 1000000), ((hfclkin_rate / 100000) % 10),
|
2010-02-23 13:09:36 +08:00
|
|
|
(clk_get_rate(core_ck) / 1000000),
|
|
|
|
(clk_get_rate(mpu_ck) / 1000000));
|
|
|
|
}
|
|
|
|
|
2010-01-27 11:13:04 +08:00
|
|
|
/* Common data */
|
|
|
|
|
|
|
|
struct clk_functions omap2_clk_functions = {
|
|
|
|
.clk_enable = omap2_clk_enable,
|
|
|
|
.clk_disable = omap2_clk_disable,
|
|
|
|
.clk_round_rate = omap2_clk_round_rate,
|
|
|
|
.clk_set_rate = omap2_clk_set_rate,
|
|
|
|
.clk_set_parent = omap2_clk_set_parent,
|
|
|
|
.clk_disable_unused = omap2_clk_disable_unused,
|
|
|
|
};
|
|
|
|
|