2019-06-01 16:08:55 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2014-11-01 00:26:16 +08:00
|
|
|
/*
|
|
|
|
* Driver for Goodix Touchscreens
|
|
|
|
*
|
|
|
|
* Copyright (c) 2014 Red Hat Inc.
|
2015-12-18 09:02:53 +08:00
|
|
|
* Copyright (c) 2015 K. Merker <merker@debian.org>
|
2014-11-01 00:26:16 +08:00
|
|
|
*
|
|
|
|
* This code is based on gt9xx.c authored by andrew@goodix.com:
|
|
|
|
*
|
|
|
|
* 2010 - 2012 Goodix Technology.
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
|
|
#include <linux/kernel.h>
|
2015-07-25 00:08:53 +08:00
|
|
|
#include <linux/dmi.h>
|
2015-12-18 08:05:42 +08:00
|
|
|
#include <linux/firmware.h>
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
#include <linux/gpio/consumer.h>
|
2014-11-01 00:26:16 +08:00
|
|
|
#include <linux/i2c.h>
|
|
|
|
#include <linux/input.h>
|
|
|
|
#include <linux/input/mt.h>
|
2018-01-27 03:08:59 +08:00
|
|
|
#include <linux/input/touchscreen.h>
|
2014-11-01 00:26:16 +08:00
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/irq.h>
|
|
|
|
#include <linux/interrupt.h>
|
2019-04-04 06:20:26 +08:00
|
|
|
#include <linux/regulator/consumer.h>
|
2014-11-01 00:26:16 +08:00
|
|
|
#include <linux/slab.h>
|
2015-03-07 08:43:38 +08:00
|
|
|
#include <linux/acpi.h>
|
|
|
|
#include <linux/of.h>
|
2014-11-01 00:26:16 +08:00
|
|
|
#include <asm/unaligned.h>
|
|
|
|
|
2020-03-25 02:29:10 +08:00
|
|
|
#define GOODIX_GPIO_INT_NAME "irq"
|
|
|
|
#define GOODIX_GPIO_RST_NAME "reset"
|
|
|
|
|
|
|
|
#define GOODIX_MAX_HEIGHT 4096
|
|
|
|
#define GOODIX_MAX_WIDTH 4096
|
|
|
|
#define GOODIX_INT_TRIGGER 1
|
|
|
|
#define GOODIX_CONTACT_SIZE 8
|
|
|
|
#define GOODIX_MAX_CONTACT_SIZE 9
|
|
|
|
#define GOODIX_MAX_CONTACTS 10
|
2020-03-25 02:38:49 +08:00
|
|
|
#define GOODIX_MAX_KEYS 7
|
2020-03-25 02:29:10 +08:00
|
|
|
|
2020-03-25 02:33:16 +08:00
|
|
|
#define GOODIX_CONFIG_MIN_LENGTH 186
|
2020-03-25 02:29:10 +08:00
|
|
|
#define GOODIX_CONFIG_911_LENGTH 186
|
|
|
|
#define GOODIX_CONFIG_967_LENGTH 228
|
2020-03-25 02:33:16 +08:00
|
|
|
#define GOODIX_CONFIG_GT9X_LENGTH 240
|
|
|
|
#define GOODIX_CONFIG_MAX_LENGTH 240
|
2020-03-25 02:29:10 +08:00
|
|
|
|
|
|
|
/* Register defines */
|
|
|
|
#define GOODIX_REG_COMMAND 0x8040
|
|
|
|
#define GOODIX_CMD_SCREEN_OFF 0x05
|
|
|
|
|
|
|
|
#define GOODIX_READ_COOR_ADDR 0x814E
|
|
|
|
#define GOODIX_GT1X_REG_CONFIG_DATA 0x8050
|
|
|
|
#define GOODIX_GT9X_REG_CONFIG_DATA 0x8047
|
|
|
|
#define GOODIX_REG_ID 0x8140
|
|
|
|
|
|
|
|
#define GOODIX_BUFFER_STATUS_READY BIT(7)
|
2020-03-25 02:38:49 +08:00
|
|
|
#define GOODIX_HAVE_KEY BIT(4)
|
2020-03-25 02:29:10 +08:00
|
|
|
#define GOODIX_BUFFER_STATUS_TIMEOUT 20
|
|
|
|
|
|
|
|
#define RESOLUTION_LOC 1
|
|
|
|
#define MAX_CONTACTS_LOC 5
|
|
|
|
#define TRIGGER_LOC 6
|
|
|
|
|
2020-04-02 03:53:36 +08:00
|
|
|
/* Our special handling for GPIO accesses through ACPI is x86 specific */
|
|
|
|
#if defined CONFIG_X86 && defined CONFIG_ACPI
|
|
|
|
#define ACPI_GPIO_SUPPORT
|
|
|
|
#endif
|
|
|
|
|
2017-10-25 02:06:41 +08:00
|
|
|
struct goodix_ts_data;
|
|
|
|
|
2020-03-25 02:12:10 +08:00
|
|
|
enum goodix_irq_pin_access_method {
|
|
|
|
IRQ_PIN_ACCESS_NONE,
|
|
|
|
IRQ_PIN_ACCESS_GPIO,
|
Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices
On most Cherry Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 1 GpioInt and 1 GpioIo resource in their _CRS table:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\_SB.PCI0.I2C2",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Edge, ActiveLow, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0013
}
GpioIo (Shared, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0019
}
})
Return (RBUF) /* \_SB_.PCI0.I2C2.TCS1._CRS.RBUF */
}
There is no fixed order for these 2. This commit adds code to check that
there is 1 of each as expected and then registers a mapping matching their
order using devm_acpi_dev_add_driver_gpios().
This gives us access to both GPIOs allowing us to properly suspend the
controller during suspend, and making it possible to reset the controller
if necessary.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20200307121505.3707-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:21 +08:00
|
|
|
IRQ_PIN_ACCESS_ACPI_GPIO,
|
2020-03-25 02:24:31 +08:00
|
|
|
IRQ_PIN_ACCESS_ACPI_METHOD,
|
2020-03-25 02:12:10 +08:00
|
|
|
};
|
|
|
|
|
2017-10-25 02:06:41 +08:00
|
|
|
struct goodix_chip_data {
|
|
|
|
u16 config_addr;
|
|
|
|
int config_len;
|
2020-03-25 02:33:50 +08:00
|
|
|
int (*check_config)(struct goodix_ts_data *ts, const u8 *cfg, int len);
|
2020-03-25 02:29:26 +08:00
|
|
|
void (*calc_config_checksum)(struct goodix_ts_data *ts);
|
2017-10-25 02:06:41 +08:00
|
|
|
};
|
|
|
|
|
2020-03-25 02:57:58 +08:00
|
|
|
struct goodix_chip_id {
|
|
|
|
const char *id;
|
|
|
|
const struct goodix_chip_data *data;
|
|
|
|
};
|
|
|
|
|
|
|
|
#define GOODIX_ID_MAX_LEN 4
|
|
|
|
|
2014-11-01 00:26:16 +08:00
|
|
|
struct goodix_ts_data {
|
|
|
|
struct i2c_client *client;
|
|
|
|
struct input_dev *input_dev;
|
2017-10-25 02:06:41 +08:00
|
|
|
const struct goodix_chip_data *chip;
|
2018-01-27 03:08:59 +08:00
|
|
|
struct touchscreen_properties prop;
|
2014-11-01 00:26:16 +08:00
|
|
|
unsigned int max_touch_num;
|
|
|
|
unsigned int int_trigger_type;
|
2019-04-04 06:20:26 +08:00
|
|
|
struct regulator *avdd28;
|
|
|
|
struct regulator *vddio;
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
struct gpio_desc *gpiod_int;
|
|
|
|
struct gpio_desc *gpiod_rst;
|
Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices
On most Cherry Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 1 GpioInt and 1 GpioIo resource in their _CRS table:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\_SB.PCI0.I2C2",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Edge, ActiveLow, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0013
}
GpioIo (Shared, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0019
}
})
Return (RBUF) /* \_SB_.PCI0.I2C2.TCS1._CRS.RBUF */
}
There is no fixed order for these 2. This commit adds code to check that
there is 1 of each as expected and then registers a mapping matching their
order using devm_acpi_dev_add_driver_gpios().
This gives us access to both GPIOs allowing us to properly suspend the
controller during suspend, and making it possible to reset the controller
if necessary.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20200307121505.3707-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:21 +08:00
|
|
|
int gpio_count;
|
|
|
|
int gpio_int_idx;
|
2020-03-25 02:57:58 +08:00
|
|
|
char id[GOODIX_ID_MAX_LEN + 1];
|
2015-12-18 08:05:42 +08:00
|
|
|
u16 version;
|
|
|
|
const char *cfg_name;
|
2020-03-25 02:23:04 +08:00
|
|
|
bool reset_controller_at_probe;
|
2020-03-25 02:12:35 +08:00
|
|
|
bool load_cfg_from_disk;
|
2015-12-18 08:05:42 +08:00
|
|
|
struct completion firmware_loading_complete;
|
2015-12-18 08:43:39 +08:00
|
|
|
unsigned long irq_flags;
|
2020-03-25 02:12:10 +08:00
|
|
|
enum goodix_irq_pin_access_method irq_pin_access_method;
|
2019-09-17 07:32:24 +08:00
|
|
|
unsigned int contact_size;
|
2020-03-25 02:29:26 +08:00
|
|
|
u8 config[GOODIX_CONFIG_MAX_LENGTH];
|
2020-03-25 02:38:49 +08:00
|
|
|
unsigned short keymap[GOODIX_MAX_KEYS];
|
2014-11-01 00:26:16 +08:00
|
|
|
};
|
|
|
|
|
2017-10-25 02:06:41 +08:00
|
|
|
static int goodix_check_cfg_8(struct goodix_ts_data *ts,
|
2020-03-25 02:33:50 +08:00
|
|
|
const u8 *cfg, int len);
|
2017-10-25 02:06:41 +08:00
|
|
|
static int goodix_check_cfg_16(struct goodix_ts_data *ts,
|
2020-03-25 02:33:50 +08:00
|
|
|
const u8 *cfg, int len);
|
2020-03-25 02:29:26 +08:00
|
|
|
static void goodix_calc_cfg_checksum_8(struct goodix_ts_data *ts);
|
|
|
|
static void goodix_calc_cfg_checksum_16(struct goodix_ts_data *ts);
|
2017-10-25 02:06:41 +08:00
|
|
|
|
|
|
|
static const struct goodix_chip_data gt1x_chip_data = {
|
|
|
|
.config_addr = GOODIX_GT1X_REG_CONFIG_DATA,
|
2020-03-25 02:33:16 +08:00
|
|
|
.config_len = GOODIX_CONFIG_GT9X_LENGTH,
|
2017-10-25 02:06:41 +08:00
|
|
|
.check_config = goodix_check_cfg_16,
|
2020-03-25 02:29:26 +08:00
|
|
|
.calc_config_checksum = goodix_calc_cfg_checksum_16,
|
2017-10-25 02:06:41 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct goodix_chip_data gt911_chip_data = {
|
|
|
|
.config_addr = GOODIX_GT9X_REG_CONFIG_DATA,
|
|
|
|
.config_len = GOODIX_CONFIG_911_LENGTH,
|
|
|
|
.check_config = goodix_check_cfg_8,
|
2020-03-25 02:29:26 +08:00
|
|
|
.calc_config_checksum = goodix_calc_cfg_checksum_8,
|
2017-10-25 02:06:41 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct goodix_chip_data gt967_chip_data = {
|
|
|
|
.config_addr = GOODIX_GT9X_REG_CONFIG_DATA,
|
|
|
|
.config_len = GOODIX_CONFIG_967_LENGTH,
|
|
|
|
.check_config = goodix_check_cfg_8,
|
2020-03-25 02:29:26 +08:00
|
|
|
.calc_config_checksum = goodix_calc_cfg_checksum_8,
|
2017-10-25 02:06:41 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct goodix_chip_data gt9x_chip_data = {
|
|
|
|
.config_addr = GOODIX_GT9X_REG_CONFIG_DATA,
|
2020-03-25 02:33:16 +08:00
|
|
|
.config_len = GOODIX_CONFIG_GT9X_LENGTH,
|
2017-10-25 02:06:41 +08:00
|
|
|
.check_config = goodix_check_cfg_8,
|
2020-03-25 02:29:26 +08:00
|
|
|
.calc_config_checksum = goodix_calc_cfg_checksum_8,
|
2017-10-25 02:06:41 +08:00
|
|
|
};
|
|
|
|
|
2020-03-25 02:57:58 +08:00
|
|
|
static const struct goodix_chip_id goodix_chip_ids[] = {
|
|
|
|
{ .id = "1151", .data = >1x_chip_data },
|
|
|
|
{ .id = "5663", .data = >1x_chip_data },
|
|
|
|
{ .id = "5688", .data = >1x_chip_data },
|
2020-03-25 03:25:58 +08:00
|
|
|
{ .id = "917S", .data = >1x_chip_data },
|
2020-03-25 02:57:58 +08:00
|
|
|
|
|
|
|
{ .id = "911", .data = >911_chip_data },
|
|
|
|
{ .id = "9271", .data = >911_chip_data },
|
|
|
|
{ .id = "9110", .data = >911_chip_data },
|
|
|
|
{ .id = "927", .data = >911_chip_data },
|
|
|
|
{ .id = "928", .data = >911_chip_data },
|
|
|
|
|
|
|
|
{ .id = "912", .data = >967_chip_data },
|
2020-03-25 03:32:27 +08:00
|
|
|
{ .id = "9147", .data = >967_chip_data },
|
2020-03-25 02:57:58 +08:00
|
|
|
{ .id = "967", .data = >967_chip_data },
|
|
|
|
{ }
|
|
|
|
};
|
|
|
|
|
2014-11-01 00:26:16 +08:00
|
|
|
static const unsigned long goodix_irq_flags[] = {
|
|
|
|
IRQ_TYPE_EDGE_RISING,
|
|
|
|
IRQ_TYPE_EDGE_FALLING,
|
|
|
|
IRQ_TYPE_LEVEL_LOW,
|
|
|
|
IRQ_TYPE_LEVEL_HIGH,
|
|
|
|
};
|
|
|
|
|
2015-07-25 00:08:53 +08:00
|
|
|
/*
|
|
|
|
* Those tablets have their coordinates origin at the bottom right
|
|
|
|
* of the tablet, as if rotated 180 degrees
|
|
|
|
*/
|
|
|
|
static const struct dmi_system_id rotated_screen[] = {
|
|
|
|
#if defined(CONFIG_DMI) && defined(CONFIG_X86)
|
2019-12-03 01:36:15 +08:00
|
|
|
{
|
|
|
|
.ident = "Teclast X89",
|
|
|
|
.matches = {
|
|
|
|
/* tPAD is too generic, also match on bios date */
|
|
|
|
DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
|
|
|
|
DMI_MATCH(DMI_BOARD_NAME, "tPAD"),
|
|
|
|
DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"),
|
|
|
|
},
|
|
|
|
},
|
2020-12-12 08:17:32 +08:00
|
|
|
{
|
|
|
|
.ident = "Teclast X98 Pro",
|
|
|
|
.matches = {
|
|
|
|
/*
|
|
|
|
* Only match BIOS date, because the manufacturers
|
|
|
|
* BIOS does not report the board name at all
|
|
|
|
* (sometimes)...
|
|
|
|
*/
|
|
|
|
DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
|
|
|
|
DMI_MATCH(DMI_BIOS_DATE, "10/28/2015"),
|
|
|
|
},
|
|
|
|
},
|
2015-07-25 00:08:53 +08:00
|
|
|
{
|
|
|
|
.ident = "WinBook TW100",
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_SYS_VENDOR, "WinBook"),
|
|
|
|
DMI_MATCH(DMI_PRODUCT_NAME, "TW100")
|
|
|
|
}
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.ident = "WinBook TW700",
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_SYS_VENDOR, "WinBook"),
|
|
|
|
DMI_MATCH(DMI_PRODUCT_NAME, "TW700")
|
|
|
|
},
|
|
|
|
},
|
|
|
|
#endif
|
|
|
|
{}
|
|
|
|
};
|
|
|
|
|
2019-09-17 07:32:24 +08:00
|
|
|
static const struct dmi_system_id nine_bytes_report[] = {
|
|
|
|
#if defined(CONFIG_DMI) && defined(CONFIG_X86)
|
|
|
|
{
|
|
|
|
.ident = "Lenovo YogaBook",
|
|
|
|
/* YB1-X91L/F and YB1-X90L/F */
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X9")
|
|
|
|
}
|
|
|
|
},
|
|
|
|
#endif
|
|
|
|
{}
|
|
|
|
};
|
|
|
|
|
2020-03-06 11:53:06 +08:00
|
|
|
/*
|
|
|
|
* Those tablets have their x coordinate inverted
|
|
|
|
*/
|
|
|
|
static const struct dmi_system_id inverted_x_screen[] = {
|
|
|
|
#if defined(CONFIG_DMI) && defined(CONFIG_X86)
|
|
|
|
{
|
|
|
|
.ident = "Cube I15-TC",
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_SYS_VENDOR, "Cube"),
|
|
|
|
DMI_MATCH(DMI_PRODUCT_NAME, "I15-TC")
|
|
|
|
},
|
|
|
|
},
|
|
|
|
#endif
|
|
|
|
{}
|
|
|
|
};
|
|
|
|
|
2014-11-01 00:26:16 +08:00
|
|
|
/**
|
|
|
|
* goodix_i2c_read - read data from a register of the i2c slave device.
|
|
|
|
*
|
|
|
|
* @client: i2c device.
|
|
|
|
* @reg: the register to read from.
|
|
|
|
* @buf: raw write data buffer.
|
|
|
|
* @len: length of the buffer to write
|
|
|
|
*/
|
|
|
|
static int goodix_i2c_read(struct i2c_client *client,
|
2015-06-10 02:01:38 +08:00
|
|
|
u16 reg, u8 *buf, int len)
|
2014-11-01 00:26:16 +08:00
|
|
|
{
|
|
|
|
struct i2c_msg msgs[2];
|
2018-01-27 03:08:59 +08:00
|
|
|
__be16 wbuf = cpu_to_be16(reg);
|
2014-11-01 00:26:16 +08:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
msgs[0].flags = 0;
|
|
|
|
msgs[0].addr = client->addr;
|
|
|
|
msgs[0].len = 2;
|
2015-06-10 02:01:38 +08:00
|
|
|
msgs[0].buf = (u8 *)&wbuf;
|
2014-11-01 00:26:16 +08:00
|
|
|
|
|
|
|
msgs[1].flags = I2C_M_RD;
|
|
|
|
msgs[1].addr = client->addr;
|
|
|
|
msgs[1].len = len;
|
|
|
|
msgs[1].buf = buf;
|
|
|
|
|
|
|
|
ret = i2c_transfer(client->adapter, msgs, 2);
|
|
|
|
return ret < 0 ? ret : (ret != ARRAY_SIZE(msgs) ? -EIO : 0);
|
|
|
|
}
|
|
|
|
|
2015-12-18 08:05:42 +08:00
|
|
|
/**
|
|
|
|
* goodix_i2c_write - write data to a register of the i2c slave device.
|
|
|
|
*
|
|
|
|
* @client: i2c device.
|
|
|
|
* @reg: the register to write to.
|
|
|
|
* @buf: raw data buffer to write.
|
|
|
|
* @len: length of the buffer to write
|
|
|
|
*/
|
|
|
|
static int goodix_i2c_write(struct i2c_client *client, u16 reg, const u8 *buf,
|
|
|
|
unsigned len)
|
|
|
|
{
|
|
|
|
u8 *addr_buf;
|
|
|
|
struct i2c_msg msg;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
addr_buf = kmalloc(len + 2, GFP_KERNEL);
|
|
|
|
if (!addr_buf)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
addr_buf[0] = reg >> 8;
|
|
|
|
addr_buf[1] = reg & 0xFF;
|
|
|
|
memcpy(&addr_buf[2], buf, len);
|
|
|
|
|
|
|
|
msg.flags = 0;
|
|
|
|
msg.addr = client->addr;
|
|
|
|
msg.buf = addr_buf;
|
|
|
|
msg.len = len + 2;
|
|
|
|
|
|
|
|
ret = i2c_transfer(client->adapter, &msg, 1);
|
|
|
|
kfree(addr_buf);
|
|
|
|
return ret < 0 ? ret : (ret != 1 ? -EIO : 0);
|
|
|
|
}
|
|
|
|
|
2015-12-18 08:43:39 +08:00
|
|
|
static int goodix_i2c_write_u8(struct i2c_client *client, u16 reg, u8 value)
|
|
|
|
{
|
|
|
|
return goodix_i2c_write(client, reg, &value, sizeof(value));
|
|
|
|
}
|
|
|
|
|
2020-03-25 02:57:58 +08:00
|
|
|
static const struct goodix_chip_data *goodix_get_chip_data(const char *id)
|
2015-12-18 07:55:21 +08:00
|
|
|
{
|
2020-03-25 02:57:58 +08:00
|
|
|
unsigned int i;
|
2015-12-18 07:55:21 +08:00
|
|
|
|
2020-03-25 02:57:58 +08:00
|
|
|
for (i = 0; goodix_chip_ids[i].id; i++) {
|
|
|
|
if (!strcmp(goodix_chip_ids[i].id, id))
|
|
|
|
return goodix_chip_ids[i].data;
|
2015-12-18 07:55:21 +08:00
|
|
|
}
|
2020-03-25 02:57:58 +08:00
|
|
|
|
|
|
|
return >9x_chip_data;
|
2015-12-18 07:55:21 +08:00
|
|
|
}
|
|
|
|
|
2014-11-01 00:26:16 +08:00
|
|
|
static int goodix_ts_read_input_report(struct goodix_ts_data *ts, u8 *data)
|
|
|
|
{
|
Input: goodix - poll the 'buffer status' bit before reading data
The Goodix panel triggers an interrupt on touch events. However, its
registers will contain the valid values a short time after the
interrupt, and not when it's raised. At that moment, the 'buffer status'
bit is set.
Previously, if the 'buffer status' bit was not set when the registers
were read, the data was discarded and no input event was emitted,
causing "finger down" or "finger up" events to be missed sometimes.
This went unnoticed until v4.9, as the DesignWare I2C driver commonly
used with this driver had enough latency for that bug to never trigger
until commit 2702ea7dbec5 ("i2c: designware: wait for disable/enable only
if necessary").
Now, in the IRQ handler we will poll (with a timeout) the 'buffer status'
bit and process the data of the panel as soon as this bit gets set.
Note that the Goodix panel will send a few spurious interrupts after the
'finger up' event, in which the 'buffer status' bit will never be set.
Cc: Bastien Nocera <hadess@hadess.net>
Cc: russianneuromancer@ya.ru
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
[hdegoede@redhat.com: Change poll loop to use jiffies,
add comment about typical poll time]
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
[dtor: rearranged control flow a bit to avoid explicit goto and double
check]
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2017-10-14 02:04:48 +08:00
|
|
|
unsigned long max_timeout;
|
2014-11-01 00:26:16 +08:00
|
|
|
int touch_num;
|
|
|
|
int error;
|
2020-03-25 02:38:49 +08:00
|
|
|
u16 addr = GOODIX_READ_COOR_ADDR;
|
|
|
|
/*
|
|
|
|
* We are going to read 1-byte header,
|
|
|
|
* ts->contact_size * max(1, touch_num) bytes of coordinates
|
|
|
|
* and 1-byte footer which contains the touch-key code.
|
|
|
|
*/
|
|
|
|
const int header_contact_keycode_size = 1 + ts->contact_size + 1;
|
2014-11-01 00:26:16 +08:00
|
|
|
|
Input: goodix - poll the 'buffer status' bit before reading data
The Goodix panel triggers an interrupt on touch events. However, its
registers will contain the valid values a short time after the
interrupt, and not when it's raised. At that moment, the 'buffer status'
bit is set.
Previously, if the 'buffer status' bit was not set when the registers
were read, the data was discarded and no input event was emitted,
causing "finger down" or "finger up" events to be missed sometimes.
This went unnoticed until v4.9, as the DesignWare I2C driver commonly
used with this driver had enough latency for that bug to never trigger
until commit 2702ea7dbec5 ("i2c: designware: wait for disable/enable only
if necessary").
Now, in the IRQ handler we will poll (with a timeout) the 'buffer status'
bit and process the data of the panel as soon as this bit gets set.
Note that the Goodix panel will send a few spurious interrupts after the
'finger up' event, in which the 'buffer status' bit will never be set.
Cc: Bastien Nocera <hadess@hadess.net>
Cc: russianneuromancer@ya.ru
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
[hdegoede@redhat.com: Change poll loop to use jiffies,
add comment about typical poll time]
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
[dtor: rearranged control flow a bit to avoid explicit goto and double
check]
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2017-10-14 02:04:48 +08:00
|
|
|
/*
|
|
|
|
* The 'buffer status' bit, which indicates that the data is valid, is
|
|
|
|
* not set as soon as the interrupt is raised, but slightly after.
|
|
|
|
* This takes around 10 ms to happen, so we poll for 20 ms.
|
|
|
|
*/
|
|
|
|
max_timeout = jiffies + msecs_to_jiffies(GOODIX_BUFFER_STATUS_TIMEOUT);
|
|
|
|
do {
|
2020-03-25 02:38:49 +08:00
|
|
|
error = goodix_i2c_read(ts->client, addr, data,
|
|
|
|
header_contact_keycode_size);
|
Input: goodix - poll the 'buffer status' bit before reading data
The Goodix panel triggers an interrupt on touch events. However, its
registers will contain the valid values a short time after the
interrupt, and not when it's raised. At that moment, the 'buffer status'
bit is set.
Previously, if the 'buffer status' bit was not set when the registers
were read, the data was discarded and no input event was emitted,
causing "finger down" or "finger up" events to be missed sometimes.
This went unnoticed until v4.9, as the DesignWare I2C driver commonly
used with this driver had enough latency for that bug to never trigger
until commit 2702ea7dbec5 ("i2c: designware: wait for disable/enable only
if necessary").
Now, in the IRQ handler we will poll (with a timeout) the 'buffer status'
bit and process the data of the panel as soon as this bit gets set.
Note that the Goodix panel will send a few spurious interrupts after the
'finger up' event, in which the 'buffer status' bit will never be set.
Cc: Bastien Nocera <hadess@hadess.net>
Cc: russianneuromancer@ya.ru
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
[hdegoede@redhat.com: Change poll loop to use jiffies,
add comment about typical poll time]
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
[dtor: rearranged control flow a bit to avoid explicit goto and double
check]
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2017-10-14 02:04:48 +08:00
|
|
|
if (error) {
|
|
|
|
dev_err(&ts->client->dev, "I2C transfer error: %d\n",
|
|
|
|
error);
|
2014-11-01 00:26:16 +08:00
|
|
|
return error;
|
Input: goodix - poll the 'buffer status' bit before reading data
The Goodix panel triggers an interrupt on touch events. However, its
registers will contain the valid values a short time after the
interrupt, and not when it's raised. At that moment, the 'buffer status'
bit is set.
Previously, if the 'buffer status' bit was not set when the registers
were read, the data was discarded and no input event was emitted,
causing "finger down" or "finger up" events to be missed sometimes.
This went unnoticed until v4.9, as the DesignWare I2C driver commonly
used with this driver had enough latency for that bug to never trigger
until commit 2702ea7dbec5 ("i2c: designware: wait for disable/enable only
if necessary").
Now, in the IRQ handler we will poll (with a timeout) the 'buffer status'
bit and process the data of the panel as soon as this bit gets set.
Note that the Goodix panel will send a few spurious interrupts after the
'finger up' event, in which the 'buffer status' bit will never be set.
Cc: Bastien Nocera <hadess@hadess.net>
Cc: russianneuromancer@ya.ru
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
[hdegoede@redhat.com: Change poll loop to use jiffies,
add comment about typical poll time]
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
[dtor: rearranged control flow a bit to avoid explicit goto and double
check]
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2017-10-14 02:04:48 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (data[0] & GOODIX_BUFFER_STATUS_READY) {
|
|
|
|
touch_num = data[0] & 0x0f;
|
|
|
|
if (touch_num > ts->max_touch_num)
|
|
|
|
return -EPROTO;
|
|
|
|
|
|
|
|
if (touch_num > 1) {
|
2020-03-25 02:38:49 +08:00
|
|
|
addr += header_contact_keycode_size;
|
|
|
|
data += header_contact_keycode_size;
|
Input: goodix - poll the 'buffer status' bit before reading data
The Goodix panel triggers an interrupt on touch events. However, its
registers will contain the valid values a short time after the
interrupt, and not when it's raised. At that moment, the 'buffer status'
bit is set.
Previously, if the 'buffer status' bit was not set when the registers
were read, the data was discarded and no input event was emitted,
causing "finger down" or "finger up" events to be missed sometimes.
This went unnoticed until v4.9, as the DesignWare I2C driver commonly
used with this driver had enough latency for that bug to never trigger
until commit 2702ea7dbec5 ("i2c: designware: wait for disable/enable only
if necessary").
Now, in the IRQ handler we will poll (with a timeout) the 'buffer status'
bit and process the data of the panel as soon as this bit gets set.
Note that the Goodix panel will send a few spurious interrupts after the
'finger up' event, in which the 'buffer status' bit will never be set.
Cc: Bastien Nocera <hadess@hadess.net>
Cc: russianneuromancer@ya.ru
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
[hdegoede@redhat.com: Change poll loop to use jiffies,
add comment about typical poll time]
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
[dtor: rearranged control flow a bit to avoid explicit goto and double
check]
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2017-10-14 02:04:48 +08:00
|
|
|
error = goodix_i2c_read(ts->client,
|
2020-03-25 02:38:49 +08:00
|
|
|
addr, data,
|
2019-09-17 07:32:24 +08:00
|
|
|
ts->contact_size *
|
Input: goodix - poll the 'buffer status' bit before reading data
The Goodix panel triggers an interrupt on touch events. However, its
registers will contain the valid values a short time after the
interrupt, and not when it's raised. At that moment, the 'buffer status'
bit is set.
Previously, if the 'buffer status' bit was not set when the registers
were read, the data was discarded and no input event was emitted,
causing "finger down" or "finger up" events to be missed sometimes.
This went unnoticed until v4.9, as the DesignWare I2C driver commonly
used with this driver had enough latency for that bug to never trigger
until commit 2702ea7dbec5 ("i2c: designware: wait for disable/enable only
if necessary").
Now, in the IRQ handler we will poll (with a timeout) the 'buffer status'
bit and process the data of the panel as soon as this bit gets set.
Note that the Goodix panel will send a few spurious interrupts after the
'finger up' event, in which the 'buffer status' bit will never be set.
Cc: Bastien Nocera <hadess@hadess.net>
Cc: russianneuromancer@ya.ru
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
[hdegoede@redhat.com: Change poll loop to use jiffies,
add comment about typical poll time]
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
[dtor: rearranged control flow a bit to avoid explicit goto and double
check]
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2017-10-14 02:04:48 +08:00
|
|
|
(touch_num - 1));
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
return touch_num;
|
|
|
|
}
|
|
|
|
|
|
|
|
usleep_range(1000, 2000); /* Poll every 1 - 2 ms */
|
|
|
|
} while (time_before(jiffies, max_timeout));
|
2014-11-01 00:26:16 +08:00
|
|
|
|
Input: goodix - poll the 'buffer status' bit before reading data
The Goodix panel triggers an interrupt on touch events. However, its
registers will contain the valid values a short time after the
interrupt, and not when it's raised. At that moment, the 'buffer status'
bit is set.
Previously, if the 'buffer status' bit was not set when the registers
were read, the data was discarded and no input event was emitted,
causing "finger down" or "finger up" events to be missed sometimes.
This went unnoticed until v4.9, as the DesignWare I2C driver commonly
used with this driver had enough latency for that bug to never trigger
until commit 2702ea7dbec5 ("i2c: designware: wait for disable/enable only
if necessary").
Now, in the IRQ handler we will poll (with a timeout) the 'buffer status'
bit and process the data of the panel as soon as this bit gets set.
Note that the Goodix panel will send a few spurious interrupts after the
'finger up' event, in which the 'buffer status' bit will never be set.
Cc: Bastien Nocera <hadess@hadess.net>
Cc: russianneuromancer@ya.ru
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
[hdegoede@redhat.com: Change poll loop to use jiffies,
add comment about typical poll time]
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
[dtor: rearranged control flow a bit to avoid explicit goto and double
check]
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2017-10-14 02:04:48 +08:00
|
|
|
/*
|
|
|
|
* The Goodix panel will send spurious interrupts after a
|
|
|
|
* 'finger up' event, which will always cause a timeout.
|
|
|
|
*/
|
2020-03-25 02:38:28 +08:00
|
|
|
return -ENOMSG;
|
2014-11-01 00:26:16 +08:00
|
|
|
}
|
|
|
|
|
2019-09-17 07:32:24 +08:00
|
|
|
static void goodix_ts_report_touch_8b(struct goodix_ts_data *ts, u8 *coor_data)
|
2014-11-01 00:26:16 +08:00
|
|
|
{
|
|
|
|
int id = coor_data[0] & 0x0F;
|
|
|
|
int input_x = get_unaligned_le16(&coor_data[1]);
|
|
|
|
int input_y = get_unaligned_le16(&coor_data[3]);
|
|
|
|
int input_w = get_unaligned_le16(&coor_data[5]);
|
|
|
|
|
|
|
|
input_mt_slot(ts->input_dev, id);
|
|
|
|
input_mt_report_slot_state(ts->input_dev, MT_TOOL_FINGER, true);
|
2018-01-27 03:08:59 +08:00
|
|
|
touchscreen_report_pos(ts->input_dev, &ts->prop,
|
|
|
|
input_x, input_y, true);
|
2014-11-01 00:26:16 +08:00
|
|
|
input_report_abs(ts->input_dev, ABS_MT_TOUCH_MAJOR, input_w);
|
|
|
|
input_report_abs(ts->input_dev, ABS_MT_WIDTH_MAJOR, input_w);
|
|
|
|
}
|
|
|
|
|
2019-09-17 07:32:24 +08:00
|
|
|
static void goodix_ts_report_touch_9b(struct goodix_ts_data *ts, u8 *coor_data)
|
|
|
|
{
|
|
|
|
int id = coor_data[1] & 0x0F;
|
|
|
|
int input_x = get_unaligned_le16(&coor_data[3]);
|
|
|
|
int input_y = get_unaligned_le16(&coor_data[5]);
|
|
|
|
int input_w = get_unaligned_le16(&coor_data[7]);
|
|
|
|
|
|
|
|
input_mt_slot(ts->input_dev, id);
|
|
|
|
input_mt_report_slot_state(ts->input_dev, MT_TOOL_FINGER, true);
|
|
|
|
touchscreen_report_pos(ts->input_dev, &ts->prop,
|
|
|
|
input_x, input_y, true);
|
|
|
|
input_report_abs(ts->input_dev, ABS_MT_TOUCH_MAJOR, input_w);
|
|
|
|
input_report_abs(ts->input_dev, ABS_MT_WIDTH_MAJOR, input_w);
|
|
|
|
}
|
|
|
|
|
2020-03-25 02:38:49 +08:00
|
|
|
static void goodix_ts_report_key(struct goodix_ts_data *ts, u8 *data)
|
|
|
|
{
|
|
|
|
int touch_num;
|
|
|
|
u8 key_value;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
if (data[0] & GOODIX_HAVE_KEY) {
|
|
|
|
touch_num = data[0] & 0x0f;
|
|
|
|
key_value = data[1 + ts->contact_size * touch_num];
|
|
|
|
for (i = 0; i < GOODIX_MAX_KEYS; i++)
|
|
|
|
if (key_value & BIT(i))
|
|
|
|
input_report_key(ts->input_dev,
|
|
|
|
ts->keymap[i], 1);
|
|
|
|
} else {
|
|
|
|
for (i = 0; i < GOODIX_MAX_KEYS; i++)
|
|
|
|
input_report_key(ts->input_dev, ts->keymap[i], 0);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-11-01 00:26:16 +08:00
|
|
|
/**
|
|
|
|
* goodix_process_events - Process incoming events
|
|
|
|
*
|
|
|
|
* @ts: our goodix_ts_data pointer
|
|
|
|
*
|
|
|
|
* Called when the IRQ is triggered. Read the current device state, and push
|
|
|
|
* the input events to the user space.
|
|
|
|
*/
|
|
|
|
static void goodix_process_events(struct goodix_ts_data *ts)
|
|
|
|
{
|
2020-03-25 02:38:49 +08:00
|
|
|
u8 point_data[2 + GOODIX_MAX_CONTACT_SIZE * GOODIX_MAX_CONTACTS];
|
2014-11-01 00:26:16 +08:00
|
|
|
int touch_num;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
touch_num = goodix_ts_read_input_report(ts, point_data);
|
|
|
|
if (touch_num < 0)
|
|
|
|
return;
|
|
|
|
|
2020-03-25 02:38:49 +08:00
|
|
|
goodix_ts_report_key(ts, point_data);
|
2017-09-07 08:29:24 +08:00
|
|
|
|
2014-11-01 00:26:16 +08:00
|
|
|
for (i = 0; i < touch_num; i++)
|
2019-09-17 07:32:24 +08:00
|
|
|
if (ts->contact_size == 9)
|
|
|
|
goodix_ts_report_touch_9b(ts,
|
|
|
|
&point_data[1 + ts->contact_size * i]);
|
|
|
|
else
|
|
|
|
goodix_ts_report_touch_8b(ts,
|
|
|
|
&point_data[1 + ts->contact_size * i]);
|
2014-11-01 00:26:16 +08:00
|
|
|
|
|
|
|
input_mt_sync_frame(ts->input_dev);
|
|
|
|
input_sync(ts->input_dev);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* goodix_ts_irq_handler - The IRQ handler
|
|
|
|
*
|
|
|
|
* @irq: interrupt number.
|
|
|
|
* @dev_id: private data pointer.
|
|
|
|
*/
|
|
|
|
static irqreturn_t goodix_ts_irq_handler(int irq, void *dev_id)
|
|
|
|
{
|
|
|
|
struct goodix_ts_data *ts = dev_id;
|
|
|
|
|
|
|
|
goodix_process_events(ts);
|
|
|
|
|
2015-12-18 08:47:42 +08:00
|
|
|
if (goodix_i2c_write_u8(ts->client, GOODIX_READ_COOR_ADDR, 0) < 0)
|
2014-11-01 00:26:16 +08:00
|
|
|
dev_err(&ts->client->dev, "I2C write end_cmd error\n");
|
|
|
|
|
|
|
|
return IRQ_HANDLED;
|
|
|
|
}
|
|
|
|
|
2015-12-18 08:43:39 +08:00
|
|
|
static void goodix_free_irq(struct goodix_ts_data *ts)
|
|
|
|
{
|
|
|
|
devm_free_irq(&ts->client->dev, ts->client->irq, ts);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int goodix_request_irq(struct goodix_ts_data *ts)
|
|
|
|
{
|
|
|
|
return devm_request_threaded_irq(&ts->client->dev, ts->client->irq,
|
|
|
|
NULL, goodix_ts_irq_handler,
|
|
|
|
ts->irq_flags, ts->client->name, ts);
|
|
|
|
}
|
|
|
|
|
2020-03-25 02:33:50 +08:00
|
|
|
static int goodix_check_cfg_8(struct goodix_ts_data *ts, const u8 *cfg, int len)
|
2015-12-18 08:05:42 +08:00
|
|
|
{
|
2020-03-25 02:33:50 +08:00
|
|
|
int i, raw_cfg_len = len - 2;
|
2015-12-18 08:05:42 +08:00
|
|
|
u8 check_sum = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < raw_cfg_len; i++)
|
2020-03-25 02:33:50 +08:00
|
|
|
check_sum += cfg[i];
|
2015-12-18 08:05:42 +08:00
|
|
|
check_sum = (~check_sum) + 1;
|
2020-03-25 02:33:50 +08:00
|
|
|
if (check_sum != cfg[raw_cfg_len]) {
|
2015-12-18 08:05:42 +08:00
|
|
|
dev_err(&ts->client->dev,
|
|
|
|
"The checksum of the config fw is not correct");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2020-03-25 02:33:50 +08:00
|
|
|
if (cfg[raw_cfg_len + 1] != 1) {
|
2015-12-18 08:05:42 +08:00
|
|
|
dev_err(&ts->client->dev,
|
|
|
|
"Config fw must have Config_Fresh register set");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-03-25 02:29:26 +08:00
|
|
|
static void goodix_calc_cfg_checksum_8(struct goodix_ts_data *ts)
|
|
|
|
{
|
|
|
|
int i, raw_cfg_len = ts->chip->config_len - 2;
|
|
|
|
u8 check_sum = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < raw_cfg_len; i++)
|
|
|
|
check_sum += ts->config[i];
|
|
|
|
check_sum = (~check_sum) + 1;
|
|
|
|
|
|
|
|
ts->config[raw_cfg_len] = check_sum;
|
|
|
|
ts->config[raw_cfg_len + 1] = 1; /* Set "config_fresh" bit */
|
|
|
|
}
|
|
|
|
|
2020-03-25 02:33:50 +08:00
|
|
|
static int goodix_check_cfg_16(struct goodix_ts_data *ts, const u8 *cfg,
|
|
|
|
int len)
|
2017-10-25 02:06:41 +08:00
|
|
|
{
|
2020-03-25 02:33:50 +08:00
|
|
|
int i, raw_cfg_len = len - 3;
|
2017-10-25 02:06:41 +08:00
|
|
|
u16 check_sum = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < raw_cfg_len; i += 2)
|
2020-03-25 02:33:50 +08:00
|
|
|
check_sum += get_unaligned_be16(&cfg[i]);
|
2017-10-25 02:06:41 +08:00
|
|
|
check_sum = (~check_sum) + 1;
|
2020-03-25 02:33:50 +08:00
|
|
|
if (check_sum != get_unaligned_be16(&cfg[raw_cfg_len])) {
|
2017-10-25 02:06:41 +08:00
|
|
|
dev_err(&ts->client->dev,
|
|
|
|
"The checksum of the config fw is not correct");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2020-03-25 02:33:50 +08:00
|
|
|
if (cfg[raw_cfg_len + 2] != 1) {
|
2017-10-25 02:06:41 +08:00
|
|
|
dev_err(&ts->client->dev,
|
|
|
|
"Config fw must have Config_Fresh register set");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-03-25 02:29:26 +08:00
|
|
|
static void goodix_calc_cfg_checksum_16(struct goodix_ts_data *ts)
|
|
|
|
{
|
|
|
|
int i, raw_cfg_len = ts->chip->config_len - 3;
|
|
|
|
u16 check_sum = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < raw_cfg_len; i += 2)
|
|
|
|
check_sum += get_unaligned_be16(&ts->config[i]);
|
|
|
|
check_sum = (~check_sum) + 1;
|
|
|
|
|
|
|
|
put_unaligned_be16(check_sum, &ts->config[raw_cfg_len]);
|
|
|
|
ts->config[raw_cfg_len + 2] = 1; /* Set "config_fresh" bit */
|
|
|
|
}
|
|
|
|
|
2017-10-25 02:06:41 +08:00
|
|
|
/**
|
|
|
|
* goodix_check_cfg - Checks if config fw is valid
|
|
|
|
*
|
|
|
|
* @ts: goodix_ts_data pointer
|
|
|
|
* @cfg: firmware config data
|
2020-11-20 11:12:42 +08:00
|
|
|
* @len: config data length
|
2017-10-25 02:06:41 +08:00
|
|
|
*/
|
2020-03-25 02:33:50 +08:00
|
|
|
static int goodix_check_cfg(struct goodix_ts_data *ts, const u8 *cfg, int len)
|
2017-10-25 02:06:41 +08:00
|
|
|
{
|
2020-03-25 02:33:50 +08:00
|
|
|
if (len < GOODIX_CONFIG_MIN_LENGTH ||
|
|
|
|
len > GOODIX_CONFIG_MAX_LENGTH) {
|
2017-10-25 02:06:41 +08:00
|
|
|
dev_err(&ts->client->dev,
|
|
|
|
"The length of the config fw is not correct");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2020-03-25 02:33:50 +08:00
|
|
|
return ts->chip->check_config(ts, cfg, len);
|
2017-10-25 02:06:41 +08:00
|
|
|
}
|
|
|
|
|
2015-12-18 08:05:42 +08:00
|
|
|
/**
|
|
|
|
* goodix_send_cfg - Write fw config to device
|
|
|
|
*
|
|
|
|
* @ts: goodix_ts_data pointer
|
|
|
|
* @cfg: config firmware to write to device
|
2020-11-20 11:12:42 +08:00
|
|
|
* @len: config data length
|
2015-12-18 08:05:42 +08:00
|
|
|
*/
|
2020-03-25 02:33:50 +08:00
|
|
|
static int goodix_send_cfg(struct goodix_ts_data *ts, const u8 *cfg, int len)
|
2015-12-18 08:05:42 +08:00
|
|
|
{
|
|
|
|
int error;
|
|
|
|
|
2020-03-25 02:33:50 +08:00
|
|
|
error = goodix_check_cfg(ts, cfg, len);
|
2015-12-18 08:05:42 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
2020-03-25 02:33:50 +08:00
|
|
|
error = goodix_i2c_write(ts->client, ts->chip->config_addr, cfg, len);
|
2015-12-18 08:05:42 +08:00
|
|
|
if (error) {
|
|
|
|
dev_err(&ts->client->dev, "Failed to write config data: %d",
|
|
|
|
error);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
dev_dbg(&ts->client->dev, "Config sent successfully.");
|
|
|
|
|
|
|
|
/* Let the firmware reconfigure itself, so sleep for 10ms */
|
|
|
|
usleep_range(10000, 11000);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-04-02 03:53:36 +08:00
|
|
|
#ifdef ACPI_GPIO_SUPPORT
|
|
|
|
static int goodix_pin_acpi_direction_input(struct goodix_ts_data *ts)
|
2020-03-25 02:12:10 +08:00
|
|
|
{
|
2020-04-02 03:53:36 +08:00
|
|
|
acpi_handle handle = ACPI_HANDLE(&ts->client->dev);
|
2020-03-25 02:24:31 +08:00
|
|
|
acpi_status status;
|
|
|
|
|
2020-04-02 03:53:36 +08:00
|
|
|
status = acpi_evaluate_object(handle, "INTI", NULL, NULL);
|
|
|
|
return ACPI_SUCCESS(status) ? 0 : -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int goodix_pin_acpi_output_method(struct goodix_ts_data *ts, int value)
|
|
|
|
{
|
|
|
|
acpi_handle handle = ACPI_HANDLE(&ts->client->dev);
|
|
|
|
acpi_status status;
|
|
|
|
|
|
|
|
status = acpi_execute_simple_method(handle, "INTO", value);
|
|
|
|
return ACPI_SUCCESS(status) ? 0 : -EIO;
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static int goodix_pin_acpi_direction_input(struct goodix_ts_data *ts)
|
|
|
|
{
|
|
|
|
dev_err(&ts->client->dev,
|
|
|
|
"%s called on device without ACPI support\n", __func__);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int goodix_pin_acpi_output_method(struct goodix_ts_data *ts, int value)
|
|
|
|
{
|
|
|
|
dev_err(&ts->client->dev,
|
|
|
|
"%s called on device without ACPI support\n", __func__);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
static int goodix_irq_direction_output(struct goodix_ts_data *ts, int value)
|
|
|
|
{
|
2020-03-25 02:12:10 +08:00
|
|
|
switch (ts->irq_pin_access_method) {
|
|
|
|
case IRQ_PIN_ACCESS_NONE:
|
|
|
|
dev_err(&ts->client->dev,
|
|
|
|
"%s called without an irq_pin_access_method set\n",
|
|
|
|
__func__);
|
|
|
|
return -EINVAL;
|
|
|
|
case IRQ_PIN_ACCESS_GPIO:
|
|
|
|
return gpiod_direction_output(ts->gpiod_int, value);
|
Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices
On most Cherry Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 1 GpioInt and 1 GpioIo resource in their _CRS table:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\_SB.PCI0.I2C2",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Edge, ActiveLow, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0013
}
GpioIo (Shared, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0019
}
})
Return (RBUF) /* \_SB_.PCI0.I2C2.TCS1._CRS.RBUF */
}
There is no fixed order for these 2. This commit adds code to check that
there is 1 of each as expected and then registers a mapping matching their
order using devm_acpi_dev_add_driver_gpios().
This gives us access to both GPIOs allowing us to properly suspend the
controller during suspend, and making it possible to reset the controller
if necessary.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20200307121505.3707-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:21 +08:00
|
|
|
case IRQ_PIN_ACCESS_ACPI_GPIO:
|
|
|
|
/*
|
|
|
|
* The IRQ pin triggers on a falling edge, so its gets marked
|
|
|
|
* as active-low, use output_raw to avoid the value inversion.
|
|
|
|
*/
|
|
|
|
return gpiod_direction_output_raw(ts->gpiod_int, value);
|
2020-03-25 02:24:31 +08:00
|
|
|
case IRQ_PIN_ACCESS_ACPI_METHOD:
|
2020-04-02 03:53:36 +08:00
|
|
|
return goodix_pin_acpi_output_method(ts, value);
|
2020-03-25 02:12:10 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return -EINVAL; /* Never reached */
|
|
|
|
}
|
|
|
|
|
|
|
|
static int goodix_irq_direction_input(struct goodix_ts_data *ts)
|
|
|
|
{
|
|
|
|
switch (ts->irq_pin_access_method) {
|
|
|
|
case IRQ_PIN_ACCESS_NONE:
|
|
|
|
dev_err(&ts->client->dev,
|
|
|
|
"%s called without an irq_pin_access_method set\n",
|
|
|
|
__func__);
|
|
|
|
return -EINVAL;
|
|
|
|
case IRQ_PIN_ACCESS_GPIO:
|
2020-04-02 03:53:36 +08:00
|
|
|
return gpiod_direction_input(ts->gpiod_int);
|
Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices
On most Cherry Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 1 GpioInt and 1 GpioIo resource in their _CRS table:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\_SB.PCI0.I2C2",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Edge, ActiveLow, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0013
}
GpioIo (Shared, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0019
}
})
Return (RBUF) /* \_SB_.PCI0.I2C2.TCS1._CRS.RBUF */
}
There is no fixed order for these 2. This commit adds code to check that
there is 1 of each as expected and then registers a mapping matching their
order using devm_acpi_dev_add_driver_gpios().
This gives us access to both GPIOs allowing us to properly suspend the
controller during suspend, and making it possible to reset the controller
if necessary.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20200307121505.3707-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:21 +08:00
|
|
|
case IRQ_PIN_ACCESS_ACPI_GPIO:
|
2020-03-25 02:12:10 +08:00
|
|
|
return gpiod_direction_input(ts->gpiod_int);
|
2020-03-25 02:24:31 +08:00
|
|
|
case IRQ_PIN_ACCESS_ACPI_METHOD:
|
2020-04-02 03:53:36 +08:00
|
|
|
return goodix_pin_acpi_direction_input(ts);
|
2020-03-25 02:12:10 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return -EINVAL; /* Never reached */
|
|
|
|
}
|
|
|
|
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
static int goodix_int_sync(struct goodix_ts_data *ts)
|
|
|
|
{
|
|
|
|
int error;
|
|
|
|
|
2020-03-25 02:12:10 +08:00
|
|
|
error = goodix_irq_direction_output(ts, 0);
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
msleep(50); /* T5: 50ms */
|
|
|
|
|
2020-03-25 02:12:10 +08:00
|
|
|
error = goodix_irq_direction_input(ts);
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* goodix_reset - Reset device during power on
|
|
|
|
*
|
|
|
|
* @ts: goodix_ts_data pointer
|
|
|
|
*/
|
|
|
|
static int goodix_reset(struct goodix_ts_data *ts)
|
|
|
|
{
|
|
|
|
int error;
|
|
|
|
|
|
|
|
/* begin select I2C slave addr */
|
|
|
|
error = gpiod_direction_output(ts->gpiod_rst, 0);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
msleep(20); /* T2: > 10ms */
|
|
|
|
|
|
|
|
/* HIGH: 0x28/0x29, LOW: 0xBA/0xBB */
|
2020-03-25 02:12:10 +08:00
|
|
|
error = goodix_irq_direction_output(ts, ts->client->addr == 0x14);
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
usleep_range(100, 2000); /* T3: > 100us */
|
|
|
|
|
|
|
|
error = gpiod_direction_output(ts->gpiod_rst, 1);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
usleep_range(6000, 10000); /* T4: > 5ms */
|
|
|
|
|
|
|
|
/* end select I2C slave addr */
|
|
|
|
error = gpiod_direction_input(ts->gpiod_rst);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
error = goodix_int_sync(ts);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-04-02 03:53:36 +08:00
|
|
|
#ifdef ACPI_GPIO_SUPPORT
|
Input: goodix - add support for getting IRQ + reset GPIOs on Bay Trail devices
On most Bay Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 2 GpioIo resource in their _CRS table, on all 4 such
devices which I have access to, the order of the 2 GPIOs is reset, int.
Note that the GPIO to which the touchscreen controller irq pin is connected
is configured in direct-irq mode on these Bay Trail devices, the
pinctrl-baytrail.c driver still allows controlling the pin as a GPIO in
this case, but this is not necessarily the case on other X86 ACPI
platforms, nor do we have a guarantee that the GPIO order is the same
elsewhere, so we limit the use of a _CRS table with 2 GpioIo resources
to Bay Trail devices only.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20200307121505.3707-5-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:35 +08:00
|
|
|
#include <asm/cpu_device_id.h>
|
|
|
|
#include <asm/intel-family.h>
|
|
|
|
|
|
|
|
static const struct x86_cpu_id baytrail_cpu_ids[] = {
|
|
|
|
{ X86_VENDOR_INTEL, 6, INTEL_FAM6_ATOM_SILVERMONT, X86_FEATURE_ANY, },
|
|
|
|
{}
|
|
|
|
};
|
|
|
|
|
|
|
|
static inline bool is_byt(void)
|
|
|
|
{
|
|
|
|
const struct x86_cpu_id *id = x86_match_cpu(baytrail_cpu_ids);
|
|
|
|
|
|
|
|
return !!id;
|
|
|
|
}
|
|
|
|
|
Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices
On most Cherry Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 1 GpioInt and 1 GpioIo resource in their _CRS table:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\_SB.PCI0.I2C2",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Edge, ActiveLow, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0013
}
GpioIo (Shared, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0019
}
})
Return (RBUF) /* \_SB_.PCI0.I2C2.TCS1._CRS.RBUF */
}
There is no fixed order for these 2. This commit adds code to check that
there is 1 of each as expected and then registers a mapping matching their
order using devm_acpi_dev_add_driver_gpios().
This gives us access to both GPIOs allowing us to properly suspend the
controller during suspend, and making it possible to reset the controller
if necessary.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20200307121505.3707-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:21 +08:00
|
|
|
static const struct acpi_gpio_params first_gpio = { 0, 0, false };
|
|
|
|
static const struct acpi_gpio_params second_gpio = { 1, 0, false };
|
|
|
|
|
|
|
|
static const struct acpi_gpio_mapping acpi_goodix_int_first_gpios[] = {
|
|
|
|
{ GOODIX_GPIO_INT_NAME "-gpios", &first_gpio, 1 },
|
|
|
|
{ GOODIX_GPIO_RST_NAME "-gpios", &second_gpio, 1 },
|
|
|
|
{ },
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct acpi_gpio_mapping acpi_goodix_int_last_gpios[] = {
|
|
|
|
{ GOODIX_GPIO_RST_NAME "-gpios", &first_gpio, 1 },
|
|
|
|
{ GOODIX_GPIO_INT_NAME "-gpios", &second_gpio, 1 },
|
|
|
|
{ },
|
|
|
|
};
|
|
|
|
|
2020-03-25 02:24:31 +08:00
|
|
|
static const struct acpi_gpio_mapping acpi_goodix_reset_only_gpios[] = {
|
|
|
|
{ GOODIX_GPIO_RST_NAME "-gpios", &first_gpio, 1 },
|
|
|
|
{ },
|
|
|
|
};
|
|
|
|
|
Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices
On most Cherry Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 1 GpioInt and 1 GpioIo resource in their _CRS table:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\_SB.PCI0.I2C2",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Edge, ActiveLow, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0013
}
GpioIo (Shared, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0019
}
})
Return (RBUF) /* \_SB_.PCI0.I2C2.TCS1._CRS.RBUF */
}
There is no fixed order for these 2. This commit adds code to check that
there is 1 of each as expected and then registers a mapping matching their
order using devm_acpi_dev_add_driver_gpios().
This gives us access to both GPIOs allowing us to properly suspend the
controller during suspend, and making it possible to reset the controller
if necessary.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20200307121505.3707-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:21 +08:00
|
|
|
static int goodix_resource(struct acpi_resource *ares, void *data)
|
|
|
|
{
|
|
|
|
struct goodix_ts_data *ts = data;
|
|
|
|
struct device *dev = &ts->client->dev;
|
|
|
|
struct acpi_resource_gpio *gpio;
|
|
|
|
|
|
|
|
switch (ares->type) {
|
|
|
|
case ACPI_RESOURCE_TYPE_GPIO:
|
|
|
|
gpio = &ares->data.gpio;
|
|
|
|
if (gpio->connection_type == ACPI_RESOURCE_GPIO_TYPE_INT) {
|
|
|
|
if (ts->gpio_int_idx == -1) {
|
|
|
|
ts->gpio_int_idx = ts->gpio_count;
|
|
|
|
} else {
|
|
|
|
dev_err(dev, "More then one GpioInt resource, ignoring ACPI GPIO resources\n");
|
|
|
|
ts->gpio_int_idx = -2;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ts->gpio_count++;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This function gets called in case we fail to get the irq GPIO directly
|
|
|
|
* because the ACPI tables lack GPIO-name to APCI _CRS index mappings
|
|
|
|
* (no _DSD UUID daffd814-6eba-4d8c-8a91-bc9bbf4aa301 data).
|
|
|
|
* In that case we add our own mapping and then goodix_get_gpio_config()
|
|
|
|
* retries to get the GPIOs based on the added mapping.
|
|
|
|
*/
|
|
|
|
static int goodix_add_acpi_gpio_mappings(struct goodix_ts_data *ts)
|
|
|
|
{
|
|
|
|
const struct acpi_gpio_mapping *gpio_mapping = NULL;
|
|
|
|
struct device *dev = &ts->client->dev;
|
|
|
|
LIST_HEAD(resources);
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ts->gpio_count = 0;
|
|
|
|
ts->gpio_int_idx = -1;
|
|
|
|
ret = acpi_dev_get_resources(ACPI_COMPANION(dev), &resources,
|
|
|
|
goodix_resource, ts);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(dev, "Error getting ACPI resources: %d\n", ret);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
acpi_dev_free_resource_list(&resources);
|
|
|
|
|
|
|
|
if (ts->gpio_count == 2 && ts->gpio_int_idx == 0) {
|
|
|
|
ts->irq_pin_access_method = IRQ_PIN_ACCESS_ACPI_GPIO;
|
|
|
|
gpio_mapping = acpi_goodix_int_first_gpios;
|
|
|
|
} else if (ts->gpio_count == 2 && ts->gpio_int_idx == 1) {
|
|
|
|
ts->irq_pin_access_method = IRQ_PIN_ACCESS_ACPI_GPIO;
|
|
|
|
gpio_mapping = acpi_goodix_int_last_gpios;
|
2020-03-25 02:24:31 +08:00
|
|
|
} else if (ts->gpio_count == 1 && ts->gpio_int_idx == -1 &&
|
|
|
|
acpi_has_method(ACPI_HANDLE(dev), "INTI") &&
|
|
|
|
acpi_has_method(ACPI_HANDLE(dev), "INTO")) {
|
|
|
|
dev_info(dev, "Using ACPI INTI and INTO methods for IRQ pin access\n");
|
|
|
|
ts->irq_pin_access_method = IRQ_PIN_ACCESS_ACPI_METHOD;
|
|
|
|
gpio_mapping = acpi_goodix_reset_only_gpios;
|
Input: goodix - add support for getting IRQ + reset GPIOs on Bay Trail devices
On most Bay Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 2 GpioIo resource in their _CRS table, on all 4 such
devices which I have access to, the order of the 2 GPIOs is reset, int.
Note that the GPIO to which the touchscreen controller irq pin is connected
is configured in direct-irq mode on these Bay Trail devices, the
pinctrl-baytrail.c driver still allows controlling the pin as a GPIO in
this case, but this is not necessarily the case on other X86 ACPI
platforms, nor do we have a guarantee that the GPIO order is the same
elsewhere, so we limit the use of a _CRS table with 2 GpioIo resources
to Bay Trail devices only.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20200307121505.3707-5-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:35 +08:00
|
|
|
} else if (is_byt() && ts->gpio_count == 2 && ts->gpio_int_idx == -1) {
|
|
|
|
dev_info(dev, "No ACPI GpioInt resource, assuming that the GPIO order is reset, int\n");
|
|
|
|
ts->irq_pin_access_method = IRQ_PIN_ACCESS_ACPI_GPIO;
|
|
|
|
gpio_mapping = acpi_goodix_int_last_gpios;
|
Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices
On most Cherry Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 1 GpioInt and 1 GpioIo resource in their _CRS table:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\_SB.PCI0.I2C2",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Edge, ActiveLow, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0013
}
GpioIo (Shared, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0019
}
})
Return (RBUF) /* \_SB_.PCI0.I2C2.TCS1._CRS.RBUF */
}
There is no fixed order for these 2. This commit adds code to check that
there is 1 of each as expected and then registers a mapping matching their
order using devm_acpi_dev_add_driver_gpios().
This gives us access to both GPIOs allowing us to properly suspend the
controller during suspend, and making it possible to reset the controller
if necessary.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20200307121505.3707-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:21 +08:00
|
|
|
} else {
|
|
|
|
dev_warn(dev, "Unexpected ACPI resources: gpio_count %d, gpio_int_idx %d\n",
|
|
|
|
ts->gpio_count, ts->gpio_int_idx);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return devm_acpi_dev_add_driver_gpios(dev, gpio_mapping);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static int goodix_add_acpi_gpio_mappings(struct goodix_ts_data *ts)
|
|
|
|
{
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
#endif /* CONFIG_X86 && CONFIG_ACPI */
|
|
|
|
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
/**
|
|
|
|
* goodix_get_gpio_config - Get GPIO config from ACPI/DT
|
|
|
|
*
|
|
|
|
* @ts: goodix_ts_data pointer
|
|
|
|
*/
|
|
|
|
static int goodix_get_gpio_config(struct goodix_ts_data *ts)
|
|
|
|
{
|
|
|
|
int error;
|
|
|
|
struct device *dev;
|
|
|
|
struct gpio_desc *gpiod;
|
Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices
On most Cherry Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 1 GpioInt and 1 GpioIo resource in their _CRS table:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\_SB.PCI0.I2C2",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Edge, ActiveLow, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0013
}
GpioIo (Shared, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0019
}
})
Return (RBUF) /* \_SB_.PCI0.I2C2.TCS1._CRS.RBUF */
}
There is no fixed order for these 2. This commit adds code to check that
there is 1 of each as expected and then registers a mapping matching their
order using devm_acpi_dev_add_driver_gpios().
This gives us access to both GPIOs allowing us to properly suspend the
controller during suspend, and making it possible to reset the controller
if necessary.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20200307121505.3707-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:21 +08:00
|
|
|
bool added_acpi_mappings = false;
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
|
|
|
|
if (!ts->client)
|
|
|
|
return -EINVAL;
|
|
|
|
dev = &ts->client->dev;
|
|
|
|
|
2019-04-04 06:20:26 +08:00
|
|
|
ts->avdd28 = devm_regulator_get(dev, "AVDD28");
|
|
|
|
if (IS_ERR(ts->avdd28)) {
|
|
|
|
error = PTR_ERR(ts->avdd28);
|
|
|
|
if (error != -EPROBE_DEFER)
|
|
|
|
dev_err(dev,
|
|
|
|
"Failed to get AVDD28 regulator: %d\n", error);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
ts->vddio = devm_regulator_get(dev, "VDDIO");
|
|
|
|
if (IS_ERR(ts->vddio)) {
|
|
|
|
error = PTR_ERR(ts->vddio);
|
|
|
|
if (error != -EPROBE_DEFER)
|
|
|
|
dev_err(dev,
|
|
|
|
"Failed to get VDDIO regulator: %d\n", error);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices
On most Cherry Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 1 GpioInt and 1 GpioIo resource in their _CRS table:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\_SB.PCI0.I2C2",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Edge, ActiveLow, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0013
}
GpioIo (Shared, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0019
}
})
Return (RBUF) /* \_SB_.PCI0.I2C2.TCS1._CRS.RBUF */
}
There is no fixed order for these 2. This commit adds code to check that
there is 1 of each as expected and then registers a mapping matching their
order using devm_acpi_dev_add_driver_gpios().
This gives us access to both GPIOs allowing us to properly suspend the
controller during suspend, and making it possible to reset the controller
if necessary.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20200307121505.3707-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:21 +08:00
|
|
|
retry_get_irq_gpio:
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
/* Get the interrupt GPIO pin number */
|
|
|
|
gpiod = devm_gpiod_get_optional(dev, GOODIX_GPIO_INT_NAME, GPIOD_IN);
|
|
|
|
if (IS_ERR(gpiod)) {
|
|
|
|
error = PTR_ERR(gpiod);
|
|
|
|
if (error != -EPROBE_DEFER)
|
|
|
|
dev_dbg(dev, "Failed to get %s GPIO: %d\n",
|
|
|
|
GOODIX_GPIO_INT_NAME, error);
|
|
|
|
return error;
|
|
|
|
}
|
Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices
On most Cherry Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 1 GpioInt and 1 GpioIo resource in their _CRS table:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\_SB.PCI0.I2C2",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Edge, ActiveLow, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0013
}
GpioIo (Shared, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0019
}
})
Return (RBUF) /* \_SB_.PCI0.I2C2.TCS1._CRS.RBUF */
}
There is no fixed order for these 2. This commit adds code to check that
there is 1 of each as expected and then registers a mapping matching their
order using devm_acpi_dev_add_driver_gpios().
This gives us access to both GPIOs allowing us to properly suspend the
controller during suspend, and making it possible to reset the controller
if necessary.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20200307121505.3707-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:21 +08:00
|
|
|
if (!gpiod && has_acpi_companion(dev) && !added_acpi_mappings) {
|
|
|
|
added_acpi_mappings = true;
|
|
|
|
if (goodix_add_acpi_gpio_mappings(ts) == 0)
|
|
|
|
goto retry_get_irq_gpio;
|
|
|
|
}
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
|
|
|
|
ts->gpiod_int = gpiod;
|
|
|
|
|
|
|
|
/* Get the reset line GPIO pin number */
|
|
|
|
gpiod = devm_gpiod_get_optional(dev, GOODIX_GPIO_RST_NAME, GPIOD_IN);
|
|
|
|
if (IS_ERR(gpiod)) {
|
|
|
|
error = PTR_ERR(gpiod);
|
|
|
|
if (error != -EPROBE_DEFER)
|
|
|
|
dev_dbg(dev, "Failed to get %s GPIO: %d\n",
|
|
|
|
GOODIX_GPIO_RST_NAME, error);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
ts->gpiod_rst = gpiod;
|
|
|
|
|
Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices
On most Cherry Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 1 GpioInt and 1 GpioIo resource in their _CRS table:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\_SB.PCI0.I2C2",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Edge, ActiveLow, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0013
}
GpioIo (Shared, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0019
}
})
Return (RBUF) /* \_SB_.PCI0.I2C2.TCS1._CRS.RBUF */
}
There is no fixed order for these 2. This commit adds code to check that
there is 1 of each as expected and then registers a mapping matching their
order using devm_acpi_dev_add_driver_gpios().
This gives us access to both GPIOs allowing us to properly suspend the
controller during suspend, and making it possible to reset the controller
if necessary.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20200307121505.3707-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:21 +08:00
|
|
|
switch (ts->irq_pin_access_method) {
|
|
|
|
case IRQ_PIN_ACCESS_ACPI_GPIO:
|
|
|
|
/*
|
|
|
|
* We end up here if goodix_add_acpi_gpio_mappings() has
|
|
|
|
* called devm_acpi_dev_add_driver_gpios() because the ACPI
|
|
|
|
* tables did not contain name to index mappings.
|
|
|
|
* Check that we successfully got both GPIOs after we've
|
|
|
|
* added our own acpi_gpio_mapping and if we did not get both
|
|
|
|
* GPIOs reset irq_pin_access_method to IRQ_PIN_ACCESS_NONE.
|
|
|
|
*/
|
|
|
|
if (!ts->gpiod_int || !ts->gpiod_rst)
|
|
|
|
ts->irq_pin_access_method = IRQ_PIN_ACCESS_NONE;
|
|
|
|
break;
|
2020-03-25 02:24:31 +08:00
|
|
|
case IRQ_PIN_ACCESS_ACPI_METHOD:
|
|
|
|
if (!ts->gpiod_rst)
|
|
|
|
ts->irq_pin_access_method = IRQ_PIN_ACCESS_NONE;
|
|
|
|
break;
|
Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices
On most Cherry Trail (x86, UEFI + ACPI) devices the ACPI tables do not have
a _DSD with a "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID, adding
"irq-gpios" and "reset-gpios" mappings, so we cannot get the GPIOS by name
without first manually adding mappings ourselves.
These devices contain 1 GpioInt and 1 GpioIo resource in their _CRS table:
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBusV2 (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\_SB.PCI0.I2C2",
0x00, ResourceConsumer, , Exclusive,
)
GpioInt (Edge, ActiveLow, Shared, PullDefault, 0x0000,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0013
}
GpioIo (Shared, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0019
}
})
Return (RBUF) /* \_SB_.PCI0.I2C2.TCS1._CRS.RBUF */
}
There is no fixed order for these 2. This commit adds code to check that
there is 1 of each as expected and then registers a mapping matching their
order using devm_acpi_dev_add_driver_gpios().
This gives us access to both GPIOs allowing us to properly suspend the
controller during suspend, and making it possible to reset the controller
if necessary.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317
BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20200307121505.3707-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2020-03-25 02:23:21 +08:00
|
|
|
default:
|
|
|
|
if (ts->gpiod_int && ts->gpiod_rst) {
|
|
|
|
ts->reset_controller_at_probe = true;
|
|
|
|
ts->load_cfg_from_disk = true;
|
|
|
|
ts->irq_pin_access_method = IRQ_PIN_ACCESS_GPIO;
|
|
|
|
}
|
2020-03-25 02:12:35 +08:00
|
|
|
}
|
2020-03-25 02:12:10 +08:00
|
|
|
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-11-01 00:26:16 +08:00
|
|
|
/**
|
|
|
|
* goodix_read_config - Read the embedded configuration of the panel
|
|
|
|
*
|
|
|
|
* @ts: our goodix_ts_data pointer
|
|
|
|
*
|
|
|
|
* Must be called during probe
|
|
|
|
*/
|
|
|
|
static void goodix_read_config(struct goodix_ts_data *ts)
|
|
|
|
{
|
2018-01-27 03:08:59 +08:00
|
|
|
int x_max, y_max;
|
2014-11-01 00:26:16 +08:00
|
|
|
int error;
|
|
|
|
|
2017-10-25 02:06:41 +08:00
|
|
|
error = goodix_i2c_read(ts->client, ts->chip->config_addr,
|
2020-03-25 02:29:26 +08:00
|
|
|
ts->config, ts->chip->config_len);
|
2014-11-01 00:26:16 +08:00
|
|
|
if (error) {
|
2018-01-27 03:08:59 +08:00
|
|
|
dev_warn(&ts->client->dev, "Error reading config: %d\n",
|
2014-11-01 00:26:16 +08:00
|
|
|
error);
|
|
|
|
ts->int_trigger_type = GOODIX_INT_TRIGGER;
|
2015-03-07 08:38:16 +08:00
|
|
|
ts->max_touch_num = GOODIX_MAX_CONTACTS;
|
2014-11-01 00:26:16 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-03-25 02:29:26 +08:00
|
|
|
ts->int_trigger_type = ts->config[TRIGGER_LOC] & 0x03;
|
|
|
|
ts->max_touch_num = ts->config[MAX_CONTACTS_LOC] & 0x0f;
|
2015-07-25 00:08:53 +08:00
|
|
|
|
2020-03-25 02:29:26 +08:00
|
|
|
x_max = get_unaligned_le16(&ts->config[RESOLUTION_LOC]);
|
|
|
|
y_max = get_unaligned_le16(&ts->config[RESOLUTION_LOC + 2]);
|
2018-01-27 03:08:59 +08:00
|
|
|
if (x_max && y_max) {
|
|
|
|
input_abs_set_max(ts->input_dev, ABS_MT_POSITION_X, x_max - 1);
|
|
|
|
input_abs_set_max(ts->input_dev, ABS_MT_POSITION_Y, y_max - 1);
|
2015-12-18 09:08:31 +08:00
|
|
|
}
|
2020-03-25 02:29:26 +08:00
|
|
|
|
|
|
|
ts->chip->calc_config_checksum(ts);
|
2014-11-01 00:26:16 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* goodix_read_version - Read goodix touchscreen version
|
|
|
|
*
|
2015-12-18 08:05:42 +08:00
|
|
|
* @ts: our goodix_ts_data pointer
|
2014-11-01 00:26:16 +08:00
|
|
|
*/
|
2015-12-18 08:05:42 +08:00
|
|
|
static int goodix_read_version(struct goodix_ts_data *ts)
|
2014-11-01 00:26:16 +08:00
|
|
|
{
|
|
|
|
int error;
|
|
|
|
u8 buf[6];
|
2020-03-25 02:57:58 +08:00
|
|
|
char id_str[GOODIX_ID_MAX_LEN + 1];
|
2014-11-01 00:26:16 +08:00
|
|
|
|
2015-12-18 08:05:42 +08:00
|
|
|
error = goodix_i2c_read(ts->client, GOODIX_REG_ID, buf, sizeof(buf));
|
2014-11-01 00:26:16 +08:00
|
|
|
if (error) {
|
2015-12-18 08:05:42 +08:00
|
|
|
dev_err(&ts->client->dev, "read version failed: %d\n", error);
|
2014-11-01 00:26:16 +08:00
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2020-03-25 02:57:58 +08:00
|
|
|
memcpy(id_str, buf, GOODIX_ID_MAX_LEN);
|
|
|
|
id_str[GOODIX_ID_MAX_LEN] = 0;
|
|
|
|
strscpy(ts->id, id_str, GOODIX_ID_MAX_LEN + 1);
|
2014-11-01 00:26:16 +08:00
|
|
|
|
2015-12-18 08:05:42 +08:00
|
|
|
ts->version = get_unaligned_le16(&buf[4]);
|
2015-06-10 02:04:40 +08:00
|
|
|
|
2020-03-25 02:57:58 +08:00
|
|
|
dev_info(&ts->client->dev, "ID %s, version: %04x\n", ts->id,
|
2015-12-18 08:05:42 +08:00
|
|
|
ts->version);
|
2014-11-01 00:26:16 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* goodix_i2c_test - I2C test function to check if the device answers.
|
|
|
|
*
|
|
|
|
* @client: the i2c client
|
|
|
|
*/
|
|
|
|
static int goodix_i2c_test(struct i2c_client *client)
|
|
|
|
{
|
|
|
|
int retry = 0;
|
|
|
|
int error;
|
|
|
|
u8 test;
|
|
|
|
|
|
|
|
while (retry++ < 2) {
|
2017-10-25 02:06:41 +08:00
|
|
|
error = goodix_i2c_read(client, GOODIX_REG_ID,
|
2014-11-01 00:26:16 +08:00
|
|
|
&test, 1);
|
|
|
|
if (!error)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
dev_err(&client->dev, "i2c test failed attempt %d: %d\n",
|
|
|
|
retry, error);
|
|
|
|
msleep(20);
|
|
|
|
}
|
|
|
|
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-01-27 03:08:59 +08:00
|
|
|
* goodix_configure_dev - Finish device initialization
|
2014-11-01 00:26:16 +08:00
|
|
|
*
|
|
|
|
* @ts: our goodix_ts_data pointer
|
|
|
|
*
|
2018-01-27 03:08:59 +08:00
|
|
|
* Must be called from probe to finish initialization of the device.
|
|
|
|
* Contains the common initialization code for both devices that
|
|
|
|
* declare gpio pins and devices that do not. It is either called
|
|
|
|
* directly from probe or from request_firmware_wait callback.
|
2014-11-01 00:26:16 +08:00
|
|
|
*/
|
2018-01-27 03:08:59 +08:00
|
|
|
static int goodix_configure_dev(struct goodix_ts_data *ts)
|
2014-11-01 00:26:16 +08:00
|
|
|
{
|
|
|
|
int error;
|
2020-03-25 02:38:49 +08:00
|
|
|
int i;
|
2014-11-01 00:26:16 +08:00
|
|
|
|
2018-01-27 03:08:59 +08:00
|
|
|
ts->int_trigger_type = GOODIX_INT_TRIGGER;
|
|
|
|
ts->max_touch_num = GOODIX_MAX_CONTACTS;
|
|
|
|
|
2014-11-01 00:26:16 +08:00
|
|
|
ts->input_dev = devm_input_allocate_device(&ts->client->dev);
|
|
|
|
if (!ts->input_dev) {
|
|
|
|
dev_err(&ts->client->dev, "Failed to allocate input device.");
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
ts->input_dev->name = "Goodix Capacitive TouchScreen";
|
|
|
|
ts->input_dev->phys = "input/ts";
|
|
|
|
ts->input_dev->id.bustype = BUS_I2C;
|
|
|
|
ts->input_dev->id.vendor = 0x0416;
|
2020-03-25 02:57:58 +08:00
|
|
|
if (kstrtou16(ts->id, 10, &ts->input_dev->id.product))
|
|
|
|
ts->input_dev->id.product = 0x1001;
|
2015-12-18 08:05:42 +08:00
|
|
|
ts->input_dev->id.version = ts->version;
|
2014-11-01 00:26:16 +08:00
|
|
|
|
2020-03-25 02:38:49 +08:00
|
|
|
ts->input_dev->keycode = ts->keymap;
|
|
|
|
ts->input_dev->keycodesize = sizeof(ts->keymap[0]);
|
|
|
|
ts->input_dev->keycodemax = GOODIX_MAX_KEYS;
|
|
|
|
|
2017-09-07 08:29:24 +08:00
|
|
|
/* Capacitive Windows/Home button on some devices */
|
2020-03-25 02:38:49 +08:00
|
|
|
for (i = 0; i < GOODIX_MAX_KEYS; ++i) {
|
|
|
|
if (i == 0)
|
|
|
|
ts->keymap[i] = KEY_LEFTMETA;
|
|
|
|
else
|
|
|
|
ts->keymap[i] = KEY_F1 + (i - 1);
|
|
|
|
|
|
|
|
input_set_capability(ts->input_dev, EV_KEY, ts->keymap[i]);
|
|
|
|
}
|
2017-09-07 08:29:24 +08:00
|
|
|
|
2018-01-27 03:08:59 +08:00
|
|
|
input_set_capability(ts->input_dev, EV_ABS, ABS_MT_POSITION_X);
|
|
|
|
input_set_capability(ts->input_dev, EV_ABS, ABS_MT_POSITION_Y);
|
|
|
|
input_set_abs_params(ts->input_dev, ABS_MT_WIDTH_MAJOR, 0, 255, 0, 0);
|
|
|
|
input_set_abs_params(ts->input_dev, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0);
|
2014-11-01 00:26:16 +08:00
|
|
|
|
2018-01-27 03:08:59 +08:00
|
|
|
/* Read configuration and apply touchscreen parameters */
|
|
|
|
goodix_read_config(ts);
|
2014-11-01 00:26:16 +08:00
|
|
|
|
2018-01-27 03:08:59 +08:00
|
|
|
/* Try overriding touchscreen parameters via device properties */
|
|
|
|
touchscreen_parse_properties(ts->input_dev, true, &ts->prop);
|
2015-12-18 08:05:42 +08:00
|
|
|
|
2018-01-27 03:08:59 +08:00
|
|
|
if (!ts->prop.max_x || !ts->prop.max_y || !ts->max_touch_num) {
|
2019-02-17 15:04:43 +08:00
|
|
|
dev_err(&ts->client->dev,
|
|
|
|
"Invalid config (%d, %d, %d), using defaults\n",
|
|
|
|
ts->prop.max_x, ts->prop.max_y, ts->max_touch_num);
|
2018-01-27 03:08:59 +08:00
|
|
|
ts->prop.max_x = GOODIX_MAX_WIDTH - 1;
|
|
|
|
ts->prop.max_y = GOODIX_MAX_HEIGHT - 1;
|
|
|
|
ts->max_touch_num = GOODIX_MAX_CONTACTS;
|
|
|
|
input_abs_set_max(ts->input_dev,
|
|
|
|
ABS_MT_POSITION_X, ts->prop.max_x);
|
|
|
|
input_abs_set_max(ts->input_dev,
|
|
|
|
ABS_MT_POSITION_Y, ts->prop.max_y);
|
|
|
|
}
|
2015-12-18 09:02:53 +08:00
|
|
|
|
2018-01-27 03:08:59 +08:00
|
|
|
if (dmi_check_system(rotated_screen)) {
|
|
|
|
ts->prop.invert_x = true;
|
|
|
|
ts->prop.invert_y = true;
|
|
|
|
dev_dbg(&ts->client->dev,
|
|
|
|
"Applying '180 degrees rotated screen' quirk\n");
|
|
|
|
}
|
2015-12-18 08:05:42 +08:00
|
|
|
|
2019-09-17 07:32:24 +08:00
|
|
|
if (dmi_check_system(nine_bytes_report)) {
|
|
|
|
ts->contact_size = 9;
|
|
|
|
|
|
|
|
dev_dbg(&ts->client->dev,
|
|
|
|
"Non-standard 9-bytes report format quirk\n");
|
|
|
|
}
|
|
|
|
|
2020-03-06 11:53:06 +08:00
|
|
|
if (dmi_check_system(inverted_x_screen)) {
|
|
|
|
ts->prop.invert_x = true;
|
|
|
|
dev_dbg(&ts->client->dev,
|
|
|
|
"Applying 'inverted x screen' quirk\n");
|
|
|
|
}
|
|
|
|
|
2018-01-27 03:08:59 +08:00
|
|
|
error = input_mt_init_slots(ts->input_dev, ts->max_touch_num,
|
|
|
|
INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);
|
|
|
|
if (error) {
|
|
|
|
dev_err(&ts->client->dev,
|
|
|
|
"Failed to initialize MT slots: %d", error);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
error = input_register_device(ts->input_dev);
|
|
|
|
if (error) {
|
|
|
|
dev_err(&ts->client->dev,
|
|
|
|
"Failed to register input device: %d", error);
|
2015-12-18 08:05:42 +08:00
|
|
|
return error;
|
2018-01-27 03:08:59 +08:00
|
|
|
}
|
2015-12-18 08:05:42 +08:00
|
|
|
|
2015-12-18 08:43:39 +08:00
|
|
|
ts->irq_flags = goodix_irq_flags[ts->int_trigger_type] | IRQF_ONESHOT;
|
|
|
|
error = goodix_request_irq(ts);
|
2015-12-18 08:05:42 +08:00
|
|
|
if (error) {
|
|
|
|
dev_err(&ts->client->dev, "request IRQ failed: %d\n", error);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* goodix_config_cb - Callback to finish device init
|
|
|
|
*
|
2020-11-20 11:12:42 +08:00
|
|
|
* @cfg: firmware config
|
2020-11-20 11:19:38 +08:00
|
|
|
* @ctx: our goodix_ts_data pointer
|
2015-12-18 08:05:42 +08:00
|
|
|
*
|
|
|
|
* request_firmware_wait callback that finishes
|
|
|
|
* initialization of the device.
|
|
|
|
*/
|
|
|
|
static void goodix_config_cb(const struct firmware *cfg, void *ctx)
|
|
|
|
{
|
|
|
|
struct goodix_ts_data *ts = ctx;
|
|
|
|
int error;
|
|
|
|
|
|
|
|
if (cfg) {
|
|
|
|
/* send device configuration to the firmware */
|
2020-03-25 02:33:50 +08:00
|
|
|
error = goodix_send_cfg(ts, cfg->data, cfg->size);
|
2015-12-18 08:05:42 +08:00
|
|
|
if (error)
|
|
|
|
goto err_release_cfg;
|
|
|
|
}
|
|
|
|
|
|
|
|
goodix_configure_dev(ts);
|
|
|
|
|
|
|
|
err_release_cfg:
|
|
|
|
release_firmware(cfg);
|
|
|
|
complete_all(&ts->firmware_loading_complete);
|
|
|
|
}
|
|
|
|
|
2019-04-04 06:20:26 +08:00
|
|
|
static void goodix_disable_regulators(void *arg)
|
|
|
|
{
|
|
|
|
struct goodix_ts_data *ts = arg;
|
|
|
|
|
|
|
|
regulator_disable(ts->vddio);
|
|
|
|
regulator_disable(ts->avdd28);
|
|
|
|
}
|
|
|
|
|
2014-11-01 00:26:16 +08:00
|
|
|
static int goodix_ts_probe(struct i2c_client *client,
|
|
|
|
const struct i2c_device_id *id)
|
|
|
|
{
|
|
|
|
struct goodix_ts_data *ts;
|
|
|
|
int error;
|
|
|
|
|
|
|
|
dev_dbg(&client->dev, "I2C Address: 0x%02x\n", client->addr);
|
|
|
|
|
|
|
|
if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
|
|
|
|
dev_err(&client->dev, "I2C check functionality failed.\n");
|
|
|
|
return -ENXIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
ts = devm_kzalloc(&client->dev, sizeof(*ts), GFP_KERNEL);
|
|
|
|
if (!ts)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
ts->client = client;
|
|
|
|
i2c_set_clientdata(client, ts);
|
2015-12-18 08:05:42 +08:00
|
|
|
init_completion(&ts->firmware_loading_complete);
|
2019-09-17 07:32:24 +08:00
|
|
|
ts->contact_size = GOODIX_CONTACT_SIZE;
|
2014-11-01 00:26:16 +08:00
|
|
|
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
error = goodix_get_gpio_config(ts);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
2019-04-04 06:20:26 +08:00
|
|
|
/* power up the controller */
|
|
|
|
error = regulator_enable(ts->avdd28);
|
|
|
|
if (error) {
|
|
|
|
dev_err(&client->dev,
|
|
|
|
"Failed to enable AVDD28 regulator: %d\n",
|
|
|
|
error);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
error = regulator_enable(ts->vddio);
|
|
|
|
if (error) {
|
|
|
|
dev_err(&client->dev,
|
|
|
|
"Failed to enable VDDIO regulator: %d\n",
|
|
|
|
error);
|
|
|
|
regulator_disable(ts->avdd28);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
error = devm_add_action_or_reset(&client->dev,
|
|
|
|
goodix_disable_regulators, ts);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
2020-03-25 02:37:23 +08:00
|
|
|
reset:
|
2020-03-25 02:23:04 +08:00
|
|
|
if (ts->reset_controller_at_probe) {
|
Input: goodix - reset device at init
After power on, it is recommended that the driver resets the device.
The reset procedure timing is described in the datasheet and is used
at device init (before writing device configuration) and
for power management. It is a sequence of setting the interrupt
and reset pins high/low at specific timing intervals. This procedure
also includes setting the slave address to the one specified in the
ACPI/device tree.
This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
driver gt9xx.c for Android (publicly available in Android kernel
trees for various devices).
For reset the driver needs to control the interrupt and
reset gpio pins (configured through ACPI/device tree). For devices
that do not have the gpio pins properly declared, the functionality
depending on these pins will not be available, but the device can still
be used with basic functionality.
For both device tree and ACPI, the interrupt gpio pin configuration is
read from the "irq-gpios" property and the reset pin configuration is
read from the "reset-gpios" property. For ACPI 5.1, named properties
can be specified using the _DSD section. This functionality will not be
available for devices that use indexed gpio pins declared in the _CRS
section (we need to provide backward compatibility with devices
that do not support using the interrupt gpio pin as output).
For ACPI, the pins can be specified using ACPI 5.1:
Device (STAC)
{
Name (_HID, "GDIX1001")
...
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
I2cSerialBus (0x0014, ControllerInitiated, 0x00061A80,
AddressingMode7Bit, "\\I2C0",
0x00, ResourceConsumer, ,
)
GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000,
"\\I2C0", 0x00, ResourceConsumer, ,
)
{ // Pin list
0
}
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\I2C0", 0x00,
ResourceConsumer, ,
)
{
1
}
})
Return (RBUF)
}
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }},
Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }},
...
}
}
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2015-12-18 07:57:34 +08:00
|
|
|
/* reset the controller */
|
|
|
|
error = goodix_reset(ts);
|
|
|
|
if (error) {
|
|
|
|
dev_err(&client->dev, "Controller reset failed.\n");
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-11-01 00:26:16 +08:00
|
|
|
error = goodix_i2c_test(client);
|
|
|
|
if (error) {
|
2020-03-25 02:37:23 +08:00
|
|
|
if (!ts->reset_controller_at_probe &&
|
|
|
|
ts->irq_pin_access_method != IRQ_PIN_ACCESS_NONE) {
|
|
|
|
/* Retry after a controller reset */
|
|
|
|
ts->reset_controller_at_probe = true;
|
|
|
|
goto reset;
|
|
|
|
}
|
2014-11-01 00:26:16 +08:00
|
|
|
dev_err(&client->dev, "I2C communication failure: %d\n", error);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2015-12-18 08:05:42 +08:00
|
|
|
error = goodix_read_version(ts);
|
2014-11-01 00:26:16 +08:00
|
|
|
if (error) {
|
|
|
|
dev_err(&client->dev, "Read version failed.\n");
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2017-10-25 02:06:41 +08:00
|
|
|
ts->chip = goodix_get_chip_data(ts->id);
|
2014-11-01 00:26:16 +08:00
|
|
|
|
2020-03-25 02:12:35 +08:00
|
|
|
if (ts->load_cfg_from_disk) {
|
2015-12-18 08:05:42 +08:00
|
|
|
/* update device config */
|
|
|
|
ts->cfg_name = devm_kasprintf(&client->dev, GFP_KERNEL,
|
2020-03-25 02:57:58 +08:00
|
|
|
"goodix_%s_cfg.bin", ts->id);
|
2015-12-18 08:05:42 +08:00
|
|
|
if (!ts->cfg_name)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
error = request_firmware_nowait(THIS_MODULE, true, ts->cfg_name,
|
|
|
|
&client->dev, GFP_KERNEL, ts,
|
|
|
|
goodix_config_cb);
|
|
|
|
if (error) {
|
|
|
|
dev_err(&client->dev,
|
|
|
|
"Failed to invoke firmware loader: %d\n",
|
|
|
|
error);
|
|
|
|
return error;
|
|
|
|
}
|
2014-11-01 00:26:16 +08:00
|
|
|
|
2015-12-18 08:05:42 +08:00
|
|
|
return 0;
|
|
|
|
} else {
|
|
|
|
error = goodix_configure_dev(ts);
|
|
|
|
if (error)
|
|
|
|
return error;
|
2014-11-01 00:26:16 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-12-18 08:05:42 +08:00
|
|
|
static int goodix_ts_remove(struct i2c_client *client)
|
|
|
|
{
|
|
|
|
struct goodix_ts_data *ts = i2c_get_clientdata(client);
|
|
|
|
|
2020-03-25 02:12:35 +08:00
|
|
|
if (ts->load_cfg_from_disk)
|
2015-12-18 08:05:42 +08:00
|
|
|
wait_for_completion(&ts->firmware_loading_complete);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-12-18 08:43:39 +08:00
|
|
|
static int __maybe_unused goodix_suspend(struct device *dev)
|
|
|
|
{
|
|
|
|
struct i2c_client *client = to_i2c_client(dev);
|
|
|
|
struct goodix_ts_data *ts = i2c_get_clientdata(client);
|
|
|
|
int error;
|
|
|
|
|
2020-03-25 02:12:35 +08:00
|
|
|
if (ts->load_cfg_from_disk)
|
|
|
|
wait_for_completion(&ts->firmware_loading_complete);
|
|
|
|
|
2015-12-18 08:43:39 +08:00
|
|
|
/* We need gpio pins to suspend/resume */
|
2020-03-25 02:12:10 +08:00
|
|
|
if (ts->irq_pin_access_method == IRQ_PIN_ACCESS_NONE) {
|
2018-01-12 16:36:48 +08:00
|
|
|
disable_irq(client->irq);
|
2015-12-18 08:43:39 +08:00
|
|
|
return 0;
|
2018-01-12 16:36:48 +08:00
|
|
|
}
|
2015-12-18 08:43:39 +08:00
|
|
|
|
|
|
|
/* Free IRQ as IRQ pin is used as output in the suspend sequence */
|
|
|
|
goodix_free_irq(ts);
|
|
|
|
|
|
|
|
/* Output LOW on the INT pin for 5 ms */
|
2020-03-25 02:12:10 +08:00
|
|
|
error = goodix_irq_direction_output(ts, 0);
|
2015-12-18 08:43:39 +08:00
|
|
|
if (error) {
|
|
|
|
goodix_request_irq(ts);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
usleep_range(5000, 6000);
|
|
|
|
|
|
|
|
error = goodix_i2c_write_u8(ts->client, GOODIX_REG_COMMAND,
|
|
|
|
GOODIX_CMD_SCREEN_OFF);
|
|
|
|
if (error) {
|
|
|
|
dev_err(&ts->client->dev, "Screen off command failed\n");
|
2020-03-25 02:12:10 +08:00
|
|
|
goodix_irq_direction_input(ts);
|
2015-12-18 08:43:39 +08:00
|
|
|
goodix_request_irq(ts);
|
|
|
|
return -EAGAIN;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The datasheet specifies that the interval between sending screen-off
|
|
|
|
* command and wake-up should be longer than 58 ms. To avoid waking up
|
|
|
|
* sooner, delay 58ms here.
|
|
|
|
*/
|
|
|
|
msleep(58);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int __maybe_unused goodix_resume(struct device *dev)
|
|
|
|
{
|
|
|
|
struct i2c_client *client = to_i2c_client(dev);
|
|
|
|
struct goodix_ts_data *ts = i2c_get_clientdata(client);
|
2020-03-25 02:34:11 +08:00
|
|
|
u8 config_ver;
|
2015-12-18 08:43:39 +08:00
|
|
|
int error;
|
|
|
|
|
2020-03-25 02:12:10 +08:00
|
|
|
if (ts->irq_pin_access_method == IRQ_PIN_ACCESS_NONE) {
|
2018-01-12 16:36:48 +08:00
|
|
|
enable_irq(client->irq);
|
2015-12-18 08:43:39 +08:00
|
|
|
return 0;
|
2018-01-12 16:36:48 +08:00
|
|
|
}
|
2015-12-18 08:43:39 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Exit sleep mode by outputting HIGH level to INT pin
|
|
|
|
* for 2ms~5ms.
|
|
|
|
*/
|
2020-03-25 02:12:10 +08:00
|
|
|
error = goodix_irq_direction_output(ts, 1);
|
2015-12-18 08:43:39 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
usleep_range(2000, 5000);
|
|
|
|
|
|
|
|
error = goodix_int_sync(ts);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
2020-03-25 02:34:11 +08:00
|
|
|
error = goodix_i2c_read(ts->client, ts->chip->config_addr,
|
|
|
|
&config_ver, 1);
|
|
|
|
if (error)
|
|
|
|
dev_warn(dev, "Error reading config version: %d, resetting controller\n",
|
|
|
|
error);
|
|
|
|
else if (config_ver != ts->config[0])
|
|
|
|
dev_info(dev, "Config version mismatch %d != %d, resetting controller\n",
|
|
|
|
config_ver, ts->config[0]);
|
|
|
|
|
|
|
|
if (error != 0 || config_ver != ts->config[0]) {
|
|
|
|
error = goodix_reset(ts);
|
|
|
|
if (error) {
|
|
|
|
dev_err(dev, "Controller reset failed.\n");
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
error = goodix_send_cfg(ts, ts->config, ts->chip->config_len);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2015-12-18 08:43:39 +08:00
|
|
|
error = goodix_request_irq(ts);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static SIMPLE_DEV_PM_OPS(goodix_pm_ops, goodix_suspend, goodix_resume);
|
|
|
|
|
2014-11-01 00:26:16 +08:00
|
|
|
static const struct i2c_device_id goodix_ts_id[] = {
|
|
|
|
{ "GDIX1001:00", 0 },
|
|
|
|
{ }
|
|
|
|
};
|
2015-07-31 01:38:52 +08:00
|
|
|
MODULE_DEVICE_TABLE(i2c, goodix_ts_id);
|
2014-11-01 00:26:16 +08:00
|
|
|
|
2015-03-07 08:43:38 +08:00
|
|
|
#ifdef CONFIG_ACPI
|
2014-11-01 00:26:16 +08:00
|
|
|
static const struct acpi_device_id goodix_acpi_match[] = {
|
|
|
|
{ "GDIX1001", 0 },
|
2018-06-01 07:13:17 +08:00
|
|
|
{ "GDIX1002", 0 },
|
2014-11-01 00:26:16 +08:00
|
|
|
{ }
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(acpi, goodix_acpi_match);
|
2015-03-07 08:43:38 +08:00
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifdef CONFIG_OF
|
|
|
|
static const struct of_device_id goodix_of_match[] = {
|
2017-10-25 02:06:41 +08:00
|
|
|
{ .compatible = "goodix,gt1151" },
|
2019-04-04 07:05:34 +08:00
|
|
|
{ .compatible = "goodix,gt5663" },
|
2019-02-17 15:03:13 +08:00
|
|
|
{ .compatible = "goodix,gt5688" },
|
2015-03-07 08:43:38 +08:00
|
|
|
{ .compatible = "goodix,gt911" },
|
|
|
|
{ .compatible = "goodix,gt9110" },
|
|
|
|
{ .compatible = "goodix,gt912" },
|
2020-03-25 03:32:27 +08:00
|
|
|
{ .compatible = "goodix,gt9147" },
|
2020-03-25 03:25:58 +08:00
|
|
|
{ .compatible = "goodix,gt917s" },
|
2015-03-07 08:43:38 +08:00
|
|
|
{ .compatible = "goodix,gt927" },
|
|
|
|
{ .compatible = "goodix,gt9271" },
|
|
|
|
{ .compatible = "goodix,gt928" },
|
|
|
|
{ .compatible = "goodix,gt967" },
|
|
|
|
{ }
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, goodix_of_match);
|
|
|
|
#endif
|
2014-11-01 00:26:16 +08:00
|
|
|
|
|
|
|
static struct i2c_driver goodix_ts_driver = {
|
|
|
|
.probe = goodix_ts_probe,
|
2015-12-18 08:05:42 +08:00
|
|
|
.remove = goodix_ts_remove,
|
2014-11-01 00:26:16 +08:00
|
|
|
.id_table = goodix_ts_id,
|
|
|
|
.driver = {
|
|
|
|
.name = "Goodix-TS",
|
2015-03-07 08:43:38 +08:00
|
|
|
.acpi_match_table = ACPI_PTR(goodix_acpi_match),
|
|
|
|
.of_match_table = of_match_ptr(goodix_of_match),
|
2015-12-18 08:43:39 +08:00
|
|
|
.pm = &goodix_pm_ops,
|
2014-11-01 00:26:16 +08:00
|
|
|
},
|
|
|
|
};
|
|
|
|
module_i2c_driver(goodix_ts_driver);
|
|
|
|
|
|
|
|
MODULE_AUTHOR("Benjamin Tissoires <benjamin.tissoires@gmail.com>");
|
|
|
|
MODULE_AUTHOR("Bastien Nocera <hadess@hadess.net>");
|
|
|
|
MODULE_DESCRIPTION("Goodix touchscreen driver");
|
|
|
|
MODULE_LICENSE("GPL v2");
|