2011-12-14 05:19:38 +08:00
|
|
|
/*
|
|
|
|
* Copyright © 2011 Intel Corporation
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice (including the next
|
|
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
|
|
* Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
|
|
* SOFTWARE.
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Jesse Barnes <jbarnes@virtuousgeek.org>
|
|
|
|
*
|
|
|
|
* New plane/sprite handling.
|
|
|
|
*
|
|
|
|
* The older chips had a separate interface for programming plane related
|
|
|
|
* registers; newer ones are much simpler and we can use the new DRM plane
|
|
|
|
* support.
|
|
|
|
*/
|
2012-10-03 01:01:07 +08:00
|
|
|
#include <drm/drmP.h>
|
|
|
|
#include <drm/drm_crtc.h>
|
|
|
|
#include <drm/drm_fourcc.h>
|
2013-04-24 23:52:38 +08:00
|
|
|
#include <drm/drm_rect.h>
|
2015-04-16 06:15:02 +08:00
|
|
|
#include <drm/drm_atomic.h>
|
2014-12-24 02:41:52 +08:00
|
|
|
#include <drm/drm_plane_helper.h>
|
2011-12-14 05:19:38 +08:00
|
|
|
#include "intel_drv.h"
|
2016-08-04 23:32:35 +08:00
|
|
|
#include "intel_frontbuffer.h"
|
2012-10-03 01:01:07 +08:00
|
|
|
#include <drm/i915_drm.h>
|
2011-12-14 05:19:38 +08:00
|
|
|
#include "i915_drv.h"
|
|
|
|
|
2014-10-21 00:47:53 +08:00
|
|
|
static bool
|
|
|
|
format_is_yuv(uint32_t format)
|
|
|
|
{
|
|
|
|
switch (format) {
|
|
|
|
case DRM_FORMAT_YUYV:
|
|
|
|
case DRM_FORMAT_UYVY:
|
|
|
|
case DRM_FORMAT_VYUY:
|
|
|
|
case DRM_FORMAT_YVYU:
|
|
|
|
return true;
|
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-05-18 16:34:38 +08:00
|
|
|
int intel_usecs_to_scanlines(const struct drm_display_mode *adjusted_mode,
|
|
|
|
int usecs)
|
2014-04-29 18:35:46 +08:00
|
|
|
{
|
|
|
|
/* paranoia */
|
2015-09-25 21:37:43 +08:00
|
|
|
if (!adjusted_mode->crtc_htotal)
|
2014-04-29 18:35:46 +08:00
|
|
|
return 1;
|
|
|
|
|
2015-09-25 21:37:43 +08:00
|
|
|
return DIV_ROUND_UP(usecs * adjusted_mode->crtc_clock,
|
|
|
|
1000 * adjusted_mode->crtc_htotal);
|
2014-04-29 18:35:46 +08:00
|
|
|
}
|
|
|
|
|
2014-10-28 21:10:12 +08:00
|
|
|
/**
|
|
|
|
* intel_pipe_update_start() - start update of a set of display registers
|
|
|
|
* @crtc: the crtc of which the registers are going to be updated
|
|
|
|
* @start_vbl_count: vblank counter return pointer used for error checking
|
|
|
|
*
|
|
|
|
* Mark the start of an update to pipe registers that should be updated
|
|
|
|
* atomically regarding vblank. If the next vblank will happens within
|
|
|
|
* the next 100 us, this function waits until the vblank passes.
|
|
|
|
*
|
|
|
|
* After a successful call to this function, interrupts will be disabled
|
|
|
|
* until a subsequent call to intel_pipe_update_end(). That is done to
|
|
|
|
* avoid random delays. The value written to @start_vbl_count should be
|
|
|
|
* supplied to intel_pipe_update_end() for error checking.
|
|
|
|
*/
|
2015-08-31 19:04:25 +08:00
|
|
|
void intel_pipe_update_start(struct intel_crtc *crtc)
|
2014-04-29 18:35:46 +08:00
|
|
|
{
|
2015-09-08 18:40:45 +08:00
|
|
|
const struct drm_display_mode *adjusted_mode = &crtc->config->base.adjusted_mode;
|
2014-04-29 18:35:46 +08:00
|
|
|
long timeout = msecs_to_jiffies_timeout(1);
|
|
|
|
int scanline, min, max, vblank_start;
|
2014-05-23 00:00:50 +08:00
|
|
|
wait_queue_head_t *wq = drm_crtc_vblank_waitqueue(&crtc->base);
|
2014-04-29 18:35:46 +08:00
|
|
|
DEFINE_WAIT(wait);
|
|
|
|
|
2015-09-08 18:40:45 +08:00
|
|
|
vblank_start = adjusted_mode->crtc_vblank_start;
|
|
|
|
if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
|
2014-04-29 18:35:46 +08:00
|
|
|
vblank_start = DIV_ROUND_UP(vblank_start, 2);
|
|
|
|
|
|
|
|
/* FIXME needs to be calibrated sensibly */
|
2016-05-18 16:34:38 +08:00
|
|
|
min = vblank_start - intel_usecs_to_scanlines(adjusted_mode, 100);
|
2014-04-29 18:35:46 +08:00
|
|
|
max = vblank_start - 1;
|
|
|
|
|
2015-07-13 22:30:32 +08:00
|
|
|
local_irq_disable();
|
|
|
|
|
2014-04-29 18:35:46 +08:00
|
|
|
if (min <= 0 || max <= 0)
|
2015-07-13 22:30:32 +08:00
|
|
|
return;
|
2014-04-29 18:35:46 +08:00
|
|
|
|
2015-02-14 04:03:45 +08:00
|
|
|
if (WARN_ON(drm_crtc_vblank_get(&crtc->base)))
|
2015-07-13 22:30:32 +08:00
|
|
|
return;
|
2014-04-29 18:35:46 +08:00
|
|
|
|
2015-09-17 23:08:32 +08:00
|
|
|
crtc->debug.min_vbl = min;
|
|
|
|
crtc->debug.max_vbl = max;
|
|
|
|
trace_i915_pipe_update_start(crtc);
|
2014-04-29 18:35:48 +08:00
|
|
|
|
2014-04-29 18:35:46 +08:00
|
|
|
for (;;) {
|
|
|
|
/*
|
|
|
|
* prepare_to_wait() has a memory barrier, which guarantees
|
|
|
|
* other CPUs can see the task state update by the time we
|
|
|
|
* read the scanline.
|
|
|
|
*/
|
2014-05-23 00:00:50 +08:00
|
|
|
prepare_to_wait(wq, &wait, TASK_UNINTERRUPTIBLE);
|
2014-04-29 18:35:46 +08:00
|
|
|
|
|
|
|
scanline = intel_get_crtc_scanline(crtc);
|
|
|
|
if (scanline < min || scanline > max)
|
|
|
|
break;
|
|
|
|
|
|
|
|
if (timeout <= 0) {
|
|
|
|
DRM_ERROR("Potential atomic update failure on pipe %c\n",
|
|
|
|
pipe_name(crtc->pipe));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
local_irq_enable();
|
|
|
|
|
|
|
|
timeout = schedule_timeout(timeout);
|
|
|
|
|
|
|
|
local_irq_disable();
|
|
|
|
}
|
|
|
|
|
2014-05-23 00:00:50 +08:00
|
|
|
finish_wait(wq, &wait);
|
2014-04-29 18:35:46 +08:00
|
|
|
|
2015-02-14 04:03:45 +08:00
|
|
|
drm_crtc_vblank_put(&crtc->base);
|
2014-04-29 18:35:46 +08:00
|
|
|
|
2015-09-16 05:19:32 +08:00
|
|
|
crtc->debug.scanline_start = scanline;
|
|
|
|
crtc->debug.start_vbl_time = ktime_get();
|
2016-05-17 21:07:48 +08:00
|
|
|
crtc->debug.start_vbl_count = intel_crtc_get_vblank_counter(crtc);
|
2014-04-29 18:35:46 +08:00
|
|
|
|
2015-09-17 23:08:32 +08:00
|
|
|
trace_i915_pipe_update_vblank_evaded(crtc);
|
2014-04-29 18:35:46 +08:00
|
|
|
}
|
|
|
|
|
2014-10-28 21:10:12 +08:00
|
|
|
/**
|
|
|
|
* intel_pipe_update_end() - end update of a set of display registers
|
|
|
|
* @crtc: the crtc of which the registers were updated
|
|
|
|
* @start_vbl_count: start vblank counter (used for error checking)
|
|
|
|
*
|
|
|
|
* Mark the end of an update started with intel_pipe_update_start(). This
|
|
|
|
* re-enables interrupts and verifies the update was actually completed
|
|
|
|
* before a vblank using the value of @start_vbl_count.
|
|
|
|
*/
|
2016-05-17 21:07:49 +08:00
|
|
|
void intel_pipe_update_end(struct intel_crtc *crtc, struct intel_flip_work *work)
|
2014-04-29 18:35:46 +08:00
|
|
|
{
|
|
|
|
enum pipe pipe = crtc->pipe;
|
2015-09-16 05:19:32 +08:00
|
|
|
int scanline_end = intel_get_crtc_scanline(crtc);
|
2016-05-17 21:07:48 +08:00
|
|
|
u32 end_vbl_count = intel_crtc_get_vblank_counter(crtc);
|
2015-09-01 18:15:33 +08:00
|
|
|
ktime_t end_vbl_time = ktime_get();
|
2014-04-29 18:35:46 +08:00
|
|
|
|
2016-05-17 21:07:49 +08:00
|
|
|
if (work) {
|
|
|
|
work->flip_queued_vblank = end_vbl_count;
|
|
|
|
smp_mb__before_atomic();
|
|
|
|
atomic_set(&work->pending, 1);
|
|
|
|
}
|
|
|
|
|
2015-09-17 23:08:32 +08:00
|
|
|
trace_i915_pipe_update_end(crtc, end_vbl_count, scanline_end);
|
2014-04-29 18:35:48 +08:00
|
|
|
|
2016-06-13 22:13:45 +08:00
|
|
|
/* We're still in the vblank-evade critical section, this can't race.
|
|
|
|
* Would be slightly nice to just grab the vblank count and arm the
|
|
|
|
* event outside of the critical section - the spinlock might spin for a
|
|
|
|
* while ... */
|
|
|
|
if (crtc->base.state->event) {
|
|
|
|
WARN_ON(drm_crtc_vblank_get(&crtc->base) != 0);
|
|
|
|
|
|
|
|
spin_lock(&crtc->base.dev->event_lock);
|
|
|
|
drm_crtc_arm_vblank_event(&crtc->base, crtc->base.state->event);
|
|
|
|
spin_unlock(&crtc->base.dev->event_lock);
|
|
|
|
|
|
|
|
crtc->base.state->event = NULL;
|
|
|
|
}
|
|
|
|
|
2014-04-29 18:35:46 +08:00
|
|
|
local_irq_enable();
|
|
|
|
|
2015-09-16 05:19:32 +08:00
|
|
|
if (crtc->debug.start_vbl_count &&
|
|
|
|
crtc->debug.start_vbl_count != end_vbl_count) {
|
|
|
|
DRM_ERROR("Atomic update failure on pipe %c (start=%u end=%u) time %lld us, min %d, max %d, scanline start %d, end %d\n",
|
|
|
|
pipe_name(pipe), crtc->debug.start_vbl_count,
|
|
|
|
end_vbl_count,
|
|
|
|
ktime_us_delta(end_vbl_time, crtc->debug.start_vbl_time),
|
|
|
|
crtc->debug.min_vbl, crtc->debug.max_vbl,
|
|
|
|
crtc->debug.scanline_start, scanline_end);
|
|
|
|
}
|
2014-04-29 18:35:46 +08:00
|
|
|
}
|
|
|
|
|
2013-12-04 08:49:41 +08:00
|
|
|
static void
|
2016-01-07 18:54:06 +08:00
|
|
|
skl_update_plane(struct drm_plane *drm_plane,
|
|
|
|
const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
2013-12-04 08:49:41 +08:00
|
|
|
{
|
|
|
|
struct drm_device *dev = drm_plane->dev;
|
2016-07-04 18:34:36 +08:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
2013-12-04 08:49:41 +08:00
|
|
|
struct intel_plane *intel_plane = to_intel_plane(drm_plane);
|
2016-01-07 18:54:06 +08:00
|
|
|
struct drm_framebuffer *fb = plane_state->base.fb;
|
drm/i915/skl: Update plane watermarks atomically during plane updates
Thanks to Ville for suggesting this as a potential solution to pipe
underruns on Skylake.
On Skylake all of the registers for configuring planes, including the
registers for configuring their watermarks, are double buffered. New
values written to them won't take effect until said registers are
"armed", which is done by writing to the PLANE_SURF (or in the case of
cursor planes, the CURBASE register) register.
With this in mind, up until now we've been updating watermarks on skl
like this:
non-modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- intel_pre_plane_update:
- intel_update_watermarks()
- {vblank happens; new watermarks + old plane values => underrun }
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- end vblank evasion
}
or
modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- crtc_enable:
- intel_update_watermarks()
- {vblank happens; new watermarks + old plane values => underrun }
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- end vblank evasion
}
Now we update watermarks atomically like this:
non-modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- intel_pre_plane_update:
- intel_update_watermarks() (wm values aren't written yet)
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- write new wm values
- end vblank evasion
}
modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- crtc_enable:
- intel_update_watermarks() (actual wm values aren't written
yet)
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- write new wm values
- end vblank evasion
}
So this patch moves all of the watermark writes into the right place;
inside of the vblank evasion where we update all of the registers for
each plane. While this patch doesn't fix everything, it does allow us to
update the watermark values in the way the hardware expects us to.
Changes since original patch series:
- Remove mutex_lock/mutex_unlock since they don't do anything and we're
not touching global state
- Move skl_write_cursor_wm/skl_write_plane_wm functions into
intel_pm.c, make externally visible
- Add skl_write_plane_wm calls to skl_update_plane
- Fix conditional for for loop in skl_write_plane_wm (level < max_level
should be level <= max_level)
- Make diagram in commit more accurate to what's actually happening
- Add Fixes:
Changes since v1:
- Use IS_GEN9() instead of IS_SKYLAKE() since these fixes apply to more
then just Skylake
- Update description to make it clear this patch doesn't fix everything
- Check if pipes were actually changed before writing watermarks
Changes since v2:
- Write PIPE_WM_LINETIME during vblank evasion
Changes since v3:
- Rebase against new SAGV patch changes
Changes since v4:
- Add a parameter to choose what skl_wm_values struct to use when
writing new plane watermarks
Changes since v5:
- Remove cursor ddb entry write in skl_write_cursor_wm(), defer until
patch 6
- Write WM_LINETIME in intel_begin_crtc_commit()
Changes since v6:
- Remove redundant dirty_pipes check in skl_write_plane_wm (we check
this in all places where we call this function, and it was supposed
to have been removed earlier anyway)
- In i9xx_update_cursor(), use dev_priv->info.gen >= 9 instead of
IS_GEN9(dev_priv). We do this everywhere else and I'd imagine this
needs to be done for gen10 as well
Changes since v7:
- Fix rebase fail (unused variable obj)
- Make struct skl_wm_values *wm const
- Fix indenting
- Use INTEL_GEN() instead of dev_priv->info.gen
Changes since v8:
- Don't forget calls to skl_write_plane_wm() when disabling planes
- Use INTEL_GEN(), not INTEL_INFO()->gen in intel_begin_crtc_commit()
Fixes: 2d41c0b59afc ("drm/i915/skl: SKL Watermark Computation")
Signed-off-by: Lyude <cpaul@redhat.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Cc: stable@vger.kernel.org
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1471884608-10671-1-git-send-email-cpaul@redhat.com
Link: http://patchwork.freedesktop.org/patch/msgid/1471884608-10671-1-git-send-email-cpaul@redhat.com
2016-08-23 00:50:08 +08:00
|
|
|
const struct skl_wm_values *wm = &dev_priv->wm.skl_results;
|
|
|
|
struct drm_crtc *crtc = crtc_state->base.crtc;
|
|
|
|
struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
|
2013-12-04 08:49:41 +08:00
|
|
|
const int pipe = intel_plane->pipe;
|
|
|
|
const int plane = intel_plane->plane + 1;
|
2016-10-19 02:09:49 +08:00
|
|
|
const struct skl_plane_wm *p_wm =
|
|
|
|
&crtc_state->wm.skl.optimal.planes[plane];
|
2016-01-29 00:33:11 +08:00
|
|
|
u32 plane_ctl;
|
2016-01-07 18:54:06 +08:00
|
|
|
const struct drm_intel_sprite_colorkey *key = &plane_state->ckey;
|
2016-01-28 22:53:54 +08:00
|
|
|
u32 surf_addr = plane_state->main.offset;
|
2016-02-16 04:54:41 +08:00
|
|
|
unsigned int rotation = plane_state->base.rotation;
|
2016-01-29 00:33:11 +08:00
|
|
|
u32 stride = skl_plane_stride(fb, 0, rotation);
|
2016-07-27 00:06:59 +08:00
|
|
|
int crtc_x = plane_state->base.dst.x1;
|
|
|
|
int crtc_y = plane_state->base.dst.y1;
|
|
|
|
uint32_t crtc_w = drm_rect_width(&plane_state->base.dst);
|
|
|
|
uint32_t crtc_h = drm_rect_height(&plane_state->base.dst);
|
2016-01-28 22:53:54 +08:00
|
|
|
uint32_t x = plane_state->main.x;
|
|
|
|
uint32_t y = plane_state->main.y;
|
2016-07-27 00:06:59 +08:00
|
|
|
uint32_t src_w = drm_rect_width(&plane_state->base.src) >> 16;
|
|
|
|
uint32_t src_h = drm_rect_height(&plane_state->base.src) >> 16;
|
2013-12-04 08:49:41 +08:00
|
|
|
|
2015-03-19 23:57:13 +08:00
|
|
|
plane_ctl = PLANE_CTL_ENABLE |
|
2015-08-28 04:46:30 +08:00
|
|
|
PLANE_CTL_PIPE_GAMMA_ENABLE |
|
2015-03-19 23:57:13 +08:00
|
|
|
PLANE_CTL_PIPE_CSC_ENABLE;
|
2013-12-04 08:49:41 +08:00
|
|
|
|
2015-04-16 06:15:02 +08:00
|
|
|
plane_ctl |= skl_plane_ctl_format(fb->pixel_format);
|
|
|
|
plane_ctl |= skl_plane_ctl_tiling(fb->modifier[0]);
|
2015-02-27 19:15:18 +08:00
|
|
|
|
2015-04-16 06:15:02 +08:00
|
|
|
plane_ctl |= skl_plane_ctl_rotation(rotation);
|
2013-12-04 08:49:41 +08:00
|
|
|
|
drm/i915/skl: Update plane watermarks atomically during plane updates
Thanks to Ville for suggesting this as a potential solution to pipe
underruns on Skylake.
On Skylake all of the registers for configuring planes, including the
registers for configuring their watermarks, are double buffered. New
values written to them won't take effect until said registers are
"armed", which is done by writing to the PLANE_SURF (or in the case of
cursor planes, the CURBASE register) register.
With this in mind, up until now we've been updating watermarks on skl
like this:
non-modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- intel_pre_plane_update:
- intel_update_watermarks()
- {vblank happens; new watermarks + old plane values => underrun }
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- end vblank evasion
}
or
modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- crtc_enable:
- intel_update_watermarks()
- {vblank happens; new watermarks + old plane values => underrun }
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- end vblank evasion
}
Now we update watermarks atomically like this:
non-modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- intel_pre_plane_update:
- intel_update_watermarks() (wm values aren't written yet)
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- write new wm values
- end vblank evasion
}
modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- crtc_enable:
- intel_update_watermarks() (actual wm values aren't written
yet)
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- write new wm values
- end vblank evasion
}
So this patch moves all of the watermark writes into the right place;
inside of the vblank evasion where we update all of the registers for
each plane. While this patch doesn't fix everything, it does allow us to
update the watermark values in the way the hardware expects us to.
Changes since original patch series:
- Remove mutex_lock/mutex_unlock since they don't do anything and we're
not touching global state
- Move skl_write_cursor_wm/skl_write_plane_wm functions into
intel_pm.c, make externally visible
- Add skl_write_plane_wm calls to skl_update_plane
- Fix conditional for for loop in skl_write_plane_wm (level < max_level
should be level <= max_level)
- Make diagram in commit more accurate to what's actually happening
- Add Fixes:
Changes since v1:
- Use IS_GEN9() instead of IS_SKYLAKE() since these fixes apply to more
then just Skylake
- Update description to make it clear this patch doesn't fix everything
- Check if pipes were actually changed before writing watermarks
Changes since v2:
- Write PIPE_WM_LINETIME during vblank evasion
Changes since v3:
- Rebase against new SAGV patch changes
Changes since v4:
- Add a parameter to choose what skl_wm_values struct to use when
writing new plane watermarks
Changes since v5:
- Remove cursor ddb entry write in skl_write_cursor_wm(), defer until
patch 6
- Write WM_LINETIME in intel_begin_crtc_commit()
Changes since v6:
- Remove redundant dirty_pipes check in skl_write_plane_wm (we check
this in all places where we call this function, and it was supposed
to have been removed earlier anyway)
- In i9xx_update_cursor(), use dev_priv->info.gen >= 9 instead of
IS_GEN9(dev_priv). We do this everywhere else and I'd imagine this
needs to be done for gen10 as well
Changes since v7:
- Fix rebase fail (unused variable obj)
- Make struct skl_wm_values *wm const
- Fix indenting
- Use INTEL_GEN() instead of dev_priv->info.gen
Changes since v8:
- Don't forget calls to skl_write_plane_wm() when disabling planes
- Use INTEL_GEN(), not INTEL_INFO()->gen in intel_begin_crtc_commit()
Fixes: 2d41c0b59afc ("drm/i915/skl: SKL Watermark Computation")
Signed-off-by: Lyude <cpaul@redhat.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Cc: stable@vger.kernel.org
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1471884608-10671-1-git-send-email-cpaul@redhat.com
Link: http://patchwork.freedesktop.org/patch/msgid/1471884608-10671-1-git-send-email-cpaul@redhat.com
2016-08-23 00:50:08 +08:00
|
|
|
if (wm->dirty_pipes & drm_crtc_mask(crtc))
|
2016-10-19 02:09:49 +08:00
|
|
|
skl_write_plane_wm(intel_crtc, p_wm, &wm->ddb, plane);
|
drm/i915/skl: Update plane watermarks atomically during plane updates
Thanks to Ville for suggesting this as a potential solution to pipe
underruns on Skylake.
On Skylake all of the registers for configuring planes, including the
registers for configuring their watermarks, are double buffered. New
values written to them won't take effect until said registers are
"armed", which is done by writing to the PLANE_SURF (or in the case of
cursor planes, the CURBASE register) register.
With this in mind, up until now we've been updating watermarks on skl
like this:
non-modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- intel_pre_plane_update:
- intel_update_watermarks()
- {vblank happens; new watermarks + old plane values => underrun }
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- end vblank evasion
}
or
modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- crtc_enable:
- intel_update_watermarks()
- {vblank happens; new watermarks + old plane values => underrun }
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- end vblank evasion
}
Now we update watermarks atomically like this:
non-modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- intel_pre_plane_update:
- intel_update_watermarks() (wm values aren't written yet)
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- write new wm values
- end vblank evasion
}
modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- crtc_enable:
- intel_update_watermarks() (actual wm values aren't written
yet)
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- write new wm values
- end vblank evasion
}
So this patch moves all of the watermark writes into the right place;
inside of the vblank evasion where we update all of the registers for
each plane. While this patch doesn't fix everything, it does allow us to
update the watermark values in the way the hardware expects us to.
Changes since original patch series:
- Remove mutex_lock/mutex_unlock since they don't do anything and we're
not touching global state
- Move skl_write_cursor_wm/skl_write_plane_wm functions into
intel_pm.c, make externally visible
- Add skl_write_plane_wm calls to skl_update_plane
- Fix conditional for for loop in skl_write_plane_wm (level < max_level
should be level <= max_level)
- Make diagram in commit more accurate to what's actually happening
- Add Fixes:
Changes since v1:
- Use IS_GEN9() instead of IS_SKYLAKE() since these fixes apply to more
then just Skylake
- Update description to make it clear this patch doesn't fix everything
- Check if pipes were actually changed before writing watermarks
Changes since v2:
- Write PIPE_WM_LINETIME during vblank evasion
Changes since v3:
- Rebase against new SAGV patch changes
Changes since v4:
- Add a parameter to choose what skl_wm_values struct to use when
writing new plane watermarks
Changes since v5:
- Remove cursor ddb entry write in skl_write_cursor_wm(), defer until
patch 6
- Write WM_LINETIME in intel_begin_crtc_commit()
Changes since v6:
- Remove redundant dirty_pipes check in skl_write_plane_wm (we check
this in all places where we call this function, and it was supposed
to have been removed earlier anyway)
- In i9xx_update_cursor(), use dev_priv->info.gen >= 9 instead of
IS_GEN9(dev_priv). We do this everywhere else and I'd imagine this
needs to be done for gen10 as well
Changes since v7:
- Fix rebase fail (unused variable obj)
- Make struct skl_wm_values *wm const
- Fix indenting
- Use INTEL_GEN() instead of dev_priv->info.gen
Changes since v8:
- Don't forget calls to skl_write_plane_wm() when disabling planes
- Use INTEL_GEN(), not INTEL_INFO()->gen in intel_begin_crtc_commit()
Fixes: 2d41c0b59afc ("drm/i915/skl: SKL Watermark Computation")
Signed-off-by: Lyude <cpaul@redhat.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Cc: stable@vger.kernel.org
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1471884608-10671-1-git-send-email-cpaul@redhat.com
Link: http://patchwork.freedesktop.org/patch/msgid/1471884608-10671-1-git-send-email-cpaul@redhat.com
2016-08-23 00:50:08 +08:00
|
|
|
|
2015-03-20 03:18:57 +08:00
|
|
|
if (key->flags) {
|
|
|
|
I915_WRITE(PLANE_KEYVAL(pipe, plane), key->min_value);
|
|
|
|
I915_WRITE(PLANE_KEYMAX(pipe, plane), key->max_value);
|
|
|
|
I915_WRITE(PLANE_KEYMSK(pipe, plane), key->channel_mask);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (key->flags & I915_SET_COLORKEY_DESTINATION)
|
|
|
|
plane_ctl |= PLANE_CTL_KEY_ENABLE_DESTINATION;
|
|
|
|
else if (key->flags & I915_SET_COLORKEY_SOURCE)
|
|
|
|
plane_ctl |= PLANE_CTL_KEY_ENABLE_SOURCE;
|
|
|
|
|
drm/i915: Rewrite fb rotation GTT handling
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling easier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,height,stride in tile units,
and the page offset into the object where the plane starts. Each plane
is handled exactly the same way, no special casing for NV12 or other
formats. We then store the computed rotation_info under
intel_framebuffer so that we don't have to recompute it again.
To handle fb->offsets[] we treat them as a linear offsets and convert
them to x/y offsets from the start of the relevant GTT mapping (either
normal or rotated). We store the x/y offsets under intel_framebuffer,
and for some extra convenience we also store the rotated pitch (ie.
tile aligned plane height). So for each plane we have the normal
x/y offsets, rotated x/y offsets, and the rotated pitch. The normal
pitch is available already in fb->pitches[].
While we're gathering up all that extra information, we can also easily
compute the storage requirements for the framebuffer, so that we can
check that the object is big enough to hold it.
When it comes time to deal with the plane source coordinates, we first
rotate the clipped src coordinates to match the relevant GTT view
orientation, then add to them the fb x/y offsets. Next we compute
the aligned surface page offset, and as a result we're left with some
residual x/y offsets. Finally, if required by the hardware, we convert
the remaining x/y offsets into a linear offset.
For gen2/3 we simply skip computing the final page offset, and just
convert the src+fb x/y offsets directly into a linear offset since
that's what the hardware wants.
After this all platforms, incluing SKL+, compute these things in exactly
the same way (excluding alignemnt differences).
v2: Use BIT(DRM_ROTATE_270) instead of ROTATE_270 when rotating
plane src coordinates
Drop some spurious changes that got left behind during
development
v3: Split out more changes to prep patches (Daniel)
s/intel_fb->plane[].foo.bar/intel_fb->foo[].bar/ for brevity
Rename intel_surf_gtt_offset to intel_fb_gtt_offset
Kill the pointless 'plane' parameter from intel_fb_gtt_offset()
v4: Fix alignment vs. alignment-1 when calling
_intel_compute_tile_offset() from intel_fill_fb_info()
Pass the pitch in tiles in
stad of pixels to intel_adjust_tile_offset() from intel_fill_fb_info()
Pass the full width/height of the rotated area to
drm_rect_rotate() for clarity
Use u32 for more offsets
v5: Preserve the upper_32_bits()/lower_32_bits() handling for the
fb ggtt offset (Sivakumar)
v6: Rebase due to drm_plane_state src/dst rects
Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470821001-25272-2-git-send-email-ville.syrjala@linux.intel.com
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2015-09-15 18:16:41 +08:00
|
|
|
/* Sizes are 0 based */
|
|
|
|
src_w--;
|
|
|
|
src_h--;
|
|
|
|
crtc_w--;
|
|
|
|
crtc_h--;
|
|
|
|
|
|
|
|
I915_WRITE(PLANE_OFFSET(pipe, plane), (y << 16) | x);
|
2015-10-14 03:48:39 +08:00
|
|
|
I915_WRITE(PLANE_STRIDE(pipe, plane), stride);
|
drm/i915: Rewrite fb rotation GTT handling
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling easier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,height,stride in tile units,
and the page offset into the object where the plane starts. Each plane
is handled exactly the same way, no special casing for NV12 or other
formats. We then store the computed rotation_info under
intel_framebuffer so that we don't have to recompute it again.
To handle fb->offsets[] we treat them as a linear offsets and convert
them to x/y offsets from the start of the relevant GTT mapping (either
normal or rotated). We store the x/y offsets under intel_framebuffer,
and for some extra convenience we also store the rotated pitch (ie.
tile aligned plane height). So for each plane we have the normal
x/y offsets, rotated x/y offsets, and the rotated pitch. The normal
pitch is available already in fb->pitches[].
While we're gathering up all that extra information, we can also easily
compute the storage requirements for the framebuffer, so that we can
check that the object is big enough to hold it.
When it comes time to deal with the plane source coordinates, we first
rotate the clipped src coordinates to match the relevant GTT view
orientation, then add to them the fb x/y offsets. Next we compute
the aligned surface page offset, and as a result we're left with some
residual x/y offsets. Finally, if required by the hardware, we convert
the remaining x/y offsets into a linear offset.
For gen2/3 we simply skip computing the final page offset, and just
convert the src+fb x/y offsets directly into a linear offset since
that's what the hardware wants.
After this all platforms, incluing SKL+, compute these things in exactly
the same way (excluding alignemnt differences).
v2: Use BIT(DRM_ROTATE_270) instead of ROTATE_270 when rotating
plane src coordinates
Drop some spurious changes that got left behind during
development
v3: Split out more changes to prep patches (Daniel)
s/intel_fb->plane[].foo.bar/intel_fb->foo[].bar/ for brevity
Rename intel_surf_gtt_offset to intel_fb_gtt_offset
Kill the pointless 'plane' parameter from intel_fb_gtt_offset()
v4: Fix alignment vs. alignment-1 when calling
_intel_compute_tile_offset() from intel_fill_fb_info()
Pass the pitch in tiles in
stad of pixels to intel_adjust_tile_offset() from intel_fill_fb_info()
Pass the full width/height of the rotated area to
drm_rect_rotate() for clarity
Use u32 for more offsets
v5: Preserve the upper_32_bits()/lower_32_bits() handling for the
fb ggtt offset (Sivakumar)
v6: Rebase due to drm_plane_state src/dst rects
Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470821001-25272-2-git-send-email-ville.syrjala@linux.intel.com
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2015-09-15 18:16:41 +08:00
|
|
|
I915_WRITE(PLANE_SIZE(pipe, plane), (src_h << 16) | src_w);
|
2015-04-16 06:15:02 +08:00
|
|
|
|
|
|
|
/* program plane scaler */
|
2016-01-07 18:54:06 +08:00
|
|
|
if (plane_state->scaler_id >= 0) {
|
|
|
|
int scaler_id = plane_state->scaler_id;
|
2016-05-12 21:18:49 +08:00
|
|
|
const struct intel_scaler *scaler;
|
2015-04-16 06:15:02 +08:00
|
|
|
|
|
|
|
DRM_DEBUG_KMS("plane = %d PS_PLANE_SEL(plane) = 0x%x\n", plane,
|
|
|
|
PS_PLANE_SEL(plane));
|
2016-05-12 21:18:49 +08:00
|
|
|
|
|
|
|
scaler = &crtc_state->scaler_state.scalers[scaler_id];
|
|
|
|
|
|
|
|
I915_WRITE(SKL_PS_CTRL(pipe, scaler_id),
|
|
|
|
PS_SCALER_EN | PS_PLANE_SEL(plane) | scaler->mode);
|
2015-04-16 06:15:02 +08:00
|
|
|
I915_WRITE(SKL_PS_PWR_GATE(pipe, scaler_id), 0);
|
|
|
|
I915_WRITE(SKL_PS_WIN_POS(pipe, scaler_id), (crtc_x << 16) | crtc_y);
|
|
|
|
I915_WRITE(SKL_PS_WIN_SZ(pipe, scaler_id),
|
|
|
|
((crtc_w + 1) << 16)|(crtc_h + 1));
|
|
|
|
|
|
|
|
I915_WRITE(PLANE_POS(pipe, plane), 0);
|
|
|
|
} else {
|
|
|
|
I915_WRITE(PLANE_POS(pipe, plane), (crtc_y << 16) | crtc_x);
|
|
|
|
}
|
|
|
|
|
2013-12-04 08:49:41 +08:00
|
|
|
I915_WRITE(PLANE_CTL(pipe, plane), plane_ctl);
|
drm/i915: Rewrite fb rotation GTT handling
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling easier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,height,stride in tile units,
and the page offset into the object where the plane starts. Each plane
is handled exactly the same way, no special casing for NV12 or other
formats. We then store the computed rotation_info under
intel_framebuffer so that we don't have to recompute it again.
To handle fb->offsets[] we treat them as a linear offsets and convert
them to x/y offsets from the start of the relevant GTT mapping (either
normal or rotated). We store the x/y offsets under intel_framebuffer,
and for some extra convenience we also store the rotated pitch (ie.
tile aligned plane height). So for each plane we have the normal
x/y offsets, rotated x/y offsets, and the rotated pitch. The normal
pitch is available already in fb->pitches[].
While we're gathering up all that extra information, we can also easily
compute the storage requirements for the framebuffer, so that we can
check that the object is big enough to hold it.
When it comes time to deal with the plane source coordinates, we first
rotate the clipped src coordinates to match the relevant GTT view
orientation, then add to them the fb x/y offsets. Next we compute
the aligned surface page offset, and as a result we're left with some
residual x/y offsets. Finally, if required by the hardware, we convert
the remaining x/y offsets into a linear offset.
For gen2/3 we simply skip computing the final page offset, and just
convert the src+fb x/y offsets directly into a linear offset since
that's what the hardware wants.
After this all platforms, incluing SKL+, compute these things in exactly
the same way (excluding alignemnt differences).
v2: Use BIT(DRM_ROTATE_270) instead of ROTATE_270 when rotating
plane src coordinates
Drop some spurious changes that got left behind during
development
v3: Split out more changes to prep patches (Daniel)
s/intel_fb->plane[].foo.bar/intel_fb->foo[].bar/ for brevity
Rename intel_surf_gtt_offset to intel_fb_gtt_offset
Kill the pointless 'plane' parameter from intel_fb_gtt_offset()
v4: Fix alignment vs. alignment-1 when calling
_intel_compute_tile_offset() from intel_fill_fb_info()
Pass the pitch in tiles in
stad of pixels to intel_adjust_tile_offset() from intel_fill_fb_info()
Pass the full width/height of the rotated area to
drm_rect_rotate() for clarity
Use u32 for more offsets
v5: Preserve the upper_32_bits()/lower_32_bits() handling for the
fb ggtt offset (Sivakumar)
v6: Rebase due to drm_plane_state src/dst rects
Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470821001-25272-2-git-send-email-ville.syrjala@linux.intel.com
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2015-09-15 18:16:41 +08:00
|
|
|
I915_WRITE(PLANE_SURF(pipe, plane),
|
|
|
|
intel_fb_gtt_offset(fb, rotation) + surf_addr);
|
2013-12-04 08:49:41 +08:00
|
|
|
POSTING_READ(PLANE_SURF(pipe, plane));
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2015-06-15 18:33:47 +08:00
|
|
|
skl_disable_plane(struct drm_plane *dplane, struct drm_crtc *crtc)
|
2013-12-04 08:49:41 +08:00
|
|
|
{
|
2015-04-21 22:12:51 +08:00
|
|
|
struct drm_device *dev = dplane->dev;
|
2016-07-04 18:34:36 +08:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
2015-04-21 22:12:51 +08:00
|
|
|
struct intel_plane *intel_plane = to_intel_plane(dplane);
|
2016-10-19 02:09:49 +08:00
|
|
|
struct intel_crtc_state *cstate = to_intel_crtc_state(crtc->state);
|
2013-12-04 08:49:41 +08:00
|
|
|
const int pipe = intel_plane->pipe;
|
|
|
|
const int plane = intel_plane->plane + 1;
|
|
|
|
|
2016-08-30 00:31:27 +08:00
|
|
|
/*
|
|
|
|
* We only populate skl_results on watermark updates, and if the
|
|
|
|
* plane's visiblity isn't actually changing neither is its watermarks.
|
|
|
|
*/
|
|
|
|
if (!dplane->state->visible)
|
|
|
|
skl_write_plane_wm(to_intel_crtc(crtc),
|
2016-10-19 02:09:49 +08:00
|
|
|
&cstate->wm.skl.optimal.planes[plane],
|
|
|
|
&dev_priv->wm.skl_results.ddb, plane);
|
drm/i915/skl: Update plane watermarks atomically during plane updates
Thanks to Ville for suggesting this as a potential solution to pipe
underruns on Skylake.
On Skylake all of the registers for configuring planes, including the
registers for configuring their watermarks, are double buffered. New
values written to them won't take effect until said registers are
"armed", which is done by writing to the PLANE_SURF (or in the case of
cursor planes, the CURBASE register) register.
With this in mind, up until now we've been updating watermarks on skl
like this:
non-modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- intel_pre_plane_update:
- intel_update_watermarks()
- {vblank happens; new watermarks + old plane values => underrun }
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- end vblank evasion
}
or
modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- crtc_enable:
- intel_update_watermarks()
- {vblank happens; new watermarks + old plane values => underrun }
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- end vblank evasion
}
Now we update watermarks atomically like this:
non-modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- intel_pre_plane_update:
- intel_update_watermarks() (wm values aren't written yet)
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- write new wm values
- end vblank evasion
}
modeset {
- calculate (during atomic check phase)
- finish_atomic_commit:
- crtc_enable:
- intel_update_watermarks() (actual wm values aren't written
yet)
- drm_atomic_helper_commit_planes_on_crtc:
- start vblank evasion
- write new plane registers
- write new wm values
- end vblank evasion
}
So this patch moves all of the watermark writes into the right place;
inside of the vblank evasion where we update all of the registers for
each plane. While this patch doesn't fix everything, it does allow us to
update the watermark values in the way the hardware expects us to.
Changes since original patch series:
- Remove mutex_lock/mutex_unlock since they don't do anything and we're
not touching global state
- Move skl_write_cursor_wm/skl_write_plane_wm functions into
intel_pm.c, make externally visible
- Add skl_write_plane_wm calls to skl_update_plane
- Fix conditional for for loop in skl_write_plane_wm (level < max_level
should be level <= max_level)
- Make diagram in commit more accurate to what's actually happening
- Add Fixes:
Changes since v1:
- Use IS_GEN9() instead of IS_SKYLAKE() since these fixes apply to more
then just Skylake
- Update description to make it clear this patch doesn't fix everything
- Check if pipes were actually changed before writing watermarks
Changes since v2:
- Write PIPE_WM_LINETIME during vblank evasion
Changes since v3:
- Rebase against new SAGV patch changes
Changes since v4:
- Add a parameter to choose what skl_wm_values struct to use when
writing new plane watermarks
Changes since v5:
- Remove cursor ddb entry write in skl_write_cursor_wm(), defer until
patch 6
- Write WM_LINETIME in intel_begin_crtc_commit()
Changes since v6:
- Remove redundant dirty_pipes check in skl_write_plane_wm (we check
this in all places where we call this function, and it was supposed
to have been removed earlier anyway)
- In i9xx_update_cursor(), use dev_priv->info.gen >= 9 instead of
IS_GEN9(dev_priv). We do this everywhere else and I'd imagine this
needs to be done for gen10 as well
Changes since v7:
- Fix rebase fail (unused variable obj)
- Make struct skl_wm_values *wm const
- Fix indenting
- Use INTEL_GEN() instead of dev_priv->info.gen
Changes since v8:
- Don't forget calls to skl_write_plane_wm() when disabling planes
- Use INTEL_GEN(), not INTEL_INFO()->gen in intel_begin_crtc_commit()
Fixes: 2d41c0b59afc ("drm/i915/skl: SKL Watermark Computation")
Signed-off-by: Lyude <cpaul@redhat.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Cc: stable@vger.kernel.org
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1471884608-10671-1-git-send-email-cpaul@redhat.com
Link: http://patchwork.freedesktop.org/patch/msgid/1471884608-10671-1-git-send-email-cpaul@redhat.com
2016-08-23 00:50:08 +08:00
|
|
|
|
2015-03-19 23:57:13 +08:00
|
|
|
I915_WRITE(PLANE_CTL(pipe, plane), 0);
|
2013-12-04 08:49:41 +08:00
|
|
|
|
2015-03-19 23:57:14 +08:00
|
|
|
I915_WRITE(PLANE_SURF(pipe, plane), 0);
|
|
|
|
POSTING_READ(PLANE_SURF(pipe, plane));
|
2013-12-04 08:49:41 +08:00
|
|
|
}
|
|
|
|
|
2014-10-21 00:47:53 +08:00
|
|
|
static void
|
|
|
|
chv_update_csc(struct intel_plane *intel_plane, uint32_t format)
|
|
|
|
{
|
2016-07-04 18:34:36 +08:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(intel_plane->base.dev);
|
2014-10-21 00:47:53 +08:00
|
|
|
int plane = intel_plane->plane;
|
|
|
|
|
|
|
|
/* Seems RGB data bypasses the CSC always */
|
|
|
|
if (!format_is_yuv(format))
|
|
|
|
return;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* BT.601 limited range YCbCr -> full range RGB
|
|
|
|
*
|
|
|
|
* |r| | 6537 4769 0| |cr |
|
|
|
|
* |g| = |-3330 4769 -1605| x |y-64|
|
|
|
|
* |b| | 0 4769 8263| |cb |
|
|
|
|
*
|
|
|
|
* Cb and Cr apparently come in as signed already, so no
|
|
|
|
* need for any offset. For Y we need to remove the offset.
|
|
|
|
*/
|
|
|
|
I915_WRITE(SPCSCYGOFF(plane), SPCSC_OOFF(0) | SPCSC_IOFF(-64));
|
|
|
|
I915_WRITE(SPCSCCBOFF(plane), SPCSC_OOFF(0) | SPCSC_IOFF(0));
|
|
|
|
I915_WRITE(SPCSCCROFF(plane), SPCSC_OOFF(0) | SPCSC_IOFF(0));
|
|
|
|
|
|
|
|
I915_WRITE(SPCSCC01(plane), SPCSC_C1(4769) | SPCSC_C0(6537));
|
|
|
|
I915_WRITE(SPCSCC23(plane), SPCSC_C1(-3330) | SPCSC_C0(0));
|
|
|
|
I915_WRITE(SPCSCC45(plane), SPCSC_C1(-1605) | SPCSC_C0(4769));
|
|
|
|
I915_WRITE(SPCSCC67(plane), SPCSC_C1(4769) | SPCSC_C0(0));
|
|
|
|
I915_WRITE(SPCSCC8(plane), SPCSC_C0(8263));
|
|
|
|
|
|
|
|
I915_WRITE(SPCSCYGICLAMP(plane), SPCSC_IMAX(940) | SPCSC_IMIN(64));
|
|
|
|
I915_WRITE(SPCSCCBICLAMP(plane), SPCSC_IMAX(448) | SPCSC_IMIN(-448));
|
|
|
|
I915_WRITE(SPCSCCRICLAMP(plane), SPCSC_IMAX(448) | SPCSC_IMIN(-448));
|
|
|
|
|
|
|
|
I915_WRITE(SPCSCYGOCLAMP(plane), SPCSC_OMAX(1023) | SPCSC_OMIN(0));
|
|
|
|
I915_WRITE(SPCSCCBOCLAMP(plane), SPCSC_OMAX(1023) | SPCSC_OMIN(0));
|
|
|
|
I915_WRITE(SPCSCCROCLAMP(plane), SPCSC_OMAX(1023) | SPCSC_OMIN(0));
|
|
|
|
}
|
|
|
|
|
2013-04-03 02:22:20 +08:00
|
|
|
static void
|
2016-01-07 18:54:06 +08:00
|
|
|
vlv_update_plane(struct drm_plane *dplane,
|
|
|
|
const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
2013-04-03 02:22:20 +08:00
|
|
|
{
|
|
|
|
struct drm_device *dev = dplane->dev;
|
2016-07-04 18:34:36 +08:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
2013-04-03 02:22:20 +08:00
|
|
|
struct intel_plane *intel_plane = to_intel_plane(dplane);
|
2016-01-07 18:54:06 +08:00
|
|
|
struct drm_framebuffer *fb = plane_state->base.fb;
|
2013-04-03 02:22:20 +08:00
|
|
|
int pipe = intel_plane->pipe;
|
|
|
|
int plane = intel_plane->plane;
|
|
|
|
u32 sprctl;
|
2016-01-21 03:05:25 +08:00
|
|
|
u32 sprsurf_offset, linear_offset;
|
2016-02-16 04:54:41 +08:00
|
|
|
unsigned int rotation = dplane->state->rotation;
|
2016-01-07 18:54:06 +08:00
|
|
|
const struct drm_intel_sprite_colorkey *key = &plane_state->ckey;
|
2016-07-27 00:06:59 +08:00
|
|
|
int crtc_x = plane_state->base.dst.x1;
|
|
|
|
int crtc_y = plane_state->base.dst.y1;
|
|
|
|
uint32_t crtc_w = drm_rect_width(&plane_state->base.dst);
|
|
|
|
uint32_t crtc_h = drm_rect_height(&plane_state->base.dst);
|
|
|
|
uint32_t x = plane_state->base.src.x1 >> 16;
|
|
|
|
uint32_t y = plane_state->base.src.y1 >> 16;
|
|
|
|
uint32_t src_w = drm_rect_width(&plane_state->base.src) >> 16;
|
|
|
|
uint32_t src_h = drm_rect_height(&plane_state->base.src) >> 16;
|
2013-04-03 02:22:20 +08:00
|
|
|
|
2015-03-19 23:57:13 +08:00
|
|
|
sprctl = SP_ENABLE;
|
2013-04-03 02:22:20 +08:00
|
|
|
|
|
|
|
switch (fb->pixel_format) {
|
|
|
|
case DRM_FORMAT_YUYV:
|
|
|
|
sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YUYV;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_YVYU:
|
|
|
|
sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YVYU;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_UYVY:
|
|
|
|
sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_UYVY;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_VYUY:
|
|
|
|
sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_VYUY;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_RGB565:
|
|
|
|
sprctl |= SP_FORMAT_BGR565;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XRGB8888:
|
|
|
|
sprctl |= SP_FORMAT_BGRX8888;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_ARGB8888:
|
|
|
|
sprctl |= SP_FORMAT_BGRA8888;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XBGR2101010:
|
|
|
|
sprctl |= SP_FORMAT_RGBX1010102;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_ABGR2101010:
|
|
|
|
sprctl |= SP_FORMAT_RGBA1010102;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XBGR8888:
|
|
|
|
sprctl |= SP_FORMAT_RGBX8888;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_ABGR8888:
|
|
|
|
sprctl |= SP_FORMAT_RGBA8888;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
/*
|
|
|
|
* If we get here one of the upper layers failed to filter
|
|
|
|
* out the unsupported plane formats
|
|
|
|
*/
|
|
|
|
BUG();
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2013-11-19 10:32:38 +08:00
|
|
|
/*
|
|
|
|
* Enable gamma to match primary/cursor plane behaviour.
|
|
|
|
* FIXME should be user controllable via propertiesa.
|
|
|
|
*/
|
|
|
|
sprctl |= SP_GAMMA_ENABLE;
|
|
|
|
|
2016-02-05 02:38:20 +08:00
|
|
|
if (fb->modifier[0] == I915_FORMAT_MOD_X_TILED)
|
2013-04-03 02:22:20 +08:00
|
|
|
sprctl |= SP_TILED;
|
|
|
|
|
|
|
|
/* Sizes are 0 based */
|
|
|
|
src_w--;
|
|
|
|
src_h--;
|
|
|
|
crtc_w--;
|
|
|
|
crtc_h--;
|
|
|
|
|
2016-01-21 00:02:50 +08:00
|
|
|
intel_add_fb_offsets(&x, &y, plane_state, 0);
|
|
|
|
sprsurf_offset = intel_compute_tile_offset(&x, &y, plane_state, 0);
|
2013-04-03 02:22:20 +08:00
|
|
|
|
2016-07-29 13:50:05 +08:00
|
|
|
if (rotation == DRM_ROTATE_180) {
|
2014-08-05 13:56:52 +08:00
|
|
|
sprctl |= SP_ROTATE_180;
|
|
|
|
|
|
|
|
x += src_w;
|
|
|
|
y += src_h;
|
|
|
|
}
|
|
|
|
|
2016-01-21 00:02:50 +08:00
|
|
|
linear_offset = intel_fb_xy_to_linear(x, y, plane_state, 0);
|
drm/i915: Rewrite fb rotation GTT handling
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling easier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,height,stride in tile units,
and the page offset into the object where the plane starts. Each plane
is handled exactly the same way, no special casing for NV12 or other
formats. We then store the computed rotation_info under
intel_framebuffer so that we don't have to recompute it again.
To handle fb->offsets[] we treat them as a linear offsets and convert
them to x/y offsets from the start of the relevant GTT mapping (either
normal or rotated). We store the x/y offsets under intel_framebuffer,
and for some extra convenience we also store the rotated pitch (ie.
tile aligned plane height). So for each plane we have the normal
x/y offsets, rotated x/y offsets, and the rotated pitch. The normal
pitch is available already in fb->pitches[].
While we're gathering up all that extra information, we can also easily
compute the storage requirements for the framebuffer, so that we can
check that the object is big enough to hold it.
When it comes time to deal with the plane source coordinates, we first
rotate the clipped src coordinates to match the relevant GTT view
orientation, then add to them the fb x/y offsets. Next we compute
the aligned surface page offset, and as a result we're left with some
residual x/y offsets. Finally, if required by the hardware, we convert
the remaining x/y offsets into a linear offset.
For gen2/3 we simply skip computing the final page offset, and just
convert the src+fb x/y offsets directly into a linear offset since
that's what the hardware wants.
After this all platforms, incluing SKL+, compute these things in exactly
the same way (excluding alignemnt differences).
v2: Use BIT(DRM_ROTATE_270) instead of ROTATE_270 when rotating
plane src coordinates
Drop some spurious changes that got left behind during
development
v3: Split out more changes to prep patches (Daniel)
s/intel_fb->plane[].foo.bar/intel_fb->foo[].bar/ for brevity
Rename intel_surf_gtt_offset to intel_fb_gtt_offset
Kill the pointless 'plane' parameter from intel_fb_gtt_offset()
v4: Fix alignment vs. alignment-1 when calling
_intel_compute_tile_offset() from intel_fill_fb_info()
Pass the pitch in tiles in
stad of pixels to intel_adjust_tile_offset() from intel_fill_fb_info()
Pass the full width/height of the rotated area to
drm_rect_rotate() for clarity
Use u32 for more offsets
v5: Preserve the upper_32_bits()/lower_32_bits() handling for the
fb ggtt offset (Sivakumar)
v6: Rebase due to drm_plane_state src/dst rects
Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470821001-25272-2-git-send-email-ville.syrjala@linux.intel.com
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2015-09-15 18:16:41 +08:00
|
|
|
|
2015-03-20 03:18:57 +08:00
|
|
|
if (key->flags) {
|
|
|
|
I915_WRITE(SPKEYMINVAL(pipe, plane), key->min_value);
|
|
|
|
I915_WRITE(SPKEYMAXVAL(pipe, plane), key->max_value);
|
|
|
|
I915_WRITE(SPKEYMSK(pipe, plane), key->channel_mask);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (key->flags & I915_SET_COLORKEY_SOURCE)
|
|
|
|
sprctl |= SP_SOURCE_KEY;
|
|
|
|
|
2016-10-14 17:13:44 +08:00
|
|
|
if (IS_CHERRYVIEW(dev_priv) && pipe == PIPE_B)
|
2014-10-21 00:47:53 +08:00
|
|
|
chv_update_csc(intel_plane, fb->pixel_format);
|
|
|
|
|
2014-01-18 02:09:03 +08:00
|
|
|
I915_WRITE(SPSTRIDE(pipe, plane), fb->pitches[0]);
|
|
|
|
I915_WRITE(SPPOS(pipe, plane), (crtc_y << 16) | crtc_x);
|
|
|
|
|
2016-02-05 02:38:20 +08:00
|
|
|
if (fb->modifier[0] == I915_FORMAT_MOD_X_TILED)
|
2013-04-03 02:22:20 +08:00
|
|
|
I915_WRITE(SPTILEOFF(pipe, plane), (y << 16) | x);
|
|
|
|
else
|
|
|
|
I915_WRITE(SPLINOFF(pipe, plane), linear_offset);
|
|
|
|
|
2014-10-17 01:52:34 +08:00
|
|
|
I915_WRITE(SPCONSTALPHA(pipe, plane), 0);
|
|
|
|
|
2013-04-03 02:22:20 +08:00
|
|
|
I915_WRITE(SPSIZE(pipe, plane), (crtc_h << 16) | crtc_w);
|
|
|
|
I915_WRITE(SPCNTR(pipe, plane), sprctl);
|
drm/i915: Rewrite fb rotation GTT handling
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling easier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,height,stride in tile units,
and the page offset into the object where the plane starts. Each plane
is handled exactly the same way, no special casing for NV12 or other
formats. We then store the computed rotation_info under
intel_framebuffer so that we don't have to recompute it again.
To handle fb->offsets[] we treat them as a linear offsets and convert
them to x/y offsets from the start of the relevant GTT mapping (either
normal or rotated). We store the x/y offsets under intel_framebuffer,
and for some extra convenience we also store the rotated pitch (ie.
tile aligned plane height). So for each plane we have the normal
x/y offsets, rotated x/y offsets, and the rotated pitch. The normal
pitch is available already in fb->pitches[].
While we're gathering up all that extra information, we can also easily
compute the storage requirements for the framebuffer, so that we can
check that the object is big enough to hold it.
When it comes time to deal with the plane source coordinates, we first
rotate the clipped src coordinates to match the relevant GTT view
orientation, then add to them the fb x/y offsets. Next we compute
the aligned surface page offset, and as a result we're left with some
residual x/y offsets. Finally, if required by the hardware, we convert
the remaining x/y offsets into a linear offset.
For gen2/3 we simply skip computing the final page offset, and just
convert the src+fb x/y offsets directly into a linear offset since
that's what the hardware wants.
After this all platforms, incluing SKL+, compute these things in exactly
the same way (excluding alignemnt differences).
v2: Use BIT(DRM_ROTATE_270) instead of ROTATE_270 when rotating
plane src coordinates
Drop some spurious changes that got left behind during
development
v3: Split out more changes to prep patches (Daniel)
s/intel_fb->plane[].foo.bar/intel_fb->foo[].bar/ for brevity
Rename intel_surf_gtt_offset to intel_fb_gtt_offset
Kill the pointless 'plane' parameter from intel_fb_gtt_offset()
v4: Fix alignment vs. alignment-1 when calling
_intel_compute_tile_offset() from intel_fill_fb_info()
Pass the pitch in tiles in
stad of pixels to intel_adjust_tile_offset() from intel_fill_fb_info()
Pass the full width/height of the rotated area to
drm_rect_rotate() for clarity
Use u32 for more offsets
v5: Preserve the upper_32_bits()/lower_32_bits() handling for the
fb ggtt offset (Sivakumar)
v6: Rebase due to drm_plane_state src/dst rects
Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470821001-25272-2-git-send-email-ville.syrjala@linux.intel.com
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2015-09-15 18:16:41 +08:00
|
|
|
I915_WRITE(SPSURF(pipe, plane),
|
|
|
|
intel_fb_gtt_offset(fb, rotation) + sprsurf_offset);
|
2015-05-27 01:27:23 +08:00
|
|
|
POSTING_READ(SPSURF(pipe, plane));
|
2013-04-03 02:22:20 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2015-06-15 18:33:47 +08:00
|
|
|
vlv_disable_plane(struct drm_plane *dplane, struct drm_crtc *crtc)
|
2013-04-03 02:22:20 +08:00
|
|
|
{
|
|
|
|
struct drm_device *dev = dplane->dev;
|
2016-07-04 18:34:36 +08:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
2013-04-03 02:22:20 +08:00
|
|
|
struct intel_plane *intel_plane = to_intel_plane(dplane);
|
|
|
|
int pipe = intel_plane->pipe;
|
|
|
|
int plane = intel_plane->plane;
|
|
|
|
|
2015-03-19 23:57:13 +08:00
|
|
|
I915_WRITE(SPCNTR(pipe, plane), 0);
|
|
|
|
|
2014-01-24 17:31:44 +08:00
|
|
|
I915_WRITE(SPSURF(pipe, plane), 0);
|
2015-05-27 01:27:23 +08:00
|
|
|
POSTING_READ(SPSURF(pipe, plane));
|
2013-04-03 02:22:20 +08:00
|
|
|
}
|
|
|
|
|
2011-12-14 05:19:38 +08:00
|
|
|
static void
|
2016-01-07 18:54:06 +08:00
|
|
|
ivb_update_plane(struct drm_plane *plane,
|
|
|
|
const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
2011-12-14 05:19:38 +08:00
|
|
|
{
|
|
|
|
struct drm_device *dev = plane->dev;
|
2016-07-04 18:34:36 +08:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
2011-12-14 05:19:38 +08:00
|
|
|
struct intel_plane *intel_plane = to_intel_plane(plane);
|
2016-01-07 18:54:06 +08:00
|
|
|
struct drm_framebuffer *fb = plane_state->base.fb;
|
2015-03-20 03:18:57 +08:00
|
|
|
enum pipe pipe = intel_plane->pipe;
|
2011-12-14 05:19:38 +08:00
|
|
|
u32 sprctl, sprscale = 0;
|
2016-01-21 03:05:25 +08:00
|
|
|
u32 sprsurf_offset, linear_offset;
|
2016-02-16 04:54:41 +08:00
|
|
|
unsigned int rotation = plane_state->base.rotation;
|
2016-01-07 18:54:06 +08:00
|
|
|
const struct drm_intel_sprite_colorkey *key = &plane_state->ckey;
|
2016-07-27 00:06:59 +08:00
|
|
|
int crtc_x = plane_state->base.dst.x1;
|
|
|
|
int crtc_y = plane_state->base.dst.y1;
|
|
|
|
uint32_t crtc_w = drm_rect_width(&plane_state->base.dst);
|
|
|
|
uint32_t crtc_h = drm_rect_height(&plane_state->base.dst);
|
|
|
|
uint32_t x = plane_state->base.src.x1 >> 16;
|
|
|
|
uint32_t y = plane_state->base.src.y1 >> 16;
|
|
|
|
uint32_t src_w = drm_rect_width(&plane_state->base.src) >> 16;
|
|
|
|
uint32_t src_h = drm_rect_height(&plane_state->base.src) >> 16;
|
2011-12-14 05:19:38 +08:00
|
|
|
|
2015-03-19 23:57:13 +08:00
|
|
|
sprctl = SPRITE_ENABLE;
|
2011-12-14 05:19:38 +08:00
|
|
|
|
|
|
|
switch (fb->pixel_format) {
|
|
|
|
case DRM_FORMAT_XBGR8888:
|
2012-08-23 14:38:57 +08:00
|
|
|
sprctl |= SPRITE_FORMAT_RGBX888 | SPRITE_RGB_ORDER_RGBX;
|
2011-12-14 05:19:38 +08:00
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XRGB8888:
|
2012-08-23 14:38:57 +08:00
|
|
|
sprctl |= SPRITE_FORMAT_RGBX888;
|
2011-12-14 05:19:38 +08:00
|
|
|
break;
|
|
|
|
case DRM_FORMAT_YUYV:
|
|
|
|
sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YUYV;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_YVYU:
|
|
|
|
sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YVYU;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_UYVY:
|
|
|
|
sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_UYVY;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_VYUY:
|
|
|
|
sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_VYUY;
|
|
|
|
break;
|
|
|
|
default:
|
2012-10-31 23:50:21 +08:00
|
|
|
BUG();
|
2011-12-14 05:19:38 +08:00
|
|
|
}
|
|
|
|
|
2013-11-19 10:32:38 +08:00
|
|
|
/*
|
|
|
|
* Enable gamma to match primary/cursor plane behaviour.
|
|
|
|
* FIXME should be user controllable via propertiesa.
|
|
|
|
*/
|
|
|
|
sprctl |= SPRITE_GAMMA_ENABLE;
|
|
|
|
|
2016-02-05 02:38:20 +08:00
|
|
|
if (fb->modifier[0] == I915_FORMAT_MOD_X_TILED)
|
2011-12-14 05:19:38 +08:00
|
|
|
sprctl |= SPRITE_TILED;
|
|
|
|
|
2016-10-13 18:03:00 +08:00
|
|
|
if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
|
2013-08-24 06:51:28 +08:00
|
|
|
sprctl &= ~SPRITE_TRICKLE_FEED_DISABLE;
|
|
|
|
else
|
|
|
|
sprctl |= SPRITE_TRICKLE_FEED_DISABLE;
|
|
|
|
|
2016-10-13 18:03:00 +08:00
|
|
|
if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
|
2013-01-19 01:11:38 +08:00
|
|
|
sprctl |= SPRITE_PIPE_CSC_ENABLE;
|
|
|
|
|
2011-12-14 05:19:38 +08:00
|
|
|
/* Sizes are 0 based */
|
|
|
|
src_w--;
|
|
|
|
src_h--;
|
|
|
|
crtc_w--;
|
|
|
|
crtc_h--;
|
|
|
|
|
2013-12-05 21:51:39 +08:00
|
|
|
if (crtc_w != src_w || crtc_h != src_h)
|
2011-12-14 05:19:38 +08:00
|
|
|
sprscale = SPRITE_SCALE_ENABLE | (src_w << 16) | src_h;
|
|
|
|
|
2016-01-21 00:02:50 +08:00
|
|
|
intel_add_fb_offsets(&x, &y, plane_state, 0);
|
|
|
|
sprsurf_offset = intel_compute_tile_offset(&x, &y, plane_state, 0);
|
2012-10-27 01:20:12 +08:00
|
|
|
|
2016-07-29 13:50:05 +08:00
|
|
|
if (rotation == DRM_ROTATE_180) {
|
2014-08-05 13:56:52 +08:00
|
|
|
sprctl |= SPRITE_ROTATE_180;
|
|
|
|
|
|
|
|
/* HSW and BDW does this automagically in hardware */
|
2016-10-13 18:03:00 +08:00
|
|
|
if (!IS_HASWELL(dev_priv) && !IS_BROADWELL(dev_priv)) {
|
2014-08-05 13:56:52 +08:00
|
|
|
x += src_w;
|
|
|
|
y += src_h;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-01-21 00:02:50 +08:00
|
|
|
linear_offset = intel_fb_xy_to_linear(x, y, plane_state, 0);
|
drm/i915: Rewrite fb rotation GTT handling
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling easier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,height,stride in tile units,
and the page offset into the object where the plane starts. Each plane
is handled exactly the same way, no special casing for NV12 or other
formats. We then store the computed rotation_info under
intel_framebuffer so that we don't have to recompute it again.
To handle fb->offsets[] we treat them as a linear offsets and convert
them to x/y offsets from the start of the relevant GTT mapping (either
normal or rotated). We store the x/y offsets under intel_framebuffer,
and for some extra convenience we also store the rotated pitch (ie.
tile aligned plane height). So for each plane we have the normal
x/y offsets, rotated x/y offsets, and the rotated pitch. The normal
pitch is available already in fb->pitches[].
While we're gathering up all that extra information, we can also easily
compute the storage requirements for the framebuffer, so that we can
check that the object is big enough to hold it.
When it comes time to deal with the plane source coordinates, we first
rotate the clipped src coordinates to match the relevant GTT view
orientation, then add to them the fb x/y offsets. Next we compute
the aligned surface page offset, and as a result we're left with some
residual x/y offsets. Finally, if required by the hardware, we convert
the remaining x/y offsets into a linear offset.
For gen2/3 we simply skip computing the final page offset, and just
convert the src+fb x/y offsets directly into a linear offset since
that's what the hardware wants.
After this all platforms, incluing SKL+, compute these things in exactly
the same way (excluding alignemnt differences).
v2: Use BIT(DRM_ROTATE_270) instead of ROTATE_270 when rotating
plane src coordinates
Drop some spurious changes that got left behind during
development
v3: Split out more changes to prep patches (Daniel)
s/intel_fb->plane[].foo.bar/intel_fb->foo[].bar/ for brevity
Rename intel_surf_gtt_offset to intel_fb_gtt_offset
Kill the pointless 'plane' parameter from intel_fb_gtt_offset()
v4: Fix alignment vs. alignment-1 when calling
_intel_compute_tile_offset() from intel_fill_fb_info()
Pass the pitch in tiles in
stad of pixels to intel_adjust_tile_offset() from intel_fill_fb_info()
Pass the full width/height of the rotated area to
drm_rect_rotate() for clarity
Use u32 for more offsets
v5: Preserve the upper_32_bits()/lower_32_bits() handling for the
fb ggtt offset (Sivakumar)
v6: Rebase due to drm_plane_state src/dst rects
Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470821001-25272-2-git-send-email-ville.syrjala@linux.intel.com
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2015-09-15 18:16:41 +08:00
|
|
|
|
2015-03-20 03:18:57 +08:00
|
|
|
if (key->flags) {
|
|
|
|
I915_WRITE(SPRKEYVAL(pipe), key->min_value);
|
|
|
|
I915_WRITE(SPRKEYMAX(pipe), key->max_value);
|
|
|
|
I915_WRITE(SPRKEYMSK(pipe), key->channel_mask);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (key->flags & I915_SET_COLORKEY_DESTINATION)
|
|
|
|
sprctl |= SPRITE_DEST_KEY;
|
|
|
|
else if (key->flags & I915_SET_COLORKEY_SOURCE)
|
|
|
|
sprctl |= SPRITE_SOURCE_KEY;
|
|
|
|
|
2014-01-18 02:09:03 +08:00
|
|
|
I915_WRITE(SPRSTRIDE(pipe), fb->pitches[0]);
|
|
|
|
I915_WRITE(SPRPOS(pipe), (crtc_y << 16) | crtc_x);
|
|
|
|
|
2012-10-27 01:20:12 +08:00
|
|
|
/* HSW consolidates SPRTILEOFF and SPRLINOFF into a single SPROFFSET
|
|
|
|
* register */
|
2016-10-13 18:03:00 +08:00
|
|
|
if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
|
2012-10-27 01:20:11 +08:00
|
|
|
I915_WRITE(SPROFFSET(pipe), (y << 16) | x);
|
2016-02-05 02:38:20 +08:00
|
|
|
else if (fb->modifier[0] == I915_FORMAT_MOD_X_TILED)
|
2011-12-14 05:19:38 +08:00
|
|
|
I915_WRITE(SPRTILEOFF(pipe), (y << 16) | x);
|
2012-10-27 01:20:12 +08:00
|
|
|
else
|
|
|
|
I915_WRITE(SPRLINOFF(pipe), linear_offset);
|
2012-10-27 01:20:11 +08:00
|
|
|
|
2011-12-14 05:19:38 +08:00
|
|
|
I915_WRITE(SPRSIZE(pipe), (crtc_h << 16) | crtc_w);
|
2012-10-23 01:19:27 +08:00
|
|
|
if (intel_plane->can_scale)
|
|
|
|
I915_WRITE(SPRSCALE(pipe), sprscale);
|
2011-12-14 05:19:38 +08:00
|
|
|
I915_WRITE(SPRCTL(pipe), sprctl);
|
2014-01-24 17:31:44 +08:00
|
|
|
I915_WRITE(SPRSURF(pipe),
|
drm/i915: Rewrite fb rotation GTT handling
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling easier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,height,stride in tile units,
and the page offset into the object where the plane starts. Each plane
is handled exactly the same way, no special casing for NV12 or other
formats. We then store the computed rotation_info under
intel_framebuffer so that we don't have to recompute it again.
To handle fb->offsets[] we treat them as a linear offsets and convert
them to x/y offsets from the start of the relevant GTT mapping (either
normal or rotated). We store the x/y offsets under intel_framebuffer,
and for some extra convenience we also store the rotated pitch (ie.
tile aligned plane height). So for each plane we have the normal
x/y offsets, rotated x/y offsets, and the rotated pitch. The normal
pitch is available already in fb->pitches[].
While we're gathering up all that extra information, we can also easily
compute the storage requirements for the framebuffer, so that we can
check that the object is big enough to hold it.
When it comes time to deal with the plane source coordinates, we first
rotate the clipped src coordinates to match the relevant GTT view
orientation, then add to them the fb x/y offsets. Next we compute
the aligned surface page offset, and as a result we're left with some
residual x/y offsets. Finally, if required by the hardware, we convert
the remaining x/y offsets into a linear offset.
For gen2/3 we simply skip computing the final page offset, and just
convert the src+fb x/y offsets directly into a linear offset since
that's what the hardware wants.
After this all platforms, incluing SKL+, compute these things in exactly
the same way (excluding alignemnt differences).
v2: Use BIT(DRM_ROTATE_270) instead of ROTATE_270 when rotating
plane src coordinates
Drop some spurious changes that got left behind during
development
v3: Split out more changes to prep patches (Daniel)
s/intel_fb->plane[].foo.bar/intel_fb->foo[].bar/ for brevity
Rename intel_surf_gtt_offset to intel_fb_gtt_offset
Kill the pointless 'plane' parameter from intel_fb_gtt_offset()
v4: Fix alignment vs. alignment-1 when calling
_intel_compute_tile_offset() from intel_fill_fb_info()
Pass the pitch in tiles in
stad of pixels to intel_adjust_tile_offset() from intel_fill_fb_info()
Pass the full width/height of the rotated area to
drm_rect_rotate() for clarity
Use u32 for more offsets
v5: Preserve the upper_32_bits()/lower_32_bits() handling for the
fb ggtt offset (Sivakumar)
v6: Rebase due to drm_plane_state src/dst rects
Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470821001-25272-2-git-send-email-ville.syrjala@linux.intel.com
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2015-09-15 18:16:41 +08:00
|
|
|
intel_fb_gtt_offset(fb, rotation) + sprsurf_offset);
|
2015-05-27 01:27:23 +08:00
|
|
|
POSTING_READ(SPRSURF(pipe));
|
2011-12-14 05:19:38 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2015-06-15 18:33:47 +08:00
|
|
|
ivb_disable_plane(struct drm_plane *plane, struct drm_crtc *crtc)
|
2011-12-14 05:19:38 +08:00
|
|
|
{
|
|
|
|
struct drm_device *dev = plane->dev;
|
2016-07-04 18:34:36 +08:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
2011-12-14 05:19:38 +08:00
|
|
|
struct intel_plane *intel_plane = to_intel_plane(plane);
|
|
|
|
int pipe = intel_plane->pipe;
|
|
|
|
|
2015-10-15 22:04:04 +08:00
|
|
|
I915_WRITE(SPRCTL(pipe), 0);
|
2011-12-14 05:19:38 +08:00
|
|
|
/* Can't leave the scaler enabled... */
|
2012-10-23 01:19:27 +08:00
|
|
|
if (intel_plane->can_scale)
|
|
|
|
I915_WRITE(SPRSCALE(pipe), 0);
|
2014-04-29 18:35:47 +08:00
|
|
|
|
2015-05-27 01:27:23 +08:00
|
|
|
I915_WRITE(SPRSURF(pipe), 0);
|
|
|
|
POSTING_READ(SPRSURF(pipe));
|
2011-12-14 05:19:38 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2016-01-07 18:54:06 +08:00
|
|
|
ilk_update_plane(struct drm_plane *plane,
|
|
|
|
const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
2011-12-14 05:19:38 +08:00
|
|
|
{
|
|
|
|
struct drm_device *dev = plane->dev;
|
2016-07-04 18:34:36 +08:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
2011-12-14 05:19:38 +08:00
|
|
|
struct intel_plane *intel_plane = to_intel_plane(plane);
|
2016-01-07 18:54:06 +08:00
|
|
|
struct drm_framebuffer *fb = plane_state->base.fb;
|
2012-10-31 23:50:20 +08:00
|
|
|
int pipe = intel_plane->pipe;
|
2012-04-15 05:14:26 +08:00
|
|
|
u32 dvscntr, dvsscale;
|
2016-01-21 03:05:25 +08:00
|
|
|
u32 dvssurf_offset, linear_offset;
|
2016-02-16 04:54:41 +08:00
|
|
|
unsigned int rotation = plane_state->base.rotation;
|
2016-01-07 18:54:06 +08:00
|
|
|
const struct drm_intel_sprite_colorkey *key = &plane_state->ckey;
|
2016-07-27 00:06:59 +08:00
|
|
|
int crtc_x = plane_state->base.dst.x1;
|
|
|
|
int crtc_y = plane_state->base.dst.y1;
|
|
|
|
uint32_t crtc_w = drm_rect_width(&plane_state->base.dst);
|
|
|
|
uint32_t crtc_h = drm_rect_height(&plane_state->base.dst);
|
|
|
|
uint32_t x = plane_state->base.src.x1 >> 16;
|
|
|
|
uint32_t y = plane_state->base.src.y1 >> 16;
|
|
|
|
uint32_t src_w = drm_rect_width(&plane_state->base.src) >> 16;
|
|
|
|
uint32_t src_h = drm_rect_height(&plane_state->base.src) >> 16;
|
2011-12-14 05:19:38 +08:00
|
|
|
|
2015-03-19 23:57:13 +08:00
|
|
|
dvscntr = DVS_ENABLE;
|
2011-12-14 05:19:38 +08:00
|
|
|
|
|
|
|
switch (fb->pixel_format) {
|
|
|
|
case DRM_FORMAT_XBGR8888:
|
2012-02-28 04:40:10 +08:00
|
|
|
dvscntr |= DVS_FORMAT_RGBX888 | DVS_RGB_ORDER_XBGR;
|
2011-12-14 05:19:38 +08:00
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XRGB8888:
|
2012-02-28 04:40:10 +08:00
|
|
|
dvscntr |= DVS_FORMAT_RGBX888;
|
2011-12-14 05:19:38 +08:00
|
|
|
break;
|
|
|
|
case DRM_FORMAT_YUYV:
|
|
|
|
dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YUYV;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_YVYU:
|
|
|
|
dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YVYU;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_UYVY:
|
|
|
|
dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_UYVY;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_VYUY:
|
|
|
|
dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_VYUY;
|
|
|
|
break;
|
|
|
|
default:
|
2012-10-31 23:50:21 +08:00
|
|
|
BUG();
|
2011-12-14 05:19:38 +08:00
|
|
|
}
|
|
|
|
|
2013-11-19 10:32:38 +08:00
|
|
|
/*
|
|
|
|
* Enable gamma to match primary/cursor plane behaviour.
|
|
|
|
* FIXME should be user controllable via propertiesa.
|
|
|
|
*/
|
|
|
|
dvscntr |= DVS_GAMMA_ENABLE;
|
|
|
|
|
2016-02-05 02:38:20 +08:00
|
|
|
if (fb->modifier[0] == I915_FORMAT_MOD_X_TILED)
|
2011-12-14 05:19:38 +08:00
|
|
|
dvscntr |= DVS_TILED;
|
|
|
|
|
2016-10-13 18:03:10 +08:00
|
|
|
if (IS_GEN6(dev_priv))
|
2012-04-10 18:41:49 +08:00
|
|
|
dvscntr |= DVS_TRICKLE_FEED_DISABLE; /* must disable */
|
2011-12-14 05:19:38 +08:00
|
|
|
|
|
|
|
/* Sizes are 0 based */
|
|
|
|
src_w--;
|
|
|
|
src_h--;
|
|
|
|
crtc_w--;
|
|
|
|
crtc_h--;
|
|
|
|
|
2012-04-15 05:14:26 +08:00
|
|
|
dvsscale = 0;
|
2013-12-05 21:51:31 +08:00
|
|
|
if (crtc_w != src_w || crtc_h != src_h)
|
2011-12-14 05:19:38 +08:00
|
|
|
dvsscale = DVS_SCALE_ENABLE | (src_w << 16) | src_h;
|
|
|
|
|
2016-01-21 00:02:50 +08:00
|
|
|
intel_add_fb_offsets(&x, &y, plane_state, 0);
|
|
|
|
dvssurf_offset = intel_compute_tile_offset(&x, &y, plane_state, 0);
|
2012-10-27 01:20:12 +08:00
|
|
|
|
2016-07-29 13:50:05 +08:00
|
|
|
if (rotation == DRM_ROTATE_180) {
|
2014-08-05 13:56:52 +08:00
|
|
|
dvscntr |= DVS_ROTATE_180;
|
|
|
|
|
|
|
|
x += src_w;
|
|
|
|
y += src_h;
|
|
|
|
}
|
|
|
|
|
2016-01-21 00:02:50 +08:00
|
|
|
linear_offset = intel_fb_xy_to_linear(x, y, plane_state, 0);
|
drm/i915: Rewrite fb rotation GTT handling
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling easier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,height,stride in tile units,
and the page offset into the object where the plane starts. Each plane
is handled exactly the same way, no special casing for NV12 or other
formats. We then store the computed rotation_info under
intel_framebuffer so that we don't have to recompute it again.
To handle fb->offsets[] we treat them as a linear offsets and convert
them to x/y offsets from the start of the relevant GTT mapping (either
normal or rotated). We store the x/y offsets under intel_framebuffer,
and for some extra convenience we also store the rotated pitch (ie.
tile aligned plane height). So for each plane we have the normal
x/y offsets, rotated x/y offsets, and the rotated pitch. The normal
pitch is available already in fb->pitches[].
While we're gathering up all that extra information, we can also easily
compute the storage requirements for the framebuffer, so that we can
check that the object is big enough to hold it.
When it comes time to deal with the plane source coordinates, we first
rotate the clipped src coordinates to match the relevant GTT view
orientation, then add to them the fb x/y offsets. Next we compute
the aligned surface page offset, and as a result we're left with some
residual x/y offsets. Finally, if required by the hardware, we convert
the remaining x/y offsets into a linear offset.
For gen2/3 we simply skip computing the final page offset, and just
convert the src+fb x/y offsets directly into a linear offset since
that's what the hardware wants.
After this all platforms, incluing SKL+, compute these things in exactly
the same way (excluding alignemnt differences).
v2: Use BIT(DRM_ROTATE_270) instead of ROTATE_270 when rotating
plane src coordinates
Drop some spurious changes that got left behind during
development
v3: Split out more changes to prep patches (Daniel)
s/intel_fb->plane[].foo.bar/intel_fb->foo[].bar/ for brevity
Rename intel_surf_gtt_offset to intel_fb_gtt_offset
Kill the pointless 'plane' parameter from intel_fb_gtt_offset()
v4: Fix alignment vs. alignment-1 when calling
_intel_compute_tile_offset() from intel_fill_fb_info()
Pass the pitch in tiles in
stad of pixels to intel_adjust_tile_offset() from intel_fill_fb_info()
Pass the full width/height of the rotated area to
drm_rect_rotate() for clarity
Use u32 for more offsets
v5: Preserve the upper_32_bits()/lower_32_bits() handling for the
fb ggtt offset (Sivakumar)
v6: Rebase due to drm_plane_state src/dst rects
Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470821001-25272-2-git-send-email-ville.syrjala@linux.intel.com
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2015-09-15 18:16:41 +08:00
|
|
|
|
2015-03-20 03:18:57 +08:00
|
|
|
if (key->flags) {
|
|
|
|
I915_WRITE(DVSKEYVAL(pipe), key->min_value);
|
|
|
|
I915_WRITE(DVSKEYMAX(pipe), key->max_value);
|
|
|
|
I915_WRITE(DVSKEYMSK(pipe), key->channel_mask);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (key->flags & I915_SET_COLORKEY_DESTINATION)
|
|
|
|
dvscntr |= DVS_DEST_KEY;
|
|
|
|
else if (key->flags & I915_SET_COLORKEY_SOURCE)
|
|
|
|
dvscntr |= DVS_SOURCE_KEY;
|
|
|
|
|
2014-01-18 02:09:03 +08:00
|
|
|
I915_WRITE(DVSSTRIDE(pipe), fb->pitches[0]);
|
|
|
|
I915_WRITE(DVSPOS(pipe), (crtc_y << 16) | crtc_x);
|
|
|
|
|
2016-02-05 02:38:20 +08:00
|
|
|
if (fb->modifier[0] == I915_FORMAT_MOD_X_TILED)
|
2011-12-14 05:19:38 +08:00
|
|
|
I915_WRITE(DVSTILEOFF(pipe), (y << 16) | x);
|
2012-10-27 01:20:12 +08:00
|
|
|
else
|
|
|
|
I915_WRITE(DVSLINOFF(pipe), linear_offset);
|
2011-12-14 05:19:38 +08:00
|
|
|
|
|
|
|
I915_WRITE(DVSSIZE(pipe), (crtc_h << 16) | crtc_w);
|
|
|
|
I915_WRITE(DVSSCALE(pipe), dvsscale);
|
|
|
|
I915_WRITE(DVSCNTR(pipe), dvscntr);
|
2014-01-24 17:31:44 +08:00
|
|
|
I915_WRITE(DVSSURF(pipe),
|
drm/i915: Rewrite fb rotation GTT handling
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling easier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,height,stride in tile units,
and the page offset into the object where the plane starts. Each plane
is handled exactly the same way, no special casing for NV12 or other
formats. We then store the computed rotation_info under
intel_framebuffer so that we don't have to recompute it again.
To handle fb->offsets[] we treat them as a linear offsets and convert
them to x/y offsets from the start of the relevant GTT mapping (either
normal or rotated). We store the x/y offsets under intel_framebuffer,
and for some extra convenience we also store the rotated pitch (ie.
tile aligned plane height). So for each plane we have the normal
x/y offsets, rotated x/y offsets, and the rotated pitch. The normal
pitch is available already in fb->pitches[].
While we're gathering up all that extra information, we can also easily
compute the storage requirements for the framebuffer, so that we can
check that the object is big enough to hold it.
When it comes time to deal with the plane source coordinates, we first
rotate the clipped src coordinates to match the relevant GTT view
orientation, then add to them the fb x/y offsets. Next we compute
the aligned surface page offset, and as a result we're left with some
residual x/y offsets. Finally, if required by the hardware, we convert
the remaining x/y offsets into a linear offset.
For gen2/3 we simply skip computing the final page offset, and just
convert the src+fb x/y offsets directly into a linear offset since
that's what the hardware wants.
After this all platforms, incluing SKL+, compute these things in exactly
the same way (excluding alignemnt differences).
v2: Use BIT(DRM_ROTATE_270) instead of ROTATE_270 when rotating
plane src coordinates
Drop some spurious changes that got left behind during
development
v3: Split out more changes to prep patches (Daniel)
s/intel_fb->plane[].foo.bar/intel_fb->foo[].bar/ for brevity
Rename intel_surf_gtt_offset to intel_fb_gtt_offset
Kill the pointless 'plane' parameter from intel_fb_gtt_offset()
v4: Fix alignment vs. alignment-1 when calling
_intel_compute_tile_offset() from intel_fill_fb_info()
Pass the pitch in tiles in
stad of pixels to intel_adjust_tile_offset() from intel_fill_fb_info()
Pass the full width/height of the rotated area to
drm_rect_rotate() for clarity
Use u32 for more offsets
v5: Preserve the upper_32_bits()/lower_32_bits() handling for the
fb ggtt offset (Sivakumar)
v6: Rebase due to drm_plane_state src/dst rects
Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470821001-25272-2-git-send-email-ville.syrjala@linux.intel.com
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2015-09-15 18:16:41 +08:00
|
|
|
intel_fb_gtt_offset(fb, rotation) + dvssurf_offset);
|
2015-05-27 01:27:23 +08:00
|
|
|
POSTING_READ(DVSSURF(pipe));
|
2011-12-14 05:19:38 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2015-06-15 18:33:47 +08:00
|
|
|
ilk_disable_plane(struct drm_plane *plane, struct drm_crtc *crtc)
|
2011-12-14 05:19:38 +08:00
|
|
|
{
|
|
|
|
struct drm_device *dev = plane->dev;
|
2016-07-04 18:34:36 +08:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
2011-12-14 05:19:38 +08:00
|
|
|
struct intel_plane *intel_plane = to_intel_plane(plane);
|
|
|
|
int pipe = intel_plane->pipe;
|
|
|
|
|
2015-03-19 23:57:13 +08:00
|
|
|
I915_WRITE(DVSCNTR(pipe), 0);
|
2011-12-14 05:19:38 +08:00
|
|
|
/* Disable the scaler */
|
|
|
|
I915_WRITE(DVSSCALE(pipe), 0);
|
2015-03-19 23:57:13 +08:00
|
|
|
|
2014-01-24 17:31:44 +08:00
|
|
|
I915_WRITE(DVSSURF(pipe), 0);
|
2015-05-27 01:27:23 +08:00
|
|
|
POSTING_READ(DVSSURF(pipe));
|
2011-12-14 05:19:38 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2014-09-06 04:04:47 +08:00
|
|
|
intel_check_sprite_plane(struct drm_plane *plane,
|
2015-06-15 18:33:46 +08:00
|
|
|
struct intel_crtc_state *crtc_state,
|
2014-09-06 04:04:47 +08:00
|
|
|
struct intel_plane_state *state)
|
2011-12-14 05:19:38 +08:00
|
|
|
{
|
2016-10-14 16:17:22 +08:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->dev);
|
2015-06-15 18:33:46 +08:00
|
|
|
struct drm_crtc *crtc = state->base.crtc;
|
|
|
|
struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
|
2011-12-14 05:19:38 +08:00
|
|
|
struct intel_plane *intel_plane = to_intel_plane(plane);
|
2014-12-02 07:40:13 +08:00
|
|
|
struct drm_framebuffer *fb = state->base.fb;
|
2014-09-06 04:04:47 +08:00
|
|
|
int crtc_x, crtc_y;
|
|
|
|
unsigned int crtc_w, crtc_h;
|
|
|
|
uint32_t src_x, src_y, src_w, src_h;
|
2016-07-27 00:06:59 +08:00
|
|
|
struct drm_rect *src = &state->base.src;
|
|
|
|
struct drm_rect *dst = &state->base.dst;
|
2014-09-06 04:04:47 +08:00
|
|
|
const struct drm_rect *clip = &state->clip;
|
2013-04-24 23:52:38 +08:00
|
|
|
int hscale, vscale;
|
|
|
|
int max_scale, min_scale;
|
2015-05-19 07:18:44 +08:00
|
|
|
bool can_scale;
|
2016-01-28 22:53:54 +08:00
|
|
|
int ret;
|
2014-12-05 02:27:42 +08:00
|
|
|
|
2016-07-27 00:07:00 +08:00
|
|
|
src->x1 = state->base.src_x;
|
|
|
|
src->y1 = state->base.src_y;
|
|
|
|
src->x2 = state->base.src_x + state->base.src_w;
|
|
|
|
src->y2 = state->base.src_y + state->base.src_h;
|
|
|
|
|
|
|
|
dst->x1 = state->base.crtc_x;
|
|
|
|
dst->y1 = state->base.crtc_y;
|
|
|
|
dst->x2 = state->base.crtc_x + state->base.crtc_w;
|
|
|
|
dst->y2 = state->base.crtc_y + state->base.crtc_h;
|
|
|
|
|
2014-12-05 02:27:42 +08:00
|
|
|
if (!fb) {
|
2016-07-27 00:06:59 +08:00
|
|
|
state->base.visible = false;
|
2015-06-15 18:33:44 +08:00
|
|
|
return 0;
|
2014-12-05 02:27:42 +08:00
|
|
|
}
|
2013-03-27 00:25:43 +08:00
|
|
|
|
2013-04-24 23:52:38 +08:00
|
|
|
/* Don't modify another pipe's plane */
|
|
|
|
if (intel_plane->pipe != intel_crtc->pipe) {
|
|
|
|
DRM_DEBUG_KMS("Wrong plane <-> crtc mapping\n");
|
2011-12-14 05:19:38 +08:00
|
|
|
return -EINVAL;
|
2013-04-24 23:52:38 +08:00
|
|
|
}
|
2011-12-14 05:19:38 +08:00
|
|
|
|
2013-04-24 23:52:38 +08:00
|
|
|
/* FIXME check all gen limits */
|
|
|
|
if (fb->width < 3 || fb->height < 3 || fb->pitches[0] > 16384) {
|
|
|
|
DRM_DEBUG_KMS("Unsuitable framebuffer for plane\n");
|
2011-12-14 05:19:38 +08:00
|
|
|
return -EINVAL;
|
2013-04-24 23:52:38 +08:00
|
|
|
}
|
2011-12-14 05:19:38 +08:00
|
|
|
|
2015-05-19 07:18:44 +08:00
|
|
|
/* setup can_scale, min_scale, max_scale */
|
2016-10-14 16:17:22 +08:00
|
|
|
if (INTEL_GEN(dev_priv) >= 9) {
|
2015-05-19 07:18:44 +08:00
|
|
|
/* use scaler when colorkey is not required */
|
2015-06-15 18:33:54 +08:00
|
|
|
if (state->ckey.flags == I915_SET_COLORKEY_NONE) {
|
2015-05-19 07:18:44 +08:00
|
|
|
can_scale = 1;
|
|
|
|
min_scale = 1;
|
|
|
|
max_scale = skl_max_scale(intel_crtc, crtc_state);
|
|
|
|
} else {
|
|
|
|
can_scale = 0;
|
|
|
|
min_scale = DRM_PLANE_HELPER_NO_SCALING;
|
|
|
|
max_scale = DRM_PLANE_HELPER_NO_SCALING;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
can_scale = intel_plane->can_scale;
|
|
|
|
max_scale = intel_plane->max_downscale << 16;
|
|
|
|
min_scale = intel_plane->can_scale ? 1 : (1 << 16);
|
|
|
|
}
|
|
|
|
|
2013-04-24 23:52:39 +08:00
|
|
|
/*
|
|
|
|
* FIXME the following code does a bunch of fuzzy adjustments to the
|
|
|
|
* coordinates and sizes. We probably need some way to decide whether
|
|
|
|
* more strict checking should be done instead.
|
|
|
|
*/
|
2014-09-06 04:04:47 +08:00
|
|
|
drm_rect_rotate(src, fb->width << 16, fb->height << 16,
|
2015-01-22 08:35:41 +08:00
|
|
|
state->base.rotation);
|
2014-08-05 13:56:52 +08:00
|
|
|
|
2014-09-06 04:04:47 +08:00
|
|
|
hscale = drm_rect_calc_hscale_relaxed(src, dst, min_scale, max_scale);
|
2013-04-24 23:52:39 +08:00
|
|
|
BUG_ON(hscale < 0);
|
2013-04-24 23:52:38 +08:00
|
|
|
|
2014-09-06 04:04:47 +08:00
|
|
|
vscale = drm_rect_calc_vscale_relaxed(src, dst, min_scale, max_scale);
|
2013-04-24 23:52:39 +08:00
|
|
|
BUG_ON(vscale < 0);
|
2011-12-14 05:19:38 +08:00
|
|
|
|
2016-07-27 00:06:59 +08:00
|
|
|
state->base.visible = drm_rect_clip_scaled(src, dst, clip, hscale, vscale);
|
2011-12-14 05:19:38 +08:00
|
|
|
|
2014-09-06 04:04:47 +08:00
|
|
|
crtc_x = dst->x1;
|
|
|
|
crtc_y = dst->y1;
|
|
|
|
crtc_w = drm_rect_width(dst);
|
|
|
|
crtc_h = drm_rect_height(dst);
|
2012-10-23 01:19:27 +08:00
|
|
|
|
2016-07-27 00:06:59 +08:00
|
|
|
if (state->base.visible) {
|
2013-04-24 23:52:39 +08:00
|
|
|
/* check again in case clipping clamped the results */
|
2014-09-06 04:04:47 +08:00
|
|
|
hscale = drm_rect_calc_hscale(src, dst, min_scale, max_scale);
|
2013-04-24 23:52:39 +08:00
|
|
|
if (hscale < 0) {
|
|
|
|
DRM_DEBUG_KMS("Horizontal scaling factor out of limits\n");
|
2015-11-16 23:02:36 +08:00
|
|
|
drm_rect_debug_print("src: ", src, true);
|
|
|
|
drm_rect_debug_print("dst: ", dst, false);
|
2013-04-24 23:52:39 +08:00
|
|
|
|
|
|
|
return hscale;
|
|
|
|
}
|
|
|
|
|
2014-09-06 04:04:47 +08:00
|
|
|
vscale = drm_rect_calc_vscale(src, dst, min_scale, max_scale);
|
2013-04-24 23:52:39 +08:00
|
|
|
if (vscale < 0) {
|
|
|
|
DRM_DEBUG_KMS("Vertical scaling factor out of limits\n");
|
2015-11-16 23:02:36 +08:00
|
|
|
drm_rect_debug_print("src: ", src, true);
|
|
|
|
drm_rect_debug_print("dst: ", dst, false);
|
2013-04-24 23:52:39 +08:00
|
|
|
|
|
|
|
return vscale;
|
|
|
|
}
|
|
|
|
|
2013-04-24 23:52:38 +08:00
|
|
|
/* Make the source viewport size an exact multiple of the scaling factors. */
|
2014-09-06 04:04:47 +08:00
|
|
|
drm_rect_adjust_size(src,
|
|
|
|
drm_rect_width(dst) * hscale - drm_rect_width(src),
|
|
|
|
drm_rect_height(dst) * vscale - drm_rect_height(src));
|
2013-04-24 23:52:38 +08:00
|
|
|
|
2014-09-06 04:04:47 +08:00
|
|
|
drm_rect_rotate_inv(src, fb->width << 16, fb->height << 16,
|
2015-01-22 08:35:41 +08:00
|
|
|
state->base.rotation);
|
2014-08-05 13:56:52 +08:00
|
|
|
|
2013-04-24 23:52:38 +08:00
|
|
|
/* sanity check to make sure the src viewport wasn't enlarged */
|
2014-12-24 02:41:52 +08:00
|
|
|
WARN_ON(src->x1 < (int) state->base.src_x ||
|
|
|
|
src->y1 < (int) state->base.src_y ||
|
|
|
|
src->x2 > (int) state->base.src_x + state->base.src_w ||
|
|
|
|
src->y2 > (int) state->base.src_y + state->base.src_h);
|
2013-04-24 23:52:38 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Hardware doesn't handle subpixel coordinates.
|
|
|
|
* Adjust to (macro)pixel boundary, but be careful not to
|
|
|
|
* increase the source viewport size, because that could
|
|
|
|
* push the downscaling factor out of bounds.
|
|
|
|
*/
|
2014-09-06 04:04:47 +08:00
|
|
|
src_x = src->x1 >> 16;
|
|
|
|
src_w = drm_rect_width(src) >> 16;
|
|
|
|
src_y = src->y1 >> 16;
|
|
|
|
src_h = drm_rect_height(src) >> 16;
|
2013-04-24 23:52:38 +08:00
|
|
|
|
|
|
|
if (format_is_yuv(fb->pixel_format)) {
|
|
|
|
src_x &= ~1;
|
|
|
|
src_w &= ~1;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Must keep src and dst the
|
|
|
|
* same if we can't scale.
|
|
|
|
*/
|
2015-05-19 07:18:44 +08:00
|
|
|
if (!can_scale)
|
2013-04-24 23:52:38 +08:00
|
|
|
crtc_w &= ~1;
|
|
|
|
|
|
|
|
if (crtc_w == 0)
|
2016-07-27 00:06:59 +08:00
|
|
|
state->base.visible = false;
|
2013-04-24 23:52:38 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Check size restrictions when scaling */
|
2016-07-27 00:06:59 +08:00
|
|
|
if (state->base.visible && (src_w != crtc_w || src_h != crtc_h)) {
|
2013-04-24 23:52:38 +08:00
|
|
|
unsigned int width_bytes;
|
2016-01-21 03:05:26 +08:00
|
|
|
int cpp = drm_format_plane_cpp(fb->pixel_format, 0);
|
2013-04-24 23:52:38 +08:00
|
|
|
|
2015-05-19 07:18:44 +08:00
|
|
|
WARN_ON(!can_scale);
|
2013-04-24 23:52:38 +08:00
|
|
|
|
|
|
|
/* FIXME interlacing min height is 6 */
|
|
|
|
|
|
|
|
if (crtc_w < 3 || crtc_h < 3)
|
2016-07-27 00:06:59 +08:00
|
|
|
state->base.visible = false;
|
2013-04-24 23:52:38 +08:00
|
|
|
|
|
|
|
if (src_w < 3 || src_h < 3)
|
2016-07-27 00:06:59 +08:00
|
|
|
state->base.visible = false;
|
2013-04-24 23:52:38 +08:00
|
|
|
|
2016-01-21 03:05:26 +08:00
|
|
|
width_bytes = ((src_x * cpp) & 63) + src_w * cpp;
|
2013-04-24 23:52:38 +08:00
|
|
|
|
2016-10-14 16:17:22 +08:00
|
|
|
if (INTEL_GEN(dev_priv) < 9 && (src_w > 2048 || src_h > 2048 ||
|
2015-04-16 06:15:02 +08:00
|
|
|
width_bytes > 4096 || fb->pitches[0] > 4096)) {
|
2013-04-24 23:52:38 +08:00
|
|
|
DRM_DEBUG_KMS("Source dimensions exceed hardware limits\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-07-27 00:06:59 +08:00
|
|
|
if (state->base.visible) {
|
2015-04-10 07:41:54 +08:00
|
|
|
src->x1 = src_x << 16;
|
|
|
|
src->x2 = (src_x + src_w) << 16;
|
|
|
|
src->y1 = src_y << 16;
|
|
|
|
src->y2 = (src_y + src_h) << 16;
|
2014-09-06 04:04:47 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
dst->x1 = crtc_x;
|
|
|
|
dst->x2 = crtc_x + crtc_w;
|
|
|
|
dst->y1 = crtc_y;
|
|
|
|
dst->y2 = crtc_y + crtc_h;
|
|
|
|
|
2016-10-14 16:17:22 +08:00
|
|
|
if (INTEL_GEN(dev_priv) >= 9) {
|
2016-01-28 22:53:54 +08:00
|
|
|
ret = skl_check_plane_surface(state);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-09-06 04:04:47 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-01-04 00:05:39 +08:00
|
|
|
int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
|
|
|
|
struct drm_file *file_priv)
|
|
|
|
{
|
2016-10-14 17:13:44 +08:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
2012-01-04 00:05:39 +08:00
|
|
|
struct drm_intel_sprite_colorkey *set = data;
|
|
|
|
struct drm_plane *plane;
|
2015-06-15 18:33:54 +08:00
|
|
|
struct drm_plane_state *plane_state;
|
|
|
|
struct drm_atomic_state *state;
|
|
|
|
struct drm_modeset_acquire_ctx ctx;
|
2012-01-04 00:05:39 +08:00
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
/* Make sure we don't try to enable both src & dest simultaneously */
|
|
|
|
if ((set->flags & (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE)) == (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE))
|
|
|
|
return -EINVAL;
|
|
|
|
|
2016-10-14 17:13:44 +08:00
|
|
|
if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
|
2015-03-20 03:18:57 +08:00
|
|
|
set->flags & I915_SET_COLORKEY_DESTINATION)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2014-07-18 11:30:04 +08:00
|
|
|
plane = drm_plane_find(dev, set->plane_id);
|
2015-06-15 18:33:54 +08:00
|
|
|
if (!plane || plane->type != DRM_PLANE_TYPE_OVERLAY)
|
|
|
|
return -ENOENT;
|
2012-01-04 00:05:39 +08:00
|
|
|
|
2015-06-15 18:33:54 +08:00
|
|
|
drm_modeset_acquire_init(&ctx, 0);
|
2015-04-28 04:48:39 +08:00
|
|
|
|
2015-06-15 18:33:54 +08:00
|
|
|
state = drm_atomic_state_alloc(plane->dev);
|
|
|
|
if (!state) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto out;
|
2015-04-28 04:48:39 +08:00
|
|
|
}
|
2015-06-15 18:33:54 +08:00
|
|
|
state->acquire_ctx = &ctx;
|
|
|
|
|
|
|
|
while (1) {
|
|
|
|
plane_state = drm_atomic_get_plane_state(state, plane);
|
|
|
|
ret = PTR_ERR_OR_ZERO(plane_state);
|
|
|
|
if (!ret) {
|
|
|
|
to_intel_plane_state(plane_state)->ckey = *set;
|
|
|
|
ret = drm_atomic_commit(state);
|
|
|
|
}
|
2015-04-28 04:48:39 +08:00
|
|
|
|
2015-06-15 18:33:54 +08:00
|
|
|
if (ret != -EDEADLK)
|
|
|
|
break;
|
2012-01-04 00:05:39 +08:00
|
|
|
|
2015-06-15 18:33:54 +08:00
|
|
|
drm_atomic_state_clear(state);
|
|
|
|
drm_modeset_backoff(&ctx);
|
|
|
|
}
|
2012-01-04 00:05:39 +08:00
|
|
|
|
2016-10-14 20:18:18 +08:00
|
|
|
drm_atomic_state_put(state);
|
2015-06-15 18:33:54 +08:00
|
|
|
out:
|
|
|
|
drm_modeset_drop_locks(&ctx);
|
|
|
|
drm_modeset_acquire_fini(&ctx);
|
|
|
|
return ret;
|
2013-03-27 00:25:43 +08:00
|
|
|
}
|
|
|
|
|
2015-05-12 23:13:22 +08:00
|
|
|
static const uint32_t ilk_plane_formats[] = {
|
2012-04-10 18:41:49 +08:00
|
|
|
DRM_FORMAT_XRGB8888,
|
|
|
|
DRM_FORMAT_YUYV,
|
|
|
|
DRM_FORMAT_YVYU,
|
|
|
|
DRM_FORMAT_UYVY,
|
|
|
|
DRM_FORMAT_VYUY,
|
|
|
|
};
|
|
|
|
|
2015-05-12 23:13:22 +08:00
|
|
|
static const uint32_t snb_plane_formats[] = {
|
2011-12-14 05:19:38 +08:00
|
|
|
DRM_FORMAT_XBGR8888,
|
|
|
|
DRM_FORMAT_XRGB8888,
|
|
|
|
DRM_FORMAT_YUYV,
|
|
|
|
DRM_FORMAT_YVYU,
|
|
|
|
DRM_FORMAT_UYVY,
|
|
|
|
DRM_FORMAT_VYUY,
|
|
|
|
};
|
|
|
|
|
2015-05-12 23:13:22 +08:00
|
|
|
static const uint32_t vlv_plane_formats[] = {
|
2013-04-03 02:22:20 +08:00
|
|
|
DRM_FORMAT_RGB565,
|
|
|
|
DRM_FORMAT_ABGR8888,
|
|
|
|
DRM_FORMAT_ARGB8888,
|
|
|
|
DRM_FORMAT_XBGR8888,
|
|
|
|
DRM_FORMAT_XRGB8888,
|
|
|
|
DRM_FORMAT_XBGR2101010,
|
|
|
|
DRM_FORMAT_ABGR2101010,
|
|
|
|
DRM_FORMAT_YUYV,
|
|
|
|
DRM_FORMAT_YVYU,
|
|
|
|
DRM_FORMAT_UYVY,
|
|
|
|
DRM_FORMAT_VYUY,
|
|
|
|
};
|
|
|
|
|
2013-12-04 08:49:41 +08:00
|
|
|
static uint32_t skl_plane_formats[] = {
|
|
|
|
DRM_FORMAT_RGB565,
|
|
|
|
DRM_FORMAT_ABGR8888,
|
|
|
|
DRM_FORMAT_ARGB8888,
|
|
|
|
DRM_FORMAT_XBGR8888,
|
|
|
|
DRM_FORMAT_XRGB8888,
|
|
|
|
DRM_FORMAT_YUYV,
|
|
|
|
DRM_FORMAT_YVYU,
|
|
|
|
DRM_FORMAT_UYVY,
|
|
|
|
DRM_FORMAT_VYUY,
|
|
|
|
};
|
|
|
|
|
2011-12-14 05:19:38 +08:00
|
|
|
int
|
2013-04-03 02:22:20 +08:00
|
|
|
intel_plane_init(struct drm_device *dev, enum pipe pipe, int plane)
|
2011-12-14 05:19:38 +08:00
|
|
|
{
|
2016-10-14 17:13:44 +08:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
2016-03-21 22:43:22 +08:00
|
|
|
struct intel_plane *intel_plane = NULL;
|
|
|
|
struct intel_plane_state *state = NULL;
|
2011-12-14 05:19:38 +08:00
|
|
|
unsigned long possible_crtcs;
|
2012-04-10 18:41:49 +08:00
|
|
|
const uint32_t *plane_formats;
|
2016-09-27 00:30:56 +08:00
|
|
|
unsigned int supported_rotations;
|
2012-04-10 18:41:49 +08:00
|
|
|
int num_plane_formats;
|
2011-12-14 05:19:38 +08:00
|
|
|
int ret;
|
|
|
|
|
2012-04-10 18:41:49 +08:00
|
|
|
if (INTEL_INFO(dev)->gen < 5)
|
2011-12-14 05:19:38 +08:00
|
|
|
return -ENODEV;
|
|
|
|
|
2013-09-19 18:18:32 +08:00
|
|
|
intel_plane = kzalloc(sizeof(*intel_plane), GFP_KERNEL);
|
2016-03-21 22:43:22 +08:00
|
|
|
if (!intel_plane) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto fail;
|
|
|
|
}
|
2011-12-14 05:19:38 +08:00
|
|
|
|
2015-01-22 08:35:41 +08:00
|
|
|
state = intel_create_plane_state(&intel_plane->base);
|
|
|
|
if (!state) {
|
2016-03-21 22:43:22 +08:00
|
|
|
ret = -ENOMEM;
|
|
|
|
goto fail;
|
2014-12-24 02:41:52 +08:00
|
|
|
}
|
2015-01-22 08:35:41 +08:00
|
|
|
intel_plane->base.state = &state->base;
|
2014-12-24 02:41:52 +08:00
|
|
|
|
2012-04-10 18:41:49 +08:00
|
|
|
switch (INTEL_INFO(dev)->gen) {
|
|
|
|
case 5:
|
|
|
|
case 6:
|
2012-10-23 01:19:27 +08:00
|
|
|
intel_plane->can_scale = true;
|
2011-12-14 05:19:38 +08:00
|
|
|
intel_plane->max_downscale = 16;
|
2012-04-10 18:41:49 +08:00
|
|
|
intel_plane->update_plane = ilk_update_plane;
|
|
|
|
intel_plane->disable_plane = ilk_disable_plane;
|
|
|
|
|
2016-10-13 18:03:10 +08:00
|
|
|
if (IS_GEN6(dev_priv)) {
|
2012-04-10 18:41:49 +08:00
|
|
|
plane_formats = snb_plane_formats;
|
|
|
|
num_plane_formats = ARRAY_SIZE(snb_plane_formats);
|
|
|
|
} else {
|
|
|
|
plane_formats = ilk_plane_formats;
|
|
|
|
num_plane_formats = ARRAY_SIZE(ilk_plane_formats);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
case 7:
|
2013-11-03 12:07:07 +08:00
|
|
|
case 8:
|
2016-10-14 17:13:44 +08:00
|
|
|
if (IS_IVYBRIDGE(dev_priv)) {
|
2012-10-23 01:19:27 +08:00
|
|
|
intel_plane->can_scale = true;
|
2013-04-25 22:15:00 +08:00
|
|
|
intel_plane->max_downscale = 2;
|
|
|
|
} else {
|
|
|
|
intel_plane->can_scale = false;
|
|
|
|
intel_plane->max_downscale = 1;
|
|
|
|
}
|
2013-04-03 02:22:20 +08:00
|
|
|
|
2016-10-14 17:13:44 +08:00
|
|
|
if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) {
|
2013-04-03 02:22:20 +08:00
|
|
|
intel_plane->update_plane = vlv_update_plane;
|
|
|
|
intel_plane->disable_plane = vlv_disable_plane;
|
|
|
|
|
|
|
|
plane_formats = vlv_plane_formats;
|
|
|
|
num_plane_formats = ARRAY_SIZE(vlv_plane_formats);
|
|
|
|
} else {
|
|
|
|
intel_plane->update_plane = ivb_update_plane;
|
|
|
|
intel_plane->disable_plane = ivb_disable_plane;
|
|
|
|
|
|
|
|
plane_formats = snb_plane_formats;
|
|
|
|
num_plane_formats = ARRAY_SIZE(snb_plane_formats);
|
|
|
|
}
|
2012-04-10 18:41:49 +08:00
|
|
|
break;
|
2013-12-04 08:49:41 +08:00
|
|
|
case 9:
|
2015-04-16 06:15:02 +08:00
|
|
|
intel_plane->can_scale = true;
|
2013-12-04 08:49:41 +08:00
|
|
|
intel_plane->update_plane = skl_update_plane;
|
|
|
|
intel_plane->disable_plane = skl_disable_plane;
|
2015-04-08 06:28:38 +08:00
|
|
|
state->scaler_id = -1;
|
2013-12-04 08:49:41 +08:00
|
|
|
|
|
|
|
plane_formats = skl_plane_formats;
|
|
|
|
num_plane_formats = ARRAY_SIZE(skl_plane_formats);
|
|
|
|
break;
|
2012-04-10 18:41:49 +08:00
|
|
|
default:
|
2016-03-21 22:43:22 +08:00
|
|
|
MISSING_CASE(INTEL_INFO(dev)->gen);
|
|
|
|
ret = -ENODEV;
|
|
|
|
goto fail;
|
2011-12-14 05:19:38 +08:00
|
|
|
}
|
|
|
|
|
2016-10-25 14:36:13 +08:00
|
|
|
if (INTEL_GEN(dev_priv) >= 9) {
|
2016-09-27 00:30:56 +08:00
|
|
|
supported_rotations =
|
|
|
|
DRM_ROTATE_0 | DRM_ROTATE_90 |
|
|
|
|
DRM_ROTATE_180 | DRM_ROTATE_270;
|
|
|
|
} else {
|
|
|
|
supported_rotations =
|
|
|
|
DRM_ROTATE_0 | DRM_ROTATE_180;
|
|
|
|
}
|
|
|
|
|
2011-12-14 05:19:38 +08:00
|
|
|
intel_plane->pipe = pipe;
|
2013-04-03 02:22:20 +08:00
|
|
|
intel_plane->plane = plane;
|
2015-09-15 00:05:42 +08:00
|
|
|
intel_plane->frontbuffer_bit = INTEL_FRONTBUFFER_SPRITE(pipe, plane);
|
2014-12-02 07:40:16 +08:00
|
|
|
intel_plane->check_plane = intel_check_sprite_plane;
|
2016-03-21 22:43:22 +08:00
|
|
|
|
2011-12-14 05:19:38 +08:00
|
|
|
possible_crtcs = (1 << pipe);
|
2016-03-21 22:43:22 +08:00
|
|
|
|
2016-05-28 01:59:23 +08:00
|
|
|
if (INTEL_INFO(dev)->gen >= 9)
|
|
|
|
ret = drm_universal_plane_init(dev, &intel_plane->base, possible_crtcs,
|
|
|
|
&intel_plane_funcs,
|
|
|
|
plane_formats, num_plane_formats,
|
|
|
|
DRM_PLANE_TYPE_OVERLAY,
|
|
|
|
"plane %d%c", plane + 2, pipe_name(pipe));
|
|
|
|
else
|
|
|
|
ret = drm_universal_plane_init(dev, &intel_plane->base, possible_crtcs,
|
|
|
|
&intel_plane_funcs,
|
|
|
|
plane_formats, num_plane_formats,
|
|
|
|
DRM_PLANE_TYPE_OVERLAY,
|
|
|
|
"sprite %c", sprite_name(pipe, plane));
|
2016-03-21 22:43:22 +08:00
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2014-08-05 13:56:55 +08:00
|
|
|
|
2016-09-27 00:30:56 +08:00
|
|
|
drm_plane_create_rotation_property(&intel_plane->base,
|
|
|
|
DRM_ROTATE_0,
|
|
|
|
supported_rotations);
|
2011-12-14 05:19:38 +08:00
|
|
|
|
2014-12-24 02:41:52 +08:00
|
|
|
drm_plane_helper_add(&intel_plane->base, &intel_plane_helper_funcs);
|
|
|
|
|
2016-03-21 22:43:22 +08:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
fail:
|
|
|
|
kfree(state);
|
|
|
|
kfree(intel_plane);
|
|
|
|
|
2011-12-14 05:19:38 +08:00
|
|
|
return ret;
|
|
|
|
}
|