License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 22:07:57 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2015-03-31 02:34:21 +08:00
|
|
|
/*
|
2017-12-15 09:57:47 +08:00
|
|
|
* Copyright (c) 2015, 2017 Oracle. All rights reserved.
|
2015-03-31 02:34:21 +08:00
|
|
|
* Copyright (c) 2003-2007 Network Appliance, Inc. All rights reserved.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* Lightweight memory registration using Fast Registration Work
|
2017-12-15 09:57:47 +08:00
|
|
|
* Requests (FRWR).
|
2015-03-31 02:34:21 +08:00
|
|
|
*
|
|
|
|
* FRWR features ordered asynchronous registration and deregistration
|
|
|
|
* of arbitrarily sized memory regions. This is the fastest and safest
|
|
|
|
* but most complex memory registration mode.
|
|
|
|
*/
|
|
|
|
|
2015-05-26 23:52:35 +08:00
|
|
|
/* Normal operation
|
|
|
|
*
|
|
|
|
* A Memory Region is prepared for RDMA READ or WRITE using a FAST_REG
|
2018-12-19 23:59:01 +08:00
|
|
|
* Work Request (frwr_map). When the RDMA operation is finished, this
|
2015-05-26 23:52:35 +08:00
|
|
|
* Memory Region is invalidated using a LOCAL_INV Work Request
|
2018-12-19 23:59:01 +08:00
|
|
|
* (frwr_unmap_sync).
|
2015-05-26 23:52:35 +08:00
|
|
|
*
|
|
|
|
* Typically these Work Requests are not signaled, and neither are RDMA
|
|
|
|
* SEND Work Requests (with the exception of signaling occasionally to
|
|
|
|
* prevent provider work queue overflows). This greatly reduces HCA
|
|
|
|
* interrupt workload.
|
|
|
|
*
|
2018-12-19 23:59:01 +08:00
|
|
|
* As an optimization, frwr_unmap marks MRs INVALID before the
|
2015-05-26 23:52:35 +08:00
|
|
|
* LOCAL_INV WR is posted. If posting succeeds, the MR is placed on
|
2017-12-15 09:57:55 +08:00
|
|
|
* rb_mrs immediately so that no work (like managing a linked list
|
2015-05-26 23:52:35 +08:00
|
|
|
* under a spinlock) is needed in the completion upcall.
|
|
|
|
*
|
2018-12-19 23:59:01 +08:00
|
|
|
* But this means that frwr_map() can occasionally encounter an MR
|
2015-05-26 23:52:35 +08:00
|
|
|
* that is INVALID but the LOCAL_INV WR has not completed. Work Queue
|
|
|
|
* ordering prevents a subsequent FAST_REG WR from executing against
|
|
|
|
* that MR while it is still being invalidated.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* Transport recovery
|
|
|
|
*
|
|
|
|
* ->op_map and the transport connect worker cannot run at the same
|
|
|
|
* time, but ->op_unmap can fire while the transport connect worker
|
|
|
|
* is running. Thus MR recovery is handled in ->op_map, to guarantee
|
|
|
|
* that recovered MRs are owned by a sending RPC, and not one where
|
|
|
|
* ->op_unmap could fire at the same time transport reconnect is
|
|
|
|
* being done.
|
|
|
|
*
|
|
|
|
* When the underlying transport disconnects, MRs are left in one of
|
2016-11-08 05:16:24 +08:00
|
|
|
* four states:
|
2015-05-26 23:52:35 +08:00
|
|
|
*
|
|
|
|
* INVALID: The MR was not in use before the QP entered ERROR state.
|
|
|
|
*
|
|
|
|
* VALID: The MR was registered before the QP entered ERROR state.
|
|
|
|
*
|
2016-11-08 05:16:24 +08:00
|
|
|
* FLUSHED_FR: The MR was being registered when the QP entered ERROR
|
|
|
|
* state, and the pending WR was flushed.
|
|
|
|
*
|
|
|
|
* FLUSHED_LI: The MR was being invalidated when the QP entered ERROR
|
|
|
|
* state, and the pending WR was flushed.
|
|
|
|
*
|
2018-12-19 23:59:01 +08:00
|
|
|
* When frwr_map encounters FLUSHED and VALID MRs, they are recovered
|
2016-11-08 05:16:24 +08:00
|
|
|
* with ib_dereg_mr and then are re-initialized. Because MR recovery
|
2015-05-26 23:52:35 +08:00
|
|
|
* allocates fresh resources, it is deferred to a workqueue, and the
|
2017-12-15 09:57:55 +08:00
|
|
|
* recovered MRs are placed back on the rb_mrs list when recovery is
|
2018-12-19 23:59:01 +08:00
|
|
|
* complete. frwr_map allocates another MR for the current RPC while
|
2015-05-26 23:52:35 +08:00
|
|
|
* the broken MR is reset.
|
|
|
|
*
|
2018-12-19 23:59:01 +08:00
|
|
|
* To ensure that frwr_map doesn't encounter an MR that is marked
|
2015-05-26 23:52:35 +08:00
|
|
|
* INVALID but that is about to be flushed due to a previous transport
|
|
|
|
* disconnect, the transport connect worker attempts to drain all
|
|
|
|
* pending send queue WRs before the transport is reconnected.
|
|
|
|
*/
|
|
|
|
|
2016-09-15 22:57:16 +08:00
|
|
|
#include <linux/sunrpc/rpc_rdma.h>
|
2018-05-08 03:27:16 +08:00
|
|
|
#include <linux/sunrpc/svc_rdma.h>
|
2016-09-15 22:57:16 +08:00
|
|
|
|
2015-03-31 02:34:21 +08:00
|
|
|
#include "xprt_rdma.h"
|
2018-05-08 03:27:05 +08:00
|
|
|
#include <trace/events/rpcrdma.h>
|
2015-03-31 02:34:21 +08:00
|
|
|
|
|
|
|
#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)
|
|
|
|
# define RPCDBG_FACILITY RPCDBG_TRANS
|
|
|
|
#endif
|
|
|
|
|
2018-12-19 23:59:01 +08:00
|
|
|
/**
|
|
|
|
* frwr_is_supported - Check if device supports FRWR
|
|
|
|
* @ia: interface adapter to check
|
|
|
|
*
|
|
|
|
* Returns true if device supports FRWR, otherwise false
|
|
|
|
*/
|
|
|
|
bool frwr_is_supported(struct rpcrdma_ia *ia)
|
2016-06-30 01:53:27 +08:00
|
|
|
{
|
|
|
|
struct ib_device_attr *attrs = &ia->ri_device->attrs;
|
|
|
|
|
|
|
|
if (!(attrs->device_cap_flags & IB_DEVICE_MEM_MGT_EXTENSIONS))
|
|
|
|
goto out_not_supported;
|
|
|
|
if (attrs->max_fast_reg_page_list_len == 0)
|
|
|
|
goto out_not_supported;
|
|
|
|
return true;
|
|
|
|
|
|
|
|
out_not_supported:
|
|
|
|
pr_info("rpcrdma: 'frwr' mode is not supported by device %s\n",
|
|
|
|
ia->ri_device->name);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-12-19 23:59:01 +08:00
|
|
|
/**
|
|
|
|
* frwr_release_mr - Destroy one MR
|
|
|
|
* @mr: MR allocated by frwr_init_mr
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
void frwr_release_mr(struct rpcrdma_mr *mr)
|
2018-10-02 02:25:25 +08:00
|
|
|
{
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
rc = ib_dereg_mr(mr->frwr.fr_mr);
|
|
|
|
if (rc)
|
2018-12-20 00:00:06 +08:00
|
|
|
trace_xprtrdma_frwr_dereg(mr, rc);
|
2018-10-02 02:25:25 +08:00
|
|
|
kfree(mr->mr_sg);
|
|
|
|
kfree(mr);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* MRs are dynamically allocated, so simply clean up and release the MR.
|
|
|
|
* A replacement MR will subsequently be allocated on demand.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
frwr_mr_recycle_worker(struct work_struct *work)
|
|
|
|
{
|
|
|
|
struct rpcrdma_mr *mr = container_of(work, struct rpcrdma_mr, mr_recycle);
|
|
|
|
struct rpcrdma_xprt *r_xprt = mr->mr_xprt;
|
|
|
|
|
|
|
|
trace_xprtrdma_mr_recycle(mr);
|
|
|
|
|
2018-12-19 23:58:13 +08:00
|
|
|
if (mr->mr_dir != DMA_NONE) {
|
2018-10-02 02:25:30 +08:00
|
|
|
trace_xprtrdma_mr_unmap(mr);
|
2018-10-02 02:25:25 +08:00
|
|
|
ib_dma_unmap_sg(r_xprt->rx_ia.ri_device,
|
|
|
|
mr->mr_sg, mr->mr_nents, mr->mr_dir);
|
2018-12-19 23:58:13 +08:00
|
|
|
mr->mr_dir = DMA_NONE;
|
2018-10-02 02:25:25 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
spin_lock(&r_xprt->rx_buf.rb_mrlock);
|
|
|
|
list_del(&mr->mr_all);
|
|
|
|
r_xprt->rx_stats.mrs_recycled++;
|
|
|
|
spin_unlock(&r_xprt->rx_buf.rb_mrlock);
|
2018-12-19 23:59:01 +08:00
|
|
|
|
|
|
|
frwr_release_mr(mr);
|
2018-10-02 02:25:25 +08:00
|
|
|
}
|
|
|
|
|
2018-12-19 23:59:01 +08:00
|
|
|
/**
|
|
|
|
* frwr_init_mr - Initialize one MR
|
|
|
|
* @ia: interface adapter
|
|
|
|
* @mr: generic MR to prepare for FRWR
|
|
|
|
*
|
|
|
|
* Returns zero if successful. Otherwise a negative errno
|
|
|
|
* is returned.
|
|
|
|
*/
|
|
|
|
int frwr_init_mr(struct rpcrdma_ia *ia, struct rpcrdma_mr *mr)
|
2016-06-30 01:52:29 +08:00
|
|
|
{
|
2017-12-15 09:57:47 +08:00
|
|
|
unsigned int depth = ia->ri_max_frwr_depth;
|
2018-12-20 00:00:48 +08:00
|
|
|
struct scatterlist *sg;
|
|
|
|
struct ib_mr *frmr;
|
2016-06-30 01:52:29 +08:00
|
|
|
int rc;
|
|
|
|
|
2018-12-20 00:00:48 +08:00
|
|
|
frmr = ib_alloc_mr(ia->ri_pd, ia->ri_mrtype, depth);
|
|
|
|
if (IS_ERR(frmr))
|
2016-06-30 01:52:29 +08:00
|
|
|
goto out_mr_err;
|
|
|
|
|
2018-12-20 00:00:48 +08:00
|
|
|
sg = kcalloc(depth, sizeof(*sg), GFP_KERNEL);
|
|
|
|
if (!sg)
|
2016-06-30 01:52:29 +08:00
|
|
|
goto out_list_err;
|
|
|
|
|
2018-12-20 00:00:48 +08:00
|
|
|
mr->frwr.fr_mr = frmr;
|
|
|
|
mr->frwr.fr_state = FRWR_IS_INVALID;
|
2018-12-19 23:58:13 +08:00
|
|
|
mr->mr_dir = DMA_NONE;
|
xprtrdma: Fix list corruption / DMAR errors during MR recovery
The ro_release_mr methods check whether mr->mr_list is empty.
Therefore, be sure to always use list_del_init when removing an MR
linked into a list using that field. Otherwise, when recovering from
transport failures or device removal, list corruption can result, or
MRs can get mapped or unmapped an odd number of times, resulting in
IOMMU-related failures.
In general this fix is appropriate back to v4.8. However, code
changes since then make it impossible to apply this patch directly
to stable kernels. The fix would have to be applied by hand or
reworked for kernels earlier than v4.16.
Backport guidance -- there are several cases:
- When creating an MR, initialize mr_list so that using list_empty
on an as-yet-unused MR is safe.
- When an MR is being handled by the remote invalidation path,
ensure that mr_list is reinitialized when it is removed from
rl_registered.
- When an MR is being handled by rpcrdma_destroy_mrs, it is removed
from mr_all, but it may still be on an rl_registered list. In
that case, the MR needs to be removed from that list before being
released.
- Other cases are covered by using list_del_init in rpcrdma_mr_pop.
Fixes: 9d6b04097882 ('xprtrdma: Place registered MWs on a ... ')
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
2018-05-01 23:37:14 +08:00
|
|
|
INIT_LIST_HEAD(&mr->mr_list);
|
2018-10-02 02:25:25 +08:00
|
|
|
INIT_WORK(&mr->mr_recycle, frwr_mr_recycle_worker);
|
2018-12-20 00:00:48 +08:00
|
|
|
init_completion(&mr->frwr.fr_linv_done);
|
|
|
|
|
|
|
|
sg_init_table(sg, depth);
|
|
|
|
mr->mr_sg = sg;
|
2016-06-30 01:52:29 +08:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
out_mr_err:
|
2018-12-20 00:00:48 +08:00
|
|
|
rc = PTR_ERR(frmr);
|
2018-12-20 00:00:06 +08:00
|
|
|
trace_xprtrdma_frwr_alloc(mr, rc);
|
2016-06-30 01:52:29 +08:00
|
|
|
return rc;
|
|
|
|
|
|
|
|
out_list_err:
|
|
|
|
dprintk("RPC: %s: sg allocation failure\n",
|
|
|
|
__func__);
|
2018-12-20 00:00:48 +08:00
|
|
|
ib_dereg_mr(frmr);
|
|
|
|
return -ENOMEM;
|
2016-06-30 01:52:29 +08:00
|
|
|
}
|
|
|
|
|
2018-12-19 23:59:01 +08:00
|
|
|
/**
|
|
|
|
* frwr_open - Prepare an endpoint for use with FRWR
|
|
|
|
* @ia: interface adapter this endpoint will use
|
|
|
|
* @ep: endpoint to prepare
|
|
|
|
* @cdata: transport parameters
|
|
|
|
*
|
|
|
|
* On success, sets:
|
2018-05-05 03:34:48 +08:00
|
|
|
* ep->rep_attr.cap.max_send_wr
|
|
|
|
* ep->rep_attr.cap.max_recv_wr
|
|
|
|
* cdata->max_requests
|
|
|
|
* ia->ri_max_segs
|
|
|
|
*
|
|
|
|
* And these FRWR-related fields:
|
|
|
|
* ia->ri_max_frwr_depth
|
|
|
|
* ia->ri_mrtype
|
2018-12-19 23:59:01 +08:00
|
|
|
*
|
|
|
|
* On failure, a negative errno is returned.
|
2018-05-05 03:34:48 +08:00
|
|
|
*/
|
2018-12-19 23:59:01 +08:00
|
|
|
int frwr_open(struct rpcrdma_ia *ia, struct rpcrdma_ep *ep,
|
|
|
|
struct rpcrdma_create_data_internal *cdata)
|
2015-03-31 02:35:26 +08:00
|
|
|
{
|
xprtrdma: Support for SG_GAP devices
Some devices (such as the Mellanox CX-4) can register, under a
single R_key, a set of memory regions that are not contiguous. When
this is done, all the segments in a Reply list, say, can then be
invalidated in a single LocalInv Work Request (or via Remote
Invalidation, which can invalidate exactly one R_key when completing
a Receive).
This means a single FastReg WR is used to register, and one or zero
LocalInv WRs can invalidate, the memory involved with RDMA transfers
on behalf of an RPC.
In addition, xprtrdma constructs some Reply chunks from three or
more segments. By registering them with SG_GAP, only one segment
is needed for the Reply chunk, allowing the whole chunk to be
invalidated remotely.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
2016-11-29 23:52:24 +08:00
|
|
|
struct ib_device_attr *attrs = &ia->ri_device->attrs;
|
2018-05-05 03:34:48 +08:00
|
|
|
int max_qp_wr, depth, delta;
|
2015-03-31 02:35:26 +08:00
|
|
|
|
xprtrdma: Support for SG_GAP devices
Some devices (such as the Mellanox CX-4) can register, under a
single R_key, a set of memory regions that are not contiguous. When
this is done, all the segments in a Reply list, say, can then be
invalidated in a single LocalInv Work Request (or via Remote
Invalidation, which can invalidate exactly one R_key when completing
a Receive).
This means a single FastReg WR is used to register, and one or zero
LocalInv WRs can invalidate, the memory involved with RDMA transfers
on behalf of an RPC.
In addition, xprtrdma constructs some Reply chunks from three or
more segments. By registering them with SG_GAP, only one segment
is needed for the Reply chunk, allowing the whole chunk to be
invalidated remotely.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
2016-11-29 23:52:24 +08:00
|
|
|
ia->ri_mrtype = IB_MR_TYPE_MEM_REG;
|
|
|
|
if (attrs->device_cap_flags & IB_DEVICE_SG_GAPS_REG)
|
|
|
|
ia->ri_mrtype = IB_MR_TYPE_SG_GAPS;
|
|
|
|
|
2018-12-19 23:58:51 +08:00
|
|
|
/* Quirk: Some devices advertise a large max_fast_reg_page_list_len
|
|
|
|
* capability, but perform optimally when the MRs are not larger
|
|
|
|
* than a page.
|
|
|
|
*/
|
|
|
|
if (attrs->max_sge_rd > 1)
|
|
|
|
ia->ri_max_frwr_depth = attrs->max_sge_rd;
|
|
|
|
else
|
|
|
|
ia->ri_max_frwr_depth = attrs->max_fast_reg_page_list_len;
|
|
|
|
if (ia->ri_max_frwr_depth > RPCRDMA_MAX_DATA_SEGS)
|
|
|
|
ia->ri_max_frwr_depth = RPCRDMA_MAX_DATA_SEGS;
|
|
|
|
dprintk("RPC: %s: max FR page list depth = %u\n",
|
2017-12-15 09:57:47 +08:00
|
|
|
__func__, ia->ri_max_frwr_depth);
|
|
|
|
|
|
|
|
/* Add room for frwr register and invalidate WRs.
|
|
|
|
* 1. FRWR reg WR for head
|
|
|
|
* 2. FRWR invalidate WR for head
|
|
|
|
* 3. N FRWR reg WRs for pagelist
|
|
|
|
* 4. N FRWR invalidate WRs for pagelist
|
|
|
|
* 5. FRWR reg WR for tail
|
|
|
|
* 6. FRWR invalidate WR for tail
|
2015-03-31 02:35:26 +08:00
|
|
|
* 7. The RDMA_SEND WR
|
|
|
|
*/
|
|
|
|
depth = 7;
|
|
|
|
|
2017-12-15 09:57:47 +08:00
|
|
|
/* Calculate N if the device max FRWR depth is smaller than
|
2015-03-31 02:35:26 +08:00
|
|
|
* RPCRDMA_MAX_DATA_SEGS.
|
|
|
|
*/
|
2017-12-15 09:57:47 +08:00
|
|
|
if (ia->ri_max_frwr_depth < RPCRDMA_MAX_DATA_SEGS) {
|
|
|
|
delta = RPCRDMA_MAX_DATA_SEGS - ia->ri_max_frwr_depth;
|
2015-03-31 02:35:26 +08:00
|
|
|
do {
|
2017-12-15 09:57:47 +08:00
|
|
|
depth += 2; /* FRWR reg + invalidate */
|
|
|
|
delta -= ia->ri_max_frwr_depth;
|
2015-03-31 02:35:26 +08:00
|
|
|
} while (delta > 0);
|
|
|
|
}
|
|
|
|
|
2018-05-05 03:34:48 +08:00
|
|
|
max_qp_wr = ia->ri_device->attrs.max_qp_wr;
|
|
|
|
max_qp_wr -= RPCRDMA_BACKWARD_WRS;
|
|
|
|
max_qp_wr -= 1;
|
|
|
|
if (max_qp_wr < RPCRDMA_MIN_SLOT_TABLE)
|
|
|
|
return -ENOMEM;
|
|
|
|
if (cdata->max_requests > max_qp_wr)
|
|
|
|
cdata->max_requests = max_qp_wr;
|
|
|
|
ep->rep_attr.cap.max_send_wr = cdata->max_requests * depth;
|
|
|
|
if (ep->rep_attr.cap.max_send_wr > max_qp_wr) {
|
|
|
|
cdata->max_requests = max_qp_wr / depth;
|
2015-03-31 02:35:26 +08:00
|
|
|
if (!cdata->max_requests)
|
|
|
|
return -EINVAL;
|
|
|
|
ep->rep_attr.cap.max_send_wr = cdata->max_requests *
|
|
|
|
depth;
|
|
|
|
}
|
2018-05-05 03:34:48 +08:00
|
|
|
ep->rep_attr.cap.max_send_wr += RPCRDMA_BACKWARD_WRS;
|
|
|
|
ep->rep_attr.cap.max_send_wr += 1; /* for ib_drain_sq */
|
|
|
|
ep->rep_attr.cap.max_recv_wr = cdata->max_requests;
|
|
|
|
ep->rep_attr.cap.max_recv_wr += RPCRDMA_BACKWARD_WRS;
|
|
|
|
ep->rep_attr.cap.max_recv_wr += 1; /* for ib_drain_rq */
|
2015-03-31 02:35:26 +08:00
|
|
|
|
2016-09-15 22:57:07 +08:00
|
|
|
ia->ri_max_segs = max_t(unsigned int, 1, RPCRDMA_MAX_DATA_SEGS /
|
2017-12-15 09:57:47 +08:00
|
|
|
ia->ri_max_frwr_depth);
|
2018-12-19 23:58:45 +08:00
|
|
|
/* Reply chunks require segments for head and tail buffers */
|
|
|
|
ia->ri_max_segs += 2;
|
|
|
|
if (ia->ri_max_segs > RPCRDMA_MAX_HDR_SEGS)
|
|
|
|
ia->ri_max_segs = RPCRDMA_MAX_HDR_SEGS;
|
2015-03-31 02:35:26 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-12-19 23:59:01 +08:00
|
|
|
/**
|
|
|
|
* frwr_maxpages - Compute size of largest payload
|
|
|
|
* @r_xprt: transport
|
|
|
|
*
|
|
|
|
* Returns maximum size of an RPC message, in pages.
|
|
|
|
*
|
|
|
|
* FRWR mode conveys a list of pages per chunk segment. The
|
2015-03-31 02:34:30 +08:00
|
|
|
* maximum length of that list is the FRWR page list depth.
|
|
|
|
*/
|
2018-12-19 23:59:01 +08:00
|
|
|
size_t frwr_maxpages(struct rpcrdma_xprt *r_xprt)
|
2015-03-31 02:34:30 +08:00
|
|
|
{
|
|
|
|
struct rpcrdma_ia *ia = &r_xprt->rx_ia;
|
|
|
|
|
|
|
|
return min_t(unsigned int, RPCRDMA_MAX_DATA_SEGS,
|
2018-12-19 23:58:45 +08:00
|
|
|
(ia->ri_max_segs - 2) * ia->ri_max_frwr_depth);
|
2015-03-31 02:34:30 +08:00
|
|
|
}
|
|
|
|
|
2016-03-05 00:28:53 +08:00
|
|
|
static void
|
2016-11-08 05:16:24 +08:00
|
|
|
__frwr_sendcompletion_flush(struct ib_wc *wc, const char *wr)
|
2016-03-05 00:28:53 +08:00
|
|
|
{
|
|
|
|
if (wc->status != IB_WC_WR_FLUSH_ERR)
|
|
|
|
pr_err("rpcrdma: %s: %s (%u/0x%x)\n",
|
|
|
|
wr, ib_wc_status_msg(wc->status),
|
|
|
|
wc->status, wc->vendor_err);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-06-08 23:53:24 +08:00
|
|
|
* frwr_wc_fastreg - Invoked by RDMA provider for a flushed FastReg WC
|
2016-03-05 00:28:53 +08:00
|
|
|
* @cq: completion queue (ignored)
|
|
|
|
* @wc: completed WR
|
2015-12-17 06:22:47 +08:00
|
|
|
*
|
|
|
|
*/
|
2015-03-31 02:35:35 +08:00
|
|
|
static void
|
2016-03-05 00:28:53 +08:00
|
|
|
frwr_wc_fastreg(struct ib_cq *cq, struct ib_wc *wc)
|
2015-03-31 02:35:35 +08:00
|
|
|
{
|
2017-12-21 05:30:56 +08:00
|
|
|
struct ib_cqe *cqe = wc->wr_cqe;
|
|
|
|
struct rpcrdma_frwr *frwr =
|
|
|
|
container_of(cqe, struct rpcrdma_frwr, fr_cqe);
|
2015-12-17 06:22:47 +08:00
|
|
|
|
2016-03-05 00:28:53 +08:00
|
|
|
/* WARNING: Only wr_cqe and status are reliable at this point */
|
|
|
|
if (wc->status != IB_WC_SUCCESS) {
|
2017-12-15 09:57:47 +08:00
|
|
|
frwr->fr_state = FRWR_FLUSHED_FR;
|
2016-11-08 05:16:24 +08:00
|
|
|
__frwr_sendcompletion_flush(wc, "fastreg");
|
2016-03-05 00:28:53 +08:00
|
|
|
}
|
2017-12-21 05:30:56 +08:00
|
|
|
trace_xprtrdma_wc_fastreg(wc, frwr);
|
2015-03-31 02:35:35 +08:00
|
|
|
}
|
|
|
|
|
2016-03-05 00:28:53 +08:00
|
|
|
/**
|
2017-06-08 23:53:24 +08:00
|
|
|
* frwr_wc_localinv - Invoked by RDMA provider for a flushed LocalInv WC
|
2016-03-05 00:28:53 +08:00
|
|
|
* @cq: completion queue (ignored)
|
|
|
|
* @wc: completed WR
|
|
|
|
*
|
|
|
|
*/
|
2015-12-17 06:22:47 +08:00
|
|
|
static void
|
2016-03-05 00:28:53 +08:00
|
|
|
frwr_wc_localinv(struct ib_cq *cq, struct ib_wc *wc)
|
2015-12-17 06:22:47 +08:00
|
|
|
{
|
2017-12-21 05:31:12 +08:00
|
|
|
struct ib_cqe *cqe = wc->wr_cqe;
|
|
|
|
struct rpcrdma_frwr *frwr = container_of(cqe, struct rpcrdma_frwr,
|
|
|
|
fr_cqe);
|
2015-12-17 06:22:47 +08:00
|
|
|
|
2016-03-05 00:28:53 +08:00
|
|
|
/* WARNING: Only wr_cqe and status are reliable at this point */
|
|
|
|
if (wc->status != IB_WC_SUCCESS) {
|
2017-12-15 09:57:47 +08:00
|
|
|
frwr->fr_state = FRWR_FLUSHED_LI;
|
2016-11-08 05:16:24 +08:00
|
|
|
__frwr_sendcompletion_flush(wc, "localinv");
|
2016-03-05 00:28:53 +08:00
|
|
|
}
|
2017-12-21 05:31:12 +08:00
|
|
|
trace_xprtrdma_wc_li(wc, frwr);
|
2016-03-05 00:28:53 +08:00
|
|
|
}
|
2015-12-17 06:22:47 +08:00
|
|
|
|
2016-03-05 00:28:53 +08:00
|
|
|
/**
|
2017-06-08 23:53:24 +08:00
|
|
|
* frwr_wc_localinv_wake - Invoked by RDMA provider for a signaled LocalInv WC
|
2016-03-05 00:28:53 +08:00
|
|
|
* @cq: completion queue (ignored)
|
|
|
|
* @wc: completed WR
|
|
|
|
*
|
|
|
|
* Awaken anyone waiting for an MR to finish being fenced.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
frwr_wc_localinv_wake(struct ib_cq *cq, struct ib_wc *wc)
|
|
|
|
{
|
2017-12-21 05:31:12 +08:00
|
|
|
struct ib_cqe *cqe = wc->wr_cqe;
|
|
|
|
struct rpcrdma_frwr *frwr = container_of(cqe, struct rpcrdma_frwr,
|
|
|
|
fr_cqe);
|
2016-03-05 00:28:53 +08:00
|
|
|
|
|
|
|
/* WARNING: Only wr_cqe and status are reliable at this point */
|
2016-11-08 05:16:24 +08:00
|
|
|
if (wc->status != IB_WC_SUCCESS) {
|
2017-12-15 09:57:47 +08:00
|
|
|
frwr->fr_state = FRWR_FLUSHED_LI;
|
2016-11-08 05:16:24 +08:00
|
|
|
__frwr_sendcompletion_flush(wc, "localinv");
|
|
|
|
}
|
2017-12-15 09:57:47 +08:00
|
|
|
complete(&frwr->fr_linv_done);
|
2017-12-21 05:31:12 +08:00
|
|
|
trace_xprtrdma_wc_li_wake(wc, frwr);
|
2015-12-17 06:22:47 +08:00
|
|
|
}
|
|
|
|
|
2018-12-19 23:59:01 +08:00
|
|
|
/**
|
|
|
|
* frwr_map - Register a memory region
|
|
|
|
* @r_xprt: controlling transport
|
|
|
|
* @seg: memory region co-ordinates
|
|
|
|
* @nsegs: number of segments remaining
|
|
|
|
* @writing: true when RDMA Write will be used
|
2018-12-19 23:59:07 +08:00
|
|
|
* @xid: XID of RPC using the registered memory
|
2018-12-19 23:59:01 +08:00
|
|
|
* @out: initialized MR
|
|
|
|
*
|
|
|
|
* Prepare a REG_MR Work Request to register a memory region
|
2015-03-31 02:34:39 +08:00
|
|
|
* for remote access via RDMA READ or RDMA WRITE.
|
2018-12-19 23:59:01 +08:00
|
|
|
*
|
|
|
|
* Returns the next segment or a negative errno pointer.
|
|
|
|
* On success, the prepared MR is planted in @out.
|
2015-03-31 02:34:39 +08:00
|
|
|
*/
|
2018-12-19 23:59:01 +08:00
|
|
|
struct rpcrdma_mr_seg *frwr_map(struct rpcrdma_xprt *r_xprt,
|
|
|
|
struct rpcrdma_mr_seg *seg,
|
2019-02-12 00:23:44 +08:00
|
|
|
int nsegs, bool writing, __be32 xid,
|
2018-12-19 23:59:01 +08:00
|
|
|
struct rpcrdma_mr **out)
|
2015-03-31 02:34:39 +08:00
|
|
|
{
|
|
|
|
struct rpcrdma_ia *ia = &r_xprt->rx_ia;
|
xprtrdma: Support for SG_GAP devices
Some devices (such as the Mellanox CX-4) can register, under a
single R_key, a set of memory regions that are not contiguous. When
this is done, all the segments in a Reply list, say, can then be
invalidated in a single LocalInv Work Request (or via Remote
Invalidation, which can invalidate exactly one R_key when completing
a Receive).
This means a single FastReg WR is used to register, and one or zero
LocalInv WRs can invalidate, the memory involved with RDMA transfers
on behalf of an RPC.
In addition, xprtrdma constructs some Reply chunks from three or
more segments. By registering them with SG_GAP, only one segment
is needed for the Reply chunk, allowing the whole chunk to be
invalidated remotely.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
2016-11-29 23:52:24 +08:00
|
|
|
bool holes_ok = ia->ri_mrtype == IB_MR_TYPE_SG_GAPS;
|
2017-12-15 09:57:47 +08:00
|
|
|
struct rpcrdma_frwr *frwr;
|
2017-12-15 09:57:55 +08:00
|
|
|
struct rpcrdma_mr *mr;
|
|
|
|
struct ib_mr *ibmr;
|
2015-12-17 06:22:31 +08:00
|
|
|
struct ib_reg_wr *reg_wr;
|
2018-03-01 04:30:59 +08:00
|
|
|
int i, n;
|
2015-03-31 02:34:39 +08:00
|
|
|
u8 key;
|
|
|
|
|
2017-12-15 09:57:55 +08:00
|
|
|
mr = NULL;
|
2015-05-26 23:52:35 +08:00
|
|
|
do {
|
2017-12-15 09:57:55 +08:00
|
|
|
if (mr)
|
2018-10-02 02:25:25 +08:00
|
|
|
rpcrdma_mr_recycle(mr);
|
2017-12-15 09:57:55 +08:00
|
|
|
mr = rpcrdma_mr_get(r_xprt);
|
|
|
|
if (!mr)
|
2018-03-01 04:30:44 +08:00
|
|
|
return ERR_PTR(-EAGAIN);
|
2017-12-15 09:57:55 +08:00
|
|
|
} while (mr->frwr.fr_state != FRWR_IS_INVALID);
|
|
|
|
frwr = &mr->frwr;
|
2017-12-15 09:57:47 +08:00
|
|
|
frwr->fr_state = FRWR_IS_VALID;
|
|
|
|
|
|
|
|
if (nsegs > ia->ri_max_frwr_depth)
|
|
|
|
nsegs = ia->ri_max_frwr_depth;
|
2015-10-14 00:11:35 +08:00
|
|
|
for (i = 0; i < nsegs;) {
|
|
|
|
if (seg->mr_page)
|
2017-12-15 09:57:55 +08:00
|
|
|
sg_set_page(&mr->mr_sg[i],
|
2015-10-14 00:11:35 +08:00
|
|
|
seg->mr_page,
|
|
|
|
seg->mr_len,
|
|
|
|
offset_in_page(seg->mr_offset));
|
|
|
|
else
|
2017-12-15 09:57:55 +08:00
|
|
|
sg_set_buf(&mr->mr_sg[i], seg->mr_offset,
|
2015-10-14 00:11:35 +08:00
|
|
|
seg->mr_len);
|
|
|
|
|
2015-03-31 02:34:39 +08:00
|
|
|
++seg;
|
|
|
|
++i;
|
xprtrdma: Support for SG_GAP devices
Some devices (such as the Mellanox CX-4) can register, under a
single R_key, a set of memory regions that are not contiguous. When
this is done, all the segments in a Reply list, say, can then be
invalidated in a single LocalInv Work Request (or via Remote
Invalidation, which can invalidate exactly one R_key when completing
a Receive).
This means a single FastReg WR is used to register, and one or zero
LocalInv WRs can invalidate, the memory involved with RDMA transfers
on behalf of an RPC.
In addition, xprtrdma constructs some Reply chunks from three or
more segments. By registering them with SG_GAP, only one segment
is needed for the Reply chunk, allowing the whole chunk to be
invalidated remotely.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
2016-11-29 23:52:24 +08:00
|
|
|
if (holes_ok)
|
|
|
|
continue;
|
2015-03-31 02:34:39 +08:00
|
|
|
if ((i < nsegs && offset_in_page(seg->mr_offset)) ||
|
|
|
|
offset_in_page((seg-1)->mr_offset + (seg-1)->mr_len))
|
|
|
|
break;
|
|
|
|
}
|
2017-12-15 09:57:55 +08:00
|
|
|
mr->mr_dir = rpcrdma_data_dir(writing);
|
2015-10-14 00:11:35 +08:00
|
|
|
|
2017-12-15 09:57:55 +08:00
|
|
|
mr->mr_nents = ib_dma_map_sg(ia->ri_device, mr->mr_sg, i, mr->mr_dir);
|
|
|
|
if (!mr->mr_nents)
|
2016-06-30 01:52:21 +08:00
|
|
|
goto out_dmamap_err;
|
|
|
|
|
2017-12-15 09:57:55 +08:00
|
|
|
ibmr = frwr->fr_mr;
|
|
|
|
n = ib_map_mr_sg(ibmr, mr->mr_sg, mr->mr_nents, NULL, PAGE_SIZE);
|
|
|
|
if (unlikely(n != mr->mr_nents))
|
2016-06-30 01:52:21 +08:00
|
|
|
goto out_mapmr_err;
|
2015-10-14 00:11:35 +08:00
|
|
|
|
2018-12-19 23:59:07 +08:00
|
|
|
ibmr->iova &= 0x00000000ffffffff;
|
2019-02-12 00:23:44 +08:00
|
|
|
ibmr->iova |= ((u64)be32_to_cpu(xid)) << 32;
|
2017-12-15 09:57:55 +08:00
|
|
|
key = (u8)(ibmr->rkey & 0x000000FF);
|
|
|
|
ib_update_fast_reg_key(ibmr, ++key);
|
2015-10-14 00:11:35 +08:00
|
|
|
|
2017-12-15 09:57:47 +08:00
|
|
|
reg_wr = &frwr->fr_regwr;
|
2017-12-15 09:57:55 +08:00
|
|
|
reg_wr->mr = ibmr;
|
|
|
|
reg_wr->key = ibmr->rkey;
|
2015-12-17 06:22:31 +08:00
|
|
|
reg_wr->access = writing ?
|
|
|
|
IB_ACCESS_REMOTE_WRITE | IB_ACCESS_LOCAL_WRITE :
|
|
|
|
IB_ACCESS_REMOTE_READ;
|
2015-03-31 02:34:39 +08:00
|
|
|
|
2017-12-15 09:57:55 +08:00
|
|
|
mr->mr_handle = ibmr->rkey;
|
|
|
|
mr->mr_length = ibmr->length;
|
|
|
|
mr->mr_offset = ibmr->iova;
|
2018-12-19 23:59:55 +08:00
|
|
|
trace_xprtrdma_mr_map(mr);
|
2015-10-14 00:11:35 +08:00
|
|
|
|
2017-12-15 09:57:55 +08:00
|
|
|
*out = mr;
|
2017-08-15 03:38:30 +08:00
|
|
|
return seg;
|
2016-06-30 01:52:21 +08:00
|
|
|
|
|
|
|
out_dmamap_err:
|
2017-12-15 09:57:47 +08:00
|
|
|
frwr->fr_state = FRWR_IS_INVALID;
|
2018-12-20 00:00:06 +08:00
|
|
|
trace_xprtrdma_frwr_sgerr(mr, i);
|
2017-12-15 09:57:55 +08:00
|
|
|
rpcrdma_mr_put(mr);
|
2017-08-15 03:38:30 +08:00
|
|
|
return ERR_PTR(-EIO);
|
2016-06-30 01:52:21 +08:00
|
|
|
|
|
|
|
out_mapmr_err:
|
2018-12-20 00:00:06 +08:00
|
|
|
trace_xprtrdma_frwr_maperr(mr, n);
|
2018-10-02 02:25:25 +08:00
|
|
|
rpcrdma_mr_recycle(mr);
|
2017-08-15 03:38:30 +08:00
|
|
|
return ERR_PTR(-EIO);
|
2018-03-01 04:30:59 +08:00
|
|
|
}
|
2015-03-31 02:34:39 +08:00
|
|
|
|
2018-12-19 23:59:01 +08:00
|
|
|
/**
|
|
|
|
* frwr_send - post Send WR containing the RPC Call message
|
|
|
|
* @ia: interface adapter
|
|
|
|
* @req: Prepared RPC Call
|
2018-03-01 04:30:59 +08:00
|
|
|
*
|
2018-12-20 00:00:27 +08:00
|
|
|
* For FRWR, chain any FastReg WRs to the Send WR. Only a
|
2018-03-01 04:30:59 +08:00
|
|
|
* single ib_post_send call is needed to register memory
|
|
|
|
* and then post the Send WR.
|
2018-12-19 23:59:01 +08:00
|
|
|
*
|
|
|
|
* Returns the result of ib_post_send.
|
2018-03-01 04:30:59 +08:00
|
|
|
*/
|
2018-12-19 23:59:01 +08:00
|
|
|
int frwr_send(struct rpcrdma_ia *ia, struct rpcrdma_req *req)
|
2018-03-01 04:30:59 +08:00
|
|
|
{
|
2018-07-19 00:25:31 +08:00
|
|
|
struct ib_send_wr *post_wr;
|
2018-03-01 04:30:59 +08:00
|
|
|
struct rpcrdma_mr *mr;
|
|
|
|
|
|
|
|
post_wr = &req->rl_sendctx->sc_wr;
|
|
|
|
list_for_each_entry(mr, &req->rl_registered, mr_list) {
|
|
|
|
struct rpcrdma_frwr *frwr;
|
|
|
|
|
|
|
|
frwr = &mr->frwr;
|
|
|
|
|
|
|
|
frwr->fr_cqe.done = frwr_wc_fastreg;
|
|
|
|
frwr->fr_regwr.wr.next = post_wr;
|
|
|
|
frwr->fr_regwr.wr.wr_cqe = &frwr->fr_cqe;
|
|
|
|
frwr->fr_regwr.wr.num_sge = 0;
|
|
|
|
frwr->fr_regwr.wr.opcode = IB_WR_REG_MR;
|
|
|
|
frwr->fr_regwr.wr.send_flags = 0;
|
|
|
|
|
|
|
|
post_wr = &frwr->fr_regwr.wr;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* If ib_post_send fails, the next ->send_request for
|
2018-12-20 00:00:27 +08:00
|
|
|
* @req will queue these MRs for recovery.
|
2018-03-01 04:30:59 +08:00
|
|
|
*/
|
2018-07-19 00:25:31 +08:00
|
|
|
return ib_post_send(ia->ri_id->qp, post_wr, NULL);
|
2015-03-31 02:34:39 +08:00
|
|
|
}
|
|
|
|
|
2018-12-19 23:59:01 +08:00
|
|
|
/**
|
|
|
|
* frwr_reminv - handle a remotely invalidated mr on the @mrs list
|
|
|
|
* @rep: Received reply
|
|
|
|
* @mrs: list of MRs to check
|
|
|
|
*
|
2017-12-15 09:56:26 +08:00
|
|
|
*/
|
2018-12-19 23:59:01 +08:00
|
|
|
void frwr_reminv(struct rpcrdma_rep *rep, struct list_head *mrs)
|
2017-12-15 09:56:26 +08:00
|
|
|
{
|
2017-12-15 09:57:55 +08:00
|
|
|
struct rpcrdma_mr *mr;
|
2017-12-15 09:56:26 +08:00
|
|
|
|
2017-12-15 09:57:55 +08:00
|
|
|
list_for_each_entry(mr, mrs, mr_list)
|
|
|
|
if (mr->mr_handle == rep->rr_inv_rkey) {
|
xprtrdma: Fix list corruption / DMAR errors during MR recovery
The ro_release_mr methods check whether mr->mr_list is empty.
Therefore, be sure to always use list_del_init when removing an MR
linked into a list using that field. Otherwise, when recovering from
transport failures or device removal, list corruption can result, or
MRs can get mapped or unmapped an odd number of times, resulting in
IOMMU-related failures.
In general this fix is appropriate back to v4.8. However, code
changes since then make it impossible to apply this patch directly
to stable kernels. The fix would have to be applied by hand or
reworked for kernels earlier than v4.16.
Backport guidance -- there are several cases:
- When creating an MR, initialize mr_list so that using list_empty
on an as-yet-unused MR is safe.
- When an MR is being handled by the remote invalidation path,
ensure that mr_list is reinitialized when it is removed from
rl_registered.
- When an MR is being handled by rpcrdma_destroy_mrs, it is removed
from mr_all, but it may still be on an rl_registered list. In
that case, the MR needs to be removed from that list before being
released.
- Other cases are covered by using list_del_init in rpcrdma_mr_pop.
Fixes: 9d6b04097882 ('xprtrdma: Place registered MWs on a ... ')
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
2018-05-01 23:37:14 +08:00
|
|
|
list_del_init(&mr->mr_list);
|
2018-10-02 02:25:30 +08:00
|
|
|
trace_xprtrdma_mr_remoteinv(mr);
|
2017-12-15 09:57:55 +08:00
|
|
|
mr->frwr.fr_state = FRWR_IS_INVALID;
|
2017-12-15 09:58:04 +08:00
|
|
|
rpcrdma_mr_unmap_and_put(mr);
|
2017-12-15 09:56:26 +08:00
|
|
|
break; /* only one invalidated MR per RPC */
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-12-19 23:59:01 +08:00
|
|
|
/**
|
|
|
|
* frwr_unmap_sync - invalidate memory regions that were registered for @req
|
|
|
|
* @r_xprt: controlling transport
|
|
|
|
* @mrs: list of MRs to process
|
2015-12-17 06:22:47 +08:00
|
|
|
*
|
|
|
|
* Sleeps until it is safe for the host CPU to access the
|
|
|
|
* previously mapped memory regions.
|
2016-06-30 01:54:16 +08:00
|
|
|
*
|
2017-12-15 09:57:55 +08:00
|
|
|
* Caller ensures that @mrs is not empty before the call. This
|
2017-06-08 23:52:04 +08:00
|
|
|
* function empties the list.
|
2015-12-17 06:22:47 +08:00
|
|
|
*/
|
2018-12-19 23:59:01 +08:00
|
|
|
void frwr_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mrs)
|
2015-12-17 06:22:47 +08:00
|
|
|
{
|
2018-07-19 00:25:32 +08:00
|
|
|
struct ib_send_wr *first, **prev, *last;
|
|
|
|
const struct ib_send_wr *bad_wr;
|
2015-12-17 06:22:47 +08:00
|
|
|
struct rpcrdma_ia *ia = &r_xprt->rx_ia;
|
2017-12-15 09:57:47 +08:00
|
|
|
struct rpcrdma_frwr *frwr;
|
2017-12-15 09:57:55 +08:00
|
|
|
struct rpcrdma_mr *mr;
|
2016-11-29 23:52:16 +08:00
|
|
|
int count, rc;
|
2015-12-17 06:22:47 +08:00
|
|
|
|
2017-06-08 23:52:04 +08:00
|
|
|
/* ORDER: Invalidate all of the MRs first
|
2015-12-17 06:22:47 +08:00
|
|
|
*
|
|
|
|
* Chain the LOCAL_INV Work Requests and post them with
|
|
|
|
* a single ib_post_send() call.
|
|
|
|
*/
|
2017-12-15 09:57:47 +08:00
|
|
|
frwr = NULL;
|
2016-11-29 23:52:16 +08:00
|
|
|
count = 0;
|
2016-11-29 23:52:57 +08:00
|
|
|
prev = &first;
|
2017-12-15 09:57:55 +08:00
|
|
|
list_for_each_entry(mr, mrs, mr_list) {
|
|
|
|
mr->frwr.fr_state = FRWR_IS_INVALID;
|
|
|
|
|
|
|
|
frwr = &mr->frwr;
|
2018-10-02 02:25:30 +08:00
|
|
|
trace_xprtrdma_mr_localinv(mr);
|
2016-11-29 23:52:57 +08:00
|
|
|
|
2017-12-15 09:57:47 +08:00
|
|
|
frwr->fr_cqe.done = frwr_wc_localinv;
|
|
|
|
last = &frwr->fr_invwr;
|
2016-11-29 23:52:57 +08:00
|
|
|
memset(last, 0, sizeof(*last));
|
2017-12-15 09:57:47 +08:00
|
|
|
last->wr_cqe = &frwr->fr_cqe;
|
2016-11-29 23:52:57 +08:00
|
|
|
last->opcode = IB_WR_LOCAL_INV;
|
2017-12-15 09:57:55 +08:00
|
|
|
last->ex.invalidate_rkey = mr->mr_handle;
|
2016-11-29 23:52:16 +08:00
|
|
|
count++;
|
2015-12-17 06:22:47 +08:00
|
|
|
|
2016-11-29 23:52:57 +08:00
|
|
|
*prev = last;
|
|
|
|
prev = &last->next;
|
2015-12-17 06:22:47 +08:00
|
|
|
}
|
2017-12-15 09:57:47 +08:00
|
|
|
if (!frwr)
|
2016-09-15 22:57:16 +08:00
|
|
|
goto unmap;
|
2015-12-17 06:22:47 +08:00
|
|
|
|
|
|
|
/* Strong send queue ordering guarantees that when the
|
|
|
|
* last WR in the chain completes, all WRs in the chain
|
|
|
|
* are complete.
|
|
|
|
*/
|
2016-11-29 23:52:57 +08:00
|
|
|
last->send_flags = IB_SEND_SIGNALED;
|
2017-12-15 09:57:47 +08:00
|
|
|
frwr->fr_cqe.done = frwr_wc_localinv_wake;
|
|
|
|
reinit_completion(&frwr->fr_linv_done);
|
2016-11-29 23:52:16 +08:00
|
|
|
|
2015-12-17 06:22:47 +08:00
|
|
|
/* Transport disconnect drains the receive CQ before it
|
|
|
|
* replaces the QP. The RPC reply handler won't call us
|
|
|
|
* unless ri_id->qp is a valid pointer.
|
|
|
|
*/
|
2016-09-15 22:57:16 +08:00
|
|
|
r_xprt->rx_stats.local_inv_needed++;
|
2017-06-08 23:52:28 +08:00
|
|
|
bad_wr = NULL;
|
2016-11-29 23:52:57 +08:00
|
|
|
rc = ib_post_send(ia->ri_id->qp, first, &bad_wr);
|
2017-06-08 23:52:28 +08:00
|
|
|
if (bad_wr != first)
|
2017-12-15 09:57:47 +08:00
|
|
|
wait_for_completion(&frwr->fr_linv_done);
|
2016-05-03 02:42:12 +08:00
|
|
|
if (rc)
|
2018-10-02 02:25:25 +08:00
|
|
|
goto out_release;
|
2015-12-17 06:22:47 +08:00
|
|
|
|
2017-06-08 23:52:04 +08:00
|
|
|
/* ORDER: Now DMA unmap all of the MRs, and return
|
2017-12-15 09:57:55 +08:00
|
|
|
* them to the free MR list.
|
2015-12-17 06:22:47 +08:00
|
|
|
*/
|
2016-03-05 00:28:01 +08:00
|
|
|
unmap:
|
2017-12-15 09:57:55 +08:00
|
|
|
while (!list_empty(mrs)) {
|
|
|
|
mr = rpcrdma_mr_pop(mrs);
|
2017-12-15 09:58:04 +08:00
|
|
|
rpcrdma_mr_unmap_and_put(mr);
|
2015-12-17 06:22:47 +08:00
|
|
|
}
|
2016-05-03 02:42:12 +08:00
|
|
|
return;
|
2015-12-17 06:22:47 +08:00
|
|
|
|
2018-10-02 02:25:25 +08:00
|
|
|
out_release:
|
2017-12-15 09:57:47 +08:00
|
|
|
pr_err("rpcrdma: FRWR invalidate ib_post_send returned %i\n", rc);
|
2015-03-31 02:34:48 +08:00
|
|
|
|
2018-10-02 02:25:25 +08:00
|
|
|
/* Unmap and release the MRs in the LOCAL_INV WRs that did not
|
2017-06-08 23:52:28 +08:00
|
|
|
* get posted.
|
2016-05-03 02:42:12 +08:00
|
|
|
*/
|
2017-06-08 23:52:28 +08:00
|
|
|
while (bad_wr) {
|
2017-12-15 09:57:47 +08:00
|
|
|
frwr = container_of(bad_wr, struct rpcrdma_frwr,
|
|
|
|
fr_invwr);
|
2017-12-15 09:57:55 +08:00
|
|
|
mr = container_of(frwr, struct rpcrdma_mr, frwr);
|
2017-06-08 23:52:28 +08:00
|
|
|
bad_wr = bad_wr->next;
|
2018-10-02 02:25:25 +08:00
|
|
|
|
2018-12-19 23:58:19 +08:00
|
|
|
list_del_init(&mr->mr_list);
|
|
|
|
rpcrdma_mr_recycle(mr);
|
2016-05-03 02:42:12 +08:00
|
|
|
}
|
2015-12-17 06:22:47 +08:00
|
|
|
}
|