2019-06-04 16:11:33 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2016-11-17 04:46:13 +08:00
|
|
|
/*
|
|
|
|
* File attributes for Mediated devices
|
|
|
|
*
|
|
|
|
* Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
|
|
|
|
* Author: Neo Jia <cjia@nvidia.com>
|
|
|
|
* Kirti Wankhede <kwankhede@nvidia.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/sysfs.h>
|
|
|
|
#include <linux/ctype.h>
|
|
|
|
#include <linux/device.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/uuid.h>
|
|
|
|
#include <linux/mdev.h>
|
|
|
|
|
|
|
|
#include "mdev_private.h"
|
|
|
|
|
|
|
|
/* Static functions */
|
|
|
|
|
|
|
|
static ssize_t mdev_type_attr_show(struct kobject *kobj,
|
|
|
|
struct attribute *__attr, char *buf)
|
|
|
|
{
|
|
|
|
struct mdev_type_attribute *attr = to_mdev_type_attr(__attr);
|
|
|
|
struct mdev_type *type = to_mdev_type(kobj);
|
|
|
|
ssize_t ret = -EIO;
|
|
|
|
|
|
|
|
if (attr->show)
|
vfio/mdev: Correct the function signatures for the mdev_type_attributes
The driver core standard is to pass in the properly typed object, the
properly typed attribute and the buffer data. It stems from the root
kobject method:
ssize_t (*show)(struct kobject *kobj, struct kobj_attribute *attr,..)
Each subclass of kobject should provide their own function with the same
signature but more specific types, eg struct device uses:
ssize_t (*show)(struct device *dev, struct device_attribute *attr,..)
In this case the existing signature is:
ssize_t (*show)(struct kobject *kobj, struct device *dev,..)
Where kobj is a 'struct mdev_type *' and dev is 'mdev_type->parent->dev'.
Change the mdev_type related sysfs attribute functions to:
ssize_t (*show)(struct mdev_type *mtype, struct mdev_type_attribute *attr,..)
In order to restore type safety and match the driver core standard
There are no current users of 'attr', but if it is ever needed it would be
hard to add in retroactively, so do it now.
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Message-Id: <18-v2-d36939638fc6+d54-vfio2_jgg@nvidia.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
2021-04-07 03:40:41 +08:00
|
|
|
ret = attr->show(type, attr, buf);
|
2016-11-17 04:46:13 +08:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t mdev_type_attr_store(struct kobject *kobj,
|
|
|
|
struct attribute *__attr,
|
|
|
|
const char *buf, size_t count)
|
|
|
|
{
|
|
|
|
struct mdev_type_attribute *attr = to_mdev_type_attr(__attr);
|
|
|
|
struct mdev_type *type = to_mdev_type(kobj);
|
|
|
|
ssize_t ret = -EIO;
|
|
|
|
|
|
|
|
if (attr->store)
|
vfio/mdev: Correct the function signatures for the mdev_type_attributes
The driver core standard is to pass in the properly typed object, the
properly typed attribute and the buffer data. It stems from the root
kobject method:
ssize_t (*show)(struct kobject *kobj, struct kobj_attribute *attr,..)
Each subclass of kobject should provide their own function with the same
signature but more specific types, eg struct device uses:
ssize_t (*show)(struct device *dev, struct device_attribute *attr,..)
In this case the existing signature is:
ssize_t (*show)(struct kobject *kobj, struct device *dev,..)
Where kobj is a 'struct mdev_type *' and dev is 'mdev_type->parent->dev'.
Change the mdev_type related sysfs attribute functions to:
ssize_t (*show)(struct mdev_type *mtype, struct mdev_type_attribute *attr,..)
In order to restore type safety and match the driver core standard
There are no current users of 'attr', but if it is ever needed it would be
hard to add in retroactively, so do it now.
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Message-Id: <18-v2-d36939638fc6+d54-vfio2_jgg@nvidia.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
2021-04-07 03:40:41 +08:00
|
|
|
ret = attr->store(type, attr, buf, count);
|
2016-11-17 04:46:13 +08:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct sysfs_ops mdev_type_sysfs_ops = {
|
|
|
|
.show = mdev_type_attr_show,
|
|
|
|
.store = mdev_type_attr_store,
|
|
|
|
};
|
|
|
|
|
vfio/mdev: Correct the function signatures for the mdev_type_attributes
The driver core standard is to pass in the properly typed object, the
properly typed attribute and the buffer data. It stems from the root
kobject method:
ssize_t (*show)(struct kobject *kobj, struct kobj_attribute *attr,..)
Each subclass of kobject should provide their own function with the same
signature but more specific types, eg struct device uses:
ssize_t (*show)(struct device *dev, struct device_attribute *attr,..)
In this case the existing signature is:
ssize_t (*show)(struct kobject *kobj, struct device *dev,..)
Where kobj is a 'struct mdev_type *' and dev is 'mdev_type->parent->dev'.
Change the mdev_type related sysfs attribute functions to:
ssize_t (*show)(struct mdev_type *mtype, struct mdev_type_attribute *attr,..)
In order to restore type safety and match the driver core standard
There are no current users of 'attr', but if it is ever needed it would be
hard to add in retroactively, so do it now.
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Message-Id: <18-v2-d36939638fc6+d54-vfio2_jgg@nvidia.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
2021-04-07 03:40:41 +08:00
|
|
|
static ssize_t create_store(struct mdev_type *mtype,
|
|
|
|
struct mdev_type_attribute *attr, const char *buf,
|
|
|
|
size_t count)
|
2016-11-17 04:46:13 +08:00
|
|
|
{
|
|
|
|
char *str;
|
2019-01-11 03:00:27 +08:00
|
|
|
guid_t uuid;
|
2016-11-17 04:46:13 +08:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
if ((count < UUID_STRING_LEN) || (count > UUID_STRING_LEN + 1))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
str = kstrndup(buf, count, GFP_KERNEL);
|
|
|
|
if (!str)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2019-01-11 03:00:27 +08:00
|
|
|
ret = guid_parse(str, &uuid);
|
2016-11-17 04:46:13 +08:00
|
|
|
kfree(str);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
vfio/mdev: Correct the function signatures for the mdev_type_attributes
The driver core standard is to pass in the properly typed object, the
properly typed attribute and the buffer data. It stems from the root
kobject method:
ssize_t (*show)(struct kobject *kobj, struct kobj_attribute *attr,..)
Each subclass of kobject should provide their own function with the same
signature but more specific types, eg struct device uses:
ssize_t (*show)(struct device *dev, struct device_attribute *attr,..)
In this case the existing signature is:
ssize_t (*show)(struct kobject *kobj, struct device *dev,..)
Where kobj is a 'struct mdev_type *' and dev is 'mdev_type->parent->dev'.
Change the mdev_type related sysfs attribute functions to:
ssize_t (*show)(struct mdev_type *mtype, struct mdev_type_attribute *attr,..)
In order to restore type safety and match the driver core standard
There are no current users of 'attr', but if it is ever needed it would be
hard to add in retroactively, so do it now.
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Message-Id: <18-v2-d36939638fc6+d54-vfio2_jgg@nvidia.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
2021-04-07 03:40:41 +08:00
|
|
|
ret = mdev_device_create(mtype, &uuid);
|
2016-11-17 04:46:13 +08:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
2019-12-18 20:31:19 +08:00
|
|
|
static MDEV_TYPE_ATTR_WO(create);
|
2016-11-17 04:46:13 +08:00
|
|
|
|
|
|
|
static void mdev_type_release(struct kobject *kobj)
|
|
|
|
{
|
|
|
|
struct mdev_type *type = to_mdev_type(kobj);
|
|
|
|
|
|
|
|
pr_debug("Releasing group %s\n", kobj->name);
|
2021-04-07 03:40:30 +08:00
|
|
|
/* Pairs with the get in add_mdev_supported_type() */
|
|
|
|
mdev_put_parent(type->parent);
|
2016-11-17 04:46:13 +08:00
|
|
|
kfree(type);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct kobj_type mdev_type_ktype = {
|
|
|
|
.sysfs_ops = &mdev_type_sysfs_ops,
|
|
|
|
.release = mdev_type_release,
|
|
|
|
};
|
|
|
|
|
2018-11-13 16:45:43 +08:00
|
|
|
static struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent,
|
2021-04-07 03:40:34 +08:00
|
|
|
unsigned int type_group_id)
|
2016-11-17 04:46:13 +08:00
|
|
|
{
|
|
|
|
struct mdev_type *type;
|
2021-04-07 03:40:34 +08:00
|
|
|
struct attribute_group *group =
|
|
|
|
parent->ops->supported_type_groups[type_group_id];
|
2016-11-17 04:46:13 +08:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (!group->name) {
|
|
|
|
pr_err("%s: Type name empty!\n", __func__);
|
|
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
}
|
|
|
|
|
|
|
|
type = kzalloc(sizeof(*type), GFP_KERNEL);
|
|
|
|
if (!type)
|
|
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
|
|
|
|
type->kobj.kset = parent->mdev_types_kset;
|
2021-04-07 03:40:25 +08:00
|
|
|
type->parent = parent;
|
2021-04-07 03:40:30 +08:00
|
|
|
/* Pairs with the put in mdev_type_release() */
|
|
|
|
mdev_get_parent(parent);
|
2021-04-07 03:40:34 +08:00
|
|
|
type->type_group_id = type_group_id;
|
2016-11-17 04:46:13 +08:00
|
|
|
|
|
|
|
ret = kobject_init_and_add(&type->kobj, &mdev_type_ktype, NULL,
|
|
|
|
"%s-%s", dev_driver_string(parent->dev),
|
|
|
|
group->name);
|
|
|
|
if (ret) {
|
2020-05-28 10:01:09 +08:00
|
|
|
kobject_put(&type->kobj);
|
2016-11-17 04:46:13 +08:00
|
|
|
return ERR_PTR(ret);
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = sysfs_create_file(&type->kobj, &mdev_type_attr_create.attr);
|
|
|
|
if (ret)
|
|
|
|
goto attr_create_failed;
|
|
|
|
|
|
|
|
type->devices_kobj = kobject_create_and_add("devices", &type->kobj);
|
|
|
|
if (!type->devices_kobj) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto attr_devices_failed;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = sysfs_create_files(&type->kobj,
|
|
|
|
(const struct attribute **)group->attrs);
|
|
|
|
if (ret) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto attrs_failed;
|
|
|
|
}
|
|
|
|
return type;
|
|
|
|
|
|
|
|
attrs_failed:
|
|
|
|
kobject_put(type->devices_kobj);
|
|
|
|
attr_devices_failed:
|
|
|
|
sysfs_remove_file(&type->kobj, &mdev_type_attr_create.attr);
|
|
|
|
attr_create_failed:
|
|
|
|
kobject_del(&type->kobj);
|
|
|
|
kobject_put(&type->kobj);
|
|
|
|
return ERR_PTR(ret);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void remove_mdev_supported_type(struct mdev_type *type)
|
|
|
|
{
|
2021-04-07 03:40:34 +08:00
|
|
|
struct attribute_group *group =
|
|
|
|
type->parent->ops->supported_type_groups[type->type_group_id];
|
|
|
|
|
2016-11-17 04:46:13 +08:00
|
|
|
sysfs_remove_files(&type->kobj,
|
2021-04-07 03:40:34 +08:00
|
|
|
(const struct attribute **)group->attrs);
|
2016-11-17 04:46:13 +08:00
|
|
|
kobject_put(type->devices_kobj);
|
|
|
|
sysfs_remove_file(&type->kobj, &mdev_type_attr_create.attr);
|
|
|
|
kobject_del(&type->kobj);
|
|
|
|
kobject_put(&type->kobj);
|
|
|
|
}
|
|
|
|
|
2016-12-30 23:13:38 +08:00
|
|
|
static int add_mdev_supported_type_groups(struct mdev_parent *parent)
|
2016-11-17 04:46:13 +08:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; parent->ops->supported_type_groups[i]; i++) {
|
|
|
|
struct mdev_type *type;
|
|
|
|
|
2021-04-07 03:40:34 +08:00
|
|
|
type = add_mdev_supported_type(parent, i);
|
2016-11-17 04:46:13 +08:00
|
|
|
if (IS_ERR(type)) {
|
|
|
|
struct mdev_type *ltype, *tmp;
|
|
|
|
|
|
|
|
list_for_each_entry_safe(ltype, tmp, &parent->type_list,
|
|
|
|
next) {
|
|
|
|
list_del(<ype->next);
|
|
|
|
remove_mdev_supported_type(ltype);
|
|
|
|
}
|
|
|
|
return PTR_ERR(type);
|
|
|
|
}
|
|
|
|
list_add(&type->next, &parent->type_list);
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* mdev sysfs functions */
|
2016-12-30 23:13:38 +08:00
|
|
|
void parent_remove_sysfs_files(struct mdev_parent *parent)
|
2016-11-17 04:46:13 +08:00
|
|
|
{
|
|
|
|
struct mdev_type *type, *tmp;
|
|
|
|
|
|
|
|
list_for_each_entry_safe(type, tmp, &parent->type_list, next) {
|
|
|
|
list_del(&type->next);
|
|
|
|
remove_mdev_supported_type(type);
|
|
|
|
}
|
|
|
|
|
|
|
|
sysfs_remove_groups(&parent->dev->kobj, parent->ops->dev_attr_groups);
|
|
|
|
kset_unregister(parent->mdev_types_kset);
|
|
|
|
}
|
|
|
|
|
2016-12-30 23:13:38 +08:00
|
|
|
int parent_create_sysfs_files(struct mdev_parent *parent)
|
2016-11-17 04:46:13 +08:00
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
parent->mdev_types_kset = kset_create_and_add("mdev_supported_types",
|
|
|
|
NULL, &parent->dev->kobj);
|
|
|
|
|
|
|
|
if (!parent->mdev_types_kset)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
INIT_LIST_HEAD(&parent->type_list);
|
|
|
|
|
|
|
|
ret = sysfs_create_groups(&parent->dev->kobj,
|
|
|
|
parent->ops->dev_attr_groups);
|
|
|
|
if (ret)
|
|
|
|
goto create_err;
|
|
|
|
|
|
|
|
ret = add_mdev_supported_type_groups(parent);
|
|
|
|
if (ret)
|
|
|
|
sysfs_remove_groups(&parent->dev->kobj,
|
|
|
|
parent->ops->dev_attr_groups);
|
|
|
|
else
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
create_err:
|
|
|
|
kset_unregister(parent->mdev_types_kset);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t remove_store(struct device *dev, struct device_attribute *attr,
|
|
|
|
const char *buf, size_t count)
|
|
|
|
{
|
2021-04-07 03:40:26 +08:00
|
|
|
struct mdev_device *mdev = to_mdev_device(dev);
|
2016-11-17 04:46:13 +08:00
|
|
|
unsigned long val;
|
|
|
|
|
|
|
|
if (kstrtoul(buf, 0, &val) < 0)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (val && device_remove_file_self(dev, attr)) {
|
|
|
|
int ret;
|
|
|
|
|
2021-04-07 03:40:26 +08:00
|
|
|
ret = mdev_device_remove(mdev);
|
2019-06-07 00:52:33 +08:00
|
|
|
if (ret)
|
2016-11-17 04:46:13 +08:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
|
|
|
static DEVICE_ATTR_WO(remove);
|
|
|
|
|
|
|
|
static const struct attribute *mdev_device_attrs[] = {
|
|
|
|
&dev_attr_remove.attr,
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
|
2021-04-07 03:40:28 +08:00
|
|
|
int mdev_create_sysfs_files(struct mdev_device *mdev)
|
2016-11-17 04:46:13 +08:00
|
|
|
{
|
2021-04-07 03:40:28 +08:00
|
|
|
struct mdev_type *type = mdev->type;
|
2021-04-07 03:40:26 +08:00
|
|
|
struct kobject *kobj = &mdev->dev.kobj;
|
2016-11-17 04:46:13 +08:00
|
|
|
int ret;
|
|
|
|
|
2021-04-07 03:40:26 +08:00
|
|
|
ret = sysfs_create_link(type->devices_kobj, kobj, dev_name(&mdev->dev));
|
2016-11-17 04:46:13 +08:00
|
|
|
if (ret)
|
2018-05-19 01:40:33 +08:00
|
|
|
return ret;
|
2016-11-17 04:46:13 +08:00
|
|
|
|
2021-04-07 03:40:26 +08:00
|
|
|
ret = sysfs_create_link(kobj, &type->kobj, "mdev_type");
|
2016-11-17 04:46:13 +08:00
|
|
|
if (ret)
|
|
|
|
goto type_link_failed;
|
|
|
|
|
2021-04-07 03:40:26 +08:00
|
|
|
ret = sysfs_create_files(kobj, mdev_device_attrs);
|
2018-05-19 01:40:33 +08:00
|
|
|
if (ret)
|
|
|
|
goto create_files_failed;
|
|
|
|
|
2016-11-17 04:46:13 +08:00
|
|
|
return ret;
|
|
|
|
|
2018-05-19 01:40:33 +08:00
|
|
|
create_files_failed:
|
2021-04-07 03:40:26 +08:00
|
|
|
sysfs_remove_link(kobj, "mdev_type");
|
2016-11-17 04:46:13 +08:00
|
|
|
type_link_failed:
|
2021-04-07 03:40:28 +08:00
|
|
|
sysfs_remove_link(mdev->type->devices_kobj, dev_name(&mdev->dev));
|
2016-11-17 04:46:13 +08:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2021-04-07 03:40:28 +08:00
|
|
|
void mdev_remove_sysfs_files(struct mdev_device *mdev)
|
2016-11-17 04:46:13 +08:00
|
|
|
{
|
2021-04-07 03:40:26 +08:00
|
|
|
struct kobject *kobj = &mdev->dev.kobj;
|
|
|
|
|
|
|
|
sysfs_remove_files(kobj, mdev_device_attrs);
|
|
|
|
sysfs_remove_link(kobj, "mdev_type");
|
2021-04-07 03:40:28 +08:00
|
|
|
sysfs_remove_link(mdev->type->devices_kobj, dev_name(&mdev->dev));
|
2016-11-17 04:46:13 +08:00
|
|
|
}
|