2019-05-27 14:55:01 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* net/sched/ematch.c Extended Match API
|
|
|
|
*
|
|
|
|
* Authors: Thomas Graf <tgraf@suug.ch>
|
|
|
|
*
|
|
|
|
* ==========================================================================
|
|
|
|
*
|
|
|
|
* An extended match (ematch) is a small classification tool not worth
|
|
|
|
* writing a full classifier for. Ematches can be interconnected to form
|
|
|
|
* a logic expression and get attached to classifiers to extend their
|
|
|
|
* functionatlity.
|
|
|
|
*
|
|
|
|
* The userspace part transforms the logic expressions into an array
|
|
|
|
* consisting of multiple sequences of interconnected ematches separated
|
|
|
|
* by markers. Precedence is implemented by a special ematch kind
|
|
|
|
* referencing a sequence beyond the marker of the current sequence
|
|
|
|
* causing the current position in the sequence to be pushed onto a stack
|
|
|
|
* to allow the current position to be overwritten by the position referenced
|
|
|
|
* in the special ematch. Matching continues in the new sequence until a
|
|
|
|
* marker is reached causing the position to be restored from the stack.
|
|
|
|
*
|
|
|
|
* Example:
|
|
|
|
* A AND (B1 OR B2) AND C AND D
|
|
|
|
*
|
|
|
|
* ------->-PUSH-------
|
|
|
|
* -->-- / -->-- \ -->--
|
|
|
|
* / \ / / \ \ / \
|
|
|
|
* +-------+-------+-------+-------+-------+--------+
|
|
|
|
* | A AND | B AND | C AND | D END | B1 OR | B2 END |
|
|
|
|
* +-------+-------+-------+-------+-------+--------+
|
|
|
|
* \ /
|
|
|
|
* --------<-POP---------
|
|
|
|
*
|
|
|
|
* where B is a virtual ematch referencing to sequence starting with B1.
|
2007-02-09 22:25:16 +08:00
|
|
|
*
|
2005-04-17 06:20:36 +08:00
|
|
|
* ==========================================================================
|
|
|
|
*
|
|
|
|
* How to write an ematch in 60 seconds
|
|
|
|
* ------------------------------------
|
2007-02-09 22:25:16 +08:00
|
|
|
*
|
2005-04-17 06:20:36 +08:00
|
|
|
* 1) Provide a matcher function:
|
|
|
|
* static int my_match(struct sk_buff *skb, struct tcf_ematch *m,
|
|
|
|
* struct tcf_pkt_info *info)
|
|
|
|
* {
|
|
|
|
* struct mydata *d = (struct mydata *) m->data;
|
|
|
|
*
|
|
|
|
* if (...matching goes here...)
|
|
|
|
* return 1;
|
|
|
|
* else
|
|
|
|
* return 0;
|
|
|
|
* }
|
|
|
|
*
|
|
|
|
* 2) Fill out a struct tcf_ematch_ops:
|
|
|
|
* static struct tcf_ematch_ops my_ops = {
|
|
|
|
* .kind = unique id,
|
|
|
|
* .datalen = sizeof(struct mydata),
|
|
|
|
* .match = my_match,
|
|
|
|
* .owner = THIS_MODULE,
|
|
|
|
* };
|
|
|
|
*
|
|
|
|
* 3) Register/Unregister your ematch:
|
|
|
|
* static int __init init_my_ematch(void)
|
|
|
|
* {
|
|
|
|
* return tcf_em_register(&my_ops);
|
|
|
|
* }
|
|
|
|
*
|
|
|
|
* static void __exit exit_my_ematch(void)
|
|
|
|
* {
|
2008-11-17 15:01:49 +08:00
|
|
|
* tcf_em_unregister(&my_ops);
|
2005-04-17 06:20:36 +08:00
|
|
|
* }
|
|
|
|
*
|
|
|
|
* module_init(init_my_ematch);
|
|
|
|
* module_exit(exit_my_ematch);
|
|
|
|
*
|
|
|
|
* 4) By now you should have two more seconds left, barely enough to
|
|
|
|
* open up a beer to watch the compilation going.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/module.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 16:04:11 +08:00
|
|
|
#include <linux/slab.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/errno.h>
|
|
|
|
#include <linux/rtnetlink.h>
|
|
|
|
#include <linux/skbuff.h>
|
|
|
|
#include <net/pkt_cls.h>
|
|
|
|
|
|
|
|
static LIST_HEAD(ematch_ops);
|
|
|
|
static DEFINE_RWLOCK(ematch_mod_lock);
|
|
|
|
|
2011-01-20 03:26:56 +08:00
|
|
|
static struct tcf_ematch_ops *tcf_em_lookup(u16 kind)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct tcf_ematch_ops *e = NULL;
|
|
|
|
|
|
|
|
read_lock(&ematch_mod_lock);
|
|
|
|
list_for_each_entry(e, &ematch_ops, link) {
|
|
|
|
if (kind == e->kind) {
|
|
|
|
if (!try_module_get(e->owner))
|
|
|
|
e = NULL;
|
|
|
|
read_unlock(&ematch_mod_lock);
|
|
|
|
return e;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
read_unlock(&ematch_mod_lock);
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* tcf_em_register - register an extended match
|
2007-02-09 22:25:16 +08:00
|
|
|
*
|
2005-04-17 06:20:36 +08:00
|
|
|
* @ops: ematch operations lookup table
|
|
|
|
*
|
|
|
|
* This function must be called by ematches to announce their presence.
|
|
|
|
* The given @ops must have kind set to a unique identifier and the
|
|
|
|
* callback match() must be implemented. All other callbacks are optional
|
|
|
|
* and a fallback implementation is used instead.
|
|
|
|
*
|
|
|
|
* Returns -EEXISTS if an ematch of the same kind has already registered.
|
|
|
|
*/
|
|
|
|
int tcf_em_register(struct tcf_ematch_ops *ops)
|
|
|
|
{
|
|
|
|
int err = -EEXIST;
|
|
|
|
struct tcf_ematch_ops *e;
|
|
|
|
|
|
|
|
if (ops->match == NULL)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
write_lock(&ematch_mod_lock);
|
|
|
|
list_for_each_entry(e, &ematch_ops, link)
|
|
|
|
if (ops->kind == e->kind)
|
|
|
|
goto errout;
|
|
|
|
|
|
|
|
list_add_tail(&ops->link, &ematch_ops);
|
|
|
|
err = 0;
|
|
|
|
errout:
|
|
|
|
write_unlock(&ematch_mod_lock);
|
|
|
|
return err;
|
|
|
|
}
|
2008-01-23 14:10:23 +08:00
|
|
|
EXPORT_SYMBOL(tcf_em_register);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
/**
|
|
|
|
* tcf_em_unregister - unregster and extended match
|
|
|
|
*
|
|
|
|
* @ops: ematch operations lookup table
|
|
|
|
*
|
|
|
|
* This function must be called by ematches to announce their disappearance
|
|
|
|
* for examples when the module gets unloaded. The @ops parameter must be
|
|
|
|
* the same as the one used for registration.
|
|
|
|
*
|
|
|
|
* Returns -ENOENT if no matching ematch was found.
|
|
|
|
*/
|
2008-11-17 15:01:49 +08:00
|
|
|
void tcf_em_unregister(struct tcf_ematch_ops *ops)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
write_lock(&ematch_mod_lock);
|
2008-11-17 15:01:49 +08:00
|
|
|
list_del(&ops->link);
|
2005-04-17 06:20:36 +08:00
|
|
|
write_unlock(&ematch_mod_lock);
|
|
|
|
}
|
2008-01-23 14:10:23 +08:00
|
|
|
EXPORT_SYMBOL(tcf_em_unregister);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2011-01-20 03:26:56 +08:00
|
|
|
static inline struct tcf_ematch *tcf_em_get_match(struct tcf_ematch_tree *tree,
|
|
|
|
int index)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
return &tree->matches[index];
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static int tcf_em_validate(struct tcf_proto *tp,
|
|
|
|
struct tcf_ematch_tree_hdr *tree_hdr,
|
2008-01-23 14:11:33 +08:00
|
|
|
struct tcf_ematch *em, struct nlattr *nla, int idx)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
int err = -EINVAL;
|
2008-01-23 14:11:33 +08:00
|
|
|
struct tcf_ematch_hdr *em_hdr = nla_data(nla);
|
|
|
|
int data_len = nla_len(nla) - sizeof(*em_hdr);
|
2005-04-17 06:20:36 +08:00
|
|
|
void *data = (void *) em_hdr + sizeof(*em_hdr);
|
2017-10-13 20:01:01 +08:00
|
|
|
struct net *net = tp->chain->block->net;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
if (!TCF_EM_REL_VALID(em_hdr->flags))
|
|
|
|
goto errout;
|
|
|
|
|
|
|
|
if (em_hdr->kind == TCF_EM_CONTAINER) {
|
|
|
|
/* Special ematch called "container", carries an index
|
2011-01-20 03:26:56 +08:00
|
|
|
* referencing an external ematch sequence.
|
|
|
|
*/
|
2005-04-17 06:20:36 +08:00
|
|
|
u32 ref;
|
|
|
|
|
|
|
|
if (data_len < sizeof(ref))
|
|
|
|
goto errout;
|
|
|
|
ref = *(u32 *) data;
|
|
|
|
|
|
|
|
if (ref >= tree_hdr->nmatches)
|
|
|
|
goto errout;
|
|
|
|
|
|
|
|
/* We do not allow backward jumps to avoid loops and jumps
|
2011-01-20 03:26:56 +08:00
|
|
|
* to our own position are of course illegal.
|
|
|
|
*/
|
2005-04-17 06:20:36 +08:00
|
|
|
if (ref <= idx)
|
|
|
|
goto errout;
|
|
|
|
|
2007-02-09 22:25:16 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
em->data = ref;
|
|
|
|
} else {
|
|
|
|
/* Note: This lookup will increase the module refcnt
|
|
|
|
* of the ematch module referenced. In case of a failure,
|
|
|
|
* a destroy function is called by the underlying layer
|
|
|
|
* which automatically releases the reference again, therefore
|
|
|
|
* the module MUST not be given back under any circumstances
|
|
|
|
* here. Be aware, the destroy function assumes that the
|
2011-01-20 03:26:56 +08:00
|
|
|
* module is held if the ops field is non zero.
|
|
|
|
*/
|
2005-04-17 06:20:36 +08:00
|
|
|
em->ops = tcf_em_lookup(em_hdr->kind);
|
|
|
|
|
|
|
|
if (em->ops == NULL) {
|
|
|
|
err = -ENOENT;
|
2008-10-17 06:24:51 +08:00
|
|
|
#ifdef CONFIG_MODULES
|
2007-07-12 10:46:26 +08:00
|
|
|
__rtnl_unlock();
|
|
|
|
request_module("ematch-kind-%u", em_hdr->kind);
|
|
|
|
rtnl_lock();
|
|
|
|
em->ops = tcf_em_lookup(em_hdr->kind);
|
|
|
|
if (em->ops) {
|
|
|
|
/* We dropped the RTNL mutex in order to
|
|
|
|
* perform the module load. Tell the caller
|
2011-01-20 03:26:56 +08:00
|
|
|
* to replay the request.
|
|
|
|
*/
|
2007-07-12 10:46:26 +08:00
|
|
|
module_put(em->ops->owner);
|
2015-02-18 03:15:20 +08:00
|
|
|
em->ops = NULL;
|
2007-07-12 10:46:26 +08:00
|
|
|
err = -EAGAIN;
|
|
|
|
}
|
|
|
|
#endif
|
2005-04-17 06:20:36 +08:00
|
|
|
goto errout;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* ematch module provides expected length of data, so we
|
2011-01-20 03:26:56 +08:00
|
|
|
* can do a basic sanity check.
|
|
|
|
*/
|
2005-04-17 06:20:36 +08:00
|
|
|
if (em->ops->datalen && data_len < em->ops->datalen)
|
|
|
|
goto errout;
|
|
|
|
|
|
|
|
if (em->ops->change) {
|
2024-06-11 20:08:33 +08:00
|
|
|
err = -EINVAL;
|
|
|
|
if (em_hdr->flags & TCF_EM_SIMPLE)
|
|
|
|
goto errout;
|
2014-10-06 12:27:53 +08:00
|
|
|
err = em->ops->change(net, data, data_len, em);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (err < 0)
|
|
|
|
goto errout;
|
|
|
|
} else if (data_len > 0) {
|
|
|
|
/* ematch module doesn't provide an own change
|
|
|
|
* procedure and expects us to allocate and copy
|
|
|
|
* the ematch data.
|
|
|
|
*
|
|
|
|
* TCF_EM_SIMPLE may be specified stating that the
|
|
|
|
* data only consists of a u32 integer and the module
|
|
|
|
* does not expected a memory reference but rather
|
2011-01-20 03:26:56 +08:00
|
|
|
* the value carried.
|
|
|
|
*/
|
2005-04-17 06:20:36 +08:00
|
|
|
if (em_hdr->flags & TCF_EM_SIMPLE) {
|
|
|
|
if (data_len < sizeof(u32))
|
|
|
|
goto errout;
|
|
|
|
em->data = *(u32 *) data;
|
|
|
|
} else {
|
2006-11-21 11:19:40 +08:00
|
|
|
void *v = kmemdup(data, data_len, GFP_KERNEL);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (v == NULL) {
|
|
|
|
err = -ENOBUFS;
|
|
|
|
goto errout;
|
|
|
|
}
|
|
|
|
em->data = (unsigned long) v;
|
|
|
|
}
|
2024-06-11 20:08:33 +08:00
|
|
|
em->datalen = data_len;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
em->matchid = em_hdr->matchid;
|
|
|
|
em->flags = em_hdr->flags;
|
2014-10-06 12:27:53 +08:00
|
|
|
em->net = net;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
err = 0;
|
|
|
|
errout:
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2008-01-24 12:36:45 +08:00
|
|
|
static const struct nla_policy em_policy[TCA_EMATCH_TREE_MAX + 1] = {
|
|
|
|
[TCA_EMATCH_TREE_HDR] = { .len = sizeof(struct tcf_ematch_tree_hdr) },
|
|
|
|
[TCA_EMATCH_TREE_LIST] = { .type = NLA_NESTED },
|
|
|
|
};
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/**
|
|
|
|
* tcf_em_tree_validate - validate ematch config TLV and build ematch tree
|
|
|
|
*
|
|
|
|
* @tp: classifier kind handle
|
2008-01-23 14:11:33 +08:00
|
|
|
* @nla: ematch tree configuration TLV
|
2005-04-17 06:20:36 +08:00
|
|
|
* @tree: destination ematch tree variable to store the resulting
|
|
|
|
* ematch tree.
|
|
|
|
*
|
2008-01-23 14:11:33 +08:00
|
|
|
* This function validates the given configuration TLV @nla and builds an
|
2005-04-17 06:20:36 +08:00
|
|
|
* ematch tree in @tree. The resulting tree must later be copied into
|
|
|
|
* the private classifier data using tcf_em_tree_change(). You MUST NOT
|
|
|
|
* provide the ematch tree variable of the private classifier data directly,
|
|
|
|
* the changes would not be locked properly.
|
|
|
|
*
|
|
|
|
* Returns a negative error code if the configuration TLV contains errors.
|
|
|
|
*/
|
2008-01-23 14:11:33 +08:00
|
|
|
int tcf_em_tree_validate(struct tcf_proto *tp, struct nlattr *nla,
|
2005-04-17 06:20:36 +08:00
|
|
|
struct tcf_ematch_tree *tree)
|
|
|
|
{
|
2008-01-24 12:33:32 +08:00
|
|
|
int idx, list_len, matches_len, err;
|
2008-01-23 14:11:33 +08:00
|
|
|
struct nlattr *tb[TCA_EMATCH_TREE_MAX + 1];
|
|
|
|
struct nlattr *rt_match, *rt_hdr, *rt_list;
|
2005-04-17 06:20:36 +08:00
|
|
|
struct tcf_ematch_tree_hdr *tree_hdr;
|
|
|
|
struct tcf_ematch *em;
|
|
|
|
|
2008-02-09 19:47:19 +08:00
|
|
|
memset(tree, 0, sizeof(*tree));
|
|
|
|
if (!nla)
|
2005-11-09 01:39:17 +08:00
|
|
|
return 0;
|
|
|
|
|
netlink: make validation more configurable for future strictness
We currently have two levels of strict validation:
1) liberal (default)
- undefined (type >= max) & NLA_UNSPEC attributes accepted
- attribute length >= expected accepted
- garbage at end of message accepted
2) strict (opt-in)
- NLA_UNSPEC attributes accepted
- attribute length >= expected accepted
Split out parsing strictness into four different options:
* TRAILING - check that there's no trailing data after parsing
attributes (in message or nested)
* MAXTYPE - reject attrs > max known type
* UNSPEC - reject attributes with NLA_UNSPEC policy entries
* STRICT_ATTRS - strictly validate attribute size
The default for future things should be *everything*.
The current *_strict() is a combination of TRAILING and MAXTYPE,
and is renamed to _deprecated_strict().
The current regular parsing has none of this, and is renamed to
*_parse_deprecated().
Additionally it allows us to selectively set one of the new flags
even on old policies. Notably, the UNSPEC flag could be useful in
this case, since it can be arranged (by filling in the policy) to
not be an incompatible userspace ABI change, but would then going
forward prevent forgetting attribute entries. Similar can apply
to the POLICY flag.
We end up with the following renames:
* nla_parse -> nla_parse_deprecated
* nla_parse_strict -> nla_parse_deprecated_strict
* nlmsg_parse -> nlmsg_parse_deprecated
* nlmsg_parse_strict -> nlmsg_parse_deprecated_strict
* nla_parse_nested -> nla_parse_nested_deprecated
* nla_validate_nested -> nla_validate_nested_deprecated
Using spatch, of course:
@@
expression TB, MAX, HEAD, LEN, POL, EXT;
@@
-nla_parse(TB, MAX, HEAD, LEN, POL, EXT)
+nla_parse_deprecated(TB, MAX, HEAD, LEN, POL, EXT)
@@
expression NLH, HDRLEN, TB, MAX, POL, EXT;
@@
-nlmsg_parse(NLH, HDRLEN, TB, MAX, POL, EXT)
+nlmsg_parse_deprecated(NLH, HDRLEN, TB, MAX, POL, EXT)
@@
expression NLH, HDRLEN, TB, MAX, POL, EXT;
@@
-nlmsg_parse_strict(NLH, HDRLEN, TB, MAX, POL, EXT)
+nlmsg_parse_deprecated_strict(NLH, HDRLEN, TB, MAX, POL, EXT)
@@
expression TB, MAX, NLA, POL, EXT;
@@
-nla_parse_nested(TB, MAX, NLA, POL, EXT)
+nla_parse_nested_deprecated(TB, MAX, NLA, POL, EXT)
@@
expression START, MAX, POL, EXT;
@@
-nla_validate_nested(START, MAX, POL, EXT)
+nla_validate_nested_deprecated(START, MAX, POL, EXT)
@@
expression NLH, HDRLEN, MAX, POL, EXT;
@@
-nlmsg_validate(NLH, HDRLEN, MAX, POL, EXT)
+nlmsg_validate_deprecated(NLH, HDRLEN, MAX, POL, EXT)
For this patch, don't actually add the strict, non-renamed versions
yet so that it breaks compile if I get it wrong.
Also, while at it, make nla_validate and nla_parse go down to a
common __nla_validate_parse() function to avoid code duplication.
Ultimately, this allows us to have very strict validation for every
new caller of nla_parse()/nlmsg_parse() etc as re-introduced in the
next patch, while existing things will continue to work as is.
In effect then, this adds fully strict validation for any new command.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-04-26 20:07:28 +08:00
|
|
|
err = nla_parse_nested_deprecated(tb, TCA_EMATCH_TREE_MAX, nla,
|
|
|
|
em_policy, NULL);
|
2008-01-24 12:33:32 +08:00
|
|
|
if (err < 0)
|
2005-04-17 06:20:36 +08:00
|
|
|
goto errout;
|
|
|
|
|
2008-01-24 12:33:32 +08:00
|
|
|
err = -EINVAL;
|
2008-01-23 14:11:33 +08:00
|
|
|
rt_hdr = tb[TCA_EMATCH_TREE_HDR];
|
|
|
|
rt_list = tb[TCA_EMATCH_TREE_LIST];
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
if (rt_hdr == NULL || rt_list == NULL)
|
|
|
|
goto errout;
|
|
|
|
|
2008-01-23 14:11:33 +08:00
|
|
|
tree_hdr = nla_data(rt_hdr);
|
2005-04-17 06:20:36 +08:00
|
|
|
memcpy(&tree->hdr, tree_hdr, sizeof(*tree_hdr));
|
|
|
|
|
2008-01-23 14:11:33 +08:00
|
|
|
rt_match = nla_data(rt_list);
|
|
|
|
list_len = nla_len(rt_list);
|
2005-04-17 06:20:36 +08:00
|
|
|
matches_len = tree_hdr->nmatches * sizeof(*em);
|
|
|
|
|
2006-07-22 05:51:30 +08:00
|
|
|
tree->matches = kzalloc(matches_len, GFP_KERNEL);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (tree->matches == NULL)
|
|
|
|
goto errout;
|
|
|
|
|
2008-01-23 14:11:33 +08:00
|
|
|
/* We do not use nla_parse_nested here because the maximum
|
2005-04-17 06:20:36 +08:00
|
|
|
* number of attributes is unknown. This saves us the allocation
|
|
|
|
* for a tb buffer which would serve no purpose at all.
|
2007-02-09 22:25:16 +08:00
|
|
|
*
|
2005-04-17 06:20:36 +08:00
|
|
|
* The array of rt attributes is parsed in the order as they are
|
|
|
|
* provided, their type must be incremental from 1 to n. Even
|
|
|
|
* if it does not serve any real purpose, a failure of sticking
|
2011-01-20 03:26:56 +08:00
|
|
|
* to this policy will result in parsing failure.
|
|
|
|
*/
|
2008-01-23 14:11:33 +08:00
|
|
|
for (idx = 0; nla_ok(rt_match, list_len); idx++) {
|
2005-04-17 06:20:36 +08:00
|
|
|
err = -EINVAL;
|
|
|
|
|
2008-01-23 14:11:33 +08:00
|
|
|
if (rt_match->nla_type != (idx + 1))
|
2005-04-17 06:20:36 +08:00
|
|
|
goto errout_abort;
|
|
|
|
|
|
|
|
if (idx >= tree_hdr->nmatches)
|
|
|
|
goto errout_abort;
|
|
|
|
|
2008-01-23 14:11:33 +08:00
|
|
|
if (nla_len(rt_match) < sizeof(struct tcf_ematch_hdr))
|
2005-04-17 06:20:36 +08:00
|
|
|
goto errout_abort;
|
|
|
|
|
|
|
|
em = tcf_em_get_match(tree, idx);
|
|
|
|
|
|
|
|
err = tcf_em_validate(tp, tree_hdr, em, rt_match, idx);
|
|
|
|
if (err < 0)
|
|
|
|
goto errout_abort;
|
|
|
|
|
2008-01-23 14:11:33 +08:00
|
|
|
rt_match = nla_next(rt_match, &list_len);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Check if the number of matches provided by userspace actually
|
|
|
|
* complies with the array of matches. The number was used for
|
|
|
|
* the validation of references and a mismatch could lead to
|
2011-01-20 03:26:56 +08:00
|
|
|
* undefined references during the matching process.
|
|
|
|
*/
|
2005-04-17 06:20:36 +08:00
|
|
|
if (idx != tree_hdr->nmatches) {
|
|
|
|
err = -EINVAL;
|
|
|
|
goto errout_abort;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = 0;
|
|
|
|
errout:
|
|
|
|
return err;
|
|
|
|
|
|
|
|
errout_abort:
|
2014-10-06 12:27:53 +08:00
|
|
|
tcf_em_tree_destroy(tree);
|
2005-04-17 06:20:36 +08:00
|
|
|
return err;
|
|
|
|
}
|
2008-01-23 14:10:23 +08:00
|
|
|
EXPORT_SYMBOL(tcf_em_tree_validate);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
/**
|
|
|
|
* tcf_em_tree_destroy - destroy an ematch tree
|
|
|
|
*
|
|
|
|
* @tp: classifier kind handle
|
|
|
|
* @tree: ematch tree to be deleted
|
|
|
|
*
|
|
|
|
* This functions destroys an ematch tree previously created by
|
|
|
|
* tcf_em_tree_validate()/tcf_em_tree_change(). You must ensure that
|
|
|
|
* the ematch tree is not in use before calling this function.
|
|
|
|
*/
|
2014-10-06 12:27:53 +08:00
|
|
|
void tcf_em_tree_destroy(struct tcf_ematch_tree *tree)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
if (tree->matches == NULL)
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (i = 0; i < tree->hdr.nmatches; i++) {
|
|
|
|
struct tcf_ematch *em = tcf_em_get_match(tree, i);
|
|
|
|
|
|
|
|
if (em->ops) {
|
|
|
|
if (em->ops->destroy)
|
2014-10-06 12:27:53 +08:00
|
|
|
em->ops->destroy(em);
|
2008-02-10 15:26:53 +08:00
|
|
|
else if (!tcf_em_is_simple(em))
|
2008-02-10 19:48:15 +08:00
|
|
|
kfree((void *) em->data);
|
2005-04-17 06:20:36 +08:00
|
|
|
module_put(em->ops->owner);
|
|
|
|
}
|
|
|
|
}
|
2007-02-09 22:25:16 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
tree->hdr.nmatches = 0;
|
|
|
|
kfree(tree->matches);
|
2008-02-10 15:26:53 +08:00
|
|
|
tree->matches = NULL;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2008-01-23 14:10:23 +08:00
|
|
|
EXPORT_SYMBOL(tcf_em_tree_destroy);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
/**
|
|
|
|
* tcf_em_tree_dump - dump ematch tree into a rtnl message
|
|
|
|
*
|
|
|
|
* @skb: skb holding the rtnl message
|
|
|
|
* @t: ematch tree to be dumped
|
|
|
|
* @tlv: TLV type to be used to encapsulate the tree
|
|
|
|
*
|
|
|
|
* This function dumps a ematch tree into a rtnl message. It is valid to
|
|
|
|
* call this function while the ematch tree is in use.
|
|
|
|
*
|
|
|
|
* Returns -1 if the skb tailroom is insufficient.
|
|
|
|
*/
|
|
|
|
int tcf_em_tree_dump(struct sk_buff *skb, struct tcf_ematch_tree *tree, int tlv)
|
|
|
|
{
|
|
|
|
int i;
|
2007-04-20 11:29:13 +08:00
|
|
|
u8 *tail;
|
2008-01-24 12:34:11 +08:00
|
|
|
struct nlattr *top_start;
|
2008-01-23 14:11:33 +08:00
|
|
|
struct nlattr *list_start;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2019-04-26 17:13:06 +08:00
|
|
|
top_start = nla_nest_start_noflag(skb, tlv);
|
2008-01-24 12:34:11 +08:00
|
|
|
if (top_start == NULL)
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
2012-03-29 17:11:39 +08:00
|
|
|
if (nla_put(skb, TCA_EMATCH_TREE_HDR, sizeof(tree->hdr), &tree->hdr))
|
|
|
|
goto nla_put_failure;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2019-04-26 17:13:06 +08:00
|
|
|
list_start = nla_nest_start_noflag(skb, TCA_EMATCH_TREE_LIST);
|
2008-01-24 12:34:11 +08:00
|
|
|
if (list_start == NULL)
|
|
|
|
goto nla_put_failure;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2007-04-20 11:29:13 +08:00
|
|
|
tail = skb_tail_pointer(skb);
|
2005-04-17 06:20:36 +08:00
|
|
|
for (i = 0; i < tree->hdr.nmatches; i++) {
|
2008-01-23 14:11:33 +08:00
|
|
|
struct nlattr *match_start = (struct nlattr *)tail;
|
2005-04-17 06:20:36 +08:00
|
|
|
struct tcf_ematch *em = tcf_em_get_match(tree, i);
|
|
|
|
struct tcf_ematch_hdr em_hdr = {
|
|
|
|
.kind = em->ops ? em->ops->kind : TCF_EM_CONTAINER,
|
|
|
|
.matchid = em->matchid,
|
|
|
|
.flags = em->flags
|
|
|
|
};
|
|
|
|
|
2012-03-29 17:11:39 +08:00
|
|
|
if (nla_put(skb, i + 1, sizeof(em_hdr), &em_hdr))
|
|
|
|
goto nla_put_failure;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
if (em->ops && em->ops->dump) {
|
|
|
|
if (em->ops->dump(skb, em) < 0)
|
2008-01-23 14:11:33 +08:00
|
|
|
goto nla_put_failure;
|
2005-04-17 06:20:36 +08:00
|
|
|
} else if (tcf_em_is_container(em) || tcf_em_is_simple(em)) {
|
|
|
|
u32 u = em->data;
|
2008-01-23 14:11:33 +08:00
|
|
|
nla_put_nohdr(skb, sizeof(u), &u);
|
2005-04-17 06:20:36 +08:00
|
|
|
} else if (em->datalen > 0)
|
2008-01-23 14:11:33 +08:00
|
|
|
nla_put_nohdr(skb, em->datalen, (void *) em->data);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2007-04-20 11:29:13 +08:00
|
|
|
tail = skb_tail_pointer(skb);
|
2008-01-23 14:11:33 +08:00
|
|
|
match_start->nla_len = tail - (u8 *)match_start;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2008-01-24 12:34:11 +08:00
|
|
|
nla_nest_end(skb, list_start);
|
|
|
|
nla_nest_end(skb, top_start);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
2008-01-23 14:11:33 +08:00
|
|
|
nla_put_failure:
|
2005-04-17 06:20:36 +08:00
|
|
|
return -1;
|
|
|
|
}
|
2008-01-23 14:10:23 +08:00
|
|
|
EXPORT_SYMBOL(tcf_em_tree_dump);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
static inline int tcf_em_match(struct sk_buff *skb, struct tcf_ematch *em,
|
|
|
|
struct tcf_pkt_info *info)
|
|
|
|
{
|
|
|
|
int r = em->ops->match(skb, em, info);
|
2011-01-20 03:26:56 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
return tcf_em_is_inverted(em) ? !r : r;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Do not use this function directly, use tcf_em_tree_match instead */
|
|
|
|
int __tcf_em_tree_match(struct sk_buff *skb, struct tcf_ematch_tree *tree,
|
|
|
|
struct tcf_pkt_info *info)
|
|
|
|
{
|
|
|
|
int stackp = 0, match_idx = 0, res = 0;
|
|
|
|
struct tcf_ematch *cur_match;
|
|
|
|
int stack[CONFIG_NET_EMATCH_STACK];
|
|
|
|
|
|
|
|
proceed:
|
|
|
|
while (match_idx < tree->hdr.nmatches) {
|
|
|
|
cur_match = tcf_em_get_match(tree, match_idx);
|
|
|
|
|
|
|
|
if (tcf_em_is_container(cur_match)) {
|
|
|
|
if (unlikely(stackp >= CONFIG_NET_EMATCH_STACK))
|
|
|
|
goto stack_overflow;
|
|
|
|
|
|
|
|
stack[stackp++] = match_idx;
|
|
|
|
match_idx = cur_match->data;
|
|
|
|
goto proceed;
|
|
|
|
}
|
|
|
|
|
|
|
|
res = tcf_em_match(skb, cur_match, info);
|
|
|
|
|
|
|
|
if (tcf_em_early_end(cur_match, res))
|
|
|
|
break;
|
|
|
|
|
|
|
|
match_idx++;
|
|
|
|
}
|
|
|
|
|
|
|
|
pop_stack:
|
|
|
|
if (stackp > 0) {
|
|
|
|
match_idx = stack[--stackp];
|
|
|
|
cur_match = tcf_em_get_match(tree, match_idx);
|
|
|
|
|
2014-10-03 21:44:48 +08:00
|
|
|
if (tcf_em_is_inverted(cur_match))
|
|
|
|
res = !res;
|
|
|
|
|
2014-09-25 00:38:39 +08:00
|
|
|
if (tcf_em_early_end(cur_match, res)) {
|
2005-04-17 06:20:36 +08:00
|
|
|
goto pop_stack;
|
2014-09-25 00:38:39 +08:00
|
|
|
} else {
|
2005-04-17 06:20:36 +08:00
|
|
|
match_idx++;
|
|
|
|
goto proceed;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return res;
|
|
|
|
|
|
|
|
stack_overflow:
|
2012-05-14 05:56:26 +08:00
|
|
|
net_warn_ratelimited("tc ematch: local stack overflow, increase NET_EMATCH_STACK\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(__tcf_em_tree_match);
|