2019-06-04 16:11:33 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2016-03-11 07:55:29 +08:00
|
|
|
/*
|
|
|
|
* Copyright (c) 2012-2016 Synaptics Incorporated
|
|
|
|
*/
|
|
|
|
#include <linux/input.h>
|
|
|
|
#include <linux/input/mt.h>
|
|
|
|
#include <linux/rmi.h>
|
|
|
|
#include "rmi_driver.h"
|
|
|
|
#include "rmi_2d_sensor.h"
|
|
|
|
|
|
|
|
enum rmi_f12_object_type {
|
|
|
|
RMI_F12_OBJECT_NONE = 0x00,
|
|
|
|
RMI_F12_OBJECT_FINGER = 0x01,
|
|
|
|
RMI_F12_OBJECT_STYLUS = 0x02,
|
|
|
|
RMI_F12_OBJECT_PALM = 0x03,
|
|
|
|
RMI_F12_OBJECT_UNCLASSIFIED = 0x04,
|
|
|
|
RMI_F12_OBJECT_GLOVED_FINGER = 0x06,
|
|
|
|
RMI_F12_OBJECT_NARROW_OBJECT = 0x07,
|
|
|
|
RMI_F12_OBJECT_HAND_EDGE = 0x08,
|
|
|
|
RMI_F12_OBJECT_COVER = 0x0A,
|
|
|
|
RMI_F12_OBJECT_STYLUS_2 = 0x0B,
|
|
|
|
RMI_F12_OBJECT_ERASER = 0x0C,
|
|
|
|
RMI_F12_OBJECT_SMALL_OBJECT = 0x0D,
|
|
|
|
};
|
|
|
|
|
2016-11-09 08:46:20 +08:00
|
|
|
#define F12_DATA1_BYTES_PER_OBJ 8
|
|
|
|
|
2016-03-11 07:55:29 +08:00
|
|
|
struct f12_data {
|
|
|
|
struct rmi_2d_sensor sensor;
|
|
|
|
struct rmi_2d_sensor_platform_data sensor_pdata;
|
2016-11-09 08:47:58 +08:00
|
|
|
bool has_dribble;
|
2016-03-11 07:55:29 +08:00
|
|
|
|
|
|
|
u16 data_addr;
|
|
|
|
|
|
|
|
struct rmi_register_descriptor query_reg_desc;
|
|
|
|
struct rmi_register_descriptor control_reg_desc;
|
|
|
|
struct rmi_register_descriptor data_reg_desc;
|
|
|
|
|
|
|
|
/* F12 Data1 describes sensed objects */
|
|
|
|
const struct rmi_register_desc_item *data1;
|
|
|
|
u16 data1_offset;
|
|
|
|
|
|
|
|
/* F12 Data5 describes finger ACM */
|
|
|
|
const struct rmi_register_desc_item *data5;
|
|
|
|
u16 data5_offset;
|
|
|
|
|
|
|
|
/* F12 Data5 describes Pen */
|
|
|
|
const struct rmi_register_desc_item *data6;
|
|
|
|
u16 data6_offset;
|
|
|
|
|
|
|
|
|
|
|
|
/* F12 Data9 reports relative data */
|
|
|
|
const struct rmi_register_desc_item *data9;
|
|
|
|
u16 data9_offset;
|
|
|
|
|
|
|
|
const struct rmi_register_desc_item *data15;
|
|
|
|
u16 data15_offset;
|
2019-11-05 08:06:44 +08:00
|
|
|
|
|
|
|
unsigned long *abs_mask;
|
|
|
|
unsigned long *rel_mask;
|
2016-03-11 07:55:29 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
|
|
|
|
{
|
|
|
|
const struct rmi_register_desc_item *item;
|
|
|
|
struct rmi_2d_sensor *sensor = &f12->sensor;
|
|
|
|
struct rmi_function *fn = sensor->fn;
|
|
|
|
struct rmi_device *rmi_dev = fn->rmi_dev;
|
|
|
|
int ret;
|
|
|
|
int offset;
|
2016-07-20 08:53:59 +08:00
|
|
|
u8 buf[15];
|
2016-03-11 07:55:29 +08:00
|
|
|
int pitch_x = 0;
|
|
|
|
int pitch_y = 0;
|
|
|
|
int rx_receivers = 0;
|
|
|
|
int tx_receivers = 0;
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->control_reg_desc, 8);
|
|
|
|
if (!item) {
|
|
|
|
dev_err(&fn->dev,
|
|
|
|
"F12 does not have the sensor tuning control register\n");
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
|
|
|
offset = rmi_register_desc_calc_reg_offset(&f12->control_reg_desc, 8);
|
|
|
|
|
2016-07-20 08:53:59 +08:00
|
|
|
if (item->reg_size > sizeof(buf)) {
|
|
|
|
dev_err(&fn->dev,
|
|
|
|
"F12 control8 should be no bigger than %zd bytes, not: %ld\n",
|
|
|
|
sizeof(buf), item->reg_size);
|
2016-03-11 07:55:29 +08:00
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = rmi_read_block(rmi_dev, fn->fd.control_base_addr + offset, buf,
|
|
|
|
item->reg_size);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
offset = 0;
|
|
|
|
if (rmi_register_desc_has_subpacket(item, 0)) {
|
|
|
|
sensor->max_x = (buf[offset + 1] << 8) | buf[offset];
|
|
|
|
sensor->max_y = (buf[offset + 3] << 8) | buf[offset + 2];
|
|
|
|
offset += 4;
|
|
|
|
}
|
|
|
|
|
|
|
|
rmi_dbg(RMI_DEBUG_FN, &fn->dev, "%s: max_x: %d max_y: %d\n", __func__,
|
|
|
|
sensor->max_x, sensor->max_y);
|
|
|
|
|
|
|
|
if (rmi_register_desc_has_subpacket(item, 1)) {
|
|
|
|
pitch_x = (buf[offset + 1] << 8) | buf[offset];
|
|
|
|
pitch_y = (buf[offset + 3] << 8) | buf[offset + 2];
|
|
|
|
offset += 4;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (rmi_register_desc_has_subpacket(item, 2)) {
|
2017-04-15 05:43:25 +08:00
|
|
|
/* Units 1/128 sensor pitch */
|
|
|
|
rmi_dbg(RMI_DEBUG_FN, &fn->dev,
|
|
|
|
"%s: Inactive Border xlo:%d xhi:%d ylo:%d yhi:%d\n",
|
|
|
|
__func__,
|
|
|
|
buf[offset], buf[offset + 1],
|
|
|
|
buf[offset + 2], buf[offset + 3]);
|
|
|
|
|
2016-03-11 07:55:29 +08:00
|
|
|
offset += 4;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (rmi_register_desc_has_subpacket(item, 3)) {
|
|
|
|
rx_receivers = buf[offset];
|
|
|
|
tx_receivers = buf[offset + 1];
|
|
|
|
offset += 2;
|
|
|
|
}
|
|
|
|
|
2019-05-27 00:17:45 +08:00
|
|
|
/* Skip over sensor flags */
|
|
|
|
if (rmi_register_desc_has_subpacket(item, 4))
|
2016-03-11 07:55:29 +08:00
|
|
|
offset += 1;
|
|
|
|
|
|
|
|
sensor->x_mm = (pitch_x * rx_receivers) >> 12;
|
|
|
|
sensor->y_mm = (pitch_y * tx_receivers) >> 12;
|
|
|
|
|
|
|
|
rmi_dbg(RMI_DEBUG_FN, &fn->dev, "%s: x_mm: %d y_mm: %d\n", __func__,
|
|
|
|
sensor->x_mm, sensor->y_mm);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-11-09 08:46:20 +08:00
|
|
|
static void rmi_f12_process_objects(struct f12_data *f12, u8 *data1, int size)
|
2016-03-11 07:55:29 +08:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
struct rmi_2d_sensor *sensor = &f12->sensor;
|
2016-11-09 08:46:20 +08:00
|
|
|
int objects = f12->data1->num_subpackets;
|
|
|
|
|
|
|
|
if ((f12->data1->num_subpackets * F12_DATA1_BYTES_PER_OBJ) > size)
|
|
|
|
objects = size / F12_DATA1_BYTES_PER_OBJ;
|
2016-03-11 07:55:29 +08:00
|
|
|
|
2016-11-09 08:46:20 +08:00
|
|
|
for (i = 0; i < objects; i++) {
|
2016-03-11 07:55:29 +08:00
|
|
|
struct rmi_2d_sensor_abs_object *obj = &sensor->objs[i];
|
|
|
|
|
|
|
|
obj->type = RMI_2D_OBJECT_NONE;
|
|
|
|
obj->mt_tool = MT_TOOL_FINGER;
|
|
|
|
|
|
|
|
switch (data1[0]) {
|
|
|
|
case RMI_F12_OBJECT_FINGER:
|
|
|
|
obj->type = RMI_2D_OBJECT_FINGER;
|
|
|
|
break;
|
|
|
|
case RMI_F12_OBJECT_STYLUS:
|
|
|
|
obj->type = RMI_2D_OBJECT_STYLUS;
|
|
|
|
obj->mt_tool = MT_TOOL_PEN;
|
|
|
|
break;
|
|
|
|
case RMI_F12_OBJECT_PALM:
|
|
|
|
obj->type = RMI_2D_OBJECT_PALM;
|
|
|
|
obj->mt_tool = MT_TOOL_PALM;
|
|
|
|
break;
|
|
|
|
case RMI_F12_OBJECT_UNCLASSIFIED:
|
|
|
|
obj->type = RMI_2D_OBJECT_UNCLASSIFIED;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
obj->x = (data1[2] << 8) | data1[1];
|
|
|
|
obj->y = (data1[4] << 8) | data1[3];
|
|
|
|
obj->z = data1[5];
|
|
|
|
obj->wx = data1[6];
|
|
|
|
obj->wy = data1[7];
|
|
|
|
|
|
|
|
rmi_2d_sensor_abs_process(sensor, obj, i);
|
|
|
|
|
2016-11-09 08:46:20 +08:00
|
|
|
data1 += F12_DATA1_BYTES_PER_OBJ;
|
2016-03-11 07:55:29 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (sensor->kernel_tracking)
|
|
|
|
input_mt_assign_slots(sensor->input,
|
|
|
|
sensor->tracking_slots,
|
|
|
|
sensor->tracking_pos,
|
|
|
|
sensor->nbr_fingers,
|
|
|
|
sensor->dmax);
|
|
|
|
|
2016-11-09 08:46:20 +08:00
|
|
|
for (i = 0; i < objects; i++)
|
2016-03-11 07:55:29 +08:00
|
|
|
rmi_2d_sensor_abs_report(sensor, &sensor->objs[i], i);
|
|
|
|
}
|
|
|
|
|
2018-06-06 01:17:51 +08:00
|
|
|
static irqreturn_t rmi_f12_attention(int irq, void *ctx)
|
2016-03-11 07:55:29 +08:00
|
|
|
{
|
|
|
|
int retval;
|
2018-06-06 01:17:51 +08:00
|
|
|
struct rmi_function *fn = ctx;
|
2016-03-11 07:55:29 +08:00
|
|
|
struct rmi_device *rmi_dev = fn->rmi_dev;
|
2016-12-03 09:49:10 +08:00
|
|
|
struct rmi_driver_data *drvdata = dev_get_drvdata(&rmi_dev->dev);
|
2016-03-11 07:55:29 +08:00
|
|
|
struct f12_data *f12 = dev_get_drvdata(&fn->dev);
|
|
|
|
struct rmi_2d_sensor *sensor = &f12->sensor;
|
2016-11-09 08:46:20 +08:00
|
|
|
int valid_bytes = sensor->pkt_size;
|
2016-03-11 07:55:29 +08:00
|
|
|
|
2016-12-03 09:49:10 +08:00
|
|
|
if (drvdata->attn_data.data) {
|
|
|
|
if (sensor->attn_size > drvdata->attn_data.size)
|
|
|
|
valid_bytes = drvdata->attn_data.size;
|
2016-11-09 08:46:20 +08:00
|
|
|
else
|
|
|
|
valid_bytes = sensor->attn_size;
|
2016-12-03 09:49:10 +08:00
|
|
|
memcpy(sensor->data_pkt, drvdata->attn_data.data,
|
2016-11-09 08:46:20 +08:00
|
|
|
valid_bytes);
|
2019-11-05 08:07:30 +08:00
|
|
|
drvdata->attn_data.data += valid_bytes;
|
|
|
|
drvdata->attn_data.size -= valid_bytes;
|
2016-03-11 07:55:29 +08:00
|
|
|
} else {
|
|
|
|
retval = rmi_read_block(rmi_dev, f12->data_addr,
|
|
|
|
sensor->data_pkt, sensor->pkt_size);
|
|
|
|
if (retval < 0) {
|
|
|
|
dev_err(&fn->dev, "Failed to read object data. Code: %d.\n",
|
|
|
|
retval);
|
2018-06-06 01:17:51 +08:00
|
|
|
return IRQ_RETVAL(retval);
|
2016-03-11 07:55:29 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (f12->data1)
|
|
|
|
rmi_f12_process_objects(f12,
|
2016-11-09 08:46:20 +08:00
|
|
|
&sensor->data_pkt[f12->data1_offset], valid_bytes);
|
2016-03-11 07:55:29 +08:00
|
|
|
|
|
|
|
input_mt_sync_frame(sensor->input);
|
|
|
|
|
2018-06-06 01:17:51 +08:00
|
|
|
return IRQ_HANDLED;
|
2016-03-11 07:55:29 +08:00
|
|
|
}
|
|
|
|
|
2016-11-09 08:47:58 +08:00
|
|
|
static int rmi_f12_write_control_regs(struct rmi_function *fn)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
const struct rmi_register_desc_item *item;
|
|
|
|
struct rmi_device *rmi_dev = fn->rmi_dev;
|
|
|
|
struct f12_data *f12 = dev_get_drvdata(&fn->dev);
|
|
|
|
int control_size;
|
|
|
|
char buf[3];
|
|
|
|
u16 control_offset = 0;
|
|
|
|
u8 subpacket_offset = 0;
|
|
|
|
|
|
|
|
if (f12->has_dribble
|
|
|
|
&& (f12->sensor.dribble != RMI_REG_STATE_DEFAULT)) {
|
|
|
|
item = rmi_get_register_desc_item(&f12->control_reg_desc, 20);
|
|
|
|
if (item) {
|
|
|
|
control_offset = rmi_register_desc_calc_reg_offset(
|
|
|
|
&f12->control_reg_desc, 20);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The byte containing the EnableDribble bit will be
|
|
|
|
* in either byte 0 or byte 2 of control 20. Depending
|
|
|
|
* on the existence of subpacket 0. If control 20 is
|
|
|
|
* larger then 3 bytes, just read the first 3.
|
|
|
|
*/
|
|
|
|
control_size = min(item->reg_size, 3UL);
|
|
|
|
|
|
|
|
ret = rmi_read_block(rmi_dev, fn->fd.control_base_addr
|
|
|
|
+ control_offset, buf, control_size);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
if (rmi_register_desc_has_subpacket(item, 0))
|
|
|
|
subpacket_offset += 1;
|
|
|
|
|
|
|
|
switch (f12->sensor.dribble) {
|
|
|
|
case RMI_REG_STATE_OFF:
|
|
|
|
buf[subpacket_offset] &= ~BIT(2);
|
|
|
|
break;
|
|
|
|
case RMI_REG_STATE_ON:
|
|
|
|
buf[subpacket_offset] |= BIT(2);
|
|
|
|
break;
|
|
|
|
case RMI_REG_STATE_DEFAULT:
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = rmi_write_block(rmi_dev,
|
|
|
|
fn->fd.control_base_addr + control_offset,
|
|
|
|
buf, control_size);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2016-03-11 07:55:29 +08:00
|
|
|
static int rmi_f12_config(struct rmi_function *fn)
|
|
|
|
{
|
|
|
|
struct rmi_driver *drv = fn->rmi_dev->driver;
|
2019-11-05 08:06:44 +08:00
|
|
|
struct f12_data *f12 = dev_get_drvdata(&fn->dev);
|
|
|
|
struct rmi_2d_sensor *sensor;
|
2016-11-09 08:47:58 +08:00
|
|
|
int ret;
|
2016-03-11 07:55:29 +08:00
|
|
|
|
2019-11-05 08:06:44 +08:00
|
|
|
sensor = &f12->sensor;
|
|
|
|
|
|
|
|
if (!sensor->report_abs)
|
|
|
|
drv->clear_irq_bits(fn->rmi_dev, f12->abs_mask);
|
|
|
|
else
|
|
|
|
drv->set_irq_bits(fn->rmi_dev, f12->abs_mask);
|
|
|
|
|
|
|
|
drv->clear_irq_bits(fn->rmi_dev, f12->rel_mask);
|
2016-03-11 07:55:29 +08:00
|
|
|
|
2016-11-09 08:47:58 +08:00
|
|
|
ret = rmi_f12_write_control_regs(fn);
|
|
|
|
if (ret)
|
|
|
|
dev_warn(&fn->dev,
|
|
|
|
"Failed to write F12 control registers: %d\n", ret);
|
|
|
|
|
2016-03-11 07:55:29 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int rmi_f12_probe(struct rmi_function *fn)
|
|
|
|
{
|
|
|
|
struct f12_data *f12;
|
|
|
|
int ret;
|
|
|
|
struct rmi_device *rmi_dev = fn->rmi_dev;
|
|
|
|
char buf;
|
|
|
|
u16 query_addr = fn->fd.query_base_addr;
|
|
|
|
const struct rmi_register_desc_item *item;
|
|
|
|
struct rmi_2d_sensor *sensor;
|
|
|
|
struct rmi_device_platform_data *pdata = rmi_get_platform_data(rmi_dev);
|
2016-12-03 09:49:10 +08:00
|
|
|
struct rmi_driver_data *drvdata = dev_get_drvdata(&rmi_dev->dev);
|
2016-03-11 07:55:29 +08:00
|
|
|
u16 data_offset = 0;
|
2019-11-05 08:06:44 +08:00
|
|
|
int mask_size;
|
2016-03-11 07:55:29 +08:00
|
|
|
|
|
|
|
rmi_dbg(RMI_DEBUG_FN, &fn->dev, "%s\n", __func__);
|
|
|
|
|
2019-11-05 08:06:44 +08:00
|
|
|
mask_size = BITS_TO_LONGS(drvdata->irq_count) * sizeof(unsigned long);
|
|
|
|
|
2016-03-11 07:55:29 +08:00
|
|
|
ret = rmi_read(fn->rmi_dev, query_addr, &buf);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(&fn->dev, "Failed to read general info register: %d\n",
|
|
|
|
ret);
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
++query_addr;
|
|
|
|
|
2016-11-09 08:47:58 +08:00
|
|
|
if (!(buf & BIT(0))) {
|
2016-03-11 07:55:29 +08:00
|
|
|
dev_err(&fn->dev,
|
|
|
|
"Behavior of F12 without register descriptors is undefined.\n");
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
2019-11-05 08:06:44 +08:00
|
|
|
f12 = devm_kzalloc(&fn->dev, sizeof(struct f12_data) + mask_size * 2,
|
|
|
|
GFP_KERNEL);
|
2016-03-11 07:55:29 +08:00
|
|
|
if (!f12)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2019-11-05 08:06:44 +08:00
|
|
|
f12->abs_mask = (unsigned long *)((char *)f12
|
|
|
|
+ sizeof(struct f12_data));
|
|
|
|
f12->rel_mask = (unsigned long *)((char *)f12
|
|
|
|
+ sizeof(struct f12_data) + mask_size);
|
|
|
|
|
|
|
|
set_bit(fn->irq_pos, f12->abs_mask);
|
|
|
|
set_bit(fn->irq_pos + 1, f12->rel_mask);
|
|
|
|
|
2016-11-09 08:47:58 +08:00
|
|
|
f12->has_dribble = !!(buf & BIT(3));
|
|
|
|
|
2016-03-11 07:55:29 +08:00
|
|
|
if (fn->dev.of_node) {
|
|
|
|
ret = rmi_2d_sensor_of_probe(&fn->dev, &f12->sensor_pdata);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2016-12-01 09:01:50 +08:00
|
|
|
} else {
|
|
|
|
f12->sensor_pdata = pdata->sensor_pdata;
|
2016-03-11 07:55:29 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
ret = rmi_read_register_desc(rmi_dev, query_addr,
|
|
|
|
&f12->query_reg_desc);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(&fn->dev,
|
|
|
|
"Failed to read the Query Register Descriptor: %d\n",
|
|
|
|
ret);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
query_addr += 3;
|
|
|
|
|
|
|
|
ret = rmi_read_register_desc(rmi_dev, query_addr,
|
|
|
|
&f12->control_reg_desc);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(&fn->dev,
|
|
|
|
"Failed to read the Control Register Descriptor: %d\n",
|
|
|
|
ret);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
query_addr += 3;
|
|
|
|
|
|
|
|
ret = rmi_read_register_desc(rmi_dev, query_addr,
|
|
|
|
&f12->data_reg_desc);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(&fn->dev,
|
|
|
|
"Failed to read the Data Register Descriptor: %d\n",
|
|
|
|
ret);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
query_addr += 3;
|
|
|
|
|
|
|
|
sensor = &f12->sensor;
|
|
|
|
sensor->fn = fn;
|
|
|
|
f12->data_addr = fn->fd.data_base_addr;
|
|
|
|
sensor->pkt_size = rmi_register_desc_calc_size(&f12->data_reg_desc);
|
|
|
|
|
|
|
|
sensor->axis_align =
|
|
|
|
f12->sensor_pdata.axis_align;
|
|
|
|
|
|
|
|
sensor->x_mm = f12->sensor_pdata.x_mm;
|
|
|
|
sensor->y_mm = f12->sensor_pdata.y_mm;
|
2016-11-09 08:47:58 +08:00
|
|
|
sensor->dribble = f12->sensor_pdata.dribble;
|
2016-03-11 07:55:29 +08:00
|
|
|
|
|
|
|
if (sensor->sensor_type == rmi_sensor_default)
|
|
|
|
sensor->sensor_type =
|
|
|
|
f12->sensor_pdata.sensor_type;
|
|
|
|
|
|
|
|
rmi_dbg(RMI_DEBUG_FN, &fn->dev, "%s: data packet size: %d\n", __func__,
|
|
|
|
sensor->pkt_size);
|
|
|
|
sensor->data_pkt = devm_kzalloc(&fn->dev, sensor->pkt_size, GFP_KERNEL);
|
|
|
|
if (!sensor->data_pkt)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
dev_set_drvdata(&fn->dev, f12);
|
|
|
|
|
|
|
|
ret = rmi_f12_read_sensor_tuning(f12);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Figure out what data is contained in the data registers. HID devices
|
|
|
|
* may have registers defined, but their data is not reported in the
|
|
|
|
* HID attention report. Registers which are not reported in the HID
|
|
|
|
* attention report check to see if the device is receiving data from
|
|
|
|
* HID attention reports.
|
|
|
|
*/
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 0);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data)
|
2016-03-11 07:55:29 +08:00
|
|
|
data_offset += item->reg_size;
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 1);
|
|
|
|
if (item) {
|
|
|
|
f12->data1 = item;
|
|
|
|
f12->data1_offset = data_offset;
|
|
|
|
data_offset += item->reg_size;
|
|
|
|
sensor->nbr_fingers = item->num_subpackets;
|
|
|
|
sensor->report_abs = 1;
|
|
|
|
sensor->attn_size += item->reg_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 2);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data)
|
2016-03-11 07:55:29 +08:00
|
|
|
data_offset += item->reg_size;
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 3);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data)
|
2016-03-11 07:55:29 +08:00
|
|
|
data_offset += item->reg_size;
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 4);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data)
|
2016-03-11 07:55:29 +08:00
|
|
|
data_offset += item->reg_size;
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 5);
|
|
|
|
if (item) {
|
|
|
|
f12->data5 = item;
|
|
|
|
f12->data5_offset = data_offset;
|
|
|
|
data_offset += item->reg_size;
|
|
|
|
sensor->attn_size += item->reg_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 6);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data) {
|
2016-03-11 07:55:29 +08:00
|
|
|
f12->data6 = item;
|
|
|
|
f12->data6_offset = data_offset;
|
|
|
|
data_offset += item->reg_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 7);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data)
|
2016-03-11 07:55:29 +08:00
|
|
|
data_offset += item->reg_size;
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 8);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data)
|
2016-03-11 07:55:29 +08:00
|
|
|
data_offset += item->reg_size;
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 9);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data) {
|
2016-03-11 07:55:29 +08:00
|
|
|
f12->data9 = item;
|
|
|
|
f12->data9_offset = data_offset;
|
|
|
|
data_offset += item->reg_size;
|
|
|
|
if (!sensor->report_abs)
|
|
|
|
sensor->report_rel = 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 10);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data)
|
2016-03-11 07:55:29 +08:00
|
|
|
data_offset += item->reg_size;
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 11);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data)
|
2016-03-11 07:55:29 +08:00
|
|
|
data_offset += item->reg_size;
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 12);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data)
|
2016-03-11 07:55:29 +08:00
|
|
|
data_offset += item->reg_size;
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 13);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data)
|
2016-03-11 07:55:29 +08:00
|
|
|
data_offset += item->reg_size;
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 14);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data)
|
2016-03-11 07:55:29 +08:00
|
|
|
data_offset += item->reg_size;
|
|
|
|
|
|
|
|
item = rmi_get_register_desc_item(&f12->data_reg_desc, 15);
|
2016-12-03 09:49:10 +08:00
|
|
|
if (item && !drvdata->attn_data.data) {
|
2016-03-11 07:55:29 +08:00
|
|
|
f12->data15 = item;
|
|
|
|
f12->data15_offset = data_offset;
|
|
|
|
data_offset += item->reg_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* allocate the in-kernel tracking buffers */
|
treewide: devm_kzalloc() -> devm_kcalloc()
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
This patch replaces cases of:
devm_kzalloc(handle, a * b, gfp)
with:
devm_kcalloc(handle, a * b, gfp)
as well as handling cases of:
devm_kzalloc(handle, a * b * c, gfp)
with:
devm_kzalloc(handle, array3_size(a, b, c), gfp)
as it's slightly less ugly than:
devm_kcalloc(handle, array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
devm_kzalloc(handle, 4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@
(
devm_kzalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kzalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@
(
devm_kzalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@
(
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE, C1 * C2, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 05:07:58 +08:00
|
|
|
sensor->tracking_pos = devm_kcalloc(&fn->dev,
|
|
|
|
sensor->nbr_fingers, sizeof(struct input_mt_pos),
|
|
|
|
GFP_KERNEL);
|
|
|
|
sensor->tracking_slots = devm_kcalloc(&fn->dev,
|
|
|
|
sensor->nbr_fingers, sizeof(int), GFP_KERNEL);
|
|
|
|
sensor->objs = devm_kcalloc(&fn->dev,
|
|
|
|
sensor->nbr_fingers,
|
|
|
|
sizeof(struct rmi_2d_sensor_abs_object),
|
2016-03-11 07:55:29 +08:00
|
|
|
GFP_KERNEL);
|
|
|
|
if (!sensor->tracking_pos || !sensor->tracking_slots || !sensor->objs)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
ret = rmi_2d_sensor_configure_input(fn, sensor);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct rmi_function_handler rmi_f12_handler = {
|
|
|
|
.driver = {
|
|
|
|
.name = "rmi4_f12",
|
|
|
|
},
|
|
|
|
.func = 0x12,
|
|
|
|
.probe = rmi_f12_probe,
|
|
|
|
.config = rmi_f12_config,
|
|
|
|
.attention = rmi_f12_attention,
|
|
|
|
};
|