2019-06-01 16:08:44 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* linux/kernel/softirq.c
|
|
|
|
*
|
|
|
|
* Copyright (C) 1992 Linus Torvalds
|
|
|
|
*
|
2008-01-30 20:30:00 +08:00
|
|
|
* Rewritten. Old one was good in 2.2, but in 2.3 it was immoral. --ANK (990903)
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
|
|
|
|
2014-01-28 09:07:15 +08:00
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
|
2011-05-24 02:51:41 +08:00
|
|
|
#include <linux/export.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
#include <linux/kernel_stat.h>
|
|
|
|
#include <linux/interrupt.h>
|
|
|
|
#include <linux/init.h>
|
2021-03-09 16:55:56 +08:00
|
|
|
#include <linux/local_lock.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
#include <linux/mm.h>
|
|
|
|
#include <linux/notifier.h>
|
|
|
|
#include <linux/percpu.h>
|
|
|
|
#include <linux/cpu.h>
|
2007-07-17 19:03:35 +08:00
|
|
|
#include <linux/freezer.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
#include <linux/kthread.h>
|
|
|
|
#include <linux/rcupdate.h>
|
2009-01-23 08:01:40 +08:00
|
|
|
#include <linux/ftrace.h>
|
2006-03-22 16:08:16 +08:00
|
|
|
#include <linux/smp.h>
|
2012-07-16 18:42:37 +08:00
|
|
|
#include <linux/smpboot.h>
|
2007-02-16 17:28:03 +08:00
|
|
|
#include <linux/tick.h>
|
2014-03-19 18:19:52 +08:00
|
|
|
#include <linux/irq.h>
|
2021-03-09 16:42:08 +08:00
|
|
|
#include <linux/wait_bit.h>
|
2009-04-29 19:51:39 +08:00
|
|
|
|
2021-02-10 07:40:53 +08:00
|
|
|
#include <asm/softirq_stack.h>
|
|
|
|
|
2009-04-29 19:51:39 +08:00
|
|
|
#define CREATE_TRACE_POINTS
|
2009-04-15 07:39:12 +08:00
|
|
|
#include <trace/events/irq.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
- No shared variables, all the data are CPU local.
|
|
|
|
- If a softirq needs serialization, let it serialize itself
|
|
|
|
by its own spinlocks.
|
|
|
|
- Even if softirq is serialized, only local cpu is marked for
|
|
|
|
execution. Hence, we get something sort of weak cpu binding.
|
|
|
|
Though it is still not clear, will it result in better locality
|
|
|
|
or will not.
|
|
|
|
|
|
|
|
Examples:
|
|
|
|
- NET RX softirq. It is multithreaded and does not require
|
|
|
|
any global serialization.
|
|
|
|
- NET TX softirq. It kicks software netdevice queues, hence
|
|
|
|
it is logically serialized per device, but this serialization
|
|
|
|
is invisible to common code.
|
|
|
|
- Tasklets: serialized wrt itself.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#ifndef __ARCH_IRQ_STAT
|
2018-05-08 21:38:19 +08:00
|
|
|
DEFINE_PER_CPU_ALIGNED(irq_cpustat_t, irq_stat);
|
|
|
|
EXPORT_PER_CPU_SYMBOL(irq_stat);
|
2005-04-17 06:20:36 +08:00
|
|
|
#endif
|
|
|
|
|
2008-09-07 02:04:36 +08:00
|
|
|
static struct softirq_action softirq_vec[NR_SOFTIRQS] __cacheline_aligned_in_smp;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-12-22 09:09:00 +08:00
|
|
|
DEFINE_PER_CPU(struct task_struct *, ksoftirqd);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2014-01-28 09:07:16 +08:00
|
|
|
const char * const softirq_to_name[NR_SOFTIRQS] = {
|
2016-10-10 20:10:51 +08:00
|
|
|
"HI", "TIMER", "NET_TX", "NET_RX", "BLOCK", "IRQ_POLL",
|
rcu: Use softirq to address performance regression
Commit a26ac2455ffcf3(rcu: move TREE_RCU from softirq to kthread)
introduced performance regression. In an AIM7 test, this commit degraded
performance by about 40%.
The commit runs rcu callbacks in a kthread instead of softirq. We observed
high rate of context switch which is caused by this. Out test system has
64 CPUs and HZ is 1000, so we saw more than 64k context switch per second
which is caused by RCU's per-CPU kthread. A trace showed that most of
the time the RCU per-CPU kthread doesn't actually handle any callbacks,
but instead just does a very small amount of work handling grace periods.
This means that RCU's per-CPU kthreads are making the scheduler do quite
a bit of work in order to allow a very small amount of RCU-related
processing to be done.
Alex Shi's analysis determined that this slowdown is due to lock
contention within the scheduler. Unfortunately, as Peter Zijlstra points
out, the scheduler's real-time semantics require global action, which
means that this contention is inherent in real-time scheduling. (Yes,
perhaps someone will come up with a workaround -- otherwise, -rt is not
going to do well on large SMP systems -- but this patch will work around
this issue in the meantime. And "the meantime" might well be forever.)
This patch therefore re-introduces softirq processing to RCU, but only
for core RCU work. RCU callbacks are still executed in kthread context,
so that only a small amount of RCU work runs in softirq context in the
common case. This should minimize ksoftirqd execution, allowing us to
skip boosting of ksoftirqd for CONFIG_RCU_BOOST=y kernels.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Tested-by: "Alex,Shi" <alex.shi@intel.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
2011-06-14 13:26:25 +08:00
|
|
|
"TASKLET", "SCHED", "HRTIMER", "RCU"
|
2009-03-13 02:33:36 +08:00
|
|
|
};
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* we cannot loop indefinitely here to avoid userspace starvation,
|
|
|
|
* but we also don't want to introduce a worst case 1/HZ latency
|
|
|
|
* to the pending events, so lets the scheduler to balance
|
|
|
|
* the softirq load for us.
|
|
|
|
*/
|
2009-07-21 05:33:49 +08:00
|
|
|
static void wakeup_softirqd(void)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
/* Interrupts are disabled: no need to stop preemption */
|
2010-12-08 23:22:55 +08:00
|
|
|
struct task_struct *tsk = __this_cpu_read(ksoftirqd);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2021-06-11 16:28:11 +08:00
|
|
|
if (tsk)
|
2005-04-17 06:20:36 +08:00
|
|
|
wake_up_process(tsk);
|
|
|
|
}
|
|
|
|
|
softirq: Let ksoftirqd do its job
A while back, Paolo and Hannes sent an RFC patch adding threaded-able
napi poll loop support : (https://patchwork.ozlabs.org/patch/620657/)
The problem seems to be that softirqs are very aggressive and are often
handled by the current process, even if we are under stress and that
ksoftirqd was scheduled, so that innocent threads would have more chance
to make progress.
This patch makes sure that if ksoftirq is running, we let it
perform the softirq work.
Jonathan Corbet summarized the issue in https://lwn.net/Articles/687617/
Tested:
- NIC receiving traffic handled by CPU 0
- UDP receiver running on CPU 0, using a single UDP socket.
- Incoming flood of UDP packets targeting the UDP socket.
Before the patch, the UDP receiver could almost never get CPU cycles and
could only receive ~2,000 packets per second.
After the patch, CPU cycles are split 50/50 between user application and
ksoftirqd/0, and we can effectively read ~900,000 packets per second,
a huge improvement in DOS situation. (Note that more packets are now
dropped by the NIC itself, since the BH handlers get less CPU cycles to
drain RX ring buffer)
Since the load runs in well identified threads context, an admin can
more easily tune process scheduling parameters if needed.
Reported-by: Paolo Abeni <pabeni@redhat.com>
Reported-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: David Miller <davem@davemloft.net>
Cc: Hannes Frederic Sowa <hannes@redhat.com>
Cc: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1472665349.14381.356.camel@edumazet-glaptop3.roam.corp.google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2016-09-01 01:42:29 +08:00
|
|
|
/*
|
|
|
|
* If ksoftirqd is scheduled, we do not want to process pending softirqs
|
Mark HI and TASKLET softirq synchronous
Way back in 4.9, we committed 4cd13c21b207 ("softirq: Let ksoftirqd do
its job"), and ever since we've had small nagging issues with it. For
example, we've had:
1ff688209e2e ("watchdog: core: make sure the watchdog_worker is not deferred")
8d5755b3f77b ("watchdog: softdog: fire watchdog even if softirqs do not get to run")
217f69743681 ("net: busy-poll: allow preemption in sk_busy_loop()")
all of which worked around some of the effects of that commit.
The DVB people have also complained that the commit causes excessive USB
URB latencies, which seems to be due to the USB code using tasklets to
schedule USB traffic. This seems to be an issue mainly when already
living on the edge, but waiting for ksoftirqd to handle it really does
seem to cause excessive latencies.
Now Hanna Hawa reports that this issue isn't just limited to USB URB and
DVB, but also causes timeout problems for the Marvell SoC team:
"I'm facing kernel panic issue while running raid 5 on sata disks
connected to Macchiatobin (Marvell community board with Armada-8040
SoC with 4 ARMv8 cores of CA72) Raid 5 built with Marvell DMA engine
and async_tx mechanism (ASYNC_TX_DMA [=y]); the DMA driver (mv_xor_v2)
uses a tasklet to clean the done descriptors from the queue"
The latency problem causes a panic:
mv_xor_v2 f0400000.xor: dma_sync_wait: timeout!
Kernel panic - not syncing: async_tx_quiesce: DMA error waiting for transaction
We've discussed simply just reverting the original commit entirely, and
also much more involved solutions (with per-softirq threads etc). This
patch is intentionally stupid and fairly limited, because the issue
still remains, and the other solutions either got sidetracked or had
other issues.
We should probably also consider the timer softirqs to be synchronous
and not be delayed to ksoftirqd (since they were the issue with the
earlier watchdog problems), but that should be done as a separate patch.
This does only the tasklet cases.
Reported-and-tested-by: Hanna Hawa <hannah@marvell.com>
Reported-and-tested-by: Josef Griebichler <griebichler.josef@gmx.at>
Reported-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-01-09 03:51:04 +08:00
|
|
|
* right now. Let ksoftirqd handle this at its own rate, to get fairness,
|
|
|
|
* unless we're doing some of the synchronous softirqs.
|
softirq: Let ksoftirqd do its job
A while back, Paolo and Hannes sent an RFC patch adding threaded-able
napi poll loop support : (https://patchwork.ozlabs.org/patch/620657/)
The problem seems to be that softirqs are very aggressive and are often
handled by the current process, even if we are under stress and that
ksoftirqd was scheduled, so that innocent threads would have more chance
to make progress.
This patch makes sure that if ksoftirq is running, we let it
perform the softirq work.
Jonathan Corbet summarized the issue in https://lwn.net/Articles/687617/
Tested:
- NIC receiving traffic handled by CPU 0
- UDP receiver running on CPU 0, using a single UDP socket.
- Incoming flood of UDP packets targeting the UDP socket.
Before the patch, the UDP receiver could almost never get CPU cycles and
could only receive ~2,000 packets per second.
After the patch, CPU cycles are split 50/50 between user application and
ksoftirqd/0, and we can effectively read ~900,000 packets per second,
a huge improvement in DOS situation. (Note that more packets are now
dropped by the NIC itself, since the BH handlers get less CPU cycles to
drain RX ring buffer)
Since the load runs in well identified threads context, an admin can
more easily tune process scheduling parameters if needed.
Reported-by: Paolo Abeni <pabeni@redhat.com>
Reported-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: David Miller <davem@davemloft.net>
Cc: Hannes Frederic Sowa <hannes@redhat.com>
Cc: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1472665349.14381.356.camel@edumazet-glaptop3.roam.corp.google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2016-09-01 01:42:29 +08:00
|
|
|
*/
|
Mark HI and TASKLET softirq synchronous
Way back in 4.9, we committed 4cd13c21b207 ("softirq: Let ksoftirqd do
its job"), and ever since we've had small nagging issues with it. For
example, we've had:
1ff688209e2e ("watchdog: core: make sure the watchdog_worker is not deferred")
8d5755b3f77b ("watchdog: softdog: fire watchdog even if softirqs do not get to run")
217f69743681 ("net: busy-poll: allow preemption in sk_busy_loop()")
all of which worked around some of the effects of that commit.
The DVB people have also complained that the commit causes excessive USB
URB latencies, which seems to be due to the USB code using tasklets to
schedule USB traffic. This seems to be an issue mainly when already
living on the edge, but waiting for ksoftirqd to handle it really does
seem to cause excessive latencies.
Now Hanna Hawa reports that this issue isn't just limited to USB URB and
DVB, but also causes timeout problems for the Marvell SoC team:
"I'm facing kernel panic issue while running raid 5 on sata disks
connected to Macchiatobin (Marvell community board with Armada-8040
SoC with 4 ARMv8 cores of CA72) Raid 5 built with Marvell DMA engine
and async_tx mechanism (ASYNC_TX_DMA [=y]); the DMA driver (mv_xor_v2)
uses a tasklet to clean the done descriptors from the queue"
The latency problem causes a panic:
mv_xor_v2 f0400000.xor: dma_sync_wait: timeout!
Kernel panic - not syncing: async_tx_quiesce: DMA error waiting for transaction
We've discussed simply just reverting the original commit entirely, and
also much more involved solutions (with per-softirq threads etc). This
patch is intentionally stupid and fairly limited, because the issue
still remains, and the other solutions either got sidetracked or had
other issues.
We should probably also consider the timer softirqs to be synchronous
and not be delayed to ksoftirqd (since they were the issue with the
earlier watchdog problems), but that should be done as a separate patch.
This does only the tasklet cases.
Reported-and-tested-by: Hanna Hawa <hannah@marvell.com>
Reported-and-tested-by: Josef Griebichler <griebichler.josef@gmx.at>
Reported-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-01-09 03:51:04 +08:00
|
|
|
#define SOFTIRQ_NOW_MASK ((1 << HI_SOFTIRQ) | (1 << TASKLET_SOFTIRQ))
|
|
|
|
static bool ksoftirqd_running(unsigned long pending)
|
softirq: Let ksoftirqd do its job
A while back, Paolo and Hannes sent an RFC patch adding threaded-able
napi poll loop support : (https://patchwork.ozlabs.org/patch/620657/)
The problem seems to be that softirqs are very aggressive and are often
handled by the current process, even if we are under stress and that
ksoftirqd was scheduled, so that innocent threads would have more chance
to make progress.
This patch makes sure that if ksoftirq is running, we let it
perform the softirq work.
Jonathan Corbet summarized the issue in https://lwn.net/Articles/687617/
Tested:
- NIC receiving traffic handled by CPU 0
- UDP receiver running on CPU 0, using a single UDP socket.
- Incoming flood of UDP packets targeting the UDP socket.
Before the patch, the UDP receiver could almost never get CPU cycles and
could only receive ~2,000 packets per second.
After the patch, CPU cycles are split 50/50 between user application and
ksoftirqd/0, and we can effectively read ~900,000 packets per second,
a huge improvement in DOS situation. (Note that more packets are now
dropped by the NIC itself, since the BH handlers get less CPU cycles to
drain RX ring buffer)
Since the load runs in well identified threads context, an admin can
more easily tune process scheduling parameters if needed.
Reported-by: Paolo Abeni <pabeni@redhat.com>
Reported-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: David Miller <davem@davemloft.net>
Cc: Hannes Frederic Sowa <hannes@redhat.com>
Cc: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1472665349.14381.356.camel@edumazet-glaptop3.roam.corp.google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2016-09-01 01:42:29 +08:00
|
|
|
{
|
|
|
|
struct task_struct *tsk = __this_cpu_read(ksoftirqd);
|
|
|
|
|
Mark HI and TASKLET softirq synchronous
Way back in 4.9, we committed 4cd13c21b207 ("softirq: Let ksoftirqd do
its job"), and ever since we've had small nagging issues with it. For
example, we've had:
1ff688209e2e ("watchdog: core: make sure the watchdog_worker is not deferred")
8d5755b3f77b ("watchdog: softdog: fire watchdog even if softirqs do not get to run")
217f69743681 ("net: busy-poll: allow preemption in sk_busy_loop()")
all of which worked around some of the effects of that commit.
The DVB people have also complained that the commit causes excessive USB
URB latencies, which seems to be due to the USB code using tasklets to
schedule USB traffic. This seems to be an issue mainly when already
living on the edge, but waiting for ksoftirqd to handle it really does
seem to cause excessive latencies.
Now Hanna Hawa reports that this issue isn't just limited to USB URB and
DVB, but also causes timeout problems for the Marvell SoC team:
"I'm facing kernel panic issue while running raid 5 on sata disks
connected to Macchiatobin (Marvell community board with Armada-8040
SoC with 4 ARMv8 cores of CA72) Raid 5 built with Marvell DMA engine
and async_tx mechanism (ASYNC_TX_DMA [=y]); the DMA driver (mv_xor_v2)
uses a tasklet to clean the done descriptors from the queue"
The latency problem causes a panic:
mv_xor_v2 f0400000.xor: dma_sync_wait: timeout!
Kernel panic - not syncing: async_tx_quiesce: DMA error waiting for transaction
We've discussed simply just reverting the original commit entirely, and
also much more involved solutions (with per-softirq threads etc). This
patch is intentionally stupid and fairly limited, because the issue
still remains, and the other solutions either got sidetracked or had
other issues.
We should probably also consider the timer softirqs to be synchronous
and not be delayed to ksoftirqd (since they were the issue with the
earlier watchdog problems), but that should be done as a separate patch.
This does only the tasklet cases.
Reported-and-tested-by: Hanna Hawa <hannah@marvell.com>
Reported-and-tested-by: Josef Griebichler <griebichler.josef@gmx.at>
Reported-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-01-09 03:51:04 +08:00
|
|
|
if (pending & SOFTIRQ_NOW_MASK)
|
|
|
|
return false;
|
2021-06-11 16:28:12 +08:00
|
|
|
return tsk && task_is_running(tsk) && !__kthread_should_park(tsk);
|
softirq: Let ksoftirqd do its job
A while back, Paolo and Hannes sent an RFC patch adding threaded-able
napi poll loop support : (https://patchwork.ozlabs.org/patch/620657/)
The problem seems to be that softirqs are very aggressive and are often
handled by the current process, even if we are under stress and that
ksoftirqd was scheduled, so that innocent threads would have more chance
to make progress.
This patch makes sure that if ksoftirq is running, we let it
perform the softirq work.
Jonathan Corbet summarized the issue in https://lwn.net/Articles/687617/
Tested:
- NIC receiving traffic handled by CPU 0
- UDP receiver running on CPU 0, using a single UDP socket.
- Incoming flood of UDP packets targeting the UDP socket.
Before the patch, the UDP receiver could almost never get CPU cycles and
could only receive ~2,000 packets per second.
After the patch, CPU cycles are split 50/50 between user application and
ksoftirqd/0, and we can effectively read ~900,000 packets per second,
a huge improvement in DOS situation. (Note that more packets are now
dropped by the NIC itself, since the BH handlers get less CPU cycles to
drain RX ring buffer)
Since the load runs in well identified threads context, an admin can
more easily tune process scheduling parameters if needed.
Reported-by: Paolo Abeni <pabeni@redhat.com>
Reported-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: David Miller <davem@davemloft.net>
Cc: Hannes Frederic Sowa <hannes@redhat.com>
Cc: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1472665349.14381.356.camel@edumazet-glaptop3.roam.corp.google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2016-09-01 01:42:29 +08:00
|
|
|
}
|
|
|
|
|
2020-11-13 22:02:18 +08:00
|
|
|
#ifdef CONFIG_TRACE_IRQFLAGS
|
|
|
|
DEFINE_PER_CPU(int, hardirqs_enabled);
|
|
|
|
DEFINE_PER_CPU(int, hardirq_context);
|
|
|
|
EXPORT_PER_CPU_SYMBOL_GPL(hardirqs_enabled);
|
|
|
|
EXPORT_PER_CPU_SYMBOL_GPL(hardirq_context);
|
|
|
|
#endif
|
|
|
|
|
2010-10-05 08:03:16 +08:00
|
|
|
/*
|
2021-03-09 16:55:56 +08:00
|
|
|
* SOFTIRQ_OFFSET usage:
|
|
|
|
*
|
|
|
|
* On !RT kernels 'count' is the preempt counter, on RT kernels this applies
|
|
|
|
* to a per CPU counter and to task::softirqs_disabled_cnt.
|
|
|
|
*
|
|
|
|
* - count is changed by SOFTIRQ_OFFSET on entering or leaving softirq
|
|
|
|
* processing.
|
|
|
|
*
|
|
|
|
* - count is changed by SOFTIRQ_DISABLE_OFFSET (= 2 * SOFTIRQ_OFFSET)
|
2010-10-05 08:03:16 +08:00
|
|
|
* on local_bh_disable or local_bh_enable.
|
2021-03-09 16:55:56 +08:00
|
|
|
*
|
2010-10-05 08:03:16 +08:00
|
|
|
* This lets us distinguish between whether we are currently processing
|
|
|
|
* softirq and whether we just have bh disabled.
|
|
|
|
*/
|
2021-03-09 16:55:56 +08:00
|
|
|
#ifdef CONFIG_PREEMPT_RT
|
|
|
|
|
|
|
|
/*
|
|
|
|
* RT accounts for BH disabled sections in task::softirqs_disabled_cnt and
|
|
|
|
* also in per CPU softirq_ctrl::cnt. This is necessary to allow tasks in a
|
|
|
|
* softirq disabled section to be preempted.
|
|
|
|
*
|
|
|
|
* The per task counter is used for softirq_count(), in_softirq() and
|
|
|
|
* in_serving_softirqs() because these counts are only valid when the task
|
|
|
|
* holding softirq_ctrl::lock is running.
|
|
|
|
*
|
|
|
|
* The per CPU counter prevents pointless wakeups of ksoftirqd in case that
|
|
|
|
* the task which is in a softirq disabled section is preempted or blocks.
|
|
|
|
*/
|
|
|
|
struct softirq_ctrl {
|
|
|
|
local_lock_t lock;
|
|
|
|
int cnt;
|
|
|
|
};
|
|
|
|
|
|
|
|
static DEFINE_PER_CPU(struct softirq_ctrl, softirq_ctrl) = {
|
|
|
|
.lock = INIT_LOCAL_LOCK(softirq_ctrl.lock),
|
|
|
|
};
|
|
|
|
|
2021-03-09 16:55:57 +08:00
|
|
|
/**
|
|
|
|
* local_bh_blocked() - Check for idle whether BH processing is blocked
|
|
|
|
*
|
|
|
|
* Returns false if the per CPU softirq::cnt is 0 otherwise true.
|
|
|
|
*
|
|
|
|
* This is invoked from the idle task to guard against false positive
|
|
|
|
* softirq pending warnings, which would happen when the task which holds
|
|
|
|
* softirq_ctrl::lock was the only running task on the CPU and blocks on
|
|
|
|
* some other lock.
|
|
|
|
*/
|
|
|
|
bool local_bh_blocked(void)
|
|
|
|
{
|
|
|
|
return __this_cpu_read(softirq_ctrl.cnt) != 0;
|
|
|
|
}
|
|
|
|
|
2021-03-09 16:55:56 +08:00
|
|
|
void __local_bh_disable_ip(unsigned long ip, unsigned int cnt)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
int newcnt;
|
|
|
|
|
|
|
|
WARN_ON_ONCE(in_hardirq());
|
|
|
|
|
|
|
|
/* First entry of a task into a BH disabled section? */
|
|
|
|
if (!current->softirq_disable_cnt) {
|
|
|
|
if (preemptible()) {
|
|
|
|
local_lock(&softirq_ctrl.lock);
|
|
|
|
/* Required to meet the RCU bottomhalf requirements. */
|
|
|
|
rcu_read_lock();
|
|
|
|
} else {
|
|
|
|
DEBUG_LOCKS_WARN_ON(this_cpu_read(softirq_ctrl.cnt));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Track the per CPU softirq disabled state. On RT this is per CPU
|
|
|
|
* state to allow preemption of bottom half disabled sections.
|
|
|
|
*/
|
|
|
|
newcnt = __this_cpu_add_return(softirq_ctrl.cnt, cnt);
|
|
|
|
/*
|
|
|
|
* Reflect the result in the task state to prevent recursion on the
|
|
|
|
* local lock and to make softirq_count() & al work.
|
|
|
|
*/
|
|
|
|
current->softirq_disable_cnt = newcnt;
|
|
|
|
|
|
|
|
if (IS_ENABLED(CONFIG_TRACE_IRQFLAGS) && newcnt == cnt) {
|
|
|
|
raw_local_irq_save(flags);
|
|
|
|
lockdep_softirqs_off(ip);
|
|
|
|
raw_local_irq_restore(flags);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(__local_bh_disable_ip);
|
|
|
|
|
|
|
|
static void __local_bh_enable(unsigned int cnt, bool unlock)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
int newcnt;
|
|
|
|
|
|
|
|
DEBUG_LOCKS_WARN_ON(current->softirq_disable_cnt !=
|
|
|
|
this_cpu_read(softirq_ctrl.cnt));
|
|
|
|
|
|
|
|
if (IS_ENABLED(CONFIG_TRACE_IRQFLAGS) && softirq_count() == cnt) {
|
|
|
|
raw_local_irq_save(flags);
|
|
|
|
lockdep_softirqs_on(_RET_IP_);
|
|
|
|
raw_local_irq_restore(flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
newcnt = __this_cpu_sub_return(softirq_ctrl.cnt, cnt);
|
|
|
|
current->softirq_disable_cnt = newcnt;
|
|
|
|
|
|
|
|
if (!newcnt && unlock) {
|
|
|
|
rcu_read_unlock();
|
|
|
|
local_unlock(&softirq_ctrl.lock);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void __local_bh_enable_ip(unsigned long ip, unsigned int cnt)
|
|
|
|
{
|
|
|
|
bool preempt_on = preemptible();
|
|
|
|
unsigned long flags;
|
|
|
|
u32 pending;
|
|
|
|
int curcnt;
|
|
|
|
|
2022-01-28 19:07:27 +08:00
|
|
|
WARN_ON_ONCE(in_hardirq());
|
2021-03-09 16:55:56 +08:00
|
|
|
lockdep_assert_irqs_enabled();
|
|
|
|
|
|
|
|
local_irq_save(flags);
|
|
|
|
curcnt = __this_cpu_read(softirq_ctrl.cnt);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If this is not reenabling soft interrupts, no point in trying to
|
|
|
|
* run pending ones.
|
|
|
|
*/
|
|
|
|
if (curcnt != cnt)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
pending = local_softirq_pending();
|
|
|
|
if (!pending || ksoftirqd_running(pending))
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If this was called from non preemptible context, wake up the
|
|
|
|
* softirq daemon.
|
|
|
|
*/
|
|
|
|
if (!preempt_on) {
|
|
|
|
wakeup_softirqd();
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Adjust softirq count to SOFTIRQ_OFFSET which makes
|
|
|
|
* in_serving_softirq() become true.
|
|
|
|
*/
|
|
|
|
cnt = SOFTIRQ_OFFSET;
|
|
|
|
__local_bh_enable(cnt, false);
|
|
|
|
__do_softirq();
|
|
|
|
|
|
|
|
out:
|
|
|
|
__local_bh_enable(cnt, preempt_on);
|
|
|
|
local_irq_restore(flags);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(__local_bh_enable_ip);
|
2010-10-05 08:03:16 +08:00
|
|
|
|
2006-07-03 15:24:42 +08:00
|
|
|
/*
|
2021-03-09 16:55:56 +08:00
|
|
|
* Invoked from ksoftirqd_run() outside of the interrupt disabled section
|
|
|
|
* to acquire the per CPU local lock for reentrancy protection.
|
|
|
|
*/
|
|
|
|
static inline void ksoftirqd_run_begin(void)
|
|
|
|
{
|
|
|
|
__local_bh_disable_ip(_RET_IP_, SOFTIRQ_OFFSET);
|
|
|
|
local_irq_disable();
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Counterpart to ksoftirqd_run_begin() */
|
|
|
|
static inline void ksoftirqd_run_end(void)
|
|
|
|
{
|
|
|
|
__local_bh_enable(SOFTIRQ_OFFSET, true);
|
|
|
|
WARN_ON_ONCE(in_interrupt());
|
|
|
|
local_irq_enable();
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void softirq_handle_begin(void) { }
|
|
|
|
static inline void softirq_handle_end(void) { }
|
|
|
|
|
|
|
|
static inline bool should_wake_ksoftirqd(void)
|
|
|
|
{
|
|
|
|
return !this_cpu_read(softirq_ctrl.cnt);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void invoke_softirq(void)
|
|
|
|
{
|
|
|
|
if (should_wake_ksoftirqd())
|
|
|
|
wakeup_softirqd();
|
|
|
|
}
|
|
|
|
|
2022-04-13 21:31:05 +08:00
|
|
|
/*
|
|
|
|
* flush_smp_call_function_queue() can raise a soft interrupt in a function
|
|
|
|
* call. On RT kernels this is undesired and the only known functionality
|
|
|
|
* in the block layer which does this is disabled on RT. If soft interrupts
|
|
|
|
* get raised which haven't been raised before the flush, warn so it can be
|
|
|
|
* investigated.
|
|
|
|
*/
|
|
|
|
void do_softirq_post_smp_call_flush(unsigned int was_pending)
|
|
|
|
{
|
|
|
|
if (WARN_ON_ONCE(was_pending != local_softirq_pending()))
|
|
|
|
invoke_softirq();
|
|
|
|
}
|
|
|
|
|
2021-03-09 16:55:56 +08:00
|
|
|
#else /* CONFIG_PREEMPT_RT */
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This one is for softirq.c-internal use, where hardirqs are disabled
|
2020-11-13 22:02:18 +08:00
|
|
|
* legitimately:
|
2006-07-03 15:24:42 +08:00
|
|
|
*/
|
2021-03-09 16:55:56 +08:00
|
|
|
#ifdef CONFIG_TRACE_IRQFLAGS
|
2013-11-19 23:13:38 +08:00
|
|
|
void __local_bh_disable_ip(unsigned long ip, unsigned int cnt)
|
2006-07-03 15:24:42 +08:00
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
2022-01-28 19:07:27 +08:00
|
|
|
WARN_ON_ONCE(in_hardirq());
|
2006-07-03 15:24:42 +08:00
|
|
|
|
|
|
|
raw_local_irq_save(flags);
|
2009-01-23 08:01:40 +08:00
|
|
|
/*
|
2013-09-10 18:15:23 +08:00
|
|
|
* The preempt tracer hooks into preempt_count_add and will break
|
2009-01-23 08:01:40 +08:00
|
|
|
* lockdep because it calls back into lockdep after SOFTIRQ_OFFSET
|
|
|
|
* is set and before current->softirq_enabled is cleared.
|
|
|
|
* We must manually increment preempt_count here and manually
|
|
|
|
* call the trace_preempt_off later.
|
|
|
|
*/
|
2013-09-10 18:15:23 +08:00
|
|
|
__preempt_count_add(cnt);
|
2006-07-03 15:24:42 +08:00
|
|
|
/*
|
|
|
|
* Were softirqs turned off above:
|
|
|
|
*/
|
2013-11-19 23:13:38 +08:00
|
|
|
if (softirq_count() == (cnt & SOFTIRQ_MASK))
|
2020-03-20 19:56:41 +08:00
|
|
|
lockdep_softirqs_off(ip);
|
2006-07-03 15:24:42 +08:00
|
|
|
raw_local_irq_restore(flags);
|
2009-01-23 08:01:40 +08:00
|
|
|
|
2015-01-07 17:04:41 +08:00
|
|
|
if (preempt_count() == cnt) {
|
|
|
|
#ifdef CONFIG_DEBUG_PREEMPT
|
2016-02-26 21:54:56 +08:00
|
|
|
current->preempt_disable_ip = get_lock_parent_ip();
|
2015-01-07 17:04:41 +08:00
|
|
|
#endif
|
2016-02-26 21:54:56 +08:00
|
|
|
trace_preempt_off(CALLER_ADDR0, get_lock_parent_ip());
|
2015-01-07 17:04:41 +08:00
|
|
|
}
|
2006-07-03 15:24:42 +08:00
|
|
|
}
|
2013-11-19 23:13:38 +08:00
|
|
|
EXPORT_SYMBOL(__local_bh_disable_ip);
|
2006-07-30 18:04:02 +08:00
|
|
|
#endif /* CONFIG_TRACE_IRQFLAGS */
|
2006-07-03 15:24:42 +08:00
|
|
|
|
2010-10-05 08:03:16 +08:00
|
|
|
static void __local_bh_enable(unsigned int cnt)
|
|
|
|
{
|
2017-11-06 23:01:18 +08:00
|
|
|
lockdep_assert_irqs_disabled();
|
2010-10-05 08:03:16 +08:00
|
|
|
|
2018-06-08 04:11:43 +08:00
|
|
|
if (preempt_count() == cnt)
|
|
|
|
trace_preempt_on(CALLER_ADDR0, get_lock_parent_ip());
|
|
|
|
|
2013-11-19 23:13:38 +08:00
|
|
|
if (softirq_count() == (cnt & SOFTIRQ_MASK))
|
2020-03-20 19:56:41 +08:00
|
|
|
lockdep_softirqs_on(_RET_IP_);
|
2018-06-08 04:11:43 +08:00
|
|
|
|
|
|
|
__preempt_count_sub(cnt);
|
2010-10-05 08:03:16 +08:00
|
|
|
}
|
|
|
|
|
2006-07-03 15:24:42 +08:00
|
|
|
/*
|
2018-03-06 03:29:40 +08:00
|
|
|
* Special-case - softirqs can safely be enabled by __do_softirq(),
|
2006-07-03 15:24:42 +08:00
|
|
|
* without processing still-pending softirqs:
|
|
|
|
*/
|
|
|
|
void _local_bh_enable(void)
|
|
|
|
{
|
2022-01-28 19:07:27 +08:00
|
|
|
WARN_ON_ONCE(in_hardirq());
|
2010-10-05 08:03:16 +08:00
|
|
|
__local_bh_enable(SOFTIRQ_DISABLE_OFFSET);
|
2006-07-03 15:24:42 +08:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(_local_bh_enable);
|
|
|
|
|
2013-11-19 23:13:38 +08:00
|
|
|
void __local_bh_enable_ip(unsigned long ip, unsigned int cnt)
|
2006-07-03 15:24:42 +08:00
|
|
|
{
|
2022-01-28 19:07:27 +08:00
|
|
|
WARN_ON_ONCE(in_hardirq());
|
2017-11-06 23:01:18 +08:00
|
|
|
lockdep_assert_irqs_enabled();
|
2006-07-30 18:04:02 +08:00
|
|
|
#ifdef CONFIG_TRACE_IRQFLAGS
|
2008-06-18 15:29:37 +08:00
|
|
|
local_irq_disable();
|
2006-07-30 18:04:02 +08:00
|
|
|
#endif
|
2006-07-03 15:24:42 +08:00
|
|
|
/*
|
|
|
|
* Are softirqs going to be turned on now:
|
|
|
|
*/
|
2010-10-05 08:03:16 +08:00
|
|
|
if (softirq_count() == SOFTIRQ_DISABLE_OFFSET)
|
2020-03-20 19:56:41 +08:00
|
|
|
lockdep_softirqs_on(ip);
|
2006-07-03 15:24:42 +08:00
|
|
|
/*
|
|
|
|
* Keep preemption disabled until we are done with
|
|
|
|
* softirq processing:
|
2014-01-28 09:07:16 +08:00
|
|
|
*/
|
2020-12-18 23:39:14 +08:00
|
|
|
__preempt_count_sub(cnt - 1);
|
2006-07-03 15:24:42 +08:00
|
|
|
|
2013-09-05 22:14:00 +08:00
|
|
|
if (unlikely(!in_interrupt() && local_softirq_pending())) {
|
|
|
|
/*
|
|
|
|
* Run softirq if any pending. And do it in its own stack
|
|
|
|
* as we may be calling this deep in a task call stack already.
|
|
|
|
*/
|
2006-07-03 15:24:42 +08:00
|
|
|
do_softirq();
|
2013-09-05 22:14:00 +08:00
|
|
|
}
|
2006-07-03 15:24:42 +08:00
|
|
|
|
2013-09-10 18:15:23 +08:00
|
|
|
preempt_count_dec();
|
2006-07-30 18:04:02 +08:00
|
|
|
#ifdef CONFIG_TRACE_IRQFLAGS
|
2008-06-18 15:29:37 +08:00
|
|
|
local_irq_enable();
|
2006-07-30 18:04:02 +08:00
|
|
|
#endif
|
2006-07-03 15:24:42 +08:00
|
|
|
preempt_check_resched();
|
|
|
|
}
|
2013-11-19 23:13:38 +08:00
|
|
|
EXPORT_SYMBOL(__local_bh_enable_ip);
|
2006-07-03 15:24:42 +08:00
|
|
|
|
2021-03-09 16:55:55 +08:00
|
|
|
static inline void softirq_handle_begin(void)
|
|
|
|
{
|
|
|
|
__local_bh_disable_ip(_RET_IP_, SOFTIRQ_OFFSET);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void softirq_handle_end(void)
|
|
|
|
{
|
|
|
|
__local_bh_enable(SOFTIRQ_OFFSET);
|
|
|
|
WARN_ON_ONCE(in_interrupt());
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void ksoftirqd_run_begin(void)
|
|
|
|
{
|
|
|
|
local_irq_disable();
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void ksoftirqd_run_end(void)
|
|
|
|
{
|
|
|
|
local_irq_enable();
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool should_wake_ksoftirqd(void)
|
|
|
|
{
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2020-11-13 22:02:18 +08:00
|
|
|
static inline void invoke_softirq(void)
|
|
|
|
{
|
|
|
|
if (ksoftirqd_running(local_softirq_pending()))
|
|
|
|
return;
|
|
|
|
|
2021-06-03 02:03:38 +08:00
|
|
|
if (!force_irqthreads() || !__this_cpu_read(ksoftirqd)) {
|
2020-11-13 22:02:18 +08:00
|
|
|
#ifdef CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK
|
|
|
|
/*
|
|
|
|
* We can safely execute softirq on the current stack if
|
|
|
|
* it is the irq stack, because it should be near empty
|
|
|
|
* at this stage.
|
|
|
|
*/
|
|
|
|
__do_softirq();
|
|
|
|
#else
|
|
|
|
/*
|
|
|
|
* Otherwise, irq_exit() is called on the task stack that can
|
|
|
|
* be potentially deep already. So call softirq in its own stack
|
|
|
|
* to prevent from any overrun.
|
|
|
|
*/
|
|
|
|
do_softirq_own_stack();
|
|
|
|
#endif
|
|
|
|
} else {
|
|
|
|
wakeup_softirqd();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
asmlinkage __visible void do_softirq(void)
|
|
|
|
{
|
|
|
|
__u32 pending;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (in_interrupt())
|
|
|
|
return;
|
|
|
|
|
|
|
|
local_irq_save(flags);
|
|
|
|
|
|
|
|
pending = local_softirq_pending();
|
|
|
|
|
|
|
|
if (pending && !ksoftirqd_running(pending))
|
|
|
|
do_softirq_own_stack();
|
|
|
|
|
|
|
|
local_irq_restore(flags);
|
|
|
|
}
|
|
|
|
|
2021-03-09 16:55:56 +08:00
|
|
|
#endif /* !CONFIG_PREEMPT_RT */
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
2013-06-07 05:29:49 +08:00
|
|
|
* We restart softirq processing for at most MAX_SOFTIRQ_RESTART times,
|
|
|
|
* but break the loop if need_resched() is set or after 2 ms.
|
|
|
|
* The MAX_SOFTIRQ_TIME provides a nice upper bound in most cases, but in
|
|
|
|
* certain cases, such as stop_machine(), jiffies may cease to
|
|
|
|
* increment and so we need the MAX_SOFTIRQ_RESTART limit as
|
|
|
|
* well to make sure we eventually return from this method.
|
2005-04-17 06:20:36 +08:00
|
|
|
*
|
softirq: reduce latencies
In various network workloads, __do_softirq() latencies can be up
to 20 ms if HZ=1000, and 200 ms if HZ=100.
This is because we iterate 10 times in the softirq dispatcher,
and some actions can consume a lot of cycles.
This patch changes the fallback to ksoftirqd condition to :
- A time limit of 2 ms.
- need_resched() being set on current task
When one of this condition is met, we wakeup ksoftirqd for further
softirq processing if we still have pending softirqs.
Using need_resched() as the only condition can trigger RCU stalls,
as we can keep BH disabled for too long.
I ran several benchmarks and got no significant difference in
throughput, but a very significant reduction of latencies (one order
of magnitude) :
In following bench, 200 antagonist "netperf -t TCP_RR" are started in
background, using all available cpus.
Then we start one "netperf -t TCP_RR", bound to the cpu handling the NIC
IRQ (hard+soft)
Before patch :
# netperf -H 7.7.7.84 -t TCP_RR -T2,2 -- -k
RT_LATENCY,MIN_LATENCY,MAX_LATENCY,P50_LATENCY,P90_LATENCY,P99_LATENCY,MEAN_LATENCY,STDDEV_LATENCY
MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET
to 7.7.7.84 () port 0 AF_INET : first burst 0 : cpu bind
RT_LATENCY=550110.424
MIN_LATENCY=146858
MAX_LATENCY=997109
P50_LATENCY=305000
P90_LATENCY=550000
P99_LATENCY=710000
MEAN_LATENCY=376989.12
STDDEV_LATENCY=184046.92
After patch :
# netperf -H 7.7.7.84 -t TCP_RR -T2,2 -- -k
RT_LATENCY,MIN_LATENCY,MAX_LATENCY,P50_LATENCY,P90_LATENCY,P99_LATENCY,MEAN_LATENCY,STDDEV_LATENCY
MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET
to 7.7.7.84 () port 0 AF_INET : first burst 0 : cpu bind
RT_LATENCY=40545.492
MIN_LATENCY=9834
MAX_LATENCY=78366
P50_LATENCY=33583
P90_LATENCY=59000
P99_LATENCY=69000
MEAN_LATENCY=38364.67
STDDEV_LATENCY=12865.26
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>
Cc: Tom Herbert <therbert@google.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-01-11 07:26:34 +08:00
|
|
|
* These limits have been established via experimentation.
|
2005-04-17 06:20:36 +08:00
|
|
|
* The two things to balance is latency against fairness -
|
|
|
|
* we want to handle softirqs as soon as possible, but they
|
|
|
|
* should not be able to lock up the box.
|
|
|
|
*/
|
softirq: reduce latencies
In various network workloads, __do_softirq() latencies can be up
to 20 ms if HZ=1000, and 200 ms if HZ=100.
This is because we iterate 10 times in the softirq dispatcher,
and some actions can consume a lot of cycles.
This patch changes the fallback to ksoftirqd condition to :
- A time limit of 2 ms.
- need_resched() being set on current task
When one of this condition is met, we wakeup ksoftirqd for further
softirq processing if we still have pending softirqs.
Using need_resched() as the only condition can trigger RCU stalls,
as we can keep BH disabled for too long.
I ran several benchmarks and got no significant difference in
throughput, but a very significant reduction of latencies (one order
of magnitude) :
In following bench, 200 antagonist "netperf -t TCP_RR" are started in
background, using all available cpus.
Then we start one "netperf -t TCP_RR", bound to the cpu handling the NIC
IRQ (hard+soft)
Before patch :
# netperf -H 7.7.7.84 -t TCP_RR -T2,2 -- -k
RT_LATENCY,MIN_LATENCY,MAX_LATENCY,P50_LATENCY,P90_LATENCY,P99_LATENCY,MEAN_LATENCY,STDDEV_LATENCY
MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET
to 7.7.7.84 () port 0 AF_INET : first burst 0 : cpu bind
RT_LATENCY=550110.424
MIN_LATENCY=146858
MAX_LATENCY=997109
P50_LATENCY=305000
P90_LATENCY=550000
P99_LATENCY=710000
MEAN_LATENCY=376989.12
STDDEV_LATENCY=184046.92
After patch :
# netperf -H 7.7.7.84 -t TCP_RR -T2,2 -- -k
RT_LATENCY,MIN_LATENCY,MAX_LATENCY,P50_LATENCY,P90_LATENCY,P99_LATENCY,MEAN_LATENCY,STDDEV_LATENCY
MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET
to 7.7.7.84 () port 0 AF_INET : first burst 0 : cpu bind
RT_LATENCY=40545.492
MIN_LATENCY=9834
MAX_LATENCY=78366
P50_LATENCY=33583
P90_LATENCY=59000
P99_LATENCY=69000
MEAN_LATENCY=38364.67
STDDEV_LATENCY=12865.26
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>
Cc: Tom Herbert <therbert@google.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-01-11 07:26:34 +08:00
|
|
|
#define MAX_SOFTIRQ_TIME msecs_to_jiffies(2)
|
2013-06-07 05:29:49 +08:00
|
|
|
#define MAX_SOFTIRQ_RESTART 10
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2013-11-19 23:42:47 +08:00
|
|
|
#ifdef CONFIG_TRACE_IRQFLAGS
|
|
|
|
/*
|
|
|
|
* When we run softirqs from irq_exit() and thus on the hardirq stack we need
|
|
|
|
* to keep the lockdep irq context tracking as tight as possible in order to
|
|
|
|
* not miss-qualify lock contexts and miss possible deadlocks.
|
|
|
|
*/
|
|
|
|
|
2013-11-20 08:07:34 +08:00
|
|
|
static inline bool lockdep_softirq_start(void)
|
2013-11-19 23:42:47 +08:00
|
|
|
{
|
2013-11-20 08:07:34 +08:00
|
|
|
bool in_hardirq = false;
|
2013-11-19 23:42:47 +08:00
|
|
|
|
2020-05-27 19:03:26 +08:00
|
|
|
if (lockdep_hardirq_context()) {
|
2013-11-20 08:07:34 +08:00
|
|
|
in_hardirq = true;
|
2020-03-20 19:56:40 +08:00
|
|
|
lockdep_hardirq_exit();
|
2013-11-20 08:07:34 +08:00
|
|
|
}
|
|
|
|
|
2013-11-19 23:42:47 +08:00
|
|
|
lockdep_softirq_enter();
|
2013-11-20 08:07:34 +08:00
|
|
|
|
|
|
|
return in_hardirq;
|
2013-11-19 23:42:47 +08:00
|
|
|
}
|
|
|
|
|
2013-11-20 08:07:34 +08:00
|
|
|
static inline void lockdep_softirq_end(bool in_hardirq)
|
2013-11-19 23:42:47 +08:00
|
|
|
{
|
|
|
|
lockdep_softirq_exit();
|
2013-11-20 08:07:34 +08:00
|
|
|
|
|
|
|
if (in_hardirq)
|
2020-03-20 19:56:40 +08:00
|
|
|
lockdep_hardirq_enter();
|
2013-11-19 23:42:47 +08:00
|
|
|
}
|
|
|
|
#else
|
2013-11-20 08:07:34 +08:00
|
|
|
static inline bool lockdep_softirq_start(void) { return false; }
|
|
|
|
static inline void lockdep_softirq_end(bool in_hardirq) { }
|
2013-11-19 23:42:47 +08:00
|
|
|
#endif
|
|
|
|
|
2016-03-26 05:22:05 +08:00
|
|
|
asmlinkage __visible void __softirq_entry __do_softirq(void)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
softirq: reduce latencies
In various network workloads, __do_softirq() latencies can be up
to 20 ms if HZ=1000, and 200 ms if HZ=100.
This is because we iterate 10 times in the softirq dispatcher,
and some actions can consume a lot of cycles.
This patch changes the fallback to ksoftirqd condition to :
- A time limit of 2 ms.
- need_resched() being set on current task
When one of this condition is met, we wakeup ksoftirqd for further
softirq processing if we still have pending softirqs.
Using need_resched() as the only condition can trigger RCU stalls,
as we can keep BH disabled for too long.
I ran several benchmarks and got no significant difference in
throughput, but a very significant reduction of latencies (one order
of magnitude) :
In following bench, 200 antagonist "netperf -t TCP_RR" are started in
background, using all available cpus.
Then we start one "netperf -t TCP_RR", bound to the cpu handling the NIC
IRQ (hard+soft)
Before patch :
# netperf -H 7.7.7.84 -t TCP_RR -T2,2 -- -k
RT_LATENCY,MIN_LATENCY,MAX_LATENCY,P50_LATENCY,P90_LATENCY,P99_LATENCY,MEAN_LATENCY,STDDEV_LATENCY
MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET
to 7.7.7.84 () port 0 AF_INET : first burst 0 : cpu bind
RT_LATENCY=550110.424
MIN_LATENCY=146858
MAX_LATENCY=997109
P50_LATENCY=305000
P90_LATENCY=550000
P99_LATENCY=710000
MEAN_LATENCY=376989.12
STDDEV_LATENCY=184046.92
After patch :
# netperf -H 7.7.7.84 -t TCP_RR -T2,2 -- -k
RT_LATENCY,MIN_LATENCY,MAX_LATENCY,P50_LATENCY,P90_LATENCY,P99_LATENCY,MEAN_LATENCY,STDDEV_LATENCY
MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET
to 7.7.7.84 () port 0 AF_INET : first burst 0 : cpu bind
RT_LATENCY=40545.492
MIN_LATENCY=9834
MAX_LATENCY=78366
P50_LATENCY=33583
P90_LATENCY=59000
P99_LATENCY=69000
MEAN_LATENCY=38364.67
STDDEV_LATENCY=12865.26
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>
Cc: Tom Herbert <therbert@google.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-01-11 07:26:34 +08:00
|
|
|
unsigned long end = jiffies + MAX_SOFTIRQ_TIME;
|
2012-08-01 07:44:07 +08:00
|
|
|
unsigned long old_flags = current->flags;
|
2013-06-07 05:29:49 +08:00
|
|
|
int max_restart = MAX_SOFTIRQ_RESTART;
|
2013-11-19 23:42:47 +08:00
|
|
|
struct softirq_action *h;
|
2013-11-20 08:07:34 +08:00
|
|
|
bool in_hardirq;
|
2013-11-19 23:42:47 +08:00
|
|
|
__u32 pending;
|
2014-01-28 09:07:14 +08:00
|
|
|
int softirq_bit;
|
2012-08-01 07:44:07 +08:00
|
|
|
|
|
|
|
/*
|
2018-10-18 22:21:33 +08:00
|
|
|
* Mask out PF_MEMALLOC as the current task context is borrowed for the
|
|
|
|
* softirq. A softirq handled, such as network RX, might set PF_MEMALLOC
|
|
|
|
* again if the socket is related to swapping.
|
2012-08-01 07:44:07 +08:00
|
|
|
*/
|
|
|
|
current->flags &= ~PF_MEMALLOC;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
pending = local_softirq_pending();
|
2006-07-03 15:25:40 +08:00
|
|
|
|
2021-03-09 16:55:55 +08:00
|
|
|
softirq_handle_begin();
|
2013-11-20 08:07:34 +08:00
|
|
|
in_hardirq = lockdep_softirq_start();
|
2020-12-02 19:57:31 +08:00
|
|
|
account_softirq_enter(current);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
restart:
|
|
|
|
/* Reset the pending bitmask before enabling irqs */
|
2005-09-13 00:49:24 +08:00
|
|
|
set_softirq_pending(0);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2005-07-31 01:22:49 +08:00
|
|
|
local_irq_enable();
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
h = softirq_vec;
|
|
|
|
|
2014-01-28 09:07:14 +08:00
|
|
|
while ((softirq_bit = ffs(pending))) {
|
|
|
|
unsigned int vec_nr;
|
|
|
|
int prev_count;
|
|
|
|
|
|
|
|
h += softirq_bit - 1;
|
|
|
|
|
|
|
|
vec_nr = h - softirq_vec;
|
|
|
|
prev_count = preempt_count();
|
|
|
|
|
|
|
|
kstat_incr_softirqs_this_cpu(vec_nr);
|
|
|
|
|
|
|
|
trace_softirq_entry(vec_nr);
|
|
|
|
h->action(h);
|
|
|
|
trace_softirq_exit(vec_nr);
|
|
|
|
if (unlikely(prev_count != preempt_count())) {
|
2014-01-28 09:07:15 +08:00
|
|
|
pr_err("huh, entered softirq %u %s %p with preempt_count %08x, exited with %08x?\n",
|
2014-01-28 09:07:14 +08:00
|
|
|
vec_nr, softirq_to_name[vec_nr], h->action,
|
|
|
|
prev_count, preempt_count());
|
|
|
|
preempt_count_set(prev_count);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
h++;
|
2014-01-28 09:07:14 +08:00
|
|
|
pending >>= softirq_bit;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2021-03-09 16:55:56 +08:00
|
|
|
if (!IS_ENABLED(CONFIG_PREEMPT_RT) &&
|
|
|
|
__this_cpu_read(ksoftirqd) == current)
|
2018-06-29 05:45:25 +08:00
|
|
|
rcu_softirq_qs();
|
2021-03-09 16:55:56 +08:00
|
|
|
|
2005-07-31 01:22:49 +08:00
|
|
|
local_irq_disable();
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
pending = local_softirq_pending();
|
softirq: reduce latencies
In various network workloads, __do_softirq() latencies can be up
to 20 ms if HZ=1000, and 200 ms if HZ=100.
This is because we iterate 10 times in the softirq dispatcher,
and some actions can consume a lot of cycles.
This patch changes the fallback to ksoftirqd condition to :
- A time limit of 2 ms.
- need_resched() being set on current task
When one of this condition is met, we wakeup ksoftirqd for further
softirq processing if we still have pending softirqs.
Using need_resched() as the only condition can trigger RCU stalls,
as we can keep BH disabled for too long.
I ran several benchmarks and got no significant difference in
throughput, but a very significant reduction of latencies (one order
of magnitude) :
In following bench, 200 antagonist "netperf -t TCP_RR" are started in
background, using all available cpus.
Then we start one "netperf -t TCP_RR", bound to the cpu handling the NIC
IRQ (hard+soft)
Before patch :
# netperf -H 7.7.7.84 -t TCP_RR -T2,2 -- -k
RT_LATENCY,MIN_LATENCY,MAX_LATENCY,P50_LATENCY,P90_LATENCY,P99_LATENCY,MEAN_LATENCY,STDDEV_LATENCY
MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET
to 7.7.7.84 () port 0 AF_INET : first burst 0 : cpu bind
RT_LATENCY=550110.424
MIN_LATENCY=146858
MAX_LATENCY=997109
P50_LATENCY=305000
P90_LATENCY=550000
P99_LATENCY=710000
MEAN_LATENCY=376989.12
STDDEV_LATENCY=184046.92
After patch :
# netperf -H 7.7.7.84 -t TCP_RR -T2,2 -- -k
RT_LATENCY,MIN_LATENCY,MAX_LATENCY,P50_LATENCY,P90_LATENCY,P99_LATENCY,MEAN_LATENCY,STDDEV_LATENCY
MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET
to 7.7.7.84 () port 0 AF_INET : first burst 0 : cpu bind
RT_LATENCY=40545.492
MIN_LATENCY=9834
MAX_LATENCY=78366
P50_LATENCY=33583
P90_LATENCY=59000
P99_LATENCY=69000
MEAN_LATENCY=38364.67
STDDEV_LATENCY=12865.26
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>
Cc: Tom Herbert <therbert@google.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-01-11 07:26:34 +08:00
|
|
|
if (pending) {
|
2013-06-07 05:29:49 +08:00
|
|
|
if (time_before(jiffies, end) && !need_resched() &&
|
|
|
|
--max_restart)
|
softirq: reduce latencies
In various network workloads, __do_softirq() latencies can be up
to 20 ms if HZ=1000, and 200 ms if HZ=100.
This is because we iterate 10 times in the softirq dispatcher,
and some actions can consume a lot of cycles.
This patch changes the fallback to ksoftirqd condition to :
- A time limit of 2 ms.
- need_resched() being set on current task
When one of this condition is met, we wakeup ksoftirqd for further
softirq processing if we still have pending softirqs.
Using need_resched() as the only condition can trigger RCU stalls,
as we can keep BH disabled for too long.
I ran several benchmarks and got no significant difference in
throughput, but a very significant reduction of latencies (one order
of magnitude) :
In following bench, 200 antagonist "netperf -t TCP_RR" are started in
background, using all available cpus.
Then we start one "netperf -t TCP_RR", bound to the cpu handling the NIC
IRQ (hard+soft)
Before patch :
# netperf -H 7.7.7.84 -t TCP_RR -T2,2 -- -k
RT_LATENCY,MIN_LATENCY,MAX_LATENCY,P50_LATENCY,P90_LATENCY,P99_LATENCY,MEAN_LATENCY,STDDEV_LATENCY
MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET
to 7.7.7.84 () port 0 AF_INET : first burst 0 : cpu bind
RT_LATENCY=550110.424
MIN_LATENCY=146858
MAX_LATENCY=997109
P50_LATENCY=305000
P90_LATENCY=550000
P99_LATENCY=710000
MEAN_LATENCY=376989.12
STDDEV_LATENCY=184046.92
After patch :
# netperf -H 7.7.7.84 -t TCP_RR -T2,2 -- -k
RT_LATENCY,MIN_LATENCY,MAX_LATENCY,P50_LATENCY,P90_LATENCY,P99_LATENCY,MEAN_LATENCY,STDDEV_LATENCY
MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET
to 7.7.7.84 () port 0 AF_INET : first burst 0 : cpu bind
RT_LATENCY=40545.492
MIN_LATENCY=9834
MAX_LATENCY=78366
P50_LATENCY=33583
P90_LATENCY=59000
P99_LATENCY=69000
MEAN_LATENCY=38364.67
STDDEV_LATENCY=12865.26
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>
Cc: Tom Herbert <therbert@google.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-01-11 07:26:34 +08:00
|
|
|
goto restart;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
wakeup_softirqd();
|
softirq: reduce latencies
In various network workloads, __do_softirq() latencies can be up
to 20 ms if HZ=1000, and 200 ms if HZ=100.
This is because we iterate 10 times in the softirq dispatcher,
and some actions can consume a lot of cycles.
This patch changes the fallback to ksoftirqd condition to :
- A time limit of 2 ms.
- need_resched() being set on current task
When one of this condition is met, we wakeup ksoftirqd for further
softirq processing if we still have pending softirqs.
Using need_resched() as the only condition can trigger RCU stalls,
as we can keep BH disabled for too long.
I ran several benchmarks and got no significant difference in
throughput, but a very significant reduction of latencies (one order
of magnitude) :
In following bench, 200 antagonist "netperf -t TCP_RR" are started in
background, using all available cpus.
Then we start one "netperf -t TCP_RR", bound to the cpu handling the NIC
IRQ (hard+soft)
Before patch :
# netperf -H 7.7.7.84 -t TCP_RR -T2,2 -- -k
RT_LATENCY,MIN_LATENCY,MAX_LATENCY,P50_LATENCY,P90_LATENCY,P99_LATENCY,MEAN_LATENCY,STDDEV_LATENCY
MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET
to 7.7.7.84 () port 0 AF_INET : first burst 0 : cpu bind
RT_LATENCY=550110.424
MIN_LATENCY=146858
MAX_LATENCY=997109
P50_LATENCY=305000
P90_LATENCY=550000
P99_LATENCY=710000
MEAN_LATENCY=376989.12
STDDEV_LATENCY=184046.92
After patch :
# netperf -H 7.7.7.84 -t TCP_RR -T2,2 -- -k
RT_LATENCY,MIN_LATENCY,MAX_LATENCY,P50_LATENCY,P90_LATENCY,P99_LATENCY,MEAN_LATENCY,STDDEV_LATENCY
MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET
to 7.7.7.84 () port 0 AF_INET : first burst 0 : cpu bind
RT_LATENCY=40545.492
MIN_LATENCY=9834
MAX_LATENCY=78366
P50_LATENCY=33583
P90_LATENCY=59000
P99_LATENCY=69000
MEAN_LATENCY=38364.67
STDDEV_LATENCY=12865.26
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>
Cc: Tom Herbert <therbert@google.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-01-11 07:26:34 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2020-12-02 19:57:31 +08:00
|
|
|
account_softirq_exit(current);
|
2013-11-20 08:07:34 +08:00
|
|
|
lockdep_softirq_end(in_hardirq);
|
2021-03-09 16:55:55 +08:00
|
|
|
softirq_handle_end();
|
2017-04-07 08:03:26 +08:00
|
|
|
current_restore_flags(old_flags, PF_MEMALLOC);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2020-05-22 04:05:21 +08:00
|
|
|
/**
|
|
|
|
* irq_enter_rcu - Enter an interrupt context with RCU watching
|
2007-02-16 17:27:45 +08:00
|
|
|
*/
|
2020-05-22 04:05:21 +08:00
|
|
|
void irq_enter_rcu(void)
|
2007-02-16 17:27:45 +08:00
|
|
|
{
|
2020-12-02 19:57:32 +08:00
|
|
|
__irq_enter_raw();
|
|
|
|
|
timers/nohz: Last resort update jiffies on nohz_full IRQ entry
When at least one CPU runs in nohz_full mode, a dedicated timekeeper CPU
is guaranteed to stay online and to never stop its tick.
Meanwhile on some rare case, the dedicated timekeeper may be running
with interrupts disabled for a while, such as in stop_machine.
If jiffies stop being updated, a nohz_full CPU may end up endlessly
programming the next tick in the past, taking the last jiffies update
monotonic timestamp as a stale base, resulting in an tick storm.
Here is a scenario where it matters:
0) CPU 0 is the timekeeper and CPU 1 a nohz_full CPU.
1) A stop machine callback is queued to execute somewhere.
2) CPU 0 reaches MULTI_STOP_DISABLE_IRQ while CPU 1 is still in
MULTI_STOP_PREPARE. Hence CPU 0 can't do its timekeeping duty. CPU 1
can still take IRQs.
3) CPU 1 receives an IRQ which queues a timer callback one jiffy forward.
4) On IRQ exit, CPU 1 schedules the tick one jiffy forward, taking
last_jiffies_update as a base. But last_jiffies_update hasn't been
updated for 2 jiffies since the timekeeper has interrupts disabled.
5) clockevents_program_event(), which relies on ktime_get(), observes
that the expiration is in the past and therefore programs the min
delta event on the clock.
6) The tick fires immediately, goto 3)
7) Tick storm, the nohz_full CPU is drown and takes ages to reach
MULTI_STOP_DISABLE_IRQ, which is the only way out of this situation.
Solve this with unconditionally updating jiffies if the value is stale
on nohz_full IRQ entry. IRQs and other disturbances are expected to be
rare enough on nohz_full for the unconditional call to ktime_get() to
actually matter.
Reported-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Paul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/r/20211026141055.57358-2-frederic@kernel.org
2021-10-26 22:10:54 +08:00
|
|
|
if (tick_nohz_full_cpu(smp_processor_id()) ||
|
|
|
|
(is_idle_task(current) && (irq_count() == HARDIRQ_OFFSET)))
|
2013-12-05 01:28:20 +08:00
|
|
|
tick_irq_enter();
|
2020-12-02 19:57:32 +08:00
|
|
|
|
|
|
|
account_hardirq_enter(current);
|
2007-02-16 17:27:45 +08:00
|
|
|
}
|
|
|
|
|
2020-05-22 04:05:21 +08:00
|
|
|
/**
|
|
|
|
* irq_enter - Enter an interrupt context including RCU update
|
|
|
|
*/
|
|
|
|
void irq_enter(void)
|
|
|
|
{
|
|
|
|
rcu_irq_enter();
|
|
|
|
irq_enter_rcu();
|
|
|
|
}
|
|
|
|
|
2013-04-20 23:43:13 +08:00
|
|
|
static inline void tick_irq_exit(void)
|
|
|
|
{
|
|
|
|
#ifdef CONFIG_NO_HZ_COMMON
|
|
|
|
int cpu = smp_processor_id();
|
|
|
|
|
|
|
|
/* Make sure that timer wheel updates are propagated */
|
|
|
|
if ((idle_cpu(cpu) && !need_resched()) || tick_nohz_full_cpu(cpu)) {
|
2022-01-28 19:07:27 +08:00
|
|
|
if (!in_hardirq())
|
2013-04-20 23:43:13 +08:00
|
|
|
tick_nohz_irq_exit();
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
}
|
|
|
|
|
2020-05-30 05:27:39 +08:00
|
|
|
static inline void __irq_exit_rcu(void)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2013-02-21 05:00:48 +08:00
|
|
|
#ifndef __ARCH_IRQ_EXIT_IRQS_DISABLED
|
2013-03-01 03:00:43 +08:00
|
|
|
local_irq_disable();
|
2013-02-21 05:00:48 +08:00
|
|
|
#else
|
2017-11-06 23:01:18 +08:00
|
|
|
lockdep_assert_irqs_disabled();
|
2013-02-21 05:00:48 +08:00
|
|
|
#endif
|
2020-12-02 19:57:31 +08:00
|
|
|
account_hardirq_exit(current);
|
2013-09-10 18:15:23 +08:00
|
|
|
preempt_count_sub(HARDIRQ_OFFSET);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (!in_interrupt() && local_softirq_pending())
|
|
|
|
invoke_softirq();
|
2007-02-16 17:28:03 +08:00
|
|
|
|
2013-04-20 23:43:13 +08:00
|
|
|
tick_irq_exit();
|
2020-05-22 04:05:21 +08:00
|
|
|
}
|
|
|
|
|
2020-05-30 05:27:39 +08:00
|
|
|
/**
|
|
|
|
* irq_exit_rcu() - Exit an interrupt context without updating RCU
|
|
|
|
*
|
|
|
|
* Also processes softirqs if needed and possible.
|
|
|
|
*/
|
|
|
|
void irq_exit_rcu(void)
|
|
|
|
{
|
|
|
|
__irq_exit_rcu();
|
|
|
|
/* must be last! */
|
|
|
|
lockdep_hardirq_exit();
|
|
|
|
}
|
|
|
|
|
2020-05-22 04:05:21 +08:00
|
|
|
/**
|
|
|
|
* irq_exit - Exit an interrupt context, update RCU and lockdep
|
|
|
|
*
|
|
|
|
* Also processes softirqs if needed and possible.
|
|
|
|
*/
|
|
|
|
void irq_exit(void)
|
|
|
|
{
|
2020-05-30 05:27:39 +08:00
|
|
|
__irq_exit_rcu();
|
2011-10-08 07:31:02 +08:00
|
|
|
rcu_irq_exit();
|
2020-03-20 19:56:40 +08:00
|
|
|
/* must be last! */
|
|
|
|
lockdep_hardirq_exit();
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This function must run with irqs disabled!
|
|
|
|
*/
|
2008-02-08 20:19:53 +08:00
|
|
|
inline void raise_softirq_irqoff(unsigned int nr)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
__raise_softirq_irqoff(nr);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If we're in an interrupt or softirq, we're done
|
|
|
|
* (this also catches softirq-disabled code). We will
|
|
|
|
* actually run the softirq once we return from
|
|
|
|
* the irq or softirq.
|
|
|
|
*
|
|
|
|
* Otherwise we wake up ksoftirqd to make sure we
|
|
|
|
* schedule the softirq soon.
|
|
|
|
*/
|
2021-03-09 16:55:55 +08:00
|
|
|
if (!in_interrupt() && should_wake_ksoftirqd())
|
2005-04-17 06:20:36 +08:00
|
|
|
wakeup_softirqd();
|
|
|
|
}
|
|
|
|
|
2008-02-08 20:19:53 +08:00
|
|
|
void raise_softirq(unsigned int nr)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
local_irq_save(flags);
|
|
|
|
raise_softirq_irqoff(nr);
|
|
|
|
local_irq_restore(flags);
|
|
|
|
}
|
|
|
|
|
2012-01-26 09:18:55 +08:00
|
|
|
void __raise_softirq_irqoff(unsigned int nr)
|
|
|
|
{
|
2020-08-14 12:55:22 +08:00
|
|
|
lockdep_assert_irqs_disabled();
|
2012-01-26 09:18:55 +08:00
|
|
|
trace_softirq_raise(nr);
|
|
|
|
or_softirq_pending(1UL << nr);
|
|
|
|
}
|
|
|
|
|
Remove argument from open_softirq which is always NULL
As git-grep shows, open_softirq() is always called with the last argument
being NULL
block/blk-core.c: open_softirq(BLOCK_SOFTIRQ, blk_done_softirq, NULL);
kernel/hrtimer.c: open_softirq(HRTIMER_SOFTIRQ, run_hrtimer_softirq, NULL);
kernel/rcuclassic.c: open_softirq(RCU_SOFTIRQ, rcu_process_callbacks, NULL);
kernel/rcupreempt.c: open_softirq(RCU_SOFTIRQ, rcu_process_callbacks, NULL);
kernel/sched.c: open_softirq(SCHED_SOFTIRQ, run_rebalance_domains, NULL);
kernel/softirq.c: open_softirq(TASKLET_SOFTIRQ, tasklet_action, NULL);
kernel/softirq.c: open_softirq(HI_SOFTIRQ, tasklet_hi_action, NULL);
kernel/timer.c: open_softirq(TIMER_SOFTIRQ, run_timer_softirq, NULL);
net/core/dev.c: open_softirq(NET_TX_SOFTIRQ, net_tx_action, NULL);
net/core/dev.c: open_softirq(NET_RX_SOFTIRQ, net_rx_action, NULL);
This observation has already been made by Matthew Wilcox in June 2002
(http://www.cs.helsinki.fi/linux/linux-kernel/2002-25/0687.html)
"I notice that none of the current softirq routines use the data element
passed to them."
and the situation hasn't changed since them. So it appears we can safely
remove that extra argument to save 128 (54) bytes of kernel data (text).
Signed-off-by: Carlos R. Mafra <crmafra@ift.unesp.br>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-05-15 22:15:37 +08:00
|
|
|
void open_softirq(int nr, void (*action)(struct softirq_action *))
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
softirq_vec[nr].action = action;
|
|
|
|
}
|
|
|
|
|
2009-07-22 20:18:35 +08:00
|
|
|
/*
|
|
|
|
* Tasklets
|
|
|
|
*/
|
2014-01-28 09:07:16 +08:00
|
|
|
struct tasklet_head {
|
2008-03-05 07:23:25 +08:00
|
|
|
struct tasklet_struct *head;
|
|
|
|
struct tasklet_struct **tail;
|
2005-04-17 06:20:36 +08:00
|
|
|
};
|
|
|
|
|
2008-06-13 05:21:53 +08:00
|
|
|
static DEFINE_PER_CPU(struct tasklet_head, tasklet_vec);
|
|
|
|
static DEFINE_PER_CPU(struct tasklet_head, tasklet_hi_vec);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2018-02-28 00:48:07 +08:00
|
|
|
static void __tasklet_schedule_common(struct tasklet_struct *t,
|
|
|
|
struct tasklet_head __percpu *headp,
|
|
|
|
unsigned int softirq_nr)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2018-02-28 00:48:07 +08:00
|
|
|
struct tasklet_head *head;
|
2005-04-17 06:20:36 +08:00
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
local_irq_save(flags);
|
2018-02-28 00:48:07 +08:00
|
|
|
head = this_cpu_ptr(headp);
|
2008-03-05 07:23:25 +08:00
|
|
|
t->next = NULL;
|
2018-02-28 00:48:07 +08:00
|
|
|
*head->tail = t;
|
|
|
|
head->tail = &(t->next);
|
|
|
|
raise_softirq_irqoff(softirq_nr);
|
2005-04-17 06:20:36 +08:00
|
|
|
local_irq_restore(flags);
|
|
|
|
}
|
2018-02-28 00:48:07 +08:00
|
|
|
|
|
|
|
void __tasklet_schedule(struct tasklet_struct *t)
|
|
|
|
{
|
|
|
|
__tasklet_schedule_common(t, &tasklet_vec,
|
|
|
|
TASKLET_SOFTIRQ);
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
EXPORT_SYMBOL(__tasklet_schedule);
|
|
|
|
|
2008-02-08 20:19:53 +08:00
|
|
|
void __tasklet_hi_schedule(struct tasklet_struct *t)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2018-02-28 00:48:07 +08:00
|
|
|
__tasklet_schedule_common(t, &tasklet_hi_vec,
|
|
|
|
HI_SOFTIRQ);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(__tasklet_hi_schedule);
|
|
|
|
|
2021-03-09 16:42:09 +08:00
|
|
|
static bool tasklet_clear_sched(struct tasklet_struct *t)
|
2021-03-17 18:20:12 +08:00
|
|
|
{
|
2021-03-09 16:42:09 +08:00
|
|
|
if (test_and_clear_bit(TASKLET_STATE_SCHED, &t->state)) {
|
|
|
|
wake_up_var(&t->state);
|
2021-03-17 18:20:12 +08:00
|
|
|
return true;
|
2021-03-09 16:42:09 +08:00
|
|
|
}
|
2021-03-17 18:20:12 +08:00
|
|
|
|
|
|
|
WARN_ONCE(1, "tasklet SCHED state not set: %s %pS\n",
|
|
|
|
t->use_callback ? "callback" : "func",
|
|
|
|
t->use_callback ? (void *)t->callback : (void *)t->func);
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-02-28 00:48:08 +08:00
|
|
|
static void tasklet_action_common(struct softirq_action *a,
|
|
|
|
struct tasklet_head *tl_head,
|
|
|
|
unsigned int softirq_nr)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct tasklet_struct *list;
|
|
|
|
|
|
|
|
local_irq_disable();
|
2018-02-28 00:48:08 +08:00
|
|
|
list = tl_head->head;
|
|
|
|
tl_head->head = NULL;
|
|
|
|
tl_head->tail = &tl_head->head;
|
2005-04-17 06:20:36 +08:00
|
|
|
local_irq_enable();
|
|
|
|
|
|
|
|
while (list) {
|
|
|
|
struct tasklet_struct *t = list;
|
|
|
|
|
|
|
|
list = list->next;
|
|
|
|
|
|
|
|
if (tasklet_trylock(t)) {
|
|
|
|
if (!atomic_read(&t->count)) {
|
2021-03-09 16:42:09 +08:00
|
|
|
if (tasklet_clear_sched(t)) {
|
2021-03-17 18:20:12 +08:00
|
|
|
if (t->use_callback)
|
|
|
|
t->callback(t);
|
|
|
|
else
|
|
|
|
t->func(t->data);
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
tasklet_unlock(t);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
tasklet_unlock(t);
|
|
|
|
}
|
|
|
|
|
|
|
|
local_irq_disable();
|
2008-03-05 07:23:25 +08:00
|
|
|
t->next = NULL;
|
2018-02-28 00:48:08 +08:00
|
|
|
*tl_head->tail = t;
|
|
|
|
tl_head->tail = &t->next;
|
|
|
|
__raise_softirq_irqoff(softirq_nr);
|
2005-04-17 06:20:36 +08:00
|
|
|
local_irq_enable();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-02-28 00:48:08 +08:00
|
|
|
static __latent_entropy void tasklet_action(struct softirq_action *a)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2018-02-28 00:48:08 +08:00
|
|
|
tasklet_action_common(a, this_cpu_ptr(&tasklet_vec), TASKLET_SOFTIRQ);
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2018-02-28 00:48:08 +08:00
|
|
|
static __latent_entropy void tasklet_hi_action(struct softirq_action *a)
|
|
|
|
{
|
|
|
|
tasklet_action_common(a, this_cpu_ptr(&tasklet_hi_vec), HI_SOFTIRQ);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
tasklet: Introduce new initialization API
Nowadays, modern kernel subsystems that use callbacks pass the data
structure associated with a given callback as argument to the callback.
The tasklet subsystem remains one which passes an arbitrary unsigned
long to the callback function. This has several problems:
- This keeps an extra field for storing the argument in each tasklet
data structure, it bloats the tasklet_struct structure with a redundant
.data field
- No type checking can be performed on this argument. Instead of
using container_of() like other callback subsystems, it forces callbacks
to do explicit type cast of the unsigned long argument into the required
object type.
- Buffer overflows can overwrite the .func and the .data field, so
an attacker can easily overwrite the function and its first argument
to whatever it wants.
Add a new tasklet initialization API, via DECLARE_TASKLET() and
tasklet_setup(), which will replace the existing ones.
This work is greatly inspired by the timer_struct conversion series,
see commit e99e88a9d2b0 ("treewide: setup_timer() -> timer_setup()")
To avoid problems with both -Wcast-function-type (which is enabled in
the kernel via -Wextra is several subsystems), and with mismatched
function prototypes when build with Control Flow Integrity enabled,
this adds the "use_callback" member to let the tasklet caller choose
which union member to call through. Once all old API uses are removed,
this and the .data member will be removed as well. (On 64-bit this does
not grow the struct size as the new member fills the hole after atomic_t,
which is also "int" sized.)
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Co-developed-by: Allen Pais <allen.lkml@gmail.com>
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Co-developed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
2019-09-30 00:30:13 +08:00
|
|
|
void tasklet_setup(struct tasklet_struct *t,
|
|
|
|
void (*callback)(struct tasklet_struct *))
|
|
|
|
{
|
|
|
|
t->next = NULL;
|
|
|
|
t->state = 0;
|
|
|
|
atomic_set(&t->count, 0);
|
|
|
|
t->callback = callback;
|
|
|
|
t->use_callback = true;
|
|
|
|
t->data = 0;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(tasklet_setup);
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
void tasklet_init(struct tasklet_struct *t,
|
|
|
|
void (*func)(unsigned long), unsigned long data)
|
|
|
|
{
|
|
|
|
t->next = NULL;
|
|
|
|
t->state = 0;
|
|
|
|
atomic_set(&t->count, 0);
|
|
|
|
t->func = func;
|
tasklet: Introduce new initialization API
Nowadays, modern kernel subsystems that use callbacks pass the data
structure associated with a given callback as argument to the callback.
The tasklet subsystem remains one which passes an arbitrary unsigned
long to the callback function. This has several problems:
- This keeps an extra field for storing the argument in each tasklet
data structure, it bloats the tasklet_struct structure with a redundant
.data field
- No type checking can be performed on this argument. Instead of
using container_of() like other callback subsystems, it forces callbacks
to do explicit type cast of the unsigned long argument into the required
object type.
- Buffer overflows can overwrite the .func and the .data field, so
an attacker can easily overwrite the function and its first argument
to whatever it wants.
Add a new tasklet initialization API, via DECLARE_TASKLET() and
tasklet_setup(), which will replace the existing ones.
This work is greatly inspired by the timer_struct conversion series,
see commit e99e88a9d2b0 ("treewide: setup_timer() -> timer_setup()")
To avoid problems with both -Wcast-function-type (which is enabled in
the kernel via -Wextra is several subsystems), and with mismatched
function prototypes when build with Control Flow Integrity enabled,
this adds the "use_callback" member to let the tasklet caller choose
which union member to call through. Once all old API uses are removed,
this and the .data member will be removed as well. (On 64-bit this does
not grow the struct size as the new member fills the hole after atomic_t,
which is also "int" sized.)
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Co-developed-by: Allen Pais <allen.lkml@gmail.com>
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Co-developed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
2019-09-30 00:30:13 +08:00
|
|
|
t->use_callback = false;
|
2005-04-17 06:20:36 +08:00
|
|
|
t->data = data;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(tasklet_init);
|
|
|
|
|
2021-03-09 16:42:10 +08:00
|
|
|
#if defined(CONFIG_SMP) || defined(CONFIG_PREEMPT_RT)
|
|
|
|
/*
|
|
|
|
* Do not use in new code. Waiting for tasklets from atomic contexts is
|
|
|
|
* error prone and should be avoided.
|
|
|
|
*/
|
|
|
|
void tasklet_unlock_spin_wait(struct tasklet_struct *t)
|
|
|
|
{
|
|
|
|
while (test_bit(TASKLET_STATE_RUN, &(t)->state)) {
|
|
|
|
if (IS_ENABLED(CONFIG_PREEMPT_RT)) {
|
|
|
|
/*
|
|
|
|
* Prevent a live lock when current preempted soft
|
|
|
|
* interrupt processing or prevents ksoftirqd from
|
|
|
|
* running. If the tasklet runs on a different CPU
|
|
|
|
* then this has no effect other than doing the BH
|
|
|
|
* disable/enable dance for nothing.
|
|
|
|
*/
|
|
|
|
local_bh_disable();
|
|
|
|
local_bh_enable();
|
|
|
|
} else {
|
|
|
|
cpu_relax();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(tasklet_unlock_spin_wait);
|
|
|
|
#endif
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
void tasklet_kill(struct tasklet_struct *t)
|
|
|
|
{
|
|
|
|
if (in_interrupt())
|
2014-01-28 09:07:15 +08:00
|
|
|
pr_notice("Attempt to kill tasklet from interrupt\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2021-03-09 16:42:09 +08:00
|
|
|
while (test_and_set_bit(TASKLET_STATE_SCHED, &t->state))
|
|
|
|
wait_var_event(&t->state, !test_bit(TASKLET_STATE_SCHED, &t->state));
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
tasklet_unlock_wait(t);
|
2021-03-09 16:42:09 +08:00
|
|
|
tasklet_clear_sched(t);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(tasklet_kill);
|
|
|
|
|
2021-03-09 16:42:10 +08:00
|
|
|
#if defined(CONFIG_SMP) || defined(CONFIG_PREEMPT_RT)
|
2021-03-09 16:42:08 +08:00
|
|
|
void tasklet_unlock(struct tasklet_struct *t)
|
|
|
|
{
|
|
|
|
smp_mb__before_atomic();
|
|
|
|
clear_bit(TASKLET_STATE_RUN, &t->state);
|
|
|
|
smp_mb__after_atomic();
|
|
|
|
wake_up_var(&t->state);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(tasklet_unlock);
|
|
|
|
|
|
|
|
void tasklet_unlock_wait(struct tasklet_struct *t)
|
|
|
|
{
|
|
|
|
wait_var_event(&t->state, !test_bit(TASKLET_STATE_RUN, &t->state));
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(tasklet_unlock_wait);
|
|
|
|
#endif
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
void __init softirq_init(void)
|
|
|
|
{
|
2008-03-05 07:23:25 +08:00
|
|
|
int cpu;
|
|
|
|
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
per_cpu(tasklet_vec, cpu).tail =
|
|
|
|
&per_cpu(tasklet_vec, cpu).head;
|
|
|
|
per_cpu(tasklet_hi_vec, cpu).tail =
|
|
|
|
&per_cpu(tasklet_hi_vec, cpu).head;
|
|
|
|
}
|
|
|
|
|
Remove argument from open_softirq which is always NULL
As git-grep shows, open_softirq() is always called with the last argument
being NULL
block/blk-core.c: open_softirq(BLOCK_SOFTIRQ, blk_done_softirq, NULL);
kernel/hrtimer.c: open_softirq(HRTIMER_SOFTIRQ, run_hrtimer_softirq, NULL);
kernel/rcuclassic.c: open_softirq(RCU_SOFTIRQ, rcu_process_callbacks, NULL);
kernel/rcupreempt.c: open_softirq(RCU_SOFTIRQ, rcu_process_callbacks, NULL);
kernel/sched.c: open_softirq(SCHED_SOFTIRQ, run_rebalance_domains, NULL);
kernel/softirq.c: open_softirq(TASKLET_SOFTIRQ, tasklet_action, NULL);
kernel/softirq.c: open_softirq(HI_SOFTIRQ, tasklet_hi_action, NULL);
kernel/timer.c: open_softirq(TIMER_SOFTIRQ, run_timer_softirq, NULL);
net/core/dev.c: open_softirq(NET_TX_SOFTIRQ, net_tx_action, NULL);
net/core/dev.c: open_softirq(NET_RX_SOFTIRQ, net_rx_action, NULL);
This observation has already been made by Matthew Wilcox in June 2002
(http://www.cs.helsinki.fi/linux/linux-kernel/2002-25/0687.html)
"I notice that none of the current softirq routines use the data element
passed to them."
and the situation hasn't changed since them. So it appears we can safely
remove that extra argument to save 128 (54) bytes of kernel data (text).
Signed-off-by: Carlos R. Mafra <crmafra@ift.unesp.br>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-05-15 22:15:37 +08:00
|
|
|
open_softirq(TASKLET_SOFTIRQ, tasklet_action);
|
|
|
|
open_softirq(HI_SOFTIRQ, tasklet_hi_action);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2012-07-16 18:42:37 +08:00
|
|
|
static int ksoftirqd_should_run(unsigned int cpu)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2012-07-16 18:42:37 +08:00
|
|
|
return local_softirq_pending();
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-07-16 18:42:37 +08:00
|
|
|
static void run_ksoftirqd(unsigned int cpu)
|
|
|
|
{
|
2021-03-09 16:55:55 +08:00
|
|
|
ksoftirqd_run_begin();
|
2012-07-16 18:42:37 +08:00
|
|
|
if (local_softirq_pending()) {
|
2013-09-05 22:14:00 +08:00
|
|
|
/*
|
|
|
|
* We can safely run softirq on inline stack, as we are not deep
|
|
|
|
* in the task stack here.
|
|
|
|
*/
|
2012-07-16 18:42:37 +08:00
|
|
|
__do_softirq();
|
2021-03-09 16:55:55 +08:00
|
|
|
ksoftirqd_run_end();
|
2017-10-24 23:31:12 +08:00
|
|
|
cond_resched();
|
2012-07-16 18:42:37 +08:00
|
|
|
return;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2021-03-09 16:55:55 +08:00
|
|
|
ksoftirqd_run_end();
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
#ifdef CONFIG_HOTPLUG_CPU
|
2016-08-18 20:57:21 +08:00
|
|
|
static int takeover_tasklets(unsigned int cpu)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
/* CPU is dead, so no lock needed. */
|
|
|
|
local_irq_disable();
|
|
|
|
|
|
|
|
/* Find end, append list for that CPU. */
|
2008-05-01 19:34:23 +08:00
|
|
|
if (&per_cpu(tasklet_vec, cpu).head != per_cpu(tasklet_vec, cpu).tail) {
|
2010-12-08 23:22:55 +08:00
|
|
|
*__this_cpu_read(tasklet_vec.tail) = per_cpu(tasklet_vec, cpu).head;
|
2019-06-18 22:33:05 +08:00
|
|
|
__this_cpu_write(tasklet_vec.tail, per_cpu(tasklet_vec, cpu).tail);
|
2008-05-01 19:34:23 +08:00
|
|
|
per_cpu(tasklet_vec, cpu).head = NULL;
|
|
|
|
per_cpu(tasklet_vec, cpu).tail = &per_cpu(tasklet_vec, cpu).head;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
raise_softirq_irqoff(TASKLET_SOFTIRQ);
|
|
|
|
|
2008-05-01 19:34:23 +08:00
|
|
|
if (&per_cpu(tasklet_hi_vec, cpu).head != per_cpu(tasklet_hi_vec, cpu).tail) {
|
2010-12-08 23:22:55 +08:00
|
|
|
*__this_cpu_read(tasklet_hi_vec.tail) = per_cpu(tasklet_hi_vec, cpu).head;
|
|
|
|
__this_cpu_write(tasklet_hi_vec.tail, per_cpu(tasklet_hi_vec, cpu).tail);
|
2008-05-01 19:34:23 +08:00
|
|
|
per_cpu(tasklet_hi_vec, cpu).head = NULL;
|
|
|
|
per_cpu(tasklet_hi_vec, cpu).tail = &per_cpu(tasklet_hi_vec, cpu).head;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
raise_softirq_irqoff(HI_SOFTIRQ);
|
|
|
|
|
|
|
|
local_irq_enable();
|
2016-08-18 20:57:21 +08:00
|
|
|
return 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2016-08-18 20:57:21 +08:00
|
|
|
#else
|
|
|
|
#define takeover_tasklets NULL
|
2005-04-17 06:20:36 +08:00
|
|
|
#endif /* CONFIG_HOTPLUG_CPU */
|
|
|
|
|
2012-07-16 18:42:37 +08:00
|
|
|
static struct smp_hotplug_thread softirq_threads = {
|
|
|
|
.store = &ksoftirqd,
|
|
|
|
.thread_should_run = ksoftirqd_should_run,
|
|
|
|
.thread_fn = run_ksoftirqd,
|
|
|
|
.thread_comm = "ksoftirqd/%u",
|
|
|
|
};
|
|
|
|
|
2008-07-26 10:45:11 +08:00
|
|
|
static __init int spawn_ksoftirqd(void)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2016-08-18 20:57:21 +08:00
|
|
|
cpuhp_setup_state_nocalls(CPUHP_SOFTIRQ_DEAD, "softirq:dead", NULL,
|
|
|
|
takeover_tasklets);
|
2012-07-16 18:42:37 +08:00
|
|
|
BUG_ON(smpboot_register_percpu_thread(&softirq_threads));
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
|
|
|
}
|
2008-07-26 10:45:11 +08:00
|
|
|
early_initcall(spawn_ksoftirqd);
|
2006-03-22 16:08:16 +08:00
|
|
|
|
2008-12-29 08:01:13 +08:00
|
|
|
/*
|
|
|
|
* [ These __weak aliases are kept in a separate compilation unit, so that
|
|
|
|
* GCC does not inline them incorrectly. ]
|
|
|
|
*/
|
|
|
|
|
|
|
|
int __init __weak early_irq_init(void)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-01-13 09:39:24 +08:00
|
|
|
int __init __weak arch_probe_nr_irqs(void)
|
|
|
|
{
|
2010-09-28 02:55:03 +08:00
|
|
|
return NR_IRQS_LEGACY;
|
2009-01-13 09:39:24 +08:00
|
|
|
}
|
|
|
|
|
2008-12-29 08:01:13 +08:00
|
|
|
int __init __weak arch_early_irq_init(void)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
2014-04-24 15:50:53 +08:00
|
|
|
|
|
|
|
unsigned int __weak arch_dynirq_lower_bound(unsigned int from)
|
|
|
|
{
|
|
|
|
return from;
|
|
|
|
}
|