2020-03-14 03:42:37 +08:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
|
|
|
/*
|
|
|
|
* Copyright (C) 2005, Intec Automation Inc.
|
|
|
|
* Copyright (C) 2014, Freescale Semiconductor, Inc.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#ifndef __LINUX_MTD_SPI_NOR_INTERNAL_H
|
|
|
|
#define __LINUX_MTD_SPI_NOR_INTERNAL_H
|
|
|
|
|
|
|
|
#include "sfdp.h"
|
|
|
|
|
2020-03-14 03:42:38 +08:00
|
|
|
#define SPI_NOR_MAX_ID_LEN 6
|
|
|
|
|
2020-03-14 03:42:53 +08:00
|
|
|
enum spi_nor_option_flags {
|
|
|
|
SNOR_F_USE_FSR = BIT(0),
|
|
|
|
SNOR_F_HAS_SR_TB = BIT(1),
|
|
|
|
SNOR_F_NO_OP_CHIP_ERASE = BIT(2),
|
|
|
|
SNOR_F_READY_XSR_RDY = BIT(3),
|
|
|
|
SNOR_F_USE_CLSR = BIT(4),
|
|
|
|
SNOR_F_BROKEN_RESET = BIT(5),
|
|
|
|
SNOR_F_4B_OPCODES = BIT(6),
|
|
|
|
SNOR_F_HAS_4BAIT = BIT(7),
|
|
|
|
SNOR_F_HAS_LOCK = BIT(8),
|
|
|
|
SNOR_F_HAS_16BIT_SR = BIT(9),
|
|
|
|
SNOR_F_NO_READ_CR = BIT(10),
|
|
|
|
SNOR_F_HAS_SR_TB_BIT6 = BIT(11),
|
2020-03-18 20:06:14 +08:00
|
|
|
SNOR_F_HAS_4BIT_BP = BIT(12),
|
|
|
|
SNOR_F_HAS_SR_BP3_BIT6 = BIT(13),
|
2020-10-05 23:31:31 +08:00
|
|
|
SNOR_F_IO_MODE_EN_VOLATILE = BIT(14),
|
2020-10-05 23:31:34 +08:00
|
|
|
SNOR_F_SOFT_RESET = BIT(15),
|
mtd: spi-nor: keep lock bits if they are non-volatile
Traditionally, Linux unlocks the whole flash because there are legacy
devices which has the write protection bits set by default at startup.
If you actually want to use the flash protection bits, eg. because there
is a read-only part for a bootloader, this automatic unlocking is
harmful. If there is no hardware write protection in place (usually
called WP#), a startup of the kernel just discards this protection.
I've gone through the datasheets of all the flashes (except the Intel
ones where I could not find any datasheet nor reference) which supports
the unlocking feature and looked how the sector protection was
implemented. The currently supported flashes can be divided into the
following two categories:
(1) block protection bits are non-volatile. Thus they keep their values
at reset and power-cycle
(2) flashes where these bits are volatile. After reset or power-cycle,
the whole memory array is protected.
(a) some devices needs a special "Global Unprotect" command, eg.
the Atmel AT25DF041A.
(b) some devices require to clear the BPn bits in the status
register.
Due to the reasons above, we do not want to clear the bits for flashes
which belong to category (1). Fortunately for us, only Atmel flashes
fall into category (2a). Implement the "Global Protect" and "Global
Unprotect" commands for these. For (2b) we can use normal block
protection locking scheme.
This patch adds a new flag to indicate the case (2). Only if we have
such a flash we unlock the whole flash array. To be backwards compatible
it also introduces a kernel configuration option which restores the
complete legacy behavior ("Disable write protection on any flashes").
Hopefully, this will clean up "unlock the entire flash for legacy
devices" once and for all.
For reference here are the actually commits which introduced the legacy
behavior (and extended the behavior to other chip manufacturers):
commit f80e521c916cb ("mtd: m25p80: add support for the Intel/Numonyx {16,32,64}0S33B SPI flash chips")
commit ea60658a08f8f ("mtd: m25p80: disable SST software protection bits by default")
commit 7228982442365 ("[MTD] m25p80: fix bug - ATmel spi flash fails to be copied to")
Actually, this might also fix handling of the Atmel AT25DF flashes,
because the original commit 7228982442365 ("[MTD] m25p80: fix bug -
ATmel spi flash fails to be copied to") was writing a 0 to the status
register, which is a "Global Unprotect". This might not be the case in
the current code which only handles the block protection bits BP2, BP1
and BP0. Thus, it depends on the current contents of the status register
if this unlock actually corresponds to a "Global Unprotect" command. In
the worst case, the current code might leave the AT25DF flashes in a
write protected state.
The commit 191f5c2ed4b6f ("mtd: spi-nor: use 16-bit WRR command when QE
is set on spansion flashes") changed that behavior by just clearing BP2
to BP0 instead of writing a 0 to the status register.
Further, the commit 3e0930f109e76 ("mtd: spi-nor: Rework the disabling
of block write protection") expanded the unlock_all() feature to ANY
flash which supports locking.
Signed-off-by: Michael Walle <michael@walle.cc>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20201203162959.29589-8-michael@walle.cc
2020-12-04 00:29:59 +08:00
|
|
|
SNOR_F_SWP_IS_VOLATILE = BIT(16),
|
2020-03-14 03:42:53 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
struct spi_nor_read_command {
|
|
|
|
u8 num_mode_clocks;
|
|
|
|
u8 num_wait_states;
|
|
|
|
u8 opcode;
|
|
|
|
enum spi_nor_protocol proto;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct spi_nor_pp_command {
|
|
|
|
u8 opcode;
|
|
|
|
enum spi_nor_protocol proto;
|
|
|
|
};
|
|
|
|
|
|
|
|
enum spi_nor_read_command_index {
|
|
|
|
SNOR_CMD_READ,
|
|
|
|
SNOR_CMD_READ_FAST,
|
|
|
|
SNOR_CMD_READ_1_1_1_DTR,
|
|
|
|
|
|
|
|
/* Dual SPI */
|
|
|
|
SNOR_CMD_READ_1_1_2,
|
|
|
|
SNOR_CMD_READ_1_2_2,
|
|
|
|
SNOR_CMD_READ_2_2_2,
|
|
|
|
SNOR_CMD_READ_1_2_2_DTR,
|
|
|
|
|
|
|
|
/* Quad SPI */
|
|
|
|
SNOR_CMD_READ_1_1_4,
|
|
|
|
SNOR_CMD_READ_1_4_4,
|
|
|
|
SNOR_CMD_READ_4_4_4,
|
|
|
|
SNOR_CMD_READ_1_4_4_DTR,
|
|
|
|
|
|
|
|
/* Octal SPI */
|
|
|
|
SNOR_CMD_READ_1_1_8,
|
|
|
|
SNOR_CMD_READ_1_8_8,
|
|
|
|
SNOR_CMD_READ_8_8_8,
|
|
|
|
SNOR_CMD_READ_1_8_8_DTR,
|
2020-10-05 23:31:26 +08:00
|
|
|
SNOR_CMD_READ_8_8_8_DTR,
|
2020-03-14 03:42:53 +08:00
|
|
|
|
|
|
|
SNOR_CMD_READ_MAX
|
|
|
|
};
|
|
|
|
|
|
|
|
enum spi_nor_pp_command_index {
|
|
|
|
SNOR_CMD_PP,
|
|
|
|
|
|
|
|
/* Quad SPI */
|
|
|
|
SNOR_CMD_PP_1_1_4,
|
|
|
|
SNOR_CMD_PP_1_4_4,
|
|
|
|
SNOR_CMD_PP_4_4_4,
|
|
|
|
|
|
|
|
/* Octal SPI */
|
|
|
|
SNOR_CMD_PP_1_1_8,
|
|
|
|
SNOR_CMD_PP_1_8_8,
|
|
|
|
SNOR_CMD_PP_8_8_8,
|
2020-10-05 23:31:26 +08:00
|
|
|
SNOR_CMD_PP_8_8_8_DTR,
|
2020-03-14 03:42:53 +08:00
|
|
|
|
|
|
|
SNOR_CMD_PP_MAX
|
|
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
|
|
* struct spi_nor_erase_type - Structure to describe a SPI NOR erase type
|
|
|
|
* @size: the size of the sector/block erased by the erase type.
|
|
|
|
* JEDEC JESD216B imposes erase sizes to be a power of 2.
|
|
|
|
* @size_shift: @size is a power of 2, the shift is stored in
|
|
|
|
* @size_shift.
|
|
|
|
* @size_mask: the size mask based on @size_shift.
|
|
|
|
* @opcode: the SPI command op code to erase the sector/block.
|
|
|
|
* @idx: Erase Type index as sorted in the Basic Flash Parameter
|
|
|
|
* Table. It will be used to synchronize the supported
|
|
|
|
* Erase Types with the ones identified in the SFDP
|
|
|
|
* optional tables.
|
|
|
|
*/
|
|
|
|
struct spi_nor_erase_type {
|
|
|
|
u32 size;
|
|
|
|
u32 size_shift;
|
|
|
|
u32 size_mask;
|
|
|
|
u8 opcode;
|
|
|
|
u8 idx;
|
|
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
|
|
* struct spi_nor_erase_command - Used for non-uniform erases
|
|
|
|
* The structure is used to describe a list of erase commands to be executed
|
|
|
|
* once we validate that the erase can be performed. The elements in the list
|
|
|
|
* are run-length encoded.
|
|
|
|
* @list: for inclusion into the list of erase commands.
|
|
|
|
* @count: how many times the same erase command should be
|
|
|
|
* consecutively used.
|
|
|
|
* @size: the size of the sector/block erased by the command.
|
|
|
|
* @opcode: the SPI command op code to erase the sector/block.
|
|
|
|
*/
|
|
|
|
struct spi_nor_erase_command {
|
|
|
|
struct list_head list;
|
|
|
|
u32 count;
|
|
|
|
u32 size;
|
|
|
|
u8 opcode;
|
|
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
|
|
* struct spi_nor_erase_region - Structure to describe a SPI NOR erase region
|
|
|
|
* @offset: the offset in the data array of erase region start.
|
|
|
|
* LSB bits are used as a bitmask encoding flags to
|
|
|
|
* determine if this region is overlaid, if this region is
|
|
|
|
* the last in the SPI NOR flash memory and to indicate
|
|
|
|
* all the supported erase commands inside this region.
|
|
|
|
* The erase types are sorted in ascending order with the
|
|
|
|
* smallest Erase Type size being at BIT(0).
|
|
|
|
* @size: the size of the region in bytes.
|
|
|
|
*/
|
|
|
|
struct spi_nor_erase_region {
|
|
|
|
u64 offset;
|
|
|
|
u64 size;
|
|
|
|
};
|
|
|
|
|
|
|
|
#define SNOR_ERASE_TYPE_MAX 4
|
|
|
|
#define SNOR_ERASE_TYPE_MASK GENMASK_ULL(SNOR_ERASE_TYPE_MAX - 1, 0)
|
|
|
|
|
|
|
|
#define SNOR_LAST_REGION BIT(4)
|
|
|
|
#define SNOR_OVERLAID_REGION BIT(5)
|
|
|
|
|
|
|
|
#define SNOR_ERASE_FLAGS_MAX 6
|
|
|
|
#define SNOR_ERASE_FLAGS_MASK GENMASK_ULL(SNOR_ERASE_FLAGS_MAX - 1, 0)
|
|
|
|
|
|
|
|
/**
|
|
|
|
* struct spi_nor_erase_map - Structure to describe the SPI NOR erase map
|
|
|
|
* @regions: array of erase regions. The regions are consecutive in
|
|
|
|
* address space. Walking through the regions is done
|
|
|
|
* incrementally.
|
|
|
|
* @uniform_region: a pre-allocated erase region for SPI NOR with a uniform
|
|
|
|
* sector size (legacy implementation).
|
|
|
|
* @erase_type: an array of erase types shared by all the regions.
|
|
|
|
* The erase types are sorted in ascending order, with the
|
|
|
|
* smallest Erase Type size being the first member in the
|
|
|
|
* erase_type array.
|
|
|
|
* @uniform_erase_type: bitmask encoding erase types that can erase the
|
|
|
|
* entire memory. This member is completed at init by
|
|
|
|
* uniform and non-uniform SPI NOR flash memories if they
|
|
|
|
* support at least one erase type that can erase the
|
|
|
|
* entire memory.
|
|
|
|
*/
|
|
|
|
struct spi_nor_erase_map {
|
|
|
|
struct spi_nor_erase_region *regions;
|
|
|
|
struct spi_nor_erase_region uniform_region;
|
|
|
|
struct spi_nor_erase_type erase_type[SNOR_ERASE_TYPE_MAX];
|
|
|
|
u8 uniform_erase_type;
|
|
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
|
|
* struct spi_nor_locking_ops - SPI NOR locking methods
|
|
|
|
* @lock: lock a region of the SPI NOR.
|
|
|
|
* @unlock: unlock a region of the SPI NOR.
|
|
|
|
* @is_locked: check if a region of the SPI NOR is completely locked
|
|
|
|
*/
|
|
|
|
struct spi_nor_locking_ops {
|
|
|
|
int (*lock)(struct spi_nor *nor, loff_t ofs, uint64_t len);
|
|
|
|
int (*unlock)(struct spi_nor *nor, loff_t ofs, uint64_t len);
|
|
|
|
int (*is_locked)(struct spi_nor *nor, loff_t ofs, uint64_t len);
|
|
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
|
|
* struct spi_nor_flash_parameter - SPI NOR flash parameters and settings.
|
|
|
|
* Includes legacy flash parameters and settings that can be overwritten
|
|
|
|
* by the spi_nor_fixups hooks, or dynamically when parsing the JESD216
|
|
|
|
* Serial Flash Discoverable Parameters (SFDP) tables.
|
|
|
|
*
|
|
|
|
* @size: the flash memory density in bytes.
|
2020-12-01 18:27:10 +08:00
|
|
|
* @writesize Minimal writable flash unit size. Defaults to 1. Set to
|
|
|
|
* ECC unit size for ECC-ed flashes.
|
2020-03-14 03:42:53 +08:00
|
|
|
* @page_size: the page size of the SPI NOR flash memory.
|
2020-10-05 23:31:28 +08:00
|
|
|
* @rdsr_dummy: dummy cycles needed for Read Status Register command.
|
|
|
|
* @rdsr_addr_nbytes: dummy address bytes needed for Read Status Register
|
|
|
|
* command.
|
2020-03-14 03:42:53 +08:00
|
|
|
* @hwcaps: describes the read and page program hardware
|
|
|
|
* capabilities.
|
|
|
|
* @reads: read capabilities ordered by priority: the higher index
|
|
|
|
* in the array, the higher priority.
|
|
|
|
* @page_programs: page program capabilities ordered by priority: the
|
|
|
|
* higher index in the array, the higher priority.
|
|
|
|
* @erase_map: the erase map parsed from the SFDP Sector Map Parameter
|
|
|
|
* Table.
|
2020-10-05 23:31:33 +08:00
|
|
|
* @octal_dtr_enable: enables SPI NOR octal DTR mode.
|
2020-09-04 15:47:20 +08:00
|
|
|
* @quad_enable: enables SPI NOR quad mode.
|
2020-03-14 03:42:53 +08:00
|
|
|
* @set_4byte_addr_mode: puts the SPI NOR in 4 byte addressing mode.
|
|
|
|
* @convert_addr: converts an absolute address into something the flash
|
|
|
|
* will understand. Particularly useful when pagesize is
|
|
|
|
* not a power-of-2.
|
|
|
|
* @setup: configures the SPI NOR memory. Useful for SPI NOR
|
|
|
|
* flashes that have peculiarities to the SPI NOR standard
|
|
|
|
* e.g. different opcodes, specific address calculation,
|
|
|
|
* page size, etc.
|
|
|
|
* @locking_ops: SPI NOR locking methods.
|
|
|
|
*/
|
|
|
|
struct spi_nor_flash_parameter {
|
|
|
|
u64 size;
|
2020-12-01 18:27:10 +08:00
|
|
|
u32 writesize;
|
2020-03-14 03:42:53 +08:00
|
|
|
u32 page_size;
|
2020-10-05 23:31:28 +08:00
|
|
|
u8 rdsr_dummy;
|
|
|
|
u8 rdsr_addr_nbytes;
|
2020-03-14 03:42:53 +08:00
|
|
|
|
|
|
|
struct spi_nor_hwcaps hwcaps;
|
|
|
|
struct spi_nor_read_command reads[SNOR_CMD_READ_MAX];
|
|
|
|
struct spi_nor_pp_command page_programs[SNOR_CMD_PP_MAX];
|
|
|
|
|
|
|
|
struct spi_nor_erase_map erase_map;
|
|
|
|
|
2020-10-05 23:31:33 +08:00
|
|
|
int (*octal_dtr_enable)(struct spi_nor *nor, bool enable);
|
2020-09-04 15:47:20 +08:00
|
|
|
int (*quad_enable)(struct spi_nor *nor);
|
2020-03-14 03:42:53 +08:00
|
|
|
int (*set_4byte_addr_mode)(struct spi_nor *nor, bool enable);
|
|
|
|
u32 (*convert_addr)(struct spi_nor *nor, u32 addr);
|
|
|
|
int (*setup)(struct spi_nor *nor, const struct spi_nor_hwcaps *hwcaps);
|
|
|
|
|
|
|
|
const struct spi_nor_locking_ops *locking_ops;
|
|
|
|
};
|
|
|
|
|
2020-03-14 03:42:38 +08:00
|
|
|
/**
|
|
|
|
* struct spi_nor_fixups - SPI NOR fixup hooks
|
|
|
|
* @default_init: called after default flash parameters init. Used to tweak
|
|
|
|
* flash parameters when information provided by the flash_info
|
|
|
|
* table is incomplete or wrong.
|
|
|
|
* @post_bfpt: called after the BFPT table has been parsed
|
|
|
|
* @post_sfdp: called after SFDP has been parsed (is also called for SPI NORs
|
|
|
|
* that do not support RDSFDP). Typically used to tweak various
|
|
|
|
* parameters that could not be extracted by other means (i.e.
|
|
|
|
* when information provided by the SFDP/flash_info tables are
|
|
|
|
* incomplete or wrong).
|
|
|
|
*
|
|
|
|
* Those hooks can be used to tweak the SPI NOR configuration when the SFDP
|
|
|
|
* table is broken or not available.
|
|
|
|
*/
|
|
|
|
struct spi_nor_fixups {
|
|
|
|
void (*default_init)(struct spi_nor *nor);
|
|
|
|
int (*post_bfpt)(struct spi_nor *nor,
|
|
|
|
const struct sfdp_parameter_header *bfpt_header,
|
|
|
|
const struct sfdp_bfpt *bfpt,
|
|
|
|
struct spi_nor_flash_parameter *params);
|
|
|
|
void (*post_sfdp)(struct spi_nor *nor);
|
|
|
|
};
|
|
|
|
|
|
|
|
struct flash_info {
|
|
|
|
char *name;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This array stores the ID bytes.
|
|
|
|
* The first three bytes are the JEDIC ID.
|
|
|
|
* JEDEC ID zero means "no ID" (mostly older chips).
|
|
|
|
*/
|
|
|
|
u8 id[SPI_NOR_MAX_ID_LEN];
|
|
|
|
u8 id_len;
|
|
|
|
|
|
|
|
/* The size listed here is what works with SPINOR_OP_SE, which isn't
|
|
|
|
* necessarily called a "sector" by the vendor.
|
|
|
|
*/
|
|
|
|
unsigned sector_size;
|
|
|
|
u16 n_sectors;
|
|
|
|
|
|
|
|
u16 page_size;
|
|
|
|
u16 addr_width;
|
|
|
|
|
|
|
|
u32 flags;
|
|
|
|
#define SECT_4K BIT(0) /* SPINOR_OP_BE_4K works uniformly */
|
|
|
|
#define SPI_NOR_NO_ERASE BIT(1) /* No erase command needed */
|
|
|
|
#define SST_WRITE BIT(2) /* use SST byte programming */
|
|
|
|
#define SPI_NOR_NO_FR BIT(3) /* Can't do fastread */
|
|
|
|
#define SECT_4K_PMC BIT(4) /* SPINOR_OP_BE_4K_PMC works uniformly */
|
|
|
|
#define SPI_NOR_DUAL_READ BIT(5) /* Flash supports Dual Read */
|
|
|
|
#define SPI_NOR_QUAD_READ BIT(6) /* Flash supports Quad Read */
|
|
|
|
#define USE_FSR BIT(7) /* use flag status register */
|
|
|
|
#define SPI_NOR_HAS_LOCK BIT(8) /* Flash supports lock/unlock via SR */
|
|
|
|
#define SPI_NOR_HAS_TB BIT(9) /*
|
|
|
|
* Flash SR has Top/Bottom (TB) protect
|
|
|
|
* bit. Must be used with
|
|
|
|
* SPI_NOR_HAS_LOCK.
|
|
|
|
*/
|
|
|
|
#define SPI_NOR_XSR_RDY BIT(10) /*
|
|
|
|
* S3AN flashes have specific opcode to
|
|
|
|
* read the status register.
|
|
|
|
*/
|
|
|
|
#define SPI_NOR_4B_OPCODES BIT(11) /*
|
|
|
|
* Use dedicated 4byte address op codes
|
|
|
|
* to support memory size above 128Mib.
|
|
|
|
*/
|
|
|
|
#define NO_CHIP_ERASE BIT(12) /* Chip does not support chip erase */
|
|
|
|
#define SPI_NOR_SKIP_SFDP BIT(13) /* Skip parsing of SFDP tables */
|
|
|
|
#define USE_CLSR BIT(14) /* use CLSR command */
|
|
|
|
#define SPI_NOR_OCTAL_READ BIT(15) /* Flash supports Octal Read */
|
|
|
|
#define SPI_NOR_TB_SR_BIT6 BIT(16) /*
|
|
|
|
* Top/Bottom (TB) is bit 6 of
|
|
|
|
* status register. Must be used with
|
|
|
|
* SPI_NOR_HAS_TB.
|
|
|
|
*/
|
2020-03-18 20:06:14 +08:00
|
|
|
#define SPI_NOR_4BIT_BP BIT(17) /*
|
|
|
|
* Flash SR has 4 bit fields (BP0-3)
|
|
|
|
* for block protection.
|
|
|
|
*/
|
|
|
|
#define SPI_NOR_BP3_SR_BIT6 BIT(18) /*
|
|
|
|
* BP3 is bit 6 of status register.
|
|
|
|
* Must be used with SPI_NOR_4BIT_BP.
|
|
|
|
*/
|
2020-10-05 23:31:26 +08:00
|
|
|
#define SPI_NOR_OCTAL_DTR_READ BIT(19) /* Flash supports octal DTR Read. */
|
|
|
|
#define SPI_NOR_OCTAL_DTR_PP BIT(20) /* Flash supports Octal DTR Page Program */
|
2020-10-05 23:31:31 +08:00
|
|
|
#define SPI_NOR_IO_MODE_EN_VOLATILE BIT(21) /*
|
|
|
|
* Flash enables the best
|
|
|
|
* available I/O mode via a
|
|
|
|
* volatile bit.
|
|
|
|
*/
|
mtd: spi-nor: keep lock bits if they are non-volatile
Traditionally, Linux unlocks the whole flash because there are legacy
devices which has the write protection bits set by default at startup.
If you actually want to use the flash protection bits, eg. because there
is a read-only part for a bootloader, this automatic unlocking is
harmful. If there is no hardware write protection in place (usually
called WP#), a startup of the kernel just discards this protection.
I've gone through the datasheets of all the flashes (except the Intel
ones where I could not find any datasheet nor reference) which supports
the unlocking feature and looked how the sector protection was
implemented. The currently supported flashes can be divided into the
following two categories:
(1) block protection bits are non-volatile. Thus they keep their values
at reset and power-cycle
(2) flashes where these bits are volatile. After reset or power-cycle,
the whole memory array is protected.
(a) some devices needs a special "Global Unprotect" command, eg.
the Atmel AT25DF041A.
(b) some devices require to clear the BPn bits in the status
register.
Due to the reasons above, we do not want to clear the bits for flashes
which belong to category (1). Fortunately for us, only Atmel flashes
fall into category (2a). Implement the "Global Protect" and "Global
Unprotect" commands for these. For (2b) we can use normal block
protection locking scheme.
This patch adds a new flag to indicate the case (2). Only if we have
such a flash we unlock the whole flash array. To be backwards compatible
it also introduces a kernel configuration option which restores the
complete legacy behavior ("Disable write protection on any flashes").
Hopefully, this will clean up "unlock the entire flash for legacy
devices" once and for all.
For reference here are the actually commits which introduced the legacy
behavior (and extended the behavior to other chip manufacturers):
commit f80e521c916cb ("mtd: m25p80: add support for the Intel/Numonyx {16,32,64}0S33B SPI flash chips")
commit ea60658a08f8f ("mtd: m25p80: disable SST software protection bits by default")
commit 7228982442365 ("[MTD] m25p80: fix bug - ATmel spi flash fails to be copied to")
Actually, this might also fix handling of the Atmel AT25DF flashes,
because the original commit 7228982442365 ("[MTD] m25p80: fix bug -
ATmel spi flash fails to be copied to") was writing a 0 to the status
register, which is a "Global Unprotect". This might not be the case in
the current code which only handles the block protection bits BP2, BP1
and BP0. Thus, it depends on the current contents of the status register
if this unlock actually corresponds to a "Global Unprotect" command. In
the worst case, the current code might leave the AT25DF flashes in a
write protected state.
The commit 191f5c2ed4b6f ("mtd: spi-nor: use 16-bit WRR command when QE
is set on spansion flashes") changed that behavior by just clearing BP2
to BP0 instead of writing a 0 to the status register.
Further, the commit 3e0930f109e76 ("mtd: spi-nor: Rework the disabling
of block write protection") expanded the unlock_all() feature to ANY
flash which supports locking.
Signed-off-by: Michael Walle <michael@walle.cc>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20201203162959.29589-8-michael@walle.cc
2020-12-04 00:29:59 +08:00
|
|
|
#define SPI_NOR_SWP_IS_VOLATILE BIT(22) /*
|
|
|
|
* Flash has volatile software write
|
|
|
|
* protection bits. Usually these will
|
|
|
|
* power-up in a write-protected state.
|
|
|
|
*/
|
2020-03-14 03:42:38 +08:00
|
|
|
|
|
|
|
/* Part specific fixup hooks. */
|
|
|
|
const struct spi_nor_fixups *fixups;
|
|
|
|
};
|
|
|
|
|
|
|
|
/* Used when the "_ext_id" is two bytes at most */
|
|
|
|
#define INFO(_jedec_id, _ext_id, _sector_size, _n_sectors, _flags) \
|
|
|
|
.id = { \
|
|
|
|
((_jedec_id) >> 16) & 0xff, \
|
|
|
|
((_jedec_id) >> 8) & 0xff, \
|
|
|
|
(_jedec_id) & 0xff, \
|
|
|
|
((_ext_id) >> 8) & 0xff, \
|
|
|
|
(_ext_id) & 0xff, \
|
|
|
|
}, \
|
|
|
|
.id_len = (!(_jedec_id) ? 0 : (3 + ((_ext_id) ? 2 : 0))), \
|
|
|
|
.sector_size = (_sector_size), \
|
|
|
|
.n_sectors = (_n_sectors), \
|
|
|
|
.page_size = 256, \
|
|
|
|
.flags = (_flags),
|
|
|
|
|
|
|
|
#define INFO6(_jedec_id, _ext_id, _sector_size, _n_sectors, _flags) \
|
|
|
|
.id = { \
|
|
|
|
((_jedec_id) >> 16) & 0xff, \
|
|
|
|
((_jedec_id) >> 8) & 0xff, \
|
|
|
|
(_jedec_id) & 0xff, \
|
|
|
|
((_ext_id) >> 16) & 0xff, \
|
|
|
|
((_ext_id) >> 8) & 0xff, \
|
|
|
|
(_ext_id) & 0xff, \
|
|
|
|
}, \
|
|
|
|
.id_len = 6, \
|
|
|
|
.sector_size = (_sector_size), \
|
|
|
|
.n_sectors = (_n_sectors), \
|
|
|
|
.page_size = 256, \
|
|
|
|
.flags = (_flags),
|
|
|
|
|
|
|
|
#define CAT25_INFO(_sector_size, _n_sectors, _page_size, _addr_width, _flags) \
|
|
|
|
.sector_size = (_sector_size), \
|
|
|
|
.n_sectors = (_n_sectors), \
|
|
|
|
.page_size = (_page_size), \
|
|
|
|
.addr_width = (_addr_width), \
|
|
|
|
.flags = (_flags),
|
|
|
|
|
|
|
|
#define S3AN_INFO(_jedec_id, _n_sectors, _page_size) \
|
|
|
|
.id = { \
|
|
|
|
((_jedec_id) >> 16) & 0xff, \
|
|
|
|
((_jedec_id) >> 8) & 0xff, \
|
|
|
|
(_jedec_id) & 0xff \
|
|
|
|
}, \
|
|
|
|
.id_len = 3, \
|
|
|
|
.sector_size = (8*_page_size), \
|
|
|
|
.n_sectors = (_n_sectors), \
|
|
|
|
.page_size = _page_size, \
|
|
|
|
.addr_width = 3, \
|
2020-03-14 03:42:50 +08:00
|
|
|
.flags = SPI_NOR_NO_FR | SPI_NOR_XSR_RDY,
|
2020-03-14 03:42:38 +08:00
|
|
|
|
2020-03-14 03:42:39 +08:00
|
|
|
/**
|
|
|
|
* struct spi_nor_manufacturer - SPI NOR manufacturer object
|
|
|
|
* @name: manufacturer name
|
|
|
|
* @parts: array of parts supported by this manufacturer
|
|
|
|
* @nparts: number of entries in the parts array
|
|
|
|
* @fixups: hooks called at various points in time during spi_nor_scan()
|
|
|
|
*/
|
|
|
|
struct spi_nor_manufacturer {
|
|
|
|
const char *name;
|
|
|
|
const struct flash_info *parts;
|
|
|
|
unsigned int nparts;
|
|
|
|
const struct spi_nor_fixups *fixups;
|
|
|
|
};
|
|
|
|
|
2020-03-14 03:42:39 +08:00
|
|
|
/* Manufacturer drivers. */
|
|
|
|
extern const struct spi_nor_manufacturer spi_nor_atmel;
|
2020-03-14 03:42:49 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_catalyst;
|
2020-03-14 03:42:40 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_eon;
|
2020-03-14 03:42:41 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_esmt;
|
2020-03-14 03:42:41 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_everspin;
|
2020-03-14 03:42:42 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_fujitsu;
|
2020-03-14 03:42:43 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_gigadevice;
|
2020-03-14 03:42:43 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_intel;
|
2020-03-14 03:42:44 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_issi;
|
2020-03-14 03:42:45 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_macronix;
|
2020-03-14 03:42:46 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_micron;
|
|
|
|
extern const struct spi_nor_manufacturer spi_nor_st;
|
2020-03-14 03:42:46 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_spansion;
|
2020-03-14 03:42:47 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_sst;
|
2020-03-14 03:42:48 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_winbond;
|
2020-03-14 03:42:50 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_xilinx;
|
2020-03-14 03:42:50 +08:00
|
|
|
extern const struct spi_nor_manufacturer spi_nor_xmc;
|
2020-03-14 03:42:39 +08:00
|
|
|
|
2020-10-05 23:31:26 +08:00
|
|
|
void spi_nor_spimem_setup_op(const struct spi_nor *nor,
|
|
|
|
struct spi_mem_op *op,
|
|
|
|
const enum spi_nor_protocol proto);
|
2020-03-14 03:42:38 +08:00
|
|
|
int spi_nor_write_enable(struct spi_nor *nor);
|
|
|
|
int spi_nor_write_disable(struct spi_nor *nor);
|
|
|
|
int spi_nor_set_4byte_addr_mode(struct spi_nor *nor, bool enable);
|
|
|
|
int spi_nor_write_ear(struct spi_nor *nor, u8 ear);
|
|
|
|
int spi_nor_wait_till_ready(struct spi_nor *nor);
|
2021-01-21 19:05:45 +08:00
|
|
|
int spi_nor_global_block_unlock(struct spi_nor *nor);
|
2020-03-14 03:42:38 +08:00
|
|
|
int spi_nor_lock_and_prep(struct spi_nor *nor);
|
|
|
|
void spi_nor_unlock_and_unprep(struct spi_nor *nor);
|
2020-09-04 15:47:20 +08:00
|
|
|
int spi_nor_sr1_bit6_quad_enable(struct spi_nor *nor);
|
|
|
|
int spi_nor_sr2_bit1_quad_enable(struct spi_nor *nor);
|
|
|
|
int spi_nor_sr2_bit7_quad_enable(struct spi_nor *nor);
|
mtd: spi-nor: keep lock bits if they are non-volatile
Traditionally, Linux unlocks the whole flash because there are legacy
devices which has the write protection bits set by default at startup.
If you actually want to use the flash protection bits, eg. because there
is a read-only part for a bootloader, this automatic unlocking is
harmful. If there is no hardware write protection in place (usually
called WP#), a startup of the kernel just discards this protection.
I've gone through the datasheets of all the flashes (except the Intel
ones where I could not find any datasheet nor reference) which supports
the unlocking feature and looked how the sector protection was
implemented. The currently supported flashes can be divided into the
following two categories:
(1) block protection bits are non-volatile. Thus they keep their values
at reset and power-cycle
(2) flashes where these bits are volatile. After reset or power-cycle,
the whole memory array is protected.
(a) some devices needs a special "Global Unprotect" command, eg.
the Atmel AT25DF041A.
(b) some devices require to clear the BPn bits in the status
register.
Due to the reasons above, we do not want to clear the bits for flashes
which belong to category (1). Fortunately for us, only Atmel flashes
fall into category (2a). Implement the "Global Protect" and "Global
Unprotect" commands for these. For (2b) we can use normal block
protection locking scheme.
This patch adds a new flag to indicate the case (2). Only if we have
such a flash we unlock the whole flash array. To be backwards compatible
it also introduces a kernel configuration option which restores the
complete legacy behavior ("Disable write protection on any flashes").
Hopefully, this will clean up "unlock the entire flash for legacy
devices" once and for all.
For reference here are the actually commits which introduced the legacy
behavior (and extended the behavior to other chip manufacturers):
commit f80e521c916cb ("mtd: m25p80: add support for the Intel/Numonyx {16,32,64}0S33B SPI flash chips")
commit ea60658a08f8f ("mtd: m25p80: disable SST software protection bits by default")
commit 7228982442365 ("[MTD] m25p80: fix bug - ATmel spi flash fails to be copied to")
Actually, this might also fix handling of the Atmel AT25DF flashes,
because the original commit 7228982442365 ("[MTD] m25p80: fix bug -
ATmel spi flash fails to be copied to") was writing a 0 to the status
register, which is a "Global Unprotect". This might not be the case in
the current code which only handles the block protection bits BP2, BP1
and BP0. Thus, it depends on the current contents of the status register
if this unlock actually corresponds to a "Global Unprotect" command. In
the worst case, the current code might leave the AT25DF flashes in a
write protected state.
The commit 191f5c2ed4b6f ("mtd: spi-nor: use 16-bit WRR command when QE
is set on spansion flashes") changed that behavior by just clearing BP2
to BP0 instead of writing a 0 to the status register.
Further, the commit 3e0930f109e76 ("mtd: spi-nor: Rework the disabling
of block write protection") expanded the unlock_all() feature to ANY
flash which supports locking.
Signed-off-by: Michael Walle <michael@walle.cc>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20201203162959.29589-8-michael@walle.cc
2020-12-04 00:29:59 +08:00
|
|
|
int spi_nor_read_sr(struct spi_nor *nor, u8 *sr);
|
|
|
|
int spi_nor_write_sr(struct spi_nor *nor, const u8 *sr, size_t len);
|
2020-12-04 00:29:58 +08:00
|
|
|
int spi_nor_write_sr_and_check(struct spi_nor *nor, u8 sr1);
|
2020-03-14 03:42:37 +08:00
|
|
|
|
2020-03-14 03:42:38 +08:00
|
|
|
int spi_nor_xread_sr(struct spi_nor *nor, u8 *sr);
|
2020-03-14 03:42:37 +08:00
|
|
|
ssize_t spi_nor_read_data(struct spi_nor *nor, loff_t from, size_t len,
|
|
|
|
u8 *buf);
|
2020-03-14 03:42:38 +08:00
|
|
|
ssize_t spi_nor_write_data(struct spi_nor *nor, loff_t to, size_t len,
|
|
|
|
const u8 *buf);
|
2020-03-14 03:42:37 +08:00
|
|
|
|
|
|
|
int spi_nor_hwcaps_read2cmd(u32 hwcaps);
|
|
|
|
u8 spi_nor_convert_3to4_read(u8 opcode);
|
2020-10-05 23:31:28 +08:00
|
|
|
void spi_nor_set_read_settings(struct spi_nor_read_command *read,
|
|
|
|
u8 num_mode_clocks,
|
|
|
|
u8 num_wait_states,
|
|
|
|
u8 opcode,
|
|
|
|
enum spi_nor_protocol proto);
|
2020-03-14 03:42:37 +08:00
|
|
|
void spi_nor_set_pp_settings(struct spi_nor_pp_command *pp, u8 opcode,
|
|
|
|
enum spi_nor_protocol proto);
|
|
|
|
|
|
|
|
void spi_nor_set_erase_type(struct spi_nor_erase_type *erase, u32 size,
|
|
|
|
u8 opcode);
|
|
|
|
struct spi_nor_erase_region *
|
|
|
|
spi_nor_region_next(struct spi_nor_erase_region *region);
|
|
|
|
void spi_nor_init_uniform_erase_map(struct spi_nor_erase_map *map,
|
|
|
|
u8 erase_mask, u64 flash_size);
|
|
|
|
|
|
|
|
int spi_nor_post_bfpt_fixups(struct spi_nor *nor,
|
|
|
|
const struct sfdp_parameter_header *bfpt_header,
|
|
|
|
const struct sfdp_bfpt *bfpt,
|
|
|
|
struct spi_nor_flash_parameter *params);
|
|
|
|
|
2020-03-14 03:42:38 +08:00
|
|
|
static struct spi_nor __maybe_unused *mtd_to_spi_nor(struct mtd_info *mtd)
|
|
|
|
{
|
|
|
|
return mtd->priv;
|
|
|
|
}
|
|
|
|
|
2020-03-14 03:42:37 +08:00
|
|
|
#endif /* __LINUX_MTD_SPI_NOR_INTERNAL_H */
|