2018-08-08 00:18:26 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0+
|
|
|
|
|
//
|
|
|
|
|
// Copyright (c) 2011 Samsung Electronics Co., Ltd
|
|
|
|
|
// http://www.samsung.com
|
2012-01-09 18:10:25 +08:00
|
|
|
|
|
|
|
|
#include <linux/err.h>
|
2013-02-04 07:49:47 +08:00
|
|
|
#include <linux/of_gpio.h>
|
2018-05-14 16:06:32 +08:00
|
|
|
#include <linux/gpio/consumer.h>
|
2012-01-09 18:10:25 +08:00
|
|
|
#include <linux/module.h>
|
|
|
|
|
#include <linux/platform_device.h>
|
|
|
|
|
#include <linux/regulator/driver.h>
|
|
|
|
|
#include <linux/regulator/machine.h>
|
2012-07-11 20:07:16 +08:00
|
|
|
#include <linux/mfd/samsung/core.h>
|
|
|
|
|
#include <linux/mfd/samsung/s5m8767.h>
|
2013-02-04 07:49:47 +08:00
|
|
|
#include <linux/regulator/of_regulator.h>
|
2013-12-17 21:23:18 +08:00
|
|
|
#include <linux/regmap.h>
|
2013-02-04 07:49:47 +08:00
|
|
|
|
|
|
|
|
#define S5M8767_OPMODE_NORMAL_MODE 0x1
|
2012-01-09 18:10:25 +08:00
|
|
|
|
|
|
|
|
struct s5m8767_info {
|
|
|
|
|
struct device *dev;
|
2012-07-11 20:06:55 +08:00
|
|
|
struct sec_pmic_dev *iodev;
|
2012-01-09 18:10:25 +08:00
|
|
|
int num_regulators;
|
2012-07-11 20:06:55 +08:00
|
|
|
struct sec_opmode_data *opmode;
|
2012-01-09 18:10:25 +08:00
|
|
|
|
|
|
|
|
int ramp_delay;
|
|
|
|
|
bool buck2_ramp;
|
|
|
|
|
bool buck3_ramp;
|
|
|
|
|
bool buck4_ramp;
|
|
|
|
|
|
|
|
|
|
bool buck2_gpiodvs;
|
|
|
|
|
bool buck3_gpiodvs;
|
|
|
|
|
bool buck4_gpiodvs;
|
|
|
|
|
u8 buck2_vol[8];
|
|
|
|
|
u8 buck3_vol[8];
|
|
|
|
|
u8 buck4_vol[8];
|
|
|
|
|
int buck_gpios[3];
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
int buck_ds[3];
|
2012-01-09 18:10:25 +08:00
|
|
|
int buck_gpioindex;
|
|
|
|
|
};
|
|
|
|
|
|
2012-07-11 20:06:55 +08:00
|
|
|
struct sec_voltage_desc {
|
2012-01-09 18:10:25 +08:00
|
|
|
int max;
|
|
|
|
|
int min;
|
|
|
|
|
int step;
|
|
|
|
|
};
|
|
|
|
|
|
2012-07-11 20:06:55 +08:00
|
|
|
static const struct sec_voltage_desc buck_voltage_val1 = {
|
2012-01-09 18:10:25 +08:00
|
|
|
.max = 2225000,
|
|
|
|
|
.min = 650000,
|
|
|
|
|
.step = 6250,
|
|
|
|
|
};
|
|
|
|
|
|
2012-07-11 20:06:55 +08:00
|
|
|
static const struct sec_voltage_desc buck_voltage_val2 = {
|
2012-01-09 18:10:25 +08:00
|
|
|
.max = 1600000,
|
|
|
|
|
.min = 600000,
|
|
|
|
|
.step = 6250,
|
|
|
|
|
};
|
|
|
|
|
|
2012-07-11 20:06:55 +08:00
|
|
|
static const struct sec_voltage_desc buck_voltage_val3 = {
|
2012-01-09 18:10:25 +08:00
|
|
|
.max = 3000000,
|
|
|
|
|
.min = 750000,
|
|
|
|
|
.step = 12500,
|
|
|
|
|
};
|
|
|
|
|
|
2012-07-11 20:06:55 +08:00
|
|
|
static const struct sec_voltage_desc ldo_voltage_val1 = {
|
2012-01-09 18:10:25 +08:00
|
|
|
.max = 3950000,
|
|
|
|
|
.min = 800000,
|
|
|
|
|
.step = 50000,
|
|
|
|
|
};
|
|
|
|
|
|
2012-07-11 20:06:55 +08:00
|
|
|
static const struct sec_voltage_desc ldo_voltage_val2 = {
|
2012-01-09 18:10:25 +08:00
|
|
|
.max = 2375000,
|
|
|
|
|
.min = 800000,
|
|
|
|
|
.step = 25000,
|
|
|
|
|
};
|
|
|
|
|
|
2012-07-11 20:06:55 +08:00
|
|
|
static const struct sec_voltage_desc *reg_voltage_map[] = {
|
2012-01-09 18:10:25 +08:00
|
|
|
[S5M8767_LDO1] = &ldo_voltage_val2,
|
|
|
|
|
[S5M8767_LDO2] = &ldo_voltage_val2,
|
|
|
|
|
[S5M8767_LDO3] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO4] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO5] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO6] = &ldo_voltage_val2,
|
|
|
|
|
[S5M8767_LDO7] = &ldo_voltage_val2,
|
|
|
|
|
[S5M8767_LDO8] = &ldo_voltage_val2,
|
|
|
|
|
[S5M8767_LDO9] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO10] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO11] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO12] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO13] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO14] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO15] = &ldo_voltage_val2,
|
|
|
|
|
[S5M8767_LDO16] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO17] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO18] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO19] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO20] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO21] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO22] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO23] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO24] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO25] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO26] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO27] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_LDO28] = &ldo_voltage_val1,
|
|
|
|
|
[S5M8767_BUCK1] = &buck_voltage_val1,
|
|
|
|
|
[S5M8767_BUCK2] = &buck_voltage_val2,
|
|
|
|
|
[S5M8767_BUCK3] = &buck_voltage_val2,
|
|
|
|
|
[S5M8767_BUCK4] = &buck_voltage_val2,
|
|
|
|
|
[S5M8767_BUCK5] = &buck_voltage_val1,
|
|
|
|
|
[S5M8767_BUCK6] = &buck_voltage_val1,
|
2013-12-10 17:09:43 +08:00
|
|
|
[S5M8767_BUCK7] = &buck_voltage_val3,
|
|
|
|
|
[S5M8767_BUCK8] = &buck_voltage_val3,
|
2012-01-09 18:10:25 +08:00
|
|
|
[S5M8767_BUCK9] = &buck_voltage_val3,
|
|
|
|
|
};
|
|
|
|
|
|
2019-02-21 21:17:21 +08:00
|
|
|
static const unsigned int s5m8767_opmode_reg[][4] = {
|
2012-03-09 16:55:34 +08:00
|
|
|
/* {OFF, ON, LOWPOWER, SUSPEND} */
|
|
|
|
|
/* LDO1 ... LDO28 */
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1}, /* LDO1 */
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x0, 0x0, 0x0},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1}, /* LDO5 */
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1}, /* LDO10 */
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1}, /* LDO15 */
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x0, 0x0, 0x0},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1}, /* LDO20 */
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x0, 0x0, 0x0},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1}, /* LDO25 */
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1}, /* LDO28 */
|
|
|
|
|
|
|
|
|
|
/* BUCK1 ... BUCK9 */
|
|
|
|
|
{0x0, 0x3, 0x1, 0x1}, /* BUCK1 */
|
|
|
|
|
{0x0, 0x3, 0x1, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x1, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x1, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x2, 0x1}, /* BUCK5 */
|
|
|
|
|
{0x0, 0x3, 0x1, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x1, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x1, 0x1},
|
|
|
|
|
{0x0, 0x3, 0x1, 0x1}, /* BUCK9 */
|
|
|
|
|
};
|
|
|
|
|
|
2014-03-21 14:54:08 +08:00
|
|
|
static int s5m8767_get_register(struct s5m8767_info *s5m8767, int reg_id,
|
|
|
|
|
int *reg, int *enable_ctrl)
|
2012-01-09 18:10:25 +08:00
|
|
|
{
|
2014-03-21 14:54:08 +08:00
|
|
|
int i;
|
2012-03-09 16:55:34 +08:00
|
|
|
unsigned int mode;
|
2012-01-09 18:10:25 +08:00
|
|
|
|
|
|
|
|
switch (reg_id) {
|
|
|
|
|
case S5M8767_LDO1 ... S5M8767_LDO2:
|
|
|
|
|
*reg = S5M8767_REG_LDO1CTRL + (reg_id - S5M8767_LDO1);
|
|
|
|
|
break;
|
|
|
|
|
case S5M8767_LDO3 ... S5M8767_LDO28:
|
|
|
|
|
*reg = S5M8767_REG_LDO3CTRL + (reg_id - S5M8767_LDO3);
|
|
|
|
|
break;
|
|
|
|
|
case S5M8767_BUCK1:
|
|
|
|
|
*reg = S5M8767_REG_BUCK1CTRL1;
|
|
|
|
|
break;
|
|
|
|
|
case S5M8767_BUCK2 ... S5M8767_BUCK4:
|
|
|
|
|
*reg = S5M8767_REG_BUCK2CTRL + (reg_id - S5M8767_BUCK2) * 9;
|
|
|
|
|
break;
|
|
|
|
|
case S5M8767_BUCK5:
|
|
|
|
|
*reg = S5M8767_REG_BUCK5CTRL1;
|
|
|
|
|
break;
|
|
|
|
|
case S5M8767_BUCK6 ... S5M8767_BUCK9:
|
|
|
|
|
*reg = S5M8767_REG_BUCK6CTRL1 + (reg_id - S5M8767_BUCK6) * 2;
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
|
2012-12-10 20:49:39 +08:00
|
|
|
for (i = 0; i < s5m8767->num_regulators; i++) {
|
|
|
|
|
if (s5m8767->opmode[i].id == reg_id) {
|
|
|
|
|
mode = s5m8767->opmode[i].mode;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-02-16 22:53:11 +08:00
|
|
|
if (i >= s5m8767->num_regulators)
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
|
|
*enable_ctrl = s5m8767_opmode_reg[reg_id][mode] << S5M8767_ENCTRL_SHIFT;
|
2012-12-10 20:49:39 +08:00
|
|
|
|
2012-01-09 18:10:25 +08:00
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2013-01-18 09:55:06 +08:00
|
|
|
static int s5m8767_get_vsel_reg(int reg_id, struct s5m8767_info *s5m8767)
|
2012-01-09 18:10:25 +08:00
|
|
|
{
|
|
|
|
|
int reg;
|
|
|
|
|
|
|
|
|
|
switch (reg_id) {
|
|
|
|
|
case S5M8767_LDO1 ... S5M8767_LDO2:
|
|
|
|
|
reg = S5M8767_REG_LDO1CTRL + (reg_id - S5M8767_LDO1);
|
|
|
|
|
break;
|
|
|
|
|
case S5M8767_LDO3 ... S5M8767_LDO28:
|
|
|
|
|
reg = S5M8767_REG_LDO3CTRL + (reg_id - S5M8767_LDO3);
|
|
|
|
|
break;
|
|
|
|
|
case S5M8767_BUCK1:
|
|
|
|
|
reg = S5M8767_REG_BUCK1CTRL2;
|
|
|
|
|
break;
|
|
|
|
|
case S5M8767_BUCK2:
|
2012-12-10 20:49:40 +08:00
|
|
|
reg = S5M8767_REG_BUCK2DVS1;
|
2012-03-10 10:59:43 +08:00
|
|
|
if (s5m8767->buck2_gpiodvs)
|
|
|
|
|
reg += s5m8767->buck_gpioindex;
|
2012-01-09 18:10:25 +08:00
|
|
|
break;
|
|
|
|
|
case S5M8767_BUCK3:
|
2012-12-10 20:49:40 +08:00
|
|
|
reg = S5M8767_REG_BUCK3DVS1;
|
2012-03-10 10:59:43 +08:00
|
|
|
if (s5m8767->buck3_gpiodvs)
|
|
|
|
|
reg += s5m8767->buck_gpioindex;
|
2012-01-09 18:10:25 +08:00
|
|
|
break;
|
|
|
|
|
case S5M8767_BUCK4:
|
2012-12-10 20:49:40 +08:00
|
|
|
reg = S5M8767_REG_BUCK4DVS1;
|
2012-03-10 10:59:43 +08:00
|
|
|
if (s5m8767->buck4_gpiodvs)
|
|
|
|
|
reg += s5m8767->buck_gpioindex;
|
2012-01-09 18:10:25 +08:00
|
|
|
break;
|
|
|
|
|
case S5M8767_BUCK5:
|
|
|
|
|
reg = S5M8767_REG_BUCK5CTRL2;
|
|
|
|
|
break;
|
|
|
|
|
case S5M8767_BUCK6 ... S5M8767_BUCK9:
|
|
|
|
|
reg = S5M8767_REG_BUCK6CTRL2 + (reg_id - S5M8767_BUCK6) * 2;
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
|
2013-01-18 09:55:06 +08:00
|
|
|
return reg;
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
|
2012-12-29 09:38:50 +08:00
|
|
|
static int s5m8767_convert_voltage_to_sel(const struct sec_voltage_desc *desc,
|
|
|
|
|
int min_vol)
|
2012-01-09 18:10:25 +08:00
|
|
|
{
|
2012-03-09 11:31:08 +08:00
|
|
|
int selector = 0;
|
2012-01-09 18:10:25 +08:00
|
|
|
|
|
|
|
|
if (desc == NULL)
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
2012-12-29 09:38:50 +08:00
|
|
|
if (min_vol > desc->max)
|
2012-01-09 18:10:25 +08:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
2012-04-13 09:30:05 +08:00
|
|
|
if (min_vol < desc->min)
|
|
|
|
|
min_vol = desc->min;
|
|
|
|
|
|
|
|
|
|
selector = DIV_ROUND_UP(min_vol - desc->min, desc->step);
|
2012-01-09 18:10:25 +08:00
|
|
|
|
2012-12-29 09:38:50 +08:00
|
|
|
if (desc->min + desc->step * selector > desc->max)
|
2012-01-09 18:10:25 +08:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
2012-03-09 11:31:08 +08:00
|
|
|
return selector;
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
|
2012-06-13 16:28:18 +08:00
|
|
|
static inline int s5m8767_set_high(struct s5m8767_info *s5m8767)
|
2012-04-10 14:05:44 +08:00
|
|
|
{
|
|
|
|
|
int temp_index = s5m8767->buck_gpioindex;
|
|
|
|
|
|
|
|
|
|
gpio_set_value(s5m8767->buck_gpios[0], (temp_index >> 2) & 0x1);
|
|
|
|
|
gpio_set_value(s5m8767->buck_gpios[1], (temp_index >> 1) & 0x1);
|
|
|
|
|
gpio_set_value(s5m8767->buck_gpios[2], temp_index & 0x1);
|
2012-06-13 16:28:18 +08:00
|
|
|
|
|
|
|
|
return 0;
|
2012-04-10 14:05:44 +08:00
|
|
|
}
|
|
|
|
|
|
2012-06-13 16:28:18 +08:00
|
|
|
static inline int s5m8767_set_low(struct s5m8767_info *s5m8767)
|
2012-04-10 14:05:44 +08:00
|
|
|
{
|
|
|
|
|
int temp_index = s5m8767->buck_gpioindex;
|
|
|
|
|
|
|
|
|
|
gpio_set_value(s5m8767->buck_gpios[2], temp_index & 0x1);
|
|
|
|
|
gpio_set_value(s5m8767->buck_gpios[1], (temp_index >> 1) & 0x1);
|
|
|
|
|
gpio_set_value(s5m8767->buck_gpios[0], (temp_index >> 2) & 0x1);
|
2012-06-13 16:28:18 +08:00
|
|
|
|
|
|
|
|
return 0;
|
2012-04-10 14:05:44 +08:00
|
|
|
}
|
|
|
|
|
|
2012-06-13 16:28:18 +08:00
|
|
|
static int s5m8767_set_voltage_sel(struct regulator_dev *rdev,
|
|
|
|
|
unsigned selector)
|
2012-01-09 18:10:25 +08:00
|
|
|
{
|
|
|
|
|
struct s5m8767_info *s5m8767 = rdev_get_drvdata(rdev);
|
2012-01-31 15:13:31 +08:00
|
|
|
int reg_id = rdev_get_id(rdev);
|
2013-01-18 09:55:06 +08:00
|
|
|
int old_index, index = 0;
|
2012-04-10 14:05:44 +08:00
|
|
|
u8 *buck234_vol = NULL;
|
2012-01-09 18:10:25 +08:00
|
|
|
|
|
|
|
|
switch (reg_id) {
|
|
|
|
|
case S5M8767_LDO1 ... S5M8767_LDO28:
|
|
|
|
|
break;
|
|
|
|
|
case S5M8767_BUCK1 ... S5M8767_BUCK6:
|
2012-04-10 14:05:44 +08:00
|
|
|
if (reg_id == S5M8767_BUCK2 && s5m8767->buck2_gpiodvs)
|
|
|
|
|
buck234_vol = &s5m8767->buck2_vol[0];
|
|
|
|
|
else if (reg_id == S5M8767_BUCK3 && s5m8767->buck3_gpiodvs)
|
|
|
|
|
buck234_vol = &s5m8767->buck3_vol[0];
|
|
|
|
|
else if (reg_id == S5M8767_BUCK4 && s5m8767->buck4_gpiodvs)
|
|
|
|
|
buck234_vol = &s5m8767->buck4_vol[0];
|
2012-01-09 18:10:25 +08:00
|
|
|
break;
|
|
|
|
|
case S5M8767_BUCK7 ... S5M8767_BUCK8:
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
case S5M8767_BUCK9:
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
|
2012-04-10 14:05:44 +08:00
|
|
|
/* buck234_vol != NULL means to control buck234 voltage via DVS GPIO */
|
|
|
|
|
if (buck234_vol) {
|
2012-06-13 16:28:18 +08:00
|
|
|
while (*buck234_vol != selector) {
|
2012-04-10 14:05:44 +08:00
|
|
|
buck234_vol++;
|
|
|
|
|
index++;
|
|
|
|
|
}
|
|
|
|
|
old_index = s5m8767->buck_gpioindex;
|
|
|
|
|
s5m8767->buck_gpioindex = index;
|
|
|
|
|
|
|
|
|
|
if (index > old_index)
|
2012-06-13 16:28:18 +08:00
|
|
|
return s5m8767_set_high(s5m8767);
|
2012-04-10 14:05:44 +08:00
|
|
|
else
|
2012-06-13 16:28:18 +08:00
|
|
|
return s5m8767_set_low(s5m8767);
|
2012-04-10 14:05:44 +08:00
|
|
|
} else {
|
2013-01-18 09:55:06 +08:00
|
|
|
return regulator_set_voltage_sel_regmap(rdev, selector);
|
2012-04-10 14:05:44 +08:00
|
|
|
}
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int s5m8767_set_voltage_time_sel(struct regulator_dev *rdev,
|
|
|
|
|
unsigned int old_sel,
|
|
|
|
|
unsigned int new_sel)
|
|
|
|
|
{
|
|
|
|
|
struct s5m8767_info *s5m8767 = rdev_get_drvdata(rdev);
|
|
|
|
|
|
2012-06-13 16:27:16 +08:00
|
|
|
if ((old_sel < new_sel) && s5m8767->ramp_delay)
|
2019-02-21 21:17:22 +08:00
|
|
|
return DIV_ROUND_UP(rdev->desc->uV_step * (new_sel - old_sel),
|
2012-03-09 15:28:10 +08:00
|
|
|
s5m8767->ramp_delay * 1000);
|
2012-02-24 14:52:45 +08:00
|
|
|
return 0;
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
|
2017-03-12 03:01:23 +08:00
|
|
|
static const struct regulator_ops s5m8767_ops = {
|
2012-06-18 14:25:27 +08:00
|
|
|
.list_voltage = regulator_list_voltage_linear,
|
2014-03-21 14:54:08 +08:00
|
|
|
.is_enabled = regulator_is_enabled_regmap,
|
|
|
|
|
.enable = regulator_enable_regmap,
|
|
|
|
|
.disable = regulator_disable_regmap,
|
2013-01-18 09:55:06 +08:00
|
|
|
.get_voltage_sel = regulator_get_voltage_sel_regmap,
|
2012-06-13 16:28:18 +08:00
|
|
|
.set_voltage_sel = s5m8767_set_voltage_sel,
|
2012-01-09 18:10:25 +08:00
|
|
|
.set_voltage_time_sel = s5m8767_set_voltage_time_sel,
|
|
|
|
|
};
|
|
|
|
|
|
2017-03-12 03:01:23 +08:00
|
|
|
static const struct regulator_ops s5m8767_buck78_ops = {
|
2013-12-10 17:09:43 +08:00
|
|
|
.list_voltage = regulator_list_voltage_linear,
|
2014-03-21 14:54:08 +08:00
|
|
|
.is_enabled = regulator_is_enabled_regmap,
|
|
|
|
|
.enable = regulator_enable_regmap,
|
|
|
|
|
.disable = regulator_disable_regmap,
|
2013-12-10 17:09:43 +08:00
|
|
|
.get_voltage_sel = regulator_get_voltage_sel_regmap,
|
|
|
|
|
.set_voltage_sel = regulator_set_voltage_sel_regmap,
|
2012-06-18 14:25:27 +08:00
|
|
|
};
|
|
|
|
|
|
2012-04-10 14:08:19 +08:00
|
|
|
#define s5m8767_regulator_desc(_name) { \
|
|
|
|
|
.name = #_name, \
|
|
|
|
|
.id = S5M8767_##_name, \
|
|
|
|
|
.ops = &s5m8767_ops, \
|
2012-01-09 18:10:25 +08:00
|
|
|
.type = REGULATOR_VOLTAGE, \
|
|
|
|
|
.owner = THIS_MODULE, \
|
|
|
|
|
}
|
|
|
|
|
|
2012-06-18 14:25:27 +08:00
|
|
|
#define s5m8767_regulator_buck78_desc(_name) { \
|
|
|
|
|
.name = #_name, \
|
|
|
|
|
.id = S5M8767_##_name, \
|
|
|
|
|
.ops = &s5m8767_buck78_ops, \
|
|
|
|
|
.type = REGULATOR_VOLTAGE, \
|
|
|
|
|
.owner = THIS_MODULE, \
|
|
|
|
|
}
|
|
|
|
|
|
2012-01-09 18:10:25 +08:00
|
|
|
static struct regulator_desc regulators[] = {
|
2012-04-10 14:08:19 +08:00
|
|
|
s5m8767_regulator_desc(LDO1),
|
|
|
|
|
s5m8767_regulator_desc(LDO2),
|
|
|
|
|
s5m8767_regulator_desc(LDO3),
|
|
|
|
|
s5m8767_regulator_desc(LDO4),
|
|
|
|
|
s5m8767_regulator_desc(LDO5),
|
|
|
|
|
s5m8767_regulator_desc(LDO6),
|
|
|
|
|
s5m8767_regulator_desc(LDO7),
|
|
|
|
|
s5m8767_regulator_desc(LDO8),
|
|
|
|
|
s5m8767_regulator_desc(LDO9),
|
|
|
|
|
s5m8767_regulator_desc(LDO10),
|
|
|
|
|
s5m8767_regulator_desc(LDO11),
|
|
|
|
|
s5m8767_regulator_desc(LDO12),
|
|
|
|
|
s5m8767_regulator_desc(LDO13),
|
|
|
|
|
s5m8767_regulator_desc(LDO14),
|
|
|
|
|
s5m8767_regulator_desc(LDO15),
|
|
|
|
|
s5m8767_regulator_desc(LDO16),
|
|
|
|
|
s5m8767_regulator_desc(LDO17),
|
|
|
|
|
s5m8767_regulator_desc(LDO18),
|
|
|
|
|
s5m8767_regulator_desc(LDO19),
|
|
|
|
|
s5m8767_regulator_desc(LDO20),
|
|
|
|
|
s5m8767_regulator_desc(LDO21),
|
|
|
|
|
s5m8767_regulator_desc(LDO22),
|
|
|
|
|
s5m8767_regulator_desc(LDO23),
|
|
|
|
|
s5m8767_regulator_desc(LDO24),
|
|
|
|
|
s5m8767_regulator_desc(LDO25),
|
|
|
|
|
s5m8767_regulator_desc(LDO26),
|
|
|
|
|
s5m8767_regulator_desc(LDO27),
|
|
|
|
|
s5m8767_regulator_desc(LDO28),
|
|
|
|
|
s5m8767_regulator_desc(BUCK1),
|
|
|
|
|
s5m8767_regulator_desc(BUCK2),
|
|
|
|
|
s5m8767_regulator_desc(BUCK3),
|
|
|
|
|
s5m8767_regulator_desc(BUCK4),
|
|
|
|
|
s5m8767_regulator_desc(BUCK5),
|
|
|
|
|
s5m8767_regulator_desc(BUCK6),
|
2012-06-18 14:25:27 +08:00
|
|
|
s5m8767_regulator_buck78_desc(BUCK7),
|
|
|
|
|
s5m8767_regulator_buck78_desc(BUCK8),
|
2012-04-10 14:08:19 +08:00
|
|
|
s5m8767_regulator_desc(BUCK9),
|
2012-01-09 18:10:25 +08:00
|
|
|
};
|
|
|
|
|
|
2014-01-24 21:37:57 +08:00
|
|
|
/*
|
|
|
|
|
* Enable GPIO control over BUCK9 in regulator_config for that regulator.
|
|
|
|
|
*/
|
|
|
|
|
static void s5m8767_regulator_config_ext_control(struct s5m8767_info *s5m8767,
|
|
|
|
|
struct sec_regulator_data *rdata,
|
|
|
|
|
struct regulator_config *config)
|
|
|
|
|
{
|
|
|
|
|
int i, mode = 0;
|
|
|
|
|
|
|
|
|
|
if (rdata->id != S5M8767_BUCK9)
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
/* Check if opmode for regulator matches S5M8767_ENCTRL_USE_GPIO */
|
|
|
|
|
for (i = 0; i < s5m8767->num_regulators; i++) {
|
|
|
|
|
const struct sec_opmode_data *opmode = &s5m8767->opmode[i];
|
|
|
|
|
if (opmode->id == rdata->id) {
|
|
|
|
|
mode = s5m8767_opmode_reg[rdata->id][opmode->mode];
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if (mode != S5M8767_ENCTRL_USE_GPIO) {
|
|
|
|
|
dev_warn(s5m8767->dev,
|
2018-08-28 09:52:42 +08:00
|
|
|
"ext-control for %pOFn: mismatched op_mode (%x), ignoring\n",
|
|
|
|
|
rdata->reg_node, mode);
|
2014-01-24 21:37:57 +08:00
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2018-05-14 16:06:32 +08:00
|
|
|
if (!rdata->ext_control_gpiod) {
|
2014-01-24 21:37:57 +08:00
|
|
|
dev_warn(s5m8767->dev,
|
2018-08-28 09:52:42 +08:00
|
|
|
"ext-control for %pOFn: GPIO not valid, ignoring\n",
|
|
|
|
|
rdata->reg_node);
|
2014-01-24 21:37:57 +08:00
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2018-05-14 16:06:32 +08:00
|
|
|
config->ena_gpiod = rdata->ext_control_gpiod;
|
2014-01-24 21:37:57 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Turn on GPIO control over BUCK9.
|
|
|
|
|
*/
|
|
|
|
|
static int s5m8767_enable_ext_control(struct s5m8767_info *s5m8767,
|
|
|
|
|
struct regulator_dev *rdev)
|
|
|
|
|
{
|
2014-03-21 14:54:08 +08:00
|
|
|
int id = rdev_get_id(rdev);
|
2014-01-24 21:37:57 +08:00
|
|
|
int ret, reg, enable_ctrl;
|
|
|
|
|
|
2014-03-21 14:54:08 +08:00
|
|
|
if (id != S5M8767_BUCK9)
|
2014-01-24 21:37:57 +08:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
2014-03-21 14:54:08 +08:00
|
|
|
ret = s5m8767_get_register(s5m8767, id, ®, &enable_ctrl);
|
2014-01-24 21:37:57 +08:00
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
|
|
return regmap_update_bits(s5m8767->iodev->regmap_pmic,
|
|
|
|
|
reg, S5M8767_ENCTRL_MASK,
|
|
|
|
|
S5M8767_ENCTRL_USE_GPIO << S5M8767_ENCTRL_SHIFT);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
2013-02-04 07:49:47 +08:00
|
|
|
#ifdef CONFIG_OF
|
|
|
|
|
static int s5m8767_pmic_dt_parse_dvs_gpio(struct sec_pmic_dev *iodev,
|
|
|
|
|
struct sec_platform_data *pdata,
|
|
|
|
|
struct device_node *pmic_np)
|
|
|
|
|
{
|
|
|
|
|
int i, gpio;
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < 3; i++) {
|
|
|
|
|
gpio = of_get_named_gpio(pmic_np,
|
|
|
|
|
"s5m8767,pmic-buck-dvs-gpios", i);
|
|
|
|
|
if (!gpio_is_valid(gpio)) {
|
|
|
|
|
dev_err(iodev->dev, "invalid gpio[%d]: %d\n", i, gpio);
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
pdata->buck_gpios[i] = gpio;
|
|
|
|
|
}
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int s5m8767_pmic_dt_parse_ds_gpio(struct sec_pmic_dev *iodev,
|
|
|
|
|
struct sec_platform_data *pdata,
|
|
|
|
|
struct device_node *pmic_np)
|
|
|
|
|
{
|
|
|
|
|
int i, gpio;
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < 3; i++) {
|
|
|
|
|
gpio = of_get_named_gpio(pmic_np,
|
|
|
|
|
"s5m8767,pmic-buck-ds-gpios", i);
|
|
|
|
|
if (!gpio_is_valid(gpio)) {
|
|
|
|
|
dev_err(iodev->dev, "invalid gpio[%d]: %d\n", i, gpio);
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
pdata->buck_ds[i] = gpio;
|
|
|
|
|
}
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2013-02-13 09:29:45 +08:00
|
|
|
static int s5m8767_pmic_dt_parse_pdata(struct platform_device *pdev,
|
2013-02-04 07:49:47 +08:00
|
|
|
struct sec_platform_data *pdata)
|
|
|
|
|
{
|
2013-02-13 09:29:45 +08:00
|
|
|
struct sec_pmic_dev *iodev = dev_get_drvdata(pdev->dev.parent);
|
2013-02-04 07:49:47 +08:00
|
|
|
struct device_node *pmic_np, *regulators_np, *reg_np;
|
|
|
|
|
struct sec_regulator_data *rdata;
|
|
|
|
|
struct sec_opmode_data *rmode;
|
2013-10-10 09:41:36 +08:00
|
|
|
unsigned int i, dvs_voltage_nr = 8, ret;
|
2013-02-04 07:49:47 +08:00
|
|
|
|
|
|
|
|
pmic_np = iodev->dev->of_node;
|
|
|
|
|
if (!pmic_np) {
|
|
|
|
|
dev_err(iodev->dev, "could not find pmic sub-node\n");
|
|
|
|
|
return -ENODEV;
|
|
|
|
|
}
|
|
|
|
|
|
2014-02-13 19:35:06 +08:00
|
|
|
regulators_np = of_get_child_by_name(pmic_np, "regulators");
|
2013-02-04 07:49:47 +08:00
|
|
|
if (!regulators_np) {
|
|
|
|
|
dev_err(iodev->dev, "could not find regulators sub-node\n");
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* count the number of regulators to be supported in pmic */
|
2013-02-06 10:55:05 +08:00
|
|
|
pdata->num_regulators = of_get_child_count(regulators_np);
|
2013-02-04 07:49:47 +08:00
|
|
|
|
treewide: devm_kzalloc() -> devm_kcalloc()
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
This patch replaces cases of:
devm_kzalloc(handle, a * b, gfp)
with:
devm_kcalloc(handle, a * b, gfp)
as well as handling cases of:
devm_kzalloc(handle, a * b * c, gfp)
with:
devm_kzalloc(handle, array3_size(a, b, c), gfp)
as it's slightly less ugly than:
devm_kcalloc(handle, array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
devm_kzalloc(handle, 4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@
(
devm_kzalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kzalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@
(
devm_kzalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@
(
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE, C1 * C2, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 05:07:58 +08:00
|
|
|
rdata = devm_kcalloc(&pdev->dev,
|
|
|
|
|
pdata->num_regulators, sizeof(*rdata),
|
|
|
|
|
GFP_KERNEL);
|
2021-01-21 23:59:14 +08:00
|
|
|
if (!rdata) {
|
|
|
|
|
of_node_put(regulators_np);
|
2013-02-04 07:49:47 +08:00
|
|
|
return -ENOMEM;
|
2021-01-21 23:59:14 +08:00
|
|
|
}
|
2013-02-04 07:49:47 +08:00
|
|
|
|
treewide: devm_kzalloc() -> devm_kcalloc()
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
This patch replaces cases of:
devm_kzalloc(handle, a * b, gfp)
with:
devm_kcalloc(handle, a * b, gfp)
as well as handling cases of:
devm_kzalloc(handle, a * b * c, gfp)
with:
devm_kzalloc(handle, array3_size(a, b, c), gfp)
as it's slightly less ugly than:
devm_kcalloc(handle, array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
devm_kzalloc(handle, 4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@
(
devm_kzalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kzalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@
(
devm_kzalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@
(
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE, C1 * C2, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 05:07:58 +08:00
|
|
|
rmode = devm_kcalloc(&pdev->dev,
|
|
|
|
|
pdata->num_regulators, sizeof(*rmode),
|
|
|
|
|
GFP_KERNEL);
|
2021-01-21 23:59:14 +08:00
|
|
|
if (!rmode) {
|
|
|
|
|
of_node_put(regulators_np);
|
2013-02-04 07:49:47 +08:00
|
|
|
return -ENOMEM;
|
2021-01-21 23:59:14 +08:00
|
|
|
}
|
2013-02-04 07:49:47 +08:00
|
|
|
|
|
|
|
|
pdata->regulators = rdata;
|
|
|
|
|
pdata->opmode = rmode;
|
|
|
|
|
for_each_child_of_node(regulators_np, reg_np) {
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(regulators); i++)
|
2018-12-06 03:50:37 +08:00
|
|
|
if (of_node_name_eq(reg_np, regulators[i].name))
|
2013-02-04 07:49:47 +08:00
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
if (i == ARRAY_SIZE(regulators)) {
|
|
|
|
|
dev_warn(iodev->dev,
|
2018-08-28 09:52:42 +08:00
|
|
|
"don't know how to configure regulator %pOFn\n",
|
|
|
|
|
reg_np);
|
2013-02-04 07:49:47 +08:00
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2019-10-05 07:10:11 +08:00
|
|
|
rdata->ext_control_gpiod = devm_fwnode_gpiod_get(
|
2018-10-15 17:02:40 +08:00
|
|
|
&pdev->dev,
|
2019-10-05 07:10:11 +08:00
|
|
|
of_fwnode_handle(reg_np),
|
|
|
|
|
"s5m8767,pmic-ext-control",
|
2018-10-15 17:02:40 +08:00
|
|
|
GPIOD_OUT_HIGH | GPIOD_FLAGS_BIT_NONEXCLUSIVE,
|
|
|
|
|
"s5m8767");
|
2021-01-21 11:27:56 +08:00
|
|
|
if (PTR_ERR(rdata->ext_control_gpiod) == -ENOENT) {
|
2019-06-21 05:37:08 +08:00
|
|
|
rdata->ext_control_gpiod = NULL;
|
2021-01-21 11:27:56 +08:00
|
|
|
} else if (IS_ERR(rdata->ext_control_gpiod)) {
|
|
|
|
|
of_node_put(reg_np);
|
|
|
|
|
of_node_put(regulators_np);
|
2018-05-14 16:06:32 +08:00
|
|
|
return PTR_ERR(rdata->ext_control_gpiod);
|
2021-01-21 11:27:56 +08:00
|
|
|
}
|
2014-01-24 21:37:57 +08:00
|
|
|
|
2013-02-04 07:49:47 +08:00
|
|
|
rdata->id = i;
|
|
|
|
|
rdata->initdata = of_get_regulator_init_data(
|
2014-11-10 21:43:53 +08:00
|
|
|
&pdev->dev, reg_np,
|
|
|
|
|
®ulators[i]);
|
2013-02-04 07:49:47 +08:00
|
|
|
rdata->reg_node = reg_np;
|
|
|
|
|
rdata++;
|
|
|
|
|
rmode->id = i;
|
|
|
|
|
if (of_property_read_u32(reg_np, "op_mode",
|
|
|
|
|
&rmode->mode)) {
|
|
|
|
|
dev_warn(iodev->dev,
|
2019-12-04 05:48:38 +08:00
|
|
|
"no op_mode property at %pOF\n",
|
2017-07-19 05:43:26 +08:00
|
|
|
reg_np);
|
2013-02-04 07:49:47 +08:00
|
|
|
|
|
|
|
|
rmode->mode = S5M8767_OPMODE_NORMAL_MODE;
|
|
|
|
|
}
|
|
|
|
|
rmode++;
|
|
|
|
|
}
|
|
|
|
|
|
2014-02-13 19:35:07 +08:00
|
|
|
of_node_put(regulators_np);
|
|
|
|
|
|
2013-10-10 09:41:36 +08:00
|
|
|
if (of_get_property(pmic_np, "s5m8767,pmic-buck2-uses-gpio-dvs", NULL)) {
|
2013-02-04 07:49:47 +08:00
|
|
|
pdata->buck2_gpiodvs = true;
|
|
|
|
|
|
2013-10-10 09:41:36 +08:00
|
|
|
if (of_property_read_u32_array(pmic_np,
|
|
|
|
|
"s5m8767,pmic-buck2-dvs-voltage",
|
|
|
|
|
pdata->buck2_voltage, dvs_voltage_nr)) {
|
|
|
|
|
dev_err(iodev->dev, "buck2 voltages not specified\n");
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (of_get_property(pmic_np, "s5m8767,pmic-buck3-uses-gpio-dvs", NULL)) {
|
2013-02-04 07:49:47 +08:00
|
|
|
pdata->buck3_gpiodvs = true;
|
|
|
|
|
|
2013-10-10 09:41:36 +08:00
|
|
|
if (of_property_read_u32_array(pmic_np,
|
|
|
|
|
"s5m8767,pmic-buck3-dvs-voltage",
|
|
|
|
|
pdata->buck3_voltage, dvs_voltage_nr)) {
|
|
|
|
|
dev_err(iodev->dev, "buck3 voltages not specified\n");
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (of_get_property(pmic_np, "s5m8767,pmic-buck4-uses-gpio-dvs", NULL)) {
|
2013-02-04 07:49:47 +08:00
|
|
|
pdata->buck4_gpiodvs = true;
|
|
|
|
|
|
2013-10-10 09:41:36 +08:00
|
|
|
if (of_property_read_u32_array(pmic_np,
|
|
|
|
|
"s5m8767,pmic-buck4-dvs-voltage",
|
|
|
|
|
pdata->buck4_voltage, dvs_voltage_nr)) {
|
|
|
|
|
dev_err(iodev->dev, "buck4 voltages not specified\n");
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2013-02-04 07:49:47 +08:00
|
|
|
if (pdata->buck2_gpiodvs || pdata->buck3_gpiodvs ||
|
|
|
|
|
pdata->buck4_gpiodvs) {
|
|
|
|
|
ret = s5m8767_pmic_dt_parse_dvs_gpio(iodev, pdata, pmic_np);
|
|
|
|
|
if (ret)
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
|
|
if (of_property_read_u32(pmic_np,
|
|
|
|
|
"s5m8767,pmic-buck-default-dvs-idx",
|
|
|
|
|
&pdata->buck_default_idx)) {
|
|
|
|
|
pdata->buck_default_idx = 0;
|
|
|
|
|
} else {
|
|
|
|
|
if (pdata->buck_default_idx >= 8) {
|
|
|
|
|
pdata->buck_default_idx = 0;
|
|
|
|
|
dev_info(iodev->dev,
|
|
|
|
|
"invalid value for default dvs index, use 0\n");
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ret = s5m8767_pmic_dt_parse_ds_gpio(iodev, pdata, pmic_np);
|
|
|
|
|
if (ret)
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
2013-10-10 09:41:35 +08:00
|
|
|
if (of_get_property(pmic_np, "s5m8767,pmic-buck2-ramp-enable", NULL))
|
|
|
|
|
pdata->buck2_ramp_enable = true;
|
2013-02-04 07:49:47 +08:00
|
|
|
|
2013-10-10 09:41:35 +08:00
|
|
|
if (of_get_property(pmic_np, "s5m8767,pmic-buck3-ramp-enable", NULL))
|
|
|
|
|
pdata->buck3_ramp_enable = true;
|
2013-02-04 07:49:47 +08:00
|
|
|
|
2013-10-10 09:41:35 +08:00
|
|
|
if (of_get_property(pmic_np, "s5m8767,pmic-buck4-ramp-enable", NULL))
|
|
|
|
|
pdata->buck4_ramp_enable = true;
|
|
|
|
|
|
|
|
|
|
if (pdata->buck2_ramp_enable || pdata->buck3_ramp_enable
|
|
|
|
|
|| pdata->buck4_ramp_enable) {
|
|
|
|
|
if (of_property_read_u32(pmic_np, "s5m8767,pmic-buck-ramp-delay",
|
|
|
|
|
&pdata->buck_ramp_delay))
|
|
|
|
|
pdata->buck_ramp_delay = 0;
|
2013-02-04 07:49:47 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
#else
|
2013-02-13 09:29:45 +08:00
|
|
|
static int s5m8767_pmic_dt_parse_pdata(struct platform_device *pdev,
|
2013-02-04 07:49:47 +08:00
|
|
|
struct sec_platform_data *pdata)
|
|
|
|
|
{
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
#endif /* CONFIG_OF */
|
|
|
|
|
|
2012-11-20 02:22:22 +08:00
|
|
|
static int s5m8767_pmic_probe(struct platform_device *pdev)
|
2012-01-09 18:10:25 +08:00
|
|
|
{
|
2012-07-11 20:06:55 +08:00
|
|
|
struct sec_pmic_dev *iodev = dev_get_drvdata(pdev->dev.parent);
|
2013-02-04 07:49:47 +08:00
|
|
|
struct sec_platform_data *pdata = iodev->pdata;
|
2012-04-04 07:50:22 +08:00
|
|
|
struct regulator_config config = { };
|
2012-01-09 18:10:25 +08:00
|
|
|
struct s5m8767_info *s5m8767;
|
2014-06-24 16:40:04 +08:00
|
|
|
int i, ret, buck_init;
|
2012-01-09 18:10:25 +08:00
|
|
|
|
2013-02-13 09:31:31 +08:00
|
|
|
if (!pdata) {
|
|
|
|
|
dev_err(pdev->dev.parent, "Platform data not supplied\n");
|
|
|
|
|
return -ENODEV;
|
|
|
|
|
}
|
|
|
|
|
|
2013-02-04 07:49:47 +08:00
|
|
|
if (iodev->dev->of_node) {
|
2013-02-13 09:29:45 +08:00
|
|
|
ret = s5m8767_pmic_dt_parse_pdata(pdev, pdata);
|
2013-02-04 07:49:47 +08:00
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
2012-03-10 08:43:02 +08:00
|
|
|
if (pdata->buck2_gpiodvs) {
|
|
|
|
|
if (pdata->buck3_gpiodvs || pdata->buck4_gpiodvs) {
|
|
|
|
|
dev_err(&pdev->dev, "S5M8767 GPIO DVS NOT VALID\n");
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (pdata->buck3_gpiodvs) {
|
|
|
|
|
if (pdata->buck2_gpiodvs || pdata->buck4_gpiodvs) {
|
|
|
|
|
dev_err(&pdev->dev, "S5M8767 GPIO DVS NOT VALID\n");
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (pdata->buck4_gpiodvs) {
|
|
|
|
|
if (pdata->buck2_gpiodvs || pdata->buck3_gpiodvs) {
|
|
|
|
|
dev_err(&pdev->dev, "S5M8767 GPIO DVS NOT VALID\n");
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2012-01-09 18:10:25 +08:00
|
|
|
s5m8767 = devm_kzalloc(&pdev->dev, sizeof(struct s5m8767_info),
|
|
|
|
|
GFP_KERNEL);
|
|
|
|
|
if (!s5m8767)
|
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
|
|
s5m8767->dev = &pdev->dev;
|
|
|
|
|
s5m8767->iodev = iodev;
|
2012-12-10 20:49:39 +08:00
|
|
|
s5m8767->num_regulators = pdata->num_regulators;
|
2012-01-09 18:10:25 +08:00
|
|
|
platform_set_drvdata(pdev, s5m8767);
|
|
|
|
|
|
|
|
|
|
s5m8767->buck_gpioindex = pdata->buck_default_idx;
|
|
|
|
|
s5m8767->buck2_gpiodvs = pdata->buck2_gpiodvs;
|
|
|
|
|
s5m8767->buck3_gpiodvs = pdata->buck3_gpiodvs;
|
|
|
|
|
s5m8767->buck4_gpiodvs = pdata->buck4_gpiodvs;
|
|
|
|
|
s5m8767->buck_gpios[0] = pdata->buck_gpios[0];
|
|
|
|
|
s5m8767->buck_gpios[1] = pdata->buck_gpios[1];
|
|
|
|
|
s5m8767->buck_gpios[2] = pdata->buck_gpios[2];
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
s5m8767->buck_ds[0] = pdata->buck_ds[0];
|
|
|
|
|
s5m8767->buck_ds[1] = pdata->buck_ds[1];
|
|
|
|
|
s5m8767->buck_ds[2] = pdata->buck_ds[2];
|
|
|
|
|
|
2012-01-09 18:10:25 +08:00
|
|
|
s5m8767->ramp_delay = pdata->buck_ramp_delay;
|
|
|
|
|
s5m8767->buck2_ramp = pdata->buck2_ramp_enable;
|
|
|
|
|
s5m8767->buck3_ramp = pdata->buck3_ramp_enable;
|
|
|
|
|
s5m8767->buck4_ramp = pdata->buck4_ramp_enable;
|
2012-03-09 16:55:34 +08:00
|
|
|
s5m8767->opmode = pdata->opmode;
|
2012-01-09 18:10:25 +08:00
|
|
|
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
buck_init = s5m8767_convert_voltage_to_sel(&buck_voltage_val2,
|
2012-12-29 09:38:50 +08:00
|
|
|
pdata->buck2_init);
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
|
2013-12-17 21:23:18 +08:00
|
|
|
regmap_write(s5m8767->iodev->regmap_pmic, S5M8767_REG_BUCK2DVS2,
|
|
|
|
|
buck_init);
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
|
|
|
|
|
buck_init = s5m8767_convert_voltage_to_sel(&buck_voltage_val2,
|
2012-12-29 09:38:50 +08:00
|
|
|
pdata->buck3_init);
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
|
2013-12-17 21:23:18 +08:00
|
|
|
regmap_write(s5m8767->iodev->regmap_pmic, S5M8767_REG_BUCK3DVS2,
|
|
|
|
|
buck_init);
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
|
|
|
|
|
buck_init = s5m8767_convert_voltage_to_sel(&buck_voltage_val2,
|
2012-12-29 09:38:50 +08:00
|
|
|
pdata->buck4_init);
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
|
2013-12-17 21:23:18 +08:00
|
|
|
regmap_write(s5m8767->iodev->regmap_pmic, S5M8767_REG_BUCK4DVS2,
|
|
|
|
|
buck_init);
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
|
2012-01-09 18:10:25 +08:00
|
|
|
for (i = 0; i < 8; i++) {
|
|
|
|
|
if (s5m8767->buck2_gpiodvs) {
|
|
|
|
|
s5m8767->buck2_vol[i] =
|
2012-03-09 11:31:08 +08:00
|
|
|
s5m8767_convert_voltage_to_sel(
|
2012-01-09 18:10:25 +08:00
|
|
|
&buck_voltage_val2,
|
2012-12-29 09:38:50 +08:00
|
|
|
pdata->buck2_voltage[i]);
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (s5m8767->buck3_gpiodvs) {
|
|
|
|
|
s5m8767->buck3_vol[i] =
|
2012-03-09 11:31:08 +08:00
|
|
|
s5m8767_convert_voltage_to_sel(
|
2012-01-09 18:10:25 +08:00
|
|
|
&buck_voltage_val2,
|
2012-12-29 09:38:50 +08:00
|
|
|
pdata->buck3_voltage[i]);
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (s5m8767->buck4_gpiodvs) {
|
|
|
|
|
s5m8767->buck4_vol[i] =
|
2012-03-09 11:31:08 +08:00
|
|
|
s5m8767_convert_voltage_to_sel(
|
2012-01-09 18:10:25 +08:00
|
|
|
&buck_voltage_val2,
|
2012-12-29 09:38:50 +08:00
|
|
|
pdata->buck4_voltage[i]);
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2012-12-10 20:49:41 +08:00
|
|
|
if (pdata->buck2_gpiodvs || pdata->buck3_gpiodvs ||
|
|
|
|
|
pdata->buck4_gpiodvs) {
|
|
|
|
|
|
|
|
|
|
if (!gpio_is_valid(pdata->buck_gpios[0]) ||
|
|
|
|
|
!gpio_is_valid(pdata->buck_gpios[1]) ||
|
|
|
|
|
!gpio_is_valid(pdata->buck_gpios[2])) {
|
|
|
|
|
dev_err(&pdev->dev, "GPIO NOT VALID\n");
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
|
2012-07-05 23:12:49 +08:00
|
|
|
ret = devm_gpio_request(&pdev->dev, pdata->buck_gpios[0],
|
|
|
|
|
"S5M8767 SET1");
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
|
|
ret = devm_gpio_request(&pdev->dev, pdata->buck_gpios[1],
|
|
|
|
|
"S5M8767 SET2");
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
|
|
ret = devm_gpio_request(&pdev->dev, pdata->buck_gpios[2],
|
|
|
|
|
"S5M8767 SET3");
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
|
|
|
|
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
/* SET1 GPIO */
|
|
|
|
|
gpio_direction_output(pdata->buck_gpios[0],
|
|
|
|
|
(s5m8767->buck_gpioindex >> 2) & 0x1);
|
|
|
|
|
/* SET2 GPIO */
|
|
|
|
|
gpio_direction_output(pdata->buck_gpios[1],
|
|
|
|
|
(s5m8767->buck_gpioindex >> 1) & 0x1);
|
|
|
|
|
/* SET3 GPIO */
|
|
|
|
|
gpio_direction_output(pdata->buck_gpios[2],
|
|
|
|
|
(s5m8767->buck_gpioindex >> 0) & 0x1);
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
|
2012-07-05 23:12:49 +08:00
|
|
|
ret = devm_gpio_request(&pdev->dev, pdata->buck_ds[0], "S5M8767 DS2");
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
|
2012-07-05 23:12:49 +08:00
|
|
|
ret = devm_gpio_request(&pdev->dev, pdata->buck_ds[1], "S5M8767 DS3");
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
|
2012-07-05 23:12:49 +08:00
|
|
|
ret = devm_gpio_request(&pdev->dev, pdata->buck_ds[2], "S5M8767 DS4");
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
|
|
|
|
|
/* DS2 GPIO */
|
|
|
|
|
gpio_direction_output(pdata->buck_ds[0], 0x0);
|
|
|
|
|
/* DS3 GPIO */
|
|
|
|
|
gpio_direction_output(pdata->buck_ds[1], 0x0);
|
|
|
|
|
/* DS4 GPIO */
|
|
|
|
|
gpio_direction_output(pdata->buck_ds[2], 0x0);
|
|
|
|
|
|
|
|
|
|
if (pdata->buck2_gpiodvs || pdata->buck3_gpiodvs ||
|
|
|
|
|
pdata->buck4_gpiodvs) {
|
2013-12-17 21:23:18 +08:00
|
|
|
regmap_update_bits(s5m8767->iodev->regmap_pmic,
|
|
|
|
|
S5M8767_REG_BUCK2CTRL, 1 << 1,
|
|
|
|
|
(pdata->buck2_gpiodvs) ? (1 << 1) : (0 << 1));
|
|
|
|
|
regmap_update_bits(s5m8767->iodev->regmap_pmic,
|
|
|
|
|
S5M8767_REG_BUCK3CTRL, 1 << 1,
|
|
|
|
|
(pdata->buck3_gpiodvs) ? (1 << 1) : (0 << 1));
|
|
|
|
|
regmap_update_bits(s5m8767->iodev->regmap_pmic,
|
|
|
|
|
S5M8767_REG_BUCK4CTRL, 1 << 1,
|
|
|
|
|
(pdata->buck4_gpiodvs) ? (1 << 1) : (0 << 1));
|
regulator: s5m8767a: Support AP watchdog reset operation
The S5M8767A can't know status of ap reset.
So, After AP watchdog reset, AP can't boot normally.
Problem can be happened like below condition.
- AP Bootable lowest voltage(vdd_arm): 0.9v
- AP DVFS voltage table: 0.8v, 0.9v, 1.0v
- During AP works on lowest voltage(0.8V), watchdog reset is asserted
- AP can't boot, because vdd arm is still 0.8v
Solution
- Basic concept:
After ap watchdog reset, GPIO configuration is changed by default value
- S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
- Set bootable voltage on level 0 -> can work with default gpio configuration
- In the probing, Change voltage control level from level 0 to level 1
- Execute normal dvfs operation on level 1
- After watchdog reset, ap gpio is set by default value
- PMIC operation mode is changed by ap reset (level1 -> level0)
- Regardless of previous vdd_arm voltage, AP always can be booted.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2012-06-18 08:49:20 +08:00
|
|
|
}
|
2012-01-09 18:10:25 +08:00
|
|
|
|
|
|
|
|
/* Initialize GPIO DVS registers */
|
|
|
|
|
for (i = 0; i < 8; i++) {
|
|
|
|
|
if (s5m8767->buck2_gpiodvs) {
|
2013-12-17 21:23:18 +08:00
|
|
|
regmap_write(s5m8767->iodev->regmap_pmic,
|
|
|
|
|
S5M8767_REG_BUCK2DVS1 + i,
|
|
|
|
|
s5m8767->buck2_vol[i]);
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (s5m8767->buck3_gpiodvs) {
|
2013-12-17 21:23:18 +08:00
|
|
|
regmap_write(s5m8767->iodev->regmap_pmic,
|
|
|
|
|
S5M8767_REG_BUCK3DVS1 + i,
|
|
|
|
|
s5m8767->buck3_vol[i]);
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (s5m8767->buck4_gpiodvs) {
|
2013-12-17 21:23:18 +08:00
|
|
|
regmap_write(s5m8767->iodev->regmap_pmic,
|
|
|
|
|
S5M8767_REG_BUCK4DVS1 + i,
|
|
|
|
|
s5m8767->buck4_vol[i]);
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (s5m8767->buck2_ramp)
|
2013-12-17 21:23:18 +08:00
|
|
|
regmap_update_bits(s5m8767->iodev->regmap_pmic,
|
|
|
|
|
S5M8767_REG_DVSRAMP, 0x08, 0x08);
|
2012-01-09 18:10:25 +08:00
|
|
|
|
|
|
|
|
if (s5m8767->buck3_ramp)
|
2013-12-17 21:23:18 +08:00
|
|
|
regmap_update_bits(s5m8767->iodev->regmap_pmic,
|
|
|
|
|
S5M8767_REG_DVSRAMP, 0x04, 0x04);
|
2012-01-09 18:10:25 +08:00
|
|
|
|
|
|
|
|
if (s5m8767->buck4_ramp)
|
2013-12-17 21:23:18 +08:00
|
|
|
regmap_update_bits(s5m8767->iodev->regmap_pmic,
|
|
|
|
|
S5M8767_REG_DVSRAMP, 0x02, 0x02);
|
2012-01-09 18:10:25 +08:00
|
|
|
|
|
|
|
|
if (s5m8767->buck2_ramp || s5m8767->buck3_ramp
|
|
|
|
|
|| s5m8767->buck4_ramp) {
|
2013-12-17 21:23:17 +08:00
|
|
|
unsigned int val;
|
2012-01-09 18:10:25 +08:00
|
|
|
switch (s5m8767->ramp_delay) {
|
2012-06-13 16:27:54 +08:00
|
|
|
case 5:
|
2013-12-17 21:23:17 +08:00
|
|
|
val = S5M8767_DVS_BUCK_RAMP_5;
|
2012-06-13 16:27:54 +08:00
|
|
|
break;
|
|
|
|
|
case 10:
|
2013-12-17 21:23:17 +08:00
|
|
|
val = S5M8767_DVS_BUCK_RAMP_10;
|
2012-01-12 14:57:09 +08:00
|
|
|
break;
|
2012-01-09 18:10:25 +08:00
|
|
|
case 25:
|
2013-12-17 21:23:17 +08:00
|
|
|
val = S5M8767_DVS_BUCK_RAMP_25;
|
2012-01-12 14:57:09 +08:00
|
|
|
break;
|
2012-01-09 18:10:25 +08:00
|
|
|
case 50:
|
2013-12-17 21:23:17 +08:00
|
|
|
val = S5M8767_DVS_BUCK_RAMP_50;
|
2012-01-12 14:57:09 +08:00
|
|
|
break;
|
2012-01-09 18:10:25 +08:00
|
|
|
case 100:
|
2013-12-17 21:23:17 +08:00
|
|
|
val = S5M8767_DVS_BUCK_RAMP_100;
|
2012-01-12 14:57:09 +08:00
|
|
|
break;
|
2012-01-09 18:10:25 +08:00
|
|
|
default:
|
2013-12-17 21:23:17 +08:00
|
|
|
val = S5M8767_DVS_BUCK_RAMP_10;
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
2013-12-17 21:23:18 +08:00
|
|
|
regmap_update_bits(s5m8767->iodev->regmap_pmic,
|
|
|
|
|
S5M8767_REG_DVSRAMP,
|
|
|
|
|
S5M8767_DVS_BUCK_RAMP_MASK,
|
|
|
|
|
val << S5M8767_DVS_BUCK_RAMP_SHIFT);
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < pdata->num_regulators; i++) {
|
2012-07-11 20:06:55 +08:00
|
|
|
const struct sec_voltage_desc *desc;
|
2012-01-09 18:10:25 +08:00
|
|
|
int id = pdata->regulators[i].id;
|
2014-03-21 14:54:08 +08:00
|
|
|
int enable_reg, enable_val;
|
2014-04-07 20:15:24 +08:00
|
|
|
struct regulator_dev *rdev;
|
2012-01-09 18:10:25 +08:00
|
|
|
|
|
|
|
|
desc = reg_voltage_map[id];
|
2012-06-18 14:25:27 +08:00
|
|
|
if (desc) {
|
2012-01-09 18:10:25 +08:00
|
|
|
regulators[id].n_voltages =
|
|
|
|
|
(desc->max - desc->min) / desc->step + 1;
|
2012-06-18 14:25:27 +08:00
|
|
|
regulators[id].min_uV = desc->min;
|
|
|
|
|
regulators[id].uV_step = desc->step;
|
2013-01-18 09:55:06 +08:00
|
|
|
regulators[id].vsel_reg =
|
|
|
|
|
s5m8767_get_vsel_reg(id, s5m8767);
|
|
|
|
|
if (id < S5M8767_BUCK1)
|
|
|
|
|
regulators[id].vsel_mask = 0x3f;
|
|
|
|
|
else
|
|
|
|
|
regulators[id].vsel_mask = 0xff;
|
2014-03-21 14:54:08 +08:00
|
|
|
|
2016-02-16 22:53:11 +08:00
|
|
|
ret = s5m8767_get_register(s5m8767, id, &enable_reg,
|
2014-03-21 14:54:08 +08:00
|
|
|
&enable_val);
|
2016-02-16 22:53:11 +08:00
|
|
|
if (ret) {
|
|
|
|
|
dev_err(s5m8767->dev, "error reading registers\n");
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
2014-03-21 14:54:08 +08:00
|
|
|
regulators[id].enable_reg = enable_reg;
|
|
|
|
|
regulators[id].enable_mask = S5M8767_ENCTRL_MASK;
|
|
|
|
|
regulators[id].enable_val = enable_val;
|
2012-06-18 14:25:27 +08:00
|
|
|
}
|
2012-01-09 18:10:25 +08:00
|
|
|
|
2012-04-04 07:50:22 +08:00
|
|
|
config.dev = s5m8767->dev;
|
|
|
|
|
config.init_data = pdata->regulators[i].initdata;
|
|
|
|
|
config.driver_data = s5m8767;
|
2013-12-13 09:12:31 +08:00
|
|
|
config.regmap = iodev->regmap_pmic;
|
2013-02-04 07:49:47 +08:00
|
|
|
config.of_node = pdata->regulators[i].reg_node;
|
2018-05-14 16:06:32 +08:00
|
|
|
config.ena_gpiod = NULL;
|
2018-12-06 20:43:49 +08:00
|
|
|
if (pdata->regulators[i].ext_control_gpiod) {
|
|
|
|
|
/* Assigns config.ena_gpiod */
|
2014-01-24 21:37:57 +08:00
|
|
|
s5m8767_regulator_config_ext_control(s5m8767,
|
|
|
|
|
&pdata->regulators[i], &config);
|
2012-04-04 07:50:22 +08:00
|
|
|
|
2018-12-06 20:43:49 +08:00
|
|
|
/*
|
|
|
|
|
* Hand the GPIO descriptor management over to the
|
|
|
|
|
* regulator core, remove it from devres management.
|
|
|
|
|
*/
|
|
|
|
|
devm_gpiod_unhinge(s5m8767->dev, config.ena_gpiod);
|
|
|
|
|
}
|
2014-04-07 20:15:24 +08:00
|
|
|
rdev = devm_regulator_register(&pdev->dev, ®ulators[id],
|
2013-08-31 18:57:34 +08:00
|
|
|
&config);
|
2014-04-07 20:15:24 +08:00
|
|
|
if (IS_ERR(rdev)) {
|
|
|
|
|
ret = PTR_ERR(rdev);
|
2012-01-09 18:10:25 +08:00
|
|
|
dev_err(s5m8767->dev, "regulator init failed for %d\n",
|
|
|
|
|
id);
|
2013-08-31 18:57:34 +08:00
|
|
|
return ret;
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
2014-01-24 21:37:57 +08:00
|
|
|
|
2018-05-14 16:06:32 +08:00
|
|
|
if (pdata->regulators[i].ext_control_gpiod) {
|
2014-04-07 20:15:24 +08:00
|
|
|
ret = s5m8767_enable_ext_control(s5m8767, rdev);
|
2014-01-24 21:37:57 +08:00
|
|
|
if (ret < 0) {
|
|
|
|
|
dev_err(s5m8767->dev,
|
|
|
|
|
"failed to enable gpio control over %s: %d\n",
|
2014-04-07 20:15:24 +08:00
|
|
|
rdev->desc->name, ret);
|
2014-01-24 21:37:57 +08:00
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
}
|
2012-01-09 18:10:25 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static const struct platform_device_id s5m8767_pmic_id[] = {
|
|
|
|
|
{ "s5m8767-pmic", 0},
|
|
|
|
|
{ },
|
|
|
|
|
};
|
|
|
|
|
MODULE_DEVICE_TABLE(platform, s5m8767_pmic_id);
|
|
|
|
|
|
|
|
|
|
static struct platform_driver s5m8767_pmic_driver = {
|
|
|
|
|
.driver = {
|
|
|
|
|
.name = "s5m8767-pmic",
|
|
|
|
|
},
|
|
|
|
|
.probe = s5m8767_pmic_probe,
|
|
|
|
|
.id_table = s5m8767_pmic_id,
|
|
|
|
|
};
|
2020-09-22 04:36:16 +08:00
|
|
|
module_platform_driver(s5m8767_pmic_driver);
|
2012-01-09 18:10:25 +08:00
|
|
|
|
|
|
|
|
/* Module information */
|
|
|
|
|
MODULE_AUTHOR("Sangbeom Kim <sbkim73@samsung.com>");
|
2020-01-04 01:11:31 +08:00
|
|
|
MODULE_DESCRIPTION("Samsung S5M8767 Regulator Driver");
|
2012-01-09 18:10:25 +08:00
|
|
|
MODULE_LICENSE("GPL");
|