2019-08-04 20:48:26 +08:00
|
|
|
/*
|
|
|
|
|
* SPDX-License-Identifier: MIT
|
|
|
|
|
*
|
|
|
|
|
* Copyright © 2014-2018 Intel Corporation
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#ifndef INTEL_ENGINE_POOL_H
|
|
|
|
|
#define INTEL_ENGINE_POOL_H
|
|
|
|
|
|
|
|
|
|
#include "intel_engine_pool_types.h"
|
|
|
|
|
#include "i915_active.h"
|
|
|
|
|
#include "i915_request.h"
|
|
|
|
|
|
|
|
|
|
struct intel_engine_pool_node *
|
2019-08-27 21:59:35 +08:00
|
|
|
intel_engine_get_pool(struct intel_engine_cs *engine, size_t size);
|
2019-08-04 20:48:26 +08:00
|
|
|
|
|
|
|
|
static inline int
|
|
|
|
|
intel_engine_pool_mark_active(struct intel_engine_pool_node *node,
|
|
|
|
|
struct i915_request *rq)
|
|
|
|
|
{
|
drm/i915: Mark i915_request.timeline as a volatile, rcu pointer
The request->timeline is only valid until the request is retired (i.e.
before it is completed). Upon retiring the request, the context may be
unpinned and freed, and along with it the timeline may be freed. We
therefore need to be very careful when chasing rq->timeline that the
pointer does not disappear beneath us. The vast majority of users are in
a protected context, either during request construction or retirement,
where the timeline->mutex is held and the timeline cannot disappear. It
is those few off the beaten path (where we access a second timeline) that
need extra scrutiny -- to be added in the next patch after first adding
the warnings about dangerous access.
One complication, where we cannot use the timeline->mutex itself, is
during request submission onto hardware (under spinlocks). Here, we want
to check on the timeline to finalize the breadcrumb, and so we need to
impose a second rule to ensure that the request->timeline is indeed
valid. As we are submitting the request, it's context and timeline must
be pinned, as it will be used by the hardware. Since it is pinned, we
know the request->timeline must still be valid, and we cannot submit the
idle barrier until after we release the engine->active.lock, ergo while
submitting and holding that spinlock, a second thread cannot release the
timeline.
v2: Don't be lazy inside selftests; hold the timeline->mutex for as long
as we need it, and tidy up acquiring the timeline with a bit of
refactoring (i915_active_add_request)
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190919111912.21631-1-chris@chris-wilson.co.uk
2019-09-19 19:19:10 +08:00
|
|
|
return i915_active_add_request(&node->active, rq);
|
2019-08-04 20:48:26 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static inline void
|
|
|
|
|
intel_engine_pool_put(struct intel_engine_pool_node *node)
|
|
|
|
|
{
|
|
|
|
|
i915_active_release(&node->active);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void intel_engine_pool_init(struct intel_engine_pool *pool);
|
|
|
|
|
void intel_engine_pool_park(struct intel_engine_pool *pool);
|
|
|
|
|
void intel_engine_pool_fini(struct intel_engine_pool *pool);
|
|
|
|
|
|
|
|
|
|
#endif /* INTEL_ENGINE_POOL_H */
|