License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 22:07:57 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2012-11-10 08:46:50 +08:00
|
|
|
#include "parse-events.h"
|
|
|
|
#include "pmu.h"
|
|
|
|
#include "tests.h"
|
2017-04-18 21:46:11 +08:00
|
|
|
#include <errno.h>
|
perf pmu: Use relative path for sysfs scan
The PMU information is in the kernel sysfs so it needs to scan the
directory to get the whole information like event aliases, formats and
so on. During the traversal, it opens a lot of files and directories
like below:
dir = opendir("/sys/bus/event_source/devices");
while (dentry = readdir(dir)) {
char buf[PATH_MAX];
snprintf(buf, sizeof(buf), "%s/%s",
"/sys/bus/event_source/devices", dentry->d_name);
fd = open(buf, O_RDONLY);
...
}
But this is not good since it needs to copy the string to build the
absolute pathname, and it makes redundant pathname walk (from the /sys)
unnecessarily. We can use openat(2) to open the file in the given
directory. While it's not a problem ususally, it can be a problem when
the kernel has contentions on the sysfs.
Add a couple of new helper to return the file descriptor of PMU
directory so that it can use it with relative paths.
* perf_pmu__event_source_devices_fd()
- returns a fd for the PMU root ("/sys/bus/event_source/devices")
* perf_pmu__pathname_fd()
- returns a fd for "<pmu>/<file>" under the PMU root
Now the above code can be converted something like below:
dirfd = perf_pmu__event_source_devices_fd();
dir = fdopendir(dirfd);
while (dentry = readdir(dir)) {
fd = openat(dirfd, dentry->d_name, O_RDONLY);
...
}
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20230331202949.810326-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2023-04-01 04:29:45 +08:00
|
|
|
#include <fcntl.h>
|
2019-01-29 19:23:44 +08:00
|
|
|
#include <stdio.h>
|
2017-04-17 22:39:06 +08:00
|
|
|
#include <linux/kernel.h>
|
2019-01-29 19:23:44 +08:00
|
|
|
#include <linux/limits.h>
|
2012-11-10 08:46:50 +08:00
|
|
|
|
|
|
|
/* Simulated format definitions. */
|
|
|
|
static struct test_format {
|
|
|
|
const char *name;
|
|
|
|
const char *value;
|
|
|
|
} test_formats[] = {
|
|
|
|
{ "krava01", "config:0-1,62-63\n", },
|
|
|
|
{ "krava02", "config:10-17\n", },
|
|
|
|
{ "krava03", "config:5\n", },
|
|
|
|
{ "krava11", "config1:0,2,4,6,8,20-28\n", },
|
|
|
|
{ "krava12", "config1:63\n", },
|
|
|
|
{ "krava13", "config1:45-47\n", },
|
|
|
|
{ "krava21", "config2:0-3,10-13,20-23,30-33,40-43,50-53,60-63\n", },
|
|
|
|
{ "krava22", "config2:8,18,48,58\n", },
|
|
|
|
{ "krava23", "config2:28-29,38\n", },
|
|
|
|
};
|
|
|
|
|
|
|
|
/* Simulated users input. */
|
2013-01-19 03:29:49 +08:00
|
|
|
static struct parse_events_term test_terms[] = {
|
2012-11-10 08:46:50 +08:00
|
|
|
{
|
|
|
|
.config = (char *) "krava01",
|
|
|
|
.val.num = 15,
|
|
|
|
.type_val = PARSE_EVENTS__TERM_TYPE_NUM,
|
|
|
|
.type_term = PARSE_EVENTS__TERM_TYPE_USER,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.config = (char *) "krava02",
|
|
|
|
.val.num = 170,
|
|
|
|
.type_val = PARSE_EVENTS__TERM_TYPE_NUM,
|
|
|
|
.type_term = PARSE_EVENTS__TERM_TYPE_USER,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.config = (char *) "krava03",
|
|
|
|
.val.num = 1,
|
|
|
|
.type_val = PARSE_EVENTS__TERM_TYPE_NUM,
|
|
|
|
.type_term = PARSE_EVENTS__TERM_TYPE_USER,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.config = (char *) "krava11",
|
|
|
|
.val.num = 27,
|
|
|
|
.type_val = PARSE_EVENTS__TERM_TYPE_NUM,
|
|
|
|
.type_term = PARSE_EVENTS__TERM_TYPE_USER,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.config = (char *) "krava12",
|
|
|
|
.val.num = 1,
|
|
|
|
.type_val = PARSE_EVENTS__TERM_TYPE_NUM,
|
|
|
|
.type_term = PARSE_EVENTS__TERM_TYPE_USER,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.config = (char *) "krava13",
|
|
|
|
.val.num = 2,
|
|
|
|
.type_val = PARSE_EVENTS__TERM_TYPE_NUM,
|
|
|
|
.type_term = PARSE_EVENTS__TERM_TYPE_USER,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.config = (char *) "krava21",
|
|
|
|
.val.num = 119,
|
|
|
|
.type_val = PARSE_EVENTS__TERM_TYPE_NUM,
|
|
|
|
.type_term = PARSE_EVENTS__TERM_TYPE_USER,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.config = (char *) "krava22",
|
|
|
|
.val.num = 11,
|
|
|
|
.type_val = PARSE_EVENTS__TERM_TYPE_NUM,
|
|
|
|
.type_term = PARSE_EVENTS__TERM_TYPE_USER,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.config = (char *) "krava23",
|
|
|
|
.val.num = 2,
|
|
|
|
.type_val = PARSE_EVENTS__TERM_TYPE_NUM,
|
|
|
|
.type_term = PARSE_EVENTS__TERM_TYPE_USER,
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Prepare format directory data, exported by kernel
|
|
|
|
* at /sys/bus/event_source/devices/<dev>/format.
|
|
|
|
*/
|
2023-05-27 02:34:00 +08:00
|
|
|
static char *test_format_dir_get(char *dir, size_t sz)
|
2012-11-10 08:46:50 +08:00
|
|
|
{
|
|
|
|
unsigned int i;
|
|
|
|
|
2023-05-27 02:34:00 +08:00
|
|
|
snprintf(dir, sz, "/tmp/perf-pmu-test-format-XXXXXX");
|
2012-11-10 08:46:50 +08:00
|
|
|
if (!mkdtemp(dir))
|
|
|
|
return NULL;
|
|
|
|
|
2013-01-19 04:03:43 +08:00
|
|
|
for (i = 0; i < ARRAY_SIZE(test_formats); i++) {
|
2023-05-27 02:34:00 +08:00
|
|
|
char name[PATH_MAX];
|
2012-11-10 08:46:50 +08:00
|
|
|
struct test_format *format = &test_formats[i];
|
|
|
|
FILE *file;
|
|
|
|
|
2018-03-19 16:29:01 +08:00
|
|
|
scnprintf(name, PATH_MAX, "%s/%s", dir, format->name);
|
2012-11-10 08:46:50 +08:00
|
|
|
|
|
|
|
file = fopen(name, "w");
|
|
|
|
if (!file)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
if (1 != fwrite(format->value, strlen(format->value), 1, file))
|
|
|
|
break;
|
|
|
|
|
|
|
|
fclose(file);
|
|
|
|
}
|
|
|
|
|
|
|
|
return dir;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Cleanup format directory. */
|
|
|
|
static int test_format_dir_put(char *dir)
|
|
|
|
{
|
2023-05-27 02:34:00 +08:00
|
|
|
char buf[PATH_MAX + 20];
|
|
|
|
|
|
|
|
snprintf(buf, sizeof(buf), "rm -f %s/*\n", dir);
|
2012-11-10 08:46:50 +08:00
|
|
|
if (system(buf))
|
|
|
|
return -1;
|
|
|
|
|
2023-05-27 02:34:00 +08:00
|
|
|
snprintf(buf, sizeof(buf), "rmdir %s\n", dir);
|
2012-11-10 08:46:50 +08:00
|
|
|
return system(buf);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct list_head *test_terms_list(void)
|
|
|
|
{
|
|
|
|
static LIST_HEAD(terms);
|
|
|
|
unsigned int i;
|
|
|
|
|
2013-01-19 04:03:43 +08:00
|
|
|
for (i = 0; i < ARRAY_SIZE(test_terms); i++)
|
2012-11-10 08:46:50 +08:00
|
|
|
list_add_tail(&test_terms[i].list, &terms);
|
|
|
|
|
|
|
|
return &terms;
|
|
|
|
}
|
|
|
|
|
2021-11-04 14:41:51 +08:00
|
|
|
static int test__pmu(struct test_suite *test __maybe_unused, int subtest __maybe_unused)
|
2012-11-10 08:46:50 +08:00
|
|
|
{
|
2023-05-27 02:34:00 +08:00
|
|
|
char dir[PATH_MAX];
|
|
|
|
char *format = test_format_dir_get(dir, sizeof(dir));
|
2012-11-10 08:46:50 +08:00
|
|
|
LIST_HEAD(formats);
|
|
|
|
struct list_head *terms = test_terms_list();
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (!format)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
do {
|
|
|
|
struct perf_event_attr attr;
|
perf pmu: Use relative path for sysfs scan
The PMU information is in the kernel sysfs so it needs to scan the
directory to get the whole information like event aliases, formats and
so on. During the traversal, it opens a lot of files and directories
like below:
dir = opendir("/sys/bus/event_source/devices");
while (dentry = readdir(dir)) {
char buf[PATH_MAX];
snprintf(buf, sizeof(buf), "%s/%s",
"/sys/bus/event_source/devices", dentry->d_name);
fd = open(buf, O_RDONLY);
...
}
But this is not good since it needs to copy the string to build the
absolute pathname, and it makes redundant pathname walk (from the /sys)
unnecessarily. We can use openat(2) to open the file in the given
directory. While it's not a problem ususally, it can be a problem when
the kernel has contentions on the sysfs.
Add a couple of new helper to return the file descriptor of PMU
directory so that it can use it with relative paths.
* perf_pmu__event_source_devices_fd()
- returns a fd for the PMU root ("/sys/bus/event_source/devices")
* perf_pmu__pathname_fd()
- returns a fd for "<pmu>/<file>" under the PMU root
Now the above code can be converted something like below:
dirfd = perf_pmu__event_source_devices_fd();
dir = fdopendir(dirfd);
while (dentry = readdir(dir)) {
fd = openat(dirfd, dentry->d_name, O_RDONLY);
...
}
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20230331202949.810326-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2023-04-01 04:29:45 +08:00
|
|
|
int fd;
|
2012-11-10 08:46:50 +08:00
|
|
|
|
|
|
|
memset(&attr, 0, sizeof(attr));
|
|
|
|
|
perf pmu: Use relative path for sysfs scan
The PMU information is in the kernel sysfs so it needs to scan the
directory to get the whole information like event aliases, formats and
so on. During the traversal, it opens a lot of files and directories
like below:
dir = opendir("/sys/bus/event_source/devices");
while (dentry = readdir(dir)) {
char buf[PATH_MAX];
snprintf(buf, sizeof(buf), "%s/%s",
"/sys/bus/event_source/devices", dentry->d_name);
fd = open(buf, O_RDONLY);
...
}
But this is not good since it needs to copy the string to build the
absolute pathname, and it makes redundant pathname walk (from the /sys)
unnecessarily. We can use openat(2) to open the file in the given
directory. While it's not a problem ususally, it can be a problem when
the kernel has contentions on the sysfs.
Add a couple of new helper to return the file descriptor of PMU
directory so that it can use it with relative paths.
* perf_pmu__event_source_devices_fd()
- returns a fd for the PMU root ("/sys/bus/event_source/devices")
* perf_pmu__pathname_fd()
- returns a fd for "<pmu>/<file>" under the PMU root
Now the above code can be converted something like below:
dirfd = perf_pmu__event_source_devices_fd();
dir = fdopendir(dirfd);
while (dentry = readdir(dir)) {
fd = openat(dirfd, dentry->d_name, O_RDONLY);
...
}
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20230331202949.810326-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2023-04-01 04:29:45 +08:00
|
|
|
fd = open(format, O_DIRECTORY);
|
|
|
|
if (fd < 0) {
|
|
|
|
ret = fd;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
ret = perf_pmu__format_parse(fd, &formats);
|
2012-11-10 08:46:50 +08:00
|
|
|
if (ret)
|
|
|
|
break;
|
|
|
|
|
perf parse-events: Make add PMU verbose output clearer
On a CPU like skylakex an uncore_iio_0 PMU may alias with
uncore_iio_free_running_0. The latter PMU doesn't support fc_mask as a
parameter and so pmu_config_term fails. Typically parse_events_add_pmu
is called in a loop where if one alias succeeds errors are ignored,
however, if multiple errors occur parse_events__handle_error will
currently give a WARN_ONCE.
This change removes the WARN_ONCE in parse_events__handle_error and
makes it a pr_debug. It adds verbose messages to parse_events_add_pmu
warning that non-fatal errors may occur, while giving details on the pmu
and config terms for useful context. pmu_config_term is altered so the
failing term and pmu are present in the case of the 'unknown term' error
which makes spotting the free_running case more straightforward.
Before:
$ perf --debug verbose=3 stat -M llc_misses.pcie_read sleep 1
Using CPUID GenuineIntel-6-55-4
metric expr unc_iio_data_req_of_cpu.mem_read.part0 + unc_iio_data_req_of_cpu.mem_read.part1 + unc_iio_data_req_of_cpu.mem_read.part2 + unc_iio_data_req_of_cpu.mem_read.part3 for LLC_MISSES.PCIE_READ
found event unc_iio_data_req_of_cpu.mem_read.part0
found event unc_iio_data_req_of_cpu.mem_read.part1
found event unc_iio_data_req_of_cpu.mem_read.part2
found event unc_iio_data_req_of_cpu.mem_read.part3
metric expr unc_iio_data_req_of_cpu.mem_read.part0 + unc_iio_data_req_of_cpu.mem_read.part1 + unc_iio_data_req_of_cpu.mem_read.part2 + unc_iio_data_req_of_cpu.mem_read.part3 for LLC_MISSES.PCIE_READ
found event unc_iio_data_req_of_cpu.mem_read.part0
found event unc_iio_data_req_of_cpu.mem_read.part1
found event unc_iio_data_req_of_cpu.mem_read.part2
found event unc_iio_data_req_of_cpu.mem_read.part3
adding {unc_iio_data_req_of_cpu.mem_read.part0,unc_iio_data_req_of_cpu.mem_read.part1,unc_iio_data_req_of_cpu.mem_read.part2,unc_iio_data_req_of_cpu.mem_read.part3}:W,{unc_iio_data_req_of_cpu.mem_read.part0,unc_iio_data_req_of_cpu.mem_read.part1,unc_iio_data_req_of_cpu.mem_read.part2,unc_iio_data_req_of_cpu.mem_read.part3}:W
intel_pt default config: tsc,mtc,mtc_period=3,psb_period=3,pt,branch
WARNING: multiple event parsing errors
...
Invalid event/parameter 'fc_mask'
...
After:
$ perf --debug verbose=3 stat -M llc_misses.pcie_read sleep 1
Using CPUID GenuineIntel-6-55-4
metric expr unc_iio_data_req_of_cpu.mem_read.part0 + unc_iio_data_req_of_cpu.mem_read.part1 + unc_iio_data_req_of_cpu.mem_read.part2 + unc_iio_data_req_of_cpu.mem_read.part3 for LLC_MISSES.PCIE_READ
found event unc_iio_data_req_of_cpu.mem_read.part0
found event unc_iio_data_req_of_cpu.mem_read.part1
found event unc_iio_data_req_of_cpu.mem_read.part2
found event unc_iio_data_req_of_cpu.mem_read.part3
metric expr unc_iio_data_req_of_cpu.mem_read.part0 + unc_iio_data_req_of_cpu.mem_read.part1 + unc_iio_data_req_of_cpu.mem_read.part2 + unc_iio_data_req_of_cpu.mem_read.part3 for LLC_MISSES.PCIE_READ
found event unc_iio_data_req_of_cpu.mem_read.part0
found event unc_iio_data_req_of_cpu.mem_read.part1
found event unc_iio_data_req_of_cpu.mem_read.part2
found event unc_iio_data_req_of_cpu.mem_read.part3
adding {unc_iio_data_req_of_cpu.mem_read.part0,unc_iio_data_req_of_cpu.mem_read.part1,unc_iio_data_req_of_cpu.mem_read.part2,unc_iio_data_req_of_cpu.mem_read.part3}:W,{unc_iio_data_req_of_cpu.mem_read.part0,unc_iio_data_req_of_cpu.mem_read.part1,unc_iio_data_req_of_cpu.mem_read.part2,unc_iio_data_req_of_cpu.mem_read.part3}:W
intel_pt default config: tsc,mtc,mtc_period=3,psb_period=3,pt,branch
Attempting to add event pmu 'uncore_iio_free_running_5' with 'unc_iio_data_req_of_cpu.mem_read.part0,' that may result in non-fatal errors
After aliases, add event pmu 'uncore_iio_free_running_5' with 'fc_mask,ch_mask,umask,event,' that may result in non-fatal errors
Attempting to add event pmu 'uncore_iio_free_running_3' with 'unc_iio_data_req_of_cpu.mem_read.part0,' that may result in non-fatal errors
After aliases, add event pmu 'uncore_iio_free_running_3' with 'fc_mask,ch_mask,umask,event,' that may result in non-fatal errors
Attempting to add event pmu 'uncore_iio_free_running_1' with 'unc_iio_data_req_of_cpu.mem_read.part0,' that may result in non-fatal errors
After aliases, add event pmu 'uncore_iio_free_running_1' with 'fc_mask,ch_mask,umask,event,' that may result in non-fatal errors
Multiple errors dropping message: unknown term 'fc_mask' for pmu 'uncore_iio_free_running_3' (valid terms: event,umask,config,config1,config2,name,period,percore)
...
So before you see a 'WARNING: multiple event parsing errors' and
'Invalid event/parameter'. After you see 'Attempting... that may result
in non-fatal errors' then 'Multiple errors...' with details that
'fc_mask' wasn't known to a free running counter. While not completely
clean, this makes it clearer that an error hasn't really occurred.
v2. addresses review feedback from Jiri Olsa <jolsa@redhat.com>.
Signed-off-by: Ian Rogers <irogers@google.com>
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: John Garry <john.garry@huawei.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lore.kernel.org/lkml/20200513220635.54700-1-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2020-05-14 06:06:35 +08:00
|
|
|
ret = perf_pmu__config_terms("perf-pmu-test", &formats, &attr,
|
|
|
|
terms, false, NULL);
|
2012-11-10 08:46:50 +08:00
|
|
|
if (ret)
|
|
|
|
break;
|
|
|
|
|
|
|
|
ret = -EINVAL;
|
|
|
|
|
|
|
|
if (attr.config != 0xc00000000002a823)
|
|
|
|
break;
|
|
|
|
if (attr.config1 != 0x8000400000000145)
|
|
|
|
break;
|
|
|
|
if (attr.config2 != 0x0400000020041d07)
|
|
|
|
break;
|
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
} while (0);
|
|
|
|
|
2020-09-15 11:18:19 +08:00
|
|
|
perf_pmu__del_formats(&formats);
|
2012-11-10 08:46:50 +08:00
|
|
|
test_format_dir_put(format);
|
|
|
|
return ret;
|
|
|
|
}
|
2021-11-04 14:41:50 +08:00
|
|
|
|
|
|
|
DEFINE_SUITE("Parse perf pmu format", pmu);
|