2007-02-09 22:24:33 +08:00
|
|
|
/*
|
2005-04-17 06:20:36 +08:00
|
|
|
BlueZ - Bluetooth protocol stack for Linux
|
|
|
|
Copyright (C) 2000-2001 Qualcomm Incorporated
|
|
|
|
|
|
|
|
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License version 2 as
|
|
|
|
published by the Free Software Foundation;
|
|
|
|
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
|
|
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
|
|
|
|
IN NO EVENT SHALL THE COPYRIGHT HOLDER(S) AND AUTHOR(S) BE LIABLE FOR ANY
|
2007-02-09 22:24:33 +08:00
|
|
|
CLAIM, OR ANY SPECIAL INDIRECT OR CONSEQUENTIAL DAMAGES, OR ANY DAMAGES
|
|
|
|
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
|
|
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
2005-04-17 06:20:36 +08:00
|
|
|
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
|
|
|
2007-02-09 22:24:33 +08:00
|
|
|
ALL LIABILITY, INCLUDING LIABILITY FOR INFRINGEMENT OF ANY PATENTS,
|
|
|
|
COPYRIGHTS, TRADEMARKS OR OTHER RIGHTS, RELATING TO USE OF THIS
|
2005-04-17 06:20:36 +08:00
|
|
|
SOFTWARE IS DISCLAIMED.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* Bluetooth SCO sockets. */
|
|
|
|
|
|
|
|
#include <linux/module.h>
|
2010-03-21 12:27:45 +08:00
|
|
|
#include <linux/debugfs.h>
|
|
|
|
#include <linux/seq_file.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
#include <net/bluetooth/bluetooth.h>
|
|
|
|
#include <net/bluetooth/hci_core.h>
|
|
|
|
#include <net/bluetooth/sco.h>
|
|
|
|
|
2011-12-19 22:08:01 +08:00
|
|
|
static bool disable_esco;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2005-12-23 04:49:22 +08:00
|
|
|
static const struct proto_ops sco_sock_ops;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
static struct bt_sock_list sco_sk_list = {
|
2008-03-29 07:17:38 +08:00
|
|
|
.lock = __RW_LOCK_UNLOCKED(sco_sk_list.lock)
|
2005-04-17 06:20:36 +08:00
|
|
|
};
|
|
|
|
|
2014-07-11 12:19:42 +08:00
|
|
|
/* ---- SCO connections ---- */
|
|
|
|
struct sco_conn {
|
|
|
|
struct hci_conn *hcon;
|
|
|
|
|
|
|
|
spinlock_t lock;
|
|
|
|
struct sock *sk;
|
|
|
|
|
|
|
|
unsigned int mtu;
|
|
|
|
};
|
|
|
|
|
|
|
|
#define sco_conn_lock(c) spin_lock(&c->lock);
|
|
|
|
#define sco_conn_unlock(c) spin_unlock(&c->lock);
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
static void sco_sock_close(struct sock *sk);
|
|
|
|
static void sco_sock_kill(struct sock *sk);
|
|
|
|
|
2014-07-11 12:19:41 +08:00
|
|
|
/* ----- SCO socket info ----- */
|
|
|
|
#define sco_pi(sk) ((struct sco_pinfo *) sk)
|
|
|
|
|
|
|
|
struct sco_pinfo {
|
|
|
|
struct bt_sock bt;
|
|
|
|
bdaddr_t src;
|
|
|
|
bdaddr_t dst;
|
|
|
|
__u32 flags;
|
|
|
|
__u16 setting;
|
|
|
|
struct sco_conn *conn;
|
|
|
|
};
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/* ---- SCO timers ---- */
|
2014-07-11 12:19:44 +08:00
|
|
|
#define SCO_CONN_TIMEOUT (HZ * 40)
|
|
|
|
#define SCO_DISCONN_TIMEOUT (HZ * 2)
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
static void sco_sock_timeout(unsigned long arg)
|
|
|
|
{
|
|
|
|
struct sock *sk = (struct sock *) arg;
|
|
|
|
|
|
|
|
BT_DBG("sock %p state %d", sk, sk->sk_state);
|
|
|
|
|
|
|
|
bh_lock_sock(sk);
|
|
|
|
sk->sk_err = ETIMEDOUT;
|
|
|
|
sk->sk_state_change(sk);
|
|
|
|
bh_unlock_sock(sk);
|
|
|
|
|
|
|
|
sco_sock_kill(sk);
|
|
|
|
sock_put(sk);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sco_sock_set_timer(struct sock *sk, long timeout)
|
|
|
|
{
|
|
|
|
BT_DBG("sock %p state %d timeout %ld", sk, sk->sk_state, timeout);
|
|
|
|
sk_reset_timer(sk, &sk->sk_timer, jiffies + timeout);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sco_sock_clear_timer(struct sock *sk)
|
|
|
|
{
|
|
|
|
BT_DBG("sock %p state %d", sk, sk->sk_state);
|
|
|
|
sk_stop_timer(sk, &sk->sk_timer);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* ---- SCO connections ---- */
|
2012-04-19 22:12:28 +08:00
|
|
|
static struct sco_conn *sco_conn_add(struct hci_conn *hcon)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct hci_dev *hdev = hcon->hdev;
|
2006-07-06 21:40:09 +08:00
|
|
|
struct sco_conn *conn = hcon->sco_data;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-04-19 22:12:28 +08:00
|
|
|
if (conn)
|
2005-04-17 06:20:36 +08:00
|
|
|
return conn;
|
|
|
|
|
2013-04-11 22:35:45 +08:00
|
|
|
conn = kzalloc(sizeof(struct sco_conn), GFP_KERNEL);
|
2006-07-06 21:40:09 +08:00
|
|
|
if (!conn)
|
2005-04-17 06:20:36 +08:00
|
|
|
return NULL;
|
|
|
|
|
|
|
|
spin_lock_init(&conn->lock);
|
|
|
|
|
|
|
|
hcon->sco_data = conn;
|
|
|
|
conn->hcon = hcon;
|
|
|
|
|
|
|
|
if (hdev->sco_mtu > 0)
|
|
|
|
conn->mtu = hdev->sco_mtu;
|
|
|
|
else
|
|
|
|
conn->mtu = 60;
|
|
|
|
|
|
|
|
BT_DBG("hcon %p conn %p", hcon, conn);
|
2006-07-06 21:40:09 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
return conn;
|
|
|
|
}
|
|
|
|
|
2014-07-14 01:54:49 +08:00
|
|
|
/* Delete channel.
|
|
|
|
* Must be called on the locked socket. */
|
|
|
|
static void sco_chan_del(struct sock *sk, int err)
|
|
|
|
{
|
|
|
|
struct sco_conn *conn;
|
|
|
|
|
|
|
|
conn = sco_pi(sk)->conn;
|
|
|
|
|
|
|
|
BT_DBG("sk %p, conn %p, err %d", sk, conn, err);
|
|
|
|
|
|
|
|
if (conn) {
|
|
|
|
sco_conn_lock(conn);
|
|
|
|
conn->sk = NULL;
|
|
|
|
sco_pi(sk)->conn = NULL;
|
|
|
|
sco_conn_unlock(conn);
|
|
|
|
|
|
|
|
if (conn->hcon)
|
|
|
|
hci_conn_drop(conn->hcon);
|
|
|
|
}
|
|
|
|
|
|
|
|
sk->sk_state = BT_CLOSED;
|
|
|
|
sk->sk_err = err;
|
|
|
|
sk->sk_state_change(sk);
|
|
|
|
|
|
|
|
sock_set_flag(sk, SOCK_ZAPPED);
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
static int sco_conn_del(struct hci_conn *hcon, int err)
|
|
|
|
{
|
2010-12-01 22:58:22 +08:00
|
|
|
struct sco_conn *conn = hcon->sco_data;
|
2005-04-17 06:20:36 +08:00
|
|
|
struct sock *sk;
|
|
|
|
|
2010-12-01 22:58:22 +08:00
|
|
|
if (!conn)
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
BT_DBG("hcon %p conn %p, err %d", hcon, conn, err);
|
|
|
|
|
|
|
|
/* Kill socket */
|
2014-07-14 07:30:15 +08:00
|
|
|
sco_conn_lock(conn);
|
|
|
|
sk = conn->sk;
|
|
|
|
sco_conn_unlock(conn);
|
|
|
|
|
2010-12-01 22:58:22 +08:00
|
|
|
if (sk) {
|
2005-04-17 06:20:36 +08:00
|
|
|
bh_lock_sock(sk);
|
|
|
|
sco_sock_clear_timer(sk);
|
|
|
|
sco_chan_del(sk, err);
|
|
|
|
bh_unlock_sock(sk);
|
|
|
|
sco_sock_kill(sk);
|
|
|
|
}
|
|
|
|
|
|
|
|
hcon->sco_data = NULL;
|
|
|
|
kfree(conn);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-07-14 01:54:48 +08:00
|
|
|
static void __sco_chan_add(struct sco_conn *conn, struct sock *sk, struct sock *parent)
|
|
|
|
{
|
|
|
|
BT_DBG("conn %p", conn);
|
|
|
|
|
|
|
|
sco_pi(sk)->conn = conn;
|
|
|
|
conn->sk = sk;
|
|
|
|
|
|
|
|
if (parent)
|
|
|
|
bt_accept_enqueue(parent, sk);
|
|
|
|
}
|
|
|
|
|
2012-05-23 15:04:18 +08:00
|
|
|
static int sco_chan_add(struct sco_conn *conn, struct sock *sk,
|
|
|
|
struct sock *parent)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
int err = 0;
|
|
|
|
|
|
|
|
sco_conn_lock(conn);
|
2010-05-02 03:15:35 +08:00
|
|
|
if (conn->sk)
|
2005-04-17 06:20:36 +08:00
|
|
|
err = -EBUSY;
|
2010-05-02 03:15:35 +08:00
|
|
|
else
|
2005-04-17 06:20:36 +08:00
|
|
|
__sco_chan_add(conn, sk, parent);
|
2010-05-02 03:15:35 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
sco_conn_unlock(conn);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int sco_connect(struct sock *sk)
|
|
|
|
{
|
|
|
|
struct sco_conn *conn;
|
|
|
|
struct hci_conn *hcon;
|
|
|
|
struct hci_dev *hdev;
|
2007-10-20 20:55:10 +08:00
|
|
|
int err, type;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2013-10-14 01:34:01 +08:00
|
|
|
BT_DBG("%pMR -> %pMR", &sco_pi(sk)->src, &sco_pi(sk)->dst);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2013-10-14 01:34:01 +08:00
|
|
|
hdev = hci_get_route(&sco_pi(sk)->dst, &sco_pi(sk)->src);
|
2010-12-01 22:58:22 +08:00
|
|
|
if (!hdev)
|
2005-04-17 06:20:36 +08:00
|
|
|
return -EHOSTUNREACH;
|
|
|
|
|
2011-06-18 00:03:21 +08:00
|
|
|
hci_dev_lock(hdev);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-07-15 02:13:53 +08:00
|
|
|
if (lmp_esco_capable(hdev) && !disable_esco)
|
|
|
|
type = ESCO_LINK;
|
|
|
|
else
|
|
|
|
type = SCO_LINK;
|
2007-10-20 20:55:10 +08:00
|
|
|
|
2013-08-19 20:24:01 +08:00
|
|
|
if (sco_pi(sk)->setting == BT_VOICE_TRANSPARENT &&
|
|
|
|
(!lmp_transp_capable(hdev) || !lmp_esco_capable(hdev))) {
|
|
|
|
err = -EOPNOTSUPP;
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
2013-10-14 01:34:01 +08:00
|
|
|
hcon = hci_connect_sco(hdev, type, &sco_pi(sk)->dst,
|
2013-10-14 01:15:22 +08:00
|
|
|
sco_pi(sk)->setting);
|
2011-02-23 03:10:53 +08:00
|
|
|
if (IS_ERR(hcon)) {
|
|
|
|
err = PTR_ERR(hcon);
|
2005-04-17 06:20:36 +08:00
|
|
|
goto done;
|
2011-02-23 03:10:53 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-04-19 22:12:28 +08:00
|
|
|
conn = sco_conn_add(hcon);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (!conn) {
|
2013-04-07 02:28:37 +08:00
|
|
|
hci_conn_drop(hcon);
|
2011-02-23 03:10:53 +08:00
|
|
|
err = -ENOMEM;
|
2005-04-17 06:20:36 +08:00
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Update source addr of the socket */
|
2013-10-14 01:34:01 +08:00
|
|
|
bacpy(&sco_pi(sk)->src, &hcon->src);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
err = sco_chan_add(conn, sk, NULL);
|
|
|
|
if (err)
|
|
|
|
goto done;
|
|
|
|
|
|
|
|
if (hcon->state == BT_CONNECTED) {
|
|
|
|
sco_sock_clear_timer(sk);
|
|
|
|
sk->sk_state = BT_CONNECTED;
|
|
|
|
} else {
|
|
|
|
sk->sk_state = BT_CONNECT;
|
|
|
|
sco_sock_set_timer(sk, sk->sk_sndtimeo);
|
|
|
|
}
|
2007-10-20 20:55:10 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
done:
|
2011-06-18 00:03:21 +08:00
|
|
|
hci_dev_unlock(hdev);
|
2005-04-17 06:20:36 +08:00
|
|
|
hci_dev_put(hdev);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2012-05-23 15:04:18 +08:00
|
|
|
static int sco_send_frame(struct sock *sk, struct msghdr *msg, int len)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct sco_conn *conn = sco_pi(sk)->conn;
|
|
|
|
struct sk_buff *skb;
|
2012-04-11 14:48:48 +08:00
|
|
|
int err;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
/* Check outgoing MTU */
|
|
|
|
if (len > conn->mtu)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
BT_DBG("sk %p len %d", sk, len);
|
|
|
|
|
2012-04-11 14:48:48 +08:00
|
|
|
skb = bt_skb_send_alloc(sk, len, msg->msg_flags & MSG_DONTWAIT, &err);
|
2010-05-02 03:15:35 +08:00
|
|
|
if (!skb)
|
2005-04-17 06:20:36 +08:00
|
|
|
return err;
|
|
|
|
|
2014-04-07 09:25:44 +08:00
|
|
|
if (memcpy_from_msg(skb_put(skb, len), msg, len)) {
|
2010-05-02 03:15:35 +08:00
|
|
|
kfree_skb(skb);
|
|
|
|
return -EFAULT;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2010-05-02 03:15:35 +08:00
|
|
|
hci_send_sco(conn->hcon, skb);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-04-11 14:48:48 +08:00
|
|
|
return len;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2012-05-23 15:04:18 +08:00
|
|
|
static void sco_recv_frame(struct sco_conn *conn, struct sk_buff *skb)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2014-07-14 07:30:15 +08:00
|
|
|
struct sock *sk;
|
|
|
|
|
|
|
|
sco_conn_lock(conn);
|
|
|
|
sk = conn->sk;
|
|
|
|
sco_conn_unlock(conn);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
if (!sk)
|
|
|
|
goto drop;
|
|
|
|
|
|
|
|
BT_DBG("sk %p len %d", sk, skb->len);
|
|
|
|
|
|
|
|
if (sk->sk_state != BT_CONNECTED)
|
|
|
|
goto drop;
|
|
|
|
|
|
|
|
if (!sock_queue_rcv_skb(sk, skb))
|
|
|
|
return;
|
|
|
|
|
|
|
|
drop:
|
|
|
|
kfree_skb(skb);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* -------- Socket interface ---------- */
|
2012-04-19 20:37:58 +08:00
|
|
|
static struct sock *__sco_get_sock_listen_by_addr(bdaddr_t *ba)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2012-04-19 20:37:58 +08:00
|
|
|
struct sock *sk;
|
|
|
|
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:06:00 +08:00
|
|
|
sk_for_each(sk, &sco_sk_list.head) {
|
2012-04-19 20:37:58 +08:00
|
|
|
if (sk->sk_state != BT_LISTEN)
|
|
|
|
continue;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2013-10-14 01:34:01 +08:00
|
|
|
if (!bacmp(&sco_pi(sk)->src, ba))
|
2012-04-19 20:37:58 +08:00
|
|
|
return sk;
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Find socket listening on source bdaddr.
|
|
|
|
* Returns closest match.
|
|
|
|
*/
|
|
|
|
static struct sock *sco_get_sock_listen(bdaddr_t *src)
|
|
|
|
{
|
|
|
|
struct sock *sk = NULL, *sk1 = NULL;
|
|
|
|
|
|
|
|
read_lock(&sco_sk_list.lock);
|
|
|
|
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:06:00 +08:00
|
|
|
sk_for_each(sk, &sco_sk_list.head) {
|
2005-04-17 06:20:36 +08:00
|
|
|
if (sk->sk_state != BT_LISTEN)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
/* Exact match. */
|
2013-10-14 01:34:01 +08:00
|
|
|
if (!bacmp(&sco_pi(sk)->src, src))
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
|
|
|
|
/* Closest match */
|
2013-10-14 01:34:01 +08:00
|
|
|
if (!bacmp(&sco_pi(sk)->src, BDADDR_ANY))
|
2005-04-17 06:20:36 +08:00
|
|
|
sk1 = sk;
|
|
|
|
}
|
|
|
|
|
|
|
|
read_unlock(&sco_sk_list.lock);
|
|
|
|
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:06:00 +08:00
|
|
|
return sk ? sk : sk1;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void sco_sock_destruct(struct sock *sk)
|
|
|
|
{
|
|
|
|
BT_DBG("sk %p", sk);
|
|
|
|
|
|
|
|
skb_queue_purge(&sk->sk_receive_queue);
|
|
|
|
skb_queue_purge(&sk->sk_write_queue);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sco_sock_cleanup_listen(struct sock *parent)
|
|
|
|
{
|
|
|
|
struct sock *sk;
|
|
|
|
|
|
|
|
BT_DBG("parent %p", parent);
|
|
|
|
|
|
|
|
/* Close not yet accepted channels */
|
|
|
|
while ((sk = bt_accept_dequeue(parent, NULL))) {
|
|
|
|
sco_sock_close(sk);
|
|
|
|
sco_sock_kill(sk);
|
|
|
|
}
|
|
|
|
|
|
|
|
parent->sk_state = BT_CLOSED;
|
|
|
|
sock_set_flag(parent, SOCK_ZAPPED);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Kill socket (only if zapped and orphan)
|
|
|
|
* Must be called on unlocked socket.
|
|
|
|
*/
|
|
|
|
static void sco_sock_kill(struct sock *sk)
|
|
|
|
{
|
|
|
|
if (!sock_flag(sk, SOCK_ZAPPED) || sk->sk_socket)
|
|
|
|
return;
|
|
|
|
|
|
|
|
BT_DBG("sk %p state %d", sk, sk->sk_state);
|
|
|
|
|
|
|
|
/* Kill poor orphan */
|
|
|
|
bt_sock_unlink(&sco_sk_list, sk);
|
|
|
|
sock_set_flag(sk, SOCK_DEAD);
|
|
|
|
sock_put(sk);
|
|
|
|
}
|
|
|
|
|
2009-06-16 06:01:49 +08:00
|
|
|
static void __sco_sock_close(struct sock *sk)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2009-06-16 06:01:49 +08:00
|
|
|
BT_DBG("sk %p state %d socket %p", sk, sk->sk_state, sk->sk_socket);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
switch (sk->sk_state) {
|
|
|
|
case BT_LISTEN:
|
|
|
|
sco_sock_cleanup_listen(sk);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case BT_CONNECTED:
|
|
|
|
case BT_CONFIG:
|
2013-01-04 05:59:28 +08:00
|
|
|
if (sco_pi(sk)->conn->hcon) {
|
2011-05-12 16:13:15 +08:00
|
|
|
sk->sk_state = BT_DISCONN;
|
|
|
|
sco_sock_set_timer(sk, SCO_DISCONN_TIMEOUT);
|
2013-04-07 02:28:37 +08:00
|
|
|
hci_conn_drop(sco_pi(sk)->conn->hcon);
|
2011-05-12 16:13:15 +08:00
|
|
|
sco_pi(sk)->conn->hcon = NULL;
|
|
|
|
} else
|
|
|
|
sco_chan_del(sk, ECONNRESET);
|
|
|
|
break;
|
|
|
|
|
2013-03-14 06:46:20 +08:00
|
|
|
case BT_CONNECT2:
|
2005-04-17 06:20:36 +08:00
|
|
|
case BT_CONNECT:
|
|
|
|
case BT_DISCONN:
|
|
|
|
sco_chan_del(sk, ECONNRESET);
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
sock_set_flag(sk, SOCK_ZAPPED);
|
|
|
|
break;
|
2007-04-21 08:09:22 +08:00
|
|
|
}
|
2009-06-16 06:01:49 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-06-16 06:01:49 +08:00
|
|
|
/* Must be called on unlocked socket. */
|
|
|
|
static void sco_sock_close(struct sock *sk)
|
|
|
|
{
|
|
|
|
sco_sock_clear_timer(sk);
|
|
|
|
lock_sock(sk);
|
|
|
|
__sco_sock_close(sk);
|
2005-04-17 06:20:36 +08:00
|
|
|
release_sock(sk);
|
|
|
|
sco_sock_kill(sk);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sco_sock_init(struct sock *sk, struct sock *parent)
|
|
|
|
{
|
|
|
|
BT_DBG("sk %p", sk);
|
|
|
|
|
2011-10-07 17:40:59 +08:00
|
|
|
if (parent) {
|
2005-04-17 06:20:36 +08:00
|
|
|
sk->sk_type = parent->sk_type;
|
2012-11-21 17:51:12 +08:00
|
|
|
bt_sk(sk)->flags = bt_sk(parent)->flags;
|
2011-10-07 17:40:59 +08:00
|
|
|
security_sk_clone(parent, sk);
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct proto sco_proto = {
|
|
|
|
.name = "SCO",
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.obj_size = sizeof(struct sco_pinfo)
|
|
|
|
};
|
|
|
|
|
2007-10-09 14:24:22 +08:00
|
|
|
static struct sock *sco_sock_alloc(struct net *net, struct socket *sock, int proto, gfp_t prio)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct sock *sk;
|
|
|
|
|
2007-11-01 15:39:31 +08:00
|
|
|
sk = sk_alloc(net, PF_BLUETOOTH, prio, &sco_proto);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (!sk)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
sock_init_data(sock, sk);
|
|
|
|
INIT_LIST_HEAD(&bt_sk(sk)->accept_q);
|
|
|
|
|
|
|
|
sk->sk_destruct = sco_sock_destruct;
|
|
|
|
sk->sk_sndtimeo = SCO_CONN_TIMEOUT;
|
|
|
|
|
|
|
|
sock_reset_flag(sk, SOCK_ZAPPED);
|
|
|
|
|
|
|
|
sk->sk_protocol = proto;
|
|
|
|
sk->sk_state = BT_OPEN;
|
|
|
|
|
2013-08-19 20:23:56 +08:00
|
|
|
sco_pi(sk)->setting = BT_VOICE_CVSD_16BIT;
|
|
|
|
|
2008-01-24 13:20:07 +08:00
|
|
|
setup_timer(&sk->sk_timer, sco_sock_timeout, (unsigned long)sk);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
bt_sock_link(&sco_sk_list, sk);
|
|
|
|
return sk;
|
|
|
|
}
|
|
|
|
|
2009-11-06 14:18:14 +08:00
|
|
|
static int sco_sock_create(struct net *net, struct socket *sock, int protocol,
|
|
|
|
int kern)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct sock *sk;
|
|
|
|
|
|
|
|
BT_DBG("sock %p", sock);
|
|
|
|
|
|
|
|
sock->state = SS_UNCONNECTED;
|
|
|
|
|
|
|
|
if (sock->type != SOCK_SEQPACKET)
|
|
|
|
return -ESOCKTNOSUPPORT;
|
|
|
|
|
|
|
|
sock->ops = &sco_sock_ops;
|
|
|
|
|
2007-10-09 14:24:22 +08:00
|
|
|
sk = sco_sock_alloc(net, sock, protocol, GFP_ATOMIC);
|
2006-10-15 23:31:14 +08:00
|
|
|
if (!sk)
|
2005-04-17 06:20:36 +08:00
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
sco_sock_init(sk, NULL);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int sco_sock_bind(struct socket *sock, struct sockaddr *addr, int addr_len)
|
|
|
|
{
|
|
|
|
struct sockaddr_sco *sa = (struct sockaddr_sco *) addr;
|
|
|
|
struct sock *sk = sock->sk;
|
|
|
|
int err = 0;
|
|
|
|
|
2012-09-25 17:49:43 +08:00
|
|
|
BT_DBG("sk %p %pMR", sk, &sa->sco_bdaddr);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
if (!addr || addr->sa_family != AF_BLUETOOTH)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
lock_sock(sk);
|
|
|
|
|
|
|
|
if (sk->sk_state != BT_OPEN) {
|
|
|
|
err = -EBADFD;
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
2012-04-19 19:43:53 +08:00
|
|
|
if (sk->sk_type != SOCK_SEQPACKET) {
|
|
|
|
err = -EINVAL;
|
|
|
|
goto done;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2013-10-14 01:34:01 +08:00
|
|
|
bacpy(&sco_pi(sk)->src, &sa->sco_bdaddr);
|
2012-04-19 19:43:53 +08:00
|
|
|
|
|
|
|
sk->sk_state = BT_BOUND;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
done:
|
|
|
|
release_sock(sk);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int sco_sock_connect(struct socket *sock, struct sockaddr *addr, int alen, int flags)
|
|
|
|
{
|
|
|
|
struct sockaddr_sco *sa = (struct sockaddr_sco *) addr;
|
|
|
|
struct sock *sk = sock->sk;
|
2013-04-11 22:35:46 +08:00
|
|
|
int err;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
BT_DBG("sk %p", sk);
|
|
|
|
|
2010-04-01 06:58:26 +08:00
|
|
|
if (alen < sizeof(struct sockaddr_sco) ||
|
|
|
|
addr->sa_family != AF_BLUETOOTH)
|
2005-04-17 06:20:36 +08:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (sk->sk_state != BT_OPEN && sk->sk_state != BT_BOUND)
|
|
|
|
return -EBADFD;
|
|
|
|
|
|
|
|
if (sk->sk_type != SOCK_SEQPACKET)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
lock_sock(sk);
|
|
|
|
|
|
|
|
/* Set destination address and psm */
|
2013-10-14 01:34:01 +08:00
|
|
|
bacpy(&sco_pi(sk)->dst, &sa->sco_bdaddr);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-12-01 22:58:22 +08:00
|
|
|
err = sco_connect(sk);
|
|
|
|
if (err)
|
2005-04-17 06:20:36 +08:00
|
|
|
goto done;
|
|
|
|
|
2007-02-09 22:24:33 +08:00
|
|
|
err = bt_sock_wait_state(sk, BT_CONNECTED,
|
2012-05-17 11:36:21 +08:00
|
|
|
sock_sndtimeo(sk, flags & O_NONBLOCK));
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
done:
|
|
|
|
release_sock(sk);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int sco_sock_listen(struct socket *sock, int backlog)
|
|
|
|
{
|
|
|
|
struct sock *sk = sock->sk;
|
2013-10-14 01:34:01 +08:00
|
|
|
bdaddr_t *src = &sco_pi(sk)->src;
|
2005-04-17 06:20:36 +08:00
|
|
|
int err = 0;
|
|
|
|
|
|
|
|
BT_DBG("sk %p backlog %d", sk, backlog);
|
|
|
|
|
|
|
|
lock_sock(sk);
|
|
|
|
|
2012-04-19 19:43:52 +08:00
|
|
|
if (sk->sk_state != BT_BOUND) {
|
2005-04-17 06:20:36 +08:00
|
|
|
err = -EBADFD;
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
2012-04-19 19:43:52 +08:00
|
|
|
if (sk->sk_type != SOCK_SEQPACKET) {
|
|
|
|
err = -EINVAL;
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
2012-04-19 20:37:58 +08:00
|
|
|
write_lock(&sco_sk_list.lock);
|
|
|
|
|
|
|
|
if (__sco_get_sock_listen_by_addr(src)) {
|
|
|
|
err = -EADDRINUSE;
|
|
|
|
goto unlock;
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
sk->sk_max_ack_backlog = backlog;
|
|
|
|
sk->sk_ack_backlog = 0;
|
2012-04-19 20:37:58 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
sk->sk_state = BT_LISTEN;
|
|
|
|
|
2012-04-19 20:37:58 +08:00
|
|
|
unlock:
|
|
|
|
write_unlock(&sco_sk_list.lock);
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
done:
|
|
|
|
release_sock(sk);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int sco_sock_accept(struct socket *sock, struct socket *newsock, int flags)
|
|
|
|
{
|
2015-01-24 01:16:53 +08:00
|
|
|
DEFINE_WAIT_FUNC(wait, woken_wake_function);
|
2005-04-17 06:20:36 +08:00
|
|
|
struct sock *sk = sock->sk, *ch;
|
|
|
|
long timeo;
|
|
|
|
int err = 0;
|
|
|
|
|
|
|
|
lock_sock(sk);
|
|
|
|
|
|
|
|
timeo = sock_rcvtimeo(sk, flags & O_NONBLOCK);
|
|
|
|
|
|
|
|
BT_DBG("sk %p timeo %ld", sk, timeo);
|
|
|
|
|
|
|
|
/* Wait for an incoming connection. (wake-one). */
|
2010-04-20 21:03:51 +08:00
|
|
|
add_wait_queue_exclusive(sk_sleep(sk), &wait);
|
2011-07-24 12:11:01 +08:00
|
|
|
while (1) {
|
|
|
|
if (sk->sk_state != BT_LISTEN) {
|
|
|
|
err = -EBADFD;
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2011-07-24 12:11:01 +08:00
|
|
|
ch = bt_accept_dequeue(sk, newsock);
|
|
|
|
if (ch)
|
|
|
|
break;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2011-07-24 12:11:01 +08:00
|
|
|
if (!timeo) {
|
|
|
|
err = -EAGAIN;
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (signal_pending(current)) {
|
|
|
|
err = sock_intr_errno(timeo);
|
|
|
|
break;
|
|
|
|
}
|
2011-07-24 12:11:01 +08:00
|
|
|
|
|
|
|
release_sock(sk);
|
2015-01-24 01:16:53 +08:00
|
|
|
|
|
|
|
timeo = wait_woken(&wait, TASK_INTERRUPTIBLE, timeo);
|
2011-07-24 12:11:01 +08:00
|
|
|
lock_sock(sk);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2010-04-20 21:03:51 +08:00
|
|
|
remove_wait_queue(sk_sleep(sk), &wait);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
if (err)
|
|
|
|
goto done;
|
|
|
|
|
|
|
|
newsock->state = SS_CONNECTED;
|
|
|
|
|
|
|
|
BT_DBG("new socket %p", ch);
|
|
|
|
|
|
|
|
done:
|
|
|
|
release_sock(sk);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int sco_sock_getname(struct socket *sock, struct sockaddr *addr, int *len, int peer)
|
|
|
|
{
|
|
|
|
struct sockaddr_sco *sa = (struct sockaddr_sco *) addr;
|
|
|
|
struct sock *sk = sock->sk;
|
|
|
|
|
|
|
|
BT_DBG("sock %p, sk %p", sock, sk);
|
|
|
|
|
|
|
|
addr->sa_family = AF_BLUETOOTH;
|
|
|
|
*len = sizeof(struct sockaddr_sco);
|
|
|
|
|
|
|
|
if (peer)
|
2013-10-14 01:34:01 +08:00
|
|
|
bacpy(&sa->sco_bdaddr, &sco_pi(sk)->dst);
|
2005-04-17 06:20:36 +08:00
|
|
|
else
|
2013-10-14 01:34:01 +08:00
|
|
|
bacpy(&sa->sco_bdaddr, &sco_pi(sk)->src);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-03-02 15:37:48 +08:00
|
|
|
static int sco_sock_sendmsg(struct socket *sock, struct msghdr *msg,
|
|
|
|
size_t len)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct sock *sk = sock->sk;
|
2010-05-02 03:15:35 +08:00
|
|
|
int err;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
BT_DBG("sock %p, sk %p", sock, sk);
|
|
|
|
|
2005-12-14 15:22:19 +08:00
|
|
|
err = sock_error(sk);
|
|
|
|
if (err)
|
|
|
|
return err;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
if (msg->msg_flags & MSG_OOB)
|
|
|
|
return -EOPNOTSUPP;
|
|
|
|
|
|
|
|
lock_sock(sk);
|
|
|
|
|
|
|
|
if (sk->sk_state == BT_CONNECTED)
|
|
|
|
err = sco_send_frame(sk, msg, len);
|
|
|
|
else
|
|
|
|
err = -ENOTCONN;
|
|
|
|
|
|
|
|
release_sock(sk);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2013-08-19 20:23:58 +08:00
|
|
|
static void sco_conn_defer_accept(struct hci_conn *conn, u16 setting)
|
2013-04-16 23:28:58 +08:00
|
|
|
{
|
|
|
|
struct hci_dev *hdev = conn->hdev;
|
|
|
|
|
|
|
|
BT_DBG("conn %p", conn);
|
|
|
|
|
|
|
|
conn->state = BT_CONFIG;
|
|
|
|
|
|
|
|
if (!lmp_esco_capable(hdev)) {
|
|
|
|
struct hci_cp_accept_conn_req cp;
|
|
|
|
|
|
|
|
bacpy(&cp.bdaddr, &conn->dst);
|
2013-08-19 20:23:55 +08:00
|
|
|
cp.role = 0x00; /* Ignored */
|
2013-04-16 23:28:58 +08:00
|
|
|
|
|
|
|
hci_send_cmd(hdev, HCI_OP_ACCEPT_CONN_REQ, sizeof(cp), &cp);
|
|
|
|
} else {
|
|
|
|
struct hci_cp_accept_sync_conn_req cp;
|
|
|
|
|
|
|
|
bacpy(&cp.bdaddr, &conn->dst);
|
|
|
|
cp.pkt_type = cpu_to_le16(conn->pkt_type);
|
|
|
|
|
2014-03-13 01:52:35 +08:00
|
|
|
cp.tx_bandwidth = cpu_to_le32(0x00001f40);
|
|
|
|
cp.rx_bandwidth = cpu_to_le32(0x00001f40);
|
2013-08-19 20:23:58 +08:00
|
|
|
cp.content_format = cpu_to_le16(setting);
|
|
|
|
|
|
|
|
switch (setting & SCO_AIRMODE_MASK) {
|
|
|
|
case SCO_AIRMODE_TRANSP:
|
|
|
|
if (conn->pkt_type & ESCO_2EV3)
|
2014-03-13 01:52:35 +08:00
|
|
|
cp.max_latency = cpu_to_le16(0x0008);
|
2013-08-19 20:23:58 +08:00
|
|
|
else
|
2014-03-13 01:52:35 +08:00
|
|
|
cp.max_latency = cpu_to_le16(0x000D);
|
2013-08-19 20:23:58 +08:00
|
|
|
cp.retrans_effort = 0x02;
|
|
|
|
break;
|
|
|
|
case SCO_AIRMODE_CVSD:
|
2014-03-13 01:52:35 +08:00
|
|
|
cp.max_latency = cpu_to_le16(0xffff);
|
2013-08-19 20:23:58 +08:00
|
|
|
cp.retrans_effort = 0xff;
|
|
|
|
break;
|
|
|
|
}
|
2013-04-16 23:28:58 +08:00
|
|
|
|
|
|
|
hci_send_cmd(hdev, HCI_OP_ACCEPT_SYNC_CONN_REQ,
|
|
|
|
sizeof(cp), &cp);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-03-02 15:37:48 +08:00
|
|
|
static int sco_sock_recvmsg(struct socket *sock, struct msghdr *msg,
|
|
|
|
size_t len, int flags)
|
2012-11-21 17:51:12 +08:00
|
|
|
{
|
|
|
|
struct sock *sk = sock->sk;
|
|
|
|
struct sco_pinfo *pi = sco_pi(sk);
|
|
|
|
|
|
|
|
lock_sock(sk);
|
|
|
|
|
|
|
|
if (sk->sk_state == BT_CONNECT2 &&
|
|
|
|
test_bit(BT_SK_DEFER_SETUP, &bt_sk(sk)->flags)) {
|
2013-08-19 20:23:58 +08:00
|
|
|
sco_conn_defer_accept(pi->conn->hcon, pi->setting);
|
2012-11-21 17:51:12 +08:00
|
|
|
sk->sk_state = BT_CONFIG;
|
|
|
|
|
|
|
|
release_sock(sk);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
release_sock(sk);
|
|
|
|
|
2015-03-02 15:37:48 +08:00
|
|
|
return bt_sock_recvmsg(sock, msg, len, flags);
|
2012-11-21 17:51:12 +08:00
|
|
|
}
|
|
|
|
|
2009-10-01 07:12:20 +08:00
|
|
|
static int sco_sock_setsockopt(struct socket *sock, int level, int optname, char __user *optval, unsigned int optlen)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct sock *sk = sock->sk;
|
2013-08-19 20:23:56 +08:00
|
|
|
int len, err = 0;
|
|
|
|
struct bt_voice voice;
|
2012-11-21 17:51:11 +08:00
|
|
|
u32 opt;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
BT_DBG("sk %p", sk);
|
|
|
|
|
|
|
|
lock_sock(sk);
|
|
|
|
|
|
|
|
switch (optname) {
|
2012-11-21 17:51:11 +08:00
|
|
|
|
|
|
|
case BT_DEFER_SETUP:
|
|
|
|
if (sk->sk_state != BT_BOUND && sk->sk_state != BT_LISTEN) {
|
|
|
|
err = -EINVAL;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (get_user(opt, (u32 __user *) optval)) {
|
|
|
|
err = -EFAULT;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (opt)
|
|
|
|
set_bit(BT_SK_DEFER_SETUP, &bt_sk(sk)->flags);
|
|
|
|
else
|
|
|
|
clear_bit(BT_SK_DEFER_SETUP, &bt_sk(sk)->flags);
|
|
|
|
break;
|
|
|
|
|
2013-08-19 20:23:56 +08:00
|
|
|
case BT_VOICE:
|
|
|
|
if (sk->sk_state != BT_OPEN && sk->sk_state != BT_BOUND &&
|
|
|
|
sk->sk_state != BT_CONNECT2) {
|
|
|
|
err = -EINVAL;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
voice.setting = sco_pi(sk)->setting;
|
|
|
|
|
|
|
|
len = min_t(unsigned int, sizeof(voice), optlen);
|
|
|
|
if (copy_from_user((char *) &voice, optval, len)) {
|
|
|
|
err = -EFAULT;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Explicitly check for these values */
|
|
|
|
if (voice.setting != BT_VOICE_TRANSPARENT &&
|
|
|
|
voice.setting != BT_VOICE_CVSD_16BIT) {
|
|
|
|
err = -EINVAL;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
sco_pi(sk)->setting = voice.setting;
|
|
|
|
break;
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
default:
|
|
|
|
err = -ENOPROTOOPT;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
release_sock(sk);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2009-01-16 04:52:14 +08:00
|
|
|
static int sco_sock_getsockopt_old(struct socket *sock, int optname, char __user *optval, int __user *optlen)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct sock *sk = sock->sk;
|
|
|
|
struct sco_options opts;
|
|
|
|
struct sco_conninfo cinfo;
|
2007-02-09 22:24:33 +08:00
|
|
|
int len, err = 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
BT_DBG("sk %p", sk);
|
|
|
|
|
|
|
|
if (get_user(len, optlen))
|
|
|
|
return -EFAULT;
|
|
|
|
|
|
|
|
lock_sock(sk);
|
|
|
|
|
|
|
|
switch (optname) {
|
|
|
|
case SCO_OPTIONS:
|
2013-08-08 19:53:56 +08:00
|
|
|
if (sk->sk_state != BT_CONNECTED &&
|
|
|
|
!(sk->sk_state == BT_CONNECT2 &&
|
|
|
|
test_bit(BT_SK_DEFER_SETUP, &bt_sk(sk)->flags))) {
|
2005-04-17 06:20:36 +08:00
|
|
|
err = -ENOTCONN;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
opts.mtu = sco_pi(sk)->conn->mtu;
|
|
|
|
|
|
|
|
BT_DBG("mtu %d", opts.mtu);
|
|
|
|
|
|
|
|
len = min_t(unsigned int, len, sizeof(opts));
|
|
|
|
if (copy_to_user(optval, (char *)&opts, len))
|
|
|
|
err = -EFAULT;
|
|
|
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
case SCO_CONNINFO:
|
2013-08-08 19:53:56 +08:00
|
|
|
if (sk->sk_state != BT_CONNECTED &&
|
|
|
|
!(sk->sk_state == BT_CONNECT2 &&
|
|
|
|
test_bit(BT_SK_DEFER_SETUP, &bt_sk(sk)->flags))) {
|
2005-04-17 06:20:36 +08:00
|
|
|
err = -ENOTCONN;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2011-02-14 18:54:26 +08:00
|
|
|
memset(&cinfo, 0, sizeof(cinfo));
|
2005-04-17 06:20:36 +08:00
|
|
|
cinfo.hci_handle = sco_pi(sk)->conn->hcon->handle;
|
|
|
|
memcpy(cinfo.dev_class, sco_pi(sk)->conn->hcon->dev_class, 3);
|
|
|
|
|
|
|
|
len = min_t(unsigned int, len, sizeof(cinfo));
|
|
|
|
if (copy_to_user(optval, (char *)&cinfo, len))
|
|
|
|
err = -EFAULT;
|
|
|
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
err = -ENOPROTOOPT;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
release_sock(sk);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2009-01-16 04:52:14 +08:00
|
|
|
static int sco_sock_getsockopt(struct socket *sock, int level, int optname, char __user *optval, int __user *optlen)
|
|
|
|
{
|
|
|
|
struct sock *sk = sock->sk;
|
|
|
|
int len, err = 0;
|
2013-08-19 20:23:56 +08:00
|
|
|
struct bt_voice voice;
|
2009-01-16 04:52:14 +08:00
|
|
|
|
|
|
|
BT_DBG("sk %p", sk);
|
|
|
|
|
|
|
|
if (level == SOL_SCO)
|
|
|
|
return sco_sock_getsockopt_old(sock, optname, optval, optlen);
|
|
|
|
|
|
|
|
if (get_user(len, optlen))
|
|
|
|
return -EFAULT;
|
|
|
|
|
|
|
|
lock_sock(sk);
|
|
|
|
|
|
|
|
switch (optname) {
|
2012-11-21 17:51:11 +08:00
|
|
|
|
|
|
|
case BT_DEFER_SETUP:
|
|
|
|
if (sk->sk_state != BT_BOUND && sk->sk_state != BT_LISTEN) {
|
|
|
|
err = -EINVAL;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (put_user(test_bit(BT_SK_DEFER_SETUP, &bt_sk(sk)->flags),
|
|
|
|
(u32 __user *) optval))
|
|
|
|
err = -EFAULT;
|
|
|
|
|
|
|
|
break;
|
|
|
|
|
2013-08-19 20:23:56 +08:00
|
|
|
case BT_VOICE:
|
|
|
|
voice.setting = sco_pi(sk)->setting;
|
|
|
|
|
|
|
|
len = min_t(unsigned int, len, sizeof(voice));
|
|
|
|
if (copy_to_user(optval, (char *)&voice, len))
|
|
|
|
err = -EFAULT;
|
|
|
|
|
|
|
|
break;
|
|
|
|
|
2009-01-16 04:52:14 +08:00
|
|
|
default:
|
|
|
|
err = -ENOPROTOOPT;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
release_sock(sk);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2009-06-16 06:01:49 +08:00
|
|
|
static int sco_sock_shutdown(struct socket *sock, int how)
|
|
|
|
{
|
|
|
|
struct sock *sk = sock->sk;
|
|
|
|
int err = 0;
|
|
|
|
|
|
|
|
BT_DBG("sock %p, sk %p", sock, sk);
|
|
|
|
|
|
|
|
if (!sk)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
lock_sock(sk);
|
|
|
|
if (!sk->sk_shutdown) {
|
|
|
|
sk->sk_shutdown = SHUTDOWN_MASK;
|
|
|
|
sco_sock_clear_timer(sk);
|
|
|
|
__sco_sock_close(sk);
|
|
|
|
|
Bluetooth: never linger on process exit
If the current process is exiting, lingering on socket close will make
it unkillable, so we should avoid it.
Reproducer:
#include <sys/types.h>
#include <sys/socket.h>
#define BTPROTO_L2CAP 0
#define BTPROTO_SCO 2
#define BTPROTO_RFCOMM 3
int main()
{
int fd;
struct linger ling;
fd = socket(PF_BLUETOOTH, SOCK_STREAM, BTPROTO_RFCOMM);
//or: fd = socket(PF_BLUETOOTH, SOCK_DGRAM, BTPROTO_L2CAP);
//or: fd = socket(PF_BLUETOOTH, SOCK_SEQPACKET, BTPROTO_SCO);
ling.l_onoff = 1;
ling.l_linger = 1000000000;
setsockopt(fd, SOL_SOCKET, SO_LINGER, &ling, sizeof(ling));
return 0;
}
Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Cc: stable@vger.kernel.org
2014-07-15 16:25:28 +08:00
|
|
|
if (sock_flag(sk, SOCK_LINGER) && sk->sk_lingertime &&
|
|
|
|
!(current->flags & PF_EXITING))
|
2009-06-16 06:01:49 +08:00
|
|
|
err = bt_sock_wait_state(sk, BT_CLOSED,
|
2012-05-17 11:36:21 +08:00
|
|
|
sk->sk_lingertime);
|
2009-06-16 06:01:49 +08:00
|
|
|
}
|
|
|
|
release_sock(sk);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
static int sco_sock_release(struct socket *sock)
|
|
|
|
{
|
|
|
|
struct sock *sk = sock->sk;
|
|
|
|
int err = 0;
|
|
|
|
|
|
|
|
BT_DBG("sock %p, sk %p", sock, sk);
|
|
|
|
|
|
|
|
if (!sk)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
sco_sock_close(sk);
|
|
|
|
|
Bluetooth: never linger on process exit
If the current process is exiting, lingering on socket close will make
it unkillable, so we should avoid it.
Reproducer:
#include <sys/types.h>
#include <sys/socket.h>
#define BTPROTO_L2CAP 0
#define BTPROTO_SCO 2
#define BTPROTO_RFCOMM 3
int main()
{
int fd;
struct linger ling;
fd = socket(PF_BLUETOOTH, SOCK_STREAM, BTPROTO_RFCOMM);
//or: fd = socket(PF_BLUETOOTH, SOCK_DGRAM, BTPROTO_L2CAP);
//or: fd = socket(PF_BLUETOOTH, SOCK_SEQPACKET, BTPROTO_SCO);
ling.l_onoff = 1;
ling.l_linger = 1000000000;
setsockopt(fd, SOL_SOCKET, SO_LINGER, &ling, sizeof(ling));
return 0;
}
Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Cc: stable@vger.kernel.org
2014-07-15 16:25:28 +08:00
|
|
|
if (sock_flag(sk, SOCK_LINGER) && sk->sk_lingertime &&
|
|
|
|
!(current->flags & PF_EXITING)) {
|
2005-04-17 06:20:36 +08:00
|
|
|
lock_sock(sk);
|
|
|
|
err = bt_sock_wait_state(sk, BT_CLOSED, sk->sk_lingertime);
|
|
|
|
release_sock(sk);
|
|
|
|
}
|
|
|
|
|
|
|
|
sock_orphan(sk);
|
|
|
|
sco_sock_kill(sk);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sco_conn_ready(struct sco_conn *conn)
|
|
|
|
{
|
2010-12-01 22:58:22 +08:00
|
|
|
struct sock *parent;
|
|
|
|
struct sock *sk = conn->sk;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
BT_DBG("conn %p", conn);
|
|
|
|
|
2010-12-01 22:58:22 +08:00
|
|
|
if (sk) {
|
2005-04-17 06:20:36 +08:00
|
|
|
sco_sock_clear_timer(sk);
|
|
|
|
bh_lock_sock(sk);
|
|
|
|
sk->sk_state = BT_CONNECTED;
|
|
|
|
sk->sk_state_change(sk);
|
|
|
|
bh_unlock_sock(sk);
|
|
|
|
} else {
|
Bluetooth: Reduce critical section in sco_conn_ready
This patch reduces the critical section protected by sco_conn_lock in
sco_conn_ready function. The lock is acquired only when it is really
needed.
This patch fixes the following lockdep warning which is generated
when the host terminates a SCO connection.
Today, this warning is a false positive. There is no way those
two threads reported by lockdep are running at the same time since
hdev->workqueue (where rx_work is queued) is single-thread. However,
if somehow this behavior is changed in future, we will have a
potential deadlock.
======================================================
[ INFO: possible circular locking dependency detected ]
3.8.0-rc1+ #7 Not tainted
-------------------------------------------------------
kworker/u:1H/1018 is trying to acquire lock:
(&(&conn->lock)->rlock){+.+...}, at: [<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
but task is already holding lock:
(slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}, at: [<ffffffffa0033d5a>] sco_conn_del+0x8a/0xe0 [bluetooth]
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}:
[<ffffffff81083011>] lock_acquire+0xb1/0xe0
[<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
[<ffffffffa003436e>] sco_connect_cfm+0xbe/0x350 [bluetooth]
[<ffffffffa0015d6c>] hci_event_packet+0xd3c/0x29b0 [bluetooth]
[<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
[<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
[<ffffffff81050022>] worker_thread+0x2b2/0x3e0
[<ffffffff81056021>] kthread+0xd1/0xe0
[<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
-> #0 (&(&conn->lock)->rlock){+.+...}:
[<ffffffff81082215>] __lock_acquire+0x1465/0x1c70
[<ffffffff81083011>] lock_acquire+0xb1/0xe0
[<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
[<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffffa0033d6d>] sco_conn_del+0x9d/0xe0 [bluetooth]
[<ffffffffa0034653>] sco_disconn_cfm+0x53/0x60 [bluetooth]
[<ffffffffa000fef3>] hci_disconn_complete_evt.isra.54+0x363/0x3c0 [bluetooth]
[<ffffffffa00150f7>] hci_event_packet+0xc7/0x29b0 [bluetooth]
[<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
[<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
[<ffffffff81050022>] worker_thread+0x2b2/0x3e0
[<ffffffff81056021>] kthread+0xd1/0xe0
[<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(slock-AF_BLUETOOTH-BTPROTO_SCO);
lock(&(&conn->lock)->rlock);
lock(slock-AF_BLUETOOTH-BTPROTO_SCO);
lock(&(&conn->lock)->rlock);
*** DEADLOCK ***
4 locks held by kworker/u:1H/1018:
#0: (hdev->name#2){.+.+.+}, at: [<ffffffff8104d5f8>] process_one_work+0x258/0x4f0
#1: ((&hdev->rx_work)){+.+.+.}, at: [<ffffffff8104d5f8>] process_one_work+0x258/0x4f0
#2: (&hdev->lock){+.+.+.}, at: [<ffffffffa000fbe9>] hci_disconn_complete_evt.isra.54+0x59/0x3c0 [bluetooth]
#3: (slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}, at: [<ffffffffa0033d5a>] sco_conn_del+0x8a/0xe0 [bluetooth]
stack backtrace:
Pid: 1018, comm: kworker/u:1H Not tainted 3.8.0-rc1+ #7
Call Trace:
[<ffffffff813e92f9>] print_circular_bug+0x1fb/0x20c
[<ffffffff81082215>] __lock_acquire+0x1465/0x1c70
[<ffffffff81083011>] lock_acquire+0xb1/0xe0
[<ffffffffa0033ba6>] ? sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
[<ffffffffa0033ba6>] ? sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffffa0033d6d>] sco_conn_del+0x9d/0xe0 [bluetooth]
[<ffffffffa0034653>] sco_disconn_cfm+0x53/0x60 [bluetooth]
[<ffffffffa000fef3>] hci_disconn_complete_evt.isra.54+0x363/0x3c0 [bluetooth]
[<ffffffffa000fbd0>] ? hci_disconn_complete_evt.isra.54+0x40/0x3c0 [bluetooth]
[<ffffffffa00150f7>] hci_event_packet+0xc7/0x29b0 [bluetooth]
[<ffffffff81202e90>] ? __dynamic_pr_debug+0x80/0x90
[<ffffffff8133ff7d>] ? kfree_skb+0x2d/0x40
[<ffffffffa0021644>] ? hci_send_to_monitor+0x1a4/0x1c0 [bluetooth]
[<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
[<ffffffff8104d5f8>] ? process_one_work+0x258/0x4f0
[<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
[<ffffffff8104d5f8>] ? process_one_work+0x258/0x4f0
[<ffffffff8104fdc1>] ? worker_thread+0x51/0x3e0
[<ffffffffa0004450>] ? hci_tx_work+0x800/0x800 [bluetooth]
[<ffffffff81050022>] worker_thread+0x2b2/0x3e0
[<ffffffff8104fd70>] ? busy_worker_rebind_fn+0x100/0x100
[<ffffffff81056021>] kthread+0xd1/0xe0
[<ffffffff81055f50>] ? flush_kthread_worker+0xc0/0xc0
[<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
[<ffffffff81055f50>] ? flush_kthread_worker+0xc0/0xc0
Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
2013-01-30 06:59:56 +08:00
|
|
|
sco_conn_lock(conn);
|
|
|
|
|
2013-10-14 01:15:22 +08:00
|
|
|
parent = sco_get_sock_listen(&conn->hcon->src);
|
Bluetooth: Reduce critical section in sco_conn_ready
This patch reduces the critical section protected by sco_conn_lock in
sco_conn_ready function. The lock is acquired only when it is really
needed.
This patch fixes the following lockdep warning which is generated
when the host terminates a SCO connection.
Today, this warning is a false positive. There is no way those
two threads reported by lockdep are running at the same time since
hdev->workqueue (where rx_work is queued) is single-thread. However,
if somehow this behavior is changed in future, we will have a
potential deadlock.
======================================================
[ INFO: possible circular locking dependency detected ]
3.8.0-rc1+ #7 Not tainted
-------------------------------------------------------
kworker/u:1H/1018 is trying to acquire lock:
(&(&conn->lock)->rlock){+.+...}, at: [<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
but task is already holding lock:
(slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}, at: [<ffffffffa0033d5a>] sco_conn_del+0x8a/0xe0 [bluetooth]
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}:
[<ffffffff81083011>] lock_acquire+0xb1/0xe0
[<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
[<ffffffffa003436e>] sco_connect_cfm+0xbe/0x350 [bluetooth]
[<ffffffffa0015d6c>] hci_event_packet+0xd3c/0x29b0 [bluetooth]
[<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
[<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
[<ffffffff81050022>] worker_thread+0x2b2/0x3e0
[<ffffffff81056021>] kthread+0xd1/0xe0
[<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
-> #0 (&(&conn->lock)->rlock){+.+...}:
[<ffffffff81082215>] __lock_acquire+0x1465/0x1c70
[<ffffffff81083011>] lock_acquire+0xb1/0xe0
[<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
[<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffffa0033d6d>] sco_conn_del+0x9d/0xe0 [bluetooth]
[<ffffffffa0034653>] sco_disconn_cfm+0x53/0x60 [bluetooth]
[<ffffffffa000fef3>] hci_disconn_complete_evt.isra.54+0x363/0x3c0 [bluetooth]
[<ffffffffa00150f7>] hci_event_packet+0xc7/0x29b0 [bluetooth]
[<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
[<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
[<ffffffff81050022>] worker_thread+0x2b2/0x3e0
[<ffffffff81056021>] kthread+0xd1/0xe0
[<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(slock-AF_BLUETOOTH-BTPROTO_SCO);
lock(&(&conn->lock)->rlock);
lock(slock-AF_BLUETOOTH-BTPROTO_SCO);
lock(&(&conn->lock)->rlock);
*** DEADLOCK ***
4 locks held by kworker/u:1H/1018:
#0: (hdev->name#2){.+.+.+}, at: [<ffffffff8104d5f8>] process_one_work+0x258/0x4f0
#1: ((&hdev->rx_work)){+.+.+.}, at: [<ffffffff8104d5f8>] process_one_work+0x258/0x4f0
#2: (&hdev->lock){+.+.+.}, at: [<ffffffffa000fbe9>] hci_disconn_complete_evt.isra.54+0x59/0x3c0 [bluetooth]
#3: (slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}, at: [<ffffffffa0033d5a>] sco_conn_del+0x8a/0xe0 [bluetooth]
stack backtrace:
Pid: 1018, comm: kworker/u:1H Not tainted 3.8.0-rc1+ #7
Call Trace:
[<ffffffff813e92f9>] print_circular_bug+0x1fb/0x20c
[<ffffffff81082215>] __lock_acquire+0x1465/0x1c70
[<ffffffff81083011>] lock_acquire+0xb1/0xe0
[<ffffffffa0033ba6>] ? sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
[<ffffffffa0033ba6>] ? sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffffa0033d6d>] sco_conn_del+0x9d/0xe0 [bluetooth]
[<ffffffffa0034653>] sco_disconn_cfm+0x53/0x60 [bluetooth]
[<ffffffffa000fef3>] hci_disconn_complete_evt.isra.54+0x363/0x3c0 [bluetooth]
[<ffffffffa000fbd0>] ? hci_disconn_complete_evt.isra.54+0x40/0x3c0 [bluetooth]
[<ffffffffa00150f7>] hci_event_packet+0xc7/0x29b0 [bluetooth]
[<ffffffff81202e90>] ? __dynamic_pr_debug+0x80/0x90
[<ffffffff8133ff7d>] ? kfree_skb+0x2d/0x40
[<ffffffffa0021644>] ? hci_send_to_monitor+0x1a4/0x1c0 [bluetooth]
[<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
[<ffffffff8104d5f8>] ? process_one_work+0x258/0x4f0
[<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
[<ffffffff8104d5f8>] ? process_one_work+0x258/0x4f0
[<ffffffff8104fdc1>] ? worker_thread+0x51/0x3e0
[<ffffffffa0004450>] ? hci_tx_work+0x800/0x800 [bluetooth]
[<ffffffff81050022>] worker_thread+0x2b2/0x3e0
[<ffffffff8104fd70>] ? busy_worker_rebind_fn+0x100/0x100
[<ffffffff81056021>] kthread+0xd1/0xe0
[<ffffffff81055f50>] ? flush_kthread_worker+0xc0/0xc0
[<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
[<ffffffff81055f50>] ? flush_kthread_worker+0xc0/0xc0
Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
2013-01-30 06:59:56 +08:00
|
|
|
if (!parent) {
|
|
|
|
sco_conn_unlock(conn);
|
|
|
|
return;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
bh_lock_sock(parent);
|
|
|
|
|
2010-05-02 03:15:35 +08:00
|
|
|
sk = sco_sock_alloc(sock_net(parent), NULL,
|
2012-05-17 11:36:21 +08:00
|
|
|
BTPROTO_SCO, GFP_ATOMIC);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (!sk) {
|
|
|
|
bh_unlock_sock(parent);
|
Bluetooth: Reduce critical section in sco_conn_ready
This patch reduces the critical section protected by sco_conn_lock in
sco_conn_ready function. The lock is acquired only when it is really
needed.
This patch fixes the following lockdep warning which is generated
when the host terminates a SCO connection.
Today, this warning is a false positive. There is no way those
two threads reported by lockdep are running at the same time since
hdev->workqueue (where rx_work is queued) is single-thread. However,
if somehow this behavior is changed in future, we will have a
potential deadlock.
======================================================
[ INFO: possible circular locking dependency detected ]
3.8.0-rc1+ #7 Not tainted
-------------------------------------------------------
kworker/u:1H/1018 is trying to acquire lock:
(&(&conn->lock)->rlock){+.+...}, at: [<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
but task is already holding lock:
(slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}, at: [<ffffffffa0033d5a>] sco_conn_del+0x8a/0xe0 [bluetooth]
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}:
[<ffffffff81083011>] lock_acquire+0xb1/0xe0
[<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
[<ffffffffa003436e>] sco_connect_cfm+0xbe/0x350 [bluetooth]
[<ffffffffa0015d6c>] hci_event_packet+0xd3c/0x29b0 [bluetooth]
[<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
[<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
[<ffffffff81050022>] worker_thread+0x2b2/0x3e0
[<ffffffff81056021>] kthread+0xd1/0xe0
[<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
-> #0 (&(&conn->lock)->rlock){+.+...}:
[<ffffffff81082215>] __lock_acquire+0x1465/0x1c70
[<ffffffff81083011>] lock_acquire+0xb1/0xe0
[<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
[<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffffa0033d6d>] sco_conn_del+0x9d/0xe0 [bluetooth]
[<ffffffffa0034653>] sco_disconn_cfm+0x53/0x60 [bluetooth]
[<ffffffffa000fef3>] hci_disconn_complete_evt.isra.54+0x363/0x3c0 [bluetooth]
[<ffffffffa00150f7>] hci_event_packet+0xc7/0x29b0 [bluetooth]
[<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
[<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
[<ffffffff81050022>] worker_thread+0x2b2/0x3e0
[<ffffffff81056021>] kthread+0xd1/0xe0
[<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(slock-AF_BLUETOOTH-BTPROTO_SCO);
lock(&(&conn->lock)->rlock);
lock(slock-AF_BLUETOOTH-BTPROTO_SCO);
lock(&(&conn->lock)->rlock);
*** DEADLOCK ***
4 locks held by kworker/u:1H/1018:
#0: (hdev->name#2){.+.+.+}, at: [<ffffffff8104d5f8>] process_one_work+0x258/0x4f0
#1: ((&hdev->rx_work)){+.+.+.}, at: [<ffffffff8104d5f8>] process_one_work+0x258/0x4f0
#2: (&hdev->lock){+.+.+.}, at: [<ffffffffa000fbe9>] hci_disconn_complete_evt.isra.54+0x59/0x3c0 [bluetooth]
#3: (slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}, at: [<ffffffffa0033d5a>] sco_conn_del+0x8a/0xe0 [bluetooth]
stack backtrace:
Pid: 1018, comm: kworker/u:1H Not tainted 3.8.0-rc1+ #7
Call Trace:
[<ffffffff813e92f9>] print_circular_bug+0x1fb/0x20c
[<ffffffff81082215>] __lock_acquire+0x1465/0x1c70
[<ffffffff81083011>] lock_acquire+0xb1/0xe0
[<ffffffffa0033ba6>] ? sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
[<ffffffffa0033ba6>] ? sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffffa0033d6d>] sco_conn_del+0x9d/0xe0 [bluetooth]
[<ffffffffa0034653>] sco_disconn_cfm+0x53/0x60 [bluetooth]
[<ffffffffa000fef3>] hci_disconn_complete_evt.isra.54+0x363/0x3c0 [bluetooth]
[<ffffffffa000fbd0>] ? hci_disconn_complete_evt.isra.54+0x40/0x3c0 [bluetooth]
[<ffffffffa00150f7>] hci_event_packet+0xc7/0x29b0 [bluetooth]
[<ffffffff81202e90>] ? __dynamic_pr_debug+0x80/0x90
[<ffffffff8133ff7d>] ? kfree_skb+0x2d/0x40
[<ffffffffa0021644>] ? hci_send_to_monitor+0x1a4/0x1c0 [bluetooth]
[<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
[<ffffffff8104d5f8>] ? process_one_work+0x258/0x4f0
[<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
[<ffffffff8104d5f8>] ? process_one_work+0x258/0x4f0
[<ffffffff8104fdc1>] ? worker_thread+0x51/0x3e0
[<ffffffffa0004450>] ? hci_tx_work+0x800/0x800 [bluetooth]
[<ffffffff81050022>] worker_thread+0x2b2/0x3e0
[<ffffffff8104fd70>] ? busy_worker_rebind_fn+0x100/0x100
[<ffffffff81056021>] kthread+0xd1/0xe0
[<ffffffff81055f50>] ? flush_kthread_worker+0xc0/0xc0
[<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
[<ffffffff81055f50>] ? flush_kthread_worker+0xc0/0xc0
Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
2013-01-30 06:59:56 +08:00
|
|
|
sco_conn_unlock(conn);
|
|
|
|
return;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
sco_sock_init(sk, parent);
|
|
|
|
|
2013-10-14 01:34:01 +08:00
|
|
|
bacpy(&sco_pi(sk)->src, &conn->hcon->src);
|
|
|
|
bacpy(&sco_pi(sk)->dst, &conn->hcon->dst);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
hci_conn_hold(conn->hcon);
|
|
|
|
__sco_chan_add(conn, sk, parent);
|
|
|
|
|
2012-11-21 17:51:12 +08:00
|
|
|
if (test_bit(BT_SK_DEFER_SETUP, &bt_sk(parent)->flags))
|
|
|
|
sk->sk_state = BT_CONNECT2;
|
|
|
|
else
|
|
|
|
sk->sk_state = BT_CONNECTED;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
/* Wake up parent */
|
2014-04-12 04:15:36 +08:00
|
|
|
parent->sk_data_ready(parent);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
bh_unlock_sock(parent);
|
|
|
|
|
Bluetooth: Reduce critical section in sco_conn_ready
This patch reduces the critical section protected by sco_conn_lock in
sco_conn_ready function. The lock is acquired only when it is really
needed.
This patch fixes the following lockdep warning which is generated
when the host terminates a SCO connection.
Today, this warning is a false positive. There is no way those
two threads reported by lockdep are running at the same time since
hdev->workqueue (where rx_work is queued) is single-thread. However,
if somehow this behavior is changed in future, we will have a
potential deadlock.
======================================================
[ INFO: possible circular locking dependency detected ]
3.8.0-rc1+ #7 Not tainted
-------------------------------------------------------
kworker/u:1H/1018 is trying to acquire lock:
(&(&conn->lock)->rlock){+.+...}, at: [<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
but task is already holding lock:
(slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}, at: [<ffffffffa0033d5a>] sco_conn_del+0x8a/0xe0 [bluetooth]
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}:
[<ffffffff81083011>] lock_acquire+0xb1/0xe0
[<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
[<ffffffffa003436e>] sco_connect_cfm+0xbe/0x350 [bluetooth]
[<ffffffffa0015d6c>] hci_event_packet+0xd3c/0x29b0 [bluetooth]
[<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
[<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
[<ffffffff81050022>] worker_thread+0x2b2/0x3e0
[<ffffffff81056021>] kthread+0xd1/0xe0
[<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
-> #0 (&(&conn->lock)->rlock){+.+...}:
[<ffffffff81082215>] __lock_acquire+0x1465/0x1c70
[<ffffffff81083011>] lock_acquire+0xb1/0xe0
[<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
[<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffffa0033d6d>] sco_conn_del+0x9d/0xe0 [bluetooth]
[<ffffffffa0034653>] sco_disconn_cfm+0x53/0x60 [bluetooth]
[<ffffffffa000fef3>] hci_disconn_complete_evt.isra.54+0x363/0x3c0 [bluetooth]
[<ffffffffa00150f7>] hci_event_packet+0xc7/0x29b0 [bluetooth]
[<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
[<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
[<ffffffff81050022>] worker_thread+0x2b2/0x3e0
[<ffffffff81056021>] kthread+0xd1/0xe0
[<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(slock-AF_BLUETOOTH-BTPROTO_SCO);
lock(&(&conn->lock)->rlock);
lock(slock-AF_BLUETOOTH-BTPROTO_SCO);
lock(&(&conn->lock)->rlock);
*** DEADLOCK ***
4 locks held by kworker/u:1H/1018:
#0: (hdev->name#2){.+.+.+}, at: [<ffffffff8104d5f8>] process_one_work+0x258/0x4f0
#1: ((&hdev->rx_work)){+.+.+.}, at: [<ffffffff8104d5f8>] process_one_work+0x258/0x4f0
#2: (&hdev->lock){+.+.+.}, at: [<ffffffffa000fbe9>] hci_disconn_complete_evt.isra.54+0x59/0x3c0 [bluetooth]
#3: (slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}, at: [<ffffffffa0033d5a>] sco_conn_del+0x8a/0xe0 [bluetooth]
stack backtrace:
Pid: 1018, comm: kworker/u:1H Not tainted 3.8.0-rc1+ #7
Call Trace:
[<ffffffff813e92f9>] print_circular_bug+0x1fb/0x20c
[<ffffffff81082215>] __lock_acquire+0x1465/0x1c70
[<ffffffff81083011>] lock_acquire+0xb1/0xe0
[<ffffffffa0033ba6>] ? sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
[<ffffffffa0033ba6>] ? sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
[<ffffffffa0033d6d>] sco_conn_del+0x9d/0xe0 [bluetooth]
[<ffffffffa0034653>] sco_disconn_cfm+0x53/0x60 [bluetooth]
[<ffffffffa000fef3>] hci_disconn_complete_evt.isra.54+0x363/0x3c0 [bluetooth]
[<ffffffffa000fbd0>] ? hci_disconn_complete_evt.isra.54+0x40/0x3c0 [bluetooth]
[<ffffffffa00150f7>] hci_event_packet+0xc7/0x29b0 [bluetooth]
[<ffffffff81202e90>] ? __dynamic_pr_debug+0x80/0x90
[<ffffffff8133ff7d>] ? kfree_skb+0x2d/0x40
[<ffffffffa0021644>] ? hci_send_to_monitor+0x1a4/0x1c0 [bluetooth]
[<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
[<ffffffff8104d5f8>] ? process_one_work+0x258/0x4f0
[<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
[<ffffffff8104d5f8>] ? process_one_work+0x258/0x4f0
[<ffffffff8104fdc1>] ? worker_thread+0x51/0x3e0
[<ffffffffa0004450>] ? hci_tx_work+0x800/0x800 [bluetooth]
[<ffffffff81050022>] worker_thread+0x2b2/0x3e0
[<ffffffff8104fd70>] ? busy_worker_rebind_fn+0x100/0x100
[<ffffffff81056021>] kthread+0xd1/0xe0
[<ffffffff81055f50>] ? flush_kthread_worker+0xc0/0xc0
[<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
[<ffffffff81055f50>] ? flush_kthread_worker+0xc0/0xc0
Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
2013-01-30 06:59:56 +08:00
|
|
|
sco_conn_unlock(conn);
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* ----- SCO interface with lower layer (HCI) ----- */
|
2012-11-21 17:51:12 +08:00
|
|
|
int sco_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 *flags)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2012-05-23 15:04:19 +08:00
|
|
|
struct sock *sk;
|
2009-01-16 04:57:02 +08:00
|
|
|
int lm = 0;
|
|
|
|
|
2012-09-25 17:49:43 +08:00
|
|
|
BT_DBG("hdev %s, bdaddr %pMR", hdev->name, bdaddr);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-01-16 04:57:02 +08:00
|
|
|
/* Find listening sockets */
|
|
|
|
read_lock(&sco_sk_list.lock);
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:06:00 +08:00
|
|
|
sk_for_each(sk, &sco_sk_list.head) {
|
2009-01-16 04:57:02 +08:00
|
|
|
if (sk->sk_state != BT_LISTEN)
|
|
|
|
continue;
|
|
|
|
|
2013-10-14 01:34:01 +08:00
|
|
|
if (!bacmp(&sco_pi(sk)->src, &hdev->bdaddr) ||
|
|
|
|
!bacmp(&sco_pi(sk)->src, BDADDR_ANY)) {
|
2009-01-16 04:57:02 +08:00
|
|
|
lm |= HCI_LM_ACCEPT;
|
2012-11-21 17:51:12 +08:00
|
|
|
|
|
|
|
if (test_bit(BT_SK_DEFER_SETUP, &bt_sk(sk)->flags))
|
|
|
|
*flags |= HCI_PROTO_DEFER;
|
2009-01-16 04:57:02 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
read_unlock(&sco_sk_list.lock);
|
|
|
|
|
|
|
|
return lm;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2015-02-18 20:53:57 +08:00
|
|
|
static void sco_connect_cfm(struct hci_conn *hcon, __u8 status)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2015-02-18 20:53:57 +08:00
|
|
|
if (hcon->type != SCO_LINK && hcon->type != ESCO_LINK)
|
|
|
|
return;
|
|
|
|
|
2012-09-25 17:49:43 +08:00
|
|
|
BT_DBG("hcon %p bdaddr %pMR status %d", hcon, &hcon->dst, status);
|
2015-02-18 20:53:57 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
if (!status) {
|
|
|
|
struct sco_conn *conn;
|
|
|
|
|
2012-04-19 22:12:28 +08:00
|
|
|
conn = sco_conn_add(hcon);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (conn)
|
|
|
|
sco_conn_ready(conn);
|
2007-02-09 22:24:33 +08:00
|
|
|
} else
|
2011-06-30 09:18:29 +08:00
|
|
|
sco_conn_del(hcon, bt_to_errno(status));
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2015-02-18 20:53:58 +08:00
|
|
|
static void sco_disconn_cfm(struct hci_conn *hcon, __u8 reason)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2015-02-18 20:53:58 +08:00
|
|
|
if (hcon->type != SCO_LINK && hcon->type != ESCO_LINK)
|
|
|
|
return;
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
BT_DBG("hcon %p reason %d", hcon, reason);
|
|
|
|
|
2011-06-30 09:18:29 +08:00
|
|
|
sco_conn_del(hcon, bt_to_errno(reason));
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2011-12-21 20:11:33 +08:00
|
|
|
int sco_recv_scodata(struct hci_conn *hcon, struct sk_buff *skb)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct sco_conn *conn = hcon->sco_data;
|
|
|
|
|
|
|
|
if (!conn)
|
|
|
|
goto drop;
|
|
|
|
|
|
|
|
BT_DBG("conn %p len %d", conn, skb->len);
|
|
|
|
|
|
|
|
if (skb->len) {
|
|
|
|
sco_recv_frame(conn, skb);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
drop:
|
2007-02-09 22:24:33 +08:00
|
|
|
kfree_skb(skb);
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-02-18 20:53:57 +08:00
|
|
|
static struct hci_cb sco_cb = {
|
|
|
|
.name = "SCO",
|
|
|
|
.connect_cfm = sco_connect_cfm,
|
2015-02-18 20:53:58 +08:00
|
|
|
.disconn_cfm = sco_disconn_cfm,
|
2015-02-18 20:53:57 +08:00
|
|
|
};
|
|
|
|
|
2010-03-21 12:27:45 +08:00
|
|
|
static int sco_debugfs_show(struct seq_file *f, void *p)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct sock *sk;
|
|
|
|
|
2011-12-28 01:28:46 +08:00
|
|
|
read_lock(&sco_sk_list.lock);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:06:00 +08:00
|
|
|
sk_for_each(sk, &sco_sk_list.head) {
|
2013-10-14 01:34:01 +08:00
|
|
|
seq_printf(f, "%pMR %pMR %d\n", &sco_pi(sk)->src,
|
|
|
|
&sco_pi(sk)->dst, sk->sk_state);
|
2005-11-09 01:57:38 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2011-12-28 01:28:46 +08:00
|
|
|
read_unlock(&sco_sk_list.lock);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-03-21 12:27:45 +08:00
|
|
|
return 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2010-03-21 12:27:45 +08:00
|
|
|
static int sco_debugfs_open(struct inode *inode, struct file *file)
|
|
|
|
{
|
|
|
|
return single_open(file, sco_debugfs_show, inode->i_private);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct file_operations sco_debugfs_fops = {
|
|
|
|
.open = sco_debugfs_open,
|
|
|
|
.read = seq_read,
|
|
|
|
.llseek = seq_lseek,
|
|
|
|
.release = single_release,
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct dentry *sco_debugfs;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2005-12-23 04:49:22 +08:00
|
|
|
static const struct proto_ops sco_sock_ops = {
|
2005-04-17 06:20:36 +08:00
|
|
|
.family = PF_BLUETOOTH,
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.release = sco_sock_release,
|
|
|
|
.bind = sco_sock_bind,
|
|
|
|
.connect = sco_sock_connect,
|
|
|
|
.listen = sco_sock_listen,
|
|
|
|
.accept = sco_sock_accept,
|
|
|
|
.getname = sco_sock_getname,
|
|
|
|
.sendmsg = sco_sock_sendmsg,
|
2012-11-21 17:51:12 +08:00
|
|
|
.recvmsg = sco_sock_recvmsg,
|
2005-04-17 06:20:36 +08:00
|
|
|
.poll = bt_sock_poll,
|
2008-07-15 02:13:50 +08:00
|
|
|
.ioctl = bt_sock_ioctl,
|
2005-04-17 06:20:36 +08:00
|
|
|
.mmap = sock_no_mmap,
|
|
|
|
.socketpair = sock_no_socketpair,
|
2009-06-16 06:01:49 +08:00
|
|
|
.shutdown = sco_sock_shutdown,
|
2005-04-17 06:20:36 +08:00
|
|
|
.setsockopt = sco_sock_setsockopt,
|
|
|
|
.getsockopt = sco_sock_getsockopt
|
|
|
|
};
|
|
|
|
|
2009-10-05 13:58:39 +08:00
|
|
|
static const struct net_proto_family sco_sock_family_ops = {
|
2005-04-17 06:20:36 +08:00
|
|
|
.family = PF_BLUETOOTH,
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.create = sco_sock_create,
|
|
|
|
};
|
|
|
|
|
2011-02-08 06:08:52 +08:00
|
|
|
int __init sco_init(void)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
int err;
|
|
|
|
|
2015-01-12 07:21:06 +08:00
|
|
|
BUILD_BUG_ON(sizeof(struct sockaddr_sco) > sizeof(struct sockaddr));
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
err = proto_register(&sco_proto, 0);
|
|
|
|
if (err < 0)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
err = bt_sock_register(BTPROTO_SCO, &sco_sock_family_ops);
|
|
|
|
if (err < 0) {
|
|
|
|
BT_ERR("SCO socket registration failed");
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
2013-04-05 07:14:33 +08:00
|
|
|
err = bt_procfs_init(&init_net, "sco", &sco_sk_list, NULL);
|
2012-07-26 00:30:12 +08:00
|
|
|
if (err < 0) {
|
|
|
|
BT_ERR("Failed to create SCO proc file");
|
|
|
|
bt_sock_unregister(BTPROTO_SCO);
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
BT_INFO("SCO socket layer initialized");
|
|
|
|
|
2015-02-18 20:53:57 +08:00
|
|
|
hci_register_cb(&sco_cb);
|
|
|
|
|
2013-10-18 08:24:16 +08:00
|
|
|
if (IS_ERR_OR_NULL(bt_debugfs))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
sco_debugfs = debugfs_create_file("sco", 0444, bt_debugfs,
|
|
|
|
NULL, &sco_debugfs_fops);
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
error:
|
|
|
|
proto_unregister(&sco_proto);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2015-03-08 03:52:28 +08:00
|
|
|
void sco_exit(void)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2012-07-26 00:30:12 +08:00
|
|
|
bt_procfs_cleanup(&init_net, "sco");
|
|
|
|
|
2010-03-21 12:27:45 +08:00
|
|
|
debugfs_remove(sco_debugfs);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2015-02-18 20:53:57 +08:00
|
|
|
hci_unregister_cb(&sco_cb);
|
|
|
|
|
2013-02-25 02:36:51 +08:00
|
|
|
bt_sock_unregister(BTPROTO_SCO);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
proto_unregister(&sco_proto);
|
|
|
|
}
|
|
|
|
|
2008-07-15 02:13:53 +08:00
|
|
|
module_param(disable_esco, bool, 0644);
|
|
|
|
MODULE_PARM_DESC(disable_esco, "Disable eSCO connection creation");
|