License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 22:07:57 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2006-03-31 18:30:42 +08:00
|
|
|
/*
|
|
|
|
* High-level sync()-related operations
|
|
|
|
*/
|
|
|
|
|
2021-10-19 14:25:25 +08:00
|
|
|
#include <linux/blkdev.h>
|
2006-03-31 18:30:42 +08:00
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/file.h>
|
|
|
|
#include <linux/fs.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 16:04:11 +08:00
|
|
|
#include <linux/slab.h>
|
2011-11-17 12:57:37 +08:00
|
|
|
#include <linux/export.h>
|
2011-03-11 03:31:30 +08:00
|
|
|
#include <linux/namei.h>
|
2006-10-19 01:55:46 +08:00
|
|
|
#include <linux/sched.h>
|
2006-03-31 18:30:42 +08:00
|
|
|
#include <linux/writeback.h>
|
|
|
|
#include <linux/syscalls.h>
|
|
|
|
#include <linux/linkage.h>
|
|
|
|
#include <linux/pagemap.h>
|
2006-08-30 02:05:54 +08:00
|
|
|
#include <linux/quotaops.h>
|
2010-04-25 14:54:42 +08:00
|
|
|
#include <linux/backing-dev.h>
|
2009-04-27 22:43:48 +08:00
|
|
|
#include "internal.h"
|
2006-03-31 18:30:42 +08:00
|
|
|
|
|
|
|
#define VALID_FLAGS (SYNC_FILE_RANGE_WAIT_BEFORE|SYNC_FILE_RANGE_WRITE| \
|
|
|
|
SYNC_FILE_RANGE_WAIT_AFTER)
|
|
|
|
|
2009-04-27 22:43:52 +08:00
|
|
|
/*
|
|
|
|
* Write out and wait upon all dirty data associated with this
|
|
|
|
* superblock. Filesystem data as well as the underlying block
|
|
|
|
* device. Takes the superblock lock.
|
|
|
|
*/
|
2009-04-27 22:43:53 +08:00
|
|
|
int sync_filesystem(struct super_block *sb)
|
2009-04-27 22:43:52 +08:00
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
2009-05-05 21:41:25 +08:00
|
|
|
/*
|
|
|
|
* We need to be protected against the filesystem going from
|
|
|
|
* r/o to r/w or vice versa.
|
|
|
|
*/
|
|
|
|
WARN_ON(!rwsem_is_locked(&sb->s_umount));
|
|
|
|
|
|
|
|
/*
|
|
|
|
* No point in syncing out anything if the filesystem is read-only.
|
|
|
|
*/
|
2017-07-17 15:45:34 +08:00
|
|
|
if (sb_rdonly(sb))
|
2009-05-05 21:41:25 +08:00
|
|
|
return 0;
|
|
|
|
|
2021-10-19 14:25:24 +08:00
|
|
|
/*
|
|
|
|
* Do the filesystem syncing work. For simple filesystems
|
|
|
|
* writeback_inodes_sb(sb) just dirties buffers with inodes so we have
|
2021-10-19 14:25:25 +08:00
|
|
|
* to submit I/O for these buffers via sync_blockdev(). This also
|
2021-10-19 14:25:24 +08:00
|
|
|
* speeds up the wait == 1 case since in that case write_inode()
|
|
|
|
* methods call sync_dirty_buffer() and thus effectively write one block
|
|
|
|
* at a time.
|
|
|
|
*/
|
|
|
|
writeback_inodes_sb(sb, WB_REASON_SYNC);
|
|
|
|
if (sb->s_op->sync_fs)
|
|
|
|
sb->s_op->sync_fs(sb, 0);
|
2021-10-19 14:25:25 +08:00
|
|
|
ret = sync_blockdev_nowait(sb->s_bdev);
|
2009-04-27 22:43:52 +08:00
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
2021-10-19 14:25:24 +08:00
|
|
|
|
|
|
|
sync_inodes_sb(sb);
|
|
|
|
if (sb->s_op->sync_fs)
|
|
|
|
sb->s_op->sync_fs(sb, 1);
|
2021-10-19 14:25:25 +08:00
|
|
|
return sync_blockdev(sb->s_bdev);
|
2009-04-27 22:43:52 +08:00
|
|
|
}
|
2014-08-21 18:09:27 +08:00
|
|
|
EXPORT_SYMBOL(sync_filesystem);
|
2009-04-27 22:43:52 +08:00
|
|
|
|
2012-07-03 22:45:30 +08:00
|
|
|
static void sync_inodes_one_sb(struct super_block *sb, void *arg)
|
2010-03-23 18:06:58 +08:00
|
|
|
{
|
2017-07-17 15:45:34 +08:00
|
|
|
if (!sb_rdonly(sb))
|
2014-02-21 18:19:04 +08:00
|
|
|
sync_inodes_sb(sb);
|
2010-03-23 18:06:58 +08:00
|
|
|
}
|
2012-07-03 22:45:30 +08:00
|
|
|
|
|
|
|
static void sync_fs_one_sb(struct super_block *sb, void *arg)
|
|
|
|
{
|
2020-04-09 16:29:47 +08:00
|
|
|
if (!sb_rdonly(sb) && !(sb->s_iflags & SB_I_SKIP_SYNC) &&
|
|
|
|
sb->s_op->sync_fs)
|
2012-07-03 22:45:30 +08:00
|
|
|
sb->s_op->sync_fs(sb, *(int *)arg);
|
|
|
|
}
|
|
|
|
|
2009-07-06 03:08:08 +08:00
|
|
|
/*
|
2012-07-03 22:45:34 +08:00
|
|
|
* Sync everything. We start by waking flusher threads so that most of
|
|
|
|
* writeback runs on all devices in parallel. Then we sync all inodes reliably
|
|
|
|
* which effectively also waits for all flusher threads to finish doing
|
|
|
|
* writeback. At this point all data is on disk so metadata should be stable
|
|
|
|
* and we tell filesystems to sync their metadata via ->sync_fs() calls.
|
|
|
|
* Finally, we writeout all block devices because some filesystems (e.g. ext2)
|
|
|
|
* just write metadata (such as inodes or bitmaps) to block device page cache
|
|
|
|
* and do not sync it on their own in ->sync_fs().
|
2009-07-06 03:08:08 +08:00
|
|
|
*/
|
2018-03-15 05:35:11 +08:00
|
|
|
void ksys_sync(void)
|
2006-08-30 02:05:54 +08:00
|
|
|
{
|
2012-07-03 22:45:30 +08:00
|
|
|
int nowait = 0, wait = 1;
|
|
|
|
|
2017-09-20 22:58:25 +08:00
|
|
|
wakeup_flusher_threads(WB_REASON_SYNC);
|
2014-02-21 18:19:04 +08:00
|
|
|
iterate_supers(sync_inodes_one_sb, NULL);
|
2012-07-03 22:45:34 +08:00
|
|
|
iterate_supers(sync_fs_one_sb, &nowait);
|
2012-07-03 22:45:30 +08:00
|
|
|
iterate_supers(sync_fs_one_sb, &wait);
|
2021-10-19 14:25:30 +08:00
|
|
|
sync_bdevs(false);
|
|
|
|
sync_bdevs(true);
|
2006-08-30 02:05:54 +08:00
|
|
|
if (unlikely(laptop_mode))
|
|
|
|
laptop_sync_completion();
|
2018-03-15 05:35:11 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
SYSCALL_DEFINE0(sync)
|
|
|
|
{
|
|
|
|
ksys_sync();
|
2006-08-30 02:05:54 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-03-17 16:38:40 +08:00
|
|
|
static void do_sync_work(struct work_struct *work)
|
|
|
|
{
|
2012-07-03 22:45:30 +08:00
|
|
|
int nowait = 0;
|
|
|
|
|
2009-04-27 22:43:51 +08:00
|
|
|
/*
|
|
|
|
* Sync twice to reduce the possibility we skipped some inodes / pages
|
|
|
|
* because they were temporarily locked
|
|
|
|
*/
|
2012-07-03 22:45:30 +08:00
|
|
|
iterate_supers(sync_inodes_one_sb, &nowait);
|
|
|
|
iterate_supers(sync_fs_one_sb, &nowait);
|
2021-10-19 14:25:30 +08:00
|
|
|
sync_bdevs(false);
|
2012-07-03 22:45:30 +08:00
|
|
|
iterate_supers(sync_inodes_one_sb, &nowait);
|
|
|
|
iterate_supers(sync_fs_one_sb, &nowait);
|
2021-10-19 14:25:30 +08:00
|
|
|
sync_bdevs(false);
|
2009-04-27 22:43:51 +08:00
|
|
|
printk("Emergency Sync complete\n");
|
2009-03-17 16:38:40 +08:00
|
|
|
kfree(work);
|
|
|
|
}
|
|
|
|
|
2006-08-30 02:05:54 +08:00
|
|
|
void emergency_sync(void)
|
|
|
|
{
|
2009-03-17 16:38:40 +08:00
|
|
|
struct work_struct *work;
|
|
|
|
|
|
|
|
work = kmalloc(sizeof(*work), GFP_ATOMIC);
|
|
|
|
if (work) {
|
|
|
|
INIT_WORK(work, do_sync_work);
|
|
|
|
schedule_work(work);
|
|
|
|
}
|
2006-08-30 02:05:54 +08:00
|
|
|
}
|
|
|
|
|
2011-03-11 03:31:30 +08:00
|
|
|
/*
|
|
|
|
* sync a single super
|
|
|
|
*/
|
|
|
|
SYSCALL_DEFINE1(syncfs, int, fd)
|
|
|
|
{
|
2012-08-29 00:52:22 +08:00
|
|
|
struct fd f = fdget(fd);
|
2011-03-11 03:31:30 +08:00
|
|
|
struct super_block *sb;
|
vfs: track per-sb writeback errors and report them to syncfs
Patch series "vfs: have syncfs() return error when there are writeback
errors", v6.
Currently, syncfs does not return errors when one of the inodes fails to
be written back. It will return errors based on the legacy AS_EIO and
AS_ENOSPC flags when syncing out the block device fails, but that's not
particularly helpful for filesystems that aren't backed by a blockdev.
It's also possible for a stray sync to lose those errors.
The basic idea in this set is to track writeback errors at the
superblock level, so that we can quickly and easily check whether
something bad happened without having to fsync each file individually.
syncfs is then changed to reliably report writeback errors after they
occur, much in the same fashion as fsync does now.
This patch (of 2):
Usually we suggest that applications call fsync when they want to ensure
that all data written to the file has made it to the backing store, but
that can be inefficient when there are a lot of open files.
Calling syncfs on the filesystem can be more efficient in some
situations, but the error reporting doesn't currently work the way most
people expect. If a single inode on a filesystem reports a writeback
error, syncfs won't necessarily return an error. syncfs only returns an
error if __sync_blockdev fails, and on some filesystems that's a no-op.
It would be better if syncfs reported an error if there were any
writeback failures. Then applications could call syncfs to see if there
are any errors on any open files, and could then call fsync on all of
the other descriptors to figure out which one failed.
This patch adds a new errseq_t to struct super_block, and has
mapping_set_error also record writeback errors there.
To report those errors, we also need to keep an errseq_t in struct file
to act as a cursor. This patch adds a dedicated field for that purpose,
which slots nicely into 4 bytes of padding at the end of struct file on
x86_64.
An earlier version of this patch used an O_PATH file descriptor to cue
the kernel that the open file should track the superblock error and not
the inode's writeback error.
I think that API is just too weird though. This is simpler and should
make syncfs error reporting "just work" even if someone is multiplexing
fsync and syncfs on the same fds.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>
Cc: David Howells <dhowells@redhat.com>
Link: http://lkml.kernel.org/r/20200428135155.19223-1-jlayton@kernel.org
Link: http://lkml.kernel.org/r/20200428135155.19223-2-jlayton@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2020-06-02 12:45:36 +08:00
|
|
|
int ret, ret2;
|
2011-03-11 03:31:30 +08:00
|
|
|
|
2012-08-29 00:52:22 +08:00
|
|
|
if (!f.file)
|
2011-03-11 03:31:30 +08:00
|
|
|
return -EBADF;
|
2014-10-31 13:22:04 +08:00
|
|
|
sb = f.file->f_path.dentry->d_sb;
|
2011-03-11 03:31:30 +08:00
|
|
|
|
|
|
|
down_read(&sb->s_umount);
|
|
|
|
ret = sync_filesystem(sb);
|
|
|
|
up_read(&sb->s_umount);
|
|
|
|
|
vfs: track per-sb writeback errors and report them to syncfs
Patch series "vfs: have syncfs() return error when there are writeback
errors", v6.
Currently, syncfs does not return errors when one of the inodes fails to
be written back. It will return errors based on the legacy AS_EIO and
AS_ENOSPC flags when syncing out the block device fails, but that's not
particularly helpful for filesystems that aren't backed by a blockdev.
It's also possible for a stray sync to lose those errors.
The basic idea in this set is to track writeback errors at the
superblock level, so that we can quickly and easily check whether
something bad happened without having to fsync each file individually.
syncfs is then changed to reliably report writeback errors after they
occur, much in the same fashion as fsync does now.
This patch (of 2):
Usually we suggest that applications call fsync when they want to ensure
that all data written to the file has made it to the backing store, but
that can be inefficient when there are a lot of open files.
Calling syncfs on the filesystem can be more efficient in some
situations, but the error reporting doesn't currently work the way most
people expect. If a single inode on a filesystem reports a writeback
error, syncfs won't necessarily return an error. syncfs only returns an
error if __sync_blockdev fails, and on some filesystems that's a no-op.
It would be better if syncfs reported an error if there were any
writeback failures. Then applications could call syncfs to see if there
are any errors on any open files, and could then call fsync on all of
the other descriptors to figure out which one failed.
This patch adds a new errseq_t to struct super_block, and has
mapping_set_error also record writeback errors there.
To report those errors, we also need to keep an errseq_t in struct file
to act as a cursor. This patch adds a dedicated field for that purpose,
which slots nicely into 4 bytes of padding at the end of struct file on
x86_64.
An earlier version of this patch used an O_PATH file descriptor to cue
the kernel that the open file should track the superblock error and not
the inode's writeback error.
I think that API is just too weird though. This is simpler and should
make syncfs error reporting "just work" even if someone is multiplexing
fsync and syncfs on the same fds.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>
Cc: David Howells <dhowells@redhat.com>
Link: http://lkml.kernel.org/r/20200428135155.19223-1-jlayton@kernel.org
Link: http://lkml.kernel.org/r/20200428135155.19223-2-jlayton@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2020-06-02 12:45:36 +08:00
|
|
|
ret2 = errseq_check_and_advance(&sb->s_wb_err, &f.file->f_sb_err);
|
|
|
|
|
2012-08-29 00:52:22 +08:00
|
|
|
fdput(f);
|
vfs: track per-sb writeback errors and report them to syncfs
Patch series "vfs: have syncfs() return error when there are writeback
errors", v6.
Currently, syncfs does not return errors when one of the inodes fails to
be written back. It will return errors based on the legacy AS_EIO and
AS_ENOSPC flags when syncing out the block device fails, but that's not
particularly helpful for filesystems that aren't backed by a blockdev.
It's also possible for a stray sync to lose those errors.
The basic idea in this set is to track writeback errors at the
superblock level, so that we can quickly and easily check whether
something bad happened without having to fsync each file individually.
syncfs is then changed to reliably report writeback errors after they
occur, much in the same fashion as fsync does now.
This patch (of 2):
Usually we suggest that applications call fsync when they want to ensure
that all data written to the file has made it to the backing store, but
that can be inefficient when there are a lot of open files.
Calling syncfs on the filesystem can be more efficient in some
situations, but the error reporting doesn't currently work the way most
people expect. If a single inode on a filesystem reports a writeback
error, syncfs won't necessarily return an error. syncfs only returns an
error if __sync_blockdev fails, and on some filesystems that's a no-op.
It would be better if syncfs reported an error if there were any
writeback failures. Then applications could call syncfs to see if there
are any errors on any open files, and could then call fsync on all of
the other descriptors to figure out which one failed.
This patch adds a new errseq_t to struct super_block, and has
mapping_set_error also record writeback errors there.
To report those errors, we also need to keep an errseq_t in struct file
to act as a cursor. This patch adds a dedicated field for that purpose,
which slots nicely into 4 bytes of padding at the end of struct file on
x86_64.
An earlier version of this patch used an O_PATH file descriptor to cue
the kernel that the open file should track the superblock error and not
the inode's writeback error.
I think that API is just too weird though. This is simpler and should
make syncfs error reporting "just work" even if someone is multiplexing
fsync and syncfs on the same fds.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>
Cc: David Howells <dhowells@redhat.com>
Link: http://lkml.kernel.org/r/20200428135155.19223-1-jlayton@kernel.org
Link: http://lkml.kernel.org/r/20200428135155.19223-2-jlayton@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2020-06-02 12:45:36 +08:00
|
|
|
return ret ? ret : ret2;
|
2011-03-11 03:31:30 +08:00
|
|
|
}
|
|
|
|
|
2008-12-23 04:11:15 +08:00
|
|
|
/**
|
2009-08-18 01:52:36 +08:00
|
|
|
* vfs_fsync_range - helper to sync a range of data & metadata to disk
|
2008-12-23 04:11:15 +08:00
|
|
|
* @file: file to sync
|
2009-08-18 01:52:36 +08:00
|
|
|
* @start: offset in bytes of the beginning of data range to sync
|
|
|
|
* @end: offset in bytes of the end of data range (inclusive)
|
|
|
|
* @datasync: perform only datasync
|
2008-12-23 04:11:15 +08:00
|
|
|
*
|
2009-08-18 01:52:36 +08:00
|
|
|
* Write back data in range @start..@end and metadata for @file to disk. If
|
|
|
|
* @datasync is set only metadata needed to access modified file data is
|
|
|
|
* written.
|
2008-12-23 04:11:15 +08:00
|
|
|
*/
|
2010-03-23 00:32:25 +08:00
|
|
|
int vfs_fsync_range(struct file *file, loff_t start, loff_t end, int datasync)
|
2006-08-30 02:05:54 +08:00
|
|
|
{
|
2015-02-02 13:37:00 +08:00
|
|
|
struct inode *inode = file->f_mapping->host;
|
|
|
|
|
2013-09-23 04:27:52 +08:00
|
|
|
if (!file->f_op->fsync)
|
2011-07-17 08:44:56 +08:00
|
|
|
return -EINVAL;
|
2018-03-07 09:03:31 +08:00
|
|
|
if (!datasync && (inode->i_state & I_DIRTY_TIME))
|
2015-02-02 13:37:00 +08:00
|
|
|
mark_inode_dirty_sync(inode);
|
2017-07-06 03:26:50 +08:00
|
|
|
return file->f_op->fsync(file, start, end, datasync);
|
2006-08-30 02:05:54 +08:00
|
|
|
}
|
2009-08-18 01:52:36 +08:00
|
|
|
EXPORT_SYMBOL(vfs_fsync_range);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* vfs_fsync - perform a fsync or fdatasync on a file
|
|
|
|
* @file: file to sync
|
|
|
|
* @datasync: only perform a fdatasync operation
|
|
|
|
*
|
|
|
|
* Write back data and metadata for @file to disk. If @datasync is
|
|
|
|
* set only metadata needed to access modified file data is written.
|
|
|
|
*/
|
2010-03-23 00:32:25 +08:00
|
|
|
int vfs_fsync(struct file *file, int datasync)
|
2009-08-18 01:52:36 +08:00
|
|
|
{
|
2010-03-23 00:32:25 +08:00
|
|
|
return vfs_fsync_range(file, 0, LLONG_MAX, datasync);
|
2009-08-18 01:52:36 +08:00
|
|
|
}
|
2008-12-23 04:11:15 +08:00
|
|
|
EXPORT_SYMBOL(vfs_fsync);
|
2006-08-30 02:05:54 +08:00
|
|
|
|
2008-12-23 04:11:15 +08:00
|
|
|
static int do_fsync(unsigned int fd, int datasync)
|
2006-08-30 02:05:54 +08:00
|
|
|
{
|
2012-08-29 00:52:22 +08:00
|
|
|
struct fd f = fdget(fd);
|
2006-08-30 02:05:54 +08:00
|
|
|
int ret = -EBADF;
|
|
|
|
|
2012-08-29 00:52:22 +08:00
|
|
|
if (f.file) {
|
|
|
|
ret = vfs_fsync(f.file, datasync);
|
|
|
|
fdput(f);
|
2006-08-30 02:05:54 +08:00
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2009-01-14 21:14:11 +08:00
|
|
|
SYSCALL_DEFINE1(fsync, unsigned int, fd)
|
2006-08-30 02:05:54 +08:00
|
|
|
{
|
2008-12-23 04:11:15 +08:00
|
|
|
return do_fsync(fd, 0);
|
2006-08-30 02:05:54 +08:00
|
|
|
}
|
|
|
|
|
2009-01-14 21:14:11 +08:00
|
|
|
SYSCALL_DEFINE1(fdatasync, unsigned int, fd)
|
2006-08-30 02:05:54 +08:00
|
|
|
{
|
2008-12-23 04:11:15 +08:00
|
|
|
return do_fsync(fd, 1);
|
2006-08-30 02:05:54 +08:00
|
|
|
}
|
|
|
|
|
2019-04-10 04:51:48 +08:00
|
|
|
int sync_file_range(struct file *file, loff_t offset, loff_t nbytes,
|
|
|
|
unsigned int flags)
|
2006-03-31 18:30:42 +08:00
|
|
|
{
|
|
|
|
int ret;
|
2009-12-17 21:24:40 +08:00
|
|
|
struct address_space *mapping;
|
2006-03-31 18:30:42 +08:00
|
|
|
loff_t endbyte; /* inclusive */
|
|
|
|
umode_t i_mode;
|
|
|
|
|
|
|
|
ret = -EINVAL;
|
|
|
|
if (flags & ~VALID_FLAGS)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
endbyte = offset + nbytes;
|
|
|
|
|
|
|
|
if ((s64)offset < 0)
|
|
|
|
goto out;
|
|
|
|
if ((s64)endbyte < 0)
|
|
|
|
goto out;
|
|
|
|
if (endbyte < offset)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
if (sizeof(pgoff_t) == 4) {
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 20:29:47 +08:00
|
|
|
if (offset >= (0x100000000ULL << PAGE_SHIFT)) {
|
2006-03-31 18:30:42 +08:00
|
|
|
/*
|
|
|
|
* The range starts outside a 32 bit machine's
|
|
|
|
* pagecache addressing capabilities. Let it "succeed"
|
|
|
|
*/
|
|
|
|
ret = 0;
|
|
|
|
goto out;
|
|
|
|
}
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 20:29:47 +08:00
|
|
|
if (endbyte >= (0x100000000ULL << PAGE_SHIFT)) {
|
2006-03-31 18:30:42 +08:00
|
|
|
/*
|
|
|
|
* Out to EOF
|
|
|
|
*/
|
|
|
|
nbytes = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (nbytes == 0)
|
[PATCH] writeback: fix range handling
When a writeback_control's `start' and `end' fields are used to
indicate a one-byte-range starting at file offset zero, the required
values of .start=0,.end=0 mean that the ->writepages() implementation
has no way of telling that it is being asked to perform a range
request. Because we're currently overloading (start == 0 && end == 0)
to mean "this is not a write-a-range request".
To make all this sane, the patch changes range of writeback_control.
So caller does: If it is calling ->writepages() to write pages, it
sets range (range_start/end or range_cyclic) always.
And if range_cyclic is true, ->writepages() thinks the range is
cyclic, otherwise it just uses range_start and range_end.
This patch does,
- Add LLONG_MAX, LLONG_MIN, ULLONG_MAX to include/linux/kernel.h
-1 is usually ok for range_end (type is long long). But, if someone did,
range_end += val; range_end is "val - 1"
u64val = range_end >> bits; u64val is "~(0ULL)"
or something, they are wrong. So, this adds LLONG_MAX to avoid nasty
things, and uses LLONG_MAX for range_end.
- All callers of ->writepages() sets range_start/end or range_cyclic.
- Fix updates of ->writeback_index. It seems already bit strange.
If it starts at 0 and ended by check of nr_to_write, this last
index may reduce chance to scan end of file. So, this updates
->writeback_index only if range_cyclic is true or whole-file is
scanned.
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Nathan Scott <nathans@sgi.com>
Cc: Anton Altaparmakov <aia21@cantab.net>
Cc: Steven French <sfrench@us.ibm.com>
Cc: "Vladimir V. Saveliev" <vs@namesys.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-06-23 17:03:26 +08:00
|
|
|
endbyte = LLONG_MAX;
|
2006-03-31 18:30:42 +08:00
|
|
|
else
|
|
|
|
endbyte--; /* inclusive */
|
|
|
|
|
2019-04-10 04:51:48 +08:00
|
|
|
i_mode = file_inode(file)->i_mode;
|
2006-03-31 18:30:42 +08:00
|
|
|
ret = -ESPIPE;
|
|
|
|
if (!S_ISREG(i_mode) && !S_ISBLK(i_mode) && !S_ISDIR(i_mode) &&
|
|
|
|
!S_ISLNK(i_mode))
|
2019-04-10 04:51:48 +08:00
|
|
|
goto out;
|
2006-03-31 18:30:42 +08:00
|
|
|
|
2019-04-10 04:51:48 +08:00
|
|
|
mapping = file->f_mapping;
|
2009-12-17 21:24:40 +08:00
|
|
|
ret = 0;
|
|
|
|
if (flags & SYNC_FILE_RANGE_WAIT_BEFORE) {
|
2019-04-10 04:51:48 +08:00
|
|
|
ret = file_fdatawait_range(file, offset, endbyte);
|
2009-12-17 21:24:40 +08:00
|
|
|
if (ret < 0)
|
2019-04-10 04:51:48 +08:00
|
|
|
goto out;
|
2009-12-17 21:24:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (flags & SYNC_FILE_RANGE_WRITE) {
|
2019-05-14 08:22:30 +08:00
|
|
|
int sync_mode = WB_SYNC_NONE;
|
|
|
|
|
|
|
|
if ((flags & SYNC_FILE_RANGE_WRITE_AND_WAIT) ==
|
|
|
|
SYNC_FILE_RANGE_WRITE_AND_WAIT)
|
|
|
|
sync_mode = WB_SYNC_ALL;
|
|
|
|
|
2015-11-07 08:28:55 +08:00
|
|
|
ret = __filemap_fdatawrite_range(mapping, offset, endbyte,
|
2019-05-14 08:22:30 +08:00
|
|
|
sync_mode);
|
2009-12-17 21:24:40 +08:00
|
|
|
if (ret < 0)
|
2019-04-10 04:51:48 +08:00
|
|
|
goto out;
|
2009-12-17 21:24:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (flags & SYNC_FILE_RANGE_WAIT_AFTER)
|
2019-04-10 04:51:48 +08:00
|
|
|
ret = file_fdatawait_range(file, offset, endbyte);
|
2009-12-17 21:24:40 +08:00
|
|
|
|
2006-03-31 18:30:42 +08:00
|
|
|
out:
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2019-04-10 04:51:48 +08:00
|
|
|
/*
|
2019-05-14 08:22:30 +08:00
|
|
|
* ksys_sync_file_range() permits finely controlled syncing over a segment of
|
2019-04-10 04:51:48 +08:00
|
|
|
* a file in the range offset .. (offset+nbytes-1) inclusive. If nbytes is
|
2019-05-14 08:22:30 +08:00
|
|
|
* zero then ksys_sync_file_range() will operate from offset out to EOF.
|
2019-04-10 04:51:48 +08:00
|
|
|
*
|
|
|
|
* The flag bits are:
|
|
|
|
*
|
|
|
|
* SYNC_FILE_RANGE_WAIT_BEFORE: wait upon writeout of all pages in the range
|
|
|
|
* before performing the write.
|
|
|
|
*
|
|
|
|
* SYNC_FILE_RANGE_WRITE: initiate writeout of all those dirty pages in the
|
|
|
|
* range which are not presently under writeback. Note that this may block for
|
|
|
|
* significant periods due to exhaustion of disk request structures.
|
|
|
|
*
|
|
|
|
* SYNC_FILE_RANGE_WAIT_AFTER: wait upon writeout of all pages in the range
|
|
|
|
* after performing the write.
|
|
|
|
*
|
|
|
|
* Useful combinations of the flag bits are:
|
|
|
|
*
|
|
|
|
* SYNC_FILE_RANGE_WAIT_BEFORE|SYNC_FILE_RANGE_WRITE: ensures that all pages
|
2019-05-14 08:22:30 +08:00
|
|
|
* in the range which were dirty on entry to ksys_sync_file_range() are placed
|
2019-04-10 04:51:48 +08:00
|
|
|
* under writeout. This is a start-write-for-data-integrity operation.
|
|
|
|
*
|
|
|
|
* SYNC_FILE_RANGE_WRITE: start writeout of all dirty pages in the range which
|
|
|
|
* are not presently under writeout. This is an asynchronous flush-to-disk
|
|
|
|
* operation. Not suitable for data integrity operations.
|
|
|
|
*
|
|
|
|
* SYNC_FILE_RANGE_WAIT_BEFORE (or SYNC_FILE_RANGE_WAIT_AFTER): wait for
|
|
|
|
* completion of writeout of all pages in the range. This will be used after an
|
|
|
|
* earlier SYNC_FILE_RANGE_WAIT_BEFORE|SYNC_FILE_RANGE_WRITE operation to wait
|
|
|
|
* for that operation to complete and to return the result.
|
|
|
|
*
|
2019-05-14 08:22:30 +08:00
|
|
|
* SYNC_FILE_RANGE_WAIT_BEFORE|SYNC_FILE_RANGE_WRITE|SYNC_FILE_RANGE_WAIT_AFTER
|
|
|
|
* (a.k.a. SYNC_FILE_RANGE_WRITE_AND_WAIT):
|
2019-04-10 04:51:48 +08:00
|
|
|
* a traditional sync() operation. This is a write-for-data-integrity operation
|
|
|
|
* which will ensure that all pages in the range which were dirty on entry to
|
2019-05-14 08:22:30 +08:00
|
|
|
* ksys_sync_file_range() are written to disk. It should be noted that disk
|
|
|
|
* caches are not flushed by this call, so there are no guarantees here that the
|
|
|
|
* data will be available on disk after a crash.
|
2019-04-10 04:51:48 +08:00
|
|
|
*
|
|
|
|
*
|
|
|
|
* SYNC_FILE_RANGE_WAIT_BEFORE and SYNC_FILE_RANGE_WAIT_AFTER will detect any
|
|
|
|
* I/O errors or ENOSPC conditions and will return those to the caller, after
|
|
|
|
* clearing the EIO and ENOSPC flags in the address_space.
|
|
|
|
*
|
|
|
|
* It should be noted that none of these operations write out the file's
|
|
|
|
* metadata. So unless the application is strictly performing overwrites of
|
|
|
|
* already-instantiated disk blocks, there are no guarantees here that the data
|
|
|
|
* will be available after a crash.
|
|
|
|
*/
|
|
|
|
int ksys_sync_file_range(int fd, loff_t offset, loff_t nbytes,
|
|
|
|
unsigned int flags)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
struct fd f;
|
|
|
|
|
|
|
|
ret = -EBADF;
|
|
|
|
f = fdget(fd);
|
|
|
|
if (f.file)
|
|
|
|
ret = sync_file_range(f.file, offset, nbytes, flags);
|
|
|
|
|
|
|
|
fdput(f);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2018-03-11 18:34:47 +08:00
|
|
|
SYSCALL_DEFINE4(sync_file_range, int, fd, loff_t, offset, loff_t, nbytes,
|
|
|
|
unsigned int, flags)
|
|
|
|
{
|
|
|
|
return ksys_sync_file_range(fd, offset, nbytes, flags);
|
|
|
|
}
|
|
|
|
|
Introduce fixed sys_sync_file_range2() syscall, implement on PowerPC and ARM
Not all the world is an i386. Many architectures need 64-bit arguments to be
aligned in suitable pairs of registers, and the original
sys_sync_file_range(int, loff_t, loff_t, int) was therefore wasting an
argument register for padding after the first integer. Since we don't
normally have more than 6 arguments for system calls, that left no room for
the final argument on some architectures.
Fix this by introducing sys_sync_file_range2(int, int, loff_t, loff_t) which
all fits nicely. In fact, ARM already had that, but called it
sys_arm_sync_file_range. Move it to fs/sync.c and rename it, then implement
the needed compatibility routine. And stop the missing syscall check from
bitching about the absence of sys_sync_file_range() if we've implemented
sys_sync_file_range2() instead.
Tested on PPC32 and with 32-bit and 64-bit userspace on PPC64.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-06-28 05:10:09 +08:00
|
|
|
/* It would be nice if people remember that not all the world's an i386
|
|
|
|
when they introduce new system calls */
|
2013-01-22 04:16:58 +08:00
|
|
|
SYSCALL_DEFINE4(sync_file_range2, int, fd, unsigned int, flags,
|
|
|
|
loff_t, offset, loff_t, nbytes)
|
Introduce fixed sys_sync_file_range2() syscall, implement on PowerPC and ARM
Not all the world is an i386. Many architectures need 64-bit arguments to be
aligned in suitable pairs of registers, and the original
sys_sync_file_range(int, loff_t, loff_t, int) was therefore wasting an
argument register for padding after the first integer. Since we don't
normally have more than 6 arguments for system calls, that left no room for
the final argument on some architectures.
Fix this by introducing sys_sync_file_range2(int, int, loff_t, loff_t) which
all fits nicely. In fact, ARM already had that, but called it
sys_arm_sync_file_range. Move it to fs/sync.c and rename it, then implement
the needed compatibility routine. And stop the missing syscall check from
bitching about the absence of sys_sync_file_range() if we've implemented
sys_sync_file_range2() instead.
Tested on PPC32 and with 32-bit and 64-bit userspace on PPC64.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-06-28 05:10:09 +08:00
|
|
|
{
|
2018-03-11 18:34:47 +08:00
|
|
|
return ksys_sync_file_range(fd, offset, nbytes, flags);
|
Introduce fixed sys_sync_file_range2() syscall, implement on PowerPC and ARM
Not all the world is an i386. Many architectures need 64-bit arguments to be
aligned in suitable pairs of registers, and the original
sys_sync_file_range(int, loff_t, loff_t, int) was therefore wasting an
argument register for padding after the first integer. Since we don't
normally have more than 6 arguments for system calls, that left no room for
the final argument on some architectures.
Fix this by introducing sys_sync_file_range2(int, int, loff_t, loff_t) which
all fits nicely. In fact, ARM already had that, but called it
sys_arm_sync_file_range. Move it to fs/sync.c and rename it, then implement
the needed compatibility routine. And stop the missing syscall check from
bitching about the absence of sys_sync_file_range() if we've implemented
sys_sync_file_range2() instead.
Tested on PPC32 and with 32-bit and 64-bit userspace on PPC64.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-06-28 05:10:09 +08:00
|
|
|
}
|