2016-06-22 00:04:20 +08:00
|
|
|
/*
|
|
|
|
* Discovery service for the NVMe over Fabrics target.
|
|
|
|
* Copyright (C) 2016 Intel Corporation. All rights reserved.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License version
|
|
|
|
* 2 as published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <generated/utsrelease.h>
|
|
|
|
#include "nvmet.h"
|
|
|
|
|
|
|
|
struct nvmet_subsys *nvmet_disc_subsys;
|
|
|
|
|
|
|
|
u64 nvmet_genctr;
|
|
|
|
|
|
|
|
void nvmet_referral_enable(struct nvmet_port *parent, struct nvmet_port *port)
|
|
|
|
{
|
|
|
|
down_write(&nvmet_config_sem);
|
|
|
|
if (list_empty(&port->entry)) {
|
|
|
|
list_add_tail(&port->entry, &parent->referrals);
|
|
|
|
port->enabled = true;
|
|
|
|
nvmet_genctr++;
|
|
|
|
}
|
|
|
|
up_write(&nvmet_config_sem);
|
|
|
|
}
|
|
|
|
|
|
|
|
void nvmet_referral_disable(struct nvmet_port *port)
|
|
|
|
{
|
|
|
|
down_write(&nvmet_config_sem);
|
|
|
|
if (!list_empty(&port->entry)) {
|
|
|
|
port->enabled = false;
|
|
|
|
list_del_init(&port->entry);
|
|
|
|
nvmet_genctr++;
|
|
|
|
}
|
|
|
|
up_write(&nvmet_config_sem);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void nvmet_format_discovery_entry(struct nvmf_disc_rsp_page_hdr *hdr,
|
2018-01-25 02:27:10 +08:00
|
|
|
struct nvmet_port *port, char *subsys_nqn, char *traddr,
|
|
|
|
u8 type, u32 numrec)
|
2016-06-22 00:04:20 +08:00
|
|
|
{
|
|
|
|
struct nvmf_disc_rsp_page_entry *e = &hdr->entries[numrec];
|
|
|
|
|
|
|
|
e->trtype = port->disc_addr.trtype;
|
|
|
|
e->adrfam = port->disc_addr.adrfam;
|
|
|
|
e->treq = port->disc_addr.treq;
|
|
|
|
e->portid = port->disc_addr.portid;
|
|
|
|
/* we support only dynamic controllers */
|
|
|
|
e->cntlid = cpu_to_le16(NVME_CNTLID_DYNAMIC);
|
2017-06-18 21:15:59 +08:00
|
|
|
e->asqsz = cpu_to_le16(NVME_AQ_DEPTH);
|
2016-09-30 19:51:06 +08:00
|
|
|
e->subtype = type;
|
2016-06-22 00:04:20 +08:00
|
|
|
memcpy(e->trsvcid, port->disc_addr.trsvcid, NVMF_TRSVCID_SIZE);
|
2018-01-25 02:27:10 +08:00
|
|
|
memcpy(e->traddr, traddr, NVMF_TRADDR_SIZE);
|
2016-06-22 00:04:20 +08:00
|
|
|
memcpy(e->tsas.common, port->disc_addr.tsas.common, NVMF_TSAS_SIZE);
|
nvme: target: fix buffer overflow
nvmet_execute_get_disc_log_page() passes a fixed-length string into
nvmet_format_discovery_entry(), which then does a longer memcpy() on
it, as pointed out by gcc-8:
In function 'nvmet_format_discovery_entry',
inlined from 'nvmet_execute_get_disc_log_page' at drivers/nvme/target/discovery.c:126:4:
drivers/nvme/target/discovery.c:62:2: error: 'memcpy' forming offset [38, 223] is out of the bounds [0, 37] [-Werror=array-bounds]
memcpy(e->subnqn, subsys_nqn, NVMF_NQN_SIZE);
Using strncpy() will make this well-defined, filling the rest of the
buffer with zeroes, under the assumption that the input is either
a NUL-terminated string, or a byte sequence containing no zeroes.
If the input is a string that is longer than NVMF_NQN_SIZE, we
continue to have no NUL-termination in the output.
Fixes: a07b4970f464 ("nvmet: add a generic NVMe target")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2018-04-12 23:16:07 +08:00
|
|
|
strncpy(e->subnqn, subsys_nqn, NVMF_NQN_SIZE);
|
2016-06-22 00:04:20 +08:00
|
|
|
}
|
|
|
|
|
2018-01-25 02:27:10 +08:00
|
|
|
/*
|
|
|
|
* nvmet_set_disc_traddr - set a correct discovery log entry traddr
|
|
|
|
*
|
|
|
|
* IP based transports (e.g RDMA) can listen on "any" ipv4/ipv6 addresses
|
|
|
|
* (INADDR_ANY or IN6ADDR_ANY_INIT). The discovery log page traddr reply
|
|
|
|
* must not contain that "any" IP address. If the transport implements
|
|
|
|
* .disc_traddr, use it. this callback will set the discovery traddr
|
|
|
|
* from the req->port address in case the port in question listens
|
|
|
|
* "any" IP address.
|
|
|
|
*/
|
|
|
|
static void nvmet_set_disc_traddr(struct nvmet_req *req, struct nvmet_port *port,
|
|
|
|
char *traddr)
|
|
|
|
{
|
|
|
|
if (req->ops->disc_traddr)
|
|
|
|
req->ops->disc_traddr(req, port, traddr);
|
|
|
|
else
|
|
|
|
memcpy(traddr, port->disc_addr.traddr, NVMF_TRADDR_SIZE);
|
|
|
|
}
|
|
|
|
|
2016-06-22 00:04:20 +08:00
|
|
|
static void nvmet_execute_get_disc_log_page(struct nvmet_req *req)
|
|
|
|
{
|
|
|
|
const int entry_size = sizeof(struct nvmf_disc_rsp_page_entry);
|
|
|
|
struct nvmet_ctrl *ctrl = req->sq->ctrl;
|
|
|
|
struct nvmf_disc_rsp_page_hdr *hdr;
|
|
|
|
size_t data_len = nvmet_get_log_page_len(req->cmd);
|
|
|
|
size_t alloc_len = max(data_len, sizeof(*hdr));
|
|
|
|
int residual_len = data_len - sizeof(*hdr);
|
|
|
|
struct nvmet_subsys_link *p;
|
|
|
|
struct nvmet_port *r;
|
|
|
|
u32 numrec = 0;
|
|
|
|
u16 status = 0;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Make sure we're passing at least a buffer of response header size.
|
|
|
|
* If host provided data len is less than the header size, only the
|
|
|
|
* number of bytes requested by host will be sent to host.
|
|
|
|
*/
|
|
|
|
hdr = kzalloc(alloc_len, GFP_KERNEL);
|
|
|
|
if (!hdr) {
|
|
|
|
status = NVME_SC_INTERNAL;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
down_read(&nvmet_config_sem);
|
|
|
|
list_for_each_entry(p, &req->port->subsystems, entry) {
|
|
|
|
if (!nvmet_host_allowed(req, p->subsys, ctrl->hostnqn))
|
|
|
|
continue;
|
|
|
|
if (residual_len >= entry_size) {
|
2018-01-25 02:27:10 +08:00
|
|
|
char traddr[NVMF_TRADDR_SIZE];
|
|
|
|
|
|
|
|
nvmet_set_disc_traddr(req, req->port, traddr);
|
2016-06-22 00:04:20 +08:00
|
|
|
nvmet_format_discovery_entry(hdr, req->port,
|
2018-01-25 02:27:10 +08:00
|
|
|
p->subsys->subsysnqn, traddr,
|
2016-06-22 00:04:20 +08:00
|
|
|
NVME_NQN_NVME, numrec);
|
|
|
|
residual_len -= entry_size;
|
|
|
|
}
|
|
|
|
numrec++;
|
|
|
|
}
|
|
|
|
|
|
|
|
list_for_each_entry(r, &req->port->referrals, entry) {
|
|
|
|
if (residual_len >= entry_size) {
|
|
|
|
nvmet_format_discovery_entry(hdr, r,
|
|
|
|
NVME_DISC_SUBSYS_NAME,
|
2018-01-25 02:27:10 +08:00
|
|
|
r->disc_addr.traddr,
|
2016-06-22 00:04:20 +08:00
|
|
|
NVME_NQN_DISC, numrec);
|
|
|
|
residual_len -= entry_size;
|
|
|
|
}
|
|
|
|
numrec++;
|
|
|
|
}
|
|
|
|
|
|
|
|
hdr->genctr = cpu_to_le64(nvmet_genctr);
|
|
|
|
hdr->numrec = cpu_to_le64(numrec);
|
|
|
|
hdr->recfmt = cpu_to_le16(0);
|
|
|
|
|
|
|
|
up_read(&nvmet_config_sem);
|
|
|
|
|
|
|
|
status = nvmet_copy_to_sgl(req, 0, hdr, data_len);
|
|
|
|
kfree(hdr);
|
|
|
|
out:
|
|
|
|
nvmet_req_complete(req, status);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void nvmet_execute_identify_disc_ctrl(struct nvmet_req *req)
|
|
|
|
{
|
|
|
|
struct nvmet_ctrl *ctrl = req->sq->ctrl;
|
|
|
|
struct nvme_id_ctrl *id;
|
|
|
|
u16 status = 0;
|
|
|
|
|
|
|
|
id = kzalloc(sizeof(*id), GFP_KERNEL);
|
|
|
|
if (!id) {
|
|
|
|
status = NVME_SC_INTERNAL;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
memset(id->fr, ' ', sizeof(id->fr));
|
|
|
|
strncpy((char *)id->fr, UTS_RELEASE, sizeof(id->fr));
|
|
|
|
|
|
|
|
/* no limit on data transfer sizes for now */
|
|
|
|
id->mdts = 0;
|
|
|
|
id->cntlid = cpu_to_le16(ctrl->cntlid);
|
|
|
|
id->ver = cpu_to_le32(ctrl->subsys->ver);
|
|
|
|
id->lpa = (1 << 2);
|
|
|
|
|
|
|
|
/* no enforcement soft-limit for maxcmd - pick arbitrary high value */
|
|
|
|
id->maxcmd = cpu_to_le16(NVMET_MAX_CMD);
|
|
|
|
|
|
|
|
id->sgls = cpu_to_le32(1 << 0); /* we always support SGLs */
|
|
|
|
if (ctrl->ops->has_keyed_sgls)
|
|
|
|
id->sgls |= cpu_to_le32(1 << 2);
|
nvmet-rdma: support max(16KB, PAGE_SIZE) inline data
The patch enables inline data sizes using up to 4 recv sges, and capping
the size at 16KB or at least 1 page size. So on a 4K page system, up to
16KB is supported, and for a 64K page system 1 page of 64KB is supported.
We avoid > 0 order page allocations for the inline buffers by using
multiple recv sges, one for each page. If the device cannot support
the configured inline data size due to lack of enough recv sges, then
log a warning and reduce the inline size.
Add a new configfs port attribute, called param_inline_data_size,
to allow configuring the size of inline data for a given nvmf port.
The maximum size allowed is still enforced by nvmet-rdma with
NVMET_RDMA_MAX_INLINE_DATA_SIZE, which is now max(16KB, PAGE_SIZE).
And the default size, if not specified via configfs, is still PAGE_SIZE.
This preserves the existing behavior, but allows larger inline sizes
for small page systems. If the configured inline data size exceeds
NVMET_RDMA_MAX_INLINE_DATA_SIZE, a warning is logged and the size is
reduced. If param_inline_data_size is set to 0, then inline data is
disabled for that nvmf port.
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2018-06-20 22:15:10 +08:00
|
|
|
if (req->port->inline_data_size)
|
2016-06-22 00:04:20 +08:00
|
|
|
id->sgls |= cpu_to_le32(1 << 20);
|
|
|
|
|
|
|
|
strcpy(id->subnqn, ctrl->subsys->subsysnqn);
|
|
|
|
|
|
|
|
status = nvmet_copy_to_sgl(req, 0, id, sizeof(*id));
|
|
|
|
|
|
|
|
kfree(id);
|
|
|
|
out:
|
|
|
|
nvmet_req_complete(req, status);
|
|
|
|
}
|
|
|
|
|
2017-02-28 13:21:33 +08:00
|
|
|
u16 nvmet_parse_discovery_cmd(struct nvmet_req *req)
|
2016-06-22 00:04:20 +08:00
|
|
|
{
|
|
|
|
struct nvme_command *cmd = req->cmd;
|
|
|
|
|
|
|
|
if (unlikely(!(req->sq->ctrl->csts & NVME_CSTS_RDY))) {
|
2017-02-28 13:21:02 +08:00
|
|
|
pr_err("got cmd %d while not ready\n",
|
|
|
|
cmd->common.opcode);
|
2016-06-22 00:04:20 +08:00
|
|
|
return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (cmd->common.opcode) {
|
|
|
|
case nvme_admin_get_log_page:
|
|
|
|
req->data_len = nvmet_get_log_page_len(cmd);
|
|
|
|
|
|
|
|
switch (cmd->get_log_page.lid) {
|
|
|
|
case NVME_LOG_DISC:
|
|
|
|
req->execute = nvmet_execute_get_disc_log_page;
|
|
|
|
return 0;
|
|
|
|
default:
|
2017-02-28 13:21:02 +08:00
|
|
|
pr_err("unsupported get_log_page lid %d\n",
|
|
|
|
cmd->get_log_page.lid);
|
2016-06-22 00:04:20 +08:00
|
|
|
return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
|
|
|
|
}
|
|
|
|
case nvme_admin_identify:
|
2017-06-07 17:45:29 +08:00
|
|
|
req->data_len = NVME_IDENTIFY_DATA_SIZE;
|
2017-01-26 23:17:28 +08:00
|
|
|
switch (cmd->identify.cns) {
|
2016-09-30 19:51:10 +08:00
|
|
|
case NVME_ID_CNS_CTRL:
|
2016-06-22 00:04:20 +08:00
|
|
|
req->execute =
|
|
|
|
nvmet_execute_identify_disc_ctrl;
|
|
|
|
return 0;
|
|
|
|
default:
|
2017-02-28 13:21:02 +08:00
|
|
|
pr_err("unsupported identify cns %d\n",
|
|
|
|
cmd->identify.cns);
|
2016-06-22 00:04:20 +08:00
|
|
|
return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
|
|
|
|
}
|
|
|
|
default:
|
2018-08-23 10:58:45 +08:00
|
|
|
pr_err("unhandled cmd %d\n", cmd->common.opcode);
|
2016-06-22 00:04:20 +08:00
|
|
|
return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
int __init nvmet_init_discovery(void)
|
|
|
|
{
|
|
|
|
nvmet_disc_subsys =
|
|
|
|
nvmet_subsys_alloc(NVME_DISC_SUBSYS_NAME, NVME_NQN_DISC);
|
|
|
|
if (!nvmet_disc_subsys)
|
|
|
|
return -ENOMEM;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
void nvmet_exit_discovery(void)
|
|
|
|
{
|
|
|
|
nvmet_subsys_put(nvmet_disc_subsys);
|
|
|
|
}
|