2009-02-17 17:06:41 +08:00
|
|
|
/* MFD cell driver data for the DS1WM driver */
|
|
|
|
|
|
|
|
struct ds1wm_driver_data {
|
|
|
|
int active_high;
|
2009-02-17 17:09:19 +08:00
|
|
|
int clock_rate;
|
w1: ds1wm: add a reset recovery parameter
This fixes a regression in 3.0 reported by Paul Parsons regarding the
removal of the msleep(1) in the ds1wm_reset() function:
: The linux-3.0-rc4 DS1WM 1-wire driver is logging "bus error, retrying"
: error messages on an HP iPAQ hx4700 PDA (XScale-PXA270):
:
: <snip>
: Driver for 1-wire Dallas network protocol.
: DS1WM w1 busmaster driver - (c) 2004 Szabolcs Gyurko
: 1-Wire driver for the DS2760 battery monitor chip - (c) 2004-2005, Szabolcs Gyurko
: ds1wm ds1wm: pass: 1 bus error, retrying
: ds1wm ds1wm: pass: 2 bus error, retrying
: ds1wm ds1wm: pass: 3 bus error, retrying
: ds1wm ds1wm: pass: 4 bus error, retrying
: ds1wm ds1wm: pass: 5 bus error, retrying
: ...
:
: The visible result is that the battery charging LED is erratic; sometimes
: it works, mostly it doesn't.
:
: The linux-2.6.39 DS1WM 1-wire driver worked OK. I haven't tried 3.0-rc1,
: 3.0-rc2, or 3.0-rc3.
This sleep should not be required on normal circuitry provided the
pull-ups on the bus are correctly adapted to the slaves. Unfortunately,
this is not always the case. The sleep is restored but as a parameter to
the probe function in the pdata.
[akpm@linux-foundation.org: coding-style fixes]
Reported-by: Paul Parsons <lost.distance@yahoo.com>
Tested-by: Paul Parsons <lost.distance@yahoo.com>
Signed-off-by: Jean-François Dagenais <dagenaisj@sonatest.com>
Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2011-07-09 06:39:44 +08:00
|
|
|
/* in milliseconds, the amount of time to */
|
|
|
|
/* sleep following a reset pulse. Zero */
|
|
|
|
/* should work if your bus devices recover*/
|
|
|
|
/* time respects the 1-wire spec since the*/
|
|
|
|
/* ds1wm implements the precise timings of*/
|
|
|
|
/* a reset pulse/presence detect sequence.*/
|
|
|
|
unsigned int reset_recover_delay;
|
2009-02-17 17:06:41 +08:00
|
|
|
};
|