2019-05-19 21:51:48 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2009-05-22 05:01:20 +08:00
|
|
|
/*
|
|
|
|
* Copyright (C) 2008 Red Hat, Inc., Eric Paris <eparis@redhat.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/dcache.h>
|
|
|
|
#include <linux/fs.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 16:04:11 +08:00
|
|
|
#include <linux/gfp.h>
|
2009-05-22 05:01:20 +08:00
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/module.h>
|
2009-12-18 10:24:23 +08:00
|
|
|
#include <linux/mount.h>
|
2009-05-22 05:01:20 +08:00
|
|
|
#include <linux/srcu.h>
|
|
|
|
|
|
|
|
#include <linux/fsnotify_backend.h>
|
|
|
|
#include "fsnotify.h"
|
|
|
|
|
2009-05-22 05:01:26 +08:00
|
|
|
/*
|
|
|
|
* Clear all of the marks on an inode when it is being evicted from core
|
|
|
|
*/
|
|
|
|
void __fsnotify_inode_delete(struct inode *inode)
|
|
|
|
{
|
|
|
|
fsnotify_clear_marks_by_inode(inode);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(__fsnotify_inode_delete);
|
|
|
|
|
2009-12-18 10:24:27 +08:00
|
|
|
void __fsnotify_vfsmount_delete(struct vfsmount *mnt)
|
|
|
|
{
|
|
|
|
fsnotify_clear_marks_by_mount(mnt);
|
|
|
|
}
|
|
|
|
|
2016-12-21 23:40:48 +08:00
|
|
|
/**
|
|
|
|
* fsnotify_unmount_inodes - an sb is unmounting. handle any watched inodes.
|
|
|
|
* @sb: superblock being unmounted.
|
|
|
|
*
|
|
|
|
* Called during unmount with no locks held, so needs to be safe against
|
|
|
|
* concurrent modifiers. We temporarily drop sb->s_inode_list_lock and CAN block.
|
|
|
|
*/
|
2018-09-01 15:41:11 +08:00
|
|
|
static void fsnotify_unmount_inodes(struct super_block *sb)
|
2016-12-21 23:40:48 +08:00
|
|
|
{
|
|
|
|
struct inode *inode, *iput_inode = NULL;
|
|
|
|
|
|
|
|
spin_lock(&sb->s_inode_list_lock);
|
|
|
|
list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
|
|
|
|
/*
|
|
|
|
* We cannot __iget() an inode in state I_FREEING,
|
|
|
|
* I_WILL_FREE, or I_NEW which is fine because by that point
|
|
|
|
* the inode cannot have any associated watches.
|
|
|
|
*/
|
|
|
|
spin_lock(&inode->i_lock);
|
|
|
|
if (inode->i_state & (I_FREEING|I_WILL_FREE|I_NEW)) {
|
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If i_count is zero, the inode cannot have any watches and
|
2017-11-28 05:05:09 +08:00
|
|
|
* doing an __iget/iput with SB_ACTIVE clear would actually
|
2016-12-21 23:40:48 +08:00
|
|
|
* evict all inodes with zero i_count from icache which is
|
|
|
|
* unnecessarily violent and may in fact be illegal to do.
|
2019-12-07 00:55:59 +08:00
|
|
|
* However, we should have been called /after/ evict_inodes
|
|
|
|
* removed all zero refcount inodes, in any case. Test to
|
|
|
|
* be sure.
|
2016-12-21 23:40:48 +08:00
|
|
|
*/
|
|
|
|
if (!atomic_read(&inode->i_count)) {
|
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
__iget(inode);
|
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
spin_unlock(&sb->s_inode_list_lock);
|
|
|
|
|
|
|
|
if (iput_inode)
|
|
|
|
iput(iput_inode);
|
|
|
|
|
|
|
|
/* for each watch, send FS_UNMOUNT and then remove it */
|
2020-07-22 20:58:44 +08:00
|
|
|
fsnotify_inode(inode, FS_UNMOUNT);
|
2016-12-21 23:40:48 +08:00
|
|
|
|
|
|
|
fsnotify_inode_delete(inode);
|
|
|
|
|
|
|
|
iput_inode = inode;
|
|
|
|
|
2019-12-07 00:54:23 +08:00
|
|
|
cond_resched();
|
2016-12-21 23:40:48 +08:00
|
|
|
spin_lock(&sb->s_inode_list_lock);
|
|
|
|
}
|
|
|
|
spin_unlock(&sb->s_inode_list_lock);
|
|
|
|
|
|
|
|
if (iput_inode)
|
|
|
|
iput(iput_inode);
|
|
|
|
}
|
|
|
|
|
2018-09-01 15:41:11 +08:00
|
|
|
void fsnotify_sb_delete(struct super_block *sb)
|
|
|
|
{
|
|
|
|
fsnotify_unmount_inodes(sb);
|
|
|
|
fsnotify_clear_marks_by_sb(sb);
|
2021-08-10 23:12:19 +08:00
|
|
|
/* Wait for outstanding object references from connectors */
|
|
|
|
wait_var_event(&sb->s_fsnotify_connectors,
|
|
|
|
!atomic_long_read(&sb->s_fsnotify_connectors));
|
2018-09-01 15:41:11 +08:00
|
|
|
}
|
|
|
|
|
2009-05-22 05:01:29 +08:00
|
|
|
/*
|
|
|
|
* Given an inode, first check if we care what happens to our children. Inotify
|
|
|
|
* and dnotify both tell their parents about events. If we care about any event
|
|
|
|
* on a child we run all of our children and set a dentry flag saying that the
|
|
|
|
* parent cares. Thus when an event happens on a child it can quickly tell if
|
|
|
|
* if there is a need to find a parent and send the event to the parent.
|
|
|
|
*/
|
|
|
|
void __fsnotify_update_child_dentry_flags(struct inode *inode)
|
|
|
|
{
|
|
|
|
struct dentry *alias;
|
|
|
|
int watched;
|
|
|
|
|
|
|
|
if (!S_ISDIR(inode->i_mode))
|
|
|
|
return;
|
|
|
|
|
|
|
|
/* determine if the children should tell inode about their events */
|
|
|
|
watched = fsnotify_inode_watches_children(inode);
|
|
|
|
|
2011-01-07 14:50:06 +08:00
|
|
|
spin_lock(&inode->i_lock);
|
2009-05-22 05:01:29 +08:00
|
|
|
/* run all of the dentries associated with this inode. Since this is a
|
|
|
|
* directory, there damn well better only be one item on this list */
|
2014-10-27 07:19:16 +08:00
|
|
|
hlist_for_each_entry(alias, &inode->i_dentry, d_u.d_alias) {
|
2009-05-22 05:01:29 +08:00
|
|
|
struct dentry *child;
|
|
|
|
|
|
|
|
/* run all of the children of the original inode and fix their
|
|
|
|
* d_flags to indicate parental interest (their parent is the
|
|
|
|
* original inode) */
|
2011-01-07 14:49:34 +08:00
|
|
|
spin_lock(&alias->d_lock);
|
2014-10-27 07:19:16 +08:00
|
|
|
list_for_each_entry(child, &alias->d_subdirs, d_child) {
|
2009-05-22 05:01:29 +08:00
|
|
|
if (!child->d_inode)
|
|
|
|
continue;
|
|
|
|
|
2011-01-07 14:49:34 +08:00
|
|
|
spin_lock_nested(&child->d_lock, DENTRY_D_LOCK_NESTED);
|
2009-05-22 05:01:29 +08:00
|
|
|
if (watched)
|
|
|
|
child->d_flags |= DCACHE_FSNOTIFY_PARENT_WATCHED;
|
|
|
|
else
|
|
|
|
child->d_flags &= ~DCACHE_FSNOTIFY_PARENT_WATCHED;
|
|
|
|
spin_unlock(&child->d_lock);
|
|
|
|
}
|
2011-01-07 14:49:34 +08:00
|
|
|
spin_unlock(&alias->d_lock);
|
2009-05-22 05:01:29 +08:00
|
|
|
}
|
2011-01-07 14:50:06 +08:00
|
|
|
spin_unlock(&inode->i_lock);
|
2009-05-22 05:01:29 +08:00
|
|
|
}
|
|
|
|
|
2020-07-16 16:42:23 +08:00
|
|
|
/* Are inode/sb/mount interested in parent and name info with this event? */
|
|
|
|
static bool fsnotify_event_needs_parent(struct inode *inode, struct mount *mnt,
|
|
|
|
__u32 mask)
|
|
|
|
{
|
|
|
|
__u32 marks_mask = 0;
|
|
|
|
|
|
|
|
/* We only send parent/name to inode/sb/mount for events on non-dir */
|
|
|
|
if (mask & FS_ISDIR)
|
|
|
|
return false;
|
|
|
|
|
2020-12-02 20:07:09 +08:00
|
|
|
/*
|
|
|
|
* All events that are possible on child can also may be reported with
|
|
|
|
* parent/name info to inode/sb/mount. Otherwise, a watching parent
|
|
|
|
* could result in events reported with unexpected name info to sb/mount.
|
|
|
|
*/
|
|
|
|
BUILD_BUG_ON(FS_EVENTS_POSS_ON_CHILD & ~FS_EVENTS_POSS_TO_PARENT);
|
|
|
|
|
2020-07-16 16:42:23 +08:00
|
|
|
/* Did either inode/sb/mount subscribe for events with parent/name? */
|
|
|
|
marks_mask |= fsnotify_parent_needed_mask(inode->i_fsnotify_mask);
|
|
|
|
marks_mask |= fsnotify_parent_needed_mask(inode->i_sb->s_fsnotify_mask);
|
|
|
|
if (mnt)
|
|
|
|
marks_mask |= fsnotify_parent_needed_mask(mnt->mnt_fsnotify_mask);
|
|
|
|
|
|
|
|
/* Did they subscribe for this event with parent/name info? */
|
|
|
|
return mask & marks_mask;
|
|
|
|
}
|
|
|
|
|
2020-07-08 19:11:37 +08:00
|
|
|
/*
|
|
|
|
* Notify this dentry's parent about a child's events with child name info
|
2020-07-16 16:42:23 +08:00
|
|
|
* if parent is watching or if inode/sb/mount are interested in events with
|
|
|
|
* parent and name info.
|
|
|
|
*
|
|
|
|
* Notify only the child without name info if parent is not watching and
|
|
|
|
* inode/sb/mount are not interested in events with parent and name info.
|
2020-07-08 19:11:37 +08:00
|
|
|
*/
|
2020-07-08 19:11:36 +08:00
|
|
|
int __fsnotify_parent(struct dentry *dentry, __u32 mask, const void *data,
|
2020-07-08 19:11:37 +08:00
|
|
|
int data_type)
|
2009-05-22 05:01:29 +08:00
|
|
|
{
|
2020-07-16 16:42:23 +08:00
|
|
|
const struct path *path = fsnotify_data_path(data, data_type);
|
|
|
|
struct mount *mnt = path ? real_mount(path->mnt) : NULL;
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
struct inode *inode = d_inode(dentry);
|
2009-05-22 05:01:29 +08:00
|
|
|
struct dentry *parent;
|
2020-07-16 16:42:23 +08:00
|
|
|
bool parent_watched = dentry->d_flags & DCACHE_FSNOTIFY_PARENT_WATCHED;
|
2020-11-08 18:59:06 +08:00
|
|
|
bool parent_needed, parent_interested;
|
2020-07-16 16:42:23 +08:00
|
|
|
__u32 p_mask;
|
2020-07-22 20:58:46 +08:00
|
|
|
struct inode *p_inode = NULL;
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
struct name_snapshot name;
|
|
|
|
struct qstr *file_name = NULL;
|
2010-10-29 05:21:56 +08:00
|
|
|
int ret = 0;
|
2009-05-22 05:01:29 +08:00
|
|
|
|
2020-07-16 16:42:23 +08:00
|
|
|
/*
|
|
|
|
* Do inode/sb/mount care about parent and name info on non-dir?
|
|
|
|
* Do they care about any event at all?
|
|
|
|
*/
|
|
|
|
if (!inode->i_fsnotify_marks && !inode->i_sb->s_fsnotify_marks &&
|
|
|
|
(!mnt || !mnt->mnt_fsnotify_marks) && !parent_watched)
|
|
|
|
return 0;
|
|
|
|
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
parent = NULL;
|
2020-11-08 18:59:06 +08:00
|
|
|
parent_needed = fsnotify_event_needs_parent(inode, mnt, mask);
|
|
|
|
if (!parent_watched && !parent_needed)
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
goto notify;
|
2009-05-22 05:01:29 +08:00
|
|
|
|
2020-07-16 16:42:23 +08:00
|
|
|
/* Does parent inode care about events on children? */
|
2010-10-10 17:36:30 +08:00
|
|
|
parent = dget_parent(dentry);
|
2009-05-22 05:01:29 +08:00
|
|
|
p_inode = parent->d_inode;
|
2020-07-16 16:42:23 +08:00
|
|
|
p_mask = fsnotify_inode_watches_children(p_inode);
|
|
|
|
if (unlikely(parent_watched && !p_mask))
|
2010-10-10 17:36:30 +08:00
|
|
|
__fsnotify_update_child_dentry_flags(p_inode);
|
2020-07-16 16:42:23 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Include parent/name in notification either if some notification
|
2020-11-08 18:59:06 +08:00
|
|
|
* groups require parent info or the parent is interested in this event.
|
2020-07-16 16:42:23 +08:00
|
|
|
*/
|
2020-11-08 18:59:06 +08:00
|
|
|
parent_interested = mask & p_mask & ALL_FSNOTIFY_EVENTS;
|
|
|
|
if (parent_needed || parent_interested) {
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
/* When notifying parent, child should be passed as data */
|
|
|
|
WARN_ON_ONCE(inode != fsnotify_data_inode(data, data_type));
|
2017-07-08 02:51:19 +08:00
|
|
|
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
/* Notify both parent and child with child name info */
|
2017-07-08 02:51:19 +08:00
|
|
|
take_dentry_name_snapshot(&name, dentry);
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
file_name = &name.name;
|
2020-11-08 18:59:06 +08:00
|
|
|
if (parent_interested)
|
2020-07-16 16:42:23 +08:00
|
|
|
mask |= FS_EVENT_ON_CHILD;
|
2009-05-22 05:01:29 +08:00
|
|
|
}
|
|
|
|
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
notify:
|
2020-07-22 20:58:46 +08:00
|
|
|
ret = fsnotify(mask, data, data_type, p_inode, file_name, inode, 0);
|
2010-10-29 05:21:56 +08:00
|
|
|
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
if (file_name)
|
|
|
|
release_dentry_name_snapshot(&name);
|
|
|
|
dput(parent);
|
2020-07-08 19:11:37 +08:00
|
|
|
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
return ret;
|
2009-05-22 05:01:29 +08:00
|
|
|
}
|
2020-07-08 19:11:36 +08:00
|
|
|
EXPORT_SYMBOL_GPL(__fsnotify_parent);
|
2009-05-22 05:01:29 +08:00
|
|
|
|
2020-12-02 20:07:07 +08:00
|
|
|
static int fsnotify_handle_inode_event(struct fsnotify_group *group,
|
|
|
|
struct fsnotify_mark *inode_mark,
|
|
|
|
u32 mask, const void *data, int data_type,
|
|
|
|
struct inode *dir, const struct qstr *name,
|
|
|
|
u32 cookie)
|
|
|
|
{
|
|
|
|
const struct path *path = fsnotify_data_path(data, data_type);
|
|
|
|
struct inode *inode = fsnotify_data_inode(data, data_type);
|
|
|
|
const struct fsnotify_ops *ops = group->ops;
|
|
|
|
|
|
|
|
if (WARN_ON_ONCE(!ops->handle_inode_event))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if ((inode_mark->mask & FS_EXCL_UNLINK) &&
|
|
|
|
path && d_unlinked(path->dentry))
|
|
|
|
return 0;
|
|
|
|
|
2020-12-02 20:07:09 +08:00
|
|
|
/* Check interest of this mark in case event was sent with two marks */
|
|
|
|
if (!(mask & inode_mark->mask & ALL_FSNOTIFY_EVENTS))
|
|
|
|
return 0;
|
|
|
|
|
2020-12-02 20:07:07 +08:00
|
|
|
return ops->handle_inode_event(inode_mark, mask, inode, dir, name, cookie);
|
|
|
|
}
|
|
|
|
|
2020-07-22 20:58:48 +08:00
|
|
|
static int fsnotify_handle_event(struct fsnotify_group *group, __u32 mask,
|
|
|
|
const void *data, int data_type,
|
|
|
|
struct inode *dir, const struct qstr *name,
|
|
|
|
u32 cookie, struct fsnotify_iter_info *iter_info)
|
|
|
|
{
|
|
|
|
struct fsnotify_mark *inode_mark = fsnotify_iter_inode_mark(iter_info);
|
2020-12-02 20:07:09 +08:00
|
|
|
struct fsnotify_mark *parent_mark = fsnotify_iter_parent_mark(iter_info);
|
2020-07-22 20:58:48 +08:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (WARN_ON_ONCE(fsnotify_iter_sb_mark(iter_info)) ||
|
|
|
|
WARN_ON_ONCE(fsnotify_iter_vfsmount_mark(iter_info)))
|
|
|
|
return 0;
|
|
|
|
|
2020-12-02 20:07:09 +08:00
|
|
|
if (parent_mark) {
|
|
|
|
/*
|
|
|
|
* parent_mark indicates that the parent inode is watching
|
|
|
|
* children and interested in this event, which is an event
|
|
|
|
* possible on child. But is *this mark* watching children and
|
|
|
|
* interested in this event?
|
|
|
|
*/
|
|
|
|
if (parent_mark->mask & FS_EVENT_ON_CHILD) {
|
|
|
|
ret = fsnotify_handle_inode_event(group, parent_mark, mask,
|
|
|
|
data, data_type, dir, name, 0);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
if (!inode_mark)
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (mask & FS_EVENT_ON_CHILD) {
|
|
|
|
/*
|
|
|
|
* Some events can be sent on both parent dir and child marks
|
|
|
|
* (e.g. FS_ATTRIB). If both parent dir and child are
|
|
|
|
* watching, report the event once to parent dir with name (if
|
|
|
|
* interested) and once to child without name (if interested).
|
|
|
|
* The child watcher is expecting an event without a file name
|
|
|
|
* and without the FS_EVENT_ON_CHILD flag.
|
|
|
|
*/
|
|
|
|
mask &= ~FS_EVENT_ON_CHILD;
|
2020-07-22 20:58:48 +08:00
|
|
|
dir = NULL;
|
|
|
|
name = NULL;
|
|
|
|
}
|
|
|
|
|
2020-12-02 20:07:09 +08:00
|
|
|
return fsnotify_handle_inode_event(group, inode_mark, mask, data, data_type,
|
|
|
|
dir, name, cookie);
|
2020-07-22 20:58:48 +08:00
|
|
|
}
|
|
|
|
|
2020-06-07 17:10:40 +08:00
|
|
|
static int send_to_group(__u32 mask, const void *data, int data_type,
|
|
|
|
struct inode *dir, const struct qstr *file_name,
|
|
|
|
u32 cookie, struct fsnotify_iter_info *iter_info)
|
2009-12-18 10:24:23 +08:00
|
|
|
{
|
2010-08-19 00:25:49 +08:00
|
|
|
struct fsnotify_group *group = NULL;
|
2018-10-04 05:25:33 +08:00
|
|
|
__u32 test_mask = (mask & ALL_FSNOTIFY_EVENTS);
|
2018-04-05 21:18:03 +08:00
|
|
|
__u32 marks_mask = 0;
|
|
|
|
__u32 marks_ignored_mask = 0;
|
2018-04-21 07:10:53 +08:00
|
|
|
struct fsnotify_mark *mark;
|
|
|
|
int type;
|
2010-07-28 22:18:39 +08:00
|
|
|
|
2018-04-21 07:10:50 +08:00
|
|
|
if (WARN_ON(!iter_info->report_mask))
|
2010-08-19 00:25:49 +08:00
|
|
|
return 0;
|
2010-07-28 22:18:39 +08:00
|
|
|
|
|
|
|
/* clear ignored on inode modification */
|
|
|
|
if (mask & FS_MODIFY) {
|
2018-04-21 07:10:53 +08:00
|
|
|
fsnotify_foreach_obj_type(type) {
|
|
|
|
if (!fsnotify_iter_should_report_type(iter_info, type))
|
|
|
|
continue;
|
|
|
|
mark = iter_info->marks[type];
|
|
|
|
if (mark &&
|
|
|
|
!(mark->flags & FSNOTIFY_MARK_FLAG_IGNORED_SURV_MODIFY))
|
|
|
|
mark->ignored_mask = 0;
|
|
|
|
}
|
2010-07-28 22:18:39 +08:00
|
|
|
}
|
2010-07-28 22:18:39 +08:00
|
|
|
|
2018-04-21 07:10:53 +08:00
|
|
|
fsnotify_foreach_obj_type(type) {
|
|
|
|
if (!fsnotify_iter_should_report_type(iter_info, type))
|
|
|
|
continue;
|
|
|
|
mark = iter_info->marks[type];
|
|
|
|
/* does the object mark tell us to do something? */
|
|
|
|
if (mark) {
|
|
|
|
group = mark->group;
|
|
|
|
marks_mask |= mark->mask;
|
|
|
|
marks_ignored_mask |= mark->ignored_mask;
|
|
|
|
}
|
2010-07-28 22:18:39 +08:00
|
|
|
}
|
|
|
|
|
2020-06-07 17:10:40 +08:00
|
|
|
pr_debug("%s: group=%p mask=%x marks_mask=%x marks_ignored_mask=%x data=%p data_type=%d dir=%p cookie=%d\n",
|
|
|
|
__func__, group, mask, marks_mask, marks_ignored_mask,
|
|
|
|
data, data_type, dir, cookie);
|
2010-08-19 00:25:49 +08:00
|
|
|
|
2018-04-05 21:18:03 +08:00
|
|
|
if (!(test_mask & marks_mask & ~marks_ignored_mask))
|
2010-07-28 22:18:39 +08:00
|
|
|
return 0;
|
|
|
|
|
2020-07-22 20:58:48 +08:00
|
|
|
if (group->ops->handle_event) {
|
|
|
|
return group->ops->handle_event(group, mask, data, data_type, dir,
|
|
|
|
file_name, cookie, iter_info);
|
|
|
|
}
|
|
|
|
|
|
|
|
return fsnotify_handle_event(group, mask, data, data_type, dir,
|
|
|
|
file_name, cookie, iter_info);
|
2009-12-18 10:24:23 +08:00
|
|
|
}
|
|
|
|
|
2017-10-31 04:14:56 +08:00
|
|
|
static struct fsnotify_mark *fsnotify_first_mark(struct fsnotify_mark_connector **connp)
|
|
|
|
{
|
|
|
|
struct fsnotify_mark_connector *conn;
|
|
|
|
struct hlist_node *node = NULL;
|
|
|
|
|
|
|
|
conn = srcu_dereference(*connp, &fsnotify_mark_srcu);
|
|
|
|
if (conn)
|
|
|
|
node = srcu_dereference(conn->list.first, &fsnotify_mark_srcu);
|
|
|
|
|
|
|
|
return hlist_entry_safe(node, struct fsnotify_mark, obj_list);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct fsnotify_mark *fsnotify_next_mark(struct fsnotify_mark *mark)
|
|
|
|
{
|
|
|
|
struct hlist_node *node = NULL;
|
|
|
|
|
|
|
|
if (mark)
|
|
|
|
node = srcu_dereference(mark->obj_list.next,
|
|
|
|
&fsnotify_mark_srcu);
|
|
|
|
|
|
|
|
return hlist_entry_safe(node, struct fsnotify_mark, obj_list);
|
|
|
|
}
|
|
|
|
|
2018-04-21 07:10:51 +08:00
|
|
|
/*
|
|
|
|
* iter_info is a multi head priority queue of marks.
|
|
|
|
* Pick a subset of marks from queue heads, all with the
|
|
|
|
* same group and set the report_mask for selected subset.
|
|
|
|
* Returns the report_mask of the selected subset.
|
|
|
|
*/
|
|
|
|
static unsigned int fsnotify_iter_select_report_types(
|
|
|
|
struct fsnotify_iter_info *iter_info)
|
|
|
|
{
|
2018-04-21 07:10:52 +08:00
|
|
|
struct fsnotify_group *max_prio_group = NULL;
|
|
|
|
struct fsnotify_mark *mark;
|
|
|
|
int type;
|
|
|
|
|
|
|
|
/* Choose max prio group among groups of all queue heads */
|
|
|
|
fsnotify_foreach_obj_type(type) {
|
|
|
|
mark = iter_info->marks[type];
|
|
|
|
if (mark &&
|
|
|
|
fsnotify_compare_groups(max_prio_group, mark->group) > 0)
|
|
|
|
max_prio_group = mark->group;
|
|
|
|
}
|
2018-04-21 07:10:51 +08:00
|
|
|
|
2018-04-21 07:10:52 +08:00
|
|
|
if (!max_prio_group)
|
2018-04-21 07:10:51 +08:00
|
|
|
return 0;
|
|
|
|
|
2018-04-21 07:10:52 +08:00
|
|
|
/* Set the report mask for marks from same group as max prio group */
|
2018-04-21 07:10:51 +08:00
|
|
|
iter_info->report_mask = 0;
|
2018-04-21 07:10:52 +08:00
|
|
|
fsnotify_foreach_obj_type(type) {
|
|
|
|
mark = iter_info->marks[type];
|
|
|
|
if (mark &&
|
|
|
|
fsnotify_compare_groups(max_prio_group, mark->group) == 0)
|
|
|
|
fsnotify_iter_set_report_type(iter_info, type);
|
|
|
|
}
|
2018-04-21 07:10:51 +08:00
|
|
|
|
|
|
|
return iter_info->report_mask;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Pop from iter_info multi head queue, the marks that were iterated in the
|
|
|
|
* current iteration step.
|
|
|
|
*/
|
|
|
|
static void fsnotify_iter_next(struct fsnotify_iter_info *iter_info)
|
|
|
|
{
|
2018-04-21 07:10:52 +08:00
|
|
|
int type;
|
2018-04-21 07:10:51 +08:00
|
|
|
|
2018-04-21 07:10:52 +08:00
|
|
|
fsnotify_foreach_obj_type(type) {
|
|
|
|
if (fsnotify_iter_should_report_type(iter_info, type))
|
|
|
|
iter_info->marks[type] =
|
|
|
|
fsnotify_next_mark(iter_info->marks[type]);
|
|
|
|
}
|
2018-04-21 07:10:51 +08:00
|
|
|
}
|
|
|
|
|
2009-05-22 05:01:20 +08:00
|
|
|
/*
|
2020-07-22 20:58:46 +08:00
|
|
|
* fsnotify - This is the main call to fsnotify.
|
|
|
|
*
|
|
|
|
* The VFS calls into hook specific functions in linux/fsnotify.h.
|
|
|
|
* Those functions then in turn call here. Here will call out to all of the
|
|
|
|
* registered fsnotify_group. Those groups can then use the notification event
|
|
|
|
* in whatever means they feel necessary.
|
|
|
|
*
|
|
|
|
* @mask: event type and flags
|
|
|
|
* @data: object that event happened on
|
|
|
|
* @data_type: type of object for fanotify_data_XXX() accessors
|
|
|
|
* @dir: optional directory associated with event -
|
|
|
|
* if @file_name is not NULL, this is the directory that
|
|
|
|
* @file_name is relative to
|
|
|
|
* @file_name: optional file name associated with event
|
|
|
|
* @inode: optional inode associated with event -
|
|
|
|
* either @dir or @inode must be non-NULL.
|
|
|
|
* if both are non-NULL event may be reported to both.
|
|
|
|
* @cookie: inotify rename cookie
|
2009-05-22 05:01:20 +08:00
|
|
|
*/
|
2020-07-22 20:58:46 +08:00
|
|
|
int fsnotify(__u32 mask, const void *data, int data_type, struct inode *dir,
|
|
|
|
const struct qstr *file_name, struct inode *inode, u32 cookie)
|
2009-05-22 05:01:20 +08:00
|
|
|
{
|
2020-06-07 17:10:40 +08:00
|
|
|
const struct path *path = fsnotify_data_path(data, data_type);
|
2017-10-31 04:14:56 +08:00
|
|
|
struct fsnotify_iter_info iter_info = {};
|
2020-07-22 20:58:46 +08:00
|
|
|
struct super_block *sb;
|
2018-09-01 15:41:12 +08:00
|
|
|
struct mount *mnt = NULL;
|
2020-12-02 20:07:09 +08:00
|
|
|
struct inode *parent = NULL;
|
2016-11-11 00:51:50 +08:00
|
|
|
int ret = 0;
|
2020-07-08 19:11:36 +08:00
|
|
|
__u32 test_mask, marks_mask;
|
2009-05-22 05:01:20 +08:00
|
|
|
|
2020-07-08 19:11:36 +08:00
|
|
|
if (path)
|
2020-03-19 23:10:12 +08:00
|
|
|
mnt = real_mount(path->mnt);
|
2010-07-28 22:18:39 +08:00
|
|
|
|
2020-07-22 20:58:46 +08:00
|
|
|
if (!inode) {
|
|
|
|
/* Dirent event - report on TYPE_INODE to dir */
|
|
|
|
inode = dir;
|
|
|
|
} else if (mask & FS_EVENT_ON_CHILD) {
|
|
|
|
/*
|
2020-12-02 20:07:09 +08:00
|
|
|
* Event on child - report on TYPE_PARENT to dir if it is
|
|
|
|
* watching children and on TYPE_INODE to child.
|
2020-07-22 20:58:46 +08:00
|
|
|
*/
|
2020-12-02 20:07:09 +08:00
|
|
|
parent = dir;
|
2020-07-22 20:58:46 +08:00
|
|
|
}
|
|
|
|
sb = inode->i_sb;
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
|
2015-09-05 06:43:01 +08:00
|
|
|
/*
|
|
|
|
* Optimization: srcu_read_lock() has a memory barrier which can
|
|
|
|
* be expensive. It protects walking the *_fsnotify_marks lists.
|
|
|
|
* However, if we do not walk the lists, we do not have to do
|
|
|
|
* SRCU because we have no references to any objects and do not
|
|
|
|
* need SRCU to keep them "alive".
|
|
|
|
*/
|
2020-07-16 16:42:23 +08:00
|
|
|
if (!sb->s_fsnotify_marks &&
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
(!mnt || !mnt->mnt_fsnotify_marks) &&
|
2020-07-16 16:42:23 +08:00
|
|
|
(!inode || !inode->i_fsnotify_marks) &&
|
2020-12-02 20:07:09 +08:00
|
|
|
(!parent || !parent->i_fsnotify_marks))
|
2015-09-05 06:43:01 +08:00
|
|
|
return 0;
|
2020-07-08 19:11:36 +08:00
|
|
|
|
2020-07-16 16:42:23 +08:00
|
|
|
marks_mask = sb->s_fsnotify_mask;
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
if (mnt)
|
|
|
|
marks_mask |= mnt->mnt_fsnotify_mask;
|
2020-07-16 16:42:23 +08:00
|
|
|
if (inode)
|
|
|
|
marks_mask |= inode->i_fsnotify_mask;
|
2020-12-02 20:07:09 +08:00
|
|
|
if (parent)
|
|
|
|
marks_mask |= parent->i_fsnotify_mask;
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
|
2020-07-08 19:11:36 +08:00
|
|
|
|
2010-07-28 22:18:39 +08:00
|
|
|
/*
|
|
|
|
* if this is a modify event we may need to clear the ignored masks
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
* otherwise return if none of the marks care about this type of event.
|
2010-07-28 22:18:39 +08:00
|
|
|
*/
|
2020-07-08 19:11:36 +08:00
|
|
|
test_mask = (mask & ALL_FSNOTIFY_EVENTS);
|
|
|
|
if (!(mask & FS_MODIFY) && !(test_mask & marks_mask))
|
2010-07-28 22:18:39 +08:00
|
|
|
return 0;
|
2009-12-18 10:24:23 +08:00
|
|
|
|
2016-11-11 00:51:50 +08:00
|
|
|
iter_info.srcu_idx = srcu_read_lock(&fsnotify_mark_srcu);
|
2009-12-18 10:24:23 +08:00
|
|
|
|
2019-01-11 01:04:30 +08:00
|
|
|
iter_info.marks[FSNOTIFY_OBJ_TYPE_SB] =
|
|
|
|
fsnotify_first_mark(&sb->s_fsnotify_marks);
|
2018-09-01 14:40:01 +08:00
|
|
|
if (mnt) {
|
2018-04-21 07:10:52 +08:00
|
|
|
iter_info.marks[FSNOTIFY_OBJ_TYPE_VFSMOUNT] =
|
2017-10-31 04:14:56 +08:00
|
|
|
fsnotify_first_mark(&mnt->mnt_fsnotify_marks);
|
2009-05-22 05:01:20 +08:00
|
|
|
}
|
2020-07-16 16:42:23 +08:00
|
|
|
if (inode) {
|
|
|
|
iter_info.marks[FSNOTIFY_OBJ_TYPE_INODE] =
|
|
|
|
fsnotify_first_mark(&inode->i_fsnotify_marks);
|
|
|
|
}
|
2020-12-02 20:07:09 +08:00
|
|
|
if (parent) {
|
|
|
|
iter_info.marks[FSNOTIFY_OBJ_TYPE_PARENT] =
|
|
|
|
fsnotify_first_mark(&parent->i_fsnotify_marks);
|
fsnotify: send event to parent and child with single callback
Instead of calling fsnotify() twice, once with parent inode and once
with child inode, if event should be sent to parent inode, send it
with both parent and child inodes marks in object type iterator and call
the backend handle_event() callback only once.
The parent inode is assigned to the standard "inode" iterator type and
the child inode is assigned to the special "child" iterator type.
In that case, the bit FS_EVENT_ON_CHILD will be set in the event mask,
the dir argument to handle_event will be the parent inode, the file_name
argument to handle_event is non NULL and refers to the name of the child
and the child inode can be accessed with fsnotify_data_inode().
This will allow fanotify to make decisions based on child or parent's
ignored mask. For example, when a parent is interested in a specific
event on its children, but a specific child wishes to ignore this event,
the event will not be reported. This is not what happens with current
code, but according to man page, it is the expected behavior.
Link: https://lore.kernel.org/r/20200716084230.30611-15-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-07-16 16:42:22 +08:00
|
|
|
}
|
2010-07-28 22:18:38 +08:00
|
|
|
|
2014-11-14 07:19:33 +08:00
|
|
|
/*
|
2018-09-01 15:41:12 +08:00
|
|
|
* We need to merge inode/vfsmount/sb mark lists so that e.g. inode mark
|
|
|
|
* ignore masks are properly reflected for mount/sb mark notifications.
|
2014-11-14 07:19:33 +08:00
|
|
|
* That's why this traversal is so complicated...
|
|
|
|
*/
|
2018-04-21 07:10:51 +08:00
|
|
|
while (fsnotify_iter_select_report_types(&iter_info)) {
|
2020-06-07 17:10:40 +08:00
|
|
|
ret = send_to_group(mask, data, data_type, dir, file_name,
|
|
|
|
cookie, &iter_info);
|
2010-07-28 22:18:39 +08:00
|
|
|
|
2010-10-29 05:21:56 +08:00
|
|
|
if (ret && (mask & ALL_FSNOTIFY_PERM_EVENTS))
|
|
|
|
goto out;
|
|
|
|
|
2018-04-21 07:10:51 +08:00
|
|
|
fsnotify_iter_next(&iter_info);
|
2009-12-18 10:24:23 +08:00
|
|
|
}
|
2010-10-29 05:21:56 +08:00
|
|
|
ret = 0;
|
|
|
|
out:
|
2016-11-11 00:51:50 +08:00
|
|
|
srcu_read_unlock(&fsnotify_mark_srcu, iter_info.srcu_idx);
|
2009-12-18 10:24:34 +08:00
|
|
|
|
2010-03-23 15:08:09 +08:00
|
|
|
return ret;
|
2009-05-22 05:01:20 +08:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(fsnotify);
|
|
|
|
|
|
|
|
static __init int fsnotify_init(void)
|
|
|
|
{
|
2010-07-28 22:18:38 +08:00
|
|
|
int ret;
|
|
|
|
|
2020-07-08 19:11:52 +08:00
|
|
|
BUILD_BUG_ON(HWEIGHT32(ALL_FSNOTIFY_BITS) != 25);
|
2010-07-28 22:18:37 +08:00
|
|
|
|
2010-07-28 22:18:38 +08:00
|
|
|
ret = init_srcu_struct(&fsnotify_mark_srcu);
|
|
|
|
if (ret)
|
|
|
|
panic("initializing fsnotify_mark_srcu");
|
|
|
|
|
2017-03-14 19:31:02 +08:00
|
|
|
fsnotify_mark_connector_cachep = KMEM_CACHE(fsnotify_mark_connector,
|
|
|
|
SLAB_PANIC);
|
|
|
|
|
2010-07-28 22:18:38 +08:00
|
|
|
return 0;
|
2009-05-22 05:01:20 +08:00
|
|
|
}
|
2010-07-28 22:18:38 +08:00
|
|
|
core_initcall(fsnotify_init);
|