2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* Created: Tue Feb 2 08:37:54 1999 by faith@valinux.com
|
|
|
|
*
|
|
|
|
* Copyright 1999 Precision Insight, Inc., Cedar Park, Texas.
|
|
|
|
* Copyright 2000 VA Linux Systems, Inc., Sunnyvale, California.
|
|
|
|
* All Rights Reserved.
|
|
|
|
*
|
2015-05-05 03:01:30 +08:00
|
|
|
* Author Rickard E. (Rik) Faith <faith@valinux.com>
|
|
|
|
* Author Gareth Hughes <gareth@valinux.com>
|
|
|
|
*
|
2005-04-17 06:20:36 +08:00
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice (including the next
|
|
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
|
|
* Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* VA LINUX SYSTEMS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
*/
|
|
|
|
|
2019-05-27 01:35:35 +08:00
|
|
|
#include <linux/slab.h>
|
|
|
|
|
|
|
|
#include <drm/drm_auth.h>
|
|
|
|
#include <drm/drm_drv.h>
|
|
|
|
#include <drm/drm_file.h>
|
|
|
|
#include <drm/drm_lease.h>
|
|
|
|
#include <drm/drm_print.h>
|
|
|
|
|
2014-09-10 18:43:53 +08:00
|
|
|
#include "drm_internal.h"
|
2016-06-15 02:50:59 +08:00
|
|
|
#include "drm_legacy.h"
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
/**
|
2016-06-21 16:54:22 +08:00
|
|
|
* DOC: master and authentication
|
2005-04-17 06:20:36 +08:00
|
|
|
*
|
2016-12-30 04:48:26 +08:00
|
|
|
* &struct drm_master is used to track groups of clients with open
|
|
|
|
* primary/legacy device nodes. For every &struct drm_file which has had at
|
2016-06-21 16:54:22 +08:00
|
|
|
* least once successfully became the device master (either through the
|
|
|
|
* SET_MASTER IOCTL, or implicitly through opening the primary device node when
|
|
|
|
* no one else is the current master that time) there exists one &drm_master.
|
2017-01-25 14:26:47 +08:00
|
|
|
* This is noted in &drm_file.is_master. All other clients have just a pointer
|
|
|
|
* to the &drm_master they are associated with.
|
2005-04-17 06:20:36 +08:00
|
|
|
*
|
2016-06-21 16:54:22 +08:00
|
|
|
* In addition only one &drm_master can be the current master for a &drm_device.
|
|
|
|
* It can be switched through the DROP_MASTER and SET_MASTER IOCTL, or
|
|
|
|
* implicitly through closing/openeing the primary device node. See also
|
|
|
|
* drm_is_current_master().
|
|
|
|
*
|
|
|
|
* Clients can authenticate against the current master (if it matches their own)
|
|
|
|
* using the GETMAGIC and AUTHMAGIC IOCTLs. Together with exchanging masters,
|
|
|
|
* this allows controlled access to the device for an entire group of mutually
|
|
|
|
* trusted clients.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2016-06-21 16:54:22 +08:00
|
|
|
|
2021-07-12 12:35:06 +08:00
|
|
|
static bool drm_is_current_master_locked(struct drm_file *fpriv)
|
|
|
|
{
|
2021-07-24 19:18:22 +08:00
|
|
|
/* Either drm_device.master_mutex or drm_file.master_lookup_lock
|
|
|
|
* should be held here.
|
|
|
|
*/
|
2021-07-12 12:35:06 +08:00
|
|
|
return fpriv->is_master && drm_lease_owner(fpriv->master) == fpriv->minor->dev->master;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* drm_is_current_master - checks whether @priv is the current master
|
|
|
|
* @fpriv: DRM file private
|
|
|
|
*
|
|
|
|
* Checks whether @fpriv is current master on its device. This decides whether a
|
|
|
|
* client is allowed to run DRM_MASTER IOCTLs.
|
|
|
|
*
|
|
|
|
* Most of the modern IOCTL which require DRM_MASTER are for kernel modesetting
|
|
|
|
* - the current master is assumed to own the non-shareable display hardware.
|
|
|
|
*/
|
|
|
|
bool drm_is_current_master(struct drm_file *fpriv)
|
|
|
|
{
|
|
|
|
bool ret;
|
|
|
|
|
2021-07-24 19:18:22 +08:00
|
|
|
spin_lock(&fpriv->master_lookup_lock);
|
2021-07-12 12:35:06 +08:00
|
|
|
ret = drm_is_current_master_locked(fpriv);
|
2021-07-24 19:18:22 +08:00
|
|
|
spin_unlock(&fpriv->master_lookup_lock);
|
2021-07-12 12:35:06 +08:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_is_current_master);
|
|
|
|
|
2007-09-03 10:06:45 +08:00
|
|
|
int drm_getmagic(struct drm_device *dev, void *data, struct drm_file *file_priv)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2007-09-03 10:06:45 +08:00
|
|
|
struct drm_auth *auth = data;
|
2015-05-05 03:01:30 +08:00
|
|
|
int ret = 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2016-06-17 15:33:21 +08:00
|
|
|
mutex_lock(&dev->master_mutex);
|
2015-05-05 03:01:30 +08:00
|
|
|
if (!file_priv->magic) {
|
|
|
|
ret = idr_alloc(&file_priv->master->magic_map, file_priv,
|
|
|
|
1, 0, GFP_KERNEL);
|
|
|
|
if (ret >= 0)
|
|
|
|
file_priv->magic = ret;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2015-05-05 03:01:30 +08:00
|
|
|
auth->magic = file_priv->magic;
|
2016-06-17 15:33:21 +08:00
|
|
|
mutex_unlock(&dev->master_mutex);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2007-09-03 10:06:45 +08:00
|
|
|
DRM_DEBUG("%u\n", auth->magic);
|
|
|
|
|
2015-05-05 03:01:30 +08:00
|
|
|
return ret < 0 ? ret : 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2007-09-03 10:06:45 +08:00
|
|
|
int drm_authmagic(struct drm_device *dev, void *data,
|
|
|
|
struct drm_file *file_priv)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2007-09-03 10:06:45 +08:00
|
|
|
struct drm_auth *auth = data;
|
2007-07-11 13:53:27 +08:00
|
|
|
struct drm_file *file;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2007-09-03 10:06:45 +08:00
|
|
|
DRM_DEBUG("%u\n", auth->magic);
|
2015-05-05 03:01:30 +08:00
|
|
|
|
2016-06-17 15:33:21 +08:00
|
|
|
mutex_lock(&dev->master_mutex);
|
2015-05-05 03:01:30 +08:00
|
|
|
file = idr_find(&file_priv->master->magic_map, auth->magic);
|
|
|
|
if (file) {
|
2005-04-17 06:20:36 +08:00
|
|
|
file->authenticated = 1;
|
2015-05-05 03:01:30 +08:00
|
|
|
idr_replace(&file_priv->master->magic_map, NULL, auth->magic);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2016-06-17 15:33:21 +08:00
|
|
|
mutex_unlock(&dev->master_mutex);
|
2015-05-05 03:01:30 +08:00
|
|
|
|
|
|
|
return file ? 0 : -EINVAL;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2016-06-15 02:50:59 +08:00
|
|
|
|
drm: Add drm_object lease infrastructure [v5]
This provides new data structures to hold "lease" information about
drm mode setting objects, and provides for creating new drm_masters
which have access to a subset of the available drm resources.
An 'owner' is a drm_master which is not leasing the objects from
another drm_master, and hence 'owns' them.
A 'lessee' is a drm_master which is leasing objects from some other
drm_master. Each lessee holds the set of objects which it is leasing
from the lessor.
A 'lessor' is a drm_master which is leasing objects to another
drm_master. This is the same as the owner in the current code.
The set of objects any drm_master 'controls' is limited to the set of
objects it leases (for lessees) or all objects (for owners).
Objects not controlled by a drm_master cannot be modified through the
various state manipulating ioctls, and any state reported back to user
space will be edited to make them appear idle and/or unusable. For
instance, connectors always report 'disconnected', while encoders
report no possible crtcs or clones.
The full list of lessees leasing objects from an owner (either
directly, or indirectly through another lessee), can be searched from
an idr in the drm_master of the owner.
Changes for v2 as suggested by Daniel Vetter <daniel.vetter@ffwll.ch>:
* Sub-leasing has been disabled.
* BUG_ON for lock checking replaced with lockdep_assert_held
* 'change' ioctl has been removed.
* Leased objects can always be controlled by the lessor; the
'mask_lease' flag has been removed
* Checking for leased status has been simplified, replacing
the drm_lease_check function with drm_lease_held.
Changes in v3, some suggested by Dave Airlie <airlied@gmail.com>
* Add revocation. This allows leases to be effectively revoked by
removing all of the objects they have access to. The lease itself
hangs around as it's hanging off a file.
* Free the leases IDR when the master is destroyed
* _drm_lease_held should look at lessees, not lessor
* Allow non-master files to check for lease status
Changes in v4, suggested by Dave Airlie <airlied@gmail.com>
* Formatting and whitespace changes
Changes in v5 (airlied)
* check DRIVER_MODESET before lease destroy call
* check DRIVER_MODESET for lease revoke (Chris)
* Use idr_mutex uniformly for all lease elements of struct drm_master. (Keith)
Signed-off-by: Keith Packard <keithp@keithp.com>
2017-03-15 13:26:41 +08:00
|
|
|
struct drm_master *drm_master_create(struct drm_device *dev)
|
2016-06-15 02:50:59 +08:00
|
|
|
{
|
|
|
|
struct drm_master *master;
|
|
|
|
|
|
|
|
master = kzalloc(sizeof(*master), GFP_KERNEL);
|
|
|
|
if (!master)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
kref_init(&master->refcount);
|
2019-04-23 08:01:50 +08:00
|
|
|
drm_master_legacy_init(master);
|
2016-06-15 02:50:59 +08:00
|
|
|
idr_init(&master->magic_map);
|
|
|
|
master->dev = dev;
|
|
|
|
|
drm: Add drm_object lease infrastructure [v5]
This provides new data structures to hold "lease" information about
drm mode setting objects, and provides for creating new drm_masters
which have access to a subset of the available drm resources.
An 'owner' is a drm_master which is not leasing the objects from
another drm_master, and hence 'owns' them.
A 'lessee' is a drm_master which is leasing objects from some other
drm_master. Each lessee holds the set of objects which it is leasing
from the lessor.
A 'lessor' is a drm_master which is leasing objects to another
drm_master. This is the same as the owner in the current code.
The set of objects any drm_master 'controls' is limited to the set of
objects it leases (for lessees) or all objects (for owners).
Objects not controlled by a drm_master cannot be modified through the
various state manipulating ioctls, and any state reported back to user
space will be edited to make them appear idle and/or unusable. For
instance, connectors always report 'disconnected', while encoders
report no possible crtcs or clones.
The full list of lessees leasing objects from an owner (either
directly, or indirectly through another lessee), can be searched from
an idr in the drm_master of the owner.
Changes for v2 as suggested by Daniel Vetter <daniel.vetter@ffwll.ch>:
* Sub-leasing has been disabled.
* BUG_ON for lock checking replaced with lockdep_assert_held
* 'change' ioctl has been removed.
* Leased objects can always be controlled by the lessor; the
'mask_lease' flag has been removed
* Checking for leased status has been simplified, replacing
the drm_lease_check function with drm_lease_held.
Changes in v3, some suggested by Dave Airlie <airlied@gmail.com>
* Add revocation. This allows leases to be effectively revoked by
removing all of the objects they have access to. The lease itself
hangs around as it's hanging off a file.
* Free the leases IDR when the master is destroyed
* _drm_lease_held should look at lessees, not lessor
* Allow non-master files to check for lease status
Changes in v4, suggested by Dave Airlie <airlied@gmail.com>
* Formatting and whitespace changes
Changes in v5 (airlied)
* check DRIVER_MODESET before lease destroy call
* check DRIVER_MODESET for lease revoke (Chris)
* Use idr_mutex uniformly for all lease elements of struct drm_master. (Keith)
Signed-off-by: Keith Packard <keithp@keithp.com>
2017-03-15 13:26:41 +08:00
|
|
|
/* initialize the tree of output resource lessees */
|
|
|
|
INIT_LIST_HEAD(&master->lessees);
|
|
|
|
INIT_LIST_HEAD(&master->lessee_list);
|
|
|
|
idr_init(&master->leases);
|
|
|
|
idr_init(&master->lessee_idr);
|
|
|
|
|
2016-06-15 02:50:59 +08:00
|
|
|
return master;
|
|
|
|
}
|
|
|
|
|
2020-05-30 20:46:39 +08:00
|
|
|
static void drm_set_master(struct drm_device *dev, struct drm_file *fpriv,
|
|
|
|
bool new_master)
|
2016-06-21 20:20:38 +08:00
|
|
|
{
|
|
|
|
dev->master = drm_master_get(fpriv->master);
|
2020-05-30 20:46:39 +08:00
|
|
|
if (dev->driver->master_set)
|
|
|
|
dev->driver->master_set(dev, fpriv, new_master);
|
2016-06-21 20:20:38 +08:00
|
|
|
|
2020-05-30 20:46:39 +08:00
|
|
|
fpriv->was_master = true;
|
2016-06-21 20:20:38 +08:00
|
|
|
}
|
|
|
|
|
2016-06-15 02:51:00 +08:00
|
|
|
static int drm_new_set_master(struct drm_device *dev, struct drm_file *fpriv)
|
2016-06-15 02:50:59 +08:00
|
|
|
{
|
|
|
|
struct drm_master *old_master;
|
drm: serialize drm_file.master with a new spinlock
Currently, drm_file.master pointers should be protected by
drm_device.master_mutex when being dereferenced. This is because
drm_file.master is not invariant for the lifetime of drm_file. If
drm_file is not the creator of master, then drm_file.is_master is
false, and a call to drm_setmaster_ioctl will invoke
drm_new_set_master, which then allocates a new master for drm_file and
puts the old master.
Thus, without holding drm_device.master_mutex, the old value of
drm_file.master could be freed while it is being used by another
concurrent process.
However, it is not always possible to lock drm_device.master_mutex to
dereference drm_file.master. Through the fbdev emulation code, this
might occur in a deep nest of other locks. But drm_device.master_mutex
is also the outermost lock in the nesting hierarchy, so this leads to
potential deadlocks.
To address this, we introduce a new spin lock at the bottom of the
lock hierarchy that only serializes drm_file.master. With this change,
the value of drm_file.master changes only when both
drm_device.master_mutex and drm_file.master_lookup_lock are
held. Hence, any process holding either of those locks can ensure that
the value of drm_file.master will not change concurrently.
Since no lock depends on the new drm_file.master_lookup_lock, when
drm_file.master is dereferenced, but drm_device.master_mutex cannot be
held, we can safely protect the master pointer with
drm_file.master_lookup_lock.
Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210712043508.11584-5-desmondcheongzx@gmail.com
2021-07-12 12:35:07 +08:00
|
|
|
struct drm_master *new_master;
|
2016-06-15 02:50:59 +08:00
|
|
|
|
|
|
|
lockdep_assert_held_once(&dev->master_mutex);
|
|
|
|
|
2018-11-22 13:33:29 +08:00
|
|
|
WARN_ON(fpriv->is_master);
|
2016-06-15 02:50:59 +08:00
|
|
|
old_master = fpriv->master;
|
drm: serialize drm_file.master with a new spinlock
Currently, drm_file.master pointers should be protected by
drm_device.master_mutex when being dereferenced. This is because
drm_file.master is not invariant for the lifetime of drm_file. If
drm_file is not the creator of master, then drm_file.is_master is
false, and a call to drm_setmaster_ioctl will invoke
drm_new_set_master, which then allocates a new master for drm_file and
puts the old master.
Thus, without holding drm_device.master_mutex, the old value of
drm_file.master could be freed while it is being used by another
concurrent process.
However, it is not always possible to lock drm_device.master_mutex to
dereference drm_file.master. Through the fbdev emulation code, this
might occur in a deep nest of other locks. But drm_device.master_mutex
is also the outermost lock in the nesting hierarchy, so this leads to
potential deadlocks.
To address this, we introduce a new spin lock at the bottom of the
lock hierarchy that only serializes drm_file.master. With this change,
the value of drm_file.master changes only when both
drm_device.master_mutex and drm_file.master_lookup_lock are
held. Hence, any process holding either of those locks can ensure that
the value of drm_file.master will not change concurrently.
Since no lock depends on the new drm_file.master_lookup_lock, when
drm_file.master is dereferenced, but drm_device.master_mutex cannot be
held, we can safely protect the master pointer with
drm_file.master_lookup_lock.
Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210712043508.11584-5-desmondcheongzx@gmail.com
2021-07-12 12:35:07 +08:00
|
|
|
new_master = drm_master_create(dev);
|
|
|
|
if (!new_master)
|
2016-06-21 20:20:38 +08:00
|
|
|
return -ENOMEM;
|
drm: serialize drm_file.master with a new spinlock
Currently, drm_file.master pointers should be protected by
drm_device.master_mutex when being dereferenced. This is because
drm_file.master is not invariant for the lifetime of drm_file. If
drm_file is not the creator of master, then drm_file.is_master is
false, and a call to drm_setmaster_ioctl will invoke
drm_new_set_master, which then allocates a new master for drm_file and
puts the old master.
Thus, without holding drm_device.master_mutex, the old value of
drm_file.master could be freed while it is being used by another
concurrent process.
However, it is not always possible to lock drm_device.master_mutex to
dereference drm_file.master. Through the fbdev emulation code, this
might occur in a deep nest of other locks. But drm_device.master_mutex
is also the outermost lock in the nesting hierarchy, so this leads to
potential deadlocks.
To address this, we introduce a new spin lock at the bottom of the
lock hierarchy that only serializes drm_file.master. With this change,
the value of drm_file.master changes only when both
drm_device.master_mutex and drm_file.master_lookup_lock are
held. Hence, any process holding either of those locks can ensure that
the value of drm_file.master will not change concurrently.
Since no lock depends on the new drm_file.master_lookup_lock, when
drm_file.master is dereferenced, but drm_device.master_mutex cannot be
held, we can safely protect the master pointer with
drm_file.master_lookup_lock.
Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210712043508.11584-5-desmondcheongzx@gmail.com
2021-07-12 12:35:07 +08:00
|
|
|
spin_lock(&fpriv->master_lookup_lock);
|
|
|
|
fpriv->master = new_master;
|
|
|
|
spin_unlock(&fpriv->master_lookup_lock);
|
2016-06-15 02:50:59 +08:00
|
|
|
|
2016-06-21 16:54:21 +08:00
|
|
|
fpriv->is_master = 1;
|
2016-06-15 02:50:59 +08:00
|
|
|
fpriv->authenticated = 1;
|
2016-06-21 20:20:38 +08:00
|
|
|
|
2020-05-30 20:46:39 +08:00
|
|
|
drm_set_master(dev, fpriv, true);
|
2016-06-21 20:20:38 +08:00
|
|
|
|
2016-06-15 02:50:59 +08:00
|
|
|
if (old_master)
|
|
|
|
drm_master_put(&old_master);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-03-20 01:29:29 +08:00
|
|
|
/*
|
|
|
|
* In the olden days the SET/DROP_MASTER ioctls used to return EACCES when
|
|
|
|
* CAP_SYS_ADMIN was not set. This was used to prevent rogue applications
|
|
|
|
* from becoming master and/or failing to release it.
|
|
|
|
*
|
|
|
|
* At the same time, the first client (for a given VT) is _always_ master.
|
|
|
|
* Thus in order for the ioctls to succeed, one had to _explicitly_ run the
|
|
|
|
* application as root or flip the setuid bit.
|
|
|
|
*
|
|
|
|
* If the CAP_SYS_ADMIN was missing, no other client could become master...
|
|
|
|
* EVER :-( Leading to a) the graphics session dying badly or b) a completely
|
|
|
|
* locked session.
|
|
|
|
*
|
|
|
|
*
|
|
|
|
* As some point systemd-logind was introduced to orchestrate and delegate
|
|
|
|
* master as applicable. It does so by opening the fd and passing it to users
|
|
|
|
* while in itself logind a) does the set/drop master per users' request and
|
|
|
|
* b) * implicitly drops master on VT switch.
|
|
|
|
*
|
|
|
|
* Even though logind looks like the future, there are a few issues:
|
|
|
|
* - some platforms don't have equivalent (Android, CrOS, some BSDs) so
|
|
|
|
* root is required _solely_ for SET/DROP MASTER.
|
|
|
|
* - applications may not be updated to use it,
|
|
|
|
* - any client which fails to drop master* can DoS the application using
|
|
|
|
* logind, to a varying degree.
|
|
|
|
*
|
|
|
|
* * Either due missing CAP_SYS_ADMIN or simply not calling DROP_MASTER.
|
|
|
|
*
|
|
|
|
*
|
|
|
|
* Here we implement the next best thing:
|
|
|
|
* - ensure the logind style of fd passing works unchanged, and
|
|
|
|
* - allow a client to drop/set master, iff it is/was master at a given point
|
|
|
|
* in time.
|
|
|
|
*
|
|
|
|
* Note: DROP_MASTER cannot be free for all, as an arbitrator user could:
|
|
|
|
* - DoS/crash the arbitrator - details would be implementation specific
|
|
|
|
* - open the node, become master implicitly and cause issues
|
|
|
|
*
|
|
|
|
* As a result this fixes the following when using root-less build w/o logind
|
|
|
|
* - startx
|
|
|
|
* - weston
|
|
|
|
* - various compositors based on wlroots
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
drm_master_check_perm(struct drm_device *dev, struct drm_file *file_priv)
|
|
|
|
{
|
|
|
|
if (file_priv->pid == task_pid(current) && file_priv->was_master)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (!capable(CAP_SYS_ADMIN))
|
|
|
|
return -EACCES;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-06-15 02:50:59 +08:00
|
|
|
int drm_setmaster_ioctl(struct drm_device *dev, void *data,
|
|
|
|
struct drm_file *file_priv)
|
|
|
|
{
|
2020-05-30 20:46:40 +08:00
|
|
|
int ret;
|
2016-06-15 02:50:59 +08:00
|
|
|
|
|
|
|
mutex_lock(&dev->master_mutex);
|
2020-03-20 01:29:29 +08:00
|
|
|
|
|
|
|
ret = drm_master_check_perm(dev, file_priv);
|
|
|
|
if (ret)
|
|
|
|
goto out_unlock;
|
|
|
|
|
2021-07-12 12:35:06 +08:00
|
|
|
if (drm_is_current_master_locked(file_priv))
|
2016-06-15 02:50:59 +08:00
|
|
|
goto out_unlock;
|
|
|
|
|
2016-06-21 16:54:12 +08:00
|
|
|
if (dev->master) {
|
2020-03-20 01:29:30 +08:00
|
|
|
ret = -EBUSY;
|
2016-06-15 02:50:59 +08:00
|
|
|
goto out_unlock;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!file_priv->master) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_unlock;
|
|
|
|
}
|
|
|
|
|
2016-06-21 16:54:21 +08:00
|
|
|
if (!file_priv->is_master) {
|
2016-06-15 02:50:59 +08:00
|
|
|
ret = drm_new_set_master(dev, file_priv);
|
|
|
|
goto out_unlock;
|
|
|
|
}
|
|
|
|
|
drm: Add drm_object lease infrastructure [v5]
This provides new data structures to hold "lease" information about
drm mode setting objects, and provides for creating new drm_masters
which have access to a subset of the available drm resources.
An 'owner' is a drm_master which is not leasing the objects from
another drm_master, and hence 'owns' them.
A 'lessee' is a drm_master which is leasing objects from some other
drm_master. Each lessee holds the set of objects which it is leasing
from the lessor.
A 'lessor' is a drm_master which is leasing objects to another
drm_master. This is the same as the owner in the current code.
The set of objects any drm_master 'controls' is limited to the set of
objects it leases (for lessees) or all objects (for owners).
Objects not controlled by a drm_master cannot be modified through the
various state manipulating ioctls, and any state reported back to user
space will be edited to make them appear idle and/or unusable. For
instance, connectors always report 'disconnected', while encoders
report no possible crtcs or clones.
The full list of lessees leasing objects from an owner (either
directly, or indirectly through another lessee), can be searched from
an idr in the drm_master of the owner.
Changes for v2 as suggested by Daniel Vetter <daniel.vetter@ffwll.ch>:
* Sub-leasing has been disabled.
* BUG_ON for lock checking replaced with lockdep_assert_held
* 'change' ioctl has been removed.
* Leased objects can always be controlled by the lessor; the
'mask_lease' flag has been removed
* Checking for leased status has been simplified, replacing
the drm_lease_check function with drm_lease_held.
Changes in v3, some suggested by Dave Airlie <airlied@gmail.com>
* Add revocation. This allows leases to be effectively revoked by
removing all of the objects they have access to. The lease itself
hangs around as it's hanging off a file.
* Free the leases IDR when the master is destroyed
* _drm_lease_held should look at lessees, not lessor
* Allow non-master files to check for lease status
Changes in v4, suggested by Dave Airlie <airlied@gmail.com>
* Formatting and whitespace changes
Changes in v5 (airlied)
* check DRIVER_MODESET before lease destroy call
* check DRIVER_MODESET for lease revoke (Chris)
* Use idr_mutex uniformly for all lease elements of struct drm_master. (Keith)
Signed-off-by: Keith Packard <keithp@keithp.com>
2017-03-15 13:26:41 +08:00
|
|
|
if (file_priv->master->lessor != NULL) {
|
|
|
|
DRM_DEBUG_LEASE("Attempt to set lessee %d as master\n", file_priv->master->lessee_id);
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_unlock;
|
|
|
|
}
|
|
|
|
|
2020-05-30 20:46:39 +08:00
|
|
|
drm_set_master(dev, file_priv, false);
|
2016-06-15 02:50:59 +08:00
|
|
|
out_unlock:
|
|
|
|
mutex_unlock(&dev->master_mutex);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2016-06-21 20:20:38 +08:00
|
|
|
static void drm_drop_master(struct drm_device *dev,
|
|
|
|
struct drm_file *fpriv)
|
|
|
|
{
|
|
|
|
if (dev->driver->master_drop)
|
|
|
|
dev->driver->master_drop(dev, fpriv);
|
|
|
|
drm_master_put(&dev->master);
|
|
|
|
}
|
|
|
|
|
2016-06-15 02:50:59 +08:00
|
|
|
int drm_dropmaster_ioctl(struct drm_device *dev, void *data,
|
|
|
|
struct drm_file *file_priv)
|
|
|
|
{
|
2020-05-25 06:27:15 +08:00
|
|
|
int ret;
|
2016-06-15 02:50:59 +08:00
|
|
|
|
|
|
|
mutex_lock(&dev->master_mutex);
|
2020-03-20 01:29:29 +08:00
|
|
|
|
|
|
|
ret = drm_master_check_perm(dev, file_priv);
|
|
|
|
if (ret)
|
|
|
|
goto out_unlock;
|
|
|
|
|
2021-07-12 12:35:06 +08:00
|
|
|
if (!drm_is_current_master_locked(file_priv)) {
|
2020-05-30 20:46:40 +08:00
|
|
|
ret = -EINVAL;
|
2016-06-15 02:50:59 +08:00
|
|
|
goto out_unlock;
|
2020-05-30 20:46:40 +08:00
|
|
|
}
|
2016-06-15 02:50:59 +08:00
|
|
|
|
2020-05-30 20:46:40 +08:00
|
|
|
if (!dev->master) {
|
|
|
|
ret = -EINVAL;
|
2016-06-15 02:50:59 +08:00
|
|
|
goto out_unlock;
|
2020-05-30 20:46:40 +08:00
|
|
|
}
|
2016-06-15 02:50:59 +08:00
|
|
|
|
2018-01-19 09:51:59 +08:00
|
|
|
if (file_priv->master->lessor != NULL) {
|
|
|
|
DRM_DEBUG_LEASE("Attempt to drop lessee %d as master\n", file_priv->master->lessee_id);
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_unlock;
|
|
|
|
}
|
|
|
|
|
2016-06-21 20:20:38 +08:00
|
|
|
drm_drop_master(dev, file_priv);
|
2016-06-15 02:50:59 +08:00
|
|
|
out_unlock:
|
|
|
|
mutex_unlock(&dev->master_mutex);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2016-06-15 02:51:00 +08:00
|
|
|
int drm_master_open(struct drm_file *file_priv)
|
|
|
|
{
|
|
|
|
struct drm_device *dev = file_priv->minor->dev;
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
/* if there is no current master make this fd it, but do not create
|
2021-04-18 22:48:22 +08:00
|
|
|
* any master object for render clients
|
|
|
|
*/
|
2016-06-15 02:51:00 +08:00
|
|
|
mutex_lock(&dev->master_mutex);
|
drm: serialize drm_file.master with a new spinlock
Currently, drm_file.master pointers should be protected by
drm_device.master_mutex when being dereferenced. This is because
drm_file.master is not invariant for the lifetime of drm_file. If
drm_file is not the creator of master, then drm_file.is_master is
false, and a call to drm_setmaster_ioctl will invoke
drm_new_set_master, which then allocates a new master for drm_file and
puts the old master.
Thus, without holding drm_device.master_mutex, the old value of
drm_file.master could be freed while it is being used by another
concurrent process.
However, it is not always possible to lock drm_device.master_mutex to
dereference drm_file.master. Through the fbdev emulation code, this
might occur in a deep nest of other locks. But drm_device.master_mutex
is also the outermost lock in the nesting hierarchy, so this leads to
potential deadlocks.
To address this, we introduce a new spin lock at the bottom of the
lock hierarchy that only serializes drm_file.master. With this change,
the value of drm_file.master changes only when both
drm_device.master_mutex and drm_file.master_lookup_lock are
held. Hence, any process holding either of those locks can ensure that
the value of drm_file.master will not change concurrently.
Since no lock depends on the new drm_file.master_lookup_lock, when
drm_file.master is dereferenced, but drm_device.master_mutex cannot be
held, we can safely protect the master pointer with
drm_file.master_lookup_lock.
Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210712043508.11584-5-desmondcheongzx@gmail.com
2021-07-12 12:35:07 +08:00
|
|
|
if (!dev->master) {
|
2016-06-15 02:51:00 +08:00
|
|
|
ret = drm_new_set_master(dev, file_priv);
|
drm: serialize drm_file.master with a new spinlock
Currently, drm_file.master pointers should be protected by
drm_device.master_mutex when being dereferenced. This is because
drm_file.master is not invariant for the lifetime of drm_file. If
drm_file is not the creator of master, then drm_file.is_master is
false, and a call to drm_setmaster_ioctl will invoke
drm_new_set_master, which then allocates a new master for drm_file and
puts the old master.
Thus, without holding drm_device.master_mutex, the old value of
drm_file.master could be freed while it is being used by another
concurrent process.
However, it is not always possible to lock drm_device.master_mutex to
dereference drm_file.master. Through the fbdev emulation code, this
might occur in a deep nest of other locks. But drm_device.master_mutex
is also the outermost lock in the nesting hierarchy, so this leads to
potential deadlocks.
To address this, we introduce a new spin lock at the bottom of the
lock hierarchy that only serializes drm_file.master. With this change,
the value of drm_file.master changes only when both
drm_device.master_mutex and drm_file.master_lookup_lock are
held. Hence, any process holding either of those locks can ensure that
the value of drm_file.master will not change concurrently.
Since no lock depends on the new drm_file.master_lookup_lock, when
drm_file.master is dereferenced, but drm_device.master_mutex cannot be
held, we can safely protect the master pointer with
drm_file.master_lookup_lock.
Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210712043508.11584-5-desmondcheongzx@gmail.com
2021-07-12 12:35:07 +08:00
|
|
|
} else {
|
|
|
|
spin_lock(&file_priv->master_lookup_lock);
|
2016-06-21 16:54:12 +08:00
|
|
|
file_priv->master = drm_master_get(dev->master);
|
drm: serialize drm_file.master with a new spinlock
Currently, drm_file.master pointers should be protected by
drm_device.master_mutex when being dereferenced. This is because
drm_file.master is not invariant for the lifetime of drm_file. If
drm_file is not the creator of master, then drm_file.is_master is
false, and a call to drm_setmaster_ioctl will invoke
drm_new_set_master, which then allocates a new master for drm_file and
puts the old master.
Thus, without holding drm_device.master_mutex, the old value of
drm_file.master could be freed while it is being used by another
concurrent process.
However, it is not always possible to lock drm_device.master_mutex to
dereference drm_file.master. Through the fbdev emulation code, this
might occur in a deep nest of other locks. But drm_device.master_mutex
is also the outermost lock in the nesting hierarchy, so this leads to
potential deadlocks.
To address this, we introduce a new spin lock at the bottom of the
lock hierarchy that only serializes drm_file.master. With this change,
the value of drm_file.master changes only when both
drm_device.master_mutex and drm_file.master_lookup_lock are
held. Hence, any process holding either of those locks can ensure that
the value of drm_file.master will not change concurrently.
Since no lock depends on the new drm_file.master_lookup_lock, when
drm_file.master is dereferenced, but drm_device.master_mutex cannot be
held, we can safely protect the master pointer with
drm_file.master_lookup_lock.
Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210712043508.11584-5-desmondcheongzx@gmail.com
2021-07-12 12:35:07 +08:00
|
|
|
spin_unlock(&file_priv->master_lookup_lock);
|
|
|
|
}
|
2016-06-15 02:51:00 +08:00
|
|
|
mutex_unlock(&dev->master_mutex);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2016-06-15 02:51:01 +08:00
|
|
|
void drm_master_release(struct drm_file *file_priv)
|
|
|
|
{
|
|
|
|
struct drm_device *dev = file_priv->minor->dev;
|
2021-06-09 17:21:19 +08:00
|
|
|
struct drm_master *master;
|
2016-06-15 02:51:01 +08:00
|
|
|
|
2016-06-17 15:33:21 +08:00
|
|
|
mutex_lock(&dev->master_mutex);
|
2021-06-09 17:21:19 +08:00
|
|
|
master = file_priv->master;
|
2016-06-17 15:33:20 +08:00
|
|
|
if (file_priv->magic)
|
|
|
|
idr_remove(&file_priv->master->magic_map, file_priv->magic);
|
|
|
|
|
2021-07-12 12:35:06 +08:00
|
|
|
if (!drm_is_current_master_locked(file_priv))
|
2016-06-17 15:33:19 +08:00
|
|
|
goto out;
|
2016-06-15 02:51:01 +08:00
|
|
|
|
2019-04-23 07:36:54 +08:00
|
|
|
drm_legacy_lock_master_cleanup(dev, master);
|
2016-06-15 02:51:01 +08:00
|
|
|
|
2016-06-21 20:20:38 +08:00
|
|
|
if (dev->master == file_priv->master)
|
|
|
|
drm_drop_master(dev, file_priv);
|
2016-06-17 15:33:19 +08:00
|
|
|
out:
|
drm: Add drm_object lease infrastructure [v5]
This provides new data structures to hold "lease" information about
drm mode setting objects, and provides for creating new drm_masters
which have access to a subset of the available drm resources.
An 'owner' is a drm_master which is not leasing the objects from
another drm_master, and hence 'owns' them.
A 'lessee' is a drm_master which is leasing objects from some other
drm_master. Each lessee holds the set of objects which it is leasing
from the lessor.
A 'lessor' is a drm_master which is leasing objects to another
drm_master. This is the same as the owner in the current code.
The set of objects any drm_master 'controls' is limited to the set of
objects it leases (for lessees) or all objects (for owners).
Objects not controlled by a drm_master cannot be modified through the
various state manipulating ioctls, and any state reported back to user
space will be edited to make them appear idle and/or unusable. For
instance, connectors always report 'disconnected', while encoders
report no possible crtcs or clones.
The full list of lessees leasing objects from an owner (either
directly, or indirectly through another lessee), can be searched from
an idr in the drm_master of the owner.
Changes for v2 as suggested by Daniel Vetter <daniel.vetter@ffwll.ch>:
* Sub-leasing has been disabled.
* BUG_ON for lock checking replaced with lockdep_assert_held
* 'change' ioctl has been removed.
* Leased objects can always be controlled by the lessor; the
'mask_lease' flag has been removed
* Checking for leased status has been simplified, replacing
the drm_lease_check function with drm_lease_held.
Changes in v3, some suggested by Dave Airlie <airlied@gmail.com>
* Add revocation. This allows leases to be effectively revoked by
removing all of the objects they have access to. The lease itself
hangs around as it's hanging off a file.
* Free the leases IDR when the master is destroyed
* _drm_lease_held should look at lessees, not lessor
* Allow non-master files to check for lease status
Changes in v4, suggested by Dave Airlie <airlied@gmail.com>
* Formatting and whitespace changes
Changes in v5 (airlied)
* check DRIVER_MODESET before lease destroy call
* check DRIVER_MODESET for lease revoke (Chris)
* Use idr_mutex uniformly for all lease elements of struct drm_master. (Keith)
Signed-off-by: Keith Packard <keithp@keithp.com>
2017-03-15 13:26:41 +08:00
|
|
|
if (drm_core_check_feature(dev, DRIVER_MODESET) && file_priv->is_master) {
|
|
|
|
/* Revoke any leases held by this or lessees, but only if
|
|
|
|
* this is the "real" master
|
|
|
|
*/
|
|
|
|
drm_lease_revoke(master);
|
|
|
|
}
|
|
|
|
|
2016-06-15 02:51:01 +08:00
|
|
|
/* drop the master reference held by the file priv */
|
|
|
|
if (file_priv->master)
|
|
|
|
drm_master_put(&file_priv->master);
|
|
|
|
mutex_unlock(&dev->master_mutex);
|
|
|
|
}
|
|
|
|
|
2016-06-21 16:54:22 +08:00
|
|
|
/**
|
|
|
|
* drm_master_get - reference a master pointer
|
2016-12-30 04:48:26 +08:00
|
|
|
* @master: &struct drm_master
|
2016-06-21 16:54:22 +08:00
|
|
|
*
|
|
|
|
* Increments the reference count of @master and returns a pointer to @master.
|
|
|
|
*/
|
2016-06-15 02:50:59 +08:00
|
|
|
struct drm_master *drm_master_get(struct drm_master *master)
|
|
|
|
{
|
|
|
|
kref_get(&master->refcount);
|
|
|
|
return master;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_master_get);
|
|
|
|
|
2021-07-12 12:35:08 +08:00
|
|
|
/**
|
|
|
|
* drm_file_get_master - reference &drm_file.master of @file_priv
|
|
|
|
* @file_priv: DRM file private
|
|
|
|
*
|
|
|
|
* Increments the reference count of @file_priv's &drm_file.master and returns
|
|
|
|
* the &drm_file.master. If @file_priv has no &drm_file.master, returns NULL.
|
|
|
|
*
|
|
|
|
* Master pointers returned from this function should be unreferenced using
|
|
|
|
* drm_master_put().
|
|
|
|
*/
|
|
|
|
struct drm_master *drm_file_get_master(struct drm_file *file_priv)
|
|
|
|
{
|
|
|
|
struct drm_master *master = NULL;
|
|
|
|
|
|
|
|
spin_lock(&file_priv->master_lookup_lock);
|
|
|
|
if (!file_priv->master)
|
|
|
|
goto unlock;
|
|
|
|
master = drm_master_get(file_priv->master);
|
|
|
|
|
|
|
|
unlock:
|
|
|
|
spin_unlock(&file_priv->master_lookup_lock);
|
|
|
|
return master;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_file_get_master);
|
|
|
|
|
2016-06-15 02:50:59 +08:00
|
|
|
static void drm_master_destroy(struct kref *kref)
|
|
|
|
{
|
|
|
|
struct drm_master *master = container_of(kref, struct drm_master, refcount);
|
|
|
|
struct drm_device *dev = master->dev;
|
|
|
|
|
drm: Add drm_object lease infrastructure [v5]
This provides new data structures to hold "lease" information about
drm mode setting objects, and provides for creating new drm_masters
which have access to a subset of the available drm resources.
An 'owner' is a drm_master which is not leasing the objects from
another drm_master, and hence 'owns' them.
A 'lessee' is a drm_master which is leasing objects from some other
drm_master. Each lessee holds the set of objects which it is leasing
from the lessor.
A 'lessor' is a drm_master which is leasing objects to another
drm_master. This is the same as the owner in the current code.
The set of objects any drm_master 'controls' is limited to the set of
objects it leases (for lessees) or all objects (for owners).
Objects not controlled by a drm_master cannot be modified through the
various state manipulating ioctls, and any state reported back to user
space will be edited to make them appear idle and/or unusable. For
instance, connectors always report 'disconnected', while encoders
report no possible crtcs or clones.
The full list of lessees leasing objects from an owner (either
directly, or indirectly through another lessee), can be searched from
an idr in the drm_master of the owner.
Changes for v2 as suggested by Daniel Vetter <daniel.vetter@ffwll.ch>:
* Sub-leasing has been disabled.
* BUG_ON for lock checking replaced with lockdep_assert_held
* 'change' ioctl has been removed.
* Leased objects can always be controlled by the lessor; the
'mask_lease' flag has been removed
* Checking for leased status has been simplified, replacing
the drm_lease_check function with drm_lease_held.
Changes in v3, some suggested by Dave Airlie <airlied@gmail.com>
* Add revocation. This allows leases to be effectively revoked by
removing all of the objects they have access to. The lease itself
hangs around as it's hanging off a file.
* Free the leases IDR when the master is destroyed
* _drm_lease_held should look at lessees, not lessor
* Allow non-master files to check for lease status
Changes in v4, suggested by Dave Airlie <airlied@gmail.com>
* Formatting and whitespace changes
Changes in v5 (airlied)
* check DRIVER_MODESET before lease destroy call
* check DRIVER_MODESET for lease revoke (Chris)
* Use idr_mutex uniformly for all lease elements of struct drm_master. (Keith)
Signed-off-by: Keith Packard <keithp@keithp.com>
2017-03-15 13:26:41 +08:00
|
|
|
if (drm_core_check_feature(dev, DRIVER_MODESET))
|
|
|
|
drm_lease_destroy(master);
|
|
|
|
|
2016-06-15 02:50:59 +08:00
|
|
|
drm_legacy_master_rmmaps(dev, master);
|
|
|
|
|
|
|
|
idr_destroy(&master->magic_map);
|
drm: Add drm_object lease infrastructure [v5]
This provides new data structures to hold "lease" information about
drm mode setting objects, and provides for creating new drm_masters
which have access to a subset of the available drm resources.
An 'owner' is a drm_master which is not leasing the objects from
another drm_master, and hence 'owns' them.
A 'lessee' is a drm_master which is leasing objects from some other
drm_master. Each lessee holds the set of objects which it is leasing
from the lessor.
A 'lessor' is a drm_master which is leasing objects to another
drm_master. This is the same as the owner in the current code.
The set of objects any drm_master 'controls' is limited to the set of
objects it leases (for lessees) or all objects (for owners).
Objects not controlled by a drm_master cannot be modified through the
various state manipulating ioctls, and any state reported back to user
space will be edited to make them appear idle and/or unusable. For
instance, connectors always report 'disconnected', while encoders
report no possible crtcs or clones.
The full list of lessees leasing objects from an owner (either
directly, or indirectly through another lessee), can be searched from
an idr in the drm_master of the owner.
Changes for v2 as suggested by Daniel Vetter <daniel.vetter@ffwll.ch>:
* Sub-leasing has been disabled.
* BUG_ON for lock checking replaced with lockdep_assert_held
* 'change' ioctl has been removed.
* Leased objects can always be controlled by the lessor; the
'mask_lease' flag has been removed
* Checking for leased status has been simplified, replacing
the drm_lease_check function with drm_lease_held.
Changes in v3, some suggested by Dave Airlie <airlied@gmail.com>
* Add revocation. This allows leases to be effectively revoked by
removing all of the objects they have access to. The lease itself
hangs around as it's hanging off a file.
* Free the leases IDR when the master is destroyed
* _drm_lease_held should look at lessees, not lessor
* Allow non-master files to check for lease status
Changes in v4, suggested by Dave Airlie <airlied@gmail.com>
* Formatting and whitespace changes
Changes in v5 (airlied)
* check DRIVER_MODESET before lease destroy call
* check DRIVER_MODESET for lease revoke (Chris)
* Use idr_mutex uniformly for all lease elements of struct drm_master. (Keith)
Signed-off-by: Keith Packard <keithp@keithp.com>
2017-03-15 13:26:41 +08:00
|
|
|
idr_destroy(&master->leases);
|
|
|
|
idr_destroy(&master->lessee_idr);
|
|
|
|
|
2016-06-15 02:50:59 +08:00
|
|
|
kfree(master->unique);
|
|
|
|
kfree(master);
|
|
|
|
}
|
|
|
|
|
2016-06-21 16:54:22 +08:00
|
|
|
/**
|
|
|
|
* drm_master_put - unreference and clear a master pointer
|
2016-12-30 04:48:26 +08:00
|
|
|
* @master: pointer to a pointer of &struct drm_master
|
2016-06-21 16:54:22 +08:00
|
|
|
*
|
|
|
|
* This decrements the &drm_master behind @master and sets it to NULL.
|
|
|
|
*/
|
2016-06-15 02:50:59 +08:00
|
|
|
void drm_master_put(struct drm_master **master)
|
|
|
|
{
|
|
|
|
kref_put(&(*master)->refcount, drm_master_destroy);
|
|
|
|
*master = NULL;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_master_put);
|
2019-05-07 02:01:30 +08:00
|
|
|
|
|
|
|
/* Used by drm_client and drm_fb_helper */
|
|
|
|
bool drm_master_internal_acquire(struct drm_device *dev)
|
|
|
|
{
|
|
|
|
mutex_lock(&dev->master_mutex);
|
|
|
|
if (dev->master) {
|
|
|
|
mutex_unlock(&dev->master_mutex);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_master_internal_acquire);
|
|
|
|
|
|
|
|
/* Used by drm_client and drm_fb_helper */
|
|
|
|
void drm_master_internal_release(struct drm_device *dev)
|
|
|
|
{
|
|
|
|
mutex_unlock(&dev->master_mutex);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(drm_master_internal_release);
|