mindspore/.gitee/PULL_REQUEST_TEMPLATE.en.md

2.8 KiB

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug /kind task /kind feature

What does this PR do / why do we need it:

Which issue(s) this PR fixes:

Fixes #

Code review checklist [illustration]:

  • Typical problems of security coding [historical security coding cases reference]
    • whether to verify the pointer is null/nullptr
    • whether to verify the function's return value (It is forbidden to use void to mask the return values of security functions and self-developed functions. C++ STL functions can be masked if there is no problem)
    • whether new/malloc memory is released correctly
  • Performance analysis (if a sub-item is involved, please outline the implementation idea or modification content)
    • whether to modify hotspot function / algorithm / operation
    • whether to consider concurrent scenarios
    • whether to consider communication scenario
    • Whether to comply with SOLID principle / Demeter's law
    • Whether the interaction between modules / features is involved (if yes, please outline the implementation ideas)
    • Whether there is UT test case && the test case is a valid (if there is no test case, please explain the reason)
    • whether the secret key is loaded/released correctly
  • Error handling and recording
    • whether the interface exception scenarios are fully considered
    • whether the error is recorded appropriately

Special notes for your reviewers: