From 3251cf057146c20db5a50ac8513a3b797c938ba2 Mon Sep 17 00:00:00 2001 From: liuchongming Date: Mon, 25 Jul 2022 08:19:42 +0800 Subject: [PATCH] Update checking function return value item. --- .gitee/PULL_REQUEST_TEMPLATE.en.md | 2 +- .gitee/PULL_REQUEST_TEMPLATE.zh-CN.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitee/PULL_REQUEST_TEMPLATE.en.md b/.gitee/PULL_REQUEST_TEMPLATE.en.md index b51bb2b18ee..e830e40bf70 100644 --- a/.gitee/PULL_REQUEST_TEMPLATE.en.md +++ b/.gitee/PULL_REQUEST_TEMPLATE.en.md @@ -27,7 +27,7 @@ Fixes # - **Typical problems of security coding [[historical security coding cases reference]](https://gitee.com/mindspore/community/blob/master/security/security_coding_violation_cases.md)** - [ ] whether to verify the pointer is null/nullptr - - [ ] whether to verify the function's return value + - [ ] whether to verify the function's return value (It is forbidden to use void to mask the return values of security functions and self-developed functions. C++ STL functions can be masked if there is no problem) - [ ] whether new/malloc memory is released correctly - **Performance analysis (if a sub-item is involved, please outline the implementation idea or modification content)** - [ ] whether to modify hotspot ***function / algorithm / operation*** diff --git a/.gitee/PULL_REQUEST_TEMPLATE.zh-CN.md b/.gitee/PULL_REQUEST_TEMPLATE.zh-CN.md index cd3f786af61..0c3f868e2c3 100644 --- a/.gitee/PULL_REQUEST_TEMPLATE.zh-CN.md +++ b/.gitee/PULL_REQUEST_TEMPLATE.zh-CN.md @@ -27,7 +27,7 @@ Fixes # - **典型安全编码问题 [【违反安全编码案例】](https://gitee.com/mindspore/community/blob/master/security/security_coding_violation_cases.md)** - [ ] 是否进行空指针校验 - - [ ] 是否进行返回值校验 (禁止使用void屏蔽函数返回值) + - [ ] 是否进行返回值校验 (禁止使用void屏蔽安全函数、自研函数返回值，C++标准库函数确认无问题可以屏蔽) - [ ] 是否正确释放new/malloc申请的内存 - **性能分析 (如果涉及某个子项，请概述设计思想/修改内容)** - [ ] 是否修改热点***函数 / 算法 / 算子***