gitlink-cli/shortcuts/label/label_test.go

432 lines
13 KiB
Go

package label
import (
"encoding/json"
"net/http"
"net/http/httptest"
"testing"
"github.com/gitlink-org/gitlink-cli/internal/client"
"github.com/gitlink-org/gitlink-cli/shortcuts/common"
)
func TestLabelList(t *testing.T) {
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
assertRequest(t, r, "GET", "/v1/owner/repo/issue_tags.json")
if got := r.URL.Query().Get("keyword"); got != "bug" {
t.Fatalf("got keyword %q, want %q", got, "bug")
}
if got := r.URL.Query().Get("order_by"); got != "issues_count" {
t.Fatalf("got order_by %q, want %q", got, "issues_count")
}
writeJSON(t, w, map[string]interface{}{"total_count": 0, "issue_tags": []interface{}{}})
})
defer server.Close()
err := runLabelShortcut(t, server, "list", map[string]string{
"keyword": "bug",
"sort-by": "issues_count",
})
if err != nil {
t.Fatalf("list shortcut failed: %v", err)
}
}
func TestLabelCreatePayload(t *testing.T) {
var payload map[string]interface{}
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
assertRequest(t, r, "POST", "/v1/owner/repo/issue_tags.json")
payload = decodeJSON(t, r)
writeJSON(t, w, map[string]interface{}{"status": 0, "message": "success"})
})
defer server.Close()
err := runLabelShortcut(t, server, "create", map[string]string{
"name": "bug",
"description": "Something is broken",
"color": "#FF0000",
})
if err != nil {
t.Fatalf("create shortcut failed: %v", err)
}
assertEqual(t, payload["name"], "bug")
assertEqual(t, payload["description"], "Something is broken")
assertEqual(t, payload["color"], "#FF0000")
}
func TestLabelCreateUsesDefaultColor(t *testing.T) {
var payload map[string]interface{}
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
assertRequest(t, r, "POST", "/v1/owner/repo/issue_tags.json")
payload = decodeJSON(t, r)
writeJSON(t, w, map[string]interface{}{"status": 0, "message": "success"})
})
defer server.Close()
if err := runLabelShortcut(t, server, "create", map[string]string{"name": "enhancement"}); err != nil {
t.Fatalf("create shortcut failed: %v", err)
}
assertEqual(t, payload["color"], defaultLabelColor)
}
func TestLabelCreateRejectsInvalidColor(t *testing.T) {
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
t.Fatalf("invalid color should not call API, got: %s %s", r.Method, r.URL.Path)
})
defer server.Close()
err := runLabelShortcut(t, server, "create", map[string]string{
"name": "bug",
"color": "red",
})
if err == nil {
t.Fatal("expected invalid color to return an error")
}
}
func TestLabelUpdatePreservesCurrentFields(t *testing.T) {
var payload map[string]interface{}
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
switch {
case r.Method == "GET" && r.URL.Path == "/v1/owner/repo/issue_tags.json":
writeJSON(t, w, map[string]interface{}{
"total_count": 1,
"issue_tags": []interface{}{
map[string]interface{}{
"id": float64(7),
"name": "bug",
"description": "old description",
"color": "#FF0000",
},
},
})
case r.Method == "PATCH" && r.URL.Path == "/v1/owner/repo/issue_tags/7.json":
payload = decodeJSON(t, r)
writeJSON(t, w, map[string]interface{}{"status": 0, "message": "success"})
default:
t.Fatalf("unexpected request: %s %s", r.Method, r.URL.Path)
}
})
defer server.Close()
err := runLabelShortcut(t, server, "update", map[string]string{
"id": "7",
"color": "#00FF00",
})
if err != nil {
t.Fatalf("update shortcut failed: %v", err)
}
// name and description preserved from current; only color changed.
assertEqual(t, payload["name"], "bug")
assertEqual(t, payload["description"], "old description")
assertEqual(t, payload["color"], "#00FF00")
}
func TestLabelUpdateRequiresAtLeastOneField(t *testing.T) {
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
t.Fatalf("update with no fields should not call API, got: %s %s", r.Method, r.URL.Path)
})
defer server.Close()
err := runLabelShortcut(t, server, "update", map[string]string{"id": "7"})
if err == nil {
t.Fatal("expected update with no fields to return an error")
}
}
func TestLabelDelete(t *testing.T) {
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
assertRequest(t, r, "DELETE", "/v1/owner/repo/issue_tags/7.json")
writeJSON(t, w, map[string]interface{}{"status": 0, "message": "success"})
})
defer server.Close()
if err := runLabelShortcut(t, server, "delete", map[string]string{"id": "7", "yes": "true"}); err != nil {
t.Fatalf("delete shortcut failed: %v", err)
}
}
func TestLabelDeleteDryRunDoesNotCallAPI(t *testing.T) {
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
t.Fatalf("delete dry-run should not call API, got: %s %s", r.Method, r.URL.Path)
})
defer server.Close()
if err := runLabelShortcut(t, server, "delete", map[string]string{"id": "7", "dry-run": "true"}); err != nil {
t.Fatalf("delete dry-run failed: %v", err)
}
}
func TestLabelDeleteRequiresYes(t *testing.T) {
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
t.Fatalf("delete without --yes should not call API, got: %s %s", r.Method, r.URL.Path)
})
defer server.Close()
err := runLabelShortcut(t, server, "delete", map[string]string{"id": "7"})
if err == nil {
t.Fatal("expected delete to require --yes")
}
}
func TestLabelBatchCreateDryRunDoesNotCallAPI(t *testing.T) {
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
t.Fatalf("batch-create dry-run should not call API, got: %s %s", r.Method, r.URL.Path)
})
defer server.Close()
err := runLabelShortcut(t, server, "batch-create", map[string]string{
"labels": "bug:#ee0701:Bug fixes;feature:#0075ca:New features",
"dry-run": "true",
})
if err != nil {
t.Fatalf("batch-create dry-run failed: %v", err)
}
}
func TestLabelBatchCreateDefaultsToDryRunWithoutYes(t *testing.T) {
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
t.Fatalf("batch-create without --yes should not call API, got: %s %s", r.Method, r.URL.Path)
})
defer server.Close()
err := runLabelShortcut(t, server, "batch-create", map[string]string{
"labels": "bug:#ee0701:Bug fixes",
})
if err != nil {
t.Fatalf("batch-create default dry-run failed: %v", err)
}
}
func TestLabelBatchCreateWithYesCallsEndpoints(t *testing.T) {
var payloads []map[string]interface{}
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
assertRequest(t, r, "POST", "/v1/owner/repo/issue_tags.json")
payloads = append(payloads, decodeJSON(t, r))
writeJSON(t, w, map[string]interface{}{"status": 0, "message": "success"})
})
defer server.Close()
err := runLabelShortcut(t, server, "batch-create", map[string]string{
"labels": "bug:#ee0701:Bug fixes;feature:#0075ca:New features",
"yes": "true",
})
if err != nil {
t.Fatalf("batch-create failed: %v", err)
}
if len(payloads) != 2 {
t.Fatalf("got %d payloads, want 2", len(payloads))
}
assertEqual(t, payloads[0]["name"], "bug")
assertEqual(t, payloads[0]["color"], "#ee0701")
assertEqual(t, payloads[0]["description"], "Bug fixes")
assertEqual(t, payloads[1]["name"], "feature")
}
func TestLabelBatchCreateReportsPartialFailure(t *testing.T) {
calls := 0
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
assertRequest(t, r, "POST", "/v1/owner/repo/issue_tags.json")
calls++
if calls == 2 {
w.WriteHeader(http.StatusInternalServerError)
w.Write([]byte("server error"))
return
}
writeJSON(t, w, map[string]interface{}{"status": 0, "message": "success"})
})
defer server.Close()
err := runLabelShortcut(t, server, "batch-create", map[string]string{
"labels": "bug:#ee0701:Bug fixes;feature:#0075ca:New features",
"yes": "true",
})
if err == nil {
t.Fatal("expected partial failure to return an error")
}
if calls != 2 {
t.Fatalf("got %d calls, want 2", calls)
}
}
func TestLabelBatchDeleteDryRunDoesNotCallAPI(t *testing.T) {
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
t.Fatalf("batch-delete dry-run should not call API, got: %s %s", r.Method, r.URL.Path)
})
defer server.Close()
if err := runLabelShortcut(t, server, "batch-delete", map[string]string{"ids": "7,8", "dry-run": "true"}); err != nil {
t.Fatalf("batch-delete dry-run failed: %v", err)
}
}
func TestLabelBatchDeleteDefaultsToDryRunWithoutYes(t *testing.T) {
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
t.Fatalf("batch-delete without --yes should not call API, got: %s %s", r.Method, r.URL.Path)
})
defer server.Close()
if err := runLabelShortcut(t, server, "batch-delete", map[string]string{"ids": "7,8"}); err != nil {
t.Fatalf("batch-delete default dry-run failed: %v", err)
}
}
func TestLabelBatchDeleteWithYesCallsEndpoints(t *testing.T) {
var paths []string
server := newLabelTestServer(t, func(w http.ResponseWriter, r *http.Request) {
if r.Method != "DELETE" {
t.Fatalf("got method %s, want DELETE", r.Method)
}
paths = append(paths, r.URL.Path)
writeJSON(t, w, map[string]interface{}{"status": 0, "message": "success"})
})
defer server.Close()
if err := runLabelShortcut(t, server, "batch-delete", map[string]string{"ids": "7,8,7", "yes": "true"}); err != nil {
t.Fatalf("batch-delete failed: %v", err)
}
if len(paths) != 2 {
t.Fatalf("got %d calls, want 2", len(paths))
}
assertEqual(t, paths[0], "/v1/owner/repo/issue_tags/7.json")
assertEqual(t, paths[1], "/v1/owner/repo/issue_tags/8.json")
}
func TestValidateColor(t *testing.T) {
valid := []string{"#1E90FF", "#abc", "#ABCDEF", "#000"}
for _, c := range valid {
if err := validateColor(c); err != nil {
t.Fatalf("expected %q to be valid, got %v", c, err)
}
}
invalid := []string{"red", "1E90FF", "#12", "#GGGGGG", "#1234", ""}
for _, c := range invalid {
if err := validateColor(c); err == nil {
t.Fatalf("expected %q to be invalid", c)
}
}
}
func TestLabelIDString(t *testing.T) {
assertEqual(t, labelIDString(float64(7)), "7")
assertEqual(t, labelIDString("9"), "9")
assertEqual(t, labelIDString(json.Number("11")), "11")
assertEqual(t, labelIDString(nil), "")
}
func TestParseLabelSpecs(t *testing.T) {
specs, err := parseLabelSpecs("bug:#ee0701:Bug fixes; docs::Documentation")
if err != nil {
t.Fatalf("parseLabelSpecs failed: %v", err)
}
if len(specs) != 2 {
t.Fatalf("got %d specs, want 2", len(specs))
}
assertEqual(t, specs[0].Name, "bug")
assertEqual(t, specs[0].Color, "#ee0701")
assertEqual(t, specs[0].Description, "Bug fixes")
assertEqual(t, specs[1].Name, "docs")
assertEqual(t, specs[1].Color, defaultLabelColor)
assertEqual(t, specs[1].Description, "Documentation")
}
func TestParseLabelSpecsRejectsInvalidInput(t *testing.T) {
invalid := []string{"", ":#ee0701:missing name", "bug:red:bad color"}
for _, value := range invalid {
if _, err := parseLabelSpecs(value); err == nil {
t.Fatalf("expected %q to be invalid", value)
}
}
}
func TestParseLabelIDList(t *testing.T) {
ids, err := parseLabelIDList("7, 8,7, 9")
if err != nil {
t.Fatalf("parseLabelIDList failed: %v", err)
}
want := []string{"7", "8", "9"}
if len(ids) != len(want) {
t.Fatalf("got %v, want %v", ids, want)
}
for i := range want {
assertEqual(t, ids[i], want[i])
}
}
func TestParseLabelIDListRejectsInvalidInput(t *testing.T) {
invalid := []string{"", "0", "-1", "abc", "7,abc"}
for _, value := range invalid {
if _, err := parseLabelIDList(value); err == nil {
t.Fatalf("expected %q to be invalid", value)
}
}
}
func runLabelShortcut(t *testing.T, server *httptest.Server, name string, args map[string]string) error {
t.Helper()
shortcut := findLabelShortcut(t, name)
ctx := &common.RuntimeContext{
Client: &client.Client{
HTTP: server.Client(),
BaseURL: server.URL,
},
Owner: "owner",
Repo: "repo",
Format: "json",
Args: args,
}
if ctx.Args == nil {
ctx.Args = map[string]string{}
}
return shortcut.Run(ctx)
}
func findLabelShortcut(t *testing.T, name string) *common.Shortcut {
t.Helper()
for _, shortcut := range Shortcuts() {
if shortcut.Name == name {
return shortcut
}
}
t.Fatalf("shortcut %q not found", name)
return nil
}
func newLabelTestServer(t *testing.T, handler http.HandlerFunc) *httptest.Server {
t.Helper()
return httptest.NewServer(handler)
}
func assertRequest(t *testing.T, r *http.Request, method, path string) {
t.Helper()
if r.Method != method || r.URL.Path != path {
t.Fatalf("got request %s %s, want %s %s", r.Method, r.URL.Path, method, path)
}
}
func decodeJSON(t *testing.T, r *http.Request) map[string]interface{} {
t.Helper()
var payload map[string]interface{}
if err := json.NewDecoder(r.Body).Decode(&payload); err != nil {
t.Fatalf("failed to decode request body: %v", err)
}
return payload
}
func writeJSON(t *testing.T, w http.ResponseWriter, payload interface{}) {
t.Helper()
w.Header().Set("Content-Type", "application/json")
if err := json.NewEncoder(w).Encode(payload); err != nil {
t.Fatalf("failed to write response: %v", err)
}
}
func assertEqual(t *testing.T, got interface{}, want interface{}) {
t.Helper()
if got != want {
t.Fatalf("got %v (%T), want %v (%T)", got, got, want, want)
}
}