From 5a2e0549c0a318e8af2b18da2132fa184f9ab987 Mon Sep 17 00:00:00 2001 From: whzy <2402686765@qq.com> Date: Sat, 27 Jun 2026 12:41:56 +0800 Subject: [PATCH] docs(feishu): keep validation evidence text-only --- docs/pr-draft.md | 33 ++++++++++ reports/FEISHU_SMOKE_20260627.md | 15 +++-- reports/FEISHU_SMOKE_EVIDENCE_20260627.md | 74 +++++++++++++++++------ 3 files changed, 97 insertions(+), 25 deletions(-) diff --git a/docs/pr-draft.md b/docs/pr-draft.md index 29dc902..6ff3c57 100644 --- a/docs/pr-draft.md +++ b/docs/pr-draft.md @@ -153,6 +153,10 @@ docs/FEISHU_PR_ACTIVITY_STRATEGY.md ## Evidence +Validation evidence is text-only in the repository. No screenshots or other +binary evidence are committed. If visual proof is requested, use redacted +screenshots pasted directly into the PR description, not repository files. + ```text reports/FEISHU_SMOKE_20260626.md reports/FEISHU_SMOKE_20260627.md @@ -161,6 +165,35 @@ reports/FEISHU_PERMISSION_MATRIX.md docs/FEISHU_OPENAPI_INVENTORY.md ``` +Text-only validation summary: + +```text +Real Feishu custom bot delivery passed: +- final English notify card: HTTP 200 / Feishu code 0 +- final English owner digest card: HTTP 200 / Feishu code 0 + +Real GitLink repository data: +- repository: Gitlink/gitlink-cli +- open issues analyzed: 9 +- open PRs analyzed: 166 +- PR lifecycle totals: open 166, merged 65, closed/rejected 74 + +Full PR review audit: +- PRs audited: 166 +- reviewed PRs: 4 +- unreviewed PRs: 162 +- needs re-review: 0 +- formal reviews: 4 +- reviewer comments: 6 +- submitter comments: 0 +- participant comments: 436 +- system events: 0 +- audit errors: 0 + +Risk source: +- high-risk PRs from metadata rule `security-sensitive keyword`: 13 +``` + ## Out of Scope - GitLink issue comment or close. diff --git a/reports/FEISHU_SMOKE_20260627.md b/reports/FEISHU_SMOKE_20260627.md index 62de5a6..60aad12 100644 --- a/reports/FEISHU_SMOKE_20260627.md +++ b/reports/FEISHU_SMOKE_20260627.md @@ -227,15 +227,14 @@ and is intentionally not duplicated into this Feishu change. ## Screenshot Status -The requested Windows computer-use connection failed twice during plugin -initialization: +Screenshot files are intentionally excluded from the repository. The project +owner asked that validation images not be committed because binary screenshots +remain in Git history and duplicate the text report evidence. -```text -failed to write kernel assets: path not found -``` - -No screenshot was fabricated or committed. Text evidence and API-derived -results remain the evidence for this run. See: +No screenshot was fabricated or committed. Visual proof, if needed, should be +redacted and pasted directly into the PR description instead of being stored in +the worktree. Text evidence and API-derived results remain the committed +evidence for this run. See: ```text reports/FEISHU_SMOKE_EVIDENCE_20260627.md diff --git a/reports/FEISHU_SMOKE_EVIDENCE_20260627.md b/reports/FEISHU_SMOKE_EVIDENCE_20260627.md index 3cfbf3c..2a4070c 100644 --- a/reports/FEISHU_SMOKE_EVIDENCE_20260627.md +++ b/reports/FEISHU_SMOKE_EVIDENCE_20260627.md @@ -8,24 +8,19 @@ Branch: feat/feishu-export-clean ``` -Base commit: +Head commit: ```text -d7812df1af49519f9eb84def218bd3d5a9fdf02f +138d886 feat(feishu): add full PR inventory and review attribution ``` -## Evidence Files +## Evidence Policy -| Evidence | Expected file | Status | Notes | -| --- | --- | --- | --- | -| Custom bot notify card | `reports/images/feishu-card-notify-redacted.png` | not captured | computer-use initialization failed | -| Owner digest card | `reports/images/feishu-owner-digest-redacted.png` | not captured | corrected card was sent successfully | -| DocX append result | `reports/images/feishu-docx-append-redacted.png` | not captured | corrected 11-block append passed | -| Bitable sync result | `reports/images/feishu-bitable-sync-redacted.png` | not captured | real upsert passed | -| Task create result | `reports/images/feishu-task-create-redacted.png` | not captured | historical result retained; creation was not repeated | -| Diagnostics output | `reports/images/feishu-diagnostics-terminal-redacted.png` | not captured | local and remote checks passed | +No screenshot or other binary evidence is committed in this branch. -No placeholder or fabricated image file is committed. +Visual validation can be attached directly to the PR description after manual +redaction when needed. It must not be stored under repository paths such as +`assets/validation-screenshots/`, `reports/images/`, or `docs/images/`. ## Text Evidence @@ -38,6 +33,52 @@ docs/FEISHU_OPENAPI_INVENTORY.md docs/FEISHU_PR_ACTIVITY_STRATEGY.md ``` +## PR Description Evidence + +The following text is safe to paste into the PR description instead of adding +image files: + +```text +Validation evidence is text-only in the repository. No screenshots are committed. + +Real Feishu custom bot delivery passed: +- final English notify card: HTTP 200 / Feishu code 0 +- final English owner digest card: HTTP 200 / Feishu code 0 + +Real GitLink repository data: +- repository: Gitlink/gitlink-cli +- open issues analyzed: 9 +- open PRs analyzed: 166 +- PR lifecycle totals: open 166, merged 65, closed/rejected 74 + +Full PR review audit: +- PRs audited: 166 +- reviewed PRs: 4 +- unreviewed PRs: 162 +- needs re-review: 0 +- formal reviews: 4 +- reviewer comments: 6 +- submitter comments: 0 +- participant comments: 436 +- system events: 0 +- audit errors: 0 + +Risk source: +- high-risk PRs from metadata rule `security-sensitive keyword`: 13 + +Tests passed: +- go test ./shortcuts/feishu +- go test ./shortcuts/workflow +- go test ./shortcuts +- go test ./... +- go build . +- go vet ./... + +Known separate issue: +- go run ./internal/i18n/cmd/check is blocked by an existing locale formatting + issue handled in a separate branch/PR. +``` + ## Redaction Checklist ```text @@ -50,12 +91,11 @@ docs/FEISHU_PR_ACTIVITY_STRATEGY.md [x] No task ID committed [x] No open_id / union_id committed [x] No personal account credential committed -[x] No unredacted screenshot committed +[x] No screenshot committed ``` ## Capture Rule -Screenshots may be added only after the Windows automation connection works and -each image is reviewed for resource IDs, personal identities, and unrelated -conversation content. Until then, this document records the missing visual -evidence explicitly rather than presenting a fake pass. +Screenshots may be used only outside the repository, for example pasted into the +PR description after redaction. If a local screenshot is temporarily captured, +keep it outside the worktree and delete it after the PR evidence is prepared.